WN,
> +QEMU_CAPS_SCSI_DISK_WWN,
> QEMU_CAPS_SECCOMP_SANDBOX);
Oops i fixed that trivial problem in your patch but forgot to
check for syntax, mea culpa !!!
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM searc
iday. Then hopefully we can release
next Monday or Tuesday.
Give it a try, let's chase bugs :-) !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualizatio
to cleanup;
> +
> +/* find matching entry - all specified attributes must match */
> + for (ii = 0; ii < ipdef->nhosts; ii++) {
> +if ((!host.mac ||
> + !virMacAddrCompare(host.mac, ipdef->hosts[ii].mac)) &&
> +
networkRefreshRadvd(network);
> + }
> + virNetworkObjUnlock(network);
> +}
> +}
> +
> static int
> networkAddMasqueradingIptablesRules(struct network_driver *driver,
> virNetworkObjPtr network,
ACK, sounds
ObjUnlock(network);
> +networkDriverUnlock(driver);
> + return ret;
> +}
> +
> static int networkStart(virNetworkPtr net) {
> struct network_driver *driver = net->conn->networkPrivateData;
> virNetworkObjPtr network;
> @@ -3057,6 +3160,7 @@ static virNetworkDri
onn = network->conn->privateData;
> virNetworkObjPtr privnet;
> @@ -5722,6 +5772,7 @@ static virNetworkDriver testNetworkDriver = {
> .networkCreateXML = testNetworkCreate, /* 0.3.2 */
> .networkDefineXML = testNetworkDefine, /* 0.3.2 */
> .networkUndefine = test
tr);
> -virBufferFreeAndReset(&configbuf);
> VIR_FREE(radvdpidbase);
> VIR_FREE(pidfile);
> return ret;
> }
>
> +#if 0
> +/* currently unused, so they cause a build error unless we #if them out */
> +static int
> +networkRefreshRadvd(
istPtr to search
> diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h
> index 0d37a8b..c8ed2ea 100644
> --- a/src/conf/network_conf.h
> +++ b/src/conf/network_conf.h
> @@ -326,6 +326,14 @@ int virNetworkSetBridgeName(const virNetworkObjListPtr
> nets,
>
&
t a/src/test/test_driver.c b/src/test/test_driver.c
> index fbd8ed0..1bd0d61 100644
> --- a/src/test/test_driver.c
> +++ b/src/test/test_driver.c
> @@ -579,7 +579,7 @@ static int testOpenDefault(virConnectPtr conn) {
>
> if (!(netdef = virNetworkDefParseString(defaultNetworkXML)
> +error:
> +virDispatchError(network->conn);
> +return -1;
> +}
> +
> +/**
> * virNetworkCreate:
> * @network: pointer to a defined network
> *
> diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms
> index d965c7f..2c924d5 100644
> ---
intindex;
> +remote_nonnull_string xml;
> +u_int flags;
> +};
> struct remote_network_create_args {
> remote_nonnull_network net;
> };
> @@ -2406,4 +2414,5 @@ enum remote_procedure {
>
est.c
+++ b/tests/qemuhelptest.c
@@ -845,6 +845,7 @@ mymain(void)
QEMU_CAPS_SCSI_LSI,
QEMU_CAPS_VIRTIO_SCSI_PCI,
QEMU_CAPS_BLOCKIO,
+ QEMU_CAPS_SCSI_DISK_WWN,
QEMU_CAPS_SECCOMP_SANDBOX);
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
--
Daniel Vei
@@ -471,6 +471,10 @@ mymain(void)
> DO_TEST("disk-scsi-disk-split",
> QEMU_CAPS_DRIVE, QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG,
> QEMU_CAPS_SCSI_CD, QEMU_CAPS_SCSI_LSI,
> QEMU_CAPS_VIRTIO_SCSI_PCI);
> +DO_TEST("disk-scsi-disk-wwn",
> +QEMU_CAPS_DRI
= 107, /* Is ide-drive.wwn available? */
> +QEMU_CAPS_SCSI_DISK_WWN = 108, /* Is scsi-disk.wwn available? */
>
> QEMU_CAPS_LAST, /* this must always be the last item */
> };
ACK, but we will need to make sure that capability is still handled
44
> --- a/docs/schemas/nodedev.rng
> +++ b/docs/schemas/nodedev.rng
> @@ -245,12 +245,6 @@
>
>
>
> -
> -
> - [0-9a-fA-F]{16}
> -
> -
> -
>
>
>fc_host
Looks fine, ACK,
Daniel
--
Daniel Veillard |
rValidateWWN(const char *wwn) {
> +int i;
> +
> +for (i = 0; wwn[i]; i++)
> +if (!c_isxdigit(wwn[i]))
> +break;
> +
> +if (i != 16 || wwn[i]) {
> +virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> + _("Malformed ww
that service, in that case i will
try it, but not right now :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-l
On Mon, Sep 17, 2012 at 02:32:03PM +0200, Wido den Hollander wrote:
> On 17-09-12 14:20, Daniel Veillard wrote:
> >On Mon, Sep 17, 2012 at 10:35:02AM +0200, Wido den Hollander wrote:
[...]
> >>However, maven central didn't fetch 0.4.9 yet. No clue why it ain't
>
On Mon, Sep 17, 2012 at 10:35:02AM +0200, Wido den Hollander wrote:
>
>
> On 14-09-12 18:09, Daniel Veillard wrote:
> >On Fri, Sep 14, 2012 at 05:36:10PM +0200, Wido den Hollander wrote:
> >>On 09/14/2012 04:59 PM, Daniel Veillard wrote:
> >[...]
> >>&g
20 +++
> src/rpc/gendispatch.pl |3 +
> src/uml/uml_driver.c|2 +
> src/xen/xen_driver.c|3 +
> tools/virsh-host.c | 116 ++
> tools/virsh.pod |8 ++
> 21 files changed, 889 insertions
On Fri, Sep 14, 2012 at 05:36:10PM +0200, Wido den Hollander wrote:
> On 09/14/2012 04:59 PM, Daniel Veillard wrote:
[...]
> >http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.pom
> >doesn't seems to have any section though ...
> >
On Fri, Sep 14, 2012 at 04:18:21PM +0200, Wido den Hollander wrote:
> On 09/13/2012 02:19 PM, Daniel Veillard wrote:
> >On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote:
> >>On 09/10/2012 03:23 PM, Daniel Veillard wrote:
> >>>On Mon, Sep 10, 2012
On Fri, Sep 14, 2012 at 04:18:21PM +0200, Wido den Hollander wrote:
> On 09/13/2012 02:19 PM, Daniel Veillard wrote:
> >On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote:
> >>On 09/10/2012 03:23 PM, Daniel Veillard wrote:
> >>>On Mon, Sep 10, 2012
On Fri, Sep 14, 2012 at 04:01:55PM +0200, Wido den Hollander wrote:
> On 09/13/2012 02:19 PM, Daniel Veillard wrote:
[...]
> >>Come to think of it, a 0.4.9 release under MIT would however be
> >>preferable for CloudStack 4.0.
> >
> > Okay, you get it, it'
On Fri, Sep 14, 2012 at 03:34:29PM +0800, Hu Tao wrote:
> On Fri, Sep 14, 2012 at 03:10:13PM +0800, Daniel Veillard wrote:
> > On Fri, Sep 14, 2012 at 02:24:15PM +0800, Hu Tao wrote:
> > > memset before virResetError will cause memory leak.
> > >
> > > virRese
*
> @@ -6116,6 +6239,8 @@ static PyMethodDef libvirtMethods[] = {
> {(char *) "virDomainBlockPeek", libvirt_virDomainBlockPeek,
> METH_VARARGS, NULL},
> {(char *) "virDomainMemoryPeek", libvirt_virDomainMemoryPeek,
> METH_VARARGS, NULL},
>
},
> {"nodecpustats", cmdNodeCpuStats, opts_node_cpustats, info_nodecpustats,
> 0},
> {"nodeinfo", cmdNodeinfo, NULL, info_nodeinfo, 0},
> {"nodememstats", cmdNodeMemStats, opts_node_memstats, info_nodememstats,
> 0},
> diff --git a/tools/
enUnifiedDomainOpenConsole, /* 0.8.6 */
> .isAlive = xenUnifiedIsAlive, /* 0.9.8 */
> .nodeSuspendForDuration = nodeSuspendForDuration, /* 0.9.8 */
> +.nodeGetMemoryParameters = nodeGetMemoryParameters, /* 0.10.2 */
> +.nodeSetMemoryParameters = nodeSetMemoryParameters, /* 0.10.2 */
> };
goto cleanup;
> +
> +if ((tmp = strchr(buf, '\n')))
> +*tmp = '\0';
> +
> +if (virStrToLong_ull(buf, NULL, 10, &full_scans) < 0) {
> +virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> +
esn't cost much to increase that a bit, on the other hand
if we hit the limit raising it becomes a deployment problem.
I would raise that arbitrarilly a bit higher (32 or 64) to avoid the
issue in the long term.
> /* UUID. VIR_UUID_BUFLEN definition comes from libvirt.h */
>
ValidateSet(conn, params, nparams) < 0)
> +goto error;
> +
> +if (conn->driver->nodeSetMemoryParameters) {
> +int ret;
> + ret = conn->driver->nodeSetMemoryParameters(conn, params,
> + np
l/uml_driver.c|2 +
> src/xen/xen_driver.c|3 +
> tools/virsh-host.c | 116 ++
> tools/virsh.pod |8 +
> 21 files changed, 972 insertions(+), 1 deletions(-)
>
> --
> 1.7.7.3
>
> --
> libvir-list maili
API, we can't justify behaviour just
on how it is used internally.
NACK, at least the explanation need to be fixed
What is the scenario for the leak ?
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engi
nBoot)
> VIR_ENUM_DECL(virDomainFeature)
> +VIR_ENUM_DECL(virDomainApicEoi)
> VIR_ENUM_DECL(virDomainLifecycle)
> VIR_ENUM_DECL(virDomainLifecycleCrash)
> VIR_ENUM_DECL(virDomainPMState)
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 0494e1f..5
gful in different
ways.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@redhat.com
https://
els-ct-simple.xml
> @@ -0,0 +1,27 @@
> +
> + 1010
> + 88576506-d611-41c2-b6b6-c9043704a0dd
> +
> + 262144
> + 262144
> + 8
> +
> + exe
> + /sbin/init
> +
> +
> + destroy
> + destroy
> + destroy
> +
> +
> +
>
as libvirt-java-0.4.9.tar.gz and rpms at
ftp://libvirt.org/libvirt/java
it's also tagged in git. Content is slim:
- Change Licence to MIT and release 0.4.9 (Daniel Veillard)
- Update the maven jar coordinates (Daniel Veillard)
(but it is broken one month later no mirror seems to export
On Mon, Sep 10, 2012 at 03:46:43PM +0200, Wido den Hollander wrote:
> On 09/10/2012 03:23 PM, Daniel Veillard wrote:
> >On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Hollander wrote:
> >>On 09/10/2012 02:29 PM, Daniel Veillard wrote:
> >>>any idea how to tell
On Wed, Sep 12, 2012 at 04:32:52PM +0400, Dmitry Guryanov wrote:
> On 120912 16:14:47, Daniel Veillard wrote:
> > On Mon, Sep 10, 2012 at 07:22:44PM +0400, Dmitry Guryanov wrote:
> > > Fix code, which checks what is changed in virDomainDef structure.
> > > It l
The virt and res will not increase.
> I think we must provide the free functions for all the memory allocated by
> libvirt.
Okay, can you work on making a patch ? To be honnest I'm very unlikely
to have time for this in the short term,
Daniel
--
Daniel Veillard | libxml Gnome
BootDevs != 0 ||
> +!STREQ_NULLABLE(old->os.init, new->os.init) ||
> +(new->os.initargv != NULL && new->os.initargv[0] != NULL)) {
> +
> +virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
> + _("changing OS parameter
or 25,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@redhat.com
https
That patch has a problem, it doesn't carry the expected code in
domain parsing but on the other hand include a gnulib version rebase,
please fix and repost, I'm keeping your patch 1, 2 and 3 (amended
with the indentation fix in a local git branch), if you can send me a
correct 4/4 the
einfo.cpus;
> +def->maxvcpus = def->vcpus;
> +} else {
> +parallelsParseError();
> +goto cleanup;
> +}
> +} else {
> parallelsParseError();
> goto cleanup;
> }
> -def->vcpus = x;
> -
in_name)
> int ret = -1;
>
> jobj = parallelsParseOutput(PRLCTL, "list", "-j", "-a", "-i", "-H",
> -"--vmtype", "vm", domain_name, NULL);
> +"--v
ommandFree(cmd);
> -if (ret)
> +if (ret && outbuf)
> VIR_FREE(*outbuf);
> return ret;
> }
> --
> 1.7.1
ACK, the two patches are no-brainer fixes, pushed, thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.or
s ?
If not that mean deleting one of the host at random. Is that okay ? I
would think yes. Would that be equivalent to
virNetworkUpdate(net, VIR_NETWORK_SECTION_IP_DHCP_HOST, 0,
NULL,
VIR_NETWORK_UPDATE_DELETE | VIR_NETWORK_UPDATE_LIVE
On Mon, Sep 10, 2012 at 03:00:57PM +0200, Wido den Hollander wrote:
> On 09/10/2012 02:29 PM, Daniel Veillard wrote:
> >any idea how to tell the main maven site to refetch ? Even though we
> >added the checksums, http://search.maven.org still don't show 0.4.8
> >
>
On Thu, Sep 06, 2012 at 04:47:45PM +0200, Wido den Hollander wrote:
> On 09/06/2012 10:38 AM, Daniel Veillard wrote:
> > it's maven which should fetch data from libvirt.org
> >and i though I had updated everything as needed:
> >
> >http://libvirt.org/
On Fri, Sep 07, 2012 at 01:29:25PM +0200, Ján Tomko wrote:
> On 09/07/12 05:25, Daniel Veillard wrote:
> >
> > The problem is that libvirt and qemu releases are a priori not
> > tied, doing what you suggest would mean to try to guess the actual
> > qemu version used b
On Thu, Sep 06, 2012 at 11:53:06AM -0400, Corey Bryant wrote:
>
>
> On 09/06/2012 02:45 AM, Daniel Veillard wrote:
> >On Thu, Sep 06, 2012 at 02:27:19PM +0800, Daniel Veillard wrote:
> >>On Mon, Sep 03, 2012 at 02:03:39PM +0200, Ján Tomko wrote:
> >>>QEMU (
think we need a followup patch for the test area, we need
to extend tests/qemuhelpdata/ and tests/qemuhelptest.c to detect
the new feature, and check it's processed and exposed correctly,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan..
On Thu, Sep 06, 2012 at 05:08:21PM +0200, Wido den Hollander wrote:
> On 09/06/2012 05:04 PM, Daniel Veillard wrote:
> >On Thu, Sep 06, 2012 at 04:47:45PM +0200, Wido den Hollander wrote:
> >>A tcpdump shows me it is looking for:
> >>* libvirt-0.4.8.pom.md5
&
On Thu, Sep 06, 2012 at 04:47:45PM +0200, Wido den Hollander wrote:
> On 09/06/2012 10:38 AM, Daniel Veillard wrote:
> I added libvirt.org as a manual repository and while fetching the
> dependencies I saw:
>
> [INFO] snapshot org.apache.cloudstack:xapi:5.6.100-1-SNAPSHOT:
> ch
ed in some ways, I take patches !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@re
atch(Exception e){}
> }
> }
Then it's a java bug. The loop doesn't call or use libvirt in any way.
If it crashes in the loop it's java crashing to me !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veilla
2/org/libvirt/libvirt/0.4.8/
http://libvirt.org/maven2/org/libvirt/libvirt/maven-metadata-local.xml
if you can get an idea why it is not fetching then I will fix,
but I have tried to set everything up, and didn't got feedback that
it was broken or anything,
Daniel
--
Daniel Veillard |
malloc(sizeof(char) * 1);
> virConnectGetVersion(conn, &version);
> virConnectGetVersion(conn, &version1);
> free(hostname);
> sleep(1);
> }
> return;
> }
Maybe you need to increase the stack or memory size of you java
> #ifdef __linux__
> diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c
> index a29e4b2..4efb98d 100644
> --- a/src/util/virnetdevbridge.c
> +++ b/src/util/virnetdevbridge.c
> @@ -31,10 +31,8 @@
>
> #include
> #include
> +#include
>
&g
efined(__APPLE__)
> # define DYNLIB_NAME "VBoxXPCOMC.dylib"
This one is a no-brainer, ACK and pushed,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
htt
.h. linux/if_bridge.h and linux/if_tun.h are
> required. Obviously these files are missing on Solaris platform. Anybody
> can help how to solve this issue?
I'm not sure we still have an active maintainer on Solaris, John Levon
didn't posted here for ages ...
Daniel
--
Daniel Ve
On Thu, Sep 06, 2012 at 02:27:19PM +0800, Daniel Veillard wrote:
> On Mon, Sep 03, 2012 at 02:03:39PM +0200, Ján Tomko wrote:
> > QEMU (since 1.2-rc0) supports setting up a syscall whitelist through
> > libseccomp on linux kernel from 3.5-rc1. This is enabled by specifying
> >
level.
In general, if available sandboxing should be turned on unless we hit
a bug, so if it work as expected, it should always be on, which to me
would be an indication to have that as a global default for the driver
(and on by default).
If you have to rely on the user explicit set
t; goto out;
> }
> +
> +/* Restore the config space of devices behind the same bus */
> +if (list) {
> +for (i = 0; i < list->count; i++) {
> +pciDevice *pci = list->devs[i];
> +
> +if (pciWrite(pci, 0, config_spaces[i
ML networking
related data to the XML passed along the domain in the migration
- one patch using that generic mechanism to carry the OpenVSwitch
per port data
The first part defining the data extension etc ought to be generic
(but probably network related) and the second part specific
+)
I was hoping to see feedback on actual users, but since we are at v6
and nobody replied, let's push them and see
ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
ht
On Tue, Sep 04, 2012 at 09:03:22PM +, Kyle Mestery (kmestery) wrote:
> On Aug 31, 2012, at 9:09 AM, Daniel Veillard wrote:
> > On Fri, Aug 31, 2012 at 01:32:34PM +, Kyle Mestery (kmestery) wrote:
> >> On Aug 30, 2012, at 10:23 PM, Daniel Veillard wrote:
> >>>
letest.c
> @@ -79,7 +79,7 @@ mymain(void)
> #ifdef WITH_NWFILTER
> TEST("nwfilter", NULL);
> #endif
> -#ifdef WITH_NETCF
> +#ifdef WITH_INTERFACE
> TEST("interface", NULL);
> #endif
> #ifdef WITH_QEMU
> diff --git a/tools/virsh.c
th)) {
> + !grep_cmd_path) {
> VIR_ERROR(_("essential tools to support ip(6)tables "
>"firewalls could not be located"));
> VIR_FREE(iptables_cmd_path);
> @@ -4333,7 +4328,6 @@ ebiptablesDriverInit(bool privileged)
>
On Mon, Sep 03, 2012 at 08:37:13AM +0200, Guido Günther wrote:
> On Fri, Aug 31, 2012 at 02:36:07PM +0800, Daniel Veillard wrote:
> > On Thu, Aug 30, 2012 at 08:44:57PM +0200, Guido Günther wrote:
> > > On Wed, Aug 29, 2012 at 11:19:42PM +0800, Daniel Veillard wrote:
> >
On Fri, Aug 31, 2012 at 04:31:56PM +0200, Martin Kletzander wrote:
> On 08/31/2012 04:29 PM, Daniel Veillard wrote:
> > On Fri, Aug 31, 2012 at 04:09:39PM +0200, Martin Kletzander wrote:
> > Hum, too bad that would have been good in 0.10.1, but after all
> > 0.10.2 shoul
gt;> vm->def->graphics[0]->data.spice.port == -1) {
> >> -port = qemuProcessNextFreePort(driver,
> >> QEMU_REMOTE_PORT_MIN);
> >> +port = qemuProcessNextFreePort(driver,
> >> driver->remotePortMin
On Fri, Aug 31, 2012 at 01:32:34PM +, Kyle Mestery (kmestery) wrote:
> On Aug 30, 2012, at 10:23 PM, Daniel Veillard wrote:
> > On Thu, Aug 30, 2012 at 04:38:06PM -0400, Kyle Mestery wrote:
[...]
> > Still there is something which looks wrong, if we don't have a profileID
mu: Remove redundant parameter from qemuAgentSend (Jiri Denemark)
- network: get vlan info for Open vSwitch interfaces from proper source (Laine
Stump)
- Small cleanup on previous patch (Daniel Veillard)
- Fix a crash when using Open vSwitch virtual ports (Kyle Mestery)
- qemu: Sort the numa params on
double diff_ms = (((after.tv_sec - before.tv_sec) * 1000.0) +
> >((after.tv_usec - before.tv_usec) / 1000.0));
> >
> > vshPrint(ctl, _("\n(Time: %.3f ms)\n\n"), diff_ms);
>
> ACK
Pushed :-)
Daniel
--
Danie
> + _("missing security model "
> + "when using multiple labels"));
> goto error;
> }
> }
> }
> +
> return 0;
>
> error:
> @@ -8170,7 +8189,7 @@
char *baselabel;/* base name of label string */
> int type; /* virDomainSeclabelType */
> bool norelabel;
> +bool implicit; /* true if seclabel is auto-added */
> };
>
Okay, ACK, the WIP version we both tested, I'm pushing it
Daniel
On Fri, Aug 31, 2012 at 06:37:29AM -0400, Stefan Berger wrote:
> On 08/30/2012 11:33 PM, Daniel Veillard wrote:
> >On Thu, Aug 30, 2012 at 02:29:49PM -0400, Stefan Berger wrote:
> >>Index: libvirt-acl/src
MAX_CPU *
size(counter) . A counter should not be more than 20 char (very large
already) and MAX_CPU of 4096 doesn't sound crazy though I'm sure we will
have bigger. So 100KB is already a maxed out value ... for that test
case.
Since virFileReadAll will allocate (a bit more) up t
, 10, &cpu_time) < 0) {
> @@ -13580,7 +13583,7 @@ qemuDomainGetPercpuStats(virDomainPtr domain,
> }
>
> sum_cpu_pos = sum_cpu_time;
> -for (i = 0; i <= max_id; i++) {
> + for (i = 0; i <= id; i++) {
> if (!map[i])
> cpu_time =
pported, so claim success */
>
> @@ -656,10 +669,8 @@ int qemuSetupCgroupForEmulator(struct qemud_driver
> *driver,
> }
>
> for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) {
> -if (!qemuCgroupControllerActive(driver, i)) {
> - VIR_WAR
mode I or I.
> I<--config> indicates the changes will affect the next boot of the domain,
> for compatibility purposes, I<--persistent> is alias of I<--config>.
ACK
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veilla
<emulatorpin cpuset="1-3"/%gt;
> +<emulatorpin cpuset="1-3"/>
> <shares>2048</shares>
> <period>100</period>
> <quota>-1</quota>
ACK
unfortunately that's an error the XML parser can't find :
On Thu, Aug 30, 2012 at 08:44:57PM +0200, Guido Günther wrote:
> On Wed, Aug 29, 2012 at 11:19:42PM +0800, Daniel Veillard wrote:
> > I was a bit afraid of the .0 effect on release name, but we really
> > have a number of problem with 0.10.0 that ought to be fixed in a
>
r: missing security model when
using multiple labels
FAILED
...
thinkpad:~/libvirt/tests -> grep -C2 seclabel
qemuxml2argvdata/qemuxml2argv-seclabel-none.xml
thinkpad:~/libvirt/tests ->
So the new code following your patch is unable to parse the construct
I just can't
->ether_dhost) == 0 ||
> + /* allow Broadcast replies from DHCP server */
> + virMacAddrIsBroadcastRaw(ether_hdr->ether_dhost)) {
> /* packets to the VM */
> if (etherType == ETHERTYPE_IP &&
>
" -p ipv4 --ip-protocol udp"
> + " %s"
> + " --ip-sport 67 --ip-dport 68"
> + " -j ACCEPT") CMD_SEPARATOR
> +
drCompare;
> virMacAddrFormat;
> virMacAddrGenerate;
> virMacAddrGetRaw;
> +virMacAddrIsBroadcastRaw;
> virMacAddrIsMulticast;
> virMacAddrIsUnicast;
> virMacAddrParse;
ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
t;, "set", "Interface", ifname, ifaceid_ex_id,
> "--", "set", "Interface", ifname, vmid_ex_id,
Okay, ACK,
pushed, thanks !
Still there is something which looks wrong, if we don't have a profileID
why do we end up
le("xen");
> -# endif
> -# ifdef WITH_LIBXL
> -virDriverLoadModule("libxl");
> -# endif
> #else
> # ifdef WITH_NETWORK
> networkRegister();
> @@ -416,6 +419,9 @@ static void daemonInitialize(void)
> # ifdef WITH_NWFILTER
> nwfilterRegiste
else
> +} else {
> seclabel->type = VIR_DOMAIN_SECLABEL_NONE;
> +seclabel->norelabel = true;
> +}
> }
>
> if ((seclabel->type == VIR_DOMAIN_SECLABEL_NONE) &&
ACK,
Daniel
--
Daniel Veillard
/src/xen/xend_internal.c
> index 99def42..984f040 100644
> --- a/src/xen/xend_internal.c
> +++ b/src/xen/xend_internal.c
> @@ -2303,7 +2303,7 @@ xenDaemonDomainPinVcpu(virDomainPtr domain, unsigned
> int vcpu,
> }
> def->cputune.nvcpupin = 0;
>
}
> -VIR_FREE(ret);
> virReportOOMError();
>
> return NULL;
Whoops, ACK ! Please push
BTW I'm unclear what our prefered style is for
if (ret) {
...
VIR_FREE(ret);
}
vs
if (ret) {
...
}
VIR_FREE(ret);
because that pattern appears twice in the rep
2
Let's try to get the new API fixed for the next release then
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
-
> -if (!hasDAC && driver->privileged) {
> +if (driver->privileged) {
> if (!(mgr = virSecurityManagerNewDAC(QEMU_DRIVER_NAME,
> driver->user,
> driver->
e, &net->mac,
> vm->uuid, NULL,
>
> virDomainNetGetActualVirtPortProfile(net),
> - &net->vlan,
> + virDomainNetGetActua
t;trunk == true) {
>
> 'cond == true' as a condition is a pointless change, 'cond' is sufficient.
Okay, i pushed a tiny cleanup for this,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com
"--", "set", "Interface", ifname, vmid_ex_id,
> @@ -135,7 +134,8 @@ int virNetDevOpenvswitchAddPort(const char *brname, const
> char *ifname,
>
> ret = 0;
> cleanup:
> -VIR_FREE(buf);
> +if (virBufferUse(&
virSecurityManagerPtr primary)
> -{
> -virSecurityStackAddPrimary(mgr, primary);
> -}
> -
> -void virSecurityStackSetSecondary(virSecurityManagerPtr mgr,
> - virSecurityManagerPtr secondary)
> -{
> -virSecurityStackA
> +params[swap_hard_limit_index] = param;
> +}
> +} else {
> +if (hard_limit_index > swap_hard_limit_index) {
> +param = params[hard_limit_index];
> +params[hard_limit_index
601 - 700 of 6302 matches
Mail list logo
