a problem,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@redhat.com
On Wed, Mar 14, 2012 at 03:10:46AM -0600, Eric Blake wrote:
> On 03/14/2012 03:02 AM, Daniel Veillard wrote:
> > On Wed, Mar 14, 2012 at 03:06:38PM +0800, Alex Jia wrote:
> >> On 03/14/2012 01:57 PM, Guannan Ren wrote:
> >>>dom.cPUStats(True, 0)
> >> I&#
d you fix this in the patch :-) ?
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list
can't be parsed
programmatically as a replacement of the original ones
2/ the data may be misunderstood and lead to erroneous
decision for example a schedule may start to stack 2 time more
load on my machine based on the difference of report.
So I'm a bit worried about applying it a
76,7 @@ qemuMonitorJSONBlockIoThrottleInfo(virJSONValuePtr result,
if ((inserted = virJSONValueObjectGet(temp_dev, "inserted")) == NULL ||
inserted->type != VIR_JSON_TYPE_OBJECT) {
qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-
On Fri, Mar 09, 2012 at 06:49:20PM +0800, Osier Yang wrote:
> On 2012年03月09日 16:55, Daniel Veillard wrote:
> >On Mon, Mar 05, 2012 at 06:25:39PM +0800, Osier Yang wrote:
> >>This patch introduces a new event type for the QMP event
> >>DEVICE_TRAY_MOVED, which occurs w
olean XML element . Codes are refactored
> accordingly.
>
> * v1 overrides the cpuset specified by 2,
> v2 doesn't do that, but just silently ignored.
>
> * xml2xml test is added
A relatively long patch, but I went through it and it looks okay, ACK
from me
> http://downloads.linux.hp.com/~lts/Libvirt/
>
> I have installed the patched libvirt on a fedora 16 system and successfully
> defined and launched a vm. Testing in progress. I'll place an annotated
> test log ont the site above when complete.
>
> I also need to
t; 0)
> +goto error;
> +break;
> +
> +case QEMU_PROBE_CPU_MODELS:
> +if (qemuCapsCacheCPUModels(emulator) != 0 ||
> +virBitmapSetBit(emulator->cachedProbes, QEMU_PROBE_CPU_MODELS) <
> 0)
> +goto error;
> +
peString(virBufferPtr buf, const char *format,
> const char *str);
> diff --git
> a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.args
> b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.args
> index 4b3f816..c6089e1 100644
> --- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.args
a-d65c16db1809
> + 219136
> + 219136
> + 1
> +
> +hvm
> +
> +
> +
> + destroy
> + restart
> + destroy
> +
> +/usr/bin/qemu
> +
> +
> +
> +
> +
> +
> +
> +
> +
&
ayOpened;
> +if (virDomainSaveStatus(driver->caps, driver->stateDir, vm) < 0) {
> +VIR_WARN("Unable to save status on vm %s after tray moved event",
> + vm->def->name);
> +}
> }
>
> virDomainOb
t; @@ -13,7 +13,7 @@
>
>
>
> -
> +
>
>
>
> diff --git a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-2.xml
> b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-2.xml
> index 2e07963..e98bb58 100644
> --- a/tests/vmx2xmldata/vmx2xml-e
On Mon, Mar 05, 2012 at 06:25:40PM +0800, Osier Yang wrote:
> Example XML:
>
>
>
>
>
>
> ---
> docs/formatdomain.html.in | 13 +
> docs/schemas/domaincommon.rng |8
> 2 files changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/
remoteDomainBuildEventDiskChange,
>sizeof(remote_domain_event_disk_change_msg),
>(xdrproc_t)xdr_remote_domain_event_disk_change_msg },
> +{ REMOTE_PROC_DOMAIN_EVENT_TRAY_MOVED,
> + remoteDomainBuildEventTrayMoved,
> + sizeof(remote_domain_event_tray_moved_msg),
> + (xdrp
it;a=commit;h=a4203c516530a81166c5f9525fbc16d0d9a1bd11
I don't think it was submitted yet to autot...@test.kernel.org,
Lucas do you think that's ready ?
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM
On Thu, Mar 08, 2012 at 07:38:57PM +0800, Osier Yang wrote:
> Since VIR_DOMAIN_AFFECT_{LIVE,CONFIG,CURRENT} was created,
> all new virsh commands use "--config" to represents the
> persistent changing. This patch add "--config" option
> for the old commands which still use "--persistent",
> and "--
work right (the search is not setup yet and I need to reaactivate
various crons, but nearly everything should just work (TM))
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillar
B: Not all algorithms of wiping are expected to work, it depends on
> > concrete B version.
>
> I'd word this slightly differently:
>
> B the availability of algorithms may be limited by the version
> of the C binary installed on the host.
yeah, that's
9.10
http://libvirt.org/git/?p=libvirt.git;a=commit;h=b79ba8382e2205c416d7c4836ac9ee08c72e2c56
use that construct instead but don't ask us to modify description
because it is in use already for complex use case and I will definitely
not modify that data on input, it would be a terr
89 100644
> >--- a/tools/virsh.pod
> >+++ b/tools/virsh.pod
> >@@ -2081,6 +2081,8 @@ B
> >pfitzner33 - Roy Pfitzner's 33-random-pass method: random x33.
> >random - 1-pass pattern: random.
> >
> >+B: Not all algorithms of wiping are expected to w
7 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -72,7 +72,6 @@ EXTRA_DIST = \
nwfilterxml2xmlout \
oomtrace.pl \
qemuhelpdata \
- qemumonitortest \
qemuxml2argvdata \
qemuxml2xmloutdata \
qemuxmlnsdata \
--
Daniel Veillard
On Mon, Feb 20, 2012 at 10:05:02AM -0700, Eric Blake wrote:
> On 02/20/2012 03:15 AM, Daniel Veillard wrote:
> > On Mon, Feb 20, 2012 at 09:59:23AM +0100, Jiri Denemark wrote:
> >> On Mon, Feb 20, 2012 at 11:26:50 +0800, Daniel Veillard wrote:
> >>> diff --git a
On Mon, Feb 20, 2012 at 09:59:23AM +0100, Jiri Denemark wrote:
> On Mon, Feb 20, 2012 at 11:26:50 +0800, Daniel Veillard wrote:
> > diff --git a/src/util/virfile.h b/src/util/virfile.h
> > index ec1e90b..184677c 100644
> > --- a/src/util/virfile.h
> > +++ b/src/util/vir
On Tue, Feb 14, 2012 at 07:59:16PM +1100, Justin Clift wrote:
> On 14/02/2012, at 7:31 PM, Daniel Veillard wrote:
> > On Tue, Feb 14, 2012 at 07:18:32PM +1100, Justin Clift wrote:
> >> On 14/02/2012, at 4:15 PM, Daniel Veillard wrote:
> >>> As planned I made the rele
ot;::" ls32
/ [ *5( h16 ":" ) h16 ] "::" h16
/ [ *6( h16 ":" ) h16 ] "::"
ls32= ( h16 ":" h16 ) / IPv4address
; least-significant 32 bits of address
h16
On Tue, Feb 14, 2012 at 07:18:32PM +1100, Justin Clift wrote:
> On 14/02/2012, at 4:15 PM, Daniel Veillard wrote:
> > As planned I made the release yesterday, it is tagged in git and
> > available at:
> > ftp://libvirt.org/libvirt/
> > both as tarball and signed rp
(Daniel Veillard)
- build: fix bootstrap on fresh clone (Eric Blake)
- tests: Add qemuxml2argv tests for PPC64 pseries machine (Michael Ellerman)
- tests: Teach qemuxml2argvtest about spapr-vio addresses (Michael Ellerman)
- Disable netcf if building without libvirtd (Daniel P. Berrange)
- build: fix
StrToLong_ll(pidstr, &endptr, 10, &pid_value) < 0 ||
> +!(*endptr == '\0' || c_isspace(*endptr)) ||
> (pid_t) pid_value != pid_value) {
> rc = -1;
> goto cleanup;
Okay, thanks for chasing this last minute issue, ACK
please pus
On Mon, Feb 13, 2012 at 02:24:05PM +0100, Paolo Bonzini wrote:
> On 02/08/2012 07:59 AM, Daniel Veillard wrote:
> >ftp://libvirt.org/libvirt/libvirt-0.9.10-rc2.tar.gz
> >the rpms are available too and the git tree is tagged.
> >
> > Hopefully that one is more usabl
On Mon, Feb 06, 2012 at 03:21:21PM +0800, Daniel Veillard wrote:
> We are now entering the freeze for libvirt-0.9.10
> Hopefully all the API changes needed for that version are
> already commited to git head.
Okay I made an rc2 release with the python bindings fix (thanks !)
Try to do an rpmbuild --rebuild libvirt-0.9.10-rc1.tar.gz to get
a list of possible missing build packages. However I don't see how
that could possibly affect qemuxml2argvtest ...
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfin
think I will make an release candidate 2 tarball on Wednesday, and
I'm hoping for a final release next Monday the 13th.
Please give it a try !
thanks in advance,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search e
tats[i].val);
> +if (stats[i].tag == VIR_DOMAIN_MEMORY_STAT_RSS)
> +vshPrint (ctl, "rss %llu\n", stats[i].val);
> }
>
> virDomainFree(dom);
Looks fine, and works for me, ACK too
I'm pushing the 2 patches but please provide one missing item:
th
goto cleanup;
> @@ -3648,6 +3658,7 @@ qemudDomainGetVcpus(virDomainPtr dom,
> if (priv->vcpupids != NULL &&
> qemudGetProcessInfo(&(info[i].cpuTime),
> &(info[i].cpu),
> +
if (priv->vcpupids != NULL &&
> qemudGetProcessInfo(&(info[i].cpuTime),
> &(info[i].cpu),
> +NULL,
> vm->pi
t; endif
> endif
> EXTRA_DIST += $(LXC_CONTROLLER_SOURCES)
ACK, assuming you didn't push yet as a build breaker !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veilla
p but there is absolutely no
garantee. On linux we could try to be a bit smart and detect completely
stuck guests by looking at /proc/$pid/io rchar and wchar if that doesn't
move at all in the iterations we can probably consider it dead, if
it does well we can be pretty sure that SIGKILL will lo
> /* Stop autodestroy in case guest is restarted */
> qemuProcessAutoDestroyRemove(driver, vm);
> diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h
> index 062d79e..4ae6b4b 100644
> --- a/src/qemu/qemu_process.h
> +++ b/src/qemu/qemu_process.h
> @@ -1,7 +
ys
to try to push features to git before 0.9.10 freeze,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list ma
onn->privateData;
> virDomainObjPtr vm;
> +int state;
> int ret = -1;
>
> vmwareDriverLock(driver);
> @@ -914,7 +969,10 @@ vmwareDomainGetInfo(virDomainPtr dom, virDomainInfoPtr
> info)
> goto cleanup;
> }
>
> -info-
metadata;
> +remote_string key;
> +remote_string uri;
> +u_int flags;
> +};
> +struct remote_domain_get_metadata_args {
> +remote_nonnull_domain dom;
> +int type
41-864e-0949-8cc7d3bae9f8
> + 65536
> + 65536
> + A short description of this domain
> +
> + A longer explanation that this domain is a test domain
> + for validating domain schemas.
> +
> + 1
> +
> +hvm
> +
> +
> +
> +
>
On Wed, Jan 18, 2012 at 10:02:48PM +0800, Daniel Veillard wrote:
[...]
> Second I would really like to keep the monthly shedule, and have the
> release done by February 6 or earlier, so this would mean entering the
> 0.9.10 freeze on Monday 30, i.e. in a bit less than two weeks.
On Tue, Jan 24, 2012 at 08:06:31AM -0700, Eric Blake wrote:
> On 01/24/2012 07:18 AM, Daniel Veillard wrote:
> > The idea is that currently we have only the domain name usable as
> > a description for the domain. It is not really a good human readable
> > identifier, as the k
1,7 @@ struct _virDomainDef {
unsigned char uuid[VIR_UUID_BUFLEN];
char *name;
char *description;
+char *title;
struct {
unsigned int weight;
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engi
n entering the
0.9.10 freeze on Monday 30, i.e. in a bit less than two weeks.
I hope this is okay,
Daniel
[1] actually the addition of fine grained access control would be
a good reason for such a version bump
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsof
On Tue, Jan 17, 2012 at 04:50:03PM +0100, Jiri Denemark wrote:
> On Tue, Jan 17, 2012 at 23:45:10 +0800, Daniel Veillard wrote:
> > The new dependancy is only available on ix86, x86_64 and ia64
> >
> > diff --git a/libvirt.spec.in b/libvirt.spec.in
> > index d06c06
i686 x86_64 ia64
# For virConnectGetSysinfo
Requires: dmidecode
+%endif
# For service management
%if %{with_systemd}
Requires(post): systemd-units
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net
t; diff --git a/tests/qemuxml2argvdata/qemuxml2argv-net-server.xml
> b/tests/qemuxml2argvdata/qemuxml2argv-net-server.xml
> new file mode 100644
> index 000..eca440d
> --- /dev/null
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-net-server.xml
> @@ -0,0 +1,29 @@
> +
>
: Document spurious wakeups on virCondWait (Michal Privoznik)
Portability:
- build: fix mingw virCommand build (Eric Blake)
- tests: avoid test failure on rawhide gnutls (Eric Blake)
- build: drop check for ANSI compiler (Eric Blake)
- Fix build on s390(x) and other stange arches (Daniel Veill
exit $$st; \
> + < $(@F)-t1 > $(@F)-t3; \
> + case $$? in 8) rm -f $(@F)-t?; exit 0;; 0) ;; *) exit 1;; esac;\
> + diff -u $(@F)-t3 $@; st=$$?; rm -f $(@F)-t?; exit $$st; \
> + fi;
On Thu, Jan 05, 2012 at 09:11:18PM +0100, Peter Krempa wrote:
> Dňa 5.1.2012 16:37, Daniel Veillard wrote / napísal(a):
> >On Fri, Dec 30, 2011 at 02:30:43PM +0800, Daniel Veillard wrote:
> >I have made a release candidate 2 tarball (and associated rpms) at
> > ftp:
On Fri, Dec 30, 2011 at 02:30:43PM +0800, Daniel Veillard wrote:
> We are now entering the freeze for libvirt-0.9.9 .
> We hadn't yet reviewed Taku Izumi second version of his patchset
> maybe we can pull his next version in rc2.
Sorry I made rc2 earlier today and Taku Izumi pa
|
> +if (type == VIR_DOMAIN_SECLABEL_STATIC ||
> !(flags & VIR_DOMAIN_XML_INACTIVE) ||
> (default_seclabel && !def->norelabel)) {
> p = virXPathStringLimit("string(./label[1])",
> VIR_SECURITY_LABEL_BUFL
didn't actually test it, but also didn't
> spot anything obviously wrong, so:
>
> ACK.
>
> I think it is low-enough risk to be okay if you push before 0.9.9.
Agreed :-) thanks to both of you :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http:
december but I forgot it. Since it's relatively contained, I'm pushing
it in spite of the freeze, we already delayed it over one release. Blame
me if it breaks something it was my fault I forgot the patch !
ACK and pushed,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome
e git tree is tagged.
Note that this will fail to puild outside of PC and PPC arches,
but the fix is in git now.
I think I will make an rc2 on Tues or Wed and then try to
make the release around Friday next week if things
looks good.
Please give it a try !
thanks in advance,
Daniel
--
D
ve parsed clock speed out of /proc/cpuinfo. Get the core, socket
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing li
s testing can really validate the approach.
That's why I'm inclined to push this as part of the release candidate
to try to augment testing.
So ACK, I'm pushing this, I just had to slightly rebase patch #4
because the context in one of the documentation example XML changed
slightl
On Thu, Dec 29, 2011 at 09:56:02PM +0800, Daniel Veillard wrote:
> On Thu, Dec 29, 2011 at 09:37:42PM +0800, Osier Yang wrote:
> > On 2011年12月29日 21:19, Daniel Veillard wrote:
> > >As seen in https://bugzilla.redhat.com/show_bug.cgi?id=746111
> > >
> > >I
On Thu, Dec 29, 2011 at 09:37:42PM +0800, Osier Yang wrote:
> On 2011年12月29日 21:19, Daniel Veillard wrote:
> >As seen in https://bugzilla.redhat.com/show_bug.cgi?id=746111
> >
> >If compiled with the daemon and avahi support, then it's better
> >to require avahi
+++ b/libvirt.spec.in
@@ -272,6 +272,9 @@ Requires: %{name}-client = %{version}-%{release}
Requires: module-init-tools
# for /sbin/ip & /sbin/tc
Requires: iproute
+%if ! %{with_avahi}
+Requires: avahi
+%endif
%endif
%if %{with_network}
Requires: dnsmasq >= 2.41
--
Daniel Veillard
On Thu, Dec 29, 2011 at 12:36:14PM +0800, Osier Yang wrote:
> On 2011年12月29日 09:56, Daniel Veillard wrote:
> >* python/libvirt-override.c: remove the predefined array in the
> > virConnectListDomainsID binding and call virConnectNumOfDomains
> > to do a proper allocatio
devices[i].path);
> + devices[j].path);
> break;
> }
> }
> -if (i != ndevices) {
> +if (j != ndevices) {
> ret = -1;
&g
intWrap(ids[i]));
+
+if (ids) {
+ for (i = 0;i < c_retval;i++) {
+ PyList_SetItem(py_retval, i, libvirt_intWrap(ids[i]));
+ }
+ free(ids);
}
+
return(py_retval);
}
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan
-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailma
_("%s: error: %s. Check /var/log/messages or run
> without "
> - "--daemon for more info.\n"), argv0,
> +_("%s: error: %s. Check /var/log/messages or run "
> + "without --daemon for mor
;10' weight='10' />
> +
> +
> +
> +
> + />
> + />
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> diff --git a/tests/networkxml2argvtest.c b/tests/networkxml2argvtest.c
> index 4a11d6f..2dd9b7f 100644
> --- a/tests/networkxml2argvtest.c
> +++ b/tests/networkxml2argvtest.
entation or reporting issues ! Let's not forget
the translation teams at transifex [1] with special kudos for ukainian
who have 100% complete localization if I believe transifex statistics :-)
Daniel
[1] https://www.transifex.net/projects/p/libvirt/resource/strings/
--
Daniel Veillard |
On Wed, Dec 07, 2011 at 07:58:40PM -0700, Eric Blake wrote:
> On 12/07/2011 07:53 PM, Daniel Veillard wrote:
> >>>> # We check this by looking to see if the daemon is already installed
> >>>> -/sbin/chkconfig --list libvirtd 1>/dev/null 2>
Also if someone uses an XML editor on one of our fragment it's very
likely that the ' will be turned into " because the distinction is not
part of the XML infoset (i.e. the amount of data an XML parser should
report to the application) and the tool will serialize back using
h
d this has to be '/bin/chkconfig
> libvirtd', not '/sbin/chkconfig'.
>
> >
> > ACK.
>
> I'll push the corrected version.
Humm ... here on Fedora 14 it's definitely /sbin/chkconfig there
is no /bin/chkconfig,
let's wait after the
On Fri, Dec 02, 2011 at 02:30:35PM +0100, Peter Krempa wrote:
> On 12/02/2011 01:42 AM, Daniel Veillard wrote:
> >On Thu, Dec 01, 2011 at 02:11:24PM -0700, Eric Blake wrote:
> >>But that means we really are committing to an rc2.
> >
> > Definitely. For example ther
On Thu, Dec 01, 2011 at 02:11:24PM -0700, Eric Blake wrote:
> On 11/30/2011 10:48 PM, Daniel Veillard wrote:
> > We are now entering the freeze for libvirt-0.9.8 .
> > For portability sake I think adding more support for PPC machines
> > should still be allowed for a few
if the config does not match, or
> interface does not exist, -1 on error
> */
> -#ifdef __linux__
> +#if defined(HAVE_STRUCT_IFREQ)
> int virNetDevValidateConfig(const char *ifname,
> const unsigned char *macaddr, int ifindex)
> {
> @@ -924,7 +924,7 @@ int virNe
ftp://libvirt.org/libvirt/libvirt-0.9.8-rc1.tar.gz
and the git tree is tagged.
I think I will make an rc2 on Mon or Thu and then try to
make the release around Thursday next week if things
looks good.
Please give it a try !
thanks in advance,
Daniel
--
Daniel Veillard | libxml Gnome XML
irt/network/
> +%ghost %dir %{_localstatedir}/run/libvirt/network/
> %dir %attr(0700, root, root) %{_localstatedir}/lib/libvirt/network/
> %dir %attr(0755, root, root) %{_localstatedir}/lib/libvirt/dnsmasq/
> %endif
ACK, and pushed for 0.9.8-rc1,
thanks !
Daniel
--
Danie
ds to add a timeout that will make next poll return
> > immediately without blocking.
> > ---
> > tools/virsh.c | 39 +--
> > 1 files changed, 33 insertions(+), 6 deletions(-)
>
> ACK.
ACK too, and pushed !
thanks !
Da
first time too, on F14, I was blaming my system
as I got an oops earlier, but apparently that's not it ! I got it again,
and it's the virsh-synopsis test which fails to finish. I had to try 4
time before reproducing it...
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
k event loop */
> +int timer = virEventAddTimeout(-1, NULL, NULL, NULL);
> +if (timer != -1)
> +virEventRemoveTimeout(timer);
> +
> +virThreadJoin(&ctl->eventLoop);
> +ctl->eventLoopStarted = false;
>
to cleanup;
>
> -if (!(timestamp = virLogFormatTimestamp()))
> -goto cleanup;
> +if (virTimeStringNowRaw(timestamp) < 0)
> +timestamp[0] = '\0';
>
> /*
> * Log based on defaults, first store in the history buffer,
> @@ -7
gettimeofday(&cur_time, NULL);
> -localtime_r(&cur_time.tv_sec, &time_info);
> -
> - strftime(timestr, sizeof(timestr), "%Y-%m-%d %H:%M:%S", &time_info);
> -
> -if (virAsprintf(×tamp, "%s.%03d",
> -timestr, (int) cur_ti
e there is also a version without the Raw postfix
> which raises a full libvirt error. These versions are not async
> signal safe
ACK, I didn't spot anything :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind
alues
> - Patch 3 changes the capabilities XML schema
> - Patch 11 ensures we don't probe suspend info unles we need it
> - Patch 14 fixes a bug
>
>
> Obviously due to 1 & 3 we need to do this before the next release
ACK to the serie !
Daniel
--
Daniel Veilla
On Tue, Nov 29, 2011 at 06:59:46PM +0800, Osier Yang wrote:
> On 2011年11月29日 18:55, Daniel Veillard wrote:
> >On Tue, Nov 29, 2011 at 06:46:26PM +0800, Osier Yang wrote:
> >>Part of the error log is pasted, looks like it's caused by
> >>the calling of vir
to/this/dir/testnode.xml on the absolute
server, reached with test protocol from an URI perspective, so we need
at least and extra / because "" server means local host:
test:///absolute/path/to/this/dir/testnode.xml
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmls
t it, but I didn't expected failures like this
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
li
lock being initialized.
So my changes certainly need reviews, but the first version is commited
now.
Thanks, but in the future, please run "make check" and "make syntax-check"
on all commits before posting them to the list,
Daniel
--
Daniel Veillard | libxml Gnome X
8..eda60d2 100644
> --- a/src/util/util.h
> +++ b/src/util/util.h
> @@ -264,14 +264,16 @@ void virTypedParameterArrayClear(virTypedParameterPtr
> params, int nparams);
> /* Power Management Capabilities of the host system */
>
> enum virHostPMCapability {
> -VIR_HO
pumap);
> +
> +return 0;
> +}
> +
> +
> /**
> * lxcSetContainerResources
> * @def: pointer to virtual machine structure
> @@ -347,6 +407,9 @@ static int lxcSetContainerResources(virDomainDefPtr def)
> {'c', LXC_DEV_MAJ_TTY, LXC_DEV_MIN_
rloaded by allowing override.
> * virDomainAttachDevice API - need to todo different checks for the
>different types of device being attached & potentially multiple
>checks if the attached device references other host resources.
>eg a PCI device attach with man
no_memory;
> - chr->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE;
> -chr->targetType = VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL;
> +if (create_stub) {
> +/* And create a stub placeholder */
> +if (VIR_ALLOC(
return -1;
> }
>
> -if (fstat(fd, &sb) < 0) {
> -virReportSystemError(errno,
> - _("cannot stat file '%s'"),
> - path);
> -VIR_FORCE_CLOSE(fd);
> -return -1;
> -}
ot;,
> + _("Unable to get cgroup for driver"));
> +return rc;
> +}
> +
> +rc = virCgroupForDomain(driver, def->name, &cgroup, 1);
> +if (rc != 0) {
> +virReportSystemError(-rc,
> + _
ww.redhat.com/archives/libvir-list/2011-November/msg01052.html
>
> They would still be optional for tarball builds, of course, but having
> them required when doing autogen.sh on libvirt.git may help more
> developers catch problems up front.
Wasn't the problem that cppi isn't u
D_PARAM_UINT;
> +
> + switch (i) {
> +case 0: /* fill blkio weight here */
> +if (virStrcpyStatic(param->field, VIR_DOMAIN_BLKIO_WEIGHT)
> == NULL) {
> +lxcError(VIR_ERR_INTERNAL_ERROR,
> +
"%s", _("cgroup CPU controller is not mounted"));
> goto cleanup;
> }
>
> -if (virCgroupForDomain(driver->cgroup, vm->def->name, &group, 0) != 0)
> +if (virCgroupForDomain(driver->cgroup, vm->def->name, &group
ic int lxcSetContainerNUMAPolicy(virDomainDefPtr def)
> +{
> +if (def->numatune.memory.nodemask) {
> +lxcError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> + _("NUMA policy is not available on this platform"));
> +return -1;
> +
+ b/tests/qemuxml2xmltest.c
> @@ -191,6 +191,7 @@ mymain(void)
> DO_TEST("event_idx");
>
> DO_TEST("usb-redir");
> +DO_TEST("blkdeviotune");
>
> /* These tests generate different XML */
> DO_TEST_DIFFERENT("balloon-d
901 - 1000 of 6302 matches
Mail list logo
