o make sure that any other CPU string we did not come
across yet won't trigger the error - the virNodeInfo has other useful
info that is arguably more important than CPU model string, e.g. core
count, or memory size
Signed-off-by: Dawid Zamirski
Reviewed-by: Neal Gompa
---
Changes since v1:
* Add
Apparenlly exising code was dealing with stripping down Intel CPU models
as reported by Hyper-V host but was still having issues with my AMD CPU
for which Hyper-V returns "AMD FX(tm)-8350 Eight-Core Processor".
Therefore, this patch deals with it by stripping out the "
Processor" part, and if
Hi Michal,
Yes, please feel free to add:
Signed-off-by: Dawid Zamirski
to both messages. I'll make sure it is included in my future
submissions from now on.
Thanks,
Dawid
On Fri, 2019-07-12 at 17:12 +0200, Michal Privoznik wrote:
> On 7/8/19 11:32 PM, Dawid Zamirski wrote:
> &
This is a PHP 7 compatibilty macro which was segfaulting due to the
temporary variable being defined in the do..while scoped block (to
swallow semicolon for macros), e.g:
zval *arr;
VIRT_ARRAY_INIT(arr);
VIRT_ADD_ASSOC_STRING(arr, "foo", "bar"); // <= segfault here
The VIRT_ARRAY_INIT above was
one. Details are included in the commit messages of each patch.
Regards,
Dawid
Dawid Zamirski (2):
Fix PHP7 VIRT_ARRAY_INIT macro implementation.
Add binding for virDomainInterfaceAddresses.
src/libvirt-domain.c | 55
src/libvirt-domain.h | 2
A straight-forward 1:1 mapping to the C API. Returns array in the
following format:
array (
0 =>
array (
'name' => 'vnet0',
'hwaddr' => '52:54:00:3a:cd:94',
'naddrs' => 1,
'addrs' =>
array (
'addr' => '192.168.254.224',
'prefix' => 24,
'type' => 0,
),
The PHP7 variant of the macro wasn't safe if the hash key was not a
string type. This was found when running php script with just
libvirt_connect call under xdebug session which segfaulted. This patch
makes the following changes:
* make sure that tmp_name is initialized to NULL
* set the key name
On Wed, 2017-12-06 at 11:40 -0500, Dawid Zamirski wrote:
> On Wed, 2017-12-06 at 16:21 +0100, Michal Privoznik wrote:
> > On 12/06/2017 12:17 AM, Dawid Zamirski wrote:
> > >
> > > &_info.length, &_info.index, 0, &_pos); \
> >
> > but
On Wed, 2017-12-06 at 16:21 +0100, Michal Privoznik wrote:
> On 12/06/2017 12:17 AM, Dawid Zamirski wrote:
> >
> > &_info.length, &_info.index, 0, &_pos); \
>
> but not here. Does that work for you?
>
It does but with a compiler warning :-) I did not reali
The PHP7 variant of the macro wasn't safe if the hash key was not a
string type. This was found when running php script with just
libvirt_connect call under xdebug session which segfaulted. This patch
makes the following changes:
* make sure that tmp_name is initialized to NULL
* set the key name
---
docs/news.xml | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 9361a9165..630784a0a 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -37,6 +37,11 @@
+
+
+ vbox: Add VirtualBox 5.2 support
+
+
Extracted from 5.2 SDK and reindented with cppi
0001-vbox-Add-vbox-5.2-CAPI-header-file.tar.xz
Description: application/xz-compressed-tar
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Simply add the 5.2 SDK header to the existing unified framework. No
other special handling is needed as there's no API break between
exising 5.1 and the just added 5.2.
---
src/Makefile.am | 1 +
src/vbox/vbox_V5_2.c | 13 +
src/vbox/vbox_common.h| 2
.
[1] https://www.redhat.com/archives/libvir-list/2016-November/msg00355.html
Dawid Zamirski (2):
vbox: Add vbox 5.2 CAPI header file.
vbox: Add support for 5.2.x
src/Makefile.am | 1 +
src/vbox/vbox_CAPI_v5_2.h | 26870
src/vbox
On Tue, 2017-11-07 at 17:05 -0500, John Ferlan wrote:
>
> On 11/07/2017 04:36 PM, Dawid Zamirski wrote:
> > * libvirt no longer supports vbox <= 3.x
> > * update XML definition sample to show how to attach disks to
> > VBOX's SAS
> > controller and h
---
docs/formatdomain.html.in | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 92e14a919..d3cabac44 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -6100,7 +6100,10 @@ qemu-kvm -net
* update docs/drvvbox.html.in to show support for
* update docs/fomatdomain.html.in to describe autoport behavior in the
vbox driver
Dawid Zamirski (2):
docs: Update vbox driver documentation.
docs: Document autoport behavior in the vbox driver
docs/drvvbox.html.in | 28
* libvirt no longer supports vbox <= 3.x
* update XML definition sample to show how to attach disks to VBOX's SAS
controller and how to change IDE controller model.
* update XML to show how to create RDP display with autoport.
---
docs/drvvbox.html.in | 28 +++-
1 file
On Fri, 2017-11-03 at 09:52 -0400, John Ferlan wrote:
>
> On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> > If a VBOX VM has e.g. a SATA and SCSI disk attached, the XML
> > generated
> > by dumpxml used to produce "sda" for both of those disks. This is
> &
With this patch, the vbox driver will no longer attach all supported
storage controllers by default even if no disk devices are associated
with them. Instead, it will attach only those that are implicitly added
by virDomainDefAddImplicitController based on element or if
explicitly specified via
---
docs/news.xml | 74 +++
1 file changed, 74 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index ef855d895..454c63d8b 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -37,8 +37,82 @@
+
+
+
Because it deals with other disk types as well not just IDE. Also this
function now returns -1 on error
---
src/vbox/vbox_common.c | 57 ++
1 file changed, 25 insertions(+), 32 deletions(-)
diff --git a/src/vbox/vbox_common.c
If a VBOX VM has e.g. a SATA and SCSI disk attached, the XML generated
by dumpxml used to produce "sda" for both of those disks. This is an
invalid domain XML as libvirt does not allow duplicate device names. To
address this, keep the running total of disks that will use "sd" prefix
for device
This patch prepares the vboxSnapshotGetReadOnlyDisks and
vboxSnapshotGetReadWriteDisks functions for further changes so that
the code movement does not obstruct the gist of those future changes.
This is done primarily because we'll need to know the type of vbox
storage controller as early as
This patch adds element to each device since device
names alone won't adequately reflect the storage device layout in the
VM. With this patch, the ouput produced by dumpxml will faithfully
reproduce the storage layout of the VM if used with define.
---
src/vbox/vbox_common.c | 51
---
src/vbox/vbox_common.c | 109 +
1 file changed, 109 insertions(+)
diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
index 49df52c12..4d596075c 100644
--- a/src/vbox/vbox_common.c
+++ b/src/vbox/vbox_common.c
@@ -3147,6 +3147,113 @@
Both vboxSnapshotGetReadWriteDisks and vboxSnapshotGetReadWriteDisks do
not need to free the def->disks on cleanup because it's being done by
the caller via virDomainSnaphotDefFree
---
src/vbox/vbox_common.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git
Primer the code for further changes:
* move variable declarations to the top of the function
* group together free/release statements
* error check and report VBOX API calls used
---
src/vbox/vbox_common.c | 190 +++--
1 file changed, 122
Previously any removable storage device without media attached was
omitted from domain XML dump. They're still (rightfully) omitted in
snapshot XMl dump but need to be accounted properly to for the device
names to stay in 'sync' between domain and snapshot XML dumps.
---
src/vbox/vbox_common.c |
In VirtualBox SAS and SCSI are separate controller types whereas libvirt
does not make such distinction. This patch adds support for attaching
the VBOX SAS controllers by mapping the 'lsisas1068' controller model in
libvirt XML to VBOX SAS controller type. If VBOX VM has disks attached
to both
So that the function signature matches vboxSnapshotGetReadWriteDisks
---
src/vbox/vbox_common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
index 79030e36e..4d39beb1e 100644
--- a/src/vbox/vbox_common.c
+++
* Split up the snapshot function cleanup code into separate patches
* Fixed code formatting as pointed out in review
* Rename vboxDumpIDEHDDs -> vboxDumpDisks into a separate patch
* Add docs/news.xml patch to describe improvements/fixes in the series
Dawid Zamirski (13):
vbox: Cleanup partia
On Fri, 2017-11-03 at 09:51 -0400, John Ferlan wrote:
>
> On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> >
> > +case VIR_DOMAIN_CONTROLLER_TYPE_SCSI:
> > +VBOX_UTF8_TO_UTF16(VBOX_CONTROLLER_SCSI_NAME,
> > );
> > +vboxBusType = Stora
On Fri, 2017-11-03 at 09:43 -0400, John Ferlan wrote:
>
> On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> > This commit primes vboxAttachDrives for further changes so when
> > they
> > are made, the diff is less noisy:
> >
> > * move variable declarations
On Fri, 2017-11-03 at 09:51 -0400, John Ferlan wrote:
>
> On 10/24/2017 03:35 PM, Dawid Zamirski wrote:
> > This patch enables the VBOX driver to process the
> > element
> > in domain XML through which one can now customize the controller
> > model.
> >
>
On Tue, 2017-10-24 at 15:35 -0400, Dawid Zamirski wrote:
> Since the VBOX API requires to register an initial VM before
> proceeding
> to attach any remaining devices to it, any failure to attach such
> devices should result in automatic cleanup of the initially
> registered
> VM
On Wed, 2017-10-25 at 17:35 -0400, John Ferlan wrote:
>
> On 10/24/2017 05:09 PM, Dawid Zamirski wrote:
> > VirutalBox has a IVRDEServerInfo structure available that
> > gives the effective runtime port that the VM is using when it's
> > running. This is useful when the &
if vboxGetActiveRdpPort returns -1 and add
more verbose code comments to clarify the logic
Dawid Zamirski (3):
vbox: Remove old unflexible macros
vbox: Make autoport set RDP port range.
vbox: Read runtime RDP port and handle autoport
src/vbox/vbox_common.c| 3 +-
src/vbox/vbox_tmpl.c
The VBOX_SESSION_OPEN/CLOSE macros are only called in
_vboxDomainSnapshotRestore and they are unflexible because:
* assume the caller will have variable named "data"
* can only create Write lock type
As per above, it's not that hard to simply use the VBOX API directly.
---
src/vbox/vbox_tmpl.c
From: Dawid Zamirski <dzr...@gmail.com>
Originally autoport in vbox driver was setting the port to default value
(3389) which caused multiple VM instances use the same port. Since
libvirt XML does not allow to set port ranges, this patch changes the
"autoport" behavior to set V
VirutalBox has a IVRDEServerInfo structure available that
gives the effective runtime port that the VM is using when it's
running. This is useful when the "TCP/Ports" VBox property was set to
port range (e.g. via autoport = "yes" or via VBoxManage) in which
case it would be impossible to get the
Primer the code for further changes:
* move variable declarations to the top of the function
* group together free/release statements
* error check and report VBOX API calls used
---
src/vbox/vbox_common.c | 188 +++--
1 file changed, 120
---
src/vbox/vbox_common.c | 119 +
1 file changed, 119 insertions(+)
diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
index 9d45e4a76..715eb670e 100644
--- a/src/vbox/vbox_common.c
+++ b/src/vbox/vbox_common.c
@@ -3153,6 +3153,123 @@
Previously any removable storage device without media attached was
omitted from domain XML dump. They're still (rightfully) omitted in
snapshot XMl dump but need to be accounted properly to for the device
names to stay in 'sync' between domain and snapshot XML dumps.
---
src/vbox/vbox_common.c |
If a VBOX VM has e.g. a SATA and SCSI disk attached, the XML generated
by dumpxml used to produce "sda" for both of those disks. This is an
invalid domain XML as libvirt does not allow duplicate device names. To
address this, keep the running total of disks that will use "sd" prefix
for device
Previously, if one tried to define a VBOX VM and the API failed to
perform the requested actions for some reason, it would just log the
error and move on to process remaining disk definitions. This is not
desired as it could result in incorrectly defined VM without the caller
even knowing about
From: Dawid Zamirski <dzr...@gmail.com>
v1: https://www.redhat.com/archives/libvir-list/2017-October/msg00381.html
Changes since v1:
* split out the original patches into smaller ones, with each bugfix or
cleanup task is in its own isolated and compilable patch
* make sure switch stat
This patch enables the VBOX driver to process the element
in domain XML through which one can now customize the controller model.
Since VirtualBox has two distinct SAS and SCSI they do not "map"
directly to libvirt XML, he VBOX driver uses to create SAS controller in VBOX VM. Additionally
once
This patch adds element to each device since device
names alone won't adequately reflect the storage device layout in the
VM. With this patch, the ouput produced by dumpxml will faithfully
reproduce the storage layout of the VM if used with define.
---
src/vbox/vbox_common.c | 79
Since the removal of VBOX <= 3x, the function arguments are actually
used so they should not be marked with ATTRIBUTE_UNUSED anymore.
---
src/vbox/vbox_tmpl.c | 49 +++--
1 file changed, 23 insertions(+), 26 deletions(-)
diff --git
The optional values are 'piix3', 'piix4' or 'ich6'. Those will be
needed to allow setting IDE controller model in VirtualBox driver.
---
docs/formatdomain.html.in | 4
docs/schemas/domaincommon.rng | 18 --
src/conf/domain_conf.c| 9 +
Original code was checking for non empty disk source before proceeding
to actually attach disk device to VM. This prevented from creating
empty removable devices like DVD or floppy. Therefore, this patch
re-organizes the loop work-flow to allow such configurations as well as
makes the code follow
This patch exposes additional methods of the native VBOX API to the
libvirt 'unified' vbox API to deal with IStorageController. The exposed
methods are:
* IStorageController->GetStorageControllerType()
* IStorageController->SetStorageControllerType()
* IMachine->GetStorageControllers()
---
This commit primes vboxAttachDrives for further changes so when they
are made, the diff is less noisy:
* move variable declarations to the top of the function
* add disk variable to replace all the def->disks[i] instances
* add cleanup at the end of the loop body, so it's all in one place
Since the VBOX API requires to register an initial VM before proceeding
to attach any remaining devices to it, any failure to attach such
devices should result in automatic cleanup of the initially registered
VM so that the state of VBOX registry remains clean without any leftover
"aborted" VMs in
When registering a VM we call OpenMedium on each disk image which adds it
to vbox's global media registry. Therefore, we should make sure to call
Close when unregistering VM so we cleanup the media registry entries
after ourselves - this does not remove disk image files. This follows
the behaviour
Previously, the driver was computing VBOX's devicePort/deviceSlot values
based on device name and max port/slot values. While this worked, it
completely ignored values. Additionally, libvirt's built-in
virDomainDiskDefAssignAddress already does a good job setting default
values on
On Tue, 2017-10-17 at 15:46 -0400, John Ferlan wrote:
>
> On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> > From: Dawid Zamirski <dzamir...@datto.com>
> >
> Lots of potentially use DEBUG information being lost. IDC, but seems
> a
> shame to not have it. Altho
On Tue, 2017-10-17 at 15:46 -0400, John Ferlan wrote:
>
> On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> > From: Dawid Zamirski <dzamir...@datto.com>
> >
> > The optional values are 'piix3', 'piix4' or 'ich6'. Those will be
> > needed to allow setting IDE c
On Tue, 2017-10-17 at 15:44 -0400, John Ferlan wrote:
>
> On 10/09/2017 04:49 PM, Dawid Zamirski wrote:
> > From: Dawid Zamirski <dzamir...@datto.com>
> >
> > When registering a VM we call OpenMedium on each disk image which
> > adds it
> > to vbox's g
Originally autoport in vbox driver was setting the port to default
value (3389) which caused mutiple VM instances use the same port.
Since libvirt XML does not allow to set port ranges, this patch changes
the "autoport" behavior to set VBox's "TCP/Ports" property to an
arbitraty port range
The original description got it backwards.
---
docs/formatdomain.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index c0e3c2221..19a778bce 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
VirutalBox has a IVRDEServerInfo sturcture available that
gives the effective runtime port that the VM is using when it's
running. This is useful when the "TCP/Ports" VBox property was set to
port range (e.g. via autoport = "yes" or via VBoxManage) in which
case it would be impossible to get the
n RDP wher the descriptions of multiUser and
replaceUser were swapped.
Dawid Zamirski (3):
vbox: Make autoport set RDP port range.
vbox: Read runtime RDP port and handle autoport.
docs: Fix multiUser/replaceUser in RDP display doc.
docs/formatdomain.html.in | 4 +-
src/vbox/vbox_common.c
From: Dawid Zamirski <dzamir...@datto.com>
---
docs/formatdomain.html.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index c0e3c2221..ddcc9f1b1 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -
From: Dawid Zamirski <dzamir...@datto.com>
Until now the vbox driver was completely ignoring element
for storage in the XML definition. This patch adds support for
interpretting element for storage devices. With this the
following other changes were made to the whole storage attachmen
From: Dawid Zamirski <dzamir...@datto.com>
* added vboxDumpStorageControllers
* replaced vboxDumpIDEHDDs with vboxDumpDisks which has been refectored
quite a bit to handle removable devices, the new SAS controller
support etc.
* align the logic in vboxSnapshotGetReadWrit
From: Dawid Zamirski <dzamir...@datto.com>
The optional values are 'piix3', 'piix4' or 'ich6'. Those will be
needed to allow setting IDE controller model in VirtualBox driver.
---
docs/schemas/domaincommon.rng | 18 --
src/conf/domain_conf.c| 9 +
sr
From: Dawid Zamirski <dzamir...@datto.com>
This patch 'maps' additonal methods for VBOX API to the libvirt unified
vbox API to deal with IStorageController. The 'mapped' methods are:
* IStorageController->GetStorageControllerType()
* IStorageController->SetStorageControllerType(
undefining VMs. Leaving media unclosed
may cause errors when defining VMs pointing at the same local path.
Dawid Zamirski (6):
vbox: Close media when undefining domains.
domain: Allow 'model' attribute for ide controller.
docs: Add info about ide model attribute.
vbox: Add more
From: Dawid Zamirski <dzamir...@datto.com>
When registering a VM we call OpenMedium on each disk image which adds it
to vbox's global media registry. Therefore, we should make sure to call
Close when unregistering VM so we cleanup the media registry entries
after ourselves - this does not
On Thu, 2017-08-03 at 14:34 -0400, Dawid Zamirski wrote:
> As per [1], this patch series splits up the large libvirt-php.c into
> components that (attempts) to resemble the structure of the libvirt
> project. Each patch successive patch was compile-tested while the
> whole
> seri
On Thu, 2017-08-03 at 14:34 -0400, Dawid Zamirski wrote:
> Also util now includes all the PHP headers.
> ---
> src/libvirt-php.c | 1 -
> src/libvirt-php.h | 157 +---
>
> src/u
---
src/Makefile.am| 1 +
src/libvirt-php.c | 257 +
src/libvirt-php.h | 18 +---
src/libvirt-snapshot.c | 244 ++
src/libvirt-snapshot.h | 58 +++
5 files changed, 306
---
src/Makefile.am| 3 +-
src/libvirt-nwfilter.c | 415 +
src/libvirt-nwfilter.h | 66
src/libvirt-php.c | 445 +
src/libvirt-php.h | 28
5 files changed, 487
---
src/Makefile.am | 3 +-
src/libvirt-connection.c | 1 +
src/libvirt-connection.h | 2 -
src/libvirt-node.c | 305
src/libvirt-node.h | 23
src/libvirt-php.c| 322
---
src/Makefile.am |3 +-
src/libvirt-php.c | 1188 +
src/libvirt-php.h | 49 --
src/libvirt-storage.c | 1130 ++
src/libvirt-storage.h | 137 ++
5 files changed, 1271
Also util now includes all the PHP headers.
---
src/libvirt-php.c | 1 -
src/libvirt-php.h | 157 +---
src/util.h| 174 ++
3 files changed, 175 insertions(+), 157 deletions(-)
diff --git
---
src/Makefile.am | 3 +-
src/libvirt-network.c | 587
src/libvirt-network.h | 73 ++
src/libvirt-php.c | 610 +-
src/libvirt-php.h | 24 +-
5 files changed, 665 insertions(+),
---
src/Makefile.am | 3 +-
src/libvirt-php.c| 231 +--
src/libvirt-php.h| 15 +---
src/libvirt-stream.c | 230 ++
src/libvirt-stream.h | 39 +
5 files changed, 274
---
src/Makefile.am | 3 +-
src/libvirt-nodedev.c | 340
src/libvirt-nodedev.h | 54
src/libvirt-php.c | 353 +-
src/libvirt-php.h | 13 --
5 files changed, 399
As it was failing when local host is using FQDN for hostnames. The
logic to do so follows libvirt's implementation for the same thing.
This fixes an issue where unit tests would falsely fail on workstations
that have FQDN hostnames.
---
src/libvirt-php.c | 38
* add libvirt-connection.h and libvirt-connection.c
* move all libvirt_connect_* function declarations and definitions to
above files
* other minor adjusments to libvirt-php.h and util.h to keep the code
compilable while the code is being moved around.
---
src/Makefile.am | 3 +-
m/archives/libvir-list/2017-August/msg00046.html
Dawid Zamirski (11):
Move PHP version compat macros to utils.h
Split up the bindings for libvirt connection API
Split up the bindings for libvirt node API
Split up the bindings for libvirt stream API
Split up the bindings for libvirt
On Thu, 2017-08-03 at 17:02 +0200, Michal Privoznik wrote:
> On 08/03/2017 04:58 PM, Dawid Zamirski wrote:
> >
> > On Thu, 2017-08-03 at 14:27 +0200, Michal Privoznik wrote:
> > > On 08/01/2017 11:46 PM, Dawid Zamirski wrote:
> > > > * add libvirt-c
On Thu, 2017-08-03 at 14:27 +0200, Michal Privoznik wrote:
> On 08/01/2017 11:46 PM, Dawid Zamirski wrote:
> > * add libvirt-connection.h and libvirt-connection.c
> > * move all libvirt_connect_* function declarations and definitions
> > to
> > above files
&
---
src/Makefile.am | 3 +-
src/libvirt-network.c | 586
src/libvirt-network.h | 73 ++
src/libvirt-php.c | 610 +-
src/libvirt-php.h | 24 +-
5 files changed, 664 insertions(+),
The sockets.c and vncfunc.c should have their own function macros as
they are "helper" functions not directly related to PHP bindings
themselves. This is simple s/PHPFUNC/SOCKETFUNC/ and s/PHPFUNC/VNCFUNC/
---
src/sockets.c | 44 +--
src/vncfunc.c | 138
On Mon, 2017-07-31 at 11:31 -0400, Dawid Zamirski wrote:
> On Mon, 2017-07-31 at 12:35 +0200, Michal Privoznik wrote:
>
> Hi Michal,
>
> I've been busy at work lately with little or no spare time for my OSS
> work :-( I've started on this last week but have been dragged away.
---
src/Makefile.am| 3 +-
src/libvirt-nwfilter.c | 414 +
src/libvirt-nwfilter.h | 66
src/libvirt-php.c | 445 +
src/libvirt-php.h | 28
5 files changed, 486
---
src/Makefile.am| 1 +
src/libvirt-php.c | 257 +
src/libvirt-php.h | 18 +---
src/libvirt-snapshot.c | 243 ++
src/libvirt-snapshot.h | 58 +++
5 files changed, 305
* add libvirt-connection.h and libvirt-connection.c
* move all libvirt_connect_* function declarations and definitions to
above files
* other minor adjusments to libvirt-php.h and util.h to keep the code
compilable while the code is being moved around.
---
src/Makefile.am | 3 +-
---
src/Makefile.am| 3 +-
src/libvirt-node.c | 304 ++
src/libvirt-node.h | 25 +
src/libvirt-php.c | 322 +
src/libvirt-php.h | 6 -
src/util.h | 25 +
6 files
As per [1], this patch series splits up the large libvirt-php.c into
components that (attempts) to resemble the structure of the libvirt
project. Each patch successive patch was compile-tested while the whole
series was verified with "make check" and a simple custom written PHP
scri
---
src/libvirt-php.h | 144 --
src/util.h| 154 ++
2 files changed, 164 insertions(+), 134 deletions(-)
diff --git a/src/libvirt-php.h b/src/libvirt-php.h
index 7962e33..867eb60 100644
oo.org>
+Yukihiro Kawada <warp.kaw...@gmail.com>
+Remi Collet <r...@famillecollet.com>
+Ivo van den Abeelen <ivovandenabee...@gmail.com>
+Tiziano Müller <dev-z...@gentoo.org>
+Pavel Odintsov <pavel.odint...@gmail.com>
+Tugdual Saunier <tugdual.sau
On Tue, 2017-08-01 at 17:46 -0400, Dawid Zamirski wrote:
> As per [1], this patch series splits up the large libvirt-php.c into
> components that (attempts) to resemble the structure of the libvirt
> project. Each patch successive patch was compile-tested while the
> whole
> seri
---
src/Makefile.am | 3 +-
src/libvirt-nodedev.c | 339
src/libvirt-nodedev.h | 54
src/libvirt-php.c | 353 +-
src/libvirt-php.h | 13 --
5 files changed, 398
---
src/Makefile.am |3 +-
src/libvirt-php.c | 1188 +
src/libvirt-php.h | 49 --
src/libvirt-storage.c | 1129 ++
src/libvirt-storage.h | 138 ++
5 files changed, 1271
As it was failing when local host is using FQDN for hostnames. The
logic to do so follows libvirt's implementation for the same thing.
This fixes an issue where unit tests would falsely fail on workstations
that have FQDN hostnames.
---
src/libvirt-php.c | 38
1 - 100 of 267 matches
Mail list logo
