/about/deprecated.rst | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
Otherwise,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
scape from the mouse grabbing mode.
>
> Signed-off-by: Thomas Huth
> ---
> +++ b/qapi/ui.json
> @@ -1295,6 +1295,30 @@
>'*swap-opt-cmd': 'bool'
>} }
>
> +##
> +# @GrabMod:
> +#
> +# Set of modifier keys that need to be hold f
sysemu/os-win32.h | 5 -
> os-posix.c| 5 -
> stubs/is-daemonized.c | 9 -
> stubs/meson.build | 1 -
> 5 files changed, 22 deletions(-)
> delete mode 100644 stubs/is-daemonized.c
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Eng
exit(1);
> }
> -if (is_daemonized()) {
> -qemu_log_stdio_disable();
> -qemu_chr_stdio_disable();
> - }
> +break;
> +case QEMU_OPTION_chroot:
&g
include/chardev/char-stdio.h | 29 +
> softmmu/vl.c | 2 ++
> 3 files changed, 41 insertions(+), 2 deletions(-)
> create mode 100644 include/chardev/char-stdio.h
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
d, 7 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
xplicitly.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> include/qemu/log.h | 1 +
> softmmu/vl.c | 3 +++
> util/log.c | 12 +---
> 3 files changed, 13 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
R
returning
> true merely for the request, even though we've not yet put it
> into action. ie the method would have been better called
> is_daemonize_requested()
Eww, indeed.
>
> The upshot is that we fail to properly close stderr.
>
> I'll send a v2 that handles this by fully removing the
> is_daemonize() method.
Looking forward to it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
; os-posix.c | 83 +-
> 1 file changed, 39 insertions(+), 44 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
util/osdep.c| 28
> 7 files changed, 11 insertions(+), 68 deletions(-)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
in most of
> places.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Kashyap Chamarthy
> Signed-off-by: Markus Armbruster
> ---
Reviewed-by: Eric Blake
I think this is appropriate for inclusion in 6.2, even if it did not
quite make soft freeze, so that w
ct here,...
> +++ b/docs/interop/live-block-operations.rst
>
> QMP invocation for ``drive-backup``
> ~~~
>
> +Note that ``drive-backup`` command is deprecated since QEMU 6.1 and
> +will be removed in future.
...but stale here (this patc
(<< is higher than &); if writing it myself, I would probably
have used explicit () to avoid reviewer confusion, but what you have
is correct. (After grepping for ' & 1.*<<' and ' & (1.*<<', it looks
like authors using explicit precedence happens
> }
> -return visit_deprecated(ffv->target, name);
> +return visit_policy_skip(ffv->target, name, special_features);
> }
>
Otherwise, the rest of the logic changes for flipped sense look right.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
)
> SRST
> ``-compat
> [deprecated-input=@var{input-policy}][,deprecated-output=@var{output-policy}]``
> @@ -3659,6 +3661,22 @@ SRST
> Suppress deprecated command results and events
>
> Limitation: covers only syntactic aspects of QMP.
> +
> +``-comp
'*x-iops-total': { 'type': 'int',
> + 'features': [ 'unstable' ] },
This struct has been around since 381bd74 (v6.0); but was not listed
as deprecated at the time. Do we still need it in 6.2, or have we
gone enough release cycles with the saner naming without x- that we
could drop this? But that is a question independent of this patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
callee side just in
> case of an error.
Indeed. If we expected qdev_set_id() to be passed something that it
can later free, we would have used 'char *'; but because we used
'const char *' for that parameter, it really does make more sense for
the callers to pass
ev's parent and register its id.
> + * If it fails it means the id is already taken.
> + */
> +if (!qdev_set_id(dev, g_strdup(qemu_opts_id(opts)), errp)) {
> +goto err_del_dev;
...nor on this, which means the g_strdup() leaks on failure.
> +}
>
> /* set properties */
> if (qemu_opt_foreach(opts, set_property, dev, errp)) {
> --
> 2.31.1
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
; -'drive-backup' ] }
> +{ 'name': 'drive-backup', 'features': [ 'deprecated' ] } ] }
>
> ##
> # @AbortWrapper:
> --
> 2.31.1
>
But the idea is reasonable, and I'm not sure if we're any closer to
John's idea of feature flags on union branches.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
_POLICY_INPUT_ACCEPT:
> +break;
> +case COMPAT_POLICY_INPUT_REJECT:
> +error_setg(errp, "Deprecated value '%s' disabled by policy",
> + enum_str);
> +return false;
> +case COMPAT_POLICY_
ipts/qapi/introspect.py | 18 ++----
> 2 files changed, 33 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake
>
> diff --git a/qapi/introspect.json b/qapi/introspect.json
> index 39bd303778..f806bd7281 100644
> --- a/qapi/introspect.json
> +++ b/qapi/
ls switch to JSON and we can later make the change without breaking
> things.
>
> Signed-off-by: Kevin Wolf
> ---
> docs/about/deprecated.rst | 11 +++
> 1 file changed, 11 insertions(+)
Reviewed-by: Eric Blake
>
> diff --git a/docs/about/deprecated.rst
str', '*id': 'str'},
> - 'gen': false } # so we can get the additional arguments
> + 'gen': false, # so we can get the additional arguments
> + 'features': ['json-cli'] }
Eventually, we'll get rid of this 'gen':false, but this patch series
is already an improvement towards that goal.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
ot;: "device_add",
> "arguments": { "driver": "scsi-cd",
> "drive": { "completely": "invalid" },
> "physical_block_size": "4096" } }
>
> Signed-off-by: Kevin W
re.h | 8 ++---
> hw/core/qdev.c | 5 ++--
> hw/net/virtio-net.c| 4 +--
> hw/vfio/pci.c | 4 +--
> softmmu/qdev-monitor.c | 67 +++---
> 5 files changed, 41 insertions(+), 47 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric B
ses the
> string visitor, to a keyval visitor and object_property_set().
>
> Signed-off-by: Kevin Wolf
> ---
> softmmu/qdev-monitor.c | 20 +---
> 1 file changed, 17 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Enginee
| 7 +++
> qom/object_interfaces.c | 17 ++---
> 2 files changed, 9 insertions(+), 15 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
On Wed, Sep 15, 2021 at 09:24:23PM +0200, Markus Armbruster wrote:
> The next commit needs to access compat policy from the generic visitor
> core. Move it there from qobject input and output visitor.
>
> Signed-off-by: Markus Armbruster
> ---
Reviewed-by: Eric Blake
On Wed, Sep 15, 2021 at 09:24:22PM +0200, Markus Armbruster wrote:
> This is quite similar to commit 84ab008687 "qapi: Add feature flags to
> struct members", only for enums instead of structs.
>
> Signed-off-by: Markus Armbruster
> ---
Reviewed-by: Eric Blake
tr'] } }
> + 'data': { 'members': [ 'SchemaInfoEnumMember' ],
> +'values': ['str'] } }
> +
> +##
> +# @SchemaInfoEnumMember:
> +#
> +# An object member.
> +#
> +# @name: the member's name, as defined in the QAPI schema.
> +#
> +# Since: 6.1
6.2
> +##
> +{ 'struct': 'SchemaInfoEnumMember',
> + 'data': { 'name': 'str' } }
>
Definitely more flexible.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
On Thu, Jul 08, 2021 at 06:58:21PM +0200, Kevin Wolf wrote:
> Am 08.07.2021 um 17:52 hat Eric Blake geschrieben:
> > When removeing support for qemu-img being able to create backing
removing
(is it bad that I don't catch my own typos until seeing them through
the mailing list
When removeing support for qemu-img being able to create backing
chains without embedded backing formats, we caused a poor error
message as caught by iotest 114. Improve the situation to inform the
user what went wrong.
Suggested-by: Kevin Wolf
Signed-off-by: Eric Blake
---
qemu-img.c
On Thu, Jul 08, 2021 at 03:00:36PM +0200, Kevin Wolf wrote:
> Am 03.05.2021 um 23:36 hat Eric Blake geschrieben:
> > @@ -17,7 +14,7 @@ qemu-io: can't open device TEST_DIR/t.qcow2: Could not
> > open backing file: Unknow
> > no file open, try 'help open'
&
On Mon, May 03, 2021 at 04:35:58PM -0500, Eric Blake wrote:
> We've gone enough release cycles without noticeable pushback on our
> intentions, so time to make it harder to create images that can form a
> security hole due to a need for format probing rather than an explicit
>
+++++
> 1 file changed, 102 insertions(+)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
against the system identity.
>
> Reviewed-by: Michal Privoznik
> Signed-off-by: Daniel P. Berrangé
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 5/3/21 4:45 PM, Eric Blake wrote:
> On 5/3/21 4:36 PM, Eric Blake wrote:
>> Back in commit d9f059aa6c (qemu-img: Deprecate use of -b without -F),
>> we deprecated the ability to create a file with a backing image that
>> requires qemu to perform format probing. Qemu
On 5/3/21 4:36 PM, Eric Blake wrote:
> Back in commit d9f059aa6c (qemu-img: Deprecate use of -b without -F),
> we deprecated the ability to create a file with a backing image that
> requires qemu to perform format probing. Qemu can still probe older
> files for backwards compatibilit
images, due to the potential security risk they
present. Update a couple of iotests affected by the change.
Signed-off-by: Eric Blake
---
docs/system/deprecated.rst | 20 -
docs/system/removed-features.rst | 19
block.c | 37
). Update a couple of iotests to match.
Signed-off-by: Eric Blake
---
docs/system/deprecated.rst | 12
docs/system/removed-features.rst | 12
block/qcow2.c| 13 -
tests/qemu-iotests/061 | 3 +++
tests/qemu-iotests/061.out
points for telling us in a reply. "We should remove, but I can't
> do it myself right now" is a valid answer. Let's review the file:
>
[adjusting cc for this response]
>
> Eric Blake:
>
> qemu-img amend to adjust backing file (since 5.1)
> &
+qemu adds the required functionality.
> +
> * **Improvements**
>
> * **Bug fixes**
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
++--
> tests/qemu-iotests/191.out | 48 +++-
> tests/qemu-iotests/273.out | 15 --
> 7 files changed, 33 insertions(+), 65 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
gt; 4 files changed, 6 insertions(+), 75 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
gt;
> -``-drive file=json:{...{'driver':'file'}}`` (since 3.0)
> -''''''''''''''''''''''''''''''''''&#
adly, since qemu_strtosz() does not
have an Err** parameter, and plumbing that in would be a much larger
task, we instead go with just directly emitting the deprecation
warning to stderr.
Signed-off-by: Eric Blake
Message-Id: <20210211204438.1184395-4-ebl...@redhat.com>
Reviewed-by: Daniel P.
-writeconfig output,
> which at least prevents destroying your existing configuration when you
> just wanted to add another option.
Maybe worth a tweak to this paragraph now that b979c931 has landed
formally deprecating -writeconfig (all the more reason we don't care
about it).
>
> Sig
inted */
> +exit(EXIT_SUCCESS);
> +}
The commit message needs to be updated to call out that this bug fix was
intentional, preferably mentioning the commit where we broke it
(334c43e2c3).
The code is fine, though, so with an improved commit
;IothreadProperties'
> + 'iothread': 'IothreadProperties',
> + 'memory-backend-file':'MemoryBackendFileProperties',
> + 'memory-backend-memfd': { 'type': 'MemoryBacken
type': 'CryptodevVhostUserProperties',
> + 'if': 'defined(CONFIG_VIRTIO_CRYPTO)
> && defined(CONFIG_VHOST_CRYPTO)' },
...if the union branch is likewise?
>'iothread': 'IothreadProperties'
>} }
>
>
With that fixed,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
anged, 6 insertions(+), 15 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 3/2/21 12:32 PM, Kevin Wolf wrote:
> Am 26.02.2021 um 20:42 hat Eric Blake geschrieben:
>> On 2/24/21 7:52 AM, Kevin Wolf wrote:
>>> This adds a QAPI schema for the properties of the can-* objects.
>>>
>>> can-bus doesn't have any properties, so it onl
se, when
> + QMP processing moved to a dedicated thread. However, it is
> + important to let the event loop run after each API call, even
> + the ones made from the vent loop thread itself.
event loop
>
>
> Driver security architecture
>
--
Eric
s(+), 162 deletions(-)
Yay!
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
-writeconfig output,
> which at least prevents destroying your existing configuration when you
> just wanted to add another option.
And Paolo has submitted a patch deprecating it.
>
> Signed-off-by: Kevin Wolf
> ---
> softmmu/vl.c | 109 +++---
ed, 29 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
++-
> hmp-commands.hx | 2 +-
> 3 files changed, 9 insertions(+), 21 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
d be used to fix the exit status 2 issue in qemu-img convert,
if you rearrange the series a bit.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
;
> Signed-off-by: Kevin Wolf
> ---
> qemu-nbd.c | 34 +++---
> 1 file changed, 3 insertions(+), 31 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 2/26/21 3:56 PM, Eric Blake wrote:
> On 2/24/21 7:52 AM, Kevin Wolf wrote:
>> This switches qemu-img from a QemuOpts-based parser for --object to
>> user_creatable_process_cmdline() which uses a keyval parser and enforces
>> the QAPI schema.
>>
>> Apart fro
cmdline() should be given an 'int status'
parameter for specifying 1 vs. 2 (or any other non-zero value) if we
intend to fix the status of qemu-img compare failures. (Thankfully,
even though qemu-img check also has a variety of documented return
values other than 1, at least it documented 1 as internal errors and was
already using 1 for --object failures).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
;
> Signed-off-by: Kevin Wolf
> ---
> qemu-io.c | 33 +++--
> 1 file changed, 3 insertions(+), 30 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
qmp_object_add() into a
> new user_creatable_add_qapi(), because qom/qom-qmp-cmds.c is not linked
> for tools.
>
> user_creatable_print_help_from_qdict() can become static now.
>
> Signed-off-by: Kevin Wolf
> ---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Eng
changed, 50 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
ions(+), 11 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
gt; fail to remove, and therefore abort) a user creatable object from it.
>
> Signed-off-by: Kevin Wolf
> ---
> qom/object_interfaces.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red H
visit_free(v);
This part is nice...
> +
> +props = qobject_to(QDict, qobj);
> +qdict_del(props, "qom-type");
> +qdict_del(props, "id");
...while this part makes it seem like we still have more cleanup to come
later. But hey, progress!
> +
> +
tls-creds-anon': 'TlsCredsAnonProperties',
> 'tls-creds-psk': 'TlsCredsPskProperties',
>'tls-creds-x509': 'TlsCredsX509Properties',
> - 'tls-cipher-suites': 'TlsCredsProperties'
> + 'tls-cipher-suites': 'TlsCredsProperties',
> + 'x-remote-object':'RemoteObjectProperties'
>} }
>
> ##
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
; 'filter-replay',
> 'filter-rewriter',
> +'input-barrier',
> +'input-linux',
> 'iothread',
> 'memory-backend-file',
> 'memory-backend-memfd',
> @@ -741,6 +797,8 @@
>'filter-redirector': 'FilterRedirectorProperties',
>'filter-replay': 'NetfilterProperties',
>'filter-rewriter':'FilterRewriterProperties',
> + 'input-barrier': 'InputBarrierProperties',
> + 'input-linux':'InputLinuxProperties',
>'iothread': 'IothreadProperties',
>'memory-backend-file':'MemoryBackendFileProperties',
>'memory-backend-memfd': 'MemoryBackendMemfdProperties',
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
name': 'sev-guest', 'if': 'defined(CONFIG_SEV)' },
> +'s390-pv-guest',
> 'throttle-group',
> 'tls-creds-anon',
> 'tls-creds-psk',
> @@ -716,6 +751,8 @@
>'rng-random': 'RngRandomProperties',
>'secret': 'SecretProperties',
>'secret_keyring': 'SecretKeyringProperties',
> + 'sev-guest': { 'type': 'SevGuestProperties',
> + 'if': 'defined(CONFIG_SEV)' },
>'throttle-group': 'ThrottleGroupProperties',
>'tls-creds-anon': 'TlsCredsAnonProperties',
>'tls-creds-psk': 'TlsCredsPskProperties',
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
emfd': 'MemoryBackendMemfdProperties',
> 'memory-backend-ram': 'MemoryBackendProperties',
> + 'pr-manager-helper': 'PrManagerHelperProperties',
>'rng-builtin':'RngProperties',
>'rng-egd':'RngEgdProperties',
>'rng-random': 'RngRandomProperties',
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
gt; +#
> +# Since: 2.8
> +##
> +{ 'struct': 'FilterRewriterProperties',
> + 'base': 'NetfilterProperties',
> + 'data': { '*vnet_hdr_support': 'bool' } }
> +
Matches net/filter-rewriter.c:filter_rewriter_class_init().
> ##
> # @IothreadProperties:
> #
> @@ -508,6 +639,12 @@
> 'cryptodev-backend-builtin',
> 'cryptodev-vhost-user',
> 'dbus-vmstate',
> +'filter-buffer',
> +'filter-dump',
> +'filter-mirror',
> +'filter-redirector',
> +'filter-replay',
> +'filter-rewriter',
> 'iothread',
> 'memory-backend-file',
> 'memory-backend-memfd',
> @@ -550,6 +687,12 @@
>'cryptodev-backend-builtin': 'CryptodevBackendProperties',
>'cryptodev-vhost-user': 'CryptodevVhostUserProperties',
>'dbus-vmstate': 'DBusVMStateProperties',
> + 'filter-buffer': 'FilterBufferProperties',
> + 'filter-dump':'FilterDumpProperties',
> + 'filter-mirror': 'FilterMirrorProperties',
> + 'filter-redirector': 'FilterRedirectorProperties',
> + 'filter-replay': 'NetfilterProperties',
> + 'filter-rewriter':'FilterRewriterProperties',
>'iothread': 'IothreadProperties',
>'memory-backend-file':'MemoryBackendFileProperties',
>'memory-backend-memfd': 'MemoryBackendMemfdProperties',
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
an-bus',
> 'can-host-socketcan',
> +'colo-compare',
> 'cryptodev-backend',
> 'cryptodev-backend-builtin',
> 'cryptodev-vhost-user',
> @@ -497,6 +545,7 @@
>'authz-pam': 'AuthZPAMProperties',
>'authz-simple': 'AuthZSimpleProperties',
>'can-host-socketcan': 'CanHostSocketcanProperties',
> + 'colo-compare': 'ColoCompareProperties',
>'cryptodev-backend': 'CryptodevBackendProperties',
>'cryptodev-backend-builtin': 'CryptodevBackendProperties',
>'cryptodev-vhost-user': 'CryptodevVhostUserProperties',
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
AuthZPAMProperties',
>'authz-simple': 'AuthZSimpleProperties',
> + 'can-host-socketcan': 'CanHostSocketcanProperties',
>'cryptodev-backend': 'CryptodevBackendProperties',
>'cryptodev-backend-builtin': 'CryptodevBackendProperties',
>'cryptodev-vhost-user': 'CryptodevVhostUserProperties',
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
o_tls_creds_x509_class_init().
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 2668ad8369..f22b7aa99b 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -452,7 +452,11 @@
> 'rng-random',
> 'secret',
> 'secret_keyring',
> -'throttle-group'
> +'throttle-group',
> +'tls-creds-anon',
> +'tls-creds-psk',
> +'tls-creds-x509',
> +'tls-cipher-suites'
Matches crypto/tls-cipher-suites.c:qcrypto_tls_cipher_suites_class_init().
>] }
>
> ##
> @@ -488,7 +492,11 @@
>'rng-random': 'RngRandomProperties',
>'secret': 'SecretProperties',
>'secret_keyring': 'SecretKeyringProperties',
> - 'throttle-group': 'ThrottleGroupProperties'
> + 'throttle-group': 'ThrottleGroupProperties',
> + 'tls-creds-anon': 'TlsCredsAnonProperties',
> + 'tls-creds-psk': 'TlsCredsPskProperties',
> + 'tls-creds-x509': 'TlsCredsX509Properties',
> + 'tls-cipher-suites': 'TlsCredsProperties'
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
stem/deprecated.rst
> @@ -155,6 +155,17 @@ other options have been processed. This will either
> have no effect (if
> ``opened`` was the last option) or cause errors. The property is therefore
> useless and should not be specified.
>
> +``loaded`` property of ``secret`` and ``secret_keyring`` objects (since
> 6.0.0)
> +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> +
> +The only effect of specifying ``loaded=on`` in the command line or QMP
> +``object-add`` is that the secret is loaded immediately, possibly before all
> +other options have been processed. This will either have no effect (if
> +``loaded`` was the last option) or cause options to be effectively ignored as
> +if they were not given. The property is therefore useless and should not be
> +specified.
May be impacted if we rename to secret-keyring (in fact, if we rename,
the new name wouldn't even need the deprecated field), but that may be
trickier to coordinate. So with regards to just the mechanical conversion,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
evel directory.
>
> { 'include': 'authz.json' }
> +{ 'include': 'block-core.json' }
> { 'include': 'common.json' }
>
> ##
> @@ -447,7 +448,8 @@
> 'memory-backend-ram',
> 'rng-builtin',
> 'rng-egd',
> -'rng-random'
> +'rng-random',
> +'throttle-group'
>] }
>
> ##
> @@ -480,7 +482,8 @@
>'memory-backend-ram': 'MemoryBackendProperties',
>'rng-builtin':'RngProperties',
>'rng-egd':'RngEgdProperties',
> - 'rng-random': 'RngRandomProperties'
> + 'rng-random': 'RngRandomProperties',
> + 'throttle-group': 'ThrottleGroupProperties'
>} }
>
> ##
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
dProperties',
> + 'rng-builtin':'RngProperties',
> + 'rng-egd':'RngEgdProperties',
> + 'rng-random': 'RngRandomProperties'
>} }
>
> ##
> di
+395,10 @@
> 'cryptodev-backend-builtin',
> 'cryptodev-vhost-user',
> 'dbus-vmstate',
> -'iothread'
> +'iothread',
> +'memory-backend-file',
> +'memory-backend-memfd',
&g
.c:dbus_vmstate_class_init(), including
splitting id-list into a GHashTable with get_id_list_set().
Since there is benefit to documenting/converting our existing API in
this series without dragging it out by also trying to fix the warts,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
',
> 'iothread'
>] }
>
> @@ -262,6 +293,9 @@
>'authz-listfile': 'AuthZListFileProperties',
> 'authz-pam': 'AuthZPAMProperties',
>'authz-simple': 'AuthZSimpleProperties',
> + 'cryptodev-backend': 'CryptodevBackendProperties',
> + 'cryptodev-backend-builtin': 'CryptodevBackendProperties',
> + 'cryptodev-vhost-user': 'CryptodevVhostUserProperties',
>'iothread': 'IothreadProperties'
>} }
>
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
'authz-list': 'AuthZListProperties',
> + 'authz-listfile': 'AuthZListFileProperties',
> + 'authz-pam': 'AuthZPAMProperties',
> + 'authz-simple': 'AuthZSimpleProperties',
>'iothread': 'IothreadProperties'
>} }
>
> diff --git a/storage-daemon/qapi/qapi-schema.json
> b/storage-daemon/qapi/qapi-schema.json
> index 28117c3aac..67749d1101 100644
> --- a/storage-daemon/qapi/qapi-schema.json
> +++ b/storage-daemon/qapi/qapi-schema.json
> @@ -26,6 +26,7 @@
> { 'include': '../../qapi/crypto.json' }
> { 'include': '../../qapi/introspect.json' }
> { 'include': '../../qapi/job.json' }
> +{ 'include': '../../qapi/authz.json' }
> { 'include': '../../qapi/qom.json' }
> { 'include': '../../qapi/sockets.json' }
> { 'include': '../../qapi/transaction.json' }
>
Once you delete the dead QAPI hack,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
gt; +#
> +# Describes the options of a user creatable QOM object.
> +#
> +# @qom-type: the class name for the object to be created
> +#
> +# @id: the name of the new object
> +#
> +# Since: 6.0
> +##
> +{ 'union': 'ObjectOptions',
> + 'base': { 'qom-type': 'ObjectType',
> +'id': 'str' },
> + 'discriminator': 'qom-type',
> + 'data': {
> + 'iothread': 'IothreadProperties'
> + } }
> +
> ##
> # @object-add:
> #
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
> qom/qom-qmp-cmds.c | 21 -
> 4 files changed, 6 insertions(+), 31 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 2/24/21 7:52 AM, Kevin Wolf wrote:
> The 'props' option has been deprecated in 5.0 in favour of a flattened
> object-add command. Time to change our test cases to drop the deprecated
> option.
>
> Signed-off-by: Kevin Wolf
> ---
Reviewed-by: Eric Blake
--
Er
On 2/23/21 11:20 AM, Daniel P. Berrangé wrote:
> On Thu, Feb 11, 2021 at 02:44:38PM -0600, Eric Blake wrote:
>> The value '1.1k' is inexact; 1126.4 bytes is not possible, so we
>> happen to truncate it to 1126. Our use of fractional sizes is
>> intended for conveni
Since qemu_strtosz() does not have an Err** parameter, and plumbing
that in would be a much larger task, we instead go with just directly
emitting the deprecation warning to stderr.
Signed-off-by: Eric Blake
---
I'm not a fan of this patch, but am proposing it for discussion purposes.
adly, since qemu_strtosz() does not
have an Err** parameter, and plumbing that in would be a much larger
task, we instead go with just directly emitting the deprecation
warning to stderr.
Signed-off-by: Eric Blake
---
docs/system/deprecated.rst | 8
util/cutils.c | 10 +++
On 2/5/21 5:13 AM, Daniel P. Berrangé wrote:
> On Thu, Feb 04, 2021 at 01:07:07PM -0600, Eric Blake wrote:
>> Supporting '0x20M' looks odd, particularly since we have an 'E' suffix
>> that is ambiguous between a hex digit and the extremely large exibyte
>>
On 2/5/21 4:25 AM, Vladimir Sementsov-Ogievskiy wrote:
> 04.02.2021 22:07, Eric Blake wrote:
>> Supporting '0x20M' looks odd, particularly since we have an 'E' suffix
>
> What about also deprecating 'E' suffix? (just my problem of reviewing
> prev
On 2/4/21 1:07 PM, Eric Blake wrote:
> The value '1.1k' is inexact; 1126.4 bytes is not possible, so we
> happen to truncate it to 1126. Our use of fractional sizes is
> intended for convenience, but when a user specifies a fraction that is
> not a clean translation to binar
policy. Sadly, since qemu_strtosz() does not
have an Err** parameter, we pollute to stderr.
Signed-off-by: Eric Blake
---
docs/system/deprecated.rst | 8
util/cutils.c | 6 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/docs/system/deprecated.rst
pt yet, disable the adaptation until the changes can
> be done, or another compromise depending on what's the state.
>
> I know it's hard to enforce, but probably the cheapest in terms of
> drawbacks any other solution would be.
>
> I'll probably keep notifying patchsets which implement and deprecate old
> api at the same time to keep in mind that we need to be kept in touch,
> but I really don't want to impose any kind of extra process to
> development on either side.
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
fault_tls_x509_cert_dir).
> #
> # If this option is not supplied, it will be set to the value of
> -# "default_tls_x509_verify".
> +# "default_tls_x509_verify". If "default_tls_x509_verify" is not supplied
> either
> +# the default is "1".
# CA in the migrate_tls_x509_cert_dir (or default_tls_x509_cert_dir).
> #
> # If this option is not supplied, it will be set to the value of
> -# "default_tls_x509_verify".
> +# "default_tls_x509_verify". If "default_tls_x509_verify" is not supplied
>
Pass in the 'pull' flag and decide where to install the bitmap according
> to it and also when to register the bitmap name with the blockjob.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_backup.c | 42 ++++++
> 1 file change
On 10/29/20 12:10 PM, Peter Krempa wrote:
> On Mon, Oct 26, 2020 at 08:36:50 -0500, Eric Blake wrote:
>> On 10/26/20 8:19 AM, Peter Krempa wrote:
>>> We use the capability to switch to using 'block-export-add' in the
>>> upcoming qemu release instead of the
ts that the NBD
client may request, but the actual support for more than one will
require a further patch to the server.
Note that there are no changes made to the existing deprecated
'nbd-server-add' command; this required splitting the QAPI type
BlockExportOptionsNbd, which fortunately d
ts that the NBD
client may request, but the actual support for more than one will
require a further patch to the server.
Note that there are no changes made to the existing deprecated
'nbd-server-add' command; this required splitting the QAPI type
BlockExportOptionsNbd, which fortunately d
ned-off-by: Peter Krempa
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
1 - 100 of 17651 matches
Mail list logo
