On 6 May 2020, at 15:41, Daniel P. Berrangé wrote:
On Linux at least, providing passwords on the command line is
considered
a security flaw, because any user can see the command line args of any
other process on the host.
Agreed. The only reason bhyve supports this is to support VNC clients
the
virDomainGraphicsDefNew helper function, which is used by
bhyveParsePCIFbuf.
Signed-off-by: Fabian Freyer
---
src/bhyve/bhyve_parse_command.c | 91 ++-
src/libvirt_private.syms | 1 +
.../bhyveargv2xml-vnc-listen.args | 10
Add support for setting the bhyve framebuffer resolution and probe
whether bhyve supports VNC password authentication. If it does, allow
setting the password.
While we're here, also add support for parsing bhyve's framebuffer
argument string.
Fabian Freyer (4):
bhyve: support parsing fbuf PCI
the domain definition.
Signed-off-by: Fabian Freyer
---
docs/news.xml | 11 +
src/bhyve/bhyve_command.c | 33 ++-
src/bhyve/bhyve_parse_command.c | 5 +++
.../bhyveargv2xml-vnc-password.args | 10
Introduces the BHYVE_CAP_VNC_PASSWORD capability, which is probed by
parsing the error message from the bhyve command. When it is not
supported, bhyve -s 0,fbuf,password= will return an error message.
Signed-off-by: Fabian Freyer
---
src/bhyve/bhyve_capabilities.c | 16 +++-
src
The resolution of the VNC framebuffer can now be set via the resolution
definition introduced in 5.9.0.
Also, add "gop" to the list of model types the
sub-element is valid for.
Signed-off-by: Fabian Freyer
---
docs/formatdomain.html.in | 2 +-
doc
On 14 May 2018, at 8:51, Roman Bogorodskiy wrote:
> Peter Krempa wrote:
>
>> On Sun, May 13, 2018 at 14:01:25 +0400, Roman Bogorodskiy wrote:
>>> Fabian Freyer wrote:
>>
>> [...]
>>
>>>> 13 files changed, 134 insertions(+)
>>>
On Wed, May 09, 2018 at 02:29:35PM +0300, David Kiarie wrote:
> We don't have a new company here. We have an almost four year old cat.
IANAL, but I think there's a precedent [1] for this, where at least a US court
ruled that "Specifically, the Copyright Office will not register works produced
by
---
tests/bhyveargv2xmldata/bhyveargv2xml-wired.args | 7 +
tests/bhyveargv2xmldata/bhyveargv2xml-wired.xml| 19
tests/bhyveargv2xmltest.c | 1 +
tests/bhyvexml2argvdata/bhyvexml2argv-wired.args | 10 ++
The element will now pass the
wired (-S) flag to the bhyve command.
---
src/bhyve/bhyve_command.c | 3 +++
src/bhyve/bhyve_parse_command.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index 9413ae5c1..e3f7ded7d 100644
---
---
docs/drvbhyve.html.in | 14 ++
docs/news.xml | 10 ++
2 files changed, 24 insertions(+)
diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in
index bde8298a5..5b5513d3d 100644
--- a/docs/drvbhyve.html.in
+++ b/docs/drvbhyve.html.in
@@ -430,6 +430,20 @@
This patch series adds support for locking guest memory to the bhyve
driver using the following elements
When specified, the -S flag is passed to the bhyve binary.
Fabian Freyer (3):
bhyve: add support for wiring memory
bhyve: add tests for wiring memory
bhyve: document
On 26 Apr 2018, at 18:38, John Ferlan wrote:
> On 04/13/2018 03:27 PM, Fabian Freyer wrote:
>> This commit adds the node to the domain definition,
>> with the following semantics:
>>
>> To pass standard input verbatim to the bootloader, set
>>
>> so
This commit adds the node to the domain definition,
with the following semantics:
To pass standard input verbatim to the bootloader, set
some stdin
Multiline standard input can be set using a CDATA tag:
Standard input can be read from a file as follows:
Signed-off-by: Fabian
Hello list,
Some host boot loaders, e.g. grub-bhyve when using the bhyve
driver, take commands on stdin. While there is the
tag to set arbitrary command line tags,
there is no or similar to provide standard
input to the boot loader.
Typical input could be something along the lines of e.g. the
ricky than on FreeBSD. Just
increasing ARG_MAX and recompiling xnu might work though. Then again, most
apple boxes tend to not run self-compiled kernels, so I would just go with your
second suggestion.
> Probably a better way would be to somehow reduce length of the command
> line.
On 08.03.2017 18:19, Michal Privoznik wrote:
> ACK, but we really need a better way to detect capabilites. For instance
> now, bhyve binary is executed 4 times just to find out whether it
> supports 4 capabilities. That's just madness. Maybe we can get in touch
> with bhyve developers and ask
On 24 Jan 2017, at 16:31, Laine Stump wrote:
+cmd = virCommandNew(binary);
+virCommandAddArgList(cmd, "-s", "0,ahci", NULL);
+virCommandSetErrorBuffer(cmd, );
Too bad there isn't some way you could learn both of these with a
single run of the binary.
+if (virCommandRun(cmd,
a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c
index d0af4d9..10c33b9 100644
--- a/src/bhyve/bhyve_capabilities.c
+++ b/src/bhyve/bhyve_capabilities.c
@@ -3,6 +3,7 @@
*
* Copyright (C) 2014 Roman Bogorodskiy
* Copyright (C) 2014 Semihalf
+ * Copyright (C) 2016 Fabian Freyer
of qemu_parse_command.c
(in bhyveCommandLine2argv), add the appropriate copyright notices.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
po/POTFILES.in | 1 +
src/Makefile.am | 2 +
src/bhyve/bhyve_driver.c| 41 ++
src
---
tests/Makefile.am | 23 ++-
.../bhyveargv2xmldata/bhyveargv2xml-acpiapic.args | 9 +
tests/bhyveargv2xmldata/bhyveargv2xml-acpiapic.xml | 20 ++
tests/bhyveargv2xmldata/bhyveargv2xml-ahci-hd.args | 8 +
tests/bhyveargv2xmldata/bhyveargv2xml-ahci-hd.xml
etwork, VIR_DOMAIN_NET_TYPE_ETHERNET is assumed, since it
is the most generic. If no mac is specified, one will be generated.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
src/bhyve/bhyve_parse_command.c | 514 +++-
1 file changed, 512 inse
Several gnulib headers rely on features.h being included by ctype.h to provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from checks
in src/internal.h.
Therefore, define __GNUC_PREREQ as early as
/msg01741.html
Link to v2:
https://www.redhat.com/archives/libvir-list/2016-June/msg00728.html
Link to v1:
https://www.redhat.com/archives/libvir-list/2016-June/msg1.html
Fabian Freyer (6):
config-post.h: define __GNUC_PREREQ if not defined
gnulib: add getopt module
bhyve
Unconditionally use gnulib's getopt module. This is needed by the bhyve driver
to provide a reentrant interface for getopt.
---
bootstrap.conf | 1 +
m4/virt-driver-bhyve.m4 | 3 +++
po/POTFILES.in | 1 +
3 files changed, 5 insertions(+)
diff --git a/bootstrap.conf
n adding a dependency to argp or duplicating lots
of the code of argp. Therefore it's not really worth implementing that now.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
src/bhyve/bhyve_parse_command.c | 117
1 file changed, 117 in
On some systems perl is not necessarily in /usr/bin/perl. Use the perl version
in the PATH instead.
---
tests/test-wrap-argv.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-wrap-argv.pl b/tests/test-wrap-argv.pl
index d66f5b4..b053f28 100755
---
---
tests/bhyvexml2argvdata/bhyvexml2argv-nouefi.args | 9 +
.../bhyvexml2argvdata/bhyvexml2argv-nouefi.ldargs | 1 +
tests/bhyvexml2argvdata/bhyvexml2argv-nouefi.xml | 23 ++
tests/bhyvexml2argvdata/bhyvexml2argv-uefi.args| 10 ++
this series of patches adds support for specifying UEFI boot images for bhyve
virtual machines.
The old behaviour is kept; only when a loader pflash is specified the loader
command is omitted and adds a bootrom parameter to the bhyverun command.
Fabian Freyer (4):
bhyve: Separate out checks
---
src/bhyve/bhyve_command.c | 6 ++
src/bhyve/bhyve_driver.c | 27 +++
2 files changed, 29 insertions(+), 4 deletions(-)
diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index 9ad3f9b..a504788 100644
--- a/src/bhyve/bhyve_command.c
+++
At the moment this is just one check, but separating this out into a
separate function makes checks more modular, allowing for more readable
code once more checks are added. This also makes checks more easily
testable.
---
src/bhyve/bhyve_capabilities.c | 31 ++-
1
Implement the BHACE_CAP_LPC_BOOTROM capability by checking the stderr
output of 'bhyve -l bootrom'. If the bootrom option is unsupported, this
will contain the following output:
bhyve: invalid lpc device configuration 'bootrom'
On newer bhyve versions that do support specifying a bootrom
---
tests/Makefile.am | 23 ++-
.../bhyveargv2xmldata/bhyveargv2xml-acpiapic.args | 9 +
tests/bhyveargv2xmldata/bhyveargv2xml-acpiapic.xml | 20 ++
tests/bhyveargv2xmldata/bhyveargv2xml-ahci-hd.args | 8 +
n adding a dependency to argp or duplicating lots
of the code of argp. Therefore it's not really worth implementing that now.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
src/bhyve/bhyve_parse_command.c | 117
1 file changed, 117 in
etwork, VIR_DOMAIN_NET_TYPE_ETHERNET is assumed, since it
is the most generic. If no mac is specified, one will be generated.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
src/bhyve/bhyve_parse_command.c | 512 +++-
1 file changed, 510 inse
of qemu_parse_command.c
(in bhyveCommandLine2argv), add the appropriate copyright notices.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
po/POTFILES.in | 1 +
src/Makefile.am | 2 +
src/bhyve/bhyve_driver.c| 42 +++
src
Unconditionally use gnulib's getopt module. This is needed by the bhyve driver
to provide a reentrant interface for getopt.
---
bootstrap.conf | 1 +
m4/virt-driver-bhyve.m4 | 3 +++
2 files changed, 4 insertions(+)
diff --git a/bootstrap.conf b/bootstrap.conf
index 0db6b62..edea8c3
(resent due to mail client line mangling)
Several gnulib headers rely on features.h being included by ctype.h to provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from checks
in src/internal.h.
Several gnulib headers rely on features.h being included by ctype.h to
provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from
checks
in src/internal.h.
Therefore, define __GNUC_PREREQ as early as
com/archives/libvir-list/2016-June/msg1.html
Fabian Freyer (6):
config-post.h: define __GNUC_PREREQ if not defined
gnulib: add getopt module
bhyve: implement virConnectDomainXMLFromNative
bhyve: implement bhyve argument parser
bhyve: implement argument parser for loader
Add some te
an empty XML document to be returned.
Link to v2:
https://www.redhat.com/archives/libvir-list/2016-June/msg00728.html
Link to v1:
https://www.redhat.com/archives/libvir-list/2016-June/msg1.html
Fabian Freyer (5):
config-post.h: define __GNUC_PREREQ if not defined
gnulib: add getopt
n adding a dependency to argp or duplicating lots
of the code of argp. Therefore it's not really worth implementing that now.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
src/bhyve/bhyve_parse_command.c | 122
1 file changed, 122 in
of qemu_parse_command.c
(in bhyveCommandLine2argv), add the appropriate copyright notices.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
po/POTFILES.in | 1 +
src/Makefile.am | 2 +
src/bhyve/bhyve_driver.c| 42 +++
src
ly tap devices are supported. Since it isn't possible to tell
the type of the network, VIR_DOMAIN_NET_TYPE_ETHERNET is assumed, since it
is the most generic. If no mac is specified, one will be generated.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
--
Several gnulib headers rely on features.h being included by ctype.h to provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from checks
in src/internal.h.
Therefore, define __GNUC_PREREQ as early as
Unconditionally use gnulib's getopt module. This is needed by the bhyve driver
to provide a reentrant interface for getopt.
---
bootstrap.conf | 1 +
m4/virt-driver-bhyve.m4 | 3 +++
2 files changed, 4 insertions(+)
diff --git a/bootstrap.conf b/bootstrap.conf
index 0db6b62..edea8c3
On 12/06/16 15:29, Roman Bogorodskiy wrote:
> Fabian Freyer wrote:
>
>> A simpe getopt-based argument parser is added for the /usr/sbin/bhyve
>> command,
>> loosely based on its argument parser, which reads the following from the
>> bhyve
>> command line
On 12/06/16 16:03, Roman Bogorodskiy wrote:
> Fabian Freyer wrote:
>
>> First, remove escaped newlines and split up the string into an argv-list for
>> the bhyve and loader commands, respectively. This is done by iterating over
>> the
>> string splitting it by n
ly tap devices are supported. Since it isn't possible to tell
the type of the network, VIR_DOMAIN_NET_TYPE_ETHERNET is assumed, since it
is the most generic. If no mac is specified, one will be generated.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
--
of qemu_parse_command.c
(in bhyveCommandLine2argv), add the appropriate copyright notices.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
po/POTFILES.in | 1 +
src/Makefile.am | 2 +
src/bhyve/bhyve_driver.c| 42 +++
src
Unconditionally use gnulib's getopt module. This is needed by the bhyve driver
to provide a reentrant interface for getopt.
---
bootstrap.conf | 1 +
m4/virt-driver-bhyve.m4 | 3 +++
2 files changed, 4 insertions(+)
diff --git a/bootstrap.conf b/bootstrap.conf
index 0db6b62..edea8c3
n adding a dependency to argp or duplicating lots
of the code of argp. Therefore it's not really worth implementing that now.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
src/bhyve/bhyve_parse_command.c | 122
1 file changed, 122 in
Several gnulib headers rely on feature.h being included by ctype.h to provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from checks
in src/internal.h.
Therefore, define __GNUC_PREREQ as early as
:
https://www.redhat.com/archives/libvir-list/2016-June/msg1.html
Fabian Freyer (5):
config-post.h: define __GNUC_PREREQ if not defined
gnulib: add getopt module
bhyve: implement virConnectDomainXMLFromNative
bhyve: implement bhyve argument parser
bhyve: implement argument parser
would
likely always be the first header pulled in (through config.h).
Link to v1:
https://www.redhat.com/archives/libvir-list/2016-June/msg00001.html
Fabian Freyer (5):
config-post.h: define __GNUC_PREREQ if not defined
gnulib: add getopt module
bhyve: implement virConnectDom
ly tap devices are supported. Since it isn't possible to tell
the type of the network, VIR_DOMAIN_NET_TYPE_ETHERNET is assumed, since it
is the most generic. If no mac is specified, one will be generated.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
--
n adding a dependency to argp or duplicating lots
of the code of argp. Therefore it's not really worth implementing that now.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
src/bhyve/bhyve_parse_command.c | 122
1 file changed, 122 in
Unconditionally use gnulib's getopt module. This is needed by the bhyve driver
to provide a reentrant interface for getopt.
---
bootstrap.conf | 1 +
m4/virt-driver-bhyve.m4 | 3 +++
2 files changed, 4 insertions(+)
diff --git a/bootstrap.conf b/bootstrap.conf
index 0db6b62..edea8c3
Several gnulib headers rely on feature.h being included by ctype.h to provide
__GNUC_PREREQ, but on systems without glibc, this is not provided. In these
cases __GNUC_PREREQ gets redefined to 0, which causes build errors from checks
in src/internal.h.
Therefore, define __GNUC_PREREQ as early as
On 01/06/16 10:21, Fabian Freyer wrote:
> A simpe getopt-based argument parser is added for the /usr/sbin/bhyve command,
> loosely based on its argument parser, which reads the following from the bhyve
> command line string:
getopt is not thread safe, so can't use that here. There are
n adding a dependency to argp or duplicating lots
of the code of argp. Therefore it's not really worth implementing that now.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
src/bhyve/bhyve_parse_command.c | 119
1 file changed, 119 in
ly tap devices are supported. Since it isn't possible to tell
the type of the network, VIR_DOMAIN_NET_TYPE_ETHERNET is assumed, since it
is the most generic. If no mac is specified, one will be generated.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
--
of qemu_parse_command.c
(in bhyveCommandLine2argv), add the appropriate copyright notices.
Signed-off-by: Fabian Freyer <fabian.fre...@physik.tu-berlin.de>
---
po/POTFILES.in | 1 +
src/Makefile.am | 2 +
src/bhyve/bhyve_driver.c| 42 +++
src
handling involved especially in the first
patch that I am not 100% sure about, I'd appreciate a thorough review.
Fabian Freyer (3):
bhyve: implement virConnectDomainXMLFromNative
bhyve: implement bhyve argument parser
bhyve: implement argument parser for loader
po/POTFILES.in
At the moment the bootloader arguments never get formatted if the bootloader is
unset. However, in cases where the bootloader defaults to a default value when
unset, specifying bootloader arguments does make sense.
---
src/conf/domain_conf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
Trivially return 1, since bhyve is considered a local connection that
should not be vulnerable to eavesdropping.
---
src/bhyve/bhyve_driver.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 43c7183..441c666 100644
---
Being a local connection, bhyve does not support encryption. Therefore
trivially return 0.
---
src/bhyve/bhyve_driver.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 8b41f7a..43c7183 100644
--- a/src/bhyve/bhyve_driver.c
+++
These patches implement some rather trivial missing calls in the bhyve driver.
Since the bhyve connection (Interaction through /dev/vmm as well as the
bhyveload, bhyvectl user-space tools) is local, encryption is not applicable,
but the connection is seen as not prone to eavesdropping.
Fabian
On 13.05.2016 20:37, Cole Robinson wrote:
> ATTRIBUTED_UNUSED tells the compiler not to throw a warning if the parameter
> ('conn' in this case) isn't used in the function. So if the function _does_
> use the parameter, the annotation is incorrect.
>
> That means that if you grabbed that pattern
bhyve connections are local, and a "connection will be classed as alive
if it is [...] local".
---
src/bhyve/bhyve_driver.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index c3c572e..8b41f7a 100644
--- a/src/bhyve/bhyve_driver.c
This is not needed here, since the conn parameter is used in the ACL
checking calls, which were introduced in abf75aea2.
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index c4c4968..37d970e 100644
---
This implements virConnectGetType for the bhyve driver.
---
src/bhyve/bhyve_driver.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 4fc504e..a853e94 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@
Hi,
I'd also like to introduce myself.
My name is Fabian Freyer, and I'm very happy to be accepted as a GSoC
student this year. I currently study physics at the Technical University
of Berlin, but am working as a sysadmin in the FreeBSD world. Since my
project "Improving libvirt su
73 matches
Mail list logo
