On Mon, Dec 2, 2019 at 4:41 PM Fabiano Fidêncio wrote:
>
> Jim,
>
> Firstly, sorry it took so long for me to give it a try in your patch.
>
> Now, comments inline ...
>
> On Tue, Nov 26, 2019 at 1:52 AM Jim Fehlig wrote:
> >
> > This change adds supp
10,6 +10,7 @@ all_machines:
- libvirt-freebsd-11
- libvirt-freebsd-12
- libvirt-freebsd-current
+ - libvirt-opensuse-15
- libvirt-ubuntu-16
- libvirt-ubuntu-18
rpm_machines:
diff --git a/guests/playbooks/build/projects/libvirt.yml
b/guests/playbooks/build/projects/libvirt.yml
index 4b3dfdf..3e3dbba 100644
--- a/guests/playbooks/build/projects/libvirt.yml
+++ b/guests/playbooks/build/projects/libvirt.yml
@@ -19,6 +19,7 @@
- libvirt-fedora-30
- libvirt-fedora-31
- libvirt-fedora-rawhide
+ - libvirt-opensuse-15
- libvirt-ubuntu-16
- libvirt-ubuntu-18
- include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
diff --git a/guests/playbooks/update/tasks/paths.yml
b/guests/playbooks/update/tasks/paths.yml
index 770680e..c258ad2 100644
--- a/guests/playbooks/update/tasks/paths.yml
+++ b/guests/playbooks/update/tasks/paths.yml
@@ -17,7 +17,7 @@
- su
- name: 'Look for files'
- shell: 'find /etc /usr/local/etc -name {{ item }} 2>/dev/null'
+ shell: 'find /usr/local/etc -name {{ item }} 2>/dev/null || find
/etc -name {{ item }} 2>/dev/null'
register: find
with_items:
- sudoers
diff --git a/guests/playbooks/update/tasks/users.yml
b/guests/playbooks/update/tasks/users.yml
index 0470686..bf149da 100644
--- a/guests/playbooks/update/tasks/users.yml
+++ b/guests/playbooks/update/tasks/users.yml
@@ -18,12 +18,18 @@
line: 'PermitRootLogin without-password'
state: present
+- name: '{{ flavor }}: Ensure group exists'
+ group:
+name: '{{ flavor }}'
+state: present
+
- name: '{{ flavor }}: Create user account'
user:
name: '{{ flavor }}'
comment: '{{ flavor }}'
password: '*'
shell: '{{ bash }}'
+group: '{{ flavor }}'
- name: '{{ flavor }}: Set password'
user:
```
I know Andrea suggested to change the way we deal with finding sudoers
but, IMHO, it shouldn't be a blocker for your patches. However, I'm
*not* the maintainer of the project. :-)
So, with those changes, Leap works and we can build libvirt.
What I'd suggest:
- Submit a patch just adding Leap (and then you'll have to have an
agreement with Andrea about whether we'll support 15 or 15.x);
- After that, let's try to figure out the issue with Tumbleweed and,
only then, try to have it merged;
Does that make sense? Andrea, Jim, are we on the same page here?
Best Regards,
--
Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
> +
> %define with_numactl 0%{!?_without_numactl:1}
>
> # F25+ has zfs-fuse
> --
> 2.24.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
> virReportError(VIR_ERR_INTERNAL_ERROR,
> - _("machine type %s too big for destination"),
> + _("host arch %s too big for destination"),
> virArchToString(hostarch));
> goto cleanup;
> }
&
On Mon, Nov 25, 2019 at 4:41 PM Peter Krempa wrote:
>
> Commit d30a1ad0443 translated the symbol file checker from perl to
> python by doing a literal translation in most cases. Unfortunately one
> string formatting operation was not really translated into python
> leaving users with non-helpful e
On Tue, Nov 26, 2019 at 2:11 AM Jim Fehlig wrote:
>
> Grrr, I keep forgetting something within '--subject-prefix=' when sending
> these
> patches...
Are you aware of git-publish?
https://github.com/stefanha/git-publish
Best Regards,
--
Fabiano Fidêncio
--
libvir-li
On Tue, Nov 26, 2019 at 2:21 AM Jim Fehlig wrote:
>
> On 11/19/19 6:52 AM, Fabiano Fidêncio wrote:
> > On Tue, Nov 19, 2019 at 11:33 AM Andrea Bolognani
> > wrote:
> >>
> >> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
> >>> Signed-off-
; This expands the Travis CI coverage to add latest Fedora stable
> and rawhide, so that it is covering a representative set of
> distros overall.
>
> Daniel P. Berrangé (1):
> travis: add fedora-31 & fedora-rawhide to the build images
>
> .travis.yml | 14 ++
>
On Wed, Nov 20, 2019 at 10:46 PM Jim Fehlig wrote:
>
> On 11/20/19 2:16 PM, Fabiano Fidêncio wrote:
> > On Wed, Nov 20, 2019 at 8:44 PM Jim Fehlig wrote:
> >>
> >> On 11/19/19 11:56 PM, Fabiano Fidêncio wrote:
> >>> On Wed, Nov 20, 2019 at 12:01 AM Jim
On Wed, Nov 20, 2019 at 8:44 PM Jim Fehlig wrote:
>
> On 11/19/19 11:56 PM, Fabiano Fidêncio wrote:
> > On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote:
> >>
> >> On 11/19/19 3:32 AM, Andrea Bolognani wrote:
> >>> On Tue, 2019-11-19 at 00:21 +,
son.c
> @@ -40,7 +40,6 @@
> #include "virprobe.h"
> #include "virstring.h"
> #include "cpu/cpu_x86.h"
> -#include "c-strcasestr.h"
> #include "virenum.h"
>
> #ifdef WITH_DTRACE_PROBES
> --
> 2.23.0
>
> --
&g
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig wrote:
>
> On 11/19/19 3:32 AM, Andrea Bolognani wrote:
> > On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
> >> Signed-off-by: Jim Fehlig
> >> ---
> >> guests/configs/autoinst.xml | 86 +++
> >> .../libvirt-ope
On Wed, Nov 20, 2019 at 12:11 AM Jim Fehlig wrote:
>
> On 11/19/19 6:52 AM, Fabiano Fidêncio wrote:
> > On Tue, Nov 19, 2019 at 11:33 AM Andrea Bolognani
> > wrote:
> >>
> >> On Tue, 2019-11-19 at 00:21 +, Jim Fehlig wrote:
> >>> Signed-off-
ame as above
- yajl:
- It seems to be called libyajl-devel for openSUSE
- Look for files
- There's a "Look for files" rule (in
guests/playbooks/update/tasks/paths.yml) which will just bail out as
/usr/local/etc doesn't exist in openSUSE. It has to be tweaked as
well;
- Configure ccache:
- This is a rule in guests/playbooks/update/tasks/users.yml, which
takes into consideration that when the test user is created, we'll
have a test group created as well, which doesn't happen on openSUSE.
So, it also need some tweak;
I didn't write a patch for those, sorry, but I hope it gives you some
idea on the problems I faced (and that you'll face) and how to solve
then.
Once those are solved/worked around, you'll be able to run the
"update" command and then, finally, you'll be able to expand
guests/playbooks/build/projects/ in order to add openSUSE there and
check whether we can successfully build the projects using openSUSE.
Here I'm assuming your main goal is libvirt. Once that's done, I can
do the work for libosinfo, osinfo-db-tools, and osinfo-db.
Best Regards,
--
Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
> help subcommand').", "In this case a specific package providing the subcommand
> needs to be installed first. Those packages are often named
> 'zypper-autoremove'
> or 'zypper-autoremove-plugin'."]}
>
> PLAY RECAP
> ***
ra 31
> > Start building on Fedora 31
> > Stop building on Fedora 29
> > guests: Drop Fedora 29
>
> Reviewed-by: Erik Skultety
Also, Reviewed-by: Fabiano Fidêncio
Would you mind also sending patches to the dockerfiles?
Best Regards,
--
libvir-list mailing list
li
d missing entries
>
> docs/gitdm/companies/others| 4 +++-
> docs/gitdm/groups/opensource | 1 +
> docs/gitdm/groups/unaffiliated | 2 ++
> 3 files changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Oct 15, 2019 at 10:13 AM Andrea Bolognani wrote:
>
> On Tue, 2019-10-15 at 08:45 +0200, Fabiano Fidêncio wrote:
> > Add Fabiano Fidencio to Planet Virt-Tools
>
> s/Fidencio/Fidêncio/
This would break git publish. :-)
>
> > Signed-off-by: Fabiano Fidêncio
>
Signed-off-by: Fabiano Fidêncio
---
updater/virt-tools/config.ini | 3 +++
1 file changed, 3 insertions(+)
diff --git a/updater/virt-tools/config.ini b/updater/virt-tools/config.ini
index 6b4b5ec..9375c82 100644
--- a/updater/virt-tools/config.ini
+++ b/updater/virt-tools/config.ini
@@ -194,3
POSIX characteres, such as "Fidêncio".
Unfortunately, there's no standard way to do this accross different
distros, leaving us with this "happy little accident" of setting up LANG
in the way it's done right now.
Signed-off-by: Fabiano Fidêncio
---
guests/lcitool | 4
On Wed, Oct 9, 2019 at 6:03 PM Daniel P. Berrangé wrote:
>
> On Wed, Oct 09, 2019 at 05:52:27PM +0200, Fabiano Fidêncio wrote:
> > Since commit d63d6a59cc we're installing EPEL on CentOS7 in order to
> > have both "ninja" and "python36-*" packages in t
Since commit d63d6a59cc we're installing EPEL on CentOS7 in order to
have both "ninja" and "python36-*" packages in the system.
However, we've forgot to add the very code to the lcitool so the
containers would also have EPEL release installed.
Signed-off-by: Fabiano
python3-setuptools is an ansible pip module dependency, which is not
automatically pulled in.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/projects/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index 23cf14d
python3-setuptools is an ansible pip module dependency, which is not
automatically pulled in.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 4
1 file changed, 4 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index ba0f1cf..02bf8fd 100644
match the minimum required version.
Fabiano Fidêncio (3):
guests: Move python3 to the base project
mappings: Add python3-setuptools
guests: Add python3-setuptools to the base project
guests/vars/mappings.yml | 4
guests/vars/projects/base.yml| 2 ++
guests/var
As a bunch of projects already directly depend on python3 (libvirt-dbus,
libvirt-python, osinfo-db-tools, osinfo-db, virt-manager), and some
depend on it indirectly (as libvirt or anything else depending on
flake8), let's add python3 to the base project.
Signed-off-by: Fabiano Fid
On Wed, Oct 9, 2019 at 12:56 PM Fabiano Fidêncio wrote:
>
> This will bring back the ability to have CentOS7, Debian9, Ubuntu16 and
> Ubuntu18 containers.
>
> The corresponding libvirt-jenkins-ci commit is b6aabedc67ca.
>
> Signed-off-by: Fabiano Fidêncio
Self-nack as Andr
On Wed, Oct 9, 2019 at 12:18 PM Andrea Bolognani wrote:
>
> Now that we can install Meson from pip, building libosinfo and
> friends is once again possible on these platforms.
>
> Signed-off-by: Andrea Bolognani
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-
This will bring back the ability to have CentOS7, Debian9, Ubuntu16 and
Ubuntu18 containers.
The corresponding libvirt-jenkins-ci commit is b6aabedc67ca.
Signed-off-by: Fabiano Fidêncio
---
https://gitlab.com/fidencio/libvirt-dockerfiles/tree/wip/more_libosinfo_containers
---
buildenv
As libvirt-dbus has switched to using Meson instead of autotools, let's
switch its jobs here.
During the switch, `make check` and `make syntax-check` got merged into
`ninja test`, which is reflected here by merging those two jobs.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolo
Let's install meson via pip whenever meson is not available at all or
does not match the minimum required version.
Signed-off-by: Fabiano Fidêncio
---
guests/lcitool | 25
guests/playbooks/update/tasks/packages.yml | 44 ++
g
pip will be used to install meson on OSes which do not have support to
the minimum required version of the project.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/vars/mappings.yml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/guests/vars/mappings.yml b
As now we've the needed packages for building and testing osinfo-db
on all systems supported by libvirt-jenkins-ci, let's build osinfo-db
everywhere.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/host_vars/libvirt-centos-7/main.yml| 1 +
guests/host_va
As now we've the needed packages for building and testing
osinfo-db-tools on all systems supported by libvirt-jenkins-ci, let's
build osinfo-db-tools everywhere.
RPM build is still not possible in CentOS7 as it doesn't have the
needed RPM macros for Meson.
Signed-off-by: F
.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/vars/mappings.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index 5c32c94..f69937a 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -816,6
As osinfo-db-tools, osindo-db, and libosinfo can now be built again on
Debian9 and Ubuntu18, let's enable virt-manager builds on those OSes as
well.
This commit partilly reverts 570143fc41fa270.
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-debian-9/main.yml | 1 +
g
As latest CentOS 7 has added python3, CentOS 7 has support to python3,
let's run syntax-check job the project.
Also, let's update the comment explaining that we don't run `make check`
on CentOS 7 because python3-pytest version is too old.
Signed-off-by: Fabiano Fidêncio
Revi
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/vars/projects/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index a8c83ac..ec04fdf 100644
--- a/guests/vars/projects/base.yml
+++ b/guests/vars
From: Daniel P. Berrangé
Reviewed-by: Fabiano Fidêncio
Signed-off-by: Daniel P. Berrangé
---
guests/vars/projects/libvirt.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml
index 04c3ecd..8fcb286 100644
--- a/guests/vars
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/vars/projects/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index f008de3..a8c83ac 100644
--- a/guests/vars/projects/base.yml
+++ b/guests/vars
As now we've the needed packages for building and testing libosinfo
on all systems supported by libvirt-jenkins-ci, let's build libosinfo
everywhere.
RPM build is still not possible in CentOS7 as it doesn't have the
needed RPM macros for Meson.
Signed-off-by: Fabiano Fidênc
some misleading comment.
Finally, last patch in the series does the libvirt-dbus builds switch to
using meson instead of autotools.
This version addresses the comments raised by Andrea during v2.
Daniel P. Berrangé (1):
guests: add flake8 to libvirt project
Fabiano Fidêncio (11):
mappings
wantwarn="$wantwarn -Wno-cast-function-type"
>
> +# CLang incorrectly complains about dup typedefs win gnu99 mode
> +# so use this CLang-specific arg to keep it quiet
> +wantwarn="$wantwarn -Wno-typedef-redefinition"
> +
Is this the *only* failure we
lready reviewed and will be pushed as soon as we have
libvirt-jenkins-ci work merged.
Best Regards,
--
Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
;
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Ubuntu is not a supported OS in jenkins.
Signed-off-by: Fabiano Fidêncio
---
jenkins/projects/libvirt-dbus.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/jenkins/projects/libvirt-dbus.yaml
b/jenkins/projects/libvirt-dbus.yaml
index 1693d24..3accc5d 100644
--- a
As libvirt-dbus has switched to using Meson instead of autotools, let's
switch its jobs here.
During the switch, `make check` and `make syntax-check` got merged into
`ninja test`, which is reflected here by merging those two jobs.
Signed-off-by: Fabiano Fidêncio
---
.../playbooks/
As latest CentOS 7 has added python3, CentOS 7 has support to python3,
let's run syntax-check job the project.
Also, let's update the comment explaining that we don't run `make check`
on CentOS 7 because python3-pytest version is too old.
Signed-off-by: Fabiano Fidêncio
---
g
As now we've the needed packages for building and testing osinfo-db
on all systems supported by libvirt-jenkins-ci, let's build osinfo-db
everywhere.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/host_vars/libvirt-centos-7/main.yml| 1 +
guests/host_va
some misleading comment.
Finally, last patch in the series does the libvirt-dbus builds switch to
using meson instead of autotools.
Fabiano Fidêncio (12):
mappings: Add python2-setuptools
guests: Add python2-setuptools to the base project
mappings: Add python3-pip
guests: Add python3-pip t
As now we've the needed packages for building and testing
osinfo-db-tools on all systems supported by libvirt-jenkins-ci, let's
build osinfo-db-tools everywhere.
RPM build is still not possible in CentOS7 as it doesn't have the
needed RPM macros for Meson.
Signed-off-by: F
As now we've the needed packages for building and testing libosinfo
on all systems supported by libvirt-jenkins-ci, let's build libosinfo
everywhere.
RPM build is still not possible in CentOS7 as it doesn't have the
needed RPM macros for Meson.
Signed-off-by: Fabiano Fidênc
Signed-off-by: Fabiano Fidêncio
---
guests/vars/projects/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index f008de3..a8c83ac 100644
--- a/guests/vars/projects/base.yml
+++ b/guests/vars/projects/base.yml
@@ -25,6 +25,7
Let's install meson via pip whenever meson is not available at all or
does not match the minimum required version.
Signed-off-by: Fabiano Fidêncio
---
guests/lcitool | 17 +++
guests/playbooks/update/tasks/packages.yml | 35 ++
guests
As osinfo-db-tools, osindo-db, and libosinfo can now be built again on
Debian9 and Ubuntu18, let's enable virt-manager builds on those OSes as
well.
This commit partilly reverts 570143fc41fa270.
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-7/main.yml | 1 +
g
pip will be used to install meson on OSes which do not have support to
the minimum required version of the project.
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/vars/mappings.yml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/guests/vars/mappings.yml b
.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index 5c32c94..8640d15 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -787,6 +787,9 @@ mappings:
rpm
Signed-off-by: Fabiano Fidêncio
Reviewed-by: Andrea Bolognani
---
guests/vars/projects/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index a8c83ac..ec04fdf 100644
--- a/guests/vars/projects/base.yml
+++ b/guests/vars
- ebtables
>- fuse
> + - glib2
>- glusterfs
>- gnutls
>- hal
> --
> 2.21.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
; --
> 2.21.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
irt src tools docs gnulib/tests \
>tests po examples
>
> --
> 2.21.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
086c19d69 added bochs-display capability but didn't fill in the info for
domain capabilities.
Signed-off-by: Fabiano Fidêncio
---
src/qemu/qemu_capabilities.c | 2 ++
tests/domaincapsschemadata/qemu_3.1.0.x86_64.xml | 1 +
tests/domaincapsschemadata/qemu_4.0.0.x86_64.xm
gt; jenkins/projects/virt-manager.yaml | 2 --
> 8 files changed, 16 deletions(-)
>
> --
> 2.21.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
Reviewed-by: Fabiano Fidêncio
--
libvir-list
Mind that check & syntax-check jobs have been merged as we dropped
syntax-check target from our Meson builds.
Signed-off-by: Fabiano Fidêncio
---
.../playbooks/build/projects/libvirt-dbus.yml | 23 ---
jenkins/projects/libvirt-dbus.yaml| 18 +++
2 f
As now we've the needed packages for building and testing osinfo-db
on all systems supported by libvirt-jenkins-ci, let's just build
osinfo-db everywhere.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/build/projects/osinfo-db.yml | 14 +-
jenkins/projects/osin
As now we've the needed packages for building and testing libosinfo
on all systems supported by libvirt-jenkins-ci, let's just build
libosinfo everywhere.
RPM build is still not possible in CentOS7 as it doesn't have the
needed RPM macros for Meson.
Signed-off-by: Fabiano Fidênc
As now we've the needed packages for building and testing
osinfo-db-tools on all systems supported by libvirt-jenkins-ci, let's
just build osinfo-db-tools everywhere.
RPM build is still not possible in CentOS7 as it doesn't have the
needed RPM macros for Meson.
Signed-off-by: F
Let's install meson via pip whenever meson is not available at all or
does not match the minimum required version.
Signed-off-by: Fabiano Fidêncio
---
guests/lcitool | 13 +
guests/playbooks/update/tasks/packages.yml | 8
2 files change
Signed-off-by: Fabiano Fidêncio
---
guests/vars/projects/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index f008de3..e90d12e 100644
--- a/guests/vars/projects/base.yml
+++ b/guests/vars/projects/base.yml
@@ -24,6 +24,7
Those are the python36-* packages which we depend on and are provided by
EPEL repo*.
*: https://dl.fedoraproject.org/pub/epel/7/x86_64/Packages/p/
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a
pip will be used to install meson on OSes which do not have support to
the minimum required version of the project.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 5 +
1 file changed, 5 insertions(+)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index
As latest CentOS7 release includes python3, let's update python3
mapping.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/mappings.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index bc6ea69..88a8350 100644
--- a/guests
EPEL will be needed in order to have both "ninja" and "python36-*"
packages installed on CentOS7.
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/update/tasks/base.yml | 7 +++
1 file changed, 7 insertions(+)
diff --git a/guests/playbooks/update/tasks/base.yml
tools, osinfo-db, and libosinfo
on all supported machines as those now have the minimum requirements
needed.
Last patch in the series does the libvirt-dbus builds switch to using
meson instead of autotools.
Fabiano Fidêncio (17):
guests: Deal with multilib path
guests: CentOS7 provides python3
g
Signed-off-by: Fabiano Fidêncio
---
guests/vars/projects/base.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index b575079..f008de3 100644
--- a/guests/vars/projects/base.yml
+++ b/guests/vars/projects
Although ninja is a meson dependency, some OSes do not have support to
meson. Knowning that, let's explicitly add a "ninja" mapping so we get
it installed even when "meson" is not supported. It'll help us, later
on, when we install meson from pip.
Signed-off-by: Fabi
Meson is not supported in the following OSes we support:
- CentOS7: not packaged;
- Debian9: packaged, but version is older than 0.49.0;
- Ubuntu16: packaged, but version is older than 0.49.0;
- Ubuntu18: packaged, but version is older than 0.49.0;
Signed-off-by: Fabiano Fidêncio
---
guests
Together with this change, let's also remove meson as a dependency from
the projects which are already depending on it.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/projects/base.yml| 1 +
guests/vars/projects/libosinfo+mingw32.yml | 1 -
guests/vars/pro
signed-off-by: Fabiano Fidêncio
---
guests/vars/projects/base.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
index be24e06..b575079 100644
--- a/guests/vars/projects/base.yml
+++ b/guests/vars/projects/base.yml
@@ -20,6 +20,7
'%{_lib}'`
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/update/templates/bashrc.j2 | 17 +
1 file changed, 17 insertions(+)
diff --git a/guests/playbooks/update/templates/bashrc.j2
b/guests/playbooks/update/templates/bashrc.j2
index 1f39cf2..794398c 100644
--
Different OSes have a different name for ninja binary. In some of them,
it's called "ninja", in others "ninja-build".
Let's allow both in the very same way we already deal with make x gmake
and start using a NINJA environmnet variable instead of always relying
on &q
eases/.
Reviewed-by: Fabiano Fidêncio
> ---
>
> Notes:
> I'm wondering whether we shouldn't drop the secondary i686 sections as
> well
> since i686 will die starting with fedora 31. On a similar note with UML,
> upstream libvirt dropped it a while ago.
Since the switch to meson, libosinfo's archive format is "xz" instead of
"gz".
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/build/projects/libosinfo+mingw32.yml | 2 +-
guests/playbooks/build/projects/libosinfo+mingw64.yml | 2 +-
guests/playbooks/bui
libosinfo has switched its build system to meson and requires 0.49.0 or
newer.
Signed-off-by: Fabiano Fidêncio
---
guests/host_vars/libvirt-centos-7/main.yml| 1 -
guests/host_vars/libvirt-debian-9/main.yml| 1 -
guests/host_vars/libvirt-ubuntu-16/main.yml | 1 -
guests/host_vars
It's been introduced as dependency as part of v1.7.0 development cycle.
Signed-off-by: Fabiano Fidêncio
---
guests/vars/projects/libosinfo+mingw32.yml | 1 +
guests/vars/projects/libosinfo+mingw64.yml | 1 +
guests/vars/projects/libosinfo.yml | 1 +
3 files changed, 3 inser
Signed-off-by: Fabiano Fidêncio
---
guests/playbooks/build/projects/libosinfo+mingw32.yml | 4 ++--
guests/playbooks/build/projects/libosinfo+mingw64.yml | 4 ++--
guests/playbooks/build/projects/libosinfo.yml | 7 +++
jenkins/projects/libosinfo+mingw32.yaml | 4
sinfo MR acked.
Fabiano Fidêncio (4):
libosinfo: Add meson dependency
Only build libosinfo on systems with meson >= 0.49.0
Update libosinfo's archive_format
Switch libosinfo builds to Meson
guests/host_vars/libvirt-centos-7/main.yml| 1 -
guests/host_vars/libvirt-debian-9/mai
On Mon, Sep 23, 2019 at 3:40 PM Daniel P. Berrangé wrote:
>
> On Mon, Sep 23, 2019 at 03:37:15PM +0200, Fabiano Fidêncio wrote:
> > On Mon, Sep 23, 2019 at 2:51 PM Daniel P. Berrangé
> > wrote:
> > >
> > > On Mon, Sep 23, 2019 at 02:33:43PM +0200, Andrea Bolo
On Mon, Sep 23, 2019 at 2:51 PM Daniel P. Berrangé wrote:
>
> On Mon, Sep 23, 2019 at 02:33:43PM +0200, Andrea Bolognani wrote:
> > On Mon, 2019-09-23 at 13:23 +0200, Fabiano Fidêncio wrote:
> > > name: libvirt-dbus
> > > +# libvirt-dbus depends on meson 0.
On Mon, Sep 23, 2019 at 1:16 PM Andrea Bolognani wrote:
>
> On Mon, 2019-09-23 at 11:47 +0100, Daniel P. Berrangé wrote:
> > On Mon, Sep 23, 2019 at 12:43:18PM +0200, Andrea Bolognani wrote:
> > > On Mon, 2019-09-23 at 12:10 +0200, Fabiano Fidêncio wrote:
> > > >
libvirt-dbus has switched its build system to meson and requires 0.49.0
or newer. It means, let's *not* build libvirt-dbus on:
- Debian 9 (or older);
- Ubuntu 18 (or older);
- CentOS 7
Signed-off-by: Fabiano Fidêncio
---
.../playbooks/build/projects/libvirt-dbus.yml
On Mon, Sep 23, 2019 at 12:38 PM Pavel Hrdina wrote:
>
> On Mon, Sep 23, 2019 at 12:31:34PM +0200, Andrea Bolognani wrote:
> > On Mon, 2019-09-23 at 11:02 +0100, Daniel P. Berrangé wrote:
> > > On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote:
> > > > For what it's worth, I also pr
On Thu, Sep 19, 2019 at 11:11 AM Pavel Hrdina wrote:
>
> On Wed, Sep 18, 2019 at 06:19:54PM +0200, Fabiano Fidêncio wrote:
> > It's been agreed that the projects using libvirt-jenkins-ci would have
> > the `syntax-check` running as part of their test suite. Therefore,
&g
On Fri, Sep 20, 2019 at 2:34 PM Fabiano Fidêncio wrote:
>
> [snip]
>
> >
> > > In general, it looks good and works as expected.
> > > I will add my "Reviewed-by: " after we discuss the points raised.
> > >
> > > Another thing, please,
gets merged.
>
> Works for me, thanks for review, I'll fix the dist script to use a shell
> script.
>
Reviewed-by: Fabiano Fidêncio
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, Sep 20, 2019 at 1:28 PM Fabiano Fidêncio wrote:
>
> On Fri, Sep 20, 2019 at 11:05 AM Pavel Hrdina wrote:
> >
> > Meson build system is simple and quick compared to Autotools and it's
> > able to fully replace our Autotools usage. There are few drawbacks a
On Fri, Sep 20, 2019 at 11:05 AM Pavel Hrdina wrote:
>
> Meson build system is simple and quick compared to Autotools and it's
> able to fully replace our Autotools usage. There are few drawbacks as
> it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0,
> it's still evolving an
https://bugzilla.redhat.com/show_bug.cgi?id=1753670
Signed-off-by: Fabiano Fidêncio
---
libvirt-gconfig/libvirt-gconfig-domain-video.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-video.h
b/libvirt-gconfig/libvirt-gconfig-domain
On Wed, Sep 18, 2019 at 9:57 PM Ján Tomko wrote:
>
> On Wed, Sep 18, 2019 at 05:40:06PM +0200, Fabiano Fidêncio wrote:
> >On Wed, Sep 18, 2019 at 1:22 AM Fabiano Fidêncio wrote:
> >>
> >> On Tue, Sep 17, 2019 at 8:17 PM Pavel Hrdina wrote:
> >> >
>
201 - 300 of 626 matches
Mail list logo
