Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

I find the issue cannot reproduced when `make clean` before build the source. It is not proper to build with an unclean source dir, right? On Tue, Oct 15, 2019 at 3:55 AM Cole Robinson wrote: > On 10/12/19 11:07 AM, Han Han wrote: > > > > > > On Sat, Oct 12, 2019 at

Re: [libvirt] [PATCH v3 03/19] util: use glib memory allocation functions

countptr) > diff --git a/src/util/viralloc.h b/src/util/viralloc.h > index 3e72e40bc9..517f9aada6 100644 > --- a/src/util/viralloc.h > +++ b/src/util/viralloc.h > @@ -24,6 +24,15 @@ > > #include "internal.h" > > +/** > + * DEPRECATION WARNING > + * > + * APIs i

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

On Sat, Oct 12, 2019 at 1:05 AM Cole Robinson wrote: > On 10/10/19 11:25 PM, Han Han wrote: > > Hi Cole, > > I merged crobinso/qcow2-data_file branch to 37b565c00. Reserved new > > capabilities introduced by these to branches to resolve conflicts. > > Then

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

e.syms| 1 - > src/security/security_dac.c | 63 +-- > src/security/security_selinux.c | 97 +++ > src/util/virstoragefile.c | 281 > src/util/virstoragefile.h | 11 +- > 5 files changed, 290 insertions(+), 163 dele

[libvirt] Update the release note of released version

Hi, Although libvirt-5.8 is released, however some features or improvement like "slirp helper process" are missing in release note now. Can I update the news.xml even after v5.8 ? -- Best regards, ----------- Han Han Quality Engineer Redhat. Email: h...@redhat

Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

On Tue, Oct 8, 2019 at 5:50 PM Michal Privoznik wrote: > On 10/8/19 10:36 AM, Han Han wrote: > > Adjust valid range of rebootTimeout according to qemu-4.0.0 commit > > ee5d0f89de3. > > > > Signed-off-by: Han Han > > --- > > src/conf/domain_conf.c | 6 ++

[libvirt] [PATCH 3/3] docs: Update docs on rebootTimeout valid value range

Signed-off-by: Han Han --- docs/formatdomain.html.in | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 647f96f651..8a6f289df7 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -274,9 +274,8

[libvirt] [PATCH 2/3] tests: Remove test reboot-timeout-disabled

Reboot timeout is disabled by default in qemu. And -1 is invalid value for reboot-timeout parameter after qemu-4.0.0. Signed-off-by: Han Han --- .../reboot-timeout-disabled.args | 28 --- .../reboot-timeout-disabled.xml | 24

[libvirt] [PATCH 0/3] Update rebootTimeout range to 0..0xffff

Since qemu v4.0.0(commit ee5d0f89de3), reboot-timeout valid range was set 0~0x. Update libvirt codes, docs, tests for that change. I am not sure if po files should be updated. If so, please point it out. Han Han (3): conf: Set rebootTimeout valid range to 0..0x tests: Remove test

[libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff

Adjust valid range of rebootTimeout according to qemu-4.0.0 commit ee5d0f89de3. Signed-off-by: Han Han --- src/conf/domain_conf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a53cd6a725..57ab254f52 100644

[libvirt] [PATCH] admin: Fix missing filters of debug msg for virAdmConnectSetLoggingFilters

Signed-off-by: Han Han --- src/libvirt-admin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c index 4ae50b188f..cf40ea122e 100644 --- a/src/libvirt-admin.c +++ b/src/libvirt-admin.c @@ -1236,7 +1236,7

Re: [libvirt] [PATCH 2/4] conf: Adding XML support for 'xres' and 'yres'

domain_conf.h > @@ -1419,6 +1419,8 @@ struct _virDomainVideoDef { > unsigned int vram64; /* kibibytes (multiples of 1024) */ > unsigned int vgamem; /* kibibytes (multiples of 1024) */ > unsigned int heads; > +unsigned int xres; > +unsigned int yres; > bool primary; > virDomainVideoAccelDefPtr accel; > virDomainVideoDriverDefPtr driver; > -- > 2.20.1 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- Best regards, --- Han Han Quality Engineer Redhat. Email: h...@redhat.com Phone: +861065339333 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 2/2] news: Support encrypted soft tpm

Signed-off-by: Han Han --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 6d90ea8389..660706c12c 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -86,6 +86,16 @@ snapshot-create --validate

[libvirt] [PATCH v2 0/2] News for snapshot validation and vtpm encryption

v1: https://www.redhat.com/archives/libvir-list/2019-July/msg01897.html Han Han (2): news: Allow xml validation for snapshot creation news: Support encrypted soft tpm docs/news.xml | 20 1 file changed, 20 insertions(+) -- 2.20.1 -- libvir-list mailing list libvir

[libvirt] [PATCH v2 1/2] news: Allow xml validation for snapshot creation

Signed-off-by: Han Han --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 1134309ec2..6d90ea8389 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -76,6 +76,16 @@ + + + qemu: Allow

[libvirt] [PATCH] news: Allow xml validation for snapshot creation

Signed-off-by: Han Han --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 1134309ec2..6d90ea8389 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -76,6 +76,16 @@ + + + qemu: Allow

[libvirt] [PATCH v2 0/3] Add missing pool list types

v1: https://www.redhat.com/archives/libvir-list/2019-July/msg00603.html Han Han (3): storage: Add iscsi-direct pool list type flag storage: Add missing pool type flags in comment virsh.pod: Add zfs and vstorage pool types include/libvirt/libvirt-storage.h | 1 + src/conf/storage_conf.h

[libvirt] [PATCH v2 3/3] virsh.pod: Add zfs and vstorage pool types

Signed-off-by: Han Han --- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 62ffd43ba9..e8b63fdab2 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4093,7 +4093,7 @@ I<--uuid> and I<--name>. You m

[libvirt] [PATCH v2 1/3] storage: Add iscsi-direct pool list type flag

Add pool list type flag VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI_DIRECT, which was forgotten when introducing iscsi-direct pool at f0bf1be3. https://bugzilla.redhat.com/show_bug.cgi?id=1726609 Signed-off-by: Han Han --- include/libvirt/libvirt-storage.h | 1 + src/conf/storage_conf.h | 3

[libvirt] [PATCH v2 2/3] storage: Add missing pool type flags in comment

Signed-off-by: Han Han --- src/libvirt-storage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c index 24e28083ed..8d1effe33c 100644 --- a/src/libvirt-storage.c +++ b/src/libvirt-storage.c @@ -94,6 +94,9 @@ virStoragePoolGetConnect

[libvirt] [PATCH] storage: Add iscsi-direct pool list type flag

Add pool list type flag VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI_DIRECT, which was forgotten when introducing iscsi-direct pool at f0bf1be3. https://bugzilla.redhat.com/show_bug.cgi?id=1726609 Signed-off-by: Han Han --- include/libvirt/libvirt-storage.h | 1 + src/conf/storage_conf.h | 3

Re: [libvirt] [PATCH v2] qemu: Add entry for balloon stats stat-htlb-pgalloc and stat-htlb-pgfail

Ping. Anyone could help review the patch: https://www.redhat.com/archives/libvir-list/2019-April/msg01454.html On Sun, Apr 28, 2019 at 5:18 PM Han Han wrote: > Qemu added reporting of virtio balloon new statistics stat-htlb-pgalloc and > stat-htlb-pgfail since qemu-3.0 commit b7b12

Re: [libvirt] [PATCH v2] qemu: Add entry for balloon stats stat-htlb-pgalloc and stat-htlb-pgfail

ping On Sun, Apr 28, 2019 at 5:18 PM Han Han wrote: > Qemu added reporting of virtio balloon new statistics stat-htlb-pgalloc and > stat-htlb-pgfail since qemu-3.0 commit b7b12644297. The value of > stat-htlb-pgalloc represents the number of successful hugetlb page > allocations

[libvirt] [PATCH v2] qemu: Add entry for balloon stats stat-htlb-pgalloc and stat-htlb-pgfail

this statistics reporting to libvirt. To enable this feature for vm, guest kenel >= 4.17 is required because the exporting hugetlb page allocation for virtio balloon is introduced since 6c64fe7f. Signed-off-by: Han Han --- include/libvirt/libvirt-domain.h | 14 +- src/libvirt-domai

[libvirt] [PATCH] qemu: Add entry for balloon stats stat-htlb-pgalloc and stat-htlb-pgfail

this statistics reporting to libvirt. Signed-off-by: Han Han --- include/libvirt/libvirt-domain.h | 14 +- src/libvirt-domain.c | 5 - src/qemu/qemu_driver.c | 2 ++ src/qemu/qemu_monitor_json.c | 5 + tools/virsh-domain-monitor.c | 4 tools/virsh.pod

[libvirt] [PATCH] docs: index.html.in: Deduplicate the link of QEMU and KVM

Because the page of QEMU and KVM use the same doc drvqemu.html, merge the into one and name it as QEMU/KVM. Signed-off-by: Han Han --- docs/index.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/index.html.in b/docs/index.html.in index f593445d06..97a4e9eef7

Re: [libvirt] [PATCH] vmx: Define VMX_CONFIG_FORMAT_ARGV to replace vmware/esx argv str

mx' > string used by the domxml-X-native APIs. This follows the pattern used > by other drivers. > > > Thanks, > Cole > > > On 4/9/19 6:01 AM, Han Han wrote: > > Signed-off-by: Han Han > > --- > > src/esx/esx_driver.c | 4 ++-- > > src/vmware/

Re: [libvirt] [PATCH 3/3] vmware: Use VMX_CONFIG_FORMAT_ARGV for vmware naive argv

On Thu, Apr 4, 2019 at 5:16 AM Cole Robinson wrote: > *native in the subject > > On 3/28/19 1:57 AM, Han Han wrote: > > Signed-off-by: Han Han > > --- > > src/vmware/vmware_conf.c | 2 +- > > src/vmware/vmware_driver.c | 2 +- > > 2 files changed, 2 ins

[libvirt] [PATCH] vmx: Define VMX_CONFIG_FORMAT_ARGV to replace vmware/esx argv str

Signed-off-by: Han Han --- src/esx/esx_driver.c | 4 ++-- src/vmware/vmware_driver.c | 2 +- src/vmx/vmx.h | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 08d33b6f3b..d80fef0a58 100644 --- a/src/esx

[libvirt] [PATCH 3/3] vmware: Use VMX_CONFIG_FORMAT_ARGV for vmware naive argv

Signed-off-by: Han Han --- src/vmware/vmware_conf.c | 2 +- src/vmware/vmware_driver.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index 0c1b1f9550..76645a2e0d 100644 --- a/src/vmware/vmware_conf.c +++ b/src/vmware

[libvirt] [PATCH 2/3] esx: Use VMX_CONFIG_FORMAT_ARGV for esx naive argv

Signed-off-by: Han Han --- src/esx/esx_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 08d33b6f3b..d80fef0a58 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -2710,7 +2710,7

[libvirt] [PATCH 1/3] vmx: Define macro VMX_CONFIG_FORMAT_ARGV for vmware-vmx

Signed-off-by: Han Han --- src/vmx/vmx.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vmx/vmx.h b/src/vmx/vmx.h index cb99e84d18..8c068b4cb2 100644 --- a/src/vmx/vmx.h +++ b/src/vmx/vmx.h @@ -26,6 +26,8 @@ # include "virconf.h" # include "domain_conf

[libvirt] [PATCH 0/3] Replace vmware/esx argv string to VMX_CONFIG_FORMAT_ARGV

Han Han (3): vmx: Define macro VMX_CONFIG_FORMAT_ARGV for vmware-vmx esx: Use VMX_CONFIG_FORMAT_ARGV for esx naive argv vmware: Use VMX_CONFIG_FORMAT_ARGV for vmware naive argv src/esx/esx_driver.c | 4 ++-- src/vmware/vmware_conf.c | 2 +- src/vmware/vmware_driver.c | 2 +- src

[libvirt] [PATCH] virsh.pod: Improve native configuration format doc

Add native guest format of BSD hypervisor and VMware/ESX. Quote native guest format of domxml-from-native for domxml-to-native. Signed-off-by: Han Han --- tools/virsh.pod | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index

[libvirt] [PATCH] qemu: Compare group_names by STRNEQ not CHECK_EQ

Fix issue introduced by 047cfb05ee. Since group_name is str, use STRNEQ instead of CHECK_EQ to do comparition. Signed-off-by: Han Han --- src/qemu/qemu_domain.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[libvirt] [PATCH 2/2] news: Add support for postcopy-requests migration statistics

This feature is introduced by 3f4914e0. Signed-off-by: Han Han --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 78ae81e7ca..a4fc335a32 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -112,6 +112,15 @@ sibling

[libvirt] [PATCH 1/2] news: Add support for "stibp" x86_64 feature

This feature is from eb1b551d. Signed-off-by: Han Han --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 6a2a73b534..78ae81e7ca 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -102,6 +102,16 @@ the 'readonly

[libvirt] [PATCH 0/2] News update for libvirt-5.0

Han Han (2): news: Add support for "stibp" x86_64 feature news: Add support for postcopy-requests migration statistics docs/news.xml | 19 +++ 1 file changed, 19 insertions(+) -- 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.c

[libvirt] [PATCH] docs: Only one secret is in vol instead of zero or more

Referring to commit fab2e49d, it should be one and only secret for encryption. Signed-off-by: Han Han --- docs/schemas/storagecommon.rng | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/schemas/storagecommon.rng b/docs/schemas/storagecommon.rng index 9d17d934de

Re: [libvirt] [PATCH] docs: Add notes for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA

On Thu, Nov 15, 2018 at 12:36 AM Andrea Bolognani wrote: > On Wed, 2018-11-14 at 15:19 +0800, Han Han wrote: > > When listing snapshot with VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA, it > > always returns 0 or no snapshot. Because we never implement funtions > > to list

[libvirt] [PATCH] docs: Add notes for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA

DATA) == VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA) return 0; Add notes for that flag. Please update the comment and man page of that flag when no-metadata snapshot list is implemented in the future. Signed-off-by: Han Han --- include/libvirt/libvirt-domain-snapshot.h | 5 - tools/virsh

[libvirt] [PATCH v3 10/10] news: Cold(un)plug and hot(un)plug support for usb hub

Signed-off-by: Han Han --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 88774c55ae..b677f52efc 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,16 @@ + + + Qemu: Add active

[libvirt] [PATCH v3 04/10] qemu: Make qemuBuildHubDevStr global

Make function qemuBuildHubDevStr global for reuse on hub hotplug. Signed-off-by: Han Han --- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f59cbf559e

[libvirt] [PATCH v3 09/10] qemu: Implement usb hub device hotunplug

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 5 ++- src/qemu/qemu_hotplug.c | 81 - src/qemu/qemu_hotplug.h | 4 ++ 3 files changed, 88 insertions(+), 2 deletions(-) diff --git a/src/qemu

[libvirt] [PATCH v3 00/10] Cold(un)plug and hot(un)plug support for hub

/libvir-list/2018-October/msg00719.html Han Han (10): qemu: Allow coldplugging of hub device qemu: Allow coldunplugging of hub device qemu: Refactor hub alias assignment for hotplug qemu: Make qemuBuildHubDevStr global conf: Add virDomainHubDefFree to libvirt_private.syms qemu: Implement usb

[libvirt] [PATCH v3 05/10] conf: Add virDomainHubDefFree to libvirt_private.syms

Add virDomainHubDefFree to for the preparation of usb hub hotplug. Signed-off-by: Han Han --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6245927673..b29c2bf62b 100644 --- a/src/libvirt_private.syms +++ b

[libvirt] [PATCH v3 08/10] qemu: Check whether hub device is busy

qemuDomainHubIsBusy is to check whether a usb device are attached to the hub device. It will be used for hotunplugging and live device update of hub device. Signed-off-by: Han Han --- src/qemu/qemu_hotplug.c | 64 + 1 file changed, 64 insertions(+) diff

[libvirt] [PATCH v3 03/10] qemu: Refactor hub alias assignment for hotplug

Make qemuAssignDeviceHubAlias global and allow alias generating for reuse on hotplug. Signed-off-by: Han Han --- src/qemu/qemu_alias.c | 22 ++ src/qemu/qemu_alias.h | 4 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_alias.c b/src/qemu

[libvirt] [PATCH v3 07/10] conf: Add function virDomainUSBAddressIsAttachedToHub

Add this function to check if the a usb address is attached to a hub device. Signed-off-by: Han Han --- src/conf/domain_addr.c | 22 ++ src/conf/domain_addr.h | 5 + src/libvirt_private.syms | 1 + 3 files changed, 28 insertions(+) diff --git a/src/conf

[libvirt] [PATCH v3 01/10] qemu: Allow coldplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9f71641dfa..1e5a69358b 100644 --- a/src/qemu/qemu_driver.c +++ b

[libvirt] [PATCH v3 02/10] qemu: Allow coldunplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/conf/domain_conf.c | 30 ++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 10 +- 4 files changed, 43 insertions(+), 1

[libvirt] [PATCH v3 06/10] qemu: Implement usb hub device hotplug

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 9 ++- src/qemu/qemu_hotplug.c | 58 + src/qemu/qemu_hotplug.h | 4 +++ 3 files changed, 70 insertions(+), 1 deletion(-) diff --git a/src/qemu

Re: [libvirt] [PATCH v2 7/8] qemu: implement usb hub device hotunplug

On Tue, Nov 6, 2018 at 6:47 AM John Ferlan wrote: > > $SUBJ: > > s/implement/Implement > > On 10/12/18 4:50 AM, Han Han wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1375423 > > > > Add the infrastructure to allow a USB Hub device to be hot unp

Re: [libvirt] [PATCH v2 6/8] qemu: implement usb hub device hotplug

On Tue, Nov 6, 2018 at 6:34 AM John Ferlan wrote: > $SUBJ: > > s/implement/Implement > > On 10/12/18 4:50 AM, Han Han wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1375423 > > Add the infrastructure to allow a USB Hub device to be hotplugged. >

Re: [libvirt] [PATCH v2 2/8] qemu: Allow coldunplugging of hub device

On Tue, Nov 6, 2018 at 6:29 AM John Ferlan wrote: > > > On 10/12/18 4:50 AM, Han Han wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1375423 > > > > Signed-off-by: Han Han > > --- > > src/conf/domain_conf.c | 30 ++

Re: [libvirt] RFC: VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA is not functional?

On Mon, Nov 5, 2018 at 9:38 PM Peter Krempa wrote: > On Fri, Nov 02, 2018 at 15:52:54 +0800, Han Han wrote: > > Hello, > > I found snapshot APIs(like virDomainSnapshotNum) invoked with > > VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA will return 0 even there are > internal &

Re: [libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device

On Tue, Nov 6, 2018 at 6:52 AM John Ferlan wrote: > > > On 10/12/18 4:50 AM, Han Han wrote: > > Signed-off-by: Han Han > > --- > > docs/news.xml | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/docs/news.xml b/docs/new

[libvirt] RFC: VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA is not functional?

ight** result, if the function for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA will not be designed, how will we deal with the flag? Remove it from code OR update the docs to mark it unsupported? -- Best regards, --- Han Han Quality Engineer Redhat. Email: h...@redhat.com P

Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

On Thu, Oct 18, 2018 at 5:28 PM Martin Kletzander wrote: > On Thu, Oct 18, 2018 at 02:12:36PM +0800, Han Han wrote: > >On Wed, Oct 17, 2018 at 4:46 PM Martin Kletzander > >wrote: > > > >> On Tue, Oct 16, 2018 at 07:19:41PM -0400, John Ferlan wrote: > >> &

[libvirt] [PATCH v4 1/2] util: Refactor virFileIsCDROM to virFileCheckCDROM

Refactor virFileIsCDROM to virFileCheckCDROM for checking cdrom status. Add add enum type virFileCDRomStatus. Now virFileCheckCDROM could be used to check the cdrom drive status such as ok, no disc, tray open, drive not ready, or unknown. Signed-off-by: Han Han --- src/libvirt_private.syms

[libvirt] [PATCH v4 0/2] Refactor virFileIsCDROM to check cdrom status

with cdrom status. Give more detailed when fail to read cdrom backend vol. Han Han (2): util: Refactor virFileIsCDROM to virFileCheckCDROM storage: Improve error handling on cdrom backend src/libvirt_private.syms | 2 +- src/qemu/qemu_domain.c | 4 ++-- src/storage/storage_util.c | 32

[libvirt] [PATCH v4 2/2] storage: Improve error handling on cdrom backend

https://bugzilla.redhat.com/show_bug.cgi?id=1596096 Implement virFileCheckCDROM in virStorageBackendVolOpen to check if cdrom backend is ok. Report more detailed error if not ok. Signed-off-by: Han Han --- src/storage/storage_util.c | 32 1 file changed, 32

Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

On Wed, Oct 17, 2018 at 4:46 PM Martin Kletzander wrote: > On Tue, Oct 16, 2018 at 07:19:41PM -0400, John Ferlan wrote: > > > > > >On 10/14/18 10:26 AM, Han Han wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1535930 > >> > >> Report

Re: [libvirt] [RFC 0/3] update NVDIMM support

t's OK. > Regards, > Luyao Zhong > > On 2018/10/18 上午9:10, Han Han wrote: > > > > On Wed, Oct 17, 2018 at 10:25 AM Luyao Zhong > wrote: > >> Hi libvirt experts, >> >> This is the RFC for updating NVDIMM support in libvirt. >> >> QEMU has sup

Re: [libvirt] [RFC 0/3] update NVDIMM support

y-hotplug-nvdimm-pmem.xml > create mode 12 > tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-unarmed.xml > > -- > 2.7.4 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- Best regards, --- Han Han Quality Engineer Redhat. Email: h...@redhat.com Phone: +861065339333 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] conf: Fix typos in pcie controllers' name

Signed-off-by: Han Han --- src/conf/domain_addr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 442e6aab94..e4ed143b76 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -158,9 +158,9

[libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

https://bugzilla.redhat.com/show_bug.cgi?id=1535930 Report more clear err msg instead of unknown error when coalesce settings is incomplete. Signed-off-by: Han Han --- src/conf/domain_conf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src

[libvirt] [PATCH v2 7/8] qemu: implement usb hub device hotunplug

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 5 ++- src/qemu/qemu_hotplug.c | 74 - src/qemu/qemu_hotplug.h | 4 +++ 3 files changed, 81 insertions(+), 2 deletions(-) diff --git a/src/qemu

[libvirt] [PATCH v2 5/8] private_syms: add virDomainHubDefFree to libvirt_private.syms

Add virDomainHubDefFree to for the preparation of usb hub hotplug. Signed-off-by: Han Han --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6245927673..b29c2bf62b 100644 --- a/src/libvirt_private.syms +++ b

[libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device

Signed-off-by: Han Han --- docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index dc08c96352..0efad21758 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,11 @@ + + + qemu: Add support for cold(un

[libvirt] [PATCH v2 4/8] qemu_command: Make qemuBuildHubDevStr global

Make function qemuBuildHubDevStr global for reuse on hub hotplug. Signed-off-by: Han Han --- src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 269276f2f9

[libvirt] [PATCH v2 1/8] qemu: Allow coldplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a52e2495d5..130ce4cbd6 100644 --- a/src/qemu/qemu_driver.c +++ b

[libvirt] [PATCH v2 6/8] qemu: implement usb hub device hotplug

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 9 ++- src/qemu/qemu_hotplug.c | 58 + src/qemu/qemu_hotplug.h | 8 ++ 3 files changed, 74 insertions(+), 1 deletion(-) diff --git a/src

[libvirt] [PATCH v2 3/8] qemu_alias: Refactor hub alias assignment for hotplug

Make qemuAssignDeviceHubAlias global and allow alias generating for reuse on hotplug. Signed-off-by: Han Han --- src/qemu/qemu_alias.c | 22 ++ src/qemu/qemu_alias.h | 4 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_alias.c b/src/qemu

[libvirt] [PATCH v2 2/8] qemu: Allow coldunplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/conf/domain_conf.c | 30 ++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 10 +- 4 files changed, 43 insertions(+), 1

[libvirt] [PATCH v2 0/8] Usb hub Cold(un)plug and hot(un)plug support

v1: https://www.redhat.com/archives/libvir-list/2018-October/msg00563.html Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Han Han (8): qemu: Allow coldplugging of hub device qemu: Allow coldunplugging of hub device qemu_alias: Refactor hub alias assignment for hotplug

[libvirt] [PATCH 1/2] qemu: Allow coldplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a52e2495d5..130ce4cbd6 100644 --- a/src/qemu/qemu_driver.c +++ b

[libvirt] [PATCH 2/2] qemu: Allow coldunplugging of hub device

https://bugzilla.redhat.com/show_bug.cgi?id=1375423 Signed-off-by: Han Han --- src/conf/domain_conf.c | 30 ++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 10 +- 4 files changed, 43 insertions(+), 1

[libvirt] [PATCH 0/2] Allow coldplug and coldunplug of hub device

Han Han (2): qemu: Allow coldplugging of hub device qemu: Allow coldunplugging of hub device src/conf/domain_conf.c | 30 ++ src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 16 ++-- 4 files changed, 48

[libvirt] [PATCH v2] virFileIsSharedFixFUSE: Copy mnt_dir when browsing mount table

lowing: 10.XX.XX.XX:/gv0 /mnt fuse.glusterfs rw 0 0 r...@xx.xx.xx:/tmp/mkdir /tmp/br0 fuse.sshfs rw 0 0 Copy mnt_dir of struct mntent in case its mnt_dir is changed by getmntent_r in the loop later. Signed-off-by: Han Han --- src/util/virfile.c | 12 1 file changed, 8 insertions(+), 4

[libvirt] [PATCH] virFileIsSharedFSType: Copy mnt_dir when browsing mount table

nt in case its mnt_dir is changed by getmntent_r in the loop later. Signed-off-by: Han Han --- src/util/virfile.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 2a7e87102a..c503462633 100644 --- a/src/util/virfile.c

Re: [libvirt] [PATCH] docs: Typo fix in virDomainGetJobStats

ion hosts have synchronized time (i.e., NTP daemon > is > -- > 2.17.1 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- Best regards, --- Han Han Quality Engineer Redhat.

[libvirt] [PATCH v3] virsh: Don't break loop of domblkinfo for disks

breaks the loop of domblkinfo for disks. Signed-off-by: Han Han --- tools/virsh-domain-monitor.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index b9b4f9739b..ecb98d4128 100644 --- a/tools/virsh

[libvirt] [PATCH v2] virsh: Don't break loop of domblkinfo for disks

https://bugzilla.redhat.com/show_bug.cgi?id=1619625 --all option is added to cmdDomblkinfo since commit 62c39193 allowing to show all block devices info. Reset error when empty source in case error breaks the loop of domblkinfo for disks. Signed-off-by: Han Han --- tools/virsh-domain-monitor.c

Re: [libvirt] [PATCH] virsh: Don't break loop of domblkinfo for disks

On Tue, Aug 21, 2018 at 11:26 PM, Peter Krempa wrote: > On Tue, Aug 21, 2018 at 21:23:42 +0800, Han Han wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1619625 > > > > --all option is added to cmdDomblkinfo since commit 62c39193 allowing to > > show all blo

[libvirt] [PATCH] virsh: Don't break loop of domblkinfo for disks

after virDomainGetBlockInfo returning fail. Signed-off-by: Han Han --- tools/virsh-domain-monitor.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index b9b4f9739b..ee926baae8 100644 --- a/tools/virsh

Re: [libvirt] [PATCH v2 0/2] Add .domainGetHostname() support for QEMU driver.

iling list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- Best regards, --- Han Han Quality Engineer Redhat. Email: h...@redhat.com Phone: +861065339333 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 0/2] Add nodesevinfo in virsh

Add virsh nodesevinfo to get AMD SEV features via virNodeGetSEVInfo. Han Han (2): virsh: Implement virNodeGetSEVInfo in virsh news: Add nodesevinfo command in virsh docs/news.xml | 9 +++ tools/virsh-host.c | 66 ++ tools/virsh.pod

[libvirt] [PATCH 2/2] news: Add nodesevinfo command in virsh

Signed-off-by: Han Han --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index c6d03f5556..fc9db92d05 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -63,6 +63,15 @@ Support the vhost-vsock-ccw device on S390

[libvirt] [PATCH 1/2] virsh: Implement virNodeGetSEVInfo in virsh

Add sub-command nodesevinfo to get node infomation of AMD SEV feature. Signed-off-by: Han Han --- tools/virsh-host.c | 66 ++ tools/virsh.pod| 5 2 files changed, 71 insertions(+) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index

[libvirt] [PATCH] qemu: Check sev capability pointer before using it

https://bugzilla.redhat.com/show_bug.cgi?id=1612009 Check sev capability pointer in function qemuGetSEVInfoToParams to avoid null pointer dereferences. Signed-off-by: Han Han --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu

Re: [libvirt] [PATCH 2/2] esx: Fix SetAutoStart invalid pointer free

gt; +strcpy(newPowerInfo->stopAction, (char *)"none"); > > The same here > if (esxVI_AutoStartPowerInfo_AppendToList(>powerInfo, >newPowerInfo) < 0) { > -- > 2.17.1 > > -- > libvir-list maili

[libvirt] [PATCH] conf: Fix typo in error msg of virDomainVideoDefValidate

https://bugzilla.redhat.com/show_bug.cgi?id=1607825 Fix typo of error msg when 'none' type is not the only video device defined in VM. Signed-off-by: Han Han --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf

[libvirt] [PATCH] news: Usb and sata for virsh attach-disk --address

Signed-off-by: Han Han --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index fc7924ad5f..a68ef2dc1c 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -76,6 +76,16 @@ using attach-disk or attach-interface commands

Re: [libvirt] [PATCH] conf: Don't parse edev of non-passthrough input device

On Thu, Jul 19, 2018 at 12:34 AM, John Ferlan wrote: > > > On 07/11/2018 01:57 AM, Han Han wrote: > > In input devices, edev attribute is only for passthrough devices. > > Don't parse this for other input devices. > > > > Resolves: https://bugzilla.r

[libvirt] [PATCH v2 0/1] conf: Add validation of input devices

v1: https://www.redhat.com/archives/libvir-list/2018-July/msg00658.html Han Han (1): conf: Add validation of input devices src/conf/domain_conf.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) -- 2.18.0 -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH v2 1/1] conf: Add validation of input devices

https://bugzilla.redhat.com/show_bug.cgi?id=1591151 Add function virDomainInputDefValidate to validate input devices. Make sure evdev attribute of source element is not used by mouse, keyboard, and tablet input device. Signed-off-by: Han Han --- src/conf/domain_conf.c | 22

Re: [libvirt] [PATCH v2 1/2] virsh: Support alias in attach-disk

On Mon, Jul 23, 2018 at 6:21 PM, Michal Prívozník wrote: > On 07/15/2018 12:08 PM, Han Han wrote: > > Add --alias to support custom disk alias in virsh attach-disk. > > Report error if custom alias doesn't start with 'ua-'. > > > > Signed-off-by: Han Han > > -

Re: [libvirt] [PATCH v2 0/2] Add alias support in sub-commands of virsh

On Mon, Jul 23, 2018 at 6:21 PM, Michal Prívozník wrote: > On 07/15/2018 12:08 PM, Han Han wrote: > > Fix make syntax-check failure in v1. > > v1 link: https://www.redhat.com/archives/libvir-list/2018- > July/msg00929.html > > > > Han Han (2): > >

[libvirt] [PATCH] news: Add --alias to virsh attach-disk and attach-interface

Signed-off-by: Han Han --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 20c2ff7a6f..1e632eb378 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -67,6 +67,15 @@ only rendering devices within the guest

<    1   2   3   4   5   6   >