Re: [libvirt] [Xen-devel] [PATCH V2 0/4] libxl: support qemu's network-based block backends

onverter. Only rbd supported > is added in this series. Support for other backends such as nbd > and iscsi can be added as a follow-up improvement. All looks good to me, so FWIW: Acked-by: Ian Campbell <ian.campb...@citrix.com> -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [Xen-devel] [PATCH 0/4] libxl: support qemu's network-based block backends

On Tue, 2016-02-16 at 14:45 -0700, Jim Fehlig wrote: > xl/libxl already supports qemu's network-based block backends > such as nbd and rbd. libvirt has supported configuring network > disks for long time too. This series marries the two in the > libxl driver and in the xl<->xml converter. Only rbd

[libvirt] [PATCH LIBVIRT v3] libxl: Support cmdline= in xl config files

one in the xmconfigtest.c case. In order to introduce a use of VIR_WARN for logging I had to add virerror.h and VIR_LOG_INIT. Signed-off-by: Ian Campbell <ian.campb...@citrix.com> --- v2: Use VIR_INFO (adding necessary infra) Don't initialise things to NULL when there is no need. v3: I know know the

Re: [libvirt] [PATCH 2/2] Xen: add XENXL to virErrorDomain enum

On Wed, 2016-01-20 at 11:58 -0700, Jim Fehlig wrote: > Add "Xen XL Config" to the virErrorDomain enum and use it in > src/xenconfig/xen_xl.c. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> Acked-by: Ian Campbell <ian.campb...@citrix.com> -- libvir-list m

Re: [libvirt] [PATCH 1/2] Xen: VIR_FROM_THIS cleanup

rc/xenconfig/xenxs_private.h. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> Acked-by: Ian Campbell <ian.campb...@citrix.com> -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH LIBVIRT v2] libxl: Support cmdline= in xl config files

On Wed, 2016-01-20 at 11:16 -0700, Jim Fehlig wrote: > Ian Campbell wrote: > > ... and consolidate the cmdline/extra/root parsing to facilitate doing > > so. > > > > The logic is the same as xl's parse_cmdline from the current xe

Re: [libvirt] [Xen-devel] [PATCH LIBVIRT] libxl: Support cmdline= in xl config files

On Tue, 2016-01-19 at 21:46 -0700, Jim Fehlig wrote: > On 01/19/2016 05:03 AM, Ian Campbell wrote: > > I went to ping this but noticed that I had sent it to "jimfehlig" (i.e. > > no > > domain), so no wonder there was no reply! > > > > To: line fixed her

[libvirt] [PATCH LIBVIRT v2] libxl: Support cmdline= in xl config files

. Signed-off-by: Ian Campbell <ian.campb...@citrix.com> --- NB: I was unsure if I was supposed to change VIR_FROM_NONE into VIR_FROM_XEN, so I didn't (but will on advice). v2: Use VIR_INFO (adding necessary infra) Don't initialise things to NULL when there is no need. --- src/xenconfig/xe

Re: [libvirt] [PATCH LIBVIRT] libxl: Support cmdline= in xl config files

I went to ping this but noticed that I had sent it to "jimfehlig" (i.e. no domain), so no wonder there was no reply! To: line fixed here, let me know if you would prefer a resend. Ian. On Wed, 2015-12-16 at 12:09 +, Ian Campbell wrote: > ... and consolidate the cmdline/extra

Re: [libvirt] [PATCH V2] Xen: support maxvcpus in xm and xl config

On Wed, 2015-12-16 at 10:11 +, Ian Campbell wrote: > On Tue, 2015-12-15 at 15:20 -0700, Jim Fehlig wrote: > > From: Ian Campbell <ian.campb...@citrix.com> > > > > xend prior to 4.0 understands vcpus as maxvcpus and vcpu_avail > > as a bit map of whic

Re: [libvirt] [PATCH 00/16] Xen: remove xend config version

On Tue, 2015-12-15 at 14:32 -0700, Jim Fehlig wrote: > Hi All, > > Ian Campbell recently attempted [1] to fix and issue around MAX_VIRT_VPUS > on ARM that required adding a new XEND_CONFIG_VERSION. After some > discussion [2] we decided to drop support for all of the old xend co

Re: [libvirt] [Xen-devel] [PATCH LIBVIRT] libxl: Use libxentoollog in preference to libxenctrl if available.

On Tue, 2015-12-15 at 16:15 -0700, Jim Fehlig wrote: > On 12/14/2015 04:37 AM, Ian Campbell wrote: > > On Mon, 2015-12-14 at 11:15 +, Daniel P. Berrange wrote: > > > On Thu, Dec 10, 2015 at 11:38:36AM +, Ian Campbell wrote: > > > > Upstream Xen is in the pr

Re: [libvirt] [PATCH V2] Xen: support maxvcpus in xm and xl config

On Tue, 2015-12-15 at 15:20 -0700, Jim Fehlig wrote: > From: Ian Campbell <ian.campb...@citrix.com> > > xend prior to 4.0 understands vcpus as maxvcpus and vcpu_avail > as a bit map of which cpus are online (default is all). > > xend from 4.0 onwards understands maxvcpus

Re: [libvirt] [PATCH 00/16] Xen: remove xend config version

On Wed, 2015-12-16 at 09:45 +, Ian Campbell wrote: > On Tue, 2015-12-15 at 14:32 -0700, Jim Fehlig wrote: > > Hi All, > > > > Ian Campbell recently attempted [1] to fix and issue around > > MAX_VIRT_VPUS > > on ARM that required adding a new XEND_CONFIG_VERS

Re: [libvirt] [PATCH v2 5/7] virNetDevMacVLanTapSetup: Allow enabling of IFF_MULTI_QUEUE

Hello, On Thu, 2015-12-10 at 08:38 +0100, Michal Privoznik wrote: > Like we are doing for TUN/TAP devices, we should do the same for > macvtaps. Although, it's not as critical as in that case, we > should do it for the consistency. > > Signed-off-by: Michal Privoznik This

Re: [libvirt] [PATCH LIBVIRT] libxl: Use libxentoollog in preference to libxenctrl if available.

On Mon, 2015-12-14 at 11:15 +, Daniel P. Berrange wrote: > On Thu, Dec 10, 2015 at 11:38:36AM +0000, Ian Campbell wrote: > > Upstream Xen is in the process of splitting the (stable API) xtl_* > > interfaces out from the (unstable API) libxenctrl library and into a >

Re: [libvirt] [PATCH v2 5/7] virNetDevMacVLanTapSetup: Allow enabling of IFF_MULTI_QUEUE

On Mon, 2015-12-14 at 12:35 +0100, Michal Privoznik wrote: > On 14.12.2015 11:23, Ian Campbell wrote: > > Hello, > > > > On Thu, 2015-12-10 at 08:38 +0100, Michal Privoznik wrote: > > > Like we are doing for TUN/TAP devices, we should do the same for > > > m

[libvirt] [PATCH LIBVIRT] libxl: Use libxentoollog in preference to libxenctrl if available.

in a libxentoollog library and use it if present. If it is not present assume it is in libxenctrl. Compile tested on Xen 4.6 and a development tree with the split in place. Signed-off-by: Ian Campbell <ian.campb...@citrix.com> --- I'm waiting on applying the upstream change until downstreams are pr

Re: [libvirt] [PATCH LIBVIRT v1 1/2] libxl: Correct value for xendConfigVersion to xen{Parse, Format}ConfigCommon

On Fri, 2015-12-04 at 10:01 +, Daniel P. Berrange wrote: > On Thu, Dec 03, 2015 at 11:13:06PM -0700, Jim Fehlig wrote: > > On 11/26/2015 09:59 AM, Ian Campbell wrote: > > > libxlConnectDomainXMLFromNative calls both xenParseXM and xenParseXL > > > with cfg->verIn

[libvirt] [PATCH] network: selectively disable -Wcast-align in virNetDevParseDadStatus

The three macros involved (NLMSG_NEXT, IFA_RTA and RTA_NEXT) all appear to correctly take care of alignment, therefore suppress Wcast-align around their uses. Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Cc: Maxim Perevedentsev <mperevedent...@virtuozzo.com> Cc: Laine Stump <l

[libvirt] [PATCH LIBVIRT v1 0/2] Support maxvcpus (AKA >1 vcpu on Xen/ARM)

libvirt currently clamps the maximum number of vcpus to MAX_VIRT_CPUS == XEN_LEGACY_MAX_VCPUS, which on ARM is 1 (because all guests are expected to support vcpu info placement). Even on x86 this limitation is a hold over from an older xm interface where the maximum number of vcpus was expressed

[libvirt] [PATCH LIBVIRT v1 1/2] libxl: Correct value for xendConfigVersion to xen{Parse, Format}ConfigCommon

ur for xm/xend here. Signed-off-by: Ian Campbell <ian.campb...@citrix.com> --- src/libxl/libxl_driver.c| 8 src/xenconfig/xen_sxpr.h| 1 + tests/xlconfigdata/test-fullvirt-direct-kernel-boot.cfg | 3 ++- tests/xl

[libvirt] [PATCH LIBVIRT v1 2/2] xen: Handle maxcpus in xl configutation files

in Xen 4.0 the xend_config_format was never bumped beyond 4 and the internal handling remained in terms of vcpu_avail. Therefore the support for xend >= XEND_CONFIG_VERSION_4_0_0 is somewhat theoretical. Signed-off-by: Ian Campbell <ian.campb...@citrix.com> --- src/xenconfig/xen_common.c

Re: [libvirt] build issue due to '-Werror=cast-align' on ARM (armhf) [was: Re: [Xen-devel] [libvirt test] 63528: regressions - FAIL]

Hi Maxim, On Fri, 2015-11-13 at 20:26 -0700, Jim Fehlig wrote: > On 11/13/2015 10:00 AM, Dario Faggioli wrote: > > Hello, > > > > The Xen Project's automated test suite is failing at running its > > libvirt tests for a few time, like this: > > > > On Wed, 2015-11-04 at 09:04 +, osstest

Re: [libvirt] [Xen-devel] [PATCH RFC] libxl: use libxl_event_wait to process libxl events

On Fri, 2015-11-13 at 14:36 -0700, Jim Fehlig wrote: > Prior to this patch, libxl events were delivered to libvirt via > the libxlDomainEventHandler callback registered with libxl. > Documenation in $xensrc/tools/libxl/libxl_event.h states that the > callback "may occur on any thread in which the

Re: [libvirt] [Xen-devel] [PATCH] libxl: open libxl log stream with libvirtd log_level

les that can > potentially fill a disk. Control of libxl verbosity should > be placed in the administrator's hands. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> FWIW this seems like a good idea to me: Acked-by: Ian Campbell <ian.campb...@citrix.com> -- libvir-list maili

[libvirt] [PATCH LIBVIRT] libxl: don't end job for ephemeal domain on start failure

; and going straight to "cleanup" in this case. Signed-off-by: Ian Campbell <ian.campb...@citrix.com> --- src/libxl/libxl_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 5f69b49..e2797d5 100644 --- a/src/libxl/libxl_dri

Re: [libvirt] [PATCH] libxl: report correct errno from virNetSocketNewConnectTCP on migration

nectTCP() > > Remove redundant error reporting libxlDomainMigrationPerform(). > virNetSocketNewConnectTCP() is perfectly capable of reporting > sensible errors. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> FWIW: Acked-by: Ian Campbell <ian.campb...@citrix.com>

[libvirt] [PATCH] libxl: report correct errno from virNetSocketNewConnectTCP on migration

saved_errno is never written to in this function after it is initialised and it is only used to log the failure from virNetSocketNewConnectTCP masking the real errno from that function. Drop saved_errno and use errno itself. Signed-off-by: Ian Campbell <ian.campb...@citrix.com> --- src

[libvirt] [PATCH libvirt] libxl: avoid freeing an uninitialised bitmap

a glance at the handful of other users of libxl_bitmap and none of them looked to have a similar issue. Signed-off-by: Ian Campbell ian.campb...@citrix.com --- src/libxl/libxl_domain.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

On Wed, 2015-05-06 at 10:24 +0200, Olaf Hering wrote: On Fri, May 01, Ian Campbell wrote: Olaf, please can you use gdb to capture the stack trace so we can fix this (and the other issue) properly in libxl instead of just hacking around it in libvirt (which might also be appropriate

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

On Wed, 2015-05-06 at 10:08 +0100, Ian Campbell wrote: On Wed, 2015-05-06 at 10:24 +0200, Olaf Hering wrote: On Fri, May 01, Ian Campbell wrote: Olaf, please can you use gdb to capture the stack trace so we can fix this (and the other issue) properly in libxl instead of just hacking

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

On Fri, 2015-05-01 at 09:10 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Fri, 2015-04-17 at 13:57 -0600, Jim Fehlig wrote: On 04/17/2015 11:59 AM, Olaf Hering wrote: On Fri, Apr 17, Olaf Hering wrote: If the domU configu has sdl enabled libvirtd crashes

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

On Fri, 2015-04-17 at 13:57 -0600, Jim Fehlig wrote: On 04/17/2015 11:59 AM, Olaf Hering wrote: On Fri, Apr 17, Olaf Hering wrote: If the domU configu has sdl enabled libvirtd crashes: libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)'

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote: On 04/17/2015 11:19 AM, Olaf Hering wrote: If the domU configu has sdl enabled libvirtd crashes: libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed. The assertion seems harsh

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

On Mon, 2015-04-20 at 12:32 +0200, Olaf Hering wrote: On Mon, Apr 20, Ian Campbell wrote: It makes no sense to do that at init time, the whole purpose of a defbool is to allow the calling application to choose a value or to explicitly leave it as a request to for the default (which might

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

On Mon, 2015-04-20 at 12:20 +0200, Olaf Hering wrote: On Mon, Apr 20, Ian Campbell wrote: If what you said were true then an assert would be a rather harsh overreaction to an application coding error. Currently both libxl and libvirt are coded that way. Since the sdl code path

Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

On Mon, 2015-04-20 at 11:32 +0200, Olaf Hering wrote: On Mon, Apr 20, Ian Campbell wrote: On Fri, 2015-04-17 at 13:40 -0600, Jim Fehlig wrote: On 04/17/2015 11:19 AM, Olaf Hering wrote: If the domU configu has sdl enabled libvirtd crashes: libvirtd[5158]: libvirtd: libxl.c:343

Re: [libvirt] [Xen-devel] [libvirt test] 50401: regressions - FAIL

On Wed, 2015-04-15 at 14:16 +0100, Daniel P. Berrange wrote: Yeah, there is nothing Xen specific about the problem - it is entirely down to the build toolchain compiler options. FYI our bisector has now tripped over another related problem,

Re: [libvirt] [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh domid save /tmp/blah' with guest corrupting memory (on purpose).

On Thu, 2015-04-16 at 18:18 +0100, Ian Jackson wrote: Jim Fehlig writes (Re: [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh domid save /tmp/blah' with guest corrupting memory (on purpose).): On 04/14/2015 11:31 AM, Ian Jackson wrote: I have produced what I think are

Re: [libvirt] [Xen-devel] [libvirt test] 50401: regressions - FAIL

On Tue, 2015-04-14 at 10:37 +0100, Daniel P. Berrange wrote: On Tue, Apr 14, 2015 at 10:33:45AM +0100, Ian Campbell wrote: On Tue, 2015-04-14 at 02:27 +, osstest service user wrote: flight 50401 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/50401

Re: [libvirt] [Xen-devel] [libvirt test] 50401: regressions - FAIL

On Tue, 2015-04-14 at 02:27 +, osstest service user wrote: flight 50401 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/50401/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 5

Re: [libvirt] [Xen-devel] [PATCH 3/3] libxl: drop virDomainObj lock when destroying a domain

On Wed, 2015-03-25 at 14:08 -0600, Jim Fehlig wrote: A destroy operation can take considerable time on large memory domains due to scrubbing the domain' memory. The operation is running in the context of a job, so unlocking the domain and allowing query operations is safe. Signed-off-by:

Re: [libvirt] [PATCH 8/9] libxl: pass cmdline to HVM guests

On Fri, 2015-03-20 at 22:13 +0100, Marek Marczykowski-Górecki wrote: I'll definitely do. But above raises a question - how can I set extra arguments for qemu? In case of qemu in dom0, it's not a problem because I can create some wrapper script. But in case of qemu in stubdom, the only way is

Re: [libvirt] [Xen-devel] [PATCH] libxl: fix dom0 balloon logic

(just ccing the other tools maintainers, in particular Stefano who knows what this stuff is supposed to do...) On Fri, 2015-03-20 at 17:10 -0600, Jim Fehlig wrote: Recent testing on large memory systems revealed a bug in the Xen xl tool's freemem() function. When autoballooning is enabled,

Re: [libvirt] [PATCH 8/9] libxl: pass cmdline to HVM guests

On Fri, 2015-03-20 at 11:18 -0600, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 8 1 file changed, 8 insertions(+) diff --git a/src/libxl/libxl_conf.c

Re: [libvirt] [Xen-devel] [xen-unstable test] 35257: regressions - FAIL

On Fri, 2015-02-27 at 11:51 -0700, Jim Fehlig wrote: 2015-02-23 20:13:15.845+: 2133: error : virFirewallValidateBackend:193 : direct firewall backend requested, but /sbin/ebtables is not available: No such file or directory Odd, since ebtables was found when building checking for

Re: [libvirt] [Xen-devel] libvirt/libxl implemetation of get_online_cpu / virNodeGetCPUMap?

On Wed, 2015-02-25 at 15:03 +, Daniel P. Berrange wrote: FWIW, this code in openstack was only added for benefit of s390 architecture where apparently it is common to have hosts with CPUs offlined. Presumably you have to pay IBM for each extra CPU you turn online :) Presumably :-) OOI,

Re: [libvirt] [Xen-devel] libvirt/libxl implemetation of get_online_cpu / virNodeGetCPUMap?

On Wed, 2015-02-25 at 10:24 +0100, Dario Faggioli wrote: On Tue, 2015-02-24 at 13:10 +, Ian Campbell wrote: On Tue, 2015-02-24 at 12:41 +, Anthony PERARD wrote: What libxl API those provide this information, if it exist? I found libxl_get_online_cpus() but that not enough

Re: [libvirt] libvirt/libxl implemetation of get_online_cpu / virNodeGetCPUMap?

On Tue, 2015-02-24 at 12:41 +, Anthony PERARD wrote: Hi, A recent OpenStack nova commit make use of virNodeGetCPUMap to get the list of online cpu of a host. But this API is not implemented for the libvirt xen driver. The commit: Add handling for offlined CPUs to the nova libvirt

Re: [libvirt] [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

On Mon, 2015-01-19 at 09:37 +, Ian Campbell wrote: On Mon, 2015-01-19 at 04:48 +, xen.org wrote: branch xen-unstable xen branch xen-unstable job build-armhf-libvirt test libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: qemuu git://xenbits.xen.org/staging/qemu

Re: [libvirt] [PATCH v3 1/3] Add virXMLValidateAgainstSchema helper method

Hello, On Tue, 2015-01-13 at 17:00 +, Daniel P. Berrange wrote: +# define VIR_WARNINGS_NO_PRINTF \ +_Pragma (GCC diagnostic push) \ +_Pragma (GCC diagnostic ignored \-Wsuggest-attribute=format\) Xen automated tests are failing to build on all architectures with:

Re: [libvirt] [PATCH v3 1/3] Add virXMLValidateAgainstSchema helper method

On Fri, 2015-01-16 at 14:19 +, Daniel P. Berrange wrote: On Fri, Jan 16, 2015 at 01:58:27PM +, Ian Campbell wrote: Hello, On Tue, 2015-01-13 at 17:00 +, Daniel P. Berrange wrote: +# define VIR_WARNINGS_NO_PRINTF \ +_Pragma (GCC diagnostic push) \ +_Pragma (GCC

Re: [libvirt] [PATCH] Conditionalize use of -Wno-suggest-attribute=format pragma

On Fri, 2015-01-16 at 14:55 +, Daniel P. Berrange wrote: Many GCC versions don't understand -Wno-suggest-attribute=format so the pragma must only be used when supported That seems to have done the trick: Tested-by: Ian Campbell ian.campb...@citrix.com -- libvir-list mailing list libvir

Re: [libvirt] [Xen-devel] [PATCH 00/12] Replace Xen xl parsing/formatting impl

On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote: The first attempt to implement support for parsing/formatting Xen's xl disk config format copied Xen's flex-based parser into libvirt, which has proved to be challenging in the context of autotools. But as it turns out, Xen provides an

Re: [libvirt] [Xen-devel] [PATCH 00/12] Replace Xen xl parsing/formatting impl

On Mon, 2015-01-12 at 09:23 -0700, Jim Fehlig wrote: Ian Campbell wrote: On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote: The first attempt to implement support for parsing/formatting Xen's xl disk config format copied Xen's flex-based parser into libvirt, which has proved

Re: [libvirt] [PATCH v4 1/2] src/Makefile: move the new xen_xl_disk parser code at the correct place

On Thu, 2015-01-08 at 16:43 -0700, Jim Fehlig wrote: Eric Blake wrote: On 01/08/2015 06:20 AM, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina phrd...@redhat.com --- src/Makefile.am | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-)

Re: [libvirt] [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

On Tue, 2015-01-06 at 17:20 +, Wei Liu wrote: On Tue, Jan 06, 2015 at 05:03:59PM +, Ian Campbell wrote: On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: No need to check hostarch to determine whether to use lib or lib64 anymore because we now always use lib. What about

Re: [libvirt] [Xen-devel] [PATCH RFC] libxl: fix paths in capability string

On Tue, 2015-01-06 at 16:12 +, Wei Liu wrote: No need to check hostarch to determine whether to use lib or lib64 anymore because we now always use lib. What about people who use --libdir=/path/to/lib64, as I believe Red Hat derived distros still do, don't they? Ian. -- libvir-list mailing

Re: [libvirt] [Xen-devel] [PATCH V2] libxl: Set path to console on domain startup.

On Mon, 2014-12-15 at 17:07 +, Anthony PERARD wrote: On Thu, Dec 11, 2014 at 04:23:15PM +, Ian Campbell wrote: On Thu, 2014-12-11 at 16:16 +, Anthony PERARD wrote: On Tue, Dec 09, 2014 at 03:56:02PM +, Ian Campbell wrote: On Tue, 2014-12-09 at 15:39 +, Anthony PERARD

Re: [libvirt] [Xen-devel] [PATCH V2] libxl: Set path to console on domain startup.

On Tue, 2014-12-16 at 12:36 +, Ian Jackson wrote: Anthony PERARD writes (Re: [Xen-devel] [PATCH V2] libxl: Set path to console on domain startup.): On Tue, Dec 16, 2014 at 09:30:28AM +, Ian Campbell wrote: Unless by not running you meant bottlenecked or not keeping up perhaps

Re: [libvirt] [Xen-devel] [PATCH] xenconfig: fix boot device parsing

On Sun, 2014-12-14 at 14:58 +, Wei Liu wrote: The original code always checked *boot which was in effect boot[0]. It should use boot[i]. Signed-off-by: Wei Liu wei.l...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [Xen-devel] [PATCH V2] libxl: Set path to console on domain startup.

On Thu, 2014-12-11 at 16:16 +, Anthony PERARD wrote: On Tue, Dec 09, 2014 at 03:56:02PM +, Ian Campbell wrote: On Tue, 2014-12-09 at 15:39 +, Anthony PERARD wrote: The path to the pty of a Xen PV console is set only in virDomainOpenConsole. But this is done too late. A call

Re: [libvirt] [Xen-devel] [PATCH V2] libxl: Set path to console on domain startup.

On Tue, 2014-12-09 at 15:39 +, Anthony PERARD wrote: The path to the pty of a Xen PV console is set only in virDomainOpenConsole. But this is done too late. A call to virDomainGetXMLDesc done before OpenConsole will not have the path to the pty, but a call after OpenConsole will. e.g.

Re: [libvirt] [Xen-devel] [PATCH] libxl: Set path to console on domain startup.

On Fri, 2014-12-05 at 16:30 +, Anthony PERARD wrote: Jim Fehlig maintains the libxl driver in libvirt, so you should CC him (I've done so here...) The path to the pty of a Xen PV console is set only in virDomainOpenConsole. But this is done too late. A call to virDomainGetXMLDesc done

Re: [libvirt] [Xen-devel] [PATCH] libxl: Set path to console on domain startup.

On Mon, 2014-12-08 at 15:11 +, Anthony PERARD wrote: The patch intend to get the tty path on the first call of GetXMLDesc. Doesn't it actually do it on domain start (which makes more sense to me anyway). Just a wording issue. I meant: Have GetXMLDesc always return the path to the

Re: [libvirt] [PATCH] docs: Correct invalid hyperlinks

On Tue, 2014-12-02 at 07:50 +0100, Martin Kletzander wrote: That said, I found out that that XML-XPath is only needed when creating the tarball, but (probably) not when building an RPM with it. It's needed when building from the git tree to, Xen automated testing picked up on this overnight:

[libvirt] [PATCH] docs: Create html documentation even if XHTML1 DTD is not available to validate

for the .html.tmp file to be propagated to the .html output. Signed-off-by: Ian Campbell ian.campb...@citrix.com Cc: Daniel Veillard veill...@redhat.com --- docs/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 5485ee9

Re: [libvirt] [PATCH] docs: Create html documentation even if XHTML1 DTD is not available to validate

On Fri, 2014-11-28 at 14:36 +, Ian Campbell wrote: On a Debian system lacking the w3c-dtd-xhtml package the build fails On a somewhat related note on a system without xsltproc configure succeeds but the build does not: $ make -C docs csharp.html make: Entering directory

Re: [libvirt] [Xen-devel] [PATCH 1/2] virdbus: don't force users to pass int for bool values

On Mon, 2014-11-24 at 09:21 -0700, Eric Blake wrote: On 11/24/2014 02:43 AM, Ian Campbell wrote: I think this change breaks build on FreeBSD: CC util/libvirt_util_la-virdbus.lo util/virdbus.c:956:13: error: cast from 'bool *' to 'dbus_bool_t *' (aka 'unsigned int

Re: [libvirt] [PATCH 1/2] virdbus: don't force users to pass int for bool values

On Fri, 2014-11-21 at 17:16 -0700, Eric Blake wrote: On 11/20/2014 04:17 PM, Eric Blake wrote: On 11/20/2014 08:12 AM, Conrad Meyer wrote: Hi Eric, I think this change breaks build on FreeBSD: CC util/libvirt_util_la-virdbus.lo util/virdbus.c:956:13: error: cast from 'bool

Re: [libvirt] [Xen-devel] dom0 kenrel crashes for openstack + libvirt + libxl

On Fri, 2014-11-21 at 09:28 +, Ian Campbell wrote: I think libvirt is wrong to specify an absolute path here, IMHO by default it should just specify pygrub and let libxl figure out the correct path. Jim, what do you think? e.g. something like the following untested (but pretty obvious[0

Re: [libvirt] [Xen-devel] dom0 kenrel crashes for openstack + libvirt + libxl

On Fri, 2014-11-21 at 14:18 +, David Vrabel wrote: On 21/11/14 14:05, Ian Campbell wrote: On Fri, 2014-11-21 at 09:28 +, Ian Campbell wrote: I think libvirt is wrong to specify an absolute path here, IMHO by default it should just specify pygrub and let libxl figure out

Re: [libvirt] [Xen-devel] dom0 kenrel crashes for openstack + libvirt + libxl

On Fri, 2014-11-21 at 14:32 +, Ian Campbell wrote: I've now built and tested this with the 1.2.9 Debian package, works like a charm... From 9f2d8da8264b426f54b92378e9e00973694193d4 Mon Sep 17 00:00:00 2001 From: Ian Campbell ian.campb...@citrix.com Date: Fri, 21 Nov 2014 14:00:38 +

Re: [libvirt] libvirt build failure on armhf (Re: [Xen-devel] [libvirt bisection] complete build-armhf-libvirt)

On Tue, 2014-10-21 at 18:02 -0600, Jim Fehlig wrote: Ian Campbell wrote: Hi, On Fri, 2014-10-17 at 00:42 +0100, xen.org wrote: *** Found and reproduced problem changeset *** Bug is in tree: libvirt git://libvirt.org/libvirt.git Bug introduced

[libvirt] libvirt build failure on armhf (Re: [Xen-devel] [libvirt bisection] complete build-armhf-libvirt)

Hi, On Fri, 2014-10-17 at 00:42 +0100, xen.org wrote: *** Found and reproduced problem changeset *** Bug is in tree: libvirt git://libvirt.org/libvirt.git Bug introduced: 24c160376275b7d31f71fbde83af8183cbf744a7 Bug not present: 69f7b67d55316ab7b28fb904b346943497b856a1 The Xen

Re: [libvirt] [PATCH] virprocess: Introduce our own setns() wrapper

On Mon, 2014-09-15 at 10:21 +0100, Daniel P. Berrange wrote: On Sun, Sep 14, 2014 at 06:35:19PM +0100, Ian Campbell wrote: On Wed, 2014-09-10 at 12:20 +0200, Michal Privoznik wrote: +/* + * Workaround older glibc. While kernel may support the setns + * syscall, the glibc wrapper

Re: [libvirt] [PATCH] virprocess: Introduce our own setns() wrapper

On Wed, 2014-09-10 at 12:20 +0200, Michal Privoznik wrote: +/* + * Workaround older glibc. While kernel may support the setns + * syscall, the glibc wrapper might not exist. If that's the + * case, use our own. + */ +#ifndef __NR_setns +# if defined(__x86_64__) +# define __NR_setns 308

Re: [libvirt] [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

Xen's automated testing of libvirt against newer Xen's has found a build issue which it has bisected down to blockcopy: expose new API in virsh. An instance of the failure can be found in flight 30154: http://lists.xen.org/archives/html/xen-devel/2014-09/msg01063.html links to the logs =

Re: [libvirt] [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

On Tue, 2014-09-09 at 09:54 +0100, Daniel P. Berrange wrote: On Tue, Sep 09, 2014 at 09:49:47AM +0100, Ian Campbell wrote: Xen's automated testing of libvirt against newer Xen's has found a build issue which it has bisected down to blockcopy: expose new API in virsh. An instance

Re: [libvirt] [Xen-devel] [PATCH] libxl: support domainReset

On Tue, 2014-08-05 at 20:30 +0100, Wei Liu wrote: On Tue, Aug 05, 2014 at 07:45:48PM +0100, Ian Campbell wrote: [...] Sure. I think having an API that emulates a power reset button would be a nice addition to libxl's domain operations. The destroy/start approach incurs

Re: [libvirt] [Xen-devel] [PATCH] libxl: support domainReset

On Mon, 2014-08-04 at 20:09 -0600, Jim Fehlig wrote: Currently, libxl_send_trigger() does not implement the LIBXL_TRIGGER_RESET option, There's a case in the switch within libxl_send_trigger which at least purports to do so: int libxl_send_trigger(libxl_ctx *ctx, uint32_t domid,

Re: [libvirt] [Xen-devel] [PATCH] libxl: support domainReset

On Tue, 2014-08-05 at 10:41 +0200, Olaf Hering wrote: On Tue, Aug 05, Ian Campbell wrote: case LIBXL_TRIGGER_RESET: rc = xc_domain_send_trigger(ctx-xch, domid, XEN_DOMCTL_SENDTRIGGER_RESET, vcpu break; Do you mean to say

Re: [libvirt] [Xen-devel] [PATCH] libxl: support domainReset

On Tue, 2014-08-05 at 10:55 +0200, Olaf Hering wrote: On Tue, Aug 05, Ian Campbell wrote: On Tue, 2014-08-05 at 10:41 +0200, Olaf Hering wrote: On Tue, Aug 05, Ian Campbell wrote: case LIBXL_TRIGGER_RESET: rc = xc_domain_send_trigger(ctx-xch, domid

Re: [libvirt] [Xen-devel] [PATCH] libxl: support domainReset

On Tue, 2014-08-05 at 08:06 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Tue, 2014-08-05 at 10:55 +0200, Olaf Hering wrote: The original report was that 'Reset' does not work from GUI, like virt-manager or virsh. I think the expected outcome is like pushing the reset button

Re: [libvirt] [Xen-devel] [PATCH] libxl: support domainReset

On Tue, 2014-08-05 at 09:10 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Tue, 2014-08-05 at 08:06 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Tue, 2014-08-05 at 10:55 +0200, Olaf Hering wrote: The original report was that 'Reset' does not work from GUI

Re: [libvirt] [Xen-devel] [PATCH] libxl: support domainReset

On Tue, 2014-08-05 at 17:12 +0100, Wei Liu wrote: On Tue, Aug 05, 2014 at 04:30:47PM +0100, Ian Campbell wrote: On Tue, 2014-08-05 at 09:10 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Tue, 2014-08-05 at 08:06 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Tue

Re: [libvirt] [PATCH] libxl: don't break the build on Xen=4.5 because of libxl_vcpu_setaffinity()

On Tue, 2014-07-01 at 11:00 -0600, Jim Fehlig wrote: Dario Faggioli wrote: Just thinking out loud here but, if we did not get the push failure, when would have we discovered this? Good question. I could have been days (or even weeks) before I stumbled across it. ATM, I don't have

Re: [libvirt] [PATCH] libxl: don't break the build on Xen=4.5 because of libxl_vcpu_setaffinity()

On Tue, 2014-07-01 at 08:52 +0200, Dario Faggioli wrote: On lun, 2014-06-30 at 15:32 -0600, Jim Fehlig wrote: Eric Blake wrote: Thanks, looks good. I was about to push, but wanted to check with other libvirt devs first since we are in 1.2.6 freeze. Would it be fine to push

Re: [libvirt] [PATCH V2] libxl: detect support for save and restore

by Ian Campbell while improving Xen's OSSTEST infrastructure http://lists.xen.org/archives/html/xen-devel/2014-06/msg02171.html Signed-off-by: Jim Fehlig jfeh...@suse.com --- Another option for https://www.redhat.com/archives/libvir-list/2014-June/msg01276.html With this one, we even

Re: [libvirt] [Xen-devel] [PATCH] libxl: prefer qdisk for driver name='file'

On Tue, 2014-06-24 at 16:24 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Fri, 2014-06-20 at 15:07 -0600, Jim Fehlig wrote: The libxl driver currently sets the disk backend to LIBXL_DISK_BACKEND_TAP when driver name='file' is specified in the disk config. qdisk should be prefered

Re: [libvirt] [Xen-devel] [PATCH RFC OSSTEST 7/9] Toolstack: Abstract away migration support check.

On Wed, 2014-06-25 at 09:25 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Tue, 2014-06-24 at 21:18 -0600, Jim Fehlig wrote: Something like the attached patch (compile-tested only). You'll need an updated libvirt.git master to apply cleanly. Thanks. Building on ARM I get

Re: [libvirt] [PATCH] libxl: detect support for save and restore

advertisement of migration_features. Found by Ian Campbell while improving Xen's OSSTEST infrastructure http://lists.xen.org/archives/html/xen-devel/2014-06/msg02171.html Signed-off-by: Jim Fehlig jfeh...@suse.com --- Derived from a test patch I sent to Ian Campbell http

Re: [libvirt] [PATCH libvirt] xen: handle root= in xen-xm configuration files.

On Thu, 2014-06-19 at 00:15 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote: +if (xenXMConfigGetString(conf, extra, extra, NULL) 0) This was subtly broken. The default needs to be . Turns out, it wasn't

Re: [libvirt] [Xen-devel] [PATCH] libxl: prefer qdisk for driver name='file'

On Fri, 2014-06-20 at 15:07 -0600, Jim Fehlig wrote: The libxl driver currently sets the disk backend to LIBXL_DISK_BACKEND_TAP when driver name='file' is specified in the disk config. qdisk should be prefered with this configuration, otherwise existing configuration such as the following,

Re: [libvirt] [PATCH v2 4/4] libxl: Add a test suite for libxl option generator

On Tue, 2014-06-17 at 12:40 -0600, Jim Fehlig wrote: Ian Campbell wrote: On Mon, 2014-06-16 at 17:11 -0600, Jim Fehlig wrote: This function exists in Xen 4.2 as well, in libxl.h. Any ideas on how to handle this? I'm not aware of an existing macro to check for func 'foo

Re: [libvirt] [PATCH libvirt] xen: handle root= in xen-xm configuration files.

On Tue, 2014-06-17 at 16:24 +0100, Ian Campbell wrote: +if (xenXMConfigGetString(conf, extra, extra, NULL) 0) This was subtly broken. The default needs to be . -8-- From 539412a6deac8b928c82945d692ef20a49535d65 Mon Sep 17 00:00:00 2001 From: Ian Campbell ian.campb

Re: [libvirt] [Xen-devel] [PATCH libvirt] xen: handle root= in xen-xm configuration files.

On Tue, 2014-06-17 at 15:36 -0600, Jim Fehlig wrote: Eric Blake wrote: On 06/17/2014 09:24 AM, Ian Campbell wrote: In addition to extra= xm supported a root= option which was supposed to be incorporated into the final command line. Handle that for virsh domxml-from-native xen-xm

Re: [libvirt] [PATCH v7 RFC 0/2] libxl USB prototype and design discussion

On Mon, 2014-06-02 at 14:44 +0100, George Dunlap wrote: == Open questions == Those are things I think I know; there are a couple of pertinent factual questions which I'm not sure of: * Is it possible to specify PVUSB controllers and attach USB devices to them before the guest is up and

Re: [libvirt] [PATCH v2 4/4] libxl: Add a test suite for libxl option generator

On Mon, 2014-06-16 at 17:11 -0600, Jim Fehlig wrote: This function exists in Xen 4.2 as well, in libxl.h. Any ideas on how to handle this? I'm not aware of an existing macro to check for func 'foo' defined in header 'bar'. Is writing a custom macro along these lines a good solution?

  1   2   >