[libvirt] [PATCHv2] virt-xml-validate: Allow input to be read from stdin

2019-05-21 Thread Johannes Holmberg
Signed-off-by: Johannes Holmberg --- Changes from v1: - Quotes around $TMPFILE everywhere. - Explicit -n checks in if statements - Fixed one instance of incorrect indentation - Signed-off-by line in commit message tools/virt-xml-validate.in | 46 -- 1

Re: [libvirt] [PATCH] virt-xml-validate: Allow input to be read from stdin

2019-05-21 Thread Johannes Holmberg
On Tue, 2019-05-21 at 07:36 +0200, Philipp Hahn wrote: > Hello, > > Some nits: > > Am 20.05.19 um 13:57 schrieb Johannes Holmberg: > > diff --git a/tools/virt-xml-validate.in b/tools/virt-xml- > > validate.in > > index 64ae33..2d2afb74ec 100644 > > ---

Re: [libvirt] [PATCH] virt-xml-validate: Allow input to be read from stdin

2019-05-20 Thread Johannes Holmberg
On Mon, 2019-05-20 at 14:18 +0200, Martin Kletzander wrote: > On Mon, May 20, 2019 at 11:57:13AM +0000, Johannes Holmberg wrote: > > --- > > > > Hello, > > > > This is an updated version of a patch I submitted on 2015-06-10. I > > got > > some fe

[libvirt] [PATCH] virt-xml-validate: Allow input to be read from stdin

2019-05-20 Thread Johannes Holmberg
--- Hello, This is an updated version of a patch I submitted on 2015-06-10. I got some feedback on it but then moved on to a different project and forgot about it. Anyway, I've updated the patch according to the feedback so if you are still interested, here it is! :) /Johannes tools/virt-xml-

Re: [libvirt] [PATCH] virt-xml-validate: Allow input to be read from stdin

2015-06-24 Thread Johannes Holmberg
- On 24 Jun, 2015, at 09:14, Martin Kletzander mklet...@redhat.com wrote: > Why don't you just set XMLFILE="$TMPFILE" ? That would get rid of lot > of the code changes below and would be more readable. > > Other than that it looks good. Good question, with a somewhat long answer. I initially

[libvirt] [PATCH] virt-xml-validate: Allow input to be read from stdin

2015-06-10 Thread Johannes Holmberg
--- Hello, I often find myself wanting to validate a domain xml without having to save it to a file, so I've updated virt-xml-validate to support the standard practice of reading from stdin when "-" is given as the input file. Of course, the validation is multipass so there still needs to be a te