Re: [PATCH v2 27/31] qom: Add user_creatable_add_from_str()

2021-03-02 Thread Kevin Wolf
Am 26.02.2021 um 23:21 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > This is a version of user_creatable_process_cmdline() with an Error > > parameter that never calls exit() and is therefore usable in HMP. > > > > Signed-off-by: Kevin Wol

Re: [PATCH v2 19/31] qapi/qom: QAPIfy object-add

2021-03-02 Thread Kevin Wolf
Am 26.02.2021 um 22:18 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > This converts object-add from 'gen': false to the ObjectOptions QAPI > > type. As an immediate benefit, clients can now use QAPI schema > > introspection for user creata

Re: [PATCH v2 17/31] qapi/qom: Add ObjectOptions for input-*

2021-03-02 Thread Kevin Wolf
Am 26.02.2021 um 21:55 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > This adds a QAPI schema for the properties of the input-* objects. > > > > ui.json cannot be included in qom.json because the storage daemon can't > > use it, so mo

Re: [PATCH v2 12/31] qapi/qom: Add ObjectOptions for can-*

2021-03-02 Thread Kevin Wolf
Am 26.02.2021 um 20:42 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > This adds a QAPI schema for the properties of the can-* objects. > > > > can-bus doesn't have any properties, so it only needs to be added to the > > ObjectType enu

Re: [PATCH v2 11/31] qapi/qom: Add ObjectOptions for tls-*, deprecate 'loaded'

2021-03-02 Thread Kevin Wolf
Am 26.02.2021 um 20:33 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > This adds a QAPI schema for the properties of the tls-* objects. > > > > The 'loaded' property doesn't seem to make sense as an external > > interface: It is

Re: [PATCH v2 10/31] qapi/qom: Add ObjectOptions for secret*, deprecate 'loaded'

2021-03-02 Thread Kevin Wolf
Am 26.02.2021 um 20:17 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > diff --git a/qapi/qom.json b/qapi/qom.json > > index 449dca8ec5..2668ad8369 100644 > > --- a/qapi/qom.json > > +++ b/qapi/qom.json > > @@ -7,6 +7,7 @@ > > { &#

Re: [PATCH v2 09/31] qapi/qom: Add ObjectOptions for throttle-group

2021-03-02 Thread Kevin Wolf
Am 26.02.2021 um 18:26 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > This adds a QAPI schema for the properties of the throttle-group object. > > > > The only purpose of the x-* properties is to make the nested options in > > 'limits'

Re: [PATCH v2 07/31] qapi/qom: Add ObjectOptions for memory-backend-*

2021-03-02 Thread Kevin Wolf
Am 26.02.2021 um 17:23 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > This adds a QAPI schema for the properties of the memory-backend-* > > objects. > > > > HostMemPolicy has to be moved to an include file that can be used by the >

Re: [PATCH v2 06/31] qapi/qom: Add ObjectOptions for dbus-vmstate

2021-03-02 Thread Kevin Wolf
Am 26.02.2021 um 16:58 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > This adds a QAPI schema for the properties of the dbus-vmstate object. > > > > A list represented as a comma separated string is clearly not very > > QAPI-like, but for now

Re: [PATCH v2 03/31] qapi/qom: Add ObjectOptions for iothread

2021-03-02 Thread Kevin Wolf
Am 25.02.2021 um 23:55 hat Eric Blake geschrieben: > On 2/24/21 7:52 AM, Kevin Wolf wrote: > > Add an ObjectOptions union that will eventually describe the options of > > all user creatable object types. As unions can't exist without any > > branches, also add the first

Re: [PATCH v2 19/31] qapi/qom: QAPIfy object-add

2021-03-01 Thread Kevin Wolf
Am 26.02.2021 um 12:30 hat Paolo Bonzini geschrieben: > On 24/02/21 14:52, Kevin Wolf wrote: > > +v = qobject_output_visitor_new(&qobj); > > +visit_type_ObjectOptions(v, NULL, &options, &error_abort); > > +visit_complete(v, &qobj); > &g

Re: [PATCH 00/14] deprecations: remove many old deprecations

2021-03-01 Thread Kevin Wolf
Am 25.02.2021 um 18:32 hat Jim Fehlig geschrieben: > Adding xen-devel and Ian to cc. > > On 2/24/21 6:11 AM, Daniel P. Berrangé wrote: > > The following features have been deprecated for well over the 2 > > release cycle we promise > > This reminded me of a bug report we received late last year w

Re: [PATCH v2 16/31] qapi/qom: Add ObjectOptions for confidential-guest-support

2021-02-24 Thread Kevin Wolf
Am 24.02.2021 um 16:21 hat Dr. David Alan Gilbert geschrieben: > * Kevin Wolf (kw...@redhat.com) wrote: > > This adds a QAPI schema for the properties of the objects implementing > > the confidential-guest-support interface. > > > > pef-guest and s390x-pv-guest don

[PATCH v2 31/31] qom: Drop QemuOpts based interfaces

2021-02-24 Thread Kevin Wolf
user_creatable_add_opts() has only a single user left, which is a test case. Rewrite the test to use user_creatable_add_type() instead (which is the remaining function that doesn't require a QAPI schema) and drop the QemuOpts related functions. Signed-off-by: Kevin Wolf --- includ

[PATCH v2 23/31] qom: Factor out user_creatable_process_cmdline()

2021-02-24 Thread Kevin Wolf
qom/qom-qmp-cmds.c is not linked for tools. user_creatable_print_help_from_qdict() can become static now. Signed-off-by: Kevin Wolf --- include/qom/object_interfaces.h | 41 +++ qom/object_interfaces.c | 50 +++- qom/qom-qmp-cmds.c

[PATCH v2 22/31] qom: Remove user_creatable_add_dict()

2021-02-24 Thread Kevin Wolf
This function is now unused and can be removed. Signed-off-by: Kevin Wolf --- include/qom/object_interfaces.h | 18 -- qom/object_interfaces.c | 32 2 files changed, 50 deletions(-) diff --git a/include/qom/object_interfaces.h b/include

[PATCH v2 19/31] qapi/qom: QAPIfy object-add

2021-02-24 Thread Kevin Wolf
e could be generated from the schema. Signed-off-by: Kevin Wolf --- qapi/qom.json| 11 +-- include/qom/object_interfaces.h | 7 --- hw/block/xen-block.c | 16 monitor/misc.c | 2 -- qom/qom-

[PATCH v2 27/31] qom: Add user_creatable_add_from_str()

2021-02-24 Thread Kevin Wolf
This is a version of user_creatable_process_cmdline() with an Error parameter that never calls exit() and is therefore usable in HMP. Signed-off-by: Kevin Wolf --- include/qom/object_interfaces.h | 16 qom/object_interfaces.c | 29 - 2 files

[PATCH v2 28/31] hmp: QAPIfy object_add

2021-02-24 Thread Kevin Wolf
of stdout, the printf() calls in the help functions are changed to qemu_printf(). Signed-off-by: Kevin Wolf --- monitor/hmp-cmds.c | 17 ++--- qom/object_interfaces.c | 11 ++- hmp-commands.hx | 2 +- 3 files changed, 9 insertions(+), 21 deletions(-) diff --git

[PATCH v2 25/31] qemu-img: Use user_creatable_process_cmdline() for --object

2021-02-24 Thread Kevin Wolf
This switches qemu-img from a QemuOpts-based parser for --object to user_creatable_process_cmdline() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties accessible. Signed-off-by: Kevin Wolf --- qemu-img.c | 239

[PATCH v2 24/31] qemu-io: Use user_creatable_process_cmdline() for --object

2021-02-24 Thread Kevin Wolf
This switches qemu-io from a QemuOpts-based parser for --object to user_creatable_process_cmdline() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties accessible. Signed-off-by: Kevin Wolf --- qemu-io.c | 33

[PATCH v2 30/31] vl: QAPIfy -object

2021-02-24 Thread Kevin Wolf
supporting one less isn't the end of the world. As object definitions from -readconfig still go through QemuOpts, they are still included in -writeconfig output, which at least prevents destroying your existing configuration when you just wanted to add another option. Signed-off-by: Kevin

[PATCH v2 21/31] qemu-storage-daemon: Implement --object with qmp_object_add()

2021-02-24 Thread Kevin Wolf
This QAPIfies --object and ensures that QMP and the command line option behave the same. Signed-off-by: Kevin Wolf --- storage-daemon/qemu-storage-daemon.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/storage-daemon/qemu-storage-daemon.c b/storage

[PATCH v2 07/31] qapi/qom: Add ObjectOptions for memory-backend-*

2021-02-24 Thread Kevin Wolf
d-off-by: Kevin Wolf --- qapi/common.json | 20 qapi/machine.json | 22 + qapi/qom.json | 118 +- 3 files changed, 138 insertions(+), 22 deletions(-) diff --git a/qapi/common.json b/qapi/common.json index 716712d4b3..2dad4fadc3 1

[PATCH v2 29/31] qom: Add user_creatable_parse_str()

2021-02-24 Thread Kevin Wolf
the system emulator command line. Signed-off-by: Kevin Wolf --- include/qom/object_interfaces.h | 15 +++ qom/object_interfaces.c | 20 ++-- 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/include/qom/object_interfaces.h b/include/qom

[PATCH v2 26/31] qemu-nbd: Use user_creatable_process_cmdline() for --object

2021-02-24 Thread Kevin Wolf
This switches qemu-nbd from a QemuOpts-based parser for --object to user_creatable_process_cmdline() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties accessible. Signed-off-by: Kevin Wolf --- qemu-nbd.c | 34

[PATCH v2 18/31] qapi/qom: Add ObjectOptions for x-remote-object

2021-02-24 Thread Kevin Wolf
This adds a QAPI schema for the properties of the x-remote-object object. Signed-off-by: Kevin Wolf --- qapi/qom.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/qom.json b/qapi/qom.json index f8ff322df0..6793342e81 100644 --- a/qapi/qom.json

[PATCH v2 05/31] qapi/qom: Add ObjectOptions for cryptodev-*

2021-02-24 Thread Kevin Wolf
existing interface in QAPI, leave these things in place. Signed-off-by: Kevin Wolf --- qapi/qom.json | 34 ++ 1 file changed, 34 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index 30ed179bc1..1dbc95fb53 100644 --- a/qapi/qom.json +++ b/qapi/qom.json

[PATCH v2 20/31] qom: Make "object" QemuOptsList optional

2021-02-24 Thread Kevin Wolf
object from it. Signed-off-by: Kevin Wolf --- qom/object_interfaces.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c index 1e9ad6f08a..b9a99c8bf4 100644 --- a/qom/object_interfaces.c +++ b/qom/object_interfa

[PATCH v2 14/31] qapi/qom: Add ObjectOptions for filter-*

2021-02-24 Thread Kevin Wolf
x27;t have it. NetFilterDirection is still required in the new object property definitions in qom.json, so move this enum to common.json. Signed-off-by: Kevin Wolf --- qapi/common.json | 20 +++ qapi/net.json| 20 --- qapi/qom.json| 143

[PATCH v2 10/31] qapi/qom: Add ObjectOptions for secret*, deprecate 'loaded'

2021-02-24 Thread Kevin Wolf
e silently ignored. In other words, the 'loaded' property is useless. Mark it as deprecated in the schema from the start. Signed-off-by: Kevin Wolf --- qapi/crypto.json | 61 ++ qapi/qom.json | 5 docs/system/deprecated.rst |

[PATCH v2 08/31] qapi/qom: Add ObjectOptions for rng-*, deprecate 'opened'

2021-02-24 Thread Kevin Wolf
ons will result in an error. After the property has once been set to true (i.e. when the object construction has completed), it can never be reset to false. In other words, the 'opened' property is useless. Mark it as deprecated in the schema from the start. Signed-off-by: Ke

[PATCH v2 03/31] qapi/qom: Add ObjectOptions for iothread

2021-02-24 Thread Kevin Wolf
Add an ObjectOptions union that will eventually describe the options of all user creatable object types. As unions can't exist without any branches, also add the first object type. This adds a QAPI schema for the properties of the iothread object. Signed-off-by: Kevin Wolf --- qapi/qom

[PATCH v2 11/31] qapi/qom: Add ObjectOptions for tls-*, deprecate 'loaded'

2021-02-24 Thread Kevin Wolf
ently ignored. In other words, the 'loaded' property is useless. Mark it as deprecated in the schema from the start. Signed-off-by: Kevin Wolf --- qapi/crypto.json | 98 qapi/qom.json| 12 +- 2 files changed, 108 insertions(+),

[PATCH v2 13/31] qapi/qom: Add ObjectOptions for colo-compare

2021-02-24 Thread Kevin Wolf
This adds a QAPI schema for the properties of the colo-compare object. Signed-off-by: Kevin Wolf --- qapi/qom.json | 49 + 1 file changed, 49 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index 4b1cd4b8dc..8e4414f843 100644 --- a/qapi

[PATCH v2 12/31] qapi/qom: Add ObjectOptions for can-*

2021-02-24 Thread Kevin Wolf
This adds a QAPI schema for the properties of the can-* objects. can-bus doesn't have any properties, so it only needs to be added to the ObjectType enum without adding a new branch to ObjectOptions. Signed-off-by: Kevin Wolf --- qapi/qom.json | 18 ++ 1 file change

[PATCH v2 17/31] qapi/qom: Add ObjectOptions for input-*

2021-02-24 Thread Kevin Wolf
This adds a QAPI schema for the properties of the input-* objects. ui.json cannot be included in qom.json because the storage daemon can't use it, so move GrabToggleKeys to common.json. Signed-off-by: Kevin Wolf --- qapi/common.json | 12 ++ qapi/qom.json

[PATCH v2 16/31] qapi/qom: Add ObjectOptions for confidential-guest-support

2021-02-24 Thread Kevin Wolf
This adds a QAPI schema for the properties of the objects implementing the confidential-guest-support interface. pef-guest and s390x-pv-guest don't have any properties, so they only need to be added to the ObjectType enum without adding a new branch to ObjectOptions. Signed-off-by: Kevin

[PATCH v2 09/31] qapi/qom: Add ObjectOptions for throttle-group

2021-02-24 Thread Kevin Wolf
cts, though, so they will not be needed in the schema in the future. To keep the conversion straightforward, add them to the schema anyway. We can then remove the options and adjust documentation, test cases etc. in a separate patch. Signed-off-by: Kevin Wolf --- qapi/block

[PATCH v2 15/31] qapi/qom: Add ObjectOptions for pr-manager-helper

2021-02-24 Thread Kevin Wolf
This adds a QAPI schema for the properties of the pr-manager-helper object. Signed-off-by: Kevin Wolf --- qapi/qom.json | 14 ++ 1 file changed, 14 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index e3357f5123..e7184122e9 100644 --- a/qapi/qom.json +++ b/qapi/qom.json

[PATCH v2 06/31] qapi/qom: Add ObjectOptions for dbus-vmstate

2021-02-24 Thread Kevin Wolf
This adds a QAPI schema for the properties of the dbus-vmstate object. A list represented as a comma separated string is clearly not very QAPI-like, but for now just describe the existing interface. Signed-off-by: Kevin Wolf --- qapi/qom.json | 18 ++ 1 file changed, 18

[PATCH v2 04/31] qapi/qom: Add ObjectOptions for authz-*

2021-02-24 Thread Kevin Wolf
This adds a QAPI schema for the properties of the authz-* objects. Signed-off-by: Kevin Wolf --- qapi/authz.json | 62 qapi/qom.json| 10 + storage-daemon/qapi/qapi-schema.json | 1 + 3 files changed, 73 insertions

[PATCH v2 01/31] tests: Drop 'props' from object-add calls

2021-02-24 Thread Kevin Wolf
The 'props' option has been deprecated in 5.0 in favour of a flattened object-add command. Time to change our test cases to drop the deprecated option. Signed-off-by: Kevin Wolf --- tests/qtest/qmp-cmd-test.c | 16 +-- tests/qtest/test-netfil

[PATCH v2 00/31] qapi/qom: QAPIfy --object and object-add

2021-02-24 Thread Kevin Wolf
umentation to refer to the version when the object was introduced rather than 6.0 where the schema will (hopefully) be added - Probably some other minor changes Kevin Wolf (31): tests: Drop 'props' from object-add calls qapi/qom: Drop deprecated 'props' from obje

[PATCH v2 02/31] qapi/qom: Drop deprecated 'props' from object-add

2021-02-24 Thread Kevin Wolf
The option has been deprecated in QEMU 5.0, remove it. Signed-off-by: Kevin Wolf --- qapi/qom.json| 6 +- docs/system/deprecated.rst | 5 - docs/system/removed-features.rst | 5 + qom/qom-qmp-cmds.c | 21 - 4 files

Re: [PATCH 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()

2021-01-25 Thread Kevin Wolf
Am 25.01.2021 um 17:24 hat Markus Armbruster geschrieben: > The previous commit rendered the name fdctrl_realize_common() somewhat > misleading. Get rid of it by inlining the (now pretty simple) > function into its only caller. > > Signed-off-by: Markus Armbruster > --- > hw/block/fdc.c | 23 ++

Re: qmp-shell TUI (was: Re: Call for Google Summer of Code 2021 project ideas)

2021-01-14 Thread Kevin Wolf
Am 14.01.2021 um 14:59 hat Daniel P. Berrangé geschrieben: > On Thu, Jan 14, 2021 at 01:52:34PM +, Stefan Hajnoczi wrote: > > On Wed, Jan 13, 2021 at 01:59:43PM -0500, John Snow wrote: > > > On 1/13/21 3:53 AM, Stefan Hajnoczi wrote: > > > > On Tue, Jan 12, 2021 at 9:10 PM John Snow wrote: >

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-03 Thread Kevin Wolf
Am 03.12.2020 um 17:50 hat Paolo Bonzini geschrieben: > On 03/12/20 16:15, Kevin Wolf wrote: > > I don't think this is an intermediate state like Eduardo wants to have. > > Creating the object, then setting properties, then realize [1] will fail > > after your change.

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-03 Thread Kevin Wolf
Am 03.12.2020 um 12:11 hat Paolo Bonzini geschrieben: > On 02/12/20 18:35, Kevin Wolf wrote: > > > Could we have an intermediate state that doesn't require any > > > duplication and thus have no separate code paths that could > > > diverge? > > > >

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Kevin Wolf
Am 02.12.2020 um 17:05 hat Eduardo Habkost geschrieben: > > > Looks nice as end goal. Then, these are a few questions I would > > > have about the transition plan: > > > > > > Would it require changing both device implementation and device > > > users in lockstep? Should we have a compatibility

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Kevin Wolf
Am 02.12.2020 um 14:54 hat Eduardo Habkost geschrieben: > On Wed, Dec 02, 2020 at 02:26:44PM +0100, Paolo Bonzini wrote: > > On 02/12/20 13:51, Eduardo Habkost wrote: > > > > > I'm liking the direction this is taking. However, I would still > > > > > like to have a clearer and feasible plan that w

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Kevin Wolf
Am 02.12.2020 um 10:30 hat Paolo Bonzini geschrieben: > On 01/12/20 23:08, Eduardo Habkost wrote: > > > Properties are only a useful concept if they have a use. If > > > -object/object_add/object-add can do the same job without properties, > > > properties are not needed anymore. > > > > Do you m

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Kevin Wolf
Am 01.12.2020 um 22:23 hat Paolo Bonzini geschrieben: > On 01/12/20 20:35, Kevin Wolf wrote: > > Am 01.12.2020 um 18:16 hat Paolo Bonzini geschrieben: > > I don't think this is actually a new things. We already have types and > > commands declared with things like &

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-01 Thread Kevin Wolf
Am 01.12.2020 um 18:16 hat Paolo Bonzini geschrieben: > On 01/12/20 17:20, Kevin Wolf wrote: > > Am 30.11.2020 um 20:35 hat Paolo Bonzini geschrieben: > > > For devices it's just the practical issue that there are too many to have > > > something like this series.

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-01 Thread Kevin Wolf
Am 30.11.2020 um 20:35 hat Paolo Bonzini geschrieben: > On 30/11/20 19:10, Kevin Wolf wrote: > > Am 30.11.2020 um 17:57 hat Paolo Bonzini geschrieben: > > > The main problem is that it wouldn't extend well, if at all, to > > > machines and devices. So those would

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-11-30 Thread Kevin Wolf
Am 30.11.2020 um 17:57 hat Paolo Bonzini geschrieben: > On 30/11/20 16:46, Kevin Wolf wrote: > > Am 30.11.2020 um 15:58 hat Paolo Bonzini geschrieben: > > > With this series it's basically pointless to have QOM properties at > > > all. > > > > Not ent

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-11-30 Thread Kevin Wolf
Am 30.11.2020 um 16:30 hat Daniel P. Berrangé geschrieben: > On Mon, Nov 30, 2020 at 03:58:23PM +0100, Paolo Bonzini wrote: > > On 30/11/20 13:25, Kevin Wolf wrote: > > > This series adds a QAPI type for the properties of all user creatable > > > QOM types and finally m

Re: [PATCH 01/18] qapi/qom: Add ObjectOptions for iothread

2020-11-30 Thread Kevin Wolf
Am 30.11.2020 um 16:00 hat Paolo Bonzini geschrieben: > On 30/11/20 13:25, Kevin Wolf wrote: > > +## > > +# @IothreadProperties: > > +# > > +# Properties for iothread objects. > > +# > > +# @poll-max-ns: the maximum number of nanoseconds to busy wait f

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-11-30 Thread Kevin Wolf
Am 30.11.2020 um 15:58 hat Paolo Bonzini geschrieben: > On 30/11/20 13:25, Kevin Wolf wrote: > > This series adds a QAPI type for the properties of all user creatable > > QOM types and finally makes QMP object-add use the new ObjectOptions > > union so that QAPI introspection

[PATCH 18/18] qapi/qom: QAPIfy object-add

2020-11-30 Thread Kevin Wolf
e could be generated from the schema. Signed-off-by: Kevin Wolf --- qapi/qom.json | 11 +-- include/qom/object_interfaces.h | 7 --- hw/block/xen-block.c| 16 monitor/misc.c | 2 -- qom/qom-qmp-cmds.c

[PATCH 17/18] qapi/qom: Drop deprecated 'props' from object-add

2020-11-30 Thread Kevin Wolf
The option has been deprecated in QEMU 5.0, remove it. Signed-off-by: Kevin Wolf --- qapi/qom.json | 6 +- docs/system/deprecated.rst | 10 +- qom/qom-qmp-cmds.c | 21 - 3 files changed, 6 insertions(+), 31 deletions(-) diff --git a/qapi

[PATCH 16/18] tests: Drop 'props' from object-add calls

2020-11-30 Thread Kevin Wolf
The 'props' option has been deprecated in 5.0 in favour of a flattened object-add command. Time to change our test cases to drop the deprecated option. Signed-off-by: Kevin Wolf --- tests/qtest/qmp-cmd-test.c | 16 +-- tests/qtest/test-netfil

[PATCH 15/18] qapi/qom: Add ObjectOptions for input-*

2020-11-30 Thread Kevin Wolf
This adds a QAPI schema for the properties of the input-* objects. ui.json cannot be included in qom.json because the storage daemon can't use it, so move GrabToggleKeys to common.json. Signed-off-by: Kevin Wolf --- qapi/common.json | 12 ++ qapi/qom.json

[PATCH 14/18] qapi/qom: Add ObjectOptions for sev-guest

2020-11-30 Thread Kevin Wolf
This adds a QAPI schema for the properties of the sev-guest object. Signed-off-by: Kevin Wolf --- qapi/qom.json | 35 +++ 1 file changed, 35 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index 24bfa83af5..43d081cb42 100644 --- a/qapi/qom.json +++ b

[PATCH 13/18] qapi/qom: Add ObjectOptions for pr-manager-helper

2020-11-30 Thread Kevin Wolf
This adds a QAPI schema for the properties of the pr-manager-helper object. Signed-off-by: Kevin Wolf --- qapi/qom.json | 14 ++ 1 file changed, 14 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index c8ee02081c..24bfa83af5 100644 --- a/qapi/qom.json +++ b/qapi/qom.json

[PATCH 12/18] qapi/qom: Add ObjectOptions for filter-*

2020-11-30 Thread Kevin Wolf
x27;t have it. NetFilterDirection is still required in the new object property definitions in qom.json, so move this enum to common.json. Signed-off-by: Kevin Wolf --- qapi/common.json | 20 +++ qapi/net.json| 20 --- qapi/qom.json| 143

[PATCH 11/18] qapi/qom: Add ObjectOptions for colo-compare

2020-11-30 Thread Kevin Wolf
This adds a QAPI schema for the properties of the colo-compare object. Signed-off-by: Kevin Wolf --- qapi/qom.json | 49 + 1 file changed, 49 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index ff9e51ee19..4c4f2841c3 100644 --- a/qapi

[PATCH 10/18] qapi/qom: Add ObjectOptions for can-*

2020-11-30 Thread Kevin Wolf
This adds a QAPI schema for the properties of the can-* objects. can-bus doesn't have any properties, so it only needs to be added to the ObjectType enum without adding a new branch to ObjectOptions. Signed-off-by: Kevin Wolf --- qapi/qom.json | 18 ++ 1 file change

[PATCH 09/18] qapi/qom: Add ObjectOptions for tls-*, deprecate 'loaded'

2020-11-30 Thread Kevin Wolf
ently ignored. In other words, the 'loaded' property is useless. Mark it as deprecated in the schema from the start. Signed-off-by: Kevin Wolf --- qapi/crypto.json | 98 qapi/qom.json| 12 +- 2 files changed, 108 insertions(+),

[PATCH 08/18] qapi/qom: Add ObjectOptions for secret*, deprecate 'loaded'

2020-11-30 Thread Kevin Wolf
e silently ignored. In other words, the 'loaded' property is useless. Mark it as deprecated in the schema from the start. Signed-off-by: Kevin Wolf --- qapi/crypto.json | 61 ++ qapi/qom.json | 5 docs/system/deprecated.rst |

[PATCH 07/18] qapi/qom: Add ObjectOptions for throttle-group

2020-11-30 Thread Kevin Wolf
the QAPI schema will supports structs, though, so they will not be needed in the schema. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 12 qapi/qom.json| 7 +-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-

[PATCH 06/18] qapi/qom: Add ObjectOptions for rng-*, deprecate 'opened'

2020-11-30 Thread Kevin Wolf
ons will result in an error. After the property has once been set to true (i.e. when the object construction has completed), it can never be reset to false. In other words, the 'opened' property is useless. Mark it as deprecated in the schema from the start. Signed-off-by: Ke

[PATCH 05/18] qapi/qom: Add ObjectOptions for memory-backend-*

2020-11-30 Thread Kevin Wolf
d-off-by: Kevin Wolf --- qapi/common.json | 20 + qapi/machine.json | 22 +- qapi/qom.json | 106 +- 3 files changed, 126 insertions(+), 22 deletions(-) diff --git a/qapi/common.json b/qapi/common.json index 716712d4b3..2dad4fadc3 1

[PATCH 04/18] qapi/qom: Add ObjectOptions for dbus-vmstate

2020-11-30 Thread Kevin Wolf
This adds a QAPI schema for the properties of the dbus-vmstate object. A list represented as a comma separated string is clearly not very QAPI-like, but for now just describe the existing interface. Signed-off-by: Kevin Wolf --- qapi/qom.json | 18 ++ 1 file changed, 18

[PATCH 03/18] qapi/qom: Add ObjectOptions for cryptodev-*

2020-11-30 Thread Kevin Wolf
existing interface in QAPI, leave these things in place. Signed-off-by: Kevin Wolf --- qapi/qom.json | 34 ++ 1 file changed, 34 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index 0ac4b1c9fb..7cbc0a3c54 100644 --- a/qapi/qom.json +++ b/qapi/qom.json

[PATCH 02/18] qapi/qom: Add ObjectOptions for authz-*

2020-11-30 Thread Kevin Wolf
This adds a QAPI schema for the properties of the authz-* objects. Signed-off-by: Kevin Wolf --- qapi/authz.json | 62 qapi/qom.json| 10 + storage-daemon/qapi/qapi-schema.json | 1 + 3 files changed, 73 insertions

[PATCH 01/18] qapi/qom: Add ObjectOptions for iothread

2020-11-30 Thread Kevin Wolf
Add an ObjectOptions union that will eventually describe the options of all user creatable object types. As unions can't exist without any branches, also add the first object type. This adds a QAPI schema for the properties of the iothread object. Signed-off-by: Kevin Wolf --- qapi/qom

[PATCH 00/18] qapi/qom: QAPIfy object-add

2020-11-30 Thread Kevin Wolf
rt deduplicating and integrating things better between QAPI and the QOM implementation, e.g. by generating parts of the QOM boilerplate from the QAPI schema. Kevin Wolf (18): qapi/qom: Add ObjectOptions for iothread qapi/qom: Add ObjectOptions for authz-* qapi/qom: Add ObjectOptions for cryptod

Re: [PATCH 5/6] qapi: Add support for aliases

2020-11-13 Thread Kevin Wolf
Am 12.11.2020 um 19:34 hat Eric Blake geschrieben: > On 11/12/20 11:28 AM, Kevin Wolf wrote: > > Introduce alias definitions for object types (structs and unions). This > > allows using the same QAPI type and visitor for many syntax variations > > that exist in the external

Re: [PATCH 1/2] char: Skip CLI aliases in query-chardev-backends

2020-11-12 Thread Kevin Wolf
Am 12.11.2020 um 09:22 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > The aliases "tty" and "parport" are only valid on the command line, QMP > > commands like chardev-add don't know them. query-chardev-backends should > > describe

[PATCH 1/2] char: Skip CLI aliases in query-chardev-backends

2020-11-11 Thread Kevin Wolf
The aliases "tty" and "parport" are only valid on the command line, QMP commands like chardev-add don't know them. query-chardev-backends should describe QMP and therefore not include them in the list of available backends. Signed-off-by: Kevin Wolf

[PATCH 0/2] char: Deprecate backend aliases

2020-11-11 Thread Kevin Wolf
later. In the deprecation documentation I assumed that this is for 6.0, but if we want to include it in 5.2 still, this can be changed, of course. Kevin Wolf (2): char: Skip CLI aliases in query-chardev-backends char: Deprecate backend aliases 'tty' and 'parport' d

[PATCH 2/2] char: Deprecate backend aliases 'tty' and 'parport'

2020-11-11 Thread Kevin Wolf
QAPI doesn't know the aliases 'tty' and 'parport' and there is no reason to prefer them to the real names of the backends 'serial' and 'parallel'. Signed-off-by: Kevin Wolf --- docs/system/deprecated.rst | 6 ++ chardev/char.c | 1

Re: [PATCH v3 0/2] block: deprecate the sheepdog driver

2020-10-15 Thread Kevin Wolf
Am 02.10.2020 um 13:32 hat Daniel P. Berrangé geschrieben: > 2 years back I proposed dropping the sheepdog mailing list from the > MAINTAINERS file, but somehow the patch never got picked up: > > https://lists.gnu.org/archive/html/qemu-block/2018-03/msg01048.html > > So here I am with the same

Re: [PATCH 17/18] qemu: caps: Enable QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI

2020-07-14 Thread Kevin Wolf
Am 10.07.2020 um 16:44 hat Peter Krempa geschrieben: > On Fri, Jul 10, 2020 at 16:33:38 +0200, Peter Krempa wrote: > > Enable it when regular QEMU_CAPS_BLOCKDEV is present. > > > > Signed-off-by: Peter Krempa > > --- > > src/qemu/qemu_capabilities.c | 3 ++ > > .../caps_4.2.0.a

Re: [PATCH v6 00/10] Tighten qemu-img rules on missing backing format

2020-07-07 Thread Kevin Wolf
Am 06.07.2020 um 22:39 hat Eric Blake geschrieben: > v5 was here: > https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg00679.html > In v6: > - add a few more patches > - change qcow semantics based on several iterations of mailing list > debates on what behavior is easiest to support > - add

Re: [PATCH v6 08/10] iotests: Specify explicit backing format where sensible

2020-07-07 Thread Kevin Wolf
Am 06.07.2020 um 22:39 hat Eric Blake geschrieben: > There are many existing qcow2 images that specify a backing file but > no format. This has been the source of CVEs in the past, but has > become more prominent of a problem now that libvirt has switched to > -blockdev. With older -drive, at lea

Re: [PATCH v5 3/7] qcow: Tolerate backing_fmt=, but warn on backing_fmt=raw

2020-06-23 Thread Kevin Wolf
Am 22.06.2020 um 23:58 hat Eric Blake geschrieben: > On 5/5/20 10:30 AM, Eric Blake wrote: > > On 5/5/20 2:35 AM, Kevin Wolf wrote: > > > Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > > > > qcow has no space in the metadata to store a backing format, and t

Re: [PATCH v5 7/7] qemu-img: Deprecate use of -b without -F

2020-05-05 Thread Kevin Wolf
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > Creating an image that requires format probing of the backing image is > inherently unsafe (we've had several CVEs over the years based on > probes leaking information to the guest on a subsequent boot, although > these days tools like libvirt ar

Re: [PATCH v5 4/7] qcow2: Deprecate use of qemu-img amend to change backing file

2020-05-05 Thread Kevin Wolf
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > The use of 'qemu-img amend' to change qcow2 backing files is not > tested very well. In particular, our implementation has a bug where > if a new backing file is provided without a format, then the prior > format is blindly reused, even if this

Re: [PATCH v5 3/7] qcow: Tolerate backing_fmt=, but warn on backing_fmt=raw

2020-05-05 Thread Kevin Wolf
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > qcow has no space in the metadata to store a backing format, and there > are existing qcow images backed both by raw or by other formats > (usually qcow) images, reliant on probing to tell the difference. > While we don't recommend the creation o

Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk

2020-03-09 Thread Kevin Wolf
Am 09.03.2020 um 16:44 hat Daniel P. Berrangé geschrieben: > We could support "-F ..." and validate any non-raw formats, while raising a > runtime error in the case of "-F raw", as only the "raw" backing format has > the probing security risk. > > Users who need to use qcow, with a backing file,

Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk

2020-03-09 Thread Kevin Wolf
Am 09.03.2020 um 16:32 hat Eric Blake geschrieben: > On 3/9/20 10:21 AM, Kevin Wolf wrote: > > Am 06.03.2020 um 23:51 hat Eric Blake geschrieben: > > > For qcow2 and qed, we want to encourage the use of -F always, as these > > > formats can suffer from data corruption o

Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk

2020-03-09 Thread Kevin Wolf
Am 06.03.2020 um 23:51 hat Eric Blake geschrieben: > For qcow2 and qed, we want to encourage the use of -F always, as these > formats can suffer from data corruption or security holes if backing > format is probed. But for other formats, the backing format cannot be > recorded. Making the user de

Re: [libvirt] [PULL 01/19] util/hbitmap: strict hbitmap_reset

2019-10-15 Thread Kevin Wolf
Am 14.10.2019 um 20:10 hat John Snow geschrieben: > > > On 10/11/19 7:18 PM, John Snow wrote: > > > > > > On 10/11/19 5:48 PM, Eric Blake wrote: > >> On 10/11/19 4:25 PM, John Snow wrote: > >>> From: Vladimir Sementsov-Ogievskiy > >>> > >>> hbitmap_reset has an unobvious property: it rounds re

Re: [libvirt] [PATCH 0/2] qemu: Enable -blockdev support (blockdev-add saga)

2019-09-16 Thread Kevin Wolf
Am 16.09.2019 um 11:32 hat Peter Krempa geschrieben: > (ccing Kevin) > > On Mon, Sep 16, 2019 at 10:14:44 +0100, Daniel Berrange wrote: > > On Fri, Sep 13, 2019 at 02:43:53PM +0200, Peter Krempa wrote: > > > To my knowledge, everything in libvirt is now prepared to fully use > > > -blockdev way to

Re: [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

2019-09-02 Thread Kevin Wolf
Am 23.08.2019 um 11:22 hat Vladimir Sementsov-Ogievskiy geschrieben: > 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: > > To get rid of implicit filters related workarounds in future let's > > deprecate them now. > > Interesting, could we deprecate implicit filter without deprecation of > u

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-09-02 Thread Kevin Wolf
Am 30.08.2019 um 20:11 hat John Snow geschrieben: > > > On 8/30/19 6:07 AM, Christophe de Dinechin wrote: > > Without having looked at the code much, I think I would > > > > 1. extend the existing QAPI error to support warnings, deprecations and > >info messages. The first problem I see is t

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-16 Thread Kevin Wolf
Am 15.08.2019 um 21:24 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 15.08.2019 um 18:07 hat John Snow geschrieben: > >> > >> > >> On 8/15/19 6:49 AM, Kevin Wolf wrote: > >> > Am 14.08.2019 um 21:27 hat John Snow gesc

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Kevin Wolf
Am 15.08.2019 um 18:07 hat John Snow geschrieben: > > > On 8/15/19 6:49 AM, Kevin Wolf wrote: > > Am 14.08.2019 um 21:27 hat John Snow geschrieben: > >> > >> > >> On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> To get rid o

<    1   2   3   4   >