Re: [libvirt] [Xen-devel] Question about hypervisor that are not tristate

2017-01-11 Thread Konrad Rzeszutek Wilk
On Wed, Jan 11, 2017 at 10:49:48AM -0700, Jim Fehlig wrote: > On 01/06/2017 05:31 PM, Jim Fehlig wrote: > > Adding xen-devel for a question below... > > > Happy new year! > > > > Nearly a year ago I reported an issue with the hypervisor feature on > > Xen > > [1] and am now seeing a similar

Re: [libvirt] [Xen-devel] Opinions on removing the old, legacy libvirt Xen driver

2016-11-18 Thread Konrad Rzeszutek Wilk
On Fri, Nov 18, 2016 at 02:25:18PM -0700, Jim Fehlig wrote: > Hi All, > > I briefly mentioned this at an evening event during the KVM Forum / Xen Dev > Summit, but the list is certainly a better place to discuss such a topic. > What do folks think about finally removing the old, legacy,

Re: [libvirt] [Xen-devel] [PATCH v3 2/8] libxl: implement virDomainMemorystats

2015-11-18 Thread Konrad Rzeszutek Wilk
On November 17, 2015 6:15:38 PM EST, Jim Fehlig wrote: >Joao Martins wrote: >> Introduce support for domainMemoryStats API call, which >> consequently enables the use of `virsh dommemstat` command to >> query for memory statistics of a domain. We support >> the following

Re: [libvirt] [Xen-devel] [PATCH 1/4] libxl: populate build_info vfb in separate function

2015-05-09 Thread Konrad Rzeszutek Wilk
On Fri, May 08, 2015 at 04:31:02PM -0600, Jim Fehlig wrote: For HVM domains, vfb info must be populated in the libxl_domain_build_info stuct. Currently this is done in the libxlMakeVfbList function, but IMO struct it would be cleaner to populate the build_info vfb in a separate

Re: [libvirt] [PATCH] libxl: Disallow save or migrate when host devices are assigned to a guest.

2015-04-15 Thread Konrad Rzeszutek Wilk
On Tue, Apr 14, 2015 at 08:15:52PM -0600, Jim Fehlig wrote: Konrad Rzeszutek Wilk wrote: It is unhealthy. If the device is not doing any DMA operations it would work - but if you are saving and there are DMA operations happening the chance of corruption (outstanding DMAs) increase

[libvirt] libvirtd live-locking on CTX_LOCK when doing 'virsh domid save /tmp/blah' with guest corrupting memory (on purpose).

2015-04-08 Thread Konrad Rzeszutek Wilk
Hey Jim, Andrew, and Ian, This is libvirt v1.2.14 + three patches: c82a59b libxl: drop virDomainObj lock when destroying a domain a1c9d30 libxl: acquire a job when destroying a domain 5bd5406 libxl: Move job acquisition in libxlDomainStart to callers For fun I've set up an guest with PCI

[libvirt] [PATCH] libxl: Disallow save or migrate when host devices are assigned to a guest.

2015-04-08 Thread Konrad Rzeszutek Wilk
It is unhealthy. If the device is not doing any DMA operations it would work - but if you are saving and there are DMA operations happening the chance of corruption (outstanding DMAs) increase. As such re-use the check migration used. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

Re: [libvirt] [Xen-devel] [PATCH V3 0/3] libxl: domain destroy fixes

2015-04-08 Thread Konrad Rzeszutek Wilk
is changed a bit to provide a wrapper for unlocking, destroying, and locking the domain. Existing libxl_domain_destroy callers are changed to use the wrapper. Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com Tested-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com Jim Fehlig (3

Re: [libvirt] [Xen-devel] [PATCH 0/3] libxl: domain destroy fixes

2015-03-27 Thread Konrad Rzeszutek Wilk
used the job now) from the driver to make sure that there are no chained calls (one function calling another which also uses a mutex or job locking). I only found one culprit (libxlDomainAutoCoreDump being called from libxlDomainShutdownThread). Reviewed-by: Konrad Rzeszutek Wilk konrad.w

[libvirt] [PATCH] libxl: Fix memory leak if pthread_create fails.

2015-03-25 Thread Konrad Rzeszutek Wilk
If we fail to create the thread we leak the shutdown_info structure. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- src/libxl/libxl_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 774b070

Re: [libvirt] [Xen-devel] [PATCH 2/3] libxl: acquire a job when destroying a domain

2015-03-25 Thread Konrad Rzeszutek Wilk
? and then give up? Perhaps this patch should be folded in? From 9f2bac0c28815fc51850290c4b1962881691bfca Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk konrad.w...@oracle.com Date: Wed, 25 Mar 2015 22:34:51 -0400 Subject: [PATCH] squash --- src/libxl/libxl_domain.c | 4 1 file changed, 4

Re: [libvirt] [PATCH v2] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-16 Thread Konrad Rzeszutek Wilk
On Fri, May 16, 2014 at 10:48:00AM -0400, Konrad Rzeszutek Wilk wrote: On Fri, May 9, 2014 at 12:50 PM, Alex Williamson alex.william...@redhat.com wrote: The driver_override field allows us to specify the driver for a device ... ... Signed-off-by: Alex Williamson alex.william

Re: [libvirt] [PATCH v2] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-16 Thread Konrad Rzeszutek Wilk
-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-25 Thread Konrad Rzeszutek Wilk
On Fri, Apr 25, 2014 at 11:24:07AM -0600, Jim Fehlig wrote: Jim Fehlig wrote: Ian Campbell wrote: Currently the driver only exposes the ability to connect to the serial console of a Xen guest, which doesn't work for a PV guest. Since for an HVM guest the serial devices are

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-25 Thread Konrad Rzeszutek Wilk
On Fri, Apr 25, 2014 at 07:52:55PM +0100, Ian Campbell wrote: On Fri, 2014-04-25 at 13:32 -0400, Konrad Rzeszutek Wilk wrote: The development version of Xen is 4.5. The latest stable is Xen 4.4. If you want to backport it - then your suggestion is correct. Or just backport the relevant

Re: [libvirt] [Xen-devel] [PATCH] libxl: Correctly initialize vcpu bitmap

2013-07-22 Thread Konrad Rzeszutek Wilk
Bader stefan.ba...@canonical.com The libxl calling logic looks Ok to me. So from the libxl perspective you can tack on Reviewed-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- src/libxl/libxl_conf.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src

Re: [libvirt] libxl: calculating free pages in libvirt

2013-06-11 Thread Konrad Rzeszutek Wilk
On Thu, Jun 06, 2013 at 03:53:13PM +0200, Dario Faggioli wrote: Hi Jim, As I told you in Dublin, I'm looking into libvirt a bit, with the main purpose of implementing the NUMA interface for the libxl driver. While at it I noticed that libxlNodeGetFreeMemory() uses the value contained in