vantage of vfio-assigned "real hardware"
networking, but it can still be migrated with the only downside being
a performance penalty (due to using an emulated NIC) during the
migration.
Signed-off-by: Laine Stump
---
src/qemu/qemu_command.c | 9 +
src/qemu/q
.
Signed-off-by: Laine Stump
---
docs/schemas/domaincommon.rng | 19 ++
src/conf/domain_conf.c| 45 +
src/conf/domain_conf.h| 14
.../net-virtio-teaming-network.xml| 37 +++
tests
and the QEMU backend implementation using virtio failover.
Signed-off-by: Laine Stump
---
docs/formatdomain.html.in | 100 ++
docs/news.xml | 28 +++
2 files changed, 128 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs
e
hostdevs is manually unplugged, meaning that libvirt keeps the device marked as
"in-use", and it therefore cannot be re-plugged to the guest until
after a complete guest "power cycle". AFAIK there isn't yet a fix for
that bug, so don't expect manual unplug of the device to work.
L
, or recognition of a new event somewhere?)
Signed-off-by: Laine Stump
---
src/qemu/qemu_migration.c| 1 +
src/qemu/qemu_monitor.c | 1 +
src/qemu/qemu_monitor.h | 1 +
src/qemu/qemu_monitor_json.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu
empt doing the failover during migration.
This patch just adds the qemu capabilities flag "virtio-net.failover".
Signed-off-by: Laine Stump
---
No change from V1.
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3 +++
tes
On 1/21/20 10:26 AM, Daniel P. Berrangé wrote:
On Sun, Jan 19, 2020 at 10:24:13PM -0500, Laine Stump wrote:
This attribute is only used for virtio-net devices, so it is stored in
the virtio part of the anonymous union in virDomainNetDef::driver. An
I'm not convinced that storing it only
I forgot to mention in the cover letter - there is a bug in the QEMU
4.2.0 release that causes the qemu process to crash whenever the vfio
device is unplugged, and for some reason when booting a Fedora 31 guest
with a failover pair, the guest kernel attempts to unplug the vfio
device during
be used unknowingly - the
behavior it triggers would only occur if it was explicitly called out
in the config.
Signed-off-by: Laine Stump
---
docs/formatdomain.html.in | 6 -
docs/schemas/domaincommon.rng | 5
src/conf/domain_conf.c| 41 --
modifies
qemuMigrationSrcIsAllowedHostdev() to allow domains with those devices
to be migrated.
Signed-off-by: Laine Stump
---
src/qemu/qemu_migration.c | 48 +++
1 file changed, 44 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu
:
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c| 11
src/conf/domain_conf.h| 1 +
src/qemu/qemu_domain.c| 15 +++---
.../net-virtio-failover-network.xml | 37 ++
.../net
The information in formatdomain.html seems too detailed, but it also
didn't seem right to put that information in a wiki page before the
patches are even pushed...
Signed-off-by: Laine Stump
---
docs/formatdomain.html.in | 70 +++
docs/news.xml
empt doing the failover during migration.
This patch just adds the qemu capabilities flag "virtio-net.failover".
Signed-off-by: Laine Stump
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemuca
though - do
we need to add an extra state, or recognition of a new event somewhere?)
Signed-off-by: Laine Stump
---
src/qemu/qemu_migration.c| 1 +
src/qemu/qemu_monitor.c | 1 +
src/qemu/qemu_monitor.h | 1 +
src/qemu/qemu_monitor_json.c | 1 +
4 files changed, 4 insertions(+)
diff
added when an upcoming
patch adds an attribute to that will be present/parsed
regardless of whether or not the device model is "virtio".
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 443 +
src/conf/domain_conf.h | 52 ++---
2 files cha
Adding Driver to the names makes them better fit their purpose.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 69e3b7be9a..58f4a1c14b 100644
--- a/src
All three of these functions could only return 0 anyway, so just get
rid of all the extra red tape.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
arrive at a working config, which is
something that has always been the case before now). I'll leave it up to the
jury to decide whether or not it's acceptable :-)
Laine Stump (12):
conf: refactor hostdev driver subelement format for simpler additions
conf: change virDomainVirtioNet*Format() t
we check for the qemu capability before adding
it.
Signed-off-by: Laine Stump
---
docs/schemas/domaincommon.rng | 5 ++
src/conf/domain_conf.c| 15 ++
src/conf/domain_conf.h| 1 +
src/qemu/qemu_command.c
attribute; this will be useful
when we add a second attribute).
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 2a8a04cacb..0208d330c3 100644
---
te these two devices, and will
automatically unplug the hostdev at the start of any migration, and
re-plug a new device on the destination when migration is complete (it
is up to the guest virtio driver to handle bonding the two devices).
Signed-off-by: Laine Stump
---
docs/schemas/domaincommon.rng
On 1/8/20 11:31 AM, Michal Privoznik wrote:
There is no need to require users to produce iSCSI disk source
following our ordering of children elements. In fact, we don't
even accept our own order in the schema :(.
Signed-off-by: Michal Privoznik
Reviewed-by: Laine Stump
--
libvir-list
On 1/2/20 12:46 PM, Ryan Moeller wrote:
From: Ryan Moeller
Don't free the file string until after it has been used to print the
error message.
Simplify PCI bus parsing to eliminate an unannotated switch fallthrough.
I don't think this^^^ comment belongs with this patch...
On 12/17/19 1:45 PM, Michal Prívozník wrote:
On 12/17/19 6:04 PM, Laine Stump wrote:
...
+static void
+qemuDomainAttachDeviceLiveAndConfigHomogenize(const virDomainDeviceDef
*devConf,
+ virDomainDeviceDefPtr devLive)
+{
+/*
+ * fixup
effective NOP (as the macs already match)).
Any downstream libvirt containing upstream commit
55ce6564634 should have this patch as well.
https://bugzilla.redhat.com/1783411
Signed-off-by: Laine Stump
---
src/qemu/qemu_driver.c | 35 +++
1 file changed, 35 insertions(+)
dif
On 12/16/19 6:03 PM, Daniel Henrique Barboza wrote:
On 12/16/19 7:28 PM, Cole Robinson wrote:
On 12/16/19 8:36 AM, Daniel Henrique Barboza wrote:
changes from version 3 [1]:
- removed last 2 patches that made function 0 of
PCI multifunction devices mandatory
- new patch: news.xml update
-
F30
goes EOL we'll just drop i686 testing completely?)
Reviewed-by: Laine Stump
---
conf/default.cfg | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/conf/default.cfg b/conf/default.cfg
index 39d9b04..3493ad7 100644
--- a/conf/default.cfg
+++ b/conf/default.cfg
On 12/3/19 12:30 PM, Daniel P. Berrangé wrote:
The hard dependancy between the virt drivers and the network
or storage drivers was removed quite a while back now, so
the tests no longer need to link to these drivers.
Signed-off-by: Daniel P. Berrangé
---
Reviewed-by: Laine Stump
On 11/28/19 8:16 AM, Richard W.M. Jones wrote:
On Thu, Nov 28, 2019 at 01:04:00PM +, Daniel P. Berrangé wrote:
We have an RFE from libguestfs to provide a way to run as root
*with* capabilities. I looked integrating this into the DAC security
manager as a new flag in the security label, but
On 11/14/19 5:20 PM, Cole Robinson wrote:
On 10/22/19 9:24 PM, Laine Stump wrote:
+int
+virDomainNetDefRuntimeValidate(const virDomainNetDef *net G_GNUC_UNUSED)
+{
+/* Unlike virDomainNetDefValidate(), which is a static function
+ * called internally to this file
make rpm is now broken. I'm making a rash assumption something in this
series is the cause (if I have time in the morning I'll investigate further)
+ /usr/bin/mkdir -p
/home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
+ cp -pr AUTHORS
On 11/8/19 2:00 AM, Han Han wrote:
Signed-off-by: Han Han
---
docs/news.xml | 12
1 file changed, 12 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 88affb66a3..c0fd006a77 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -189,6 +189,18 @@
+
ping.
On 10/22/19 9:24 PM, Laine Stump wrote:
As usual, the first 6 patches are just torquing stuff around to make
the last patch simple (except that patch 1 makes interface validation
errors more useful). 2-5 are just converting a bunch of accessor
functions to tak/return const pointers, since
ping.
On 10/17/19 9:59 PM, Laine Stump wrote:
From: Laine Stump
I just sent a single patch for this, then realized there was a small
prerequisite patch also needed. So 1/2 is the prerequisite patch, and 2/2 is
identical to the single patch I sent previously.
Laine Stump (2):
util: allow
On 11/4/19 7:10 AM, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
Reviewed-by: Laine Stump
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
elevant to packagers, such as the
switch to Meson.
Signed-off-by: Andrea Bolognani
Reviewed-by: Laine Stump
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 10/24/19 10:31 AM, Peter Krempa wrote:
On Thu, Oct 24, 2019 at 16:22:09 +0200, Pavel Hrdina wrote:
On Thu, Oct 24, 2019 at 04:12:00PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/internal.h | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
it.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 4 ++--
src/conf/domain_conf.h | 4 ++--
src/conf/netdev_bandwidth_conf.c | 2 +-
src/conf/netdev_bandwidth_conf.h | 2 +-
src/libxl/libxl_conf.c | 2 +-
src/lxc/lxc_driver.c | 2 +-
src/lxc
wanted to use them.
This does actually fix a documented bug:
https://bugzilla.redhat.com/1741121
(that one is about vlan tag validation. There may also be one about
bandwidth, but I didn't see it right away, so I gave up, as is my
custom).
Laine Stump (7):
qemu: add mac address to error
These all just return a scalar value, so there's no daisy-chained
fallout from changing them, and they can easily be combined in a
single patch.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 10 +-
src/conf/domain_conf.h | 10 +-
2 files changed, 10 insertions(+), 10
that
must be changed to "const virNetDevVlan *".
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 6 +++---
src/conf/domain_conf.h | 2 +-
src/libxl/libxl_conf.c | 2 +-
src/libxl/xen_common.c | 2 +-
src/util/virhostdev.c | 2 +-
This also isn't required (due to the vportprofile being stored in the
NetDef as a pointer rather than being directly contained), but it
seemed dishonest to not mark it as const (and thus permit users to
modify its contents)
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c
://bugzilla.redhat.com/1741121
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 36 +++-
src/network/bridge_driver.c | 37 -
2 files changed, 35 insertions(+), 38 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
This makes it easier to understand which interface's config caused the
error.
Signed-off-by: Laine Stump
---
src/qemu/qemu_domain.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 3e8da13794
as though, of course.)
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 22 ++
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
src/libxl/libxl_domain.c | 4
src/libxl/libxl_driver.c | 4
src/lxc/lxc_driver.c | 4
src/lxc/l
ping. this was reported as a problem in Fedora 31 beta...
On 10/17/19 9:59 PM, Laine Stump wrote:
From: Laine Stump
I just sent a single patch for this, then realized there was a small
prerequisite patch also needed. So 1/2 is the prerequisite patch, and 2/2 is
identical to the single patch
On 10/21/19 9:02 AM, Andrea Bolognani wrote:
On Sat, 2019-10-19 at 02:18 -0400, Laine Stump wrote:
Commit 01ca4010d86 (libvirt v5.1.0) moved address reservation for
hotplugged interface devices up to an earlier point in
qemuDomainAttachNetDevice() because some function called when
hotplugging
Signed-off-by: Laine Stump
---
src/qemu/qemu_hotplug.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 55696ebe9a..80ddee6587 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
Sorry - disregard this patch by itself. There is a small prerequisite
patch that is needed along with it. I've resent this patch in a 2 patch
series that includes both.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: Laine Stump
I just sent a single patch for this, then realized there was a small
prerequisite patch also needed. So 1/2 is the prerequisite patch, and 2/2 is
identical to the single patch I sent previously.
Laine Stump (2):
util: allow sending mac addr to virNetNewLink without ifindex
From: Laine Stump
Although until now, any use of the extra_args argument (a pointer to a
struct containing extra attributes to add the the RTM_NEWLINK message)
would always have the ifindex and mac set, so the code could assume it
was safe to add both to the message if extra_args != NULL
From: Laine Stump
Remember when the MAC address of libvirt-created bridges weren't
stable, and changed as guests were started and stopped? Pepperidge
Farms remembers.
(No, I would never actually push a comment like that! Just wanted to
get your attention).
When libvirt first implemented
Remember when the MAC address of libvirt-created bridges weren't
stable, and changed as guests were started and stopped? Pepperidge
Farms remembers.
(No, I would never actually push a comment like that! Just wanted to
get your attention).
When libvirt first implemented a stable and configurable
XML.
Since the only way a current libvirt would ever encounter this element
would be if someone was upgrading directly from libvirt <=v0.7.5 with
running guests, it seems safe to finally remove the code that parses it.
Signed-off-by: Laine Stump
---
The git commit ID's etc are probably not essentia
On 9/30/19 1:35 PM, Andrea Bolognani wrote:
On Mon, 2019-09-30 at 13:13 -0400, Laine Stump wrote:
On 9/30/19 10:05 AM, Andrea Bolognani wrote:
I see your point about backports being more painful when you have
a bunch of unrelated changes mixed in, but I would still prefer if
we converted
On 9/30/19 10:05 AM, Andrea Bolognani wrote:
On Mon, 2019-09-30 at 13:41 +0100, Daniel P. Berrangé wrote:
On Mon, Sep 30, 2019 at 02:18:17PM +0200, Andrea Bolognani wrote:
On Mon, 2019-09-30 at 13:56 +0200, Pavel Hrdina wrote:
Agreed, for now let's keep all the wrappers but eventually we can
On 9/26/19 11:51 AM, Laine Stump wrote:
On 9/26/19 3:28 AM, Michal Privoznik wrote:
On 9/25/19 6:57 PM, Laine Stump wrote:
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 0753904472..5f63c4f51e 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -8786,8
On 9/26/19 3:28 AM, Michal Privoznik wrote:
On 9/25/19 6:57 PM, Laine Stump wrote:
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 0753904472..5f63c4f51e 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -8786,8 +8786,10 @@ qemuDomainUpdateDeviceConfig
On 9/26/19 2:52 AM, Michal Privoznik wrote:
On 9/23/19 3:08 AM, Laine Stump wrote:
Since the VIR_DEFINE_AUTOPTR_FUNC() was added for
virNetworkPortDefPtr, I decided to convert all uses of
virNetworkPortDefPtr that were appropriate to use VIR_AUTOPTR. This
could be
squashed into patch 1/2
ping
On 9/21/19 7:59 PM, Laine Stump wrote:
Patch 2/2 is the actual fix. 1/2 is just to make the fix simpler.
NB: these two patches should also be included with the other patches for
https://bugzilla.redhat.com/1745815
Laine Stump (2):
conf: take advantage of VIR_AUTO
-by: Laine Stump
---
(I actually think that it was a bad idea to have this "reach over"
pointer in the hostdevs array (I can say that, since it was my idea
:-), and want to eliminate it in favor of using an iterator function
for all operations that need to do something to all hostdevs, bu
On 9/24/19 2:59 AM, Erik Skultety wrote:
Fedora 28 is already EOL and the URLs don't work anymore either because
EOL resources eventually move to
http://archives.fedoraproject.org/pub/archive/fedora/ from
https://dl.fedoraproject.org/pub/fedora/linux/releases/.
Hah! I made this same patch
On Tue, Sep 24, 2019, 6:02 AM Andrea Bolognani wrote:
> On Tue, 2019-09-24 at 08:27 +0200, Erik Skultety wrote:
> > On Mon, Sep 23, 2019 at 04:47:06PM -0400, Laine Stump wrote:
> > > On 9/23/19 1:27 PM, Erik Skultety wrote:
> > > > The nwfilter 220-no-ip-sp
On Tue, Sep 24, 2019, 2:25 AM Erik Skultety wrote:
> On Mon, Sep 23, 2019 at 04:47:06PM -0400, Laine Stump wrote:
> > On 9/23/19 1:27 PM, Erik Skultety wrote:
> >
> > From my POV, if you apply the diff at the end of this message, then:
> >
> >
> > Review
test to explicitly add an element, but I think we still
should put it in conditionally, in case someone needs to *not* have it
(e.g., there are xen tests run with libvirt-tck, and they might not like
it if the domain had an element; I can't say that for sure,
because I'm not setup to test Xen
to compress it anymore.
Signed-off-by: Daniel P. Berrangé
(I've never liked ChangeLog files anyway...)
Reviewed-by: Laine Stump
---
libvirt.spec.in | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index e2f2a40238..c7448ed6a6 100644
Since the VIR_DEFINE_AUTOPTR_FUNC() was added for
virNetworkPortDefPtr, I decided to convert all uses of
virNetworkPortDefPtr that were appropriate to use VIR_AUTOPTR. This could be
squashed into patch 1/2, or left separate, or just completely dropped.
Signed-off-by: Laine Stump
---
src/conf
rtid for these cases, it makes for less churn in portids (and thus
may make troubleshooting simpler) if we make the small fix to
virDomainNetDefActualToNetworkPort() that preserves existing valid
portids rather than unconditionally generating a new one.)
Signed-off-by: Laine Stump
---
src/con
Before adding new code to this function that will be made easier by
using auto-cleaning pointers, update it to use auto-cleaning pointers
(and the more modern virErrorPreserveLast()).
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 53 ++--
src/conf
Patch 2/2 is the actual fix. 1/2 is just to make the fix simpler.
NB: these two patches should also be included with the other patches for
https://bugzilla.redhat.com/1745815
Laine Stump (2):
conf: take advantage of VIR_AUTO* in virDomainNetCreatePort()
conf: refresh network ports missing
needs to check for type='network' as well.
(at the time we thought that type='network' and type='bridge' could be
conflated for interface actual type, but this turned out to be too
problematic to do).
Signed-off-by: Laine Stump
---
(NB: I thought I remembered seeing a bugzilla report go by about
On 9/16/19 3:44 PM, Laine Stump wrote:
I vote for putting a check in virDomainNetDefValidate() that errors
out if it finds target dev present but empty. There may be some who
would say "it's existing behavior and has been like this for a long
time, so we have to preserve it",
On 9/16/19 10:44 AM, Nikolay Shirokovskiy wrote:
Hi, all
I recently discovered that input is allowed[*]
So you're saying this previously failed? Catastrophically (SEGV)? Or did
it log an error and refuse to start the domain?
by qemu driver's defineXML for element. On start it will
On 9/13/19 4:02 PM, Michal Prívozník wrote:
On 9/13/19 4:52 PM, Laine Stump wrote:
+qemuCaps && !virQEMUCapsGet(qemuCaps,
QEMU_CAPS_VHOSTUSER_MULTIQUEUE)) {
NULL is never passed to qemuCaps, so no need to check it.
I had put that in so I could also call
On 9/13/19 4:02 PM, Michal Prívozník wrote:
On 9/13/19 4:52 PM, Laine Stump wrote:
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -5300,6 +5300,86 @@ qemuDomainWatchdogDefValidate(const virDomainWatchdogDef
*dev,
}
+
3 empty lines instead of 2.
:-O
+int
On 9/13/19 4:02 PM, Michal Prívozník wrote:
On 9/13/19 4:52 PM, Laine Stump wrote:
There is some validation of NetDefs () that can't be done
until runtime, due to not knowing the exact configuration until that
time. This needs to happen in 3 places: 1) in the qemu commandline
when a new guest
On 9/13/19 12:38 PM, Daniel P. Berrangé wrote:
On Fri, Sep 13, 2019 at 12:10:34PM -0400, Laine Stump wrote:
On 9/13/19 10:59 AM, Daniel P. Berrangé wrote:
Since the introduction of the virNetworkPort object, the network driver
has a persistent record of ports that have been created against
. Berrangé
Unfortunately the wrong version of this patch was posted and
reviewed and thus it lacked the code to actually apply the
bandwidth settings to the bridge itself.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
--
libvir-list mailing list
libvir-list@redhat.com
https
On 9/13/19 12:05 PM, Daniel P. Berrangé wrote:
To aid in troubleshooting add some debug messages wrt
bandwidth settings and networks.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Laine Stump
(although it sounds like you already found the problem you were looking
for :-)
---
src
Reviewed-by: Laine Stump
(also tested for direct/bridge, direct/passthrough, hostdev, and normal
tap-based virtual networks)
There is one issue with this though - it only re-adds connections that
were in the port list, while previously (before introduction of
virNetworkPortDef) we had
-off-by: Laine Stump
---
src/qemu/qemu_command.c | 52 +--
src/qemu/qemu_domain.c | 80 +
src/qemu/qemu_domain.h | 4 +++
3 files changed, 85 insertions(+), 51 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu
to
https://bugzilla.redhat.com/1502754
Signed-off-by: Laine Stump
---
src/qemu/qemu_hotplug.c | 32
1 file changed, 8 insertions(+), 24 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index bd8868b0f7..0530bdd990 100644
--- a/src/qemu
that added the warning). This seems to me to be going a bit too
far - I think that (at least upstream) we should turn this into an
error, and let the regression testing of said management apps catch
the behavior change so they can fix their code. (insert
Kermit-drinking-coffee meme here)
Laine Stump
It needs to be used by a function that only has a const pointer to
virDomainNetDef.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
On 9/6/19 11:46 AM, Daniel P. Berrangé wrote:
On Fri, Sep 06, 2019 at 11:37:12AM -0400, Laine Stump wrote:
On 9/6/19 5:16 AM, Daniel P. Berrangé wrote:
On Tue, Aug 27, 2019 at 09:46:38PM -0400, Laine Stump wrote:
libvirt creates its tap devices without the IFF_PERSIST flag, so
On 9/6/19 5:16 AM, Daniel P. Berrangé wrote:
On Tue, Aug 27, 2019 at 09:46:38PM -0400, Laine Stump wrote:
libvirt creates its tap devices without the IFF_PERSIST flag, so they
will be automatically deleted when qemu is finished with them. In the
case of tap devices created outside of libvirt
On 9/5/19 1:57 PM, Andrea Bolognani wrote:
How about we add a paragraph at the end of the section that says
something along the lines of
Both the lists above are subject to change: code written in a new
programming language might be accepted if it's generally agreed
that the advantages
On 9/5/19 10:51 AM, Andrea Bolognani wrote:
On Thu, 2019-09-05 at 15:42 +0100, Daniel P. Berrangé wrote:
On Thu, Sep 05, 2019 at 04:22:17PM +0200, Andrea Bolognani wrote:
On Thu, 2019-09-05 at 12:42 +0100, Daniel P. Berrangé wrote:
+ The libvirt repository makes use of a large number of
hat's used as a gazinta/gazouta
for packets).
On 8/27/19 9:46 PM, Laine Stump wrote:
This resolves https://bugzilla.redhat.com/1723367
It has become more popular to run libvirtd in an unprivileged
environment (e.g. inside a container), but until now the only possible
types of network connection
On 9/3/19 11:12 AM, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé
---
docs/news.xml | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
Reviewed-by: Laine Stump
(but unfortunately too late to be in the release tarball :-/)
--
libvir-list
L dump to
stdout.")
+ .data = N_("Delete the specified network port.")
},
{.name = NULL}
};
Reviewed-by: Laine Stump
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
() is the correct function to call in the
case of an existing device, because the same ioctl() that creates a
new tap device will also open an existing tap device.
Resolves: https://bugzilla.redhat.com/1723367 (partially)
Signed-off-by: Laine Stump
---
src/qemu/qemu_interface.c | 77
on platforms that have
VIR_NETDEV_TAP_REQUIRE_MANUAL_CLEANUP #defined (which is only
FreeBSD).
This mistake has been corrected, along with the unnecessary check for
non-null net->ifname (it must always be non-null), and erroneous
VIR_FREE of net->ifname.
Signed-off-by: Laine Stump
---
sr
hen it automatically
creates the tap devices.)
Signed-off-by: Laine Stump
---
docs/formatdomain.html.in | 48 +
docs/schemas/domaincommon.rng | 5 ++
src/conf/domain_conf.c| 51 +++
sr
='no'.
Resolves: https://bugzilla.redhat.com/1723367 (partially)
Signed-off-by: Laine Stump
---
src/qemu/qemu_interface.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_interface.c b/src/qemu/qemu_interface.c
index 446f43c364..83580b1a82 100644
--- a/src
This will simplify addition of another attribute to the element
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b7a342bb91..f21731b5f6 100644
--- a/src/conf
with info about support for using precreated tap/macvtap devices in
unprivileged libvirtd.
Signed-off-by: Laine Stump
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index c6580e4e72..be51d6c953 100644
--- a/docs/news.xml
+++ b
tap/macvtap devices will be more easily reviewable.
Signed-off-by: Laine Stump
---
src/qemu/qemu_interface.c | 69 ---
1 file changed, 35 insertions(+), 34 deletions(-)
diff --git a/src/qemu/qemu_interface.c b/src/qemu/qemu_interface.c
index 72ed51cb1f..1e3b7f0
libvirtd is given a precreated device, that device will *not* be
explicitly deleted when qemu is finished with it - the caller must
take care of that.
Laine Stump (9):
util: new function virNetDevMacVLanIsMacvtap()
util: make a couple virNetDevMacVlan*() functions public
qemu: reorganize qemuInterfaceEthernetConne
In virNetDevMacVLanOpen(), The "retries" arg has been removed and the
value hardcoded as 10, since previously the function was only called
from one place, so it was always 10.
Signed-off-by: Laine Stump
---
src/util/virnetdevmacvlan.c | 12 +---
src/util/virnetdevmacv
1001 - 1100 of 6183 matches
Mail list logo
