Re: [libvirt] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

On 06/29/2017 03:44 PM, Alex Williamson wrote: > On Thu, 29 Jun 2017 14:50:15 -0400 > Laine Stump <la...@redhat.com> wrote: > >> On 06/28/2017 08:24 PM, Michael Roth wrote: >>> Hi everyone. Hoping to get some feedback on this approach, or some >>> altern

Re: [libvirt] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

On 06/28/2017 08:24 PM, Michael Roth wrote: > Hi everyone. Hoping to get some feedback on this approach, or some > alternatives proposed below, to the following issue: > > Currently libvirt immediately attempts to rebind a managed device back to the > host driver when it receives a DEVICE_DELETED

Re: [libvirt] [PATCH] conf: Move virDomainPCIAddressBusIsFullyReserved()

omainPCIAddressBus struct it operates on; even more > so considering we're going to introduce a complementary > virDomainPCIAddressBusIsEmpty() function later on. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> Reviewed-by: Laine Stump <la...@laine.org> -- libvir-list

Re: [libvirt] [PATCH v3 25/26] qemu: Isolate hostdevs on pSeries guests

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > All the pieces are now in place, so we can finally start > using isolation groups to achieve our initial goal, which is > separating hostdevs from emulated PCI devices while keeping > hostdevs that belong to the same host IOMMU group together. Set

Re: [libvirt] [PATCH v3 24/26] conf: Implement isolation rules

plugging in the first device; moreover, some buses are > + * prevented from ever changing it */ > +if (!firstDevice || bus->isolationGroupLocked) Yeah, how does that 2nd thing happen? (setting isolationGroupLocked on an empty bus) I see that happens in the next patch f

Re: [libvirt] [PATCH v3 23/26] conf: Introduce isolation groups

up when desired, and the logic in the allocator to honor those requests. That all makes sense to me. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> Reviewed-by: Laine Stump <la...@laine.org> > --- > src/bhyve/bhyve_device.c | 4 ++-- > src/conf/de

Re: [libvirt] [PATCH v3 26/26] news: Update for multiple PHBs and hostdev isolation

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> Reviewed-by: Laine Stump <la...@laine.org> > --- > docs/news.xml | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/docs/news.xml b

Re: [libvirt] [PATCH v3 22/26] qemu: Use PHBs when extending the guest PCI topology

: Andrea Bolognani <abolo...@redhat.com> Reviewed-by: Laine Stump <la...@laine.org> (pretty simple change once I saw that most of the diffs were just due to an indentation change) > --- > src/conf/domain_addr.c | 56 + > src/conf/domain_

Re: [libvirt] [PATCH v3 21/26] qemu: Use PHBs to fill holes in PCI bus numbering

t; > > > - > - > - > - function='0x0'/> > + > + > + Interesting - since we initially had one with controller index=2 that was automatically given target index=1, now that this PHB controller is being automat

Re: [libvirt] [PATCH v3 20/26] tests: Add baseline tests for automatic PHB usage

l2argv-pseries-hostdevs-1.xml > b/tests/qemuxml2argvdata/qemuxml2argv-pseries-hostdevs-1.xml > new file mode 100644 > index 000..87fe145 > --- /dev/null > +++ b/tests/qemuxml2argvdata/qemuxml2argv-pseries-hostdevs-1.xml > @@ -0,0 +1,38 @@ > + > + guest > + 1ccfd

Re: [libvirt] [PATCH v3 19/26] tests: Add tests for pSeries guests with multiple PHBs

> + > + > + > + > + > + > + > + > + > diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c > index c74614c..a0a846c 100644 > --- a/tests/qemuxml2xmltest.c > +++ b/tests/qemuxml2xmltest.c > @@ -676,6 +676,13

Re: [libvirt] [PATCH v3 18/26] qemu: Use multiple PHBs for pSeries guests

The subject line implies (to me) that this patch somehow automagically creates multiple PHBs for the domain. It looks like what it does is to add the proper commandline args to the qemu command when multiple PHBs have already been added to the config. As for the functionality: Reviewed-by: Laine

Re: [libvirt] [PATCH v3 17/26] qemu: Deal with PHB naming conventions

he implicit PHB that's added > automatically to every pSeries guest creates the 'pci.0' bus. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> Sigh. Words can't even describe my feelings. Nothing else you can do about it though. Reviewed-by: Laine Stump <la...@laine.org&g

Re: [libvirt] [PATCH v3 14/26] conf: Add 'spapr-pci-host-bridge' controller model

On 06/26/2017 01:25 AM, Andrea Bolognani wrote: > On Sun, 2017-06-25 at 09:55 -0400, Laine Stump wrote: >>> Adding it to the virDomainControllerPCIModelName enumeration >>> is enough for existing code to handle it, so parsing and >>> formatting will work without furt

Re: [libvirt] [PATCH v3 13/26] conf: Parse and format

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/formatdomain.html.in | 5 + > docs/schemas/domaincommon.rng | 5 + > src/conf/domain_conf.c| 24 > src/conf/domain_conf.h| 1

Re: [libvirt] [PATCH v3 15/26] qemu: Automatically pick target index and model for pci-root controllers

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > pSeries guests will soon need the new information; luckily, > we can figure it out automatically most of the time, so > users won't have to worry about it. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> Reviewe

Re: [libvirt] [PATCH v3 14/26] conf: Add 'spapr-pci-host-bridge' controller model

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > Adding it to the virDomainControllerPCIModelName enumeration > is enough for existing code to handle it, so parsing and > formatting will work without further tweaking. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com>

Re: [libvirt] [PATCH v3 13/26] conf: Parse and format

s, I'm still uncomfortable about the lack of new tests here, because my own experience is that new code is alsmot always incorrect until it's been run through some tests. But since you're remedying this problem in a later patch in the series, I'm okay with it. Reviewed-by: Laine Stump <la...@laine.

Re: [libvirt] [PATCH v3 03/26] conf: Make virDomainPCIAddressFlagsCompatible() private

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > There are no external users. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> Reviewed-by: Laine Stump <la...@laine.org> > --- > src/conf/domain_addr.c | 2 +- > src/conf/domain_addr.h | 8 &

Re: [libvirt] [PATCH v3 05/26] qemu: Clean up qemuDomainAttachHostPCIDevice()

On 06/23/2017 11:03 AM, Andrea Bolognani wrote: > We use hostdev->info frequently enough that having > a shorter name for it makes the code more readable. > We will also be adding even more uses later on. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> Revi

Re: [libvirt] [PATCH 1/3] leasetime support for globally

On 06/22/2017 01:12 PM, Alberto Ruiz wrote: > > > 2017-06-21 17:30 GMT+01:00 Laine Stump <la...@laine.org > <mailto:la...@laine.org>>: > > On 06/21/2017 03:27 AM, Peter Krempa wrote: > > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.o

Re: [libvirt] [PATCH 1/3] leasetime support for globally

On 06/22/2017 12:21 PM, Alberto Ruiz wrote: > Hello Laine, > > 2017-06-21 17:30 GMT+01:00 Laine Stump <la...@laine.org > <mailto:la...@laine.org>>: > > On 06/21/2017 03:27 AM, Peter Krempa wrote: > > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@

Re: [libvirt] [PATCH v2] qemu: Remove duplicated code in qemuBuildSerialChrDeviceStr()

On 06/22/2017 06:08 AM, Andrea Bolognani wrote: > The call to qemuBuildDeviceAddressStr() happens no matter > what, so we can move it to the outer possible scope inside > the function. > > We can also move the call to virBufferAsprintf() after all > the checks have been performed, where it makes

Re: [libvirt] RFC: Creating mediated devices with libvirt

On 06/22/2017 12:15 PM, Daniel P. Berrange wrote: > On Thu, Jun 22, 2017 at 05:14:48PM +0200, Erik Skultety wrote: >> [...] ^this is the thing we constantly keep discussing as everyone has a slightly different angle of view - libvirt does not implement any kind of policy,

Re: [libvirt] RFC: Creating mediated devices with libvirt

On 06/22/2017 11:28 AM, Alex Williamson wrote: > On Thu, 22 Jun 2017 17:14:48 +0200 > Erik Skultety wrote: > >> [...] ^this is the thing we constantly keep discussing as everyone has a slightly different angle of view - libvirt does not implement any kind of

Re: [libvirt] [PATCH 2/3] lease time support per host in dnsmasq

On 06/20/2017 02:00 PM, ar...@gnome.org wrote: > From: Alberto Ruiz > > --- > src/network/bridge_driver.c | 56 > ++--- > src/util/virdnsmasq.c | 52 +++-- > src/util/virdnsmasq.h | 1 + >

Re: [libvirt] [PATCH 1/3] leasetime support for globally

On 06/21/2017 03:27 AM, Peter Krempa wrote: > On Tue, Jun 20, 2017 at 19:00:43 +0100, ar...@gnome.org wrote: >> From: Alberto Ruiz > > Missing commit message. And when composing the commit message, it's useful to include links to the associated BZ.

Re: [libvirt] [PATCH 3/3] qemu: add busy polling support

On 06/15/2017 10:17 AM, sferd...@redhat.com wrote: > From: Sahid Orentino Ferdjaoui > > This patch finalizes support of 'poll_us' attribute as an option of > the NIC driver-specific element, the commit also takes care of > hotplug. > > > > > > >

Re: [libvirt] [PATCH 2/3] conf: introduce 'poll_us' attribute for domain interface

On 06/15/2017 10:17 AM, sferd...@redhat.com wrote: > From: Sahid Orentino Ferdjaoui > > In this commit we introduce 'poll_us' attribute which will be passed > then to the QEMU command line to enable support of busy polling. This > commit also take into account that

Re: [libvirt] [PATCH 1/3] qemu: add capability for vhost-net busy polling

(Eduardo - I Cc'ed you because there's a question you may be able to answer about halfway down the message...) On 06/15/2017 10:17 AM, sferd...@redhat.com wrote: > From: Sahid Orentino Ferdjaoui > > QEMU 2.7.0 adds support of busy polling on vhost-net. > >

Re: [libvirt] RFC: Creating mediated devices with libvirt

On 06/15/2017 02:42 PM, Alex Williamson wrote: > On Thu, 15 Jun 2017 09:33:01 +0100 > "Daniel P. Berrange" wrote: > >> On Thu, Jun 15, 2017 at 12:06:43AM +0200, Erik Skultety wrote: >>> Hi all, >>> >>> so there's been an off-list discussion about finally implementing

Re: [libvirt] [PATCH 17/26] qemu: Deal with PHB naming convention

On 06/02/2017 12:07 PM, Andrea Bolognani wrote: > Usually, a controller with alias 'x' will create a bus with the > same name; however, the bus created by a PHBs with alias 'x' will > be named 'x.0' instead, so we need to account for that. This doesn't make sense to me. My recollection (without

Re: [libvirt] [PATCH 16/26] qemu: Introduce QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE

> b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml > index 425992f..7fa652a 100644 > --- a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml > +++ b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml > @@ -164,6 +164,7 @@ > > > > + >2006000 >0 > > Reviewed-by: Laine Stump <la...@laine.org> -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 15/26] qemu: Automatically pick index and model for pci-root controllers

On 06/02/2017 12:07 PM, Andrea Bolognani wrote: > pSeries guests will soon need the new information; > luckily, we can figure it out automatically most of > the time, so users won't have to bother with it. > --- > src/qemu/qemu_domain_address.c | 57 > +- >

Re: [libvirt] [PATCH 13/26] schema: Allow 'spapr-pci-host-bridge' controller model

On 06/02/2017 12:07 PM, Andrea Bolognani wrote: > --- > docs/schemas/domaincommon.rng | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng > index cff595b..d565a0b 100644 > --- a/docs/schemas/domaincommon.rng > +++

Re: [libvirt] [PATCH 11/26] schema: Allow

On 06/02/2017 12:07 PM, Andrea Bolognani wrote: > --- > docs/schemas/domaincommon.rng | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng > index 4d9f8d1..cff595b 100644 > --- a/docs/schemas/domaincommon.rng > +++

Re: [libvirt] [PATCH 12/26] conf: Parse and format

On 06/02/2017 12:07 PM, Andrea Bolognani wrote: > --- > src/conf/domain_conf.c | 24 > src/conf/domain_conf.h | 1 + > 2 files changed, 25 insertions(+) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index d5dff8e..deb0dce 100644 > ---

Re: [libvirt] [PATCH 10/26] qemu: Relax pci-root index requirement for pSeries guests

el == VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT || > + cont->model == VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT) && > +cont->idx != 0) { > virReportError(VIR_ERR_XML_ERROR, "%s", > _("pci-root and p

Re: [libvirt] [PATCH 09/26] conf: Move index number checking to drivers

On 06/12/2017 10:14 PM, Laine Stump wrote: > On 06/12/2017 10:08 PM, Laine Stump wrote: >> On 06/02/2017 12:07 PM, Andrea Bolognani wrote: >>> pSeries guests will soon be allowed to have multiple >>> PHBs (pci-root controllers), which of course means that >>>

Re: [libvirt] [PATCH 08/26] qemu: Tweak index number checking

On 06/13/2017 06:22 AM, Andrea Bolognani wrote: > On Mon, 2017-06-12 at 22:02 -0400, Laine Stump wrote: >>> Moving the check and rewriting it this way doesn't alter >>> the current behavior, but will allow us to special-case >>> pci-root down the line. >&g

Re: [libvirt] [PATCH 09/26] conf: Move index number checking to drivers

On 06/12/2017 10:08 PM, Laine Stump wrote: > On 06/02/2017 12:07 PM, Andrea Bolognani wrote: >> pSeries guests will soon be allowed to have multiple >> PHBs (pci-root controllers), which of course means that >> all but one of them will have a non-zero index; hence, &

Re: [libvirt] [PATCH 09/26] conf: Move index number checking to drivers

On 06/02/2017 12:07 PM, Andrea Bolognani wrote: > pSeries guests will soon be allowed to have multiple > PHBs (pci-root controllers), which of course means that > all but one of them will have a non-zero index; hence, > we'll need to relax the current check. > > However, right now the check is

Re: [libvirt] [PATCH 08/26] qemu: Tweak index number checking

On 06/02/2017 12:07 PM, Andrea Bolognani wrote: > Moving the check and rewriting it this way doesn't alter > the current behavior, but will allow us to special-case > pci-root down the line. But this function should never be called for a controller with model='pci-root'? > --- >

Re: [libvirt] [PATCH 07/26] qemu: Allow qemuBuildControllerDevStr() to return NULL

virDomainDef *domainDef, >virDomainControllerDefPtr def, >virQEMUCapsPtr qemuCaps, > + char **devstr, > int *nusbcontroller) > { > virBuffer buf = VIR_BUFFER_INITIALIZER; Maybe i

Re: [libvirt] [PATCH 06/26] conf: Simplify slot allocation

thm ended up give out a different address in some case (just in case someone using transient domains with no pre-assigned PCI addresses was expecting address stability), but I can't think of any way that would happen, and the fact that the unit tests all pass indicates that it isn't happening. Reviewed

Re: [libvirt] [PATCH 05/26] tests: Mock IOMMU groups

ups/%d", dev->iommuGroup) < 0) { > +ABORT("@tmp overflow"); > +} > +make_symlink(devpath, "iommu_group", tmp); > + > if (pci_device_autobind(dev) < 0) > ABORT("Unable to bind: %s", data->id); > > @@ -821,12

Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private

On 06/12/2017 05:20 AM, Andrea Bolognani wrote: > On Mon, 2017-06-12 at 08:35 +0200, Ján Tomko wrote: >>> Reviewed-by: Laine Stump <la...@laine.org> >>> >>> (This *is* the new hot way to say ACK, right?) >> >> It is not a replac

Re: [libvirt] [PATCH 04/26] tests: Update qemumemlock data

machines. Is it more normal on PPC? Reviewed-by: Laine Stump <la...@laine.org> > --- > tests/qemumemlockdata/qemumemlock-pc-hardlimit+hostdev.xml | 2 +- > tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked+hostdev.xml | 2 +- > tests/qemumemlockdata

Re: [libvirt] [PATCH 03/26] conf: Tweak virDomainPCIAddressGetNextAddr() signature

On 06/02/2017 12:07 PM, Andrea Bolognani wrote: > Move @function after @flags to match other functions in the > same module like virDomainPCIAddressReserveNextAddr(). I might have changed the other functions to put flags last (or maybe not). Anyway, consistency is good. Reviewed-by: Laine

Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private

yms > index 429b095..901cc99 100644 > --- a/src/libvirt_private.syms > +++ b/src/libvirt_private.syms > @@ -113,7 +113,6 @@ virDomainPCIAddressReserveNextAddr; > virDomainPCIAddressSetAllMulti; > virDomainPCIAddressSetAlloc; > virDomainPCIAddressSetFree; > -virDomainPCIAddressSetGrow

Re: [libvirt] [PATCH 01/26] conf: Remove obsolete comment

; -/* If adding to this struct, ensure that > - * virDomainDeviceInfoIsSet() is updated > - * to consider the new fields > - */ > char *alias; > int type; /* virDomainDeviceAddressType */ > union { > Reviewed-by: Laine Stump <la...@la

Re: [libvirt] [PATCH 2/2] qemuDomainChangeNet: Forbid changing MTU

behave inconsistently. > > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> Reviewed-by: Laine Stump <la...@laine.org> > --- > src/qemu/qemu_hotplug.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.

Re: [libvirt] [PATCH 1/2] qemu: Set iface MTU on hotplug

(tap not connected to any bridges) as well, which is a win, so ACK. > + > for (i = 0; i < tapfdSize; i++) { > if (qemuSecuritySetTapFDLabel(driver->securityManager, >vm->def, tapfd[i]) < 0) > Reviewed-by: Laine

[libvirt] [PATCH] docs: correct improper information about domain states in virsh manpage

Commit 24d4a0a1f removed the non-existent "dying" state from the list of possible domain states given in the virsh manpage, but didn't correct the count of states from 8 down to 7. This patch fixes that mismatch, while wording the sentence in a more readable/truthful manner. --- tools/virsh.pod |

Re: [libvirt] [PATCH] qemu: Don't special case mdevs when assigning PCI addresses

On 05/26/2017 06:51 AM, Andrea Bolognani wrote: > We can treat mdevs the same as all other PCI hostdevs > and figure out whether they are PCI Express or legacy PCI > by checking the size of their config space. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [PATCH] usb: keep leading zeros of vendor/product id in USB device

On 05/19/2017 03:17 AM, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanx...@gmail.com> > > Some vendor id or product id may have leading zeros. > We should show them. > > Signed-off-by: Chen Hanxiao <chenhanx...@gmail.com> Reviewed-by: Laine Stump <la...@laine

[libvirt] [PATCH] Revert "qemu: propagate bridge MTU into qemu "host_mtu" option"

This reverts commit 2841e675. It turns out that adding the host_mtu field to the PCI capabilities in the guest bumps the length of PCI capabilities beyond the 32 byte boundary, so the virtio-net device gets 64 bytes of ioport space instead of 32, which offsets the address of all the other

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

On 05/15/2017 06:15 PM, Vasiliy Tolstov wrote: > Signed-off-by: Vasiliy Tolstov > --- > docs/formatdomain.html.in | 21 + > docs/schemas/domaincommon.rng | 11 +++ > src/conf/domain_conf.c| 28 >

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

On 05/18/2017 04:32 PM, Vasiliy Tolstov wrote: > 2017-05-17 15:28 GMT+03:00 Peter Krempa : >>> >>> Well, *I* think I've given sufficient reasons for having the two link >>> states controlled separately, but since Dan and Peter had questioned its >>> usefulness, we should see

Re: [libvirt] [PATCH v2] qemu: Adding 'downscript' feature for QEMU network interfaces.

On 05/17/2017 11:26 AM, Daniel P. Berrange wrote: > On Tue, May 16, 2017 at 06:16:19PM -0400, Laine Stump wrote: >> On 05/05/2017 10:22 AM, Julio Faracco wrote: >>> This commit adds the support for 'downscript' feature: >>> - For QEMU command line with the option: >&

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

On 05/17/2017 03:51 AM, Vasiliy Tolstov wrote: > 2017-05-17 4:25 GMT+03:00 Laine Stump <la...@laine.org>: >> Oh, and I forgot to point out here (although I did in the original >> thread last fall) that a toplevel historically only >> affects the state of the interfac

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

On 05/16/2017 06:40 PM, Laine Stump wrote: > On 05/16/2017 04:21 AM, Vasiliy Tolstov wrote: >> 2017-05-16 11:16 GMT+03:00 Daniel P. Berrange <berra...@redhat.com>: >>> Shouldn't we just tie the host & guest link state together then. This >>> doesn't seem lik

Re: [libvirt] [PATCH] qemu: allow to control host side link status of network device

On 05/16/2017 04:21 AM, Vasiliy Tolstov wrote: > 2017-05-16 11:16 GMT+03:00 Daniel P. Berrange : >> Shouldn't we just tie the host & guest link state together then. This >> doesn't seem like enough of a reason to introduce new XML elements. > > > Back to half year ago i'm

Re: [libvirt] set link state for ethernet network devices

On 05/16/2017 06:27 PM, Laine Stump wrote: > On 05/10/2017 04:58 AM, Vasiliy Tolstov wrote: >> Hi! Sometimes ago i'm write patch for setting link state of network >> interface for ethernet type (tap). >> Now i'm try libvirt 3.3.0 and see, that tap interfaces is up but in >

Re: [libvirt] set link state for ethernet network devices

On 05/10/2017 04:58 AM, Vasiliy Tolstov wrote: > Hi! Sometimes ago i'm write patch for setting link state of network > interface for ethernet type (tap). > Now i'm try libvirt 3.3.0 and see, that tap interfaces is up but in > xml i'm try to specify > > also i'm try > > Nothing changed. Laine

Re: [libvirt] [PATCH v2] qemu: Adding 'downscript' feature for QEMU network interfaces.

On 05/05/2017 10:22 AM, Julio Faracco wrote: > This commit adds the support for 'downscript' feature: > - For QEMU command line with the option: > '-net downscript=/etc/qemu-ifdown,...'. > > - For Domains with a network interface description: > ' > ... > > ... > ' > > The

Re: [libvirt] [PATCH] mdev: Cleanup code after commits @daf5081b and @2739a983

On 05/04/2017 11:03 AM, Erik Skultety wrote: > So, because mingw is somehow OK with dereferencing a pointer within a > VIR_DEBUG macro, compared to outside of it to which it complained with a > "potential NULL pointer dereference" error (still a false positive), we > can make the code a tiny bit

Re: [libvirt] 答复: Re: 答复: Re: [PATCH] qemu: change the name of tap device for a tapand bridge network

E: lu.zhip...@zte.com.cn <mailto:lu.zhip...@zte.com.cn> > www.zte.com.cn <http://www.zte.com.cn/> > > 原始邮件 > *发件人：*＜berra...@redhat.com <mailto:berra...@redhat.com>＞; > *收件人：*＜la...@laine.org <mailto:la...@laine.org>＞; > *抄送人：*＜libvir

Re: [libvirt] [PATCH 1/2] util: mdev: Use a local variable instead of an invalid pointer reference

essing the pointer later. > > Signed-off-by: Erik Skultety <eskul...@redhat.com> Reviewed-by: Laine Stump <la...@laine.org> (Oh, and "safe for freeze", in case that wasn't assumed. Same goes for 2/2) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/2] mdev: Fix daemon crash on domain shutdown after reconnect

ad () from /lib64/libpthread.so.0 > 0x73d269cf in clone () from /lib64/libc.so.6 > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1446455 > > Signed-off-by: Erik Skultety <eskul...@redhat.com> Reviewed-by: Laine Stump <la...@laine.org> or ACK, or whate

Re: [libvirt] 答复: Re: [PATCH] qemu: change the name of tap device for a tapand bridge network

On 04/28/2017 07:23 PM, Joel Wirāmu Pauling wrote: > Possibly related I notice race conditions caused by vnic never getting > loaded if an existing bridge is already up (by OS init scripts etc) and > stopping VM's from getting started. Can you explain this more exactly? In particular, by "vnic"

Re: [libvirt] [PATCH] qemu: change the name of tap device for a tap and bridge network

On 04/28/2017 05:33 AM, Daniel P. Berrange wrote: > On Fri, Apr 28, 2017 at 05:23:19PM +0800, ZhiPeng Lu wrote: >> Creating tap device and adding the device to bridge are not atomic operation. >> Similarly deleting tap device and removing it from bridge are not atomic >> operation. >> The Problem

[libvirt] [PATCH v2 1/2] qemu: don't kill qemu process on restart if networkNotify fails

Nothing that could happen during networkNotifyActualDevice() could justify unceremoniously killing the qemu process, but that's what we were doing. In particular, new code added in commit 85bcc022 (first appearred in libvirt-3.2.0) attempts to reattach tap devices to their assigned bridge devices

[libvirt] [PATCH v2 2/2] network: better log message when network is inactive during reconnect

If the network isn't active during networkNotifyActualDevice(), we would log an error message stating that the bridge device didn't exist. This patch adds a check to see if the network is active, making the logs more useful in the case that it isn't. Partially resolves:

[libvirt] [PATCH v2 0/2] don't kill qemu process on restart if networkNotify fails

John thought I didn't go far enough in my removal of return codes in V1... Laine Stump (2): qemu: don't kill qemu process on restart if networkNotify fails network: better log message when network is inactive during reconnect src/network/bridge_driver.c | 17 +++-- src/network

Re: [libvirt] [PATCH 2/2] network: better log message when network is inactive during reconnect

On 04/27/2017 09:06 AM, John Ferlan wrote: > > > On 04/26/2017 05:57 PM, Laine Stump wrote: >> On 04/26/2017 02:39 PM, John Ferlan wrote: >>> >>> >>> On 04/25/2017 12:34 PM, Laine Stump wrote: >>>> If the network isn't active during networkNo

Re: [libvirt] [PATCH 2/2] network: better log message when network is inactive during reconnect

On 04/26/2017 02:39 PM, John Ferlan wrote: > > > On 04/25/2017 12:34 PM, Laine Stump wrote: >> If the network isn't active during networkNotifyActualDevice(), we >> would log an error message stating that the bridge device didn't >> exist. This patch adds a check to s

Re: [libvirt] [PATCH 1/2] qemu: don't kill qemu process on restart if networkNotify fails

On 04/26/2017 02:39 PM, John Ferlan wrote: > > > On 04/25/2017 12:33 PM, Laine Stump wrote: >> Nothing that could happen during networkNotifyActualDevice() could >> justify unceremoniously killing the qemu process, but that's what we >> were doing. > > So that

Re: [libvirt] [PATCH] IPv6 route check: list devices only once

On 04/26/2017 06:38 AM, Cédric Bosdonnat wrote: > If several RA routes are found for the same device, only list that > device once in the error message. > --- > src/util/virnetdevip.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/src/util/virnetdevip.c

Re: [libvirt] [PATCH] virsh-domain: update attach-interface to support bridge type

On 04/25/2017 05:13 AM, ZhiPeng Lu wrote: > Adding this feature will allow users to attach a network to linux bridge > or openvswitch. The interface can be attached using --brtype=linux or > --brtype=openvswitch. If --brtype is not set, the network is attached > to linux bridge. Rather than

[libvirt] [PATCH v2 1/3] util: make macvtap/macvlan generated name #defines available to other files

MACVTAP_NAME_PREFIX and MACVLAN_NAME_PREFIX could be useful to other files if they were defined in virnetdevmacvlan.h instead of virnetdevmacvlan.c, so do that (while slightly renaming them and also adding yet another #define that chooses between macvlan/macvtap based on flags). This is a

[libvirt] [PATCH v2 3/3] util: rename/move VIR_NET_GENERATED_PREFIX to be consistent

... with VIR_NET_GENERATED_MACV???_PREFIX, which is defined in util/virnetdevmacvlan.h. Since VIR_NET_GENERATED_PREFIX is used for plain tap devices, it is renamed to VIR_NET_GENERATED_TAP_PREFIX and moved to virnetdev.h --- src/bhyve/bhyve_command.c | 4 ++-- src/conf/domain_conf.c

[libvirt] [PATCH v2 0/3] conf: don't ignore for macvtap interfaces

e V1: * make a single #define for each of MACVLAN_PREFIX and MACVTAP_PREFIX in virnetdevmacvlan.h rather than duplicating #defines from virnetdevmacvlan.c into domain_conf.h (as suggested by Martin * move/rename the auto-generated prefix for regular tap devices to be consistent with the macvtap/

[libvirt] [PATCH v2 2/3] conf: don't ignore for macvtap interfaces

The parser had been clearing out *all* suggested device names for type='direct' (aka macvtap) interfaces. All of the code implementing macvtap allows for a user-specified device name, so we should allow it. In the case that an interface name starts with "macvtap" or "macvlan" though, we do still

[libvirt] [PATCH 2/2] network: better log message when network is inactive during reconnect

If the network isn't active during networkNotifyActualDevice(), we would log an error message stating that the bridge device didn't exist. This patch adds a check to see if the network is active, making the logs more useful in the case that it isn't. Partially resolves:

[libvirt] [PATCH 1/2] qemu: don't kill qemu process on restart if networkNotify fails

Nothing that could happen during networkNotifyActualDevice() could justify unceremoniously killing the qemu process, but that's what we were doing. In particular, new code added in commit 85bcc022 (first appearred in libvirt-3.2.0) attempts to reattach tap devices to their assigned bridge devices

[libvirt] [PATCH 0/2] don't kill qemu process on restart if networkNotify fails

The individual patches explain themselves. Laine Stump (2): qemu: don't kill qemu process on restart if networkNotify fails network: better log message when network is inactive during reconnect src/network/bridge_driver.c | 7 +++ src/qemu/qemu_process.c | 9 +++-- 2 files

[libvirt] [PATCH] util: allow ignoring SIOCSIFHWADDR when errno is EPERM

From: Laine Stump <la...@redhat.com> Commit f4ef3a71 made a variation of virNetDevSetMAC that would return without logging an error message if errno was set to EADDRNOTAVAIL. This errno is set by some SRIOV VF drivers (in particular igbvf) when they fail to set the device's MAC addre

[libvirt] [PATCH] util: allow ignoring SIOCSIFHWADDR when errno is EPERM

From: Laine Stump <la...@redhat.com> Commit f4ef3a71 made a variation of virNetDevSetMAC that would return without logging an error message if errno was set to EADDRNOTAVAIL. This errno is set by some SRIOV VF drivers (in particular igbvf) when they fail to set the device's MAC addre

Re: [libvirt] [PATCH] virpci: Enable GEN4 card Link speed (16GT/s)

On 03/01/2017 04:55 AM, Shivaprasad G Bhat wrote: > This enables GEN4 link speed (16GT/s) property to be fetched properly and thus > allows the detach/reattach/dumpxml to work. > I"m so accustomed to talking about *network* link speeds, that it took me a couple minutes to recognize this was

Re: [libvirt] [PATCH 1/2] networkUpdateState: Create virMacMap module more frequently

On 03/31/2017 07:20 AM, Michal Privoznik wrote: > On 03/30/2017 06:00 PM, Laine Stump wrote: >> On 03/28/2017 05:08 AM, Michal Privoznik wrote: >>> On 03/28/2017 02:22 AM, Laine Stump wrote: >>>> On 03/22/2017 10:43 AM, Michal Privoznik wrote: >>> >>&

Re: [libvirt] [PATCH 1/2] networkUpdateState: Create virMacMap module more frequently

On 03/28/2017 05:08 AM, Michal Privoznik wrote: > On 03/28/2017 02:22 AM, Laine Stump wrote: >> On 03/22/2017 10:43 AM, Michal Privoznik wrote: > >> >>> >>> Signed-off-by: Michal Privoznik <mpriv...@redhat.com> >>> --- >>> src/ne

Re: [libvirt] [PATCH] network: Drop unused networkRestartRadvd

On 03/29/2017 04:02 AM, Michal Privoznik wrote: > Since its introduction in 1ce4922e720 this function lived as an > outcast in an #if 0 block. My memory is faint now, but I believe radvd as a whole is now nearly unused, since dnsmasq gained the same functionality (route advertisement) soon after

Re: [libvirt] [PATCH v4 00/14] Introduce vGPU mdev framework to libvirt

On 03/28/2017 10:05 PM, yonglihe wrote: > On 2017年03月27日 15:42, yonglihe wrote: >> >> Verify Summary: >> * the none rooted mode starting a high-privileges VM actually. >> >> The configurations is source generated default value except tls disabled. >> >> >> 1. rooted >> >> virsh define

Re: [libvirt] [PATCH 1/2] networkUpdateState: Create virMacMap module more frequently

On 03/22/2017 10:43 AM, Michal Privoznik wrote: > The virMacMap module is there for dumping [domain, MACs>] pairs into a file so that libvirt_guest NSS module can use > it. Whenever a interface is allocated from network (e.g. on > domani startup or NIC hotplug), network is notified and so is

Re: [libvirt] [PATCH v2 0/4] storage: Better describe logical pool creation/definition parameters

On 03/27/2017 01:42 PM, John Ferlan wrote: > v1: > https://www.redhat.com/archives/libvir-list/2017-March/msg01227.html > > changes since v1: > > Split things part - added news article > > John Ferlan (4): > conf: Set defaultFormat if no storage source XML present > virsh.pod: Move the

Re: [libvirt] [PATCH] storage: Better describe logical pool creation/definition parameters

On 03/27/2017 11:37 AM, John Ferlan wrote: > > > On 03/26/2017 08:38 PM, Laine Stump wrote: >> On 03/25/2017 08:18 AM, John Ferlan wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1398087 >>> >>> Clean up the virsh man page description for --pool

Re: [libvirt] [PATCH] docs: document bhyve UEFI support

On 03/27/2017 12:33 PM, Roman Bogorodskiy wrote: > - Add a news entry > - Update the driver page with documentation of the new options >and some examples > --- > docs/drvbhyve.html.in | 94 > +++ > docs/news.xml | 13 +++ > 2

Re: [libvirt] [PATCH v2 1/2] daemon: Rework remoteClientFreeFunc cleanup loops into C macro

On 03/27/2017 12:47 PM, John Ferlan wrote: > Rather than 'n' repetitive code segments, let's create a single macro > which will make the code easier to read. > > Signed-off-by: John Ferlan > --- > daemon/remote.c | 126 >

Re: [libvirt] [PATCH] hostdev: Fix build with GCC's static analysis in mdev

On 03/27/2017 11:40 AM, John Ferlan wrote: > > > On 03/27/2017 11:30 AM, Martin Kletzander wrote: >> Similarly to eec3b255d26e7b38bdb0830990569fd91aee661f, fix build with >> lv_cv_static_analysis=yes. >> >> Caused by a4a39d90ab4930750bcbcfccffdf6bb6d310b5d5 >> --- >> src/util/virhostdev.c | 4

<    12   13   14   15   16   17   18   19   20   21   >