[libvirt] Snapshot: Request to review patch

2017-12-07 Thread Madhu Pavan
Hi all, Could someone please review https://www.redhat.com/archives/libvir-list/2017-October/msg01333.html This patch is based on comments from Jiri Denemark ( https://www.redhat.com/archives/libvir-list/2017-October/msg01275.html ) This patch potentially fixes

Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

2017-10-30 Thread Madhu Pavan
On 10/27/2017 06:51 PM, Jiri Denemark wrote: On Fri, Oct 27, 2017 at 18:47:51 +0530, Madhu Pavan wrote: On 10/27/2017 02:51 PM, Jiri Denemark wrote: I think this is actually a bit more complicated. When reverting to a snapshot, when reverting a snapshot we should revert both active

[libvirt] [PATCH 7/7] tests: docs: Add schema and testcase for domainsnapshot

2017-10-30 Thread Kothapally Madhu Pavan
the format. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- docs/schemas/domainsnapshot.rng| 19 + .../full_domain_withinactive.xml | 83 ++ tests/domainsnapshotxml2xmltest.c | 1 + 3 files change

[libvirt] [PATCH 6/7] virsh: Allow restoring snapshot with non-persistent configuration

2017-10-30 Thread Kothapally Madhu Pavan
of the snapshot is used as both the active and inactive XML configuration of the domain after restore. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-snapshot.c | 6 ++ tools/virsh.pod| 9 - 2 files changed, 14 insertions(+), 1 deletion(-)

[libvirt] [PATCH 3/7] conf: Allow editing inactive snapshot configuration

2017-10-30 Thread Kothapally Madhu Pavan
This patch will allow user to edit the inactive XML snapshot configuration when it is available in the snapshot. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/libvirt-domain.h | 1 + src/conf/domain_conf.c | 6 -- src/conf/domain_

[libvirt] [PATCH 2/7] qemu: Use active and inactive snapshot configuration on restore

2017-10-30 Thread Kothapally Madhu Pavan
configuration of snapshot as both active and inactive XML configurations of the restoring domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/libvirt-domain-snapshot.h | 10 +++--- src/qemu/qemu_driver.c| 20 +++- 2 files c

[libvirt] [PATCH 0/7] Keep non-persistent changes alive in snapshot

2017-10-30 Thread Kothapally Madhu Pavan
a snapshot. Kothapally Madhu Pavan (7): qemu: Store inactive domain configuration in snapshot qemu: Use active and inactive snapshot configuration on restore conf: Allow editing inactive snapshot configuration virsh: Dump inactive XML configuration of snapshot using snapshot-dumpxml virsh

[libvirt] [PATCH 4/7] virsh: Dump inactive XML configuration of snapshot using snapshot-dumpxml

2017-10-30 Thread Kothapally Madhu Pavan
Now, snapshot-dumpxml will display inactive XML configuration of snapshot along with active XML configuration. When --active-only flag is used the inactive XML configuration will not be displayed. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-snapshot.

[libvirt] [PATCH 5/7] virsh: Edit inactive XML configuration of snapshot using snapshot-edit

2017-10-30 Thread Kothapally Madhu Pavan
configuration in domain after restoring the snapshot. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-snapshot.c | 7 +++ tools/virsh.pod| 8 +++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snap

[libvirt] [PATCH 1/7] qemu: Store inactive domain configuration in snapshot

2017-10-30 Thread Kothapally Madhu Pavan
-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/conf/snapshot_conf.c | 13 + src/conf/snapshot_conf.h | 1 + src/qemu/qemu_driver.c | 10 ++ 3 files changed, 24 insertions(+) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index f

Re: [libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

2017-10-27 Thread Madhu Pavan
On 10/27/2017 02:51 PM, Jiri Denemark wrote: On Fri, Oct 27, 2017 at 14:02:23 +0530, Kothapally Madhu Pavan wrote: Restoring to a snapshot should not overwrite the persistent configuration xml of a snapshot as a side effect. This patch fixes the same. Currently, virDomainSnapshotDef only

[libvirt] [PATCH] qemu: snapshot: Keep non-persistent changes alive in snapshot

2017-10-27 Thread Kothapally Madhu Pavan
$memory-device attached in Step2. This patch is attempting to solve this issue. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/conf/snapshot_conf.c | 1 + src/conf/snapshot_conf.h | 1 + src/qemu/qemu_driver.c | 23 +++ 3 files changed, 25 inse

[libvirt] [PATCH] qemu: Move qemuFreeKeywords into qemu_parse_command.c

2017-10-16 Thread Kothapally Madhu Pavan
Move qemuFreeKeywords into qemu_parse_command.c as qemuKeywordsFree and call it rather than inline code in multiple places. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_monitor_json.c | 15 ++--- src/qemu/qemu_parse_command.

Re: [libvirt] [PATCH] qemu: Floppy disks not supported on pSeries machines

2017-10-10 Thread Madhu Pavan
On 10/10/2017 02:05 PM, Ján Tomko wrote: On Sun, Oct 08, 2017 at 03:26:13PM +0530, Kothapally Madhu Pavan wrote: Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_parse_command.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sr

[libvirt] [PATCH v3] qemu: argv: parse qemu commandline memory arguments

2017-10-09 Thread Kothapally Madhu Pavan
Existing qemuParseCommandLineMem() will parse "-m 4G" format string. This patch allows it to parse "-m size=8126464k,slots=32,maxmem=33554432k" format along with existing format. And adds a testcase to validate the changes. Signed-off-by: Kothapally Madhu Pavan <k...@linux

[libvirt] [PATCH v2] qemu: argv: parse qemu commandline memory arguments

2017-10-09 Thread Kothapally Madhu Pavan
Existing qemuParseCommandLineMem() will parse "-m 4G" format string. This patch allows it to parse "-m size=8126464k,slots=32,maxmem=33554432k" format along with existing format. And adds a testcase to validate the changes. Signed-off-by: Kothapally Madhu Pavan <k...@linux

Re: [libvirt] [PATCH] qemu: Changes in parsing qemu commandline memory section

2017-10-09 Thread Madhu Pavan
On 10/09/2017 04:34 PM, Daniel P. Berrange wrote: On Mon, Oct 09, 2017 at 04:32:38PM +0530, Kothapally Madhu Pavan wrote: Existing qemuParseCommandLineMem() will parse "-m 4G" format string. This patch allows it to parse "-m size=8126464k,slots=32,maxmem=33554432k" format

[libvirt] [PATCH] qemu: Changes in parsing qemu commandline memory section

2017-10-09 Thread Kothapally Madhu Pavan
Existing qemuParseCommandLineMem() will parse "-m 4G" format string. This patch allows it to parse "-m size=8126464k,slots=32,maxmem=33554432k" format along with existing format. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu

[libvirt] [PATCH] qemu: Floppy disks not supported on pSeries machines

2017-10-08 Thread Kothapally Madhu Pavan
Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_parse_command.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c index 7c409b0..d5745ce 100644 --- a/src/qemu/qemu_parse_command.c +++ b/sr

[libvirt] [PATCH] qemu: Remove redundant code in qemuParseCommandLineDisk

2017-10-08 Thread Kothapally Madhu Pavan
Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_parse_command.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c index 37e1149..7c409b0 100644 --- a/src/qemu/qemu_parse_com

[libvirt] [PATCH] util: Free a pointer in virPolkitCheckAuth

2017-10-04 Thread Kothapally Madhu Pavan
Free DBusMessage pointer in virPolkitCheckAuth Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/util/virpolkit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index c735ca9..4559431 100644 --- a/src/util/virpolkit.c

Re: [libvirt] RFC: Detaching interface from guest fails with improper error message if no mac given in xml

2017-09-29 Thread Madhu Pavan
On 09/29/2017 01:27 PM, Peter Krempa wrote: On Fri, Sep 29, 2017 at 12:45:30 +0530, Madhu Pavan wrote: This RFC is regarding https://bugzilla.redhat.com/show_bug.cgi?id=1497054 Let's say we have a network interface                 and we are trying to detach

[libvirt] RFC: Detaching interface from guest fails with improper error message if no mac given in xml

2017-09-29 Thread Madhu Pavan
This RFC is regarding https://bugzilla.redhat.com/show_bug.cgi?id=1497054 Let's say we have a network interface             function='0x0'/>     and we are trying to detach the above interface with the following xml(vfpool.xml):           function='0x0'/>

[libvirt] RFC: libvirt support for QEMU live patching

2017-09-15 Thread Madhu Pavan
get this done. I would like to send patches on this. Is there any specific reason why it is not been pursued for the last 4 year? I plan to use postcopy along with the local migration as part of migration, that way the guest need not be even paused for a busy guest. Thanks, Madhu Pavan. -- lib

Re: [libvirt] [PATCH 3/3] doc: Document managedsave-dumpxml support

2017-08-30 Thread Madhu Pavan
On 08/30/2017 04:12 PM, Peter Krempa wrote: On Wed, Aug 30, 2017 at 15:44:37 +0530, Kothapally Madhu Pavan wrote: Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/ne

[libvirt] [PATCH v2 0/2] Fix docs/news.xml template structure and add new features

2017-08-30 Thread Kothapally Madhu Pavan
This patchset will fix docs/news.xml template structure which is broken by commit b7e779c1a51793 and add support for managedsave-define, managedsave-edit and managedsave-dumpxml commands. Kothapally Madhu Pavan (2): docs: Fix docs/news.xml template structure docs: Document managedsave-edit

[libvirt] [PATCH v2 2/2] docs: Document managedsave-edit commands support

2017-08-30 Thread Kothapally Madhu Pavan
This patch documents support for managedsave-dumpxml, managedsave-define and managedsave-edit commands. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 0

[libvirt] [PATCH v2 1/2] docs: Fix docs/news.xml template structure

2017-08-30 Thread Kothapally Madhu Pavan
Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 05152b8..088966d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,8

[libvirt] [PATCH 1/3] doc: Fix docs/news.xml template structure

2017-08-30 Thread Kothapally Madhu Pavan
Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 05152b8..088966d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,8

[libvirt] [PATCH 2/3] doc: Document managedsave-define and managedsave-edit support

2017-08-30 Thread Kothapally Madhu Pavan
Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 088966d..119c478 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -37,6

[libvirt] [PATCH 3/3] doc: Document managedsave-dumpxml support

2017-08-30 Thread Kothapally Madhu Pavan
Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 119c478..fd64094 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -37,6

[libvirt] [PATCH 0/3] Fix docs/news.xml template structure and add new features

2017-08-30 Thread Kothapally Madhu Pavan
This patchset will fix docs/news.xml template structure which is broken by commit b7e779c1a51793 and add support for managedsave-define, managedsave-edit and managedsave-dumpxml commands. Kothapally Madhu Pavan (3): doc: Fix docs/news.xml template structure doc: Document managedsave-define

[libvirt] [PATCH v4 5/7] virsh: Implement managedsave-define command

2017-08-08 Thread Kothapally Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 79 tools/virsh.pod | 14 ++ 2 files changed, 93 insertions(+)

[libvirt] [PATCH v4 3/7] qemu: Implement qemuDomainManagedSaveGetXMLDesc

2017-08-08 Thread Kothapally Madhu Pavan
This commit adds qemu driver implementation to get xml description for managed save state domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 46 ++ 1 file changed, 46 insertions(+) diff --git

[libvirt] [PATCH v4 1/7] lib: Add API to dump xml configuration of managed save state domain

2017-08-08 Thread Kothapally Madhu Pavan
Similar to domainSaveImageGetXMLDesc this commit adds domainManagedSaveGetXMLDesc API which allows to get the xml of managed save state domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/libvirt-domain.h | 2 ++ src/driver-hypervisor.h

[libvirt] [PATCH v4 6/7] virsh: Implement managedsave-dumpxml command

2017-08-08 Thread Kothapally Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 56 tools/virsh.pod | 6 ++ 2 files changed, 62 insertions(+) diff

[libvirt] [PATCH v4 0/7] Add new APIs to edit xml configuration of managed save state of a domain

2017-08-08 Thread Kothapally Madhu Pavan
nce v1: - qemu implementation called directly rather than going through driver pointer in qemuDomainManagedSaveDefineXML. - check whether the managed save state file exists and report a error if it doesn't. Kothapally Madhu Pavan (7): lib: Add API to dump xml configuration of managed save st

[libvirt] [PATCH v4 4/7] qemu: Implement qemuDomainManagedSaveDefineXML

2017-08-08 Thread Kothapally Madhu Pavan
This commit adds qemu driver implementation to edit xml configuration of managed save state file of a domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 41 + 1 file changed, 41 insertions(+) diff

[libvirt] [PATCH v4 7/7] virsh: Implement managedsave-edit command

2017-08-08 Thread Kothapally Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 72 tools/virsh.pod | 21 +++ 2 files changed, 93 inse

[libvirt] [PATCH v4 2/7] lib: Add API to edit domain's managed save state xml configuration

2017-08-08 Thread Kothapally Madhu Pavan
Similar to domainSaveImageDefineXML this commit adds domainManagedSaveDefineXML API which allows to edit domain's managed save state xml configuration. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/libvirt-domain.h | 4 +++ src/driver-hyperv

[libvirt] [PATCH v3 2/2] qemu: Default hwclock source for sPAPR to RTC

2017-07-25 Thread Kothapally Madhu Pavan
QEMU fails to launch a sPAPR guest with clock sources other that RTC. Internally qemu only uses RTC timer for hwclock. This patch reports the right error message instead of qemu erroring out when any other timer other than RTC is used. Signed-off-by: Kothapally Madhu Pavan &l

[libvirt] [PATCH v3 1/2] qemu: Restrict usage of hpet and kvm.pit timers by unsupported architectures

2017-07-25 Thread Kothapally Madhu Pavan
hpet and kvm.pit clock timers are specific to x86 architecture and are not suppose to be used in other architectures. This patch restricts the usage of hpet and kvm.pit timers in unsupported architectures. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_do

[libvirt] [PATCH v3 0/2] Restrict usage of unsupported clock timers

2017-07-25 Thread Kothapally Madhu Pavan
hpet and kvm.pit clock timers are specific to x86 architecture and are not to be used by unsuported architectures. Similarly sPAPR guests only allow RTC timer. This patchset will restrict the usage of unsupported clock timers. Kothapally Madhu Pavan (2): qemu: Restrict usage of hpet and kvm.pit

[libvirt] [PATCH v2] qemu: Default hwclock source for sPAPR to RTC

2017-07-14 Thread Kothapally Madhu Pavan
QEMU fails to launch a sPAPR guest with clock sources other that RTC. Internally qemu only uses RTC timer for hwclock. This patch reports the right error message instead of qemu erroring out when any other timer other than RTC is used. Signed-off-by: Kothapally Madhu Pavan &l

Re: [libvirt] [PATCH] qemu: Default hwclock source for sPAPR to RTC

2017-07-13 Thread Madhu Pavan
On 07/13/2017 05:49 PM, Cole Robinson wrote: On 07/13/2017 04:36 AM, Kothapally Madhu Pavan wrote: QEMU fails to launch a sPAPR guest with clock sources other that RTC. Internally qemu only uses RTC timer for hwclock. This patch reports the right error message instead of qemu erroring out

[libvirt] [PATCH] qemu: Default hwclock source for sPAPR to RTC

2017-07-13 Thread Kothapally Madhu Pavan
QEMU fails to launch a sPAPR guest with clock sources other that RTC. Internally qemu only uses RTC timer for hwclock. This patch reports the right error message instead of qemu erroring out when any other timer other than RTC is used. Signed-off-by: Kothapally Madhu Pavan &l

[libvirt] [PATCH v3 0/7] Add new APIs to edit xml configuration of managed save state of a domain

2017-07-05 Thread Kothapally Madhu Pavan
ter in qemuDomainManagedSaveDefineXML. - check whether the managed save state file exists and report a error if it doesn't. Kothapally Madhu Pavan (7): lib: Add API to dump xml configuration of managed save state domain lib: Add API to edit domain's managed save state xml configuration qemu: Implem

[libvirt] [PATCH v3 4/7] qemu: Implement qemuDomainManagedSaveDefineXML

2017-07-05 Thread Kothapally Madhu Pavan
This commit adds qemu driver implementation to edit xml configuration of managed save state file of a domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 41 + 1 file changed, 41 insertions(+) diff

[libvirt] [PATCH v3 7/7] virsh: Implement managedsave-edit command

2017-07-05 Thread Kothapally Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 72 tools/virsh.pod | 21 +++ 2 files changed, 93 inse

[libvirt] [PATCH v3 2/7] lib: Add API to edit domain's managed save state xml configuration

2017-07-05 Thread Kothapally Madhu Pavan
Similar to domainSaveImageDefineXML this commit adds domainManagedSaveDefineXML API which allows to edit domain's managed save state xml configuration. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/libvirt-domain.h | 4 +++ src/driver-hyperv

[libvirt] [PATCH v3 6/7] virsh: Implement managedsave-dumpxml command

2017-07-05 Thread Kothapally Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 56 tools/virsh.pod | 6 ++ 2 files changed, 62 insertions(+) diff

[libvirt] [PATCH v3 5/7] virsh: Implement managedsave-define command

2017-07-05 Thread Kothapally Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 79 tools/virsh.pod | 14 ++ 2 files changed, 93 insertions(+)

[libvirt] [PATCH v3 1/7] lib: Add API to dump xml configuration of managed save state domain

2017-07-05 Thread Kothapally Madhu Pavan
Similar to domainSaveImageGetXMLDesc this commit adds domainManagedSaveGetXMLDesc API which allows to get the xml of managed save state domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/libvirt-domain.h | 2 ++ src/driver-hypervisor.h

[libvirt] [PATCH v3 3/7] qemu: Implement qemuDomainManagedSaveGetXMLDesc

2017-07-05 Thread Kothapally Madhu Pavan
This commit adds qemu driver implementation to get xml description for managed save state domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 46 ++ 1 file changed, 46 insertions(+) diff --git

[libvirt] [resend PATCH v2 6/7] virsh: Implement managedsave-dumpxml command

2017-06-22 Thread Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 56 tools/virsh.pod | 6 ++ 2 files changed, 62 insertions(+) diff

[libvirt] [resend PATCH v2 7/7] virsh: Implement managedsave-edit command

2017-06-22 Thread Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 72 tools/virsh.pod | 21 +++ 2 files changed, 93 inse

[libvirt] [resend PATCH v2 5/7] virsh: Implement managedsave-define command

2017-06-22 Thread Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 79 tools/virsh.pod | 14 ++ 2 files changed, 93 insertions(+)

[libvirt] [resend PATCH v2 4/7] qemu: Implement qemuDomainManagedSaveDefineXML

2017-06-22 Thread Madhu Pavan
This commit adds qemu driver implementation to edit xml configuration of managed save state file of a domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 41 + 1 file changed, 41 insertions(+) diff

[libvirt] [resend PATCH v2 2/7] lib: Add API to edit domain's managed save state xml configuration

2017-06-22 Thread Madhu Pavan
Similar to domainSaveImageDefineXML this commit adds domainManagedSaveDefineXML API which allows to edit domain's managed save state xml configuration. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/libvirt-domain.h | 4 +++ src/driver-hyperv

[libvirt] [resend PATCH v2 3/7] qemu: Implement qemuDomainManagedSaveGetXMLDesc

2017-06-22 Thread Madhu Pavan
This commit adds qemu driver implementation to get xml description for managed save state domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 46 ++ 1 file changed, 46 insertions(+) diff --git

[libvirt] [resend PATCH v2 1/7] lib: Add API to dump xml configuration of managed save state domain

2017-06-22 Thread Madhu Pavan
Similar to domainSaveImageGetXMLDesc this commit adds domainManagedSaveGetXMLDesc API which allows to get the xml of managed save state domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/libvirt-domain.h | 2 ++ src/driver-hypervisor.h

[libvirt] [resend PATCH v2 0/7] Add new APIs to edit xml configuration of managed save state of a domain

2017-06-22 Thread Madhu Pavan
sts and report a error if it doesn't. Kothapally Madhu Pavan (7): lib: Add API to dump xml configuration of managed save state domain lib: Add API to edit domain's managed save state xml configuration qemu: Implement qemuDomainManagedSaveGetXMLDesc qemu: Implem

Re: [libvirt] [PATCH 4/7] qemu: Implement qemuDomainManagedSaveDefineXML

2017-06-21 Thread Madhu Pavan
On 06/21/2017 01:02 PM, Peter Krempa wrote: On Wed, Jun 21, 2017 at 05:07:49 +0530, Kothapally Madhu Pavan wrote: This commit adds qemu driver implementation to edit xml configuration of managed save state file of a domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.

Re: [libvirt] [PATCH 3/7] qemu: Implement qemuDomainManagedSaveGetXMLDesc

2017-06-21 Thread Madhu Pavan
On 06/21/2017 01:05 PM, Peter Krempa wrote: On Wed, Jun 21, 2017 at 05:07:48 +0530, Kothapally Madhu Pavan wrote: This commit adds qemu driver implementaion to get xml description for managed save state domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- sr

[libvirt] [PATCH 3/7] qemu: Implement qemuDomainManagedSaveGetXMLDesc

2017-06-20 Thread Kothapally Madhu Pavan
This commit adds qemu driver implementaion to get xml description for managed save state domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 40 1 file changed, 40 insertions(+) diff --git a/sr

[libvirt] [PATCH 5/7] virsh: Implement managedsave-define command

2017-06-20 Thread Kothapally Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 79 tools/virsh.pod | 14 ++ 2 files changed, 93 insertions(+)

[libvirt] [PATCH 4/7] qemu: Implement qemuDomainManagedSaveDefineXML

2017-06-20 Thread Kothapally Madhu Pavan
This commit adds qemu driver implementation to edit xml configuration of managed save state file of a domain. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 38 ++ 1 file changed, 38 insertions(+) diff --git

[libvirt] [PATCH 7/7] virsh: Implement managedsave-edit command

2017-06-20 Thread Kothapally Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 72 tools/virsh.pod | 21 +++ 2 files changed, 93 inse

[libvirt] [PATCH 6/7] virsh: Implement managedsave-dumpxml command

2017-06-20 Thread Kothapally Madhu Pavan
Add a simple virsh command handler which makes use of the new API. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c | 56 tools/virsh.pod | 6 ++ 2 files changed, 62 insertions(+) diff

[libvirt] [PATCH 1/7] lib: Add API to dump xml configuration of managed save state domain

2017-06-20 Thread Kothapally Madhu Pavan
Similar to domainSaveImageGetXMLDesc this commit adds domainManagedSaveGetXMLDesc API which allows to get the xml of managed save state domain. This allows to edit the managed save state domain xml. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/l

[libvirt] [PATCH 0/7] Add new APIs to edit xml configuration of managed save state of a domain

2017-06-20 Thread Kothapally Madhu Pavan
ame state-file-xml or you can simply use: virsh managedsave-edit domain-name It is always better when we get more. Kothapally Madhu Pavan (7): lib: Add API to dump xml configuration of managed save state domain lib: Add API to edit domain's managed save state xml configuration qemu: Implem

[libvirt] [PATCH 2/7] lib: Add API to edit domain's managed save state xml configuration

2017-06-20 Thread Kothapally Madhu Pavan
Similar to domainSaveImageDefineXML this commit adds domainManagedSaveDefineXML API which allows to edit domain's managed save state xml configuration. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- include/libvirt/libvirt-domain.h | 4 +++ src/driver-hyperv

[libvirt] [PATCH] qemu: Remove unused variables in qemuDomainUpdateDeviceConfig

2017-05-16 Thread Kothapally Madhu Pavan
priv and qemuCaps variables are not used anymore. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1c4873e..4721356 100644 ---

[libvirt] [PATCH] Adding POWER9 cpu model to cpu_map.xml

2017-05-09 Thread Kothapally Madhu Pavan
As POWER9 model is not available in cpu_map.xml virsh capabilities donot display the cpu model and vendor details. This patch provides those details --- src/cpu/cpu_map.xml |5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 7d5540a..29b5b59

Re: [libvirt] [PATCH] qemu: Check for maximum vcpus exceeding cpu topology

2017-02-20 Thread Madhu Pavan
On 02/07/2017 06:41 PM, Peter Krempa wrote: On Tue, Feb 07, 2017 at 07:56:29 -0500, Kothapally Madhu Pavan wrote: This patch will prevent guest to start when the maximum vcpus are greater than cpu topology limit. Currently similar checks do exist only during setvcpus. The patch adds

[libvirt] [PATCH] qemu: Check for maximum vcpus exceeding cpu topology

2017-02-07 Thread Kothapally Madhu Pavan
it in domain validation part to be consistent with the original intent. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_process.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 184440d..f

[libvirt] [PATCH] domain_event.c: Fix a typo

2016-10-31 Thread Kothapally Madhu Pavan
Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/conf/domain_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 63ae9e1..f1249ad 100644 --- a/src/conf/domain_event.c +++ b/sr

[libvirt] [PATCH v2] vsh: Using VSH_REQUIRE_OPTION rather than virReportError

2016-10-18 Thread Kothapally Madhu Pavan
Correcting the error reporting method by using VSH_REQUIRE_OPTION instead of virReportError Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/virsh-domain.c b/tools

Re: [libvirt] [PATCH] vsh: Using vshError rather than virReportError

2016-10-18 Thread Madhu Pavan
On 10/18/2016 07:33 PM, Peter Krempa wrote: On Tue, Oct 18, 2016 at 07:39:16 -0400, Kothapally Madhu Pavan wrote: Correcting the error reporting method by using vshError instead of virReportError Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-do

[libvirt] [PATCH] vsh: Using vshError rather than virReportError

2016-10-18 Thread Kothapally Madhu Pavan
Correcting the error reporting method by using vshError instead of virReportError Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-do

[libvirt] [PATCH] Make --postcopy flag mandatory with --postcopy-after-precopy

2016-09-02 Thread Kothapally Madhu Pavan
--postcopy-after-precopy is just an aditional flag for postcopy migration. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c |6 +++--- tools/virsh.pod |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/virsh-do

Re: [libvirt] [PATCH] Check for --live flag for postcopy-after-precopy migration

2016-08-29 Thread Madhu Pavan
On 08/27/2016 02:21 AM, Jiri Denemark wrote: On Fri, Aug 26, 2016 at 21:41:31 +0200, Michal Privoznik wrote: On 26.08.2016 11:25, Kothapally Madhu Pavan wrote: Unlike postcopy migration there is no --live flag check for postcopy-after-precopy. Signed-off-by: Kothapally Madhu Pavan &l

[libvirt] [PATCH] Check for --live flag for postcopy-after-precopy migration

2016-08-26 Thread Kothapally Madhu Pavan
Unlike postcopy migration there is no --live flag check for postcopy-after-precopy. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- tools/virsh-domain.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d

[libvirt] [PATCH] conf: Skip MAC checks when using an auto-generated one during detach-device

2016-05-30 Thread Kothapally Madhu Pavan
found". This patch allows to match DetachDeviec xml using PCI address when mac address is not specified. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/conf/domain_conf.c | 116 +- src/conf/domain_conf.h |

[libvirt] [PATCH] conf: Skip generating random MAC in DetachDevice xml

2016-04-18 Thread Kothapally Madhu Pavan
found". Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/conf/domain_conf.c |4 src/conf/domain_conf.h |3 +++ src/libxl/libxl_driver.c | 12 ++-- src/lxc/lxc_driver.c |7 --- src/qemu/qemu_driver.c |2 ++ src/

[libvirt] [PATCH] qemu: ignore EACCES error on hot unplug of PCI devices with VFIO

2016-03-07 Thread Kothapally Madhu Pavan
When the hostdev managed=true, the VFIO devices are reattached to the host driver before coming to qemuTeardownHostdevCgroup(). So, the /dev/vfio/ path would not exist. We ignore the EACCES error here. Signed-off-by: Kothapally Madhu Pavan <k...@linux.vnet.ibm.com> --- src/qemu/qemu_cg

Re: [libvirt] [PATCH v2 2/3] Avoid starting a PowerPC VM with floppy disk

2015-08-03 Thread madhu pavan
On 08/03/2015 06:23 PM, Ján Tomko wrote: On Thu, Jul 30, 2015 at 07:55:36AM -0400, Kothapally Madhu Pavan wrote: PowerPC pseries based VMs do not support a floppy disk controller. Here the commit message mentions a controller, but the code only checks for the disk type='floppy'/ device

[libvirt] [PATCH v2 2/3] Avoid starting a PowerPC VM with floppy disk

2015-07-30 Thread Kothapally Madhu Pavan
PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from creating qemu command with floppy device. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/qemu/qemu_command.c |8 1 file changed, 8 insertions(+) diff --git a/src

[libvirt] [PATCH v2 1/3] Caps: Disable floppy disk for PowerPC VM

2015-07-30 Thread Kothapally Madhu Pavan
PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from adding floppy disk for a PowerPC pseries VM. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c | 15 +++ 1 file changed, 11 insertions(+), 4

[libvirt] [PATCH v2 3/3] test: Introduce test case to disallow floppy disk on PowerPC VM

2015-07-30 Thread Kothapally Madhu Pavan
PowerPC pseries based VMs do not support a floppy disk controller. This test case fails if libvirt allows a floppy disk on pseries VMs. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- .../qemuxml2argv-disk-floppy-pseries.args |6 +++ .../qemuxml2argv-disk-floppy

Re: [libvirt] [PATCH 2/2] Avoid starting a PowerPC VM with floppy disk

2015-07-30 Thread madhu pavan
On 07/28/2015 05:32 PM, Ján Tomko wrote: On Fri, Jul 24, 2015 at 03:30:49PM -0400, Kothapally Madhu Pavan wrote: PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from creating qemu command with floppy device. Signed-off-by: Kothapally Madhu Pavan k

Re: [libvirt] [PATCH 0/2] Disable floppy disk for PowerPC VMs

2015-07-30 Thread madhu pavan
On 07/29/2015 06:25 PM, Andrea Bolognani wrote: On Fri, 2015-07-24 at 15:29 -0400, Kothapally Madhu Pavan wrote: This is an attempt to fix: Libvirt BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1180486 Libvirt currently assumes ISA_based floppy disks to be available across all

[libvirt] [PATCH v2 0/3] Disable floppy disk for PowerPC VMs

2015-07-30 Thread Kothapally Madhu Pavan
. This patch series prevents libvirt from launching ppc64[le] -based 'pseries' VMs with floppy devices. This version of patch attempts to fulfill the coments of Andrea Bolognani and Jan Tomko on previous version of patch. --- Kothapally Madhu Pavan (3): Caps: Disable floppy disk for PowerPC

[libvirt] [PATCH 0/2] Disable floppy disk for PowerPC VMs

2015-07-24 Thread Kothapally Madhu Pavan
. This patch series prevents libvirt from launching ppc64[le] -based 'pseries' VMs with floppy devices. --- Kothapally Madhu Pavan (2): Caps: Disable floppy disk for PowerPC Vm Avoid starting a PowerPC VM with floppy disk src/conf/domain_conf.c | 19 + src

[libvirt] [PATCH 2/2] Avoid starting a PowerPC VM with floppy disk

2015-07-24 Thread Kothapally Madhu Pavan
PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from creating qemu command with floppy device. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/qemu/qemu_command.c | 47 +-- 1 file

[libvirt] [PATCH 1/2] Caps: Disable floppy disk for PowerPC VM

2015-07-24 Thread Kothapally Madhu Pavan
PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from adding floppy disk for a PowerPC pseries VM. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 19 +++ src/qemu/qemu_capabilities.c

[libvirt] [PATCH v3] nodeinfo: fix to parse present cpus rather than possible cpus

2015-06-26 Thread Kothapally Madhu Pavan
Currently we are parsing all the possible cpus to get the nodeinfo. This fix will perform a check for present cpus before parsing. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/nodeinfo.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/nodeinfo.c

[libvirt] [PATCH v2] nodeinfo: fix to parse present cpus rather than possible cpus

2015-06-16 Thread Kothapally Madhu Pavan
Currently we are parsing all the possible cpus to get the nodeinfo. This fix will perform a check for present cpus before parsing. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/nodeinfo.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/nodeinfo.c

[libvirt] [PATCH] nodeinfo: fix to parse present cpus rather than possible cpus

2015-06-10 Thread Kothapally Madhu Pavan
Currently we are parsing all the possible cpus to get the nodeinfo. This fix will perform a check for present cpus before parsing. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/nodeinfo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/nodeinfo.c b

[libvirt] [PATCH v2] virsh: Fix to list online cpus using virsh capabilities

2015-05-26 Thread Kothapally Madhu Pavan
Virsh capabilities will list offline cpus as online when libvirt is compiled with numactl option disabled. This fix will list correct set of online cpus. --- src/nodeinfo.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/src/nodeinfo.c

  1   2   >