Hi
On Tue, Apr 11, 2023 at 11:10 AM Michal Prívozník
wrote:
> On 4/6/23 17:58, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > The function does not exist on win32.
> >
> > Signed-off-by: Marc-André Lureau
> > ---
Hi
On Tue, Apr 11, 2023 at 11:10 AM Michal Prívozník
wrote:
> On 4/6/23 17:58, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > meson wraps python scripts already on win32, so we end up with these
> > failing commands:
> >
> &
Hi
On Tue, Jul 26, 2022 at 12:44 PM Daniel P. Berrangé wrote:
>
> On Tue, Jul 26, 2022 at 12:32:32PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > As Ed Swierk explained back in 2006:
> > https://lists.nongnu.org/archive/html/qe
gent-features.xml
> create mode 100644
> tests/qemuxml2argvdata/channel-qemu-vdagent.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/channel-qemu-vdagent.xml
> create mode 100644
> tests/qemuxml2xmloutdata/channel-qemu-vdagent-features.x86_64-latest.xml
> create mode 100644
> tests/qemuxml2xmloutdata/channel-qemu-vdagent.x86_64-latest.xml
>
> --
> 2.35.1
>
>
>
--
Marc-André Lureau
Hi
On Wed, Dec 22, 2021 at 11:45 PM wrote:
> From: Marc-André Lureau
>
> Hi,
>
> This series implements supports for the uQEMU "-display dbus" support, that
> landed earlier this week for 7.0.
>
> By default, libvirt will start a private VM bus (sharing and r
Hi,
On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma wrote:
>
> Implement the qemu-vdagent channel introduced in the previous commit.
>
> Signed-off-by: Jonathon Jongsma
lgtm,
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu_command.c | 21 +
usb or virtio tablet device.
>
> Sample configuration:
>
>
>
>
>
>
>
>
> Signed-off-by: Jonathon Jongsma
I guess you could have added some domain XML tests here, but the next
patch covers it, so
Reviewed-by: Marc-André Lureau
> ---
>
On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma wrote:
>
> This enumeration will be useful for vnc with the upcoming qemu-vdagent
> device so make the name more generic.
>
> Signed-off-by: Jonathon Jongsma
Reviewed-by: Marc-André Lureau
> ---
> src/conf/domain_conf.c
On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma wrote:
>
> Detect whether qemu supports the qemu-vdagent character device. This
> enables support for copy/paste with VNC graphics.
>
> Signed-off-by: Jonathon Jongsma
Reviewed-by: Marc-André Lureau
> ---
> src/qem
Hi
On Wed, Mar 23, 2022 at 6:44 PM Jonathon Jongsma wrote:
>
> On 3/23/22 4:17 AM, Daniel P. Berrangé wrote:
> > On Wed, Mar 23, 2022 at 12:01:19PM +0400, Marc-André Lureau wrote:
> >> Hi
> >>
> >> On Wed, Mar 23, 2022 at 12:47 AM Jonathon Jongsma
&g
Hi
On Wed, Mar 23, 2022 at 12:47 AM Jonathon Jongsma wrote:
>
> This patch series enables support for the qemu-vdagent character device which
> enables copy/paste support between guest and client when using vnc graphics.
>
> The guest must be configured with something like the following:
>
>
hould return an error, no?
Why not call DoAsyncIO() implicitly in RunAsync() in this case?
(sorry to repeat maybe my earlier question, trying to be more precise :)
thanks
--
Marc-André Lureau
dDoAsyncIO() must be called.
>
> The credit goes to Marc-André Lureau
> who has done all the debugging and
> proposed fix in the bugzilla.
>
(thanks for the credit :)
Wouldn't it make sense to return an error if SendBuffers is used without
AsyncIO then? Or just enable AsyncIO as
Hi Neal
On Fri, Dec 31, 2021 at 6:09 AM Neal Gompa wrote:
>
> On Wed, Dec 22, 2021 at 2:44 PM wrote:
> >
> > From: Marc-André Lureau
> >
> > Hi,
> >
> > This series implements supports for the uQEMU "-display dbus" support, that
> > lan
Hi
On Fri, Dec 3, 2021 at 8:29 PM Daniel P. Berrangé wrote:
>
> On Thu, Dec 02, 2021 at 06:23:56PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Hi,
> >
> > This series implements supports for the upcoming QEMU "-di
On Mon, Nov 29, 2021 at 9:20 PM Michal Prívozník wrote:
>
> On 11/5/21 11:51, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > The daemon is started on daemon in external devices and hotplug code.
> > Add a mechanism to start it bef
Hi
On Mon, Nov 29, 2021 at 9:20 PM Michal Prívozník wrote:
>
> On 11/5/21 11:51, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Without any extra option, libvirt will start and tell QEMU to connect to
> > the private VM bus.
> >
>
Hi
On Tue, Nov 30, 2021 at 12:41 AM Peter Krempa wrote:
>
> On Fri, Nov 05, 2021 at 14:51:13 +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > src/qemu/qemu_capabilities.c
Hi
On Fri, Nov 5, 2021 at 2:51 PM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> This series implements supports for the upcoming QEMU "-display dbus" support.
> Development is still in progress, but I hope to land the QEMU support early in
> 6.3 (last version
ere..
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu_tpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
> index b305313ad2..1992b596cb 100644
> --- a/src/qemu/qemu_tpm.c
> +++ b
Hi
On Mon, Nov 1, 2021 at 9:23 PM Stefan Berger wrote:
>
> Extend the TPM domain XML with an attribute active_pcr_banks that allows
> a user to specify the PCR banks to activate before starting a VM. A comma-
> separated list of PCR banks with the choices of sha1, sha256, sha384 and
> sha512 is
On Mon, Nov 1, 2021 at 9:23 PM Stefan Berger wrote:
>
> Move the code that adds encryption options for the swtpm_setup command
> line into its own function.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> src
Hi
On Wed, Oct 27, 2021 at 9:00 PM Stefan Berger wrote:
>
> Extend qemu.conf with a configration option swtpm_active_pcr_banks that
> allows a user to set a comma-separated list of PCR banks to activate
> during 'TPM manufacturing'. Valid PCR banks are sha1,sha256,sha384 and
> sha512.
>
Why not
line before. This program needs to run once.
>
> This patch addresses the issue raised in
> https://bugzilla.redhat.com/show_bug.cgi?id=2010649
>
> Signed-off-by: Stefan Berger
>
Reviewed-by: Marc-André Lureau
> ---
> v5:
> - Address Daniel's comments on v4
>
pFeature,
>VIR_TPM_SWTPM_SETUP_FEATURE_LAST,
>"cmdarg-pwdfile-fd",
> + "cmdarg-create-config-files",
> );
>
> /**
> diff --git a/src/util/virtpm.h b/src/util/virtpm.h
> index d021a083b4..3bb03b3b33 100644
> --- a/src/util/virtpm.h
> +++ b/src/util/virtpm.h
> @@ -38,6 +38,7 @@ typedef enum {
>
> typedef enum {
> VIR_TPM_SWTPM_SETUP_FEATURE_CMDARG_PWDFILE_FD,
> +VIR_TPM_SWTPM_SETUP_FEATURE_CMDARG_CREATE_CONFIG_FILES,
>
> VIR_TPM_SWTPM_SETUP_FEATURE_LAST
> } virTPMSwtpmSetupFeature;
> --
> 2.31.1
>
>
lgtm,
Reviewed-by: Marc-André Lureau
Hi
On Fri, Oct 8, 2021 at 10:31 PM Stefan Berger wrote:
>
> On 10/8/21 12:33 PM, Marc-André Lureau wrote:
>
> Hi
>
> On Fri, Oct 8, 2021 at 6:44 PM Stefan Berger
> wrote:
>
>> Using swtpm v0.7.0 we can run swtpm_setup to create default config files
>&g
Hi
On Fri, Oct 8, 2021 at 6:44 PM Stefan Berger wrote:
> Using swtpm v0.7.0 we can run swtpm_setup to create default config files
> for swtpm_setup and swtpm-localca in session mode. Now a user can start
> a VM with an attached TPM without having to run this program on the
> command line
On Fri, Oct 8, 2021 at 5:56 PM Stefan Berger wrote:
> Using swtpm v0.7.0 we can run swtpm_setup to create default config files
> for swtpm_setup and swtpm-localca in session mode. Now a user can start
> a VM with an attached TPM without having to run this program on the
> command line before.
On Wed, Feb 24, 2021 at 5:15 PM Daniel P. Berrangé
wrote:
> This only makes sense conceptually when used with listener chardevs.
>
> Signed-off-by: Daniel P. Berrangé
>
Reviewed-by: Marc-André Lureau
---
> chardev/char-socket.c| 12
> docs/sys
es
>
> commit 05a75ca2ce743bc0bb119fb8d532ff84646fafa3
> Author: Marc-André Lureau
> Date: Fri Nov 20 22:09:46 2020 +0400
>
> domain: add disk informations to virDomainGetGuestInfo
>
> commit 0cb2d9f05d00497a715352f6ea28cf8fb6921731
> Author: Marc-André Lureau
> Date: Fri Nov 20 22
Hi
On Mon, Nov 30, 2020 at 11:16 PM Michal Privoznik wrote:
>
> On 11/20/20 7:09 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Hi,
> >
> > The following series extends virDomainGetGuestInfo to report disk
> > informati
Hi
On Mon, Nov 30, 2020 at 11:16 PM Michal Privoznik wrote:
>
> On 11/20/20 7:09 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > tools/virsh-domain.c | 6 ++
> > 1 file ch
On Mon, Nov 30, 2020 at 11:16 PM Michal Privoznik wrote:
>
> On 11/20/20 7:09 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > There might be more potential users around, I haven't looked thoroughly.
>
>
> Quick git grep showed two mo
On Fri, Nov 20, 2020 at 10:10 PM wrote:
> From: Marc-André Lureau
>
> Hi,
>
> The following series extends virDomainGetGuestInfo to report disk
> informations
> provided by the new QGA "guest-get-disks" command in QEMU 5.2.
>
> Please review,
>
ping
Hi
On Mon, Nov 9, 2020 at 4:44 PM Michal Privoznik wrote:
>
> I'm stopping my review here. The wrappers are okay, but we really need
> the public API and RPC first. I can work on that if you don't feel like it.
I am on holiday this week and perhaps a few more days. If you have
some free time,
TPM 2 for backend as default for CRB interface
>
Series:
Reviewed-by: Marc-André Lureau
> src/qemu/qemu_domain.c | 12 +---
> src/qemu/qemu_validate.c | 10 ++
> 2 files changed, 15 insertions(+), 7 deletions(-)
>
> --
> 2.17.1
>
>
--
Marc-André Lureau
Hi
On Tue, Apr 21, 2020 at 7:42 PM Michal Privoznik wrote:
>
> On 4/21/20 6:50 PM, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Apr 21, 2020 at 6:04 PM Michal Privoznik
> > wrote:
> >>
> >> On 4/8/20 7:23 PM, marcandre.lur...
Hi
On Tue, Apr 21, 2020 at 6:04 PM Michal Privoznik wrote:
>
> On 4/8/20 7:23 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Don't stop the DBus daemon if a slirp helper failed to start, as it
> > may be shared with other helpers.
>
Hi
On Tue, Apr 7, 2020 at 10:55 AM Pavel Hrdina wrote:
>
> On Mon, Apr 06, 2020 at 11:26:57PM +0200, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Hi,
> >
> > This is a small series that allows basic QEMU VM CGroup support with
> &
Hi
On Tue, Apr 7, 2020 at 11:50 AM Ján Tomko wrote:
>
> On a Monday in 2020, marcandre.lur...@redhat.com wrote:
> >From: Marc-André Lureau
> >
> >Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the
> >presence of machine1 service"), the
Hi
On Wed, Apr 1, 2020 at 6:40 PM Andrea Bolognani wrote:
>
> On Wed, 2020-04-01 at 18:23 +0200, Michal Privoznik wrote:
> > +
> > +
> > + qemu: Support migration with SLIRP interface
> > +
> > +
> > + As libslirp evolves, so does QEMU. The recent
Hi
On Mon, Mar 30, 2020 at 1:54 PM Daniel P. Berrangé wrote:
>
> On Sat, Mar 28, 2020 at 12:38:57AM +0100, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Add an option to ease setting up a VM with existing libvirt qemu.conf.
> >
> > Fi
nd
> `setsid` are not available. So, as before, let's not build them on
> Win32 and make the code more portable by using existing vir* wrappers.
>
> Signed-off-by: Rafael Fonseca
Reviewed-by: Marc-André Lureau
> ---
> src/util/virdaemon.c | 46 +++-
&g
Hi
On Mon, Mar 23, 2020 at 6:48 PM Michal Prívozník wrote:
>
> On 23. 3. 2020 17:36, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Mar 23, 2020 at 5:16 PM Michal Privoznik
> > wrote:
> >>
> >> Now, that our virCommandSetPidFile() is more inte
even though the first command might
> still be running.
>
> Signed-off-by: Michal Privoznik
Reviewed-by: Marc-André Lureau
> ---
> docs/internals/command.html.in | 4 ++-
> src/util/vircommand.c | 56 +-
> tests/commanddata/test4.log
; -}
> +/* If there is a running radvd, kill it. Essentially ignore errors from
> the
> + * following two functions, since there's really no better recovery to be
> + * done than to just push ahead (and that may be exactly what's needed).
> + */
> +if ((radvdpidbase = networkRadvdPidfileBasename(def->name)) &&
> +(pidfile = virPidFileBuildPath(driver->pidDir, radvdpidbase))) {
> +virPidFileForceCleanupPath(pidfile);
> virNetworkObjSetRadvdPid(obj, -1);
> }
> +
> /* now start radvd if it should be started */
> return networkStartRadvd(obj);
> }
> --
> 2.24.1
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
On Mon, Mar 23, 2020 at 5:14 PM Michal Privoznik wrote:
>
> Now, that we know that the slirp helper will have the pidfile
> open and locked we can use virPidFileForceCleanupPath() to kill
> it and unlink the pidfile.
>
> Signed-off-by: Michal Privoznik
Reviewed-by:
On Mon, Mar 23, 2020 at 5:14 PM Michal Privoznik wrote:
>
> Now, that we know that the virtiofsd will have the pidfile open
> and locked we can use virPidFileForceCleanupPath() to kill it and
> unlink the pidfile.
>
> Signed-off-by: Michal Privoznik
Reviewed-by:
virCommandSetErrorFD(cmd, );
>
> @@ -2956,7 +2948,6 @@ qemuProcessStartManagedPRDaemon(virDomainObjPtr vm)
> if (pidfile)
> unlink(pidfile);
> }
> -VIR_FORCE_CLOSE(pidfd);
> VIR_FORCE_CLOSE(errfd);
> return ret;
> }
> --
> 2.24.1
>
--
Marc-André Lureau
18 +
> .../qapi-schema/features-deprecated-type.err | 2 +
> .../qapi-schema/features-deprecated-type.json | 3 +
> .../qapi-schema/features-deprecated-type.out | 0
> tests/qapi-schema/qapi-schema-test.json | 51 +-
> tests/qapi-schema/qapi-schema-test.out| 48 +-
> tests/qapi-schema/test-qapi.py| 26 +-
> 51 files changed, 1393 insertions(+), 762 deletions(-)
> create mode 100644 qapi/compat.json
> create mode 100644 include/qapi/compat-policy.h
> create mode 100644 tests/qapi-schema/features-deprecated-type.err
> create mode 100644 tests/qapi-schema/features-deprecated-type.json
> create mode 100644 tests/qapi-schema/features-deprecated-type.out
>
> --
> 2.21.1
>
--
Marc-André Lureau
On Tue, Feb 25, 2020 at 10:55 AM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> The series "[libvirt] [PATCH v2 00/23] Use a slirp helper process" has
> been merged and partially reverted. Meanwhile, qemu dbus-vmstate
> design has been changed and merged u
Hi
On Tue, Feb 25, 2020 at 12:24 PM Michal Privoznik wrote:
>
> On 2/24/20 4:57 PM, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik
> > wrote:
> >>
> >> On 1/14/20 2:46 PM, marcandre.lur...
Hi
On Tue, Feb 25, 2020 at 12:49 PM Daniel P. Berrangé wrote:
>
> On Tue, Feb 25, 2020 at 10:55:10AM +0100, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > src/qemu/qemu_process.c | 6
Hi
On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote:
>
> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
>
>
> Sorry for late review. I will reply to individual patches with suggested
> changes. I have them locally as a fixup
On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote:
>
> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > m4/virt-driver-qemu.m4 | 6 ++
> >
Hi
On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote:
>
> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Helper processes may have their state migrated with QEMU data stream
> > thanks to the QEMU "dbus-
Hi
On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote:
>
> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > When the helper supports DBus, connect it to the bus and set its ID.
> >
> > If the helper supports mi
Hi
On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote:
>
> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Location of DBus daemon state configuration, socket, pid...
> >
> > Signed-off-by: Marc-André Lureau
&g
Hi
On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote:
>
> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > This code was based on a per-helper instance and peer-to-peer
> > connections. The code that landed in q
Hi
On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote:
>
> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Add a unit to start & stop a private dbus-daemon.
> >
> > The daemon is meant to be started o
Hi
On Thu, Feb 20, 2020 at 10:04 AM Michal Privoznik wrote:
>
> On 1/14/20 2:46 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > This avoids trying to start a dbus-daemon when its already running.
> >
> > Signed-off-by: Marc-
Hi
On Tue, Jan 14, 2020 at 2:47 PM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> The series "[libvirt] [PATCH v2 00/23] Use a slirp helper process" has
> been merged and partially reverted. Meanwhile, qemu dbus-vmstate
> design has been changed and merged u
de 100644 tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
> create mode 100644
> tests/qemuxml2argvdata/tpm-emulator-spapr.ppc64-latest.args
> create mode 100644 tests/qemuxml2argvdata/tpm-emulator-spapr.xml
>
Series:
Reviewed-by: Marc-André Lureau
> --
> 2.17.1
>
Hi
On Tue, Sep 24, 2019 at 2:08 PM Ján Tomko wrote:
>
> On Tue, Sep 24, 2019 at 10:12:19AM +0400, Marc-André Lureau wrote:
> >Hi
> >
> >On Mon, Sep 23, 2019 at 4:35 PM Ján Tomko wrote:
> >>
> >> On Mon, Sep 23, 2019 at 02:44:25PM +0400, marcandre.lur..
Hi
On Mon, Sep 23, 2019 at 4:35 PM Ján Tomko wrote:
>
> On Mon, Sep 23, 2019 at 02:44:25PM +0400, marcandre.lur...@redhat.com wrote:
> >From: Marc-André Lureau
> >
> >Whether a directory is missing or is not readable doesn't make much
> >difference when po
Hi
On Sat, Sep 21, 2019 at 1:05 AM Cole Robinson wrote:
>
> On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Similar to the qemu_tpm.c, add a unit with a few functions to
> > start/stop and setup the cgroup of the exter
Hi
On Mon, Sep 9, 2019 at 2:49 PM Ján Tomko wrote:
>
> On Mon, Sep 09, 2019 at 11:23:59AM +0200, Michal Privoznik wrote:
> >On 9/6/19 5:55 PM, Ján Tomko wrote:
> >>[cc-ing Marc-André]
> >>
> >>On Fri, Sep 06, 2019 at 04:25:19PM +0200, Michal Privoznik wrote:
> >>>The qemu side is not merged in
, it may be revealing a transient bug in
virDBusMessageIterDecode() rather than libdbus. It would be worth to
have VIR_DEBUG() output from the failing test.
For now:
Reviewed-by: Marc-André Lureau
> ---
> src/util/virdbus.c | 18 ++
> src/util/virdbus.h
Hi
On Fri, Aug 23, 2019 at 9:05 PM Cole Robinson wrote:
>
> On 8/23/19 12:21 PM, Cole Robinson wrote:
> > From: Marc-André Lureau
> >
> > vhost-user-gpu helper may accept --render-node option to specify on
> > which GPU should the renderning be done.
> >
>
Hi
On Tue, Aug 27, 2019 at 12:29 PM Ján Tomko wrote:
>
> On Fri, Aug 23, 2019 at 12:21:53PM -0400, Cole Robinson wrote:
> >From: Marc-André Lureau
> >
> >Add qemuVhostUserFetchConfigs() to discover vhost-user helpers.
> >
> >qemuVhostUserFillDomainGPU() wil
Hi
On Tue, Aug 27, 2019 at 12:30 AM Cole Robinson wrote:
>
> On 8/23/19 12:21 PM, Cole Robinson wrote:
> > From: Marc-André Lureau
> >
> > Add qemuVhostUserFetchConfigs() to discover vhost-user helpers.
> >
> > qemuVhostUserFillDomainGPU() wil
Hi
On Tue, Aug 27, 2019 at 1:17 PM Ján Tomko wrote:
>
> On Fri, Aug 23, 2019 at 12:21:58PM -0400, Cole Robinson wrote:
> >From: Marc-André Lureau
> >
> >For each vhost-user GPUs,
> >- build a socket chardev, and pass the vhost-user socket to it
> >- build a v
Hi
On Tue, Aug 27, 2019 at 11:19 AM Ján Tomko wrote:
>
> On Fri, Aug 23, 2019 at 12:51:56PM -0400, Cole Robinson wrote:
> >On 8/23/19 12:21 PM, Cole Robinson wrote:
> >> From: Marc-André Lureau
> >>
> >> Accept a new attribute
ontextPtr logCtxt,
> * stored and we can remove directories and files in case of domain XML
> * changes.
> */
> -int
> +static int
> qemuExtDevicesInitPaths(virQEMUDriverPtr driver,
> virDomainDefPtr def)
> {
> diff --git a/src/qemu/qemu_extdevice.h b/src/qemu/qemu_extdevice.h
> index 5a53c79f38..039b3e60dd 100644
> --- a/src/qemu/qemu_extdevice.h
> +++ b/src/qemu/qemu_extdevice.h
> @@ -54,6 +54,3 @@ bool qemuExtDevicesHasDevice(virDomainDefPtr def);
> int qemuExtDevicesSetupCgroup(virQEMUDriverPtr driver,
>virDomainDefPtr def,
>virCgroupPtr cgroup);
> -
> -int qemuExtDevicesInitPaths(virQEMUDriverPtr driver,
> -virDomainDefPtr def);
> --
> 2.19.2
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
NULL};
> +
> +ret = virResctrlMonitorGetStats(monitor, features, stats, nstats);
> +
> +return ret;
> }
> diff --git a/src/util/virresctrl.h b/src/util/virresctrl.h
> index 4dabb9c..9ef51b7 100644
> --- a/src/util/virresctrl.h
> +++ b/src/util/virresctrl.h
> @@ -236,6 +236,12 @@ int
> virResctrlMonitorRemove(virResctrlMonitorPtr monitor);
>
> int
> +virResctrlMonitorGetStats(virResctrlMonitorPtr monitor,
> + const char **resources,
> + virResctrlMonitorStatsPtr **stats,
> + size_t *nstats);
> +
> +int
> virResctrlMonitorGetCacheOccupancy(virResctrlMonitorPtr monitor,
> virResctrlMonitorStatsPtr **stats,
> size_t *nstats);
> --
> 2.7.4
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Hi
On Wed, Jun 5, 2019 at 2:32 PM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> This series of patches adds support for running virtio GPUs in
> seperate processes, thanks to vhost-user backend.
>
> The QEMU support landed for 4.1. There are several benefits
he actual state will be overwritten by the in-
> coming state. So we have to pass an indicator for incomingMigration
> all the way to the command line parameter generation for swtpm_setup.
>
> Signed-off-by: Stefan Berger
iirc, I needed to pass it down as well in my slirp-helper serie
Hi!
ping
On Wed, Jun 5, 2019 at 2:32 PM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> This series of patches adds support for running virtio GPUs in
> seperate processes, thanks to vhost-user backend.
>
> The QEMU support landed for 4.1. There are several benefits
that looks fine,
Reviewed-by: Marc-André Lureau
> ---
> src/libvirt_private.syms | 1 +
> src/util/vircommand.c| 62
> src/util/vircommand.h| 5
> 3 files changed, 68 insertions(+)
>
> diff --git a/src/libvirt_p
On Wed, Jul 10, 2019 at 10:12 PM Stefan Berger
wrote:
>
> To avoid blocking on a write on a pipe that the receiving process
> does not read from, write only MAX_PIPE_FEED_BYTES into the pipe
> so that we can serve other pipes as well.
why not simply use non-blocking write?
>
> Signed-off-by:
On Wed, Jul 10, 2019 at 10:12 PM Stefan Berger
wrote:
>
> Signed-off-by: Stefan Berger
Could you include a test?
> ---
> src/util/vircommand.c | 70 ++-
> 1 file changed, 69 insertions(+), 1 deletion(-)
>
> diff --git a/src/util/vircommand.c
On Wed, Jul 10, 2019 at 10:12 PM Stefan Berger
wrote:
>
> Convert the struct pollfd *fds to be allocated rather than residing
> on the stack.
>
why? give some context to the commit message. thanks
> Signed-off-by: Stefan Berger
> ---
> src/util/vircommand.c | 5 -
> 1 file changed, 4
> With
>the emulator device type each guest gets its own private TPM.
>'emulator' since 4.5.0
> + The state of the TPM emulator can be encrypted by providing an
> + encryption element.
> + 'encryption' since 5.5.0
here too, 5.6.0 I presume
Revi
be used to set
> + a more secure secret without using printable/readable characters.
> +
> +
> +
> +# MYSECRET=`printf %s "open sesame" | base64`
> +# virsh secret-set-value 6dd3e4a5-1d76-44ce-961f-f119f5aad935 $MYSECRET
> Secret value set
>
>
> --
> 2.20.1
>
Reviewed-by: Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Allow vTPM state encryption when swtpm_setup and swtpm support
> passing a passphrase using a file descriptor.
>
> This patch enables the encryption of the vTPM state only. It does
> not encrypt the state during migration, so the destination
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Run 'swtpm socket --print-capabilities' and
> 'swtpm_setup --print-capabilities' to get the JSON object of the
> features the programs are supporting and parse them into a bitmap.
>
> Signed-off-by: Stefan Berger
> ---
>
move:
Reviewed-by: Marc-André Lureau
> ---
> src/libvirt_private.syms | 4 ++
> src/qemu/qemu_tpm.c | 83
> src/tpm/virtpm.c | 91
> src/tpm/virtpm.h | 5 +++
> 4 files changed
Hi
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Check whether previously found executables were updated and if
> so look for them again. This helps to use updated features of
> swtpm and its tools upon updating them.
>
> Signed-off-by: Stefan Berger
Reviewed-by:
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> po/POTFILES | 2 +-
> src/Makefile.am | 1 +
> src/conf/Makefile.inc.am | 1 +
> src/libvirt_private.syms | 8
> src/qemu/Makefile.inc.am | 1 +
>
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Refactor virTPMEmulatorInit to use a loop with parameters. This allows
> for easier extension later on.
>
> Signed-off-by: Stefan Berger
for the refactoring,
Reviewed-by: Marc-André Lureau
> ---
>
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> The QEMU command line does not change when TPM state is encrypted
> compared to when it is plain.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> .../tpm-emulator-tpm2-enc.x86
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Extend the TPM XML schema with support for an encryption node.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> docs/schemas/domaincommon.rng | 30 ++
> 1 file c
On Tue, Jul 9, 2019 at 9:25 PM Stefan Berger wrote:
>
> Add a test case for the TPM XML encryption parser and formatter.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> .../tpm-emulator-tpm2-enc.xml | 34 +
>
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Add VIR_STORAGE_ENCRYPTION_FORMAT_VTPM with string 'vtpm' for
> support of encrypting vTPM storage.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu_block.c
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Add an already existing test case tpm-emulator-tpm2 to qemuxml2xmltest.c
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> tests/qemuxml2xmltest.c | 1 +
> 1 file changed, 1 insertion(+)
&
On Tue, Jul 9, 2019 at 9:24 PM Stefan Berger wrote:
>
> Extend the TPM device XML parser and XML generator with emulator
> state encryption support.
>
> Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
> ---
> src/co
ndex fd93703424..595583346a 100644
> --- a/tests/secretxml2xmltest.c
> +++ b/tests/secretxml2xmltest.c
> @@ -80,6 +80,7 @@ mymain(void)
> DO_TEST("usage-ceph");
> DO_TEST("usage-iscsi");
> DO_TEST("usage-tls");
> +DO_TEST("usage
quot;util.secret");
>
> VIR_ENUM_IMPL(virSecretUsage,
>VIR_SECRET_USAGE_TYPE_LAST,
> - "none", "volume", "ceph", "iscsi", "tls",
> + "none", "volume", "ceph", "iscsi", "tls", "vtpm",
> );
>
> void
> --
> 2.20.1
>
Looks good, but docs/schemas/secret.rng change should probably be part
of this patch.
other than that,
Reviewed-by: Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
, or we could somehow
teach qemu to do it, ex "-savevm-external chardev", which would talk a
simple protocol to read/save the state.
Other ideas? thanks
--
Marc-André Lureau
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Hi
On Thu, Apr 25, 2019 at 3:22 PM Michal Privoznik wrote:
>
> On 4/18/19 3:24 PM, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > I am throwing this away for discussions, and early feedback.
> >
> > With the upcoming release of
1 - 100 of 523 matches
Mail list logo
