[libvirt] [PATCH v2 2/4] libxl: add support for CPUID features policy

2017-07-03 Thread Marek Marczykowski-Górecki
uot;required" policy (there is only "force") and also between "forbid" and "disable" (there is only "disable"). So, merge them appropriately. If anything, "require" and "forbid" should be enforced outside of specific driver. Signed-o

[libvirt] [PATCH v2 4/4] tests: check CPU features handling in libxl driver

2017-07-03 Thread Marek Marczykowski-Górecki
Test enabling/disabling individual CPU features and also setting nested HVM support, which is also controlled by CPU features node. Signed-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com> --- Changes since v1: - rewritten to Jim's test suite for libxl_domain_config gen

[libvirt] [PATCH v2 0/4] Add setting CPU features (CPUID) with libxenlight driver.

2017-07-03 Thread Marek Marczykowski-Górecki
Tests (patches 3 and 4) depends on libxl_domain_config test suite: https://www.redhat.com/archives/libvir-list/2017-February/msg01477.html But first two patches can be applied independently. Marek Marczykowski-Górecki (4): cpu: define sub-leaf 0 for leaf 7 in cpu_map.xml libxl: add support

[libvirt] [PATCH v2 3/4] tests: switch libxlxml2domconfig test to use testXLInintCaps

2017-07-03 Thread Marek Marczykowski-Górecki
As name suggests, it's a better choice for libxl test. Important differences: - advertise x86_64 guests support - initialize host CPU caps Signed-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com> --- Changes since v1: - new patch, applicable over Jim's test

[libvirt] [PATCH v2] libxl: Add a test suite for libxl_domain_config generator

2017-07-01 Thread Marek Marczykowski-Górecki
a simple way to account for any changes or additions to the json representation across Xen releases. Signed-off-by: Jim Fehlig <jfeh...@suse.com> [update to v3.5.0-rc1, improve error reporting] Signed-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com> --- m4/virt-dri

Re: [libvirt] [PATCH 0/3] libxl: Add a test suite for libxl_domain_config generator

2017-07-01 Thread Marek Marczykowski-Górecki
nt to add more tests using this framework (see "Add setting CPU features (CPUID) with libxenlight driver" thread). Is there anything I can do to make it happen? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q:

Re: [libvirt] [PATCH 2/3] libxl: add support for CPUID features policy

2017-06-29 Thread Marek Marczykowski-Górecki
On Thu, Jun 29, 2017 at 10:21:11AM +0100, Joao Martins wrote: > On 06/29/2017 09:39 AM, Marek Marczykowski-Górecki wrote: > > On Thu, Jun 29, 2017 at 10:04:42AM +0200, Jiri Denemark wrote: > >> On Thu, Jun 29, 2017 at 03:11:42 +0200, Marek Marczykowski-Górecki wrote: >

Re: [libvirt] [PATCH 2/3] libxl: add support for CPUID features policy

2017-06-29 Thread Marek Marczykowski-Górecki
On Thu, Jun 29, 2017 at 11:00:35AM +0200, Jiri Denemark wrote: > On Thu, Jun 29, 2017 at 10:39:26 +0200, Marek Marczykowski-Górecki wrote: > > On Thu, Jun 29, 2017 at 10:04:42AM +0200, Jiri Denemark wrote: > > > On Thu, Jun 29, 2017 at 03:11:42 +0200, Marek Marczykowski-Górecki

Re: [libvirt] [PATCH 3/3] tests: check domain XML to libxl structures conversion

2017-06-29 Thread Marek Marczykowski-Górecki
On Thu, Jun 29, 2017 at 10:06:39AM +0100, Joao Martins wrote: > On 06/29/2017 02:11 AM, Marek Marczykowski-Górecki wrote: > > libxl contains a method to dump libxl_domain_config in json format, > > which is really convenient for tests. Unfortunately it require > > libxl_c

Re: [libvirt] [PATCH 2/3] libxl: add support for CPUID features policy

2017-06-29 Thread Marek Marczykowski-Górecki
On Thu, Jun 29, 2017 at 10:04:42AM +0200, Jiri Denemark wrote: > On Thu, Jun 29, 2017 at 03:11:42 +0200, Marek Marczykowski-Górecki wrote: > > Set CPU features in appropriate libxl structure. > > Use old "xend" syntax, because it allow control over any bit and lib

Re: [libvirt] [PATCH 1/3] cpu: define sub-leaf 0 for leaf 7 in cpu_map.xml

2017-06-29 Thread Marek Marczykowski-Górecki
On Thu, Jun 29, 2017 at 09:51:58AM +0200, Jiri Denemark wrote: > On Thu, Jun 29, 2017 at 03:11:41 +0200, Marek Marczykowski-Górecki wrote: > > CPUID leaf 7 is sub-leaf aware. Add missing attribute. > > --- > > src/cpu/cpu_map.xml | 58 +++--

[libvirt] [PATCH 3/3] tests: check domain XML to libxl structures conversion

2017-06-28 Thread Marek Marczykowski-Górecki
a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Author: Daniel P. Berrange <berra...@redhat.com> + * Author: Kiarie Kahurani <davidkiar...@gmail.com> + * Author: Marek Marczykowski-Górecki <marm

[libvirt] [PATCH 1/3] cpu: define sub-leaf 0 for leaf 7 in cpu_map.xml

2017-06-28 Thread Marek Marczykowski-Górecki
CPUID leaf 7 is sub-leaf aware. Add missing attribute. --- src/cpu/cpu_map.xml | 58 +++--- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 29b5b59..037a057 100644 --- a/src/cpu/cpu_map.xml +++

[libvirt] [PATCH 2/3] libxl: add support for CPUID features policy

2017-06-28 Thread Marek Marczykowski-Górecki
Set CPU features in appropriate libxl structure. Use old "xend" syntax, because it allow control over any bit and libvirt already have API for translating features to appropriate cpuid bits. And also features naming in libxl do not match the one of libvirt in multiple cases. Side effect is that

[libvirt] [PATCH 0/3] Add setting CPU features (CPUID) with libxenlight driver.

2017-06-28 Thread Marek Marczykowski-Górecki
Marek Marczykowski-Górecki (3): cpu: define sub-leaf 0 for leaf 7 in cpu_map.xml libxl: add support for CPUID features policy tests: check domain XML to libxl structures conversion src/cpu/cpu_map.xml| 58 +-- src/libxl/libxl_conf.c | 139 - src/libxl

[libvirt] [PATCH] pci: fix link maximum speed detection

2017-05-16 Thread Marek Marczykowski-Górecki
Commit 8e09663 "pci: recognize/report GEN4 (PCIe 4.0) card 16GT/s Link speed" introduced another speed into enum, but mistakenly also altered field width, so one bit of link width was included there. Signed-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com&g

Re: [libvirt] [PATCH v3 0/7] Provide an standard asyncio event loop impl

2017-04-07 Thread Marek Marczykowski-Górecki
the event test is only validated with the KVM driver, but > > that said > > I thought the Xen driver would get our default nework driver activated > > automatically, > > so I'm surprised you see that. > > I don't know, maybe this is caused by our setup. Fo

Re: [libvirt] [PATCH 1/2] libxl: add support for PVH

2016-09-16 Thread Marek Marczykowski-Górecki
On Fri, Sep 16, 2016 at 04:39:23PM -0600, Jim Fehlig wrote: > On 08/05/2016 12:05 PM, Marek Marczykowski-Górecki wrote: > > Since this is something between PV and HVM, it makes sense to put the > > setting in place where domain type is specified. > > To enable it, use It

[libvirt] [PATCH 2/2] libxl: set shadow memory for any guest type, not only HVM

2016-08-05 Thread Marek Marczykowski-Górecki
Otherwise starting PVH guest will result in "arch_setup_bootlate: mapping shared_info failed (pfn=..., rc=-1, errno: 12): Internal error". After this change the behaviour is the same as in `xl`. Signed-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com>

[libvirt] [PATCH 1/2] libxl: add support for PVH

2016-08-05 Thread Marek Marczykowski-Górecki
-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com> --- src/libxl/libxl_capabilities.c | 40 +++- src/libxl/libxl_conf.c | 2 ++ src/libxl/libxl_driver.c | 6 -- 3 files changed, 37 insertions(+), 11 deletions(-) diff

Re: [libvirt] [PATCH] libxl: open libxl log stream with libvirtd log_level

2015-11-11 Thread Marek Marczykowski-Górecki
On Wed, Nov 11, 2015 at 04:04:22PM +, Daniel P. Berrange wrote: > On Wed, Nov 11, 2015 at 04:57:59PM +0100, Marek Marczykowski-Górecki wrote: > > On Tue, Sep 15, 2015 at 11:21:00AM -0600, Jim Fehlig wrote: > > > Daniel P. Berrange wrote: > > > > On Tue, Sep 15,

Re: [libvirt] [PATCH] libxl: open libxl log stream with libvirtd log_level

2015-11-11 Thread Marek Marczykowski-Górecki
ibrary if desired, eg > > > > static virLogSource virLogLibXL = { > > .name = "libxl.libxl_library", > > > > } > > > > LIBVIRT_LOG_FILTERS="1:libxl_library" > > > > Ah, good idea. I'll look into it. Is it done anywh

Re: [libvirt] [PATCH 8/9] libxl: pass cmdline to HVM guests

2015-03-20 Thread Marek Marczykowski-Górecki
On Fri, Mar 20, 2015 at 02:11:46PM -0600, Jim Fehlig wrote: Wei Liu wrote: On Fri, Mar 20, 2015 at 11:18:36AM -0600, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c

Re: [libvirt] [PATCH 9/9] tests: add some simple libxl XML-XML tests

2015-03-20 Thread Marek Marczykowski-Górecki
On Fri, Mar 20, 2015 at 02:56:11PM -0600, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Handle features supported only on xen: driver domains, qemu in stubdomain. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com [...] diff --git a/tests

Re: [libvirt] [PATCH 7/9] libxl: Stubdom emulator type

2015-03-13 Thread Marek Marczykowski-Górecki
On Fri, Mar 13, 2015 at 02:09:34PM -0600, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Xen have feature of having device model in separate domain (called stub domain). Add stubdomain element to allow selecting such configuration. Emulator path is still used for qemu running in dom0

[libvirt] [PATCH 5/9] libxl: prevent attaching multiple netdevs with the same MAC

2015-03-06 Thread Marek Marczykowski-Górecki
It will not be possible to detach such device later. Also improve logging in such cases. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 15 +++ 1 file changed, 15 insertions(+) Changes in v4: - use virDomainHasNet instead

[libvirt] [PATCH v4 0/9] A bunch of extensions to libxl driver

2015-03-06 Thread Marek Marczykowski-Górecki
This are some additional features to libxl driver. Some of them require change in domain config structures/syntax. Details described with each patch. I've dropped patches already applied in this version. Patches for stubdom support in xenconfig and some more tests will be later. Marek

[libvirt] [PATCH 2/9] xenconfig: add support for multiple USB devices syntax

2015-03-06 Thread Marek Marczykowski-Górecki
In Xen=4.3, libxl supports new syntax for USB devices: usbdevice=[ DEVICE, DEVICE, ... ] Add support for that in xenconfig driver. When only one device is defined, keep using old syntax for backward compatibility. Adjust tests for changed options order. Signed-off-by: Marek Marczykowski-Górecki

[libvirt] [PATCH 6/9] libxl: support domain config modification in virDomainRestoreFlags

2015-03-06 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 1313d2e..d7f5dac 100644 --- a/src/libxl

[libvirt] [PATCH 1/9] libxl: add tablet/mouse input device support

2015-03-06 Thread Marek Marczykowski-Górecki
From: Marek Marczykowski marma...@invisiblethingslab.com Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 44 1 file changed, 44 insertions(+) Changes in v2: - rebase on 1.2.12+ - multiple

[libvirt] [PATCH 9/9] tests: add some simple libxl XML-XML tests

2015-03-06 Thread Marek Marczykowski-Górecki
Handle features supported only on xen: driver domains, qemu in stubdomain. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- tests/Makefile.am | 9 +- tests/domainschematest | 2 +- tests/xlxml2xmldata

[libvirt] [PATCH 3/9] tests: xenconfig: test for multiple USB devices and other HVM options

2015-03-06 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- tests/xlconfigdata/test-fullvirt-multiusb.cfg | 29 tests/xlconfigdata/test-fullvirt-multiusb.xml | 48 +++ tests/xlconfigtest.c | 1 + 3 files changed

[libvirt] [PATCH 8/9] libxl: pass cmdline to HVM guests

2015-03-06 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 8 1 file changed, 8 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 8ec3c75..d78d2b2 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c

[libvirt] [PATCH 4/9] conf: add virDomainHasNet

2015-03-06 Thread Marek Marczykowski-Górecki
virDomainNetFindIdx no longer returns info whether device was not found, or there was multiple matches. Additionally it already handle error reporting. Introduce virDomainHasNet which does a simple task, without implicit error reporting. Signed-off-by: Marek Marczykowski-Górecki marma

[libvirt] [PATCH 7/9] libxl: Stubdom emulator type

2015-03-06 Thread Marek Marczykowski-Górecki
Xen have feature of having device model in separate domain (called stub domain). Add stubdomain element to allow selecting such configuration. Emulator path is still used for qemu running in dom0 (if any). Libxl currently do not allow to select stubdomain path. Signed-off-by: Marek Marczykowski

Re: [libvirt] [PATCH 09/10] libxl: Stubdom emulator type

2015-03-05 Thread Marek Marczykowski-Górecki
On Wed, Mar 04, 2015 at 08:34:26PM +, Daniel P. Berrange wrote: On Thu, Feb 19, 2015 at 10:19:22PM +0100, Marek Marczykowski-Górecki wrote: On Thu, Feb 19, 2015 at 01:45:52PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Xen have feature of having device model

Re: [libvirt] [PATCH 09/10] libxl: Stubdom emulator type

2015-03-04 Thread Marek Marczykowski-Górecki
On Thu, Feb 19, 2015 at 10:19:22PM +0100, Marek Marczykowski-Górecki wrote: On Thu, Feb 19, 2015 at 01:45:52PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Xen have feature of having device model in separate domain (called stub domain). Add a 'type' attribute to 'emulator

Re: [libvirt] [PATCH 06.1/10] xenconfig: add support for multiple USB devices syntax

2015-02-20 Thread Marek Marczykowski-Górecki
On Fri, Feb 20, 2015 at 04:10:47PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: In Xen=4.3, libxl supports new syntax for USB devices: usbdevice=[ DEVICE, DEVICE, ... ] Add support for that in xenconfig driver. When only one device is defined, keep using old syntax

Re: [libvirt] [PATCHv3 06/10] libxl: add tablet/mouse input device support

2015-02-20 Thread Marek Marczykowski-Górecki
On Fri, Feb 20, 2015 at 03:45:02PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: From: Marek Marczykowski marma...@invisiblethingslab.com Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- Changes in v2: - rebase on 1.2.12+ - multiple

Re: [libvirt] [PATCH 07/10] libxl: prevent attaching multiple netdevs with the same MAC

2015-02-19 Thread Marek Marczykowski-Górecki
On Thu, Feb 19, 2015 at 11:43:15AM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: It will not be possible to detach such device later. Also improve logging in such cases. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl

Re: [libvirt] [PATCH 08/10] libxl: support domain config modification in virDomainRestoreFlags

2015-02-19 Thread Marek Marczykowski-Górecki
On Thu, Feb 19, 2015 at 11:59:38AM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- There was a discussion about calling virDomainDefCheckABIStability. The use case I have for this is to start

Re: [libvirt] [PATCH 07/10] libxl: prevent attaching multiple netdevs with the same MAC

2015-02-19 Thread Marek Marczykowski-Górecki
On Thu, Feb 19, 2015 at 01:58:02PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: On Thu, Feb 19, 2015 at 11:43:15AM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: It will not be possible to detach such device later. Also improve logging in such cases

Re: [libvirt] [PATCH 09/10] libxl: Stubdom emulator type

2015-02-19 Thread Marek Marczykowski-Górecki
On Thu, Feb 19, 2015 at 01:45:52PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Xen have feature of having device model in separate domain (called stub domain). Add a 'type' attribute to 'emulator' element to allow selecting such a configuration. Or maybe 'mode', describing

Re: [libvirt] [PATCH 07/10] libxl: prevent attaching multiple netdevs with the same MAC

2015-02-19 Thread Marek Marczykowski-Górecki
On Thu, Feb 19, 2015 at 03:10:13PM -0700, Jim Fehlig wrote: Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: On Thu, Feb 19, 2015 at 01:58:02PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: On Thu, Feb 19, 2015 at 11:43:15AM -0700, Jim

Re: [libvirt] [PATCH 06/10] libxl: add tablet/mouse input device support

2015-02-19 Thread Marek Marczykowski-Górecki
On Wed, Feb 18, 2015 at 08:22:12PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- Changes in v2: - rebase on 1.2.12+ - multiple devices support src/libxl/libxl_conf.c | 48

[libvirt] [PATCH 06.1/10] xenconfig: add support for multiple USB devices syntax

2015-02-19 Thread Marek Marczykowski-Górecki
In Xen=4.3, libxl supports new syntax for USB devices: usbdevice=[ DEVICE, DEVICE, ... ] Add support for that in xenconfig driver. When only one device is defined, keep using old syntax for backward compatibility. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src

[libvirt] [PATCHv3 06/10] libxl: add tablet/mouse input device support

2015-02-19 Thread Marek Marczykowski-Górecki
From: Marek Marczykowski marma...@invisiblethingslab.com Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- Changes in v2: - rebase on 1.2.12+ - multiple devices support Changes in v3: - reduce code duplication src/libxl/libxl_conf.c | 44

[libvirt] [PATCH 06.2/10] tests: xenconfig: test for multiple USB devices and other HVM options

2015-02-19 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- tests/xlconfigdata/test-fullvirt-multiusb.cfg | 29 tests/xlconfigdata/test-fullvirt-multiusb.xml | 48 +++ tests/xlconfigtest.c | 1 + 3 files changed

Re: [libvirt] [PATCH 07/10] libxl: prevent attaching multiple netdevs with the same MAC

2015-02-19 Thread Marek Marczykowski-Górecki
On Thu, Feb 19, 2015 at 03:58:30PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: On Thu, Feb 19, 2015 at 03:10:13PM -0700, Jim Fehlig wrote: Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: On Thu, Feb 19, 2015 at 01:58:02PM -0700, Jim Fehlig wrote: Marek Marczykowski

[libvirt] [PATCHv4 02/10] conf: support backend domain name in disk and network devices

2015-02-19 Thread Marek Marczykowski-Górecki
From: Marek Marczykowski marma...@invisiblethingslab.com At least Xen supports backend drivers in another domain (aka driver domain). This patch introduces XML config option for such setting as 'domain' attribute of 'source' element. Verification its content is left for the driver. In the future

[libvirt] [PATCHv4 03/10] libxl: support backend domain setting for disk and net devices

2015-02-19 Thread Marek Marczykowski-Górecki
From: Marek Marczykowski marma...@invisiblethingslab.com This implement handling of backenddomain name=''/ parameter introduced in previous patch. Works on Xen = 4.3, because only there libxl supports setting backend domain by name, not XID. Signed-off-by: Marek Marczykowski-Górecki marma

Re: [libvirt] [PATCH 07/10] libxl: prevent attaching multiple netdevs with the same MAC

2015-02-19 Thread Marek Marczykowski-Górecki
On Thu, Feb 19, 2015 at 06:13:01PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: On Thu, Feb 19, 2015 at 03:58:30PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: On Thu, Feb 19, 2015 at 03:10:13PM -0700, Jim Fehlig wrote: Jim Fehlig wrote

Re: [libvirt] [PATCHv2 05/10] libxl: pass ipaddr to libxl toolstack

2015-02-09 Thread Marek Marczykowski-Górecki
On Thu, Feb 05, 2015 at 03:36:17PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Do not silently ignore its value. LibXL support only one address, so refuse multiple IPs. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c

Re: [libvirt] [PATCHv2 04/10] libxl: fill HVM SDL and VNC settings based on graphics/ entries

2015-02-09 Thread Marek Marczykowski-Górecki
On Sat, Feb 07, 2015 at 12:22:51PM +0100, Marek Marczykowski-Górecki wrote: On Thu, Feb 05, 2015 at 02:53:44PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Vfb entries in domain config are used only by PV drivers. Qemu parameters are build based on b_info struct. So fill

Re: [libvirt] [PATCH 04/10] libxl: fill HVM SDL and VNC settings based on graphics/ entries

2015-02-07 Thread Marek Marczykowski-Górecki
On Thu, Feb 05, 2015 at 02:53:44PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Vfb entries in domain config are used only by PV drivers. Qemu parameters are build based on b_info struct. So fill it with the same data as vfb entries (actually the first one

Re: [libvirt] [PATCH 02/10] conf: support backend domain name in disk and network devices

2015-02-06 Thread Marek Marczykowski-Górecki
On Fri, Feb 06, 2015 at 05:36:40PM +, Daniel P. Berrange wrote: On Thu, Feb 05, 2015 at 06:17:08AM +0100, Marek Marczykowski-Górecki wrote: At least Xen supports backend drivers in another domain (aka driver domain). This patch introduces XML config option for such setting as 'domain

Re: [libvirt] [PATCH 02/10] conf: support backend domain name in disk and network devices

2015-02-06 Thread Marek Marczykowski-Górecki
On Fri, Feb 06, 2015 at 08:03:43PM +, Daniel P. Berrange wrote: On Fri, Feb 06, 2015 at 07:11:40PM +0100, Marek Marczykowski-Górecki wrote: On Fri, Feb 06, 2015 at 05:36:40PM +, Daniel P. Berrange wrote: On Thu, Feb 05, 2015 at 06:17:08AM +0100, Marek Marczykowski-Górecki wrote

Re: [libvirt] [PATCH 01/10] libxl: update dom-id in libxlDomainCreateWithFlags

2015-02-05 Thread Marek Marczykowski-Górecki
On Thu, Feb 05, 2015 at 02:25:41PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Otherwise domainCreateWithFlags via remote returns -1 as domid. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 3 +++ 1 file changed

[libvirt] [PATCH 02/10] conf: support backend domain name in disk and network devices

2015-02-04 Thread Marek Marczykowski-Górecki
objects), but for now libxl doesn't have support for PVUSB. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- Changes in v2: - describe in docs/formatdomain.html.in - enforce empty domain tag (only 'name' attribute allowed) Changes in v3: - change domain name='xx

[libvirt] [PATCH 05/10] libxl: pass ipaddr to libxl toolstack

2015-02-04 Thread Marek Marczykowski-Górecki
Do not silently ignore its value. LibXL support only one address, so refuse multiple IPs. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 5 + src/libxl/libxl_domain.c | 11 +++ 2 files changed, 16 insertions(+) diff --git

[libvirt] [PATCH 10/10] tests: add some simple libxl XML-XML tests

2015-02-04 Thread Marek Marczykowski-Górecki
Handle features supported only on xen: driver domains, qemu in stubdomain. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- tests/Makefile.am | 9 +- tests/domainschematest | 2 +- tests/xlxml2xmldata

[libvirt] [PATCH 00/10] A bunch of extensions to libxl driver

2015-02-04 Thread Marek Marczykowski-Górecki
This are some additional features to libxl driver. Some of them require change in domain config structures/syntax. Details described with each patch. Actually this is next iteration of a few years old patch series... Marek Marczykowski-Górecki (10): libxl: update dom-id

[libvirt] [PATCH 09/10] libxl: Stubdom emulator type

2015-02-04 Thread Marek Marczykowski-Górecki
-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- I think it would be good idea to introduce the same change to capabilities XML. The problem is I can't include domain_conf.h from capabilities.h, so probably that enum declaration needs to be moved to capabilities.h. Is it the right

[libvirt] [PATCH 08/10] libxl: support domain config modification in virDomainRestoreFlags

2015-02-04 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- There was a discussion about calling virDomainDefCheckABIStability. The use case I have for this is to start multiple domains from the same savefile. This require changing: - UUID - name - IP address Those

[libvirt] [PATCH 06/10] libxl: add tablet/mouse input device support

2015-02-04 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- Changes in v2: - rebase on 1.2.12+ - multiple devices support src/libxl/libxl_conf.c | 48 1 file changed, 48 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src

[libvirt] [PATCH 03/10] libxl: support backend domain setting for disk and net devices

2015-02-04 Thread Marek Marczykowski-Górecki
This implement handling of source domain=''/ parameter introduced in previous patch. Lookup on domain name (to get domain ID) requires libxlDriverPrivate object, so it must be passed down to libxlMakeDisk and libxlMakeNet from top level callers. Signed-off-by: Marek Marczykowski-Górecki marma

[libvirt] [PATCH 04/10] libxl: fill HVM SDL and VNC settings based on graphics/ entries

2015-02-04 Thread Marek Marczykowski-Górecki
was always enabled). Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 100 - 1 file changed, 74 insertions(+), 26 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index

[libvirt] [PATCH 01/10] libxl: update dom-id in libxlDomainCreateWithFlags

2015-02-04 Thread Marek Marczykowski-Górecki
Otherwise domainCreateWithFlags via remote returns -1 as domid. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index c95b387..ce3a99b

[libvirt] [PATCH 07/10] libxl: prevent attaching multiple netdevs with the same MAC

2015-02-04 Thread Marek Marczykowski-Górecki
It will not be possible to detach such device later. Also improve logging in such cases. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 41 +++-- 1 file changed, 39 insertions(+), 2 deletions(-) diff

Re: [libvirt] [PATCH v2 06/14] conf: virDomainObjListRemoveLocked function

2013-06-20 Thread Marek Marczykowski-Górecki
On 20.06.2013 17:34, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: While iterating with virDomainObjListForEach it is safe to remove current element. But while iterating, 'doms' lock is already taken, so can't use standard virDomainObjListRemove. So introduce

Re: [libvirt] [PATCH v2 10/14] libxl: support domain config modification in virDomainRestoreFlags

2013-06-20 Thread Marek Marczykowski-Górecki
On 20.06.2013 23:25, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/libxl/libxl_driver.c b

[libvirt] Memory access API

2013-06-18 Thread Marek Marczykowski-Górecki
pages to dom0 address space, without copy. I know that not every hypervisor supports it, but it is useful to build a high-performance communication channel on top of it. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab signature.asc Description: OpenPGP digital signature -- libvir

[libvirt] [PATCH v3] conf: support backend domain name in disk and network devices

2013-06-18 Thread Marek Marczykowski-Górecki
objects), but for now libxl doesn't have support for PVUSB. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- Changes in v2: - describe in docs/formatdomain.html.in - enforce empty domain tag (only 'name' attribute allowed) Changes in v3: - fix grammar of the documentation

[libvirt] [PATCH v3] libxl: populate xenstore memory entries at startup, handle dom0_mem

2013-06-18 Thread Marek Marczykowski-Górecki
will be before any domain startup. Also prevent automatic memory management if dom0_mem= option passed to xen hypervisor - it is known to be incompatible with autoballoon. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- Changes in v2: - disable autoballoon when dom0_mem

Re: [libvirt] [PATCH v2 1/2] add hostdev passthrough common library

2013-06-12 Thread Marek Marczykowski-Górecki
='kvm/vfio/xen'/ setting, call virPCIDeviceSetStubDriver to set stub driver. For libxl driver, a driver name='xen' / is needed. The new xen allowed name needs to be added to docs/schemas/domaincommon.rng. * rebase to current libvirt changes -- Best Regards, Marek Marczykowski-Górecki

[libvirt] [PATCH v2 01/14] libxl: allow only 'ethernet' and 'bridge' interfaces, allow script there

2013-06-12 Thread Marek Marczykowski-Górecki
' driver. Changes in v2: - reject interfaces other than 'ethernet' or 'bridge' - change title to better match patch content (was libxl: allow script for any network interface, not only bridge) - update description Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src

[libvirt] [PATCH v2] A bunch of extensions to libxl driver

2013-06-12 Thread Marek Marczykowski-Górecki
This are some additional features to libxl driver. Some of them require change in domain config structures/syntax. Details described with each patch. There are two bugfix patches for deadlock during daemon startup. Changes since v1: - dropped 'script' disk parameter patches - updated 'script'

[libvirt] [PATCH v2 03/14] conf: support backend domain name in disk and network devices

2013-06-12 Thread Marek Marczykowski-Górecki
objects), but for now libxl doesn't have support for PVUSB. Changes in v2: - describe in docs/formatdomain.html.in - enforce empty domain tag (only 'name' attribute allowed) Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- docs/formatdomain.html.in | 29

[libvirt] [PATCH v2 04/14] libxl: support backend domain setting for disk and net devices

2013-06-12 Thread Marek Marczykowski-Górecki
indentation - make libxl_name_to_domid switch more defensive Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 76 +++- src/libxl/libxl_conf.h | 4 +-- src/libxl/libxl_driver.c | 51

[libvirt] [PATCH v2 11/14] libxl: support network device attach/detach

2013-06-12 Thread Marek Marczykowski-Górecki
Both live and config. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 164 ++- 1 file changed, 161 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c

[libvirt] [PATCH v2 07/14] libxl: fix deadlock in libxlReconnectDomain

2013-06-12 Thread Marek Marczykowski-Górecki
). Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index df31001..b2cff5b 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl

[libvirt] [PATCH v2 02/14] libxl: populate xenstore memory entries at startup, handle dom0_mem

2013-06-12 Thread Marek Marczykowski-Górecki
will be before any domain startup. Also prevent automatic memory management if dom0_mem= option passed to xen hypervisor - it is known to be incompatible with autoballoon. Changes in v2: - disable autoballoon when dom0_mem option detected - rebase on 1.0.6+ Signed-off-by: Marek Marczykowski-Górecki

[libvirt] [PATCH v2 08/14] libxl: initialize device structures

2013-06-12 Thread Marek Marczykowski-Górecki
Do not leave uninitialized variables, not all parameters are set in libxlMake*. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 8 1 file changed, 8 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index

[libvirt] [PATCH v2 05/14] libxl: fill HVM SDL and VNC settings based on graphics/ entries

2013-06-12 Thread Marek Marczykowski-Górecki
was always enabled). Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 114 +++-- 1 file changed, 82 insertions(+), 32 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index

[libvirt] [PATCH v2 10/14] libxl: support domain config modification in virDomainRestoreFlags

2013-06-12 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 8dec70b..7b50853 100644 --- a/src/libxl

[libvirt] [PATCH v2 13/14] libxl: implement lifecycle actions from domain config

2013-06-12 Thread Marek Marczykowski-Górecki
' can cause Weird Effects (tm). Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 54 +++- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl

[libvirt] [PATCH v2 06/14] conf: virDomainObjListRemoveLocked function

2013-06-12 Thread Marek Marczykowski-Górecki
While iterating with virDomainObjListForEach it is safe to remove current element. But while iterating, 'doms' lock is already taken, so can't use standard virDomainObjListRemove. So introduce virDomainObjListRemoveLocked for this purpose. Changes in v2: - fix indentation Signed-off-by: Marek

[libvirt] [PATCH v2 09/14] libxl: support paused domain restore in virDomainRestoreFlags

2013-06-12 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index b2cff5b..8dec70b 100644 --- a/src/libxl/libxl_driver.c +++ b/src

[libvirt] [PATCH v2 14/14] libxl: add tablet/mouse input device support

2013-06-12 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 278c5e5..61c370f 100644 --- a/src/libxl/libxl_conf.c +++ b

[libvirt] [PATCH v2 12/14] libxl: pass ipaddr to libxl toolstack

2013-06-12 Thread Marek Marczykowski-Górecki
Do not silently ignore its value. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index d654ace..278c5e5 100644 --- a/src/libxl/libxl_conf.c

Re: [libvirt] [PATCH] remote: fix dom-id after virDomainCreateWithFlags

2013-06-10 Thread Marek Marczykowski-Górecki
On 23.05.2013 15:19, Michal Privoznik wrote: On 23.05.2013 02:01, Marek Marczykowski wrote: The same issue as (already fixed) in virDomainCreate - REMOTE_PROC_DOMAIN_CREATE_WITH_FLAGS doesn't return new domain ID, only -1 on error or 0 on success. Besides this one fix it is more general

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-05-31 Thread Marek Marczykowski
On 31.05.2013 10:25, Ian Campbell wrote: On Thu, 2013-05-30 at 11:53 -0600, Jim Fehlig wrote: Marek Marczykowski wrote: On 01.05.2013 16:11, Daniel P. Berrange wrote: On Wed, May 01, 2013 at 02:44:11PM +0100, David Scott wrote: On 01/05/13 09:46, Ian Campbell wrote: I would

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-05-31 Thread Marek Marczykowski
On 31.05.2013 12:55, Ian Campbell wrote: On Fri, 2013-05-31 at 12:46 +0200, Marek Marczykowski wrote: On 31.05.2013 10:25, Ian Campbell wrote: On Thu, 2013-05-30 at 11:53 -0600, Jim Fehlig wrote: Marek Marczykowski wrote: On 01.05.2013 16:11, Daniel P. Berrange wrote: On Wed, May 01

Re: [libvirt] [Xen-devel] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-05-25 Thread Marek Marczykowski
-device_model_stubdomain accordingly. -- Best Regards, Marek Marczykowski Invisible Things Lab signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RESENT 03/12] libxl: nodeDevice* support for PCI devices

2013-05-22 Thread Marek Marczykowski
On 22.05.2013 16:36, Jim Fehlig wrote: Marek Marczykowski wrote: For now only for PCI devices. Mostly copy-paste from old xen driver. This one is (or will be) covered by Chanyan's work as well right? Right. Regards, Jim --- src/libxl/libxl_driver.c | 193

Re: [libvirt] [PATCH RESENT 02/12] libxl: PCI passthrough support

2013-05-22 Thread Marek Marczykowski
On 22.05.2013 16:33, Jim Fehlig wrote: Jim Fehlig wrote: Daniel P. Berrange wrote: On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote: --- src/libxl/libxl_conf.c | 72 ++ src/libxl/libxl_conf.h | 2 ++ 2 files

Re: [libvirt] [Xen-devel] [PATCH RESENT 04/12] libxl: populate xenstore memory entries at startup\

2013-05-22 Thread Marek Marczykowski
On 22.05.2013 18:58, Stefano Stabellini wrote: On Wed, 22 May 2013, Jim Fehlig wrote: Marek Marczykowski wrote: On 19.04.2013 13:10, Stefano Stabellini wrote: On Thu, 11 Apr 2013, Marek Marczykowski wrote: On 11.04.2013 09:52, Ian Campbell wrote: On Thu, 2013-04-11 at 05:09

[libvirt] [PATCH] remote: fix dom-id after virDomainCreateWithFlags

2013-05-22 Thread Marek Marczykowski
client creates/destroys domain in the meantime. Perhaps virDomainGetID should be called remotely (with all performance implications...)? Or some event-based notification used? Signed-off-by: Marek Marczykowski marma...@invisiblethingslab.com --- src/remote/remote_driver.c | 40

Re: [libvirt] [PATCH RESENT 02/12] libxl: PCI passthrough support

2013-05-03 Thread Marek Marczykowski
? -- Best Regards / Pozdrawiam, Marek Marczykowski Invisible Things Lab signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Xen-devel] [PATCH RESENT 04/12] libxl: populate xenstore memory entries at startup

2013-04-19 Thread Marek Marczykowski
On 19.04.2013 13:10, Stefano Stabellini wrote: On Thu, 11 Apr 2013, Marek Marczykowski wrote: On 11.04.2013 09:52, Ian Campbell wrote: On Thu, 2013-04-11 at 05:09 +0100, Jim Fehlig wrote: +/* This will fill xenstore info about free and dom0 memory - if missing, + * should be called

<    1   2   3   4   >