not building from git
meson: Move all handling of test options together
meson: Handle -Dtests=enabled with Clang
meson: Make -Dexpensive_tests depend on -Dtests
meson: Disable all tests when tests are disabled
meson: Rename build_tests -> tests_enabled
Reviewed-by: Martin Kletzander
bu
On Wed, Oct 25, 2023 at 03:06:55PM +0200, daggs wrote:
Sent: Tuesday, October 24, 2023 at 5:28 PM
From: "Martin Kletzander"
To: "daggs"
Cc: libvir-list@redhat.com
Subject: Re: hdd kills vm
On Mon, Oct 23, 2023 at 04:59:08PM +0200, daggs wrote:
>Greetings Martin,
>
&
On Tue, Oct 24, 2023 at 04:28:58PM +0200, Martin Kletzander wrote:
On Mon, Oct 23, 2023 at 04:59:08PM +0200, daggs wrote:
Greetings Martin,
Sent: Sunday, October 22, 2023 at 12:37 PM
From: "Martin Kletzander"
To: "daggs"
Cc: libvir-list@redhat.com
Subject: Re: hdd kill
On Wed, Oct 25, 2023 at 11:03:54AM +0200, Marc Hartmayer wrote:
Document the following changes:
+ added `virsh console --resume` subcommand option
+ improved `virsh start --console` behavior
+ improved `virsh create --console` behavior
Signed-off-by: Marc Hartmayer
Reviewed-by: Martin
On Mon, Oct 23, 2023 at 04:59:08PM +0200, daggs wrote:
Greetings Martin,
Sent: Sunday, October 22, 2023 at 12:37 PM
From: "Martin Kletzander"
To: "daggs"
Cc: libvir-list@redhat.com
Subject: Re: hdd kills vm
On Fri, Oct 20, 2023 at 02:42:38PM +0200, daggs wrote:
&
On Fri, Oct 20, 2023 at 02:42:38PM +0200, daggs wrote:
Greetings,
I have a windows 11 vm running on my Gentoo using libvirt (9.8.0) + qemu
(8.1.2), I'm passing almost all available resources to the vm
(all 16 cpus, 31 out of 32 GB, nVidia gpu is pt), but the performance is not
good, system
On Tue, Oct 10, 2023 at 11:54:14AM +0300, Dmitry Frolov wrote:
Comparisson "if(ret == -1)" is always false.
s/ss/s/
Fixed locally and
Reviewed-by: Martin Kletzander
I'll push it in a while. Thanks for the patch.
This statement was forgotten during switching to g_new0()
Foun
.
Signed-off-by: Martin Kletzander
---
tools/virsh-host.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index 21aca5f6dc83..411648197895 100644
--- a/tools/virsh-host.c
+++ b/tools/virsh-host.c
@@ -328,6
On Tue, Sep 26, 2023 at 02:20:43PM +0200, Martin Kletzander wrote:
The function is supposed to return the number of items filled into the
array and not zero. Also change the initialization of the "randomness"
to be based on the startCell so that the values are different for each
The function is supposed to return the number of items filled into the
array and not zero. Also change the initialization of the "randomness"
to be based on the startCell so that the values are different for each
cell even for separate calls.
Signed-off-by: Martin Kletzander
---
(NULLSTR()) with STREQ_NULLABLE()
v3: More checks added, to skip earlier. More verbose VIR_DEBUG.
Signed-off-by: Dmitry Frolov
Reviewed-by: Martin Kletzander
---
src/interface/interface_backend_udev.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git
of capng_apply()
Reviewed-by: Martin Kletzander
Checking return values is nicer anyway.
src/lxc/lxc_container.c | 8 +++-
src/util/virutil.c | 8 ++--
2 files changed, 13 insertions(+), 3 deletions(-)
--
2.41.0
signature.asc
Description: PGP signature
-by: Martin Kletzander
and pushed now. Thanks
---
src/ch/ch_conf.c | 34 --
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c
index a8565d9537..f421af5121 100644
--- a/src/ch/ch_conf.c
+++ b/src/ch/ch_conf.c
On Fri, Sep 08, 2023 at 04:15:29PM +0300, Dmitry Frolov wrote:
Reviewing the code I found that return value of function
udev_device_get_sysattr_value() is dereferenced without a check.
udev_device_get_sysattr_value() may return NULL by number of reasons.
v2: VIR_DEBUG added, replaced
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
---
src/util/virnetdevopenvswitch.c | 93 -
1 file changed, 58 insertions(+), 35 deletions(-)
diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c
index 8dad6ed2bd..d836d05
On Thu, Sep 07, 2023 at 09:25:14AM +0200, Peter Krempa wrote:
On Thu, Sep 07, 2023 at 09:11:34 +0200, Martin Kletzander wrote:
On Wed, Sep 06, 2023 at 06:34:42PM +0300, Dmitry Frolov wrote:
> Reviewing the sources, I found, that
> in function lxcContainerMountAllFS() pointers
> vmD
On Wed, Sep 06, 2023 at 10:50:30AM -0500, Praveen K Paladugu wrote:
Refactor the version processing logic in ch driver to support versions
from non-release cloud-hypervisor binaries. This version also supports
versions with branch prefixes in them.
Signed-off-by: Praveen K Paladugu
---
On Wed, Sep 06, 2023 at 06:34:42PM +0300, Dmitry Frolov wrote:
Reviewing the sources, I found, that
in function lxcContainerMountAllFS() pointers
vmDef->fss[i]->src and vmDef->fss[i]->src->path
are checked for NULL after dereferencing in
VIR_DEBUG() macro.
Fixes: 57487085dc ("lxc: don't try to
On Wed, Sep 06, 2023 at 01:20:27PM +0200, Tim Wiederhake wrote:
Plus one drive-by improvement to sync_qemu_features_i386.py.
Tim Wiederhake (2):
cpu_map: Ignore all vmx-* features in sync_qemu_features_i386.py
cpu_map: Add cpu model EPYC Genoa
Reviewed-by: Martin Kletzander
src/cpu_map
On Wed, Sep 06, 2023 at 03:27:10AM +, ~hyman wrote:
Hyman Huang(黄勇) (10):
qemu_capabilities: Introduce QEMU_CAPS_VCPU_DIRTY_LIMIT capability
conf: Introduce XML for dirty limit configuration
libvirt: Add virDomainSetVcpuDirtyLimit API
qemu_driver: Implement qemuDomainSetVcpuDirtyLimit
non, >active_anon is passed;
-instead of *activeFile, >inactive_file is passed;
-instead of *inactiveFile, >active_file is passed.
Fixes: e634c7cd0d ("lxc: Use virCgroupGetMemoryStat")
Signed-off-by: Dmitry Frolov
Reviewed-by: Martin Kletzander
Thanks, pushed now
signatur
Sorry for not looking into this earlier, but it's been quite a while and
I, personally, received only patches 2, 6, 5, 9, and 10 from this
series. I, however, see the rest in the archive, so the issue is
probably somewhere on my part.
Would you mind resending the second version again, ideally
On Mon, Sep 04, 2023 at 02:34:49PM +0200, Michal Prívozník wrote:
On 9/1/23 17:12, Martin Kletzander wrote:
When we parse we keep that in memory
and pass it down to the hypervisor. However, that MAC address is not
strictly valid as it is not marked as locally administered (bit 0x02
On Mon, Sep 04, 2023 at 09:22:54AM +0200, Peter Krempa wrote:
On Fri, Sep 01, 2023 at 23:32:14 +0200, Martin Kletzander wrote:
They represent nanoseconds, and we accept such values already. Not that
anyone would use such values in the wild, but even one person testing
QEMU could put
Change example logfile path and clarify how complicated all things passt
are. I chose not to create the non-existing directory because it could
open a whole new can of worms.
Also explain missing `dev` attribute of ``
Resolves: https://issues.redhat.com/browse/RHEL-1833
Signed-off-by: Martin
://issues.redhat.com/browse/RHEL-1717
Signed-off-by: Martin Kletzander
---
src/conf/schemas/domaincommon.rng | 6 +++---
tests/genericxml2xmlindata/iothreadids.xml | 23 ++
tests/genericxml2xmltest.c | 2 ++
3 files changed, 28 insertions(+), 3 deletions
address just as "not
specified" and generates a new one that libvirt does not even know
about. So to make the overall experience better we now generate it if
the supplied one is all clear.
Resolves: https://issues.redhat.com/browse/RHEL-974
Signed-off-by: Martin Kletzander
---
The test does not use VIR_TEST_DIFFERENT anyway, so it's probably a
leftover.
Signed-off-by: Martin Kletzander
---
Pushed as trivial
tests/genericxml2xmloutdata/device-backenddomain.xml | 1 -
1 file changed, 1 deletion(-)
delete mode 12 tests/genericxml2xmloutdata/device
On Wed, Aug 16, 2023 at 05:41:37PM -0600, x...@trimaso.com.mx wrote:
I'll be direct.
After learning that QEMU itself has never officially implemented options
such as "-vcpu", "-vcpupin", or similar, remaining only as unimplemented
commits at their mailing lists, I felt the need of asking here
sults")
Signed-off-by: Anastasia Belova
Reviewed-by: Martin Kletzander
and pushed now, thanks.
---
src/conf/numa_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index a616521763..31b5ea58f6 100644
--- a/src/conf/numa_conf.c
virReportSystemError(errno, "%s",
_("Failed to run clone container"));
-return -1;
+goto cleanup;
}
-return pid;
+ret = pid;
+ cleanup:
+if (munmap(stack, stacksize) < 0) {
+VIR_WARN("Unable to munmap() st
On Wed, Aug 02, 2023 at 01:40:16PM -0600, Jim Fehlig wrote:
On 8/1/23 08:11, Martin Kletzander wrote:
On Mon, Jul 31, 2023 at 05:06:44PM -0600, Jim Fehlig wrote:
The first patch is trivial. I suppose the second is debatable. If I build
libvirt with -Dremote_default_mode=legacy but deploy
ILE and these are case sensitive
* The hard and soft limits were inverted - soft must come
first and so it would have been ignored even if the
setting name was correct.
* The default hard limit is 524288 not 512000
Reported-by: Olaf Hering
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Martin Kletzan
with such configurations.
Closes: https://gitlab.com/libvirt/libvirt/-/issues/514
Signed-off-by: Peter Krempa
Reviewed-by: Martin Kletzander
---
src/remote/remote_daemon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c
index d880711c91
filtering out
noise
virLXCProcessReportStartupLogError: Strip trailing newline from error
src/lxc/lxc_controller.c | 8 +---
src/lxc/lxc_process.c| 12
2 files changed, 17 insertions(+), 3 deletions(-)
Reviewed-by: Martin Kletzander
--
2.41.0
signature.asc
Description
On Tue, Aug 01, 2023 at 04:33:41PM +0200, Michal Privoznik wrote:
See reasoning in 2/2.
Michal Prívozník (2):
Revert "qemu_passt: Actually use @logfd"
Revert "qemu_passt: Precreate passt logfile"
Reviewed-by: Martin Kletzander
src/qe
On Wed, Aug 02, 2023 at 09:15:43AM +0200, Michal Prívozník wrote:
On 7/26/23 16:45, Martin Kletzander wrote:
On Wed, Jun 28, 2023 at 12:53:35PM +0200, Michal Privoznik wrote:
If a guest changes MAC address on its vNIC, then QEMU emits
NIC_RX_FILTER_CHANGED event (the event is emitted in other
On Mon, Jul 31, 2023 at 05:06:44PM -0600, Jim Fehlig wrote:
The first patch is trivial. I suppose the second is debatable. If I build
libvirt with -Dremote_default_mode=legacy but deploy modular daemons,
/run/libvirt/libvirt-sock is provided by virtproxyd, which may or may not
be running when
On Mon, Jul 31, 2023 at 05:06:45PM -0600, Jim Fehlig wrote:
Signed-off-by: Jim Fehlig
Reviewed-by: Martin Kletzander
---
tools/libvirt-guests.sh.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in
index 016014215f..344b54390a 100644
On Mon, Jul 31, 2023 at 04:16:15PM +0200, Peter Krempa wrote:
Signed-off-by: Peter Krempa
Reviewed-by: Martin Kletzander
---
NEWS.rst | 12
1 file changed, 12 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 8f0c67f779..e31448e829 100644
--- a/NEWS.rst
+++ b/NEWS.rst
On Mon, Jul 31, 2023 at 09:55:23AM +0200, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
---
v2 of:
https://listman.redhat.com/archives/libvir-list/2023-July/241020.html
diff to v2:
- Reworded, basically every paragraph, to make them sound more
On Fri, Jul 28, 2023 at 04:40:50PM +0200, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik
---
NEWS.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 1de8314a61..0dc909c849 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -33,8 +33,25 @@ v9.6.0
On Wed, Jun 28, 2023 at 12:53:35PM +0200, Michal Privoznik wrote:
If a guest changes MAC address on its vNIC, then QEMU emits
NIC_RX_FILTER_CHANGED event (the event is emitted in other cases
too, but that's not important right now). Now, domain XML allows
users to chose whether to trust these
On Tue, Jul 25, 2023 at 10:55:54AM -0400, Andrea Bolognani wrote:
On Mon, Jul 24, 2023 at 04:36:07PM +0200, Martin Kletzander wrote:
On Fri, Jul 14, 2023 at 04:39:38PM +0200, Andrea Bolognani wrote:
> The current implementation pretty much assumes that targets
> where modular d
On Wed, Jul 26, 2023 at 10:06:32AM +0200, Martin Kletzander wrote:
On Wed, Jul 26, 2023 at 11:11:39AM +0800, Han Han wrote:
Signed-off-by: Han Han
---
docs/formatdomain.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index
that
before pushing.
Reviewed-by: Martin Kletzander
In the majority of cases the default configuration used by the hypervisor
is sufficient so modifying this setting should not be necessary. For
--
2.41.0
signature.asc
Description: PGP signature
on to libvirt. For example, we do not
provide a `--help` option for the run script.
Signed-off-by: Jonathon Jongsma
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
On Fri, Jul 14, 2023 at 04:39:42PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
mean the reload is called on package install, but that's
still better than nothing. Feel free to add [ "$1" -gt 1 ] around it
somewhere if you want, but I don't think that's necessary.
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
. At least for now. I,
myself, would prefer this to be merged and then possibly cleaned up once
upstream has a better solution.
https://bugzilla.redhat.com/show_bug.cgi?id=2210058
Signed-off-by: Andrea Bolognani
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
activation, so the
additional code is no longer useful and we can treat libvirtd
the same as all other services.
On top of that it was also a little bit fragile. At least from myself,
I am fine with this.
Reviewed-by: Martin Kletzander
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 34
it will not be an issue. So I think this is
fine.
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
On Fri, Jul 14, 2023 at 04:39:37PM +0200, Andrea Bolognani wrote:
To make things more readable, use the same order (%pre, %post,
%posttrans, %preun, %postun) everywhere.
Signed-off-by: Andrea Bolognani
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
On Fri, Jul 14, 2023 at 04:39:36PM +0200, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
On Fri, Jul 14, 2023 at 04:39:35PM +0200, Andrea Bolognani wrote:
According to our platform support policy, now that Fedora 38 is
out we no longer target Fedora 36 and older. This allows us to
simplify a few conditionals.
Signed-off-by: Andrea Bolognani
Reviewed-by: Martin Kletzander
On Wed, Jun 14, 2023 at 04:45:06PM -0600, Jim Fehlig wrote:
On 6/9/23 03:05, Andrea Bolognani wrote:
On Thu, Jun 08, 2023 at 12:35:45PM -0600, Jim Fehlig wrote:
On 6/8/23 08:52, Andrea Bolognani wrote:
On Wed, Jun 07, 2023 at 04:31:36PM +0200, Martin Kletzander wrote:
+# Since this was split
ompilation errors don't stop others and maybe also future proof the
code for changes.
Signed-off-by: Martin Kletzander
---
Pushed as a trivial kind-of build-break fix.
src/conf/nwfilter_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/nwfilter_conf.c
On Mon, Jun 12, 2023 at 10:25:26AM +0200, Michal Prívozník wrote:
On 6/12/23 09:55, Martin Kletzander wrote:
It is used to fill an unsigned long long anyway and if it is negative
than there is really an issue somewhere.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_driver.c | 2 +-
src
With the last user gone this function can be abolished. It is
preferable to use _ll instead since that is not a subject to 32/64 bit
scaling.
Signed-off-by: Martin Kletzander
---
src/libvirt_private.syms | 1 -
src/util/virstring.c | 19 +--
src/util/virstring.h | 5
This has two main advantages:
- it parses the number with C locale explicitly
- it behaves the same on Windows as on Linux and BSD
both of which are wanted behaviours.
Signed-off-by: Martin Kletzander
---
src/util/virstring.c | 54 +++-
1 file changed
Using os.system("cp {0} {1}".format(...)) has two issues, it does not
work on Windows, but more importantly it can cause issues in case one of
the directories has a space in it.
Signed-off-by: Martin Kletzander
---
scripts/meson-dist.py | 7 +++
1 file changed, 3 insertions(+), 4
It is used to fill an unsigned long long anyway and if it is negative
than there is really an issue somewhere.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_driver.c | 2 +-
src/util/virprocess.c | 17 ++---
src/util/virprocess.h | 2 +-
3 files changed, 12 insertions(+), 9
blurb is here, blurb is there,
blurby blurby everywhere
Martin Kletzander (4):
util: Parse RSS into ullp
util: Remove virStrToLong_l
util: Use g_ascii_strtoll
meson-dist: Use shutil.copy for copying a file
scripts/meson-dist.py| 7 ++--
src/libvirt_private.syms | 1 -
src/qemu
On Thu, Jun 08, 2023 at 09:55:28AM +0200, Michal Prívozník wrote:
On 6/7/23 16:31, Martin Kletzander wrote:
Since virtproxyd was split into libvirt-daemon-proxy package it can
happen that, in case a distribution has such systemd preset, when
installing this package, already pre-enabled
On Thu, Jun 08, 2023 at 09:03:04AM +0200, Michal Prívozník wrote:
On 6/8/23 08:45, Martin Kletzander wrote:
On Wed, Jun 07, 2023 at 04:41:01PM +0200, Michal Privoznik wrote:
The @unionMems argument of qemuProcessSetupPid() function is not
necessary really as all callers pass 'true'. Drop
On Mon, Jun 05, 2023 at 12:10:03PM +0200, Michal Prívozník wrote:
On 5/23/23 19:31, Cole Robinson wrote:
numad is removed from Fedora 39. Upstream is dead
https://src.fedoraproject.org/rpms/numad/c/a6bb891e8447e3b2a4c63774da94ad0d9b4ee50a?branch=rawhide
to see
what's the difference between virDomainFSDefValidate and
virDomainDefFSValidate to be honest.
With that fixed up:
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
t the "else", mem_mode cannot
be both anyway.
With that fixed up:
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
s untouched and rely on .host-nodes passed on the
QEMU cmd line.
The placement still suffers because of cpuset.mems set for vcpus
or iothreads, but that's fixed in next commit.
Fixes: 3ec6d586bc3ec7a8cf406b1b6363e87d50aa159c
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
signa
rivoznik
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
/show_bug.cgi?id=2210058
Fixes: 5358618b1cd0afc126aed313249bf2134731665f
Signed-off-by: Martin Kletzander
---
This is more like an RFC as I would really like to know what to really do in
this case. What happens, basically, is that if you have libvirt-daemon-9.0.0
and set up virtproxyd-tls.socket
reasonable, looks good
Reviewed-by: Martin Kletzander
Michal
signature.asc
Description: PGP signature
On Wed, May 31, 2023 at 05:08:33PM +0200, Peter Krempa wrote:
Pipeline:
https://gitlab.com/pipo.sk/libvirt/-/jobs/4385932520
Impacted HTML files from pipeline:
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/4385932520/artifacts/website/libvirt-go.html
On Wed, May 31, 2023 at 05:08:36PM +0200, Peter Krempa wrote:
The '.. meta::' rST directive allows adding header metadata. Move the
specific metadata from page.xsl into the individual files and pass them
trhough into the header from page.xsl.
through
Signed-off-by: Peter Krempa
---
On Tue, May 30, 2023 at 05:02:26PM +0200, Ján Tomko wrote:
In virNodeDeviceGetSCSIHostCaps, there is a pattern of reusing
a tmp value and stealing the pointer.
But in one case it is not stolen. Use a separate variable for it
to avoid mixing autofree with manual free() calls.
Actually in two
;, unarmed,
"s:memdev", memdev,
"B:prealloc", prealloc,
+ "P:memaddr", mem->address,
Only here I figured out to think whether it might be possible to have
the dimm mapped to address 0, but it's fine
too.
This effectively reports the address the virtio-mem/virtio-pmem
is mapped to in live XML.
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
ddress) {
+virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ _("Target memory device address '0x%llx' doesn't match
source memory device address '0x%llx'"),
This needs to use the new permutable format string. Other than that
Reviewed-by: Martin Kletzander
and safe
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -173,6 +173,10 @@
%define with_numad0%{!?_without_numad:1}
%endif
%endif
+%if 0%{?fedora} >= 39
+# numad is retired in fedora 39+, upstream is dead
+%define with_numad0
+%endif
And I'm fine with this.
Reviewed-by: Mar
On Tue, May 23, 2023 at 12:06:20PM +0200, Michal Privoznik wrote:
This is very similar to the previous commit, but fixes the case
where there are no CGroups (or are disabled by admin) and thus
libvirt calls mbind() before exec()-ing QEMU.
nitpick: we don't call mbind, but numa_set_membind
;
bool teardowncgroup = false;
bool teardowndevice = false;
+bool restoreemulatorcgroup = false;
whoinventedthesevariablenames
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
declaration at the beginning of the function
and use it instead of the expanded form.
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
* process. */
+if (unionMems &&
+nameval == VIR_CGROUP_THREAD_EMULATOR) {
+ qemuDomainNumatuneMaybeFormatNodesetUnion(vm, NULL, _mask);
This should not be the case for VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE as
that will not result in host-nodes being set.
With those fixes
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
for the series:
Reviewed-by: Martin Kletzander
Michal Prívozník (3):
virDomainNumatuneNodeSpecified: Fix const correctness
numa_conf: Move memnode mode validation into
virDomainNumaDefValidate()
numa_conf: Deny other memory modes than 'restrictive' if a memnode is
'restrictive'
src/conf
We cannot use host-nodes attribute for it, but there is no reason for us
to skip the preallocation optimisation using thread-context in such
case. Thankfully returning the proper nodemask from
qemuBuildMemoryBackendProps is enough to trigger this.
Signed-off-by: Martin Kletzander
---
src/qemu
pointed out in 3/4 and 4/4 fixed
Reviewed-by: Martin Kletzander
docs/formatdomain.rst | 7 +
src/conf/domain_conf.c| 6 -
src/conf/domain_conf.h| 1 +
src/conf/schemas/domaincommon.rng | 5
src/qemu
On Tue, May 16, 2023 at 12:54:16PM +0200, Michal Privoznik wrote:
This is pretty trivia, just append "mte=on/off" to -machine
*trivial
arguments.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c| 6 ++
tests/qemuxml2argvdata/aarch64-gic-v3.args | 2 +-
2
On Tue, May 16, 2023 at 12:54:15PM +0200, Michal Privoznik wrote:
The MTE feature is not supported by all QEMUs, only those with
QEMU_CAPS_MACHINE_VIRT_MTE capability.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_validate.c | 25 +
1 file changed, 17 insertions(+),
On Tue, May 16, 2023 at 12:49:02PM +0200, Michal Prívozník wrote:
On 5/16/23 11:52, Martin Kletzander wrote:
On Thu, May 11, 2023 at 02:14:51PM +0200, Michal Privoznik wrote:
This is mostly straightforward, except for a teensy-weensy
detail: usually, there's no system wide daemon running
functions.
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
---
src/qemu/qemu_domain.c | 42 -
src/qemu/qemu_domain.h | 6 ++
src/qemu/qemu_hotplug.c | 16
src/qemu/qemu_process.c | 2 +-
tests/qemumemlocktest.c | 2 +-
5
domain definition.
After this, qemuDomainAdjustMaxMemLock() can be called with
@forceVFIO = false, as the disk is now part of domain definition
(when computing the new limit).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2014030#c28
Signed-off-by: Michal Privoznik
Reviewed-by:
On Thu, May 11, 2023 at 02:14:51PM +0200, Michal Privoznik wrote:
This is mostly straightforward, except for a teensy-weensy
detail: usually, there's no system wide daemon running, no system
wide available socket that anybody could connect to. PipeWire
uses a per user daemon approach instead.
environment for it in the meantime and will report results
afterwards.
Reviewed-by: Martin Kletzander
Michal
signature.asc
Description: PGP signature
On Wed, May 10, 2023 at 06:01:28AM -0700, Andrea Bolognani wrote:
On Wed, May 10, 2023 at 02:40:38PM +0200, Peter Krempa wrote:
On Wed, May 10, 2023 at 05:28:56 -0700, Andrea Bolognani wrote:
> Peter, is there a reason why we're still calling 'qemu-img create'
> for those specific images? Or
. The "something" seems weird there.
With any of the versions applied
Reviewed-by: Martin Kletzander
signature.asc
Description: PGP signature
.
Signed-off-by: Michal Privoznik
Reviewed-by: Martin Kletzander
---
src/util/virfirewalld.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/util/virfirewalld.h b/src/util/virfirewalld.h
index 004d10ec29..0e94d3507b 100644
--- a/src/util/virfirewalld.h
+++ b/src/util/virfirewalld.h
@@ -20,6
On Fri, May 05, 2023 at 08:05:05PM +0200, Andrea Bolognani wrote:
It's not used as part of the build process or even searched for
at build time. The QEMU driver detects its path at runtime.
But we do run tests at build time and virstoragetest.c is looking for
qemu-img and using it. Without
the corresponding features out of the box.
Andrea Bolognani (5):
util: Small refactor
util: Introduce virFileFindInPathFull()
qemu: Find helpers at runtime
meson: Stop looking for QEMU helpers
qemu: Update documentation for qemu.conf keys
Reviewed-by: Martin Kletzander
meson.build
-by: Martin Kletzander
signature.asc
Description: PGP signature
On Tue, May 02, 2023 at 07:15:50PM +0200, Andrea Bolognani wrote:
The default would already work fine for Fedora and RHEL, but
it's better to be explicit.
Signed-off-by: Andrea Bolognani
Reviewed-by: Martin Kletzander
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git
1 - 100 of 5738 matches
Mail list logo
