Re: qemu modularization of qemu-5.1 vs libvirt domcapabilities cache?

2020-08-20 Thread Martin Wilck
On Thu, 2020-08-20 at 11:00 +0100, Daniel P. Berrangé wrote: > On Wed, Aug 05, 2020 at 10:19:26AM +0200, Andrea Bolognani wrote: > > contents change. > > > > That said, if upgrading QEMU results in losing features, even > > though > > you can recover them through additional steps I would argue

Re: qemu modularization of qemu-5.1 vs libvirt domcapabilities cache?

2020-08-20 Thread Martin Wilck
On Thu, 2020-08-20 at 10:57 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 20, 2020 at 11:32:03AM +0200, Martin Wilck wrote: > > On Tue, 2020-08-18 at 15:15 -0600, Jim Fehlig wrote: > > > On 8/5/20 2:19 AM, Andrea Bolognani wrote: > > > > I guess we need to start

Re: qemu modularization of qemu-5.1 vs libvirt domcapabilities cache?

2020-08-20 Thread Martin Wilck
On Tue, 2020-08-18 at 15:15 -0600, Jim Fehlig wrote: > On 8/5/20 2:19 AM, Andrea Bolognani wrote: > > > > I guess we need to start checking the modules directory in addition > > to the main QEMU binary, and regenerate capabilities every time its > > contents change. > > We recently received

Re: [libvirt] backing file chains, -blockdev, and storage file autodetection

2020-01-09 Thread Martin Wilck
ake qemu-img print a big fat warning when a backing file was specified without "-F". Regards, Martin -- Dr. Martin Wilck , Tel. +49 (0)911 74053 2107 SUSE Software Solutions Germany GmbH HRB 36809, AG Nürnberg GF: Felix Imendörffer -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] backing file chains, -blockdev, and storage file autodetection

2020-01-09 Thread Martin Wilck
ntify the > fix more quickly, with no obvious downside that I see. Sounds good. I'd appreciate mention of the capability_filters option on the kbase page. Thanks, Martin -- Dr. Martin Wilck , Tel. +49 (0)911 74053 2107 SUSE Software Solutions Germany GmbH HRB 36809, AG Nürnberg GF: Felix Imendörffer -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] backing file chains, -blockdev, and storage file autodetection

2020-01-08 Thread Martin Wilck
Hi Peter, On Wed, 2020-01-08 at 15:46 +0100, Peter Krempa wrote: > On Wed, Jan 08, 2020 at 13:34:14 +0000, Martin Wilck wrote: > > The recent change in libvirt to pass storage arguments to qemu via > > "-blockdev", explicity passing backing file chain information &g

[libvirt] backing file chains, -blockdev, and storage file autodetection

2020-01-08 Thread Martin Wilck
enable it in environments (like mine, developer test environment) where evil guests are very unlikely. Best regards, Martin (*) This page is quite hard to find, googling for "libvirt backing chain" does not pick it up prominently just yet. Actually I only found this information by running

Re: [libvirt] [PATCH] network: don't use dhcp-authoritative on static networks

2017-03-07 Thread Martin Wilck
Laine, Daniel, On Mon, 2017-02-13 at 13:34 +0100, Martin Wilck wrote: > Laine, Daniel, > > On Thu, 2017-01-05 at 16:32 +0100, Martin Wilck wrote: > > On Sun, 2016-12-18 at 20:37 -0500, Laine Stump wrote: > > > > > > > > > > On 12/16/2016 11:58

Re: [libvirt] [PATCH] network: don't use dhcp-authoritative on static networks

2017-02-13 Thread Martin Wilck
Laine, Daniel, On Thu, 2017-01-05 at 16:32 +0100, Martin Wilck wrote: > On Sun, 2016-12-18 at 20:37 -0500, Laine Stump wrote: > > > > > > > On 12/16/2016 11:58 AM, Martin Wilck wrote: > > > "Static" DHCP networks are those where no dynamic DHCP

Re: [libvirt] [PATCH] network: don't use dhcp-authoritative on static networks

2017-01-05 Thread Martin Wilck
On Sun, 2016-12-18 at 20:37 -0500, Laine Stump wrote: > > > On 12/16/2016 11:58 AM, Martin Wilck wrote: > > "Static" DHCP networks are those where no dynamic DHCP range is > > defined, only a list of host entries is used to serve permanent > > IP addresses. On

Re: [libvirt] [PATCH] network: don't use dhcp-authoritative on static networks

2016-12-19 Thread Martin Wilck
On Sun, 2016-12-18 at 20:37 -0500, Laine Stump wrote: > On 12/16/2016 11:58 AM, Martin Wilck wrote: > > "Static" DHCP networks are those where no dynamic DHCP range is > > defined, only a list of host entries is used to serve permanent > > IP addresses. On such

[libvirt] [PATCH] network: don't use dhcp-authoritative on static networks

2016-12-16 Thread Martin Wilck
e dnsmasq to do just that. Therefore we can't use "dhcp-authoritative" for static networks. Fixes: 4ac20b3ae "network: add dnsmasq option 'dhcp-authoritative'" Signed-off-by: Martin Wilck <mwi...@suse.com> --- src/network/bridge_driver.c | 9

Re: [libvirt] [PATCH 0/2] network: add dnsmasq option 'dhcp-authoritative'

2016-10-10 Thread Martin Wilck
On Mon, 2016-10-10 at 15:28 -0400, Laine Stump wrote: > Heh. I finally got around to pushing your patch maybe 5 or 10 > minutes  > before you resent, and just now hit send on the reply message, then > saw  > this in my inbox :-) Sorry again for seeming so much like a > government  > bureaucracy.

[libvirt] [PATCH 2/2] tests/networkxml2confdata: add dhcp-authoritative option

2016-10-10 Thread Martin Wilck
The previous patch changes the confdata output for dnsmasq. Adapt the expected test results to match. Signed-off-by: Martin Wilck <mwi...@suse.de> --- tests/networkxml2confdata/dhcp6-nat-network.conf | 1 + tests/networkxml2confdata/dhcp6host-routed-network.conf

[libvirt] [PATCH 1/2] network: add dnsmasq option 'dhcp-authoritative'

2016-10-10 Thread Martin Wilck
VM or host is suspended) will be able to re-acquire the lease even if it's expired, unless the IP address has been taken by some other host. This avoids various annoyances caused by changing VM IP addresses. Signed-off-by: Martin Wilck <mwi...@suse.de> --- src/network/bridge_driver.c | 4 +++- 1

[libvirt] [PATCH 0/2] network: add dnsmasq option 'dhcp-authoritative'

2016-10-10 Thread Martin Wilck
the like. Original submission: https://www.redhat.com/archives/libvir-list/2016-September/msg00739.html Daniel's post where he said that "unless there's a obvious downside to it, it seems reasonable to add that": https://www.redhat.com/archives/libvir-list/2016-September/msg01305.html Rega

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-29 Thread Martin Wilck
On Wed, 2016-09-28 at 17:10 +0100, Daniel P. Berrange wrote: > > I believe that setting "dhcp-authoritative" will be a major > > improvement > > for many setups. Without it, VMs are *never* able to reacquire > > their > > expired lease. With it, reacquiring the lease would work most of > > the >

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-28 Thread Martin Wilck
On Wed, 2016-09-28 at 16:41 +0100, Daniel P. Berrange wrote: > Anyone who cares about VMs having the same IP address after resuming > from suspend *must* configure persistent DHCP mappings for their > guests. > Relying on automatic assignment will always fail in the end, may be > not immediately,

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-28 Thread Martin Wilck
On Tue, 2016-09-27 at 09:15 +0530, Nehal J Wani wrote: >  > Seems like the previous experiment involved a happy accident indeed. >  So, what are we going to do about libvirt+dnsmasq's handling of expired leases now? Martin -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] network: Add support for configuring dhcp lease time

2016-09-23 Thread Martin Wilck
On Fri, 2016-09-23 at 11:56 -0400, Laine Stump wrote: > Martin's patch tries to solve the problem with "dhcp-authoritative"  > which, as far as I understand, tells dnsmasq "you are the keeper of  > *all* lease information on this network, so if you think the address > is  > unused, it really is

[libvirt] [RFC/PATCH 2/2] tests/networkxml2confdata: add dhcp-authoritative option

2016-09-21 Thread Martin Wilck
The previous patch changes the confdata output for dnsmasq. Adapt the expected test results to match. --- tests/networkxml2confdata/dhcp6-nat-network.conf | 1 + tests/networkxml2confdata/dhcp6host-routed-network.conf | 1 +

[libvirt] [RFC/PATCH 0/2] dnsmasq option "dhcp-authoritative"

2016-09-21 Thread Martin Wilck
rt into dnsmasq repository git://thekelleys.org.uk/dnsmasq.git which occured with v2.48 in June 2009. According to CHANGELOG.archive, the option was added in dnsmasq v2.16 in 2004. Regards, Martin Martin Wilck (2): network: add dnsmasq option 'dhcp-authoritative' tests/networkxml2confdata: add

[libvirt] [RFC/PATCH 1/2] network: add dnsmasq option 'dhcp-authoritative'

2016-09-21 Thread Martin Wilck
The dnsmasq man page recommends that dhcp-authoritative "should be set when dnsmasq is definitely the only DHCP server on a network". This is the case for libvirt-managed virtual networks. The effect of this is that VMs that fail to renew their DHCP lease in time (e.g. if the VM or host is

[libvirt] dnsmasq option "dhcp-authoritative" in libvirt virtual networks?

2016-09-19 Thread Martin Wilck
n a network" - IMO that's the case for libvirtd- managed virtual networks. So the question comes to my mind: is there a good reason why libvirtd doesn't set "dhcp-authoritative" on the dnsmasq instances it starts? Regards Martin -- Dr. Martin Wilck <mwi...@suse.com>, Tel. +

[libvirt] [PATCH] conf/interface_conf.c: allow yes and no for STP

2013-11-15 Thread Martin Wilck
The error message XML error: bridge stp shold be on or off got yes is displayed after configuring a bridge interface with NetworkManager (Fedora 19). Reported as: https://bugzilla.redhat.com/show_bug.cgi?id=1031053 Problem description from BZ: Steps to Reproduce: 1. create bridge configuration