Re: [PATCH] hyperv: Fix 32bit compilation

tachSyntheticEthernetAdapter(domain, def->nets[i], > hostname) < 0) { > -virReportError(VIR_ERR_INTERNAL_ERROR, _("Could not attach > network %lu"), i); > +virReportError(VIR_ERR_INTERNAL_ERROR, _("Could not attach > network %zu"), i); > goto error; > } > } > -- > 2.29.2 > Reviewed-by: Matt Coleman -- Matt

Re: [PATCH 00/12] Hyper-V serial ports, NICs, and screeshots

> On Feb 1, 2021, at 11:16 AM, Michal Privoznik wrote: > > Looking good, but I have a few comments in 01/12 and 03/12. Thanks! I sent v2 with changes based on your feedback. -- Matt

[PATCH v2 10/13] hyperv: implement networkGetXMLDesc

Co-authored-by: Dawid Zamirski Signed-off-by: Matt Coleman --- src/hyperv/hyperv_network_driver.c | 24 1 file changed, 24 insertions(+) diff --git a/src/hyperv/hyperv_network_driver.c b/src/hyperv/hyperv_network_driver.c index d6407ac591..93ef01c9aa 100644 --- a/src

[PATCH v2 13/13] news: implement new Hyper-V APIs

Signed-off-by: Matt Coleman --- NEWS.rst | 12 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 8b8a132e41..c6ae6a6c60 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -23,6 +23,18 @@ v7.1.0 (unreleased) Booting is possible from virtiofs filesystems. Introduce

[PATCH v2 09/13] hyperv: implement networkGetAutostart, networkIsActive, and networkIsPersistent

Co-authored-by: Dawid Zamirski Signed-off-by: Matt Coleman --- src/hyperv/hyperv_network_driver.c | 28 1 file changed, 28 insertions(+) diff --git a/src/hyperv/hyperv_network_driver.c b/src/hyperv/hyperv_network_driver.c index f85dea31fe..d6407ac591 100644

[PATCH v2 08/13] hyperv: implement connectNumOfDefinedNetworks and connectListDefinedNetworks

Co-authored-by: Dawid Zamirski Signed-off-by: Matt Coleman --- src/hyperv/hyperv_network_driver.c | 20 1 file changed, 20 insertions(+) diff --git a/src/hyperv/hyperv_network_driver.c b/src/hyperv/hyperv_network_driver.c index 25755f2525..f85dea31fe 100644 --- a/src

[PATCH v2 12/13] hyperv: provide a more detailed error message for WSMan faults

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 4c1bd5e0d2..c14ff0e64a 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -789,9

[PATCH v2 11/13] hyperv: implement domainScreenshot

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 207 ++ src/hyperv/hyperv_wmi_classes.h | 21 +++ src/hyperv/hyperv_wmi_generator.input | 163 3 files changed, 391 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b

[PATCH v2 05/13] hyperv: add support for creating network adapters

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 138 ++ src/hyperv/hyperv_wmi_classes.h | 2 + src/hyperv/hyperv_wmi_generator.input | 32 ++ 3 files changed, 172 insertions(+) diff --git a/src/hyperv

[PATCH v2 06/13] hyperv: implement connectListAllNetworks and connectNumOfNetworks

Co-authored-by: Dawid Zamirski Signed-off-by: Matt Coleman --- po/POTFILES.in | 1 + src/hyperv/hyperv_driver.c | 2 + src/hyperv/hyperv_network_driver.c | 127 + src/hyperv/hyperv_network_driver.h | 26 ++ src/hyperv/meson.build

[PATCH v2 03/13] domain_conf: enable use of g_autofree for virDomainNetDef

Signed-off-by: Matt Coleman --- src/conf/domain_conf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 0a5d151150..f9ea31d48c 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3099,6 +3099,7 @@ virDomainVsockDefPtr

[PATCH v2 07/13] hyperv: implement networkLookupByName and networkLookupByUUID

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_network_driver.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/src/hyperv/hyperv_network_driver.c b/src/hyperv/hyperv_network_driver.c index 3931e548f5..25755f2525 100644 --- a/src/hyperv

[PATCH v2 04/13] hyperv: XML parsing of Ethernet adapters

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 111 ++ src/hyperv/hyperv_wmi.c | 20 + src/hyperv/hyperv_wmi.h | 8 ++ src/hyperv/hyperv_wmi_classes.h | 12 +++ src/hyperv

[PATCH v2 00/13] Hyper-V serial ports, NICs, and screeshots

of g_autoptr for virDomainNetDef * use g_autoptr for ndef in hypervDomainDefParseEthernetAdapter to fix the memory leaks that Michal spotted Matt Coleman (13): hyperv: XML parsing of serial ports hyperv: add support for creating serial devices domain_conf: enable use of g_autofree for virDomainNetDef

[PATCH v2 02/13] hyperv: add support for creating serial devices

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 92 ++ 1 file changed, 92 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 9902fa75b8..a7947be267 100644 --- a/src/hyperv

[PATCH v2 01/13] hyperv: XML parsing of serial ports

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 61 +++ src/hyperv/hyperv_wmi.c | 10 + src/hyperv/hyperv_wmi.h | 4 ++ src/hyperv/hyperv_wmi_classes.h | 1 + src/hyperv

[PATCH 12/12] news: implement new Hyper-V APIs

Signed-off-by: Matt Coleman --- NEWS.rst | 12 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7a2d6649b4..cc8ac4e6eb 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -18,6 +18,18 @@ v7.1.0 (unreleased) The virtio-pmem is a virtio variant of NVDIMM and just like

[PATCH 11/12] hyperv: provide a more detailed error message for WSMan faults

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 4c1bd5e0d2..c14ff0e64a 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -789,9

[PATCH 10/12] hyperv: implement domainScreenshot

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 207 ++ src/hyperv/hyperv_wmi_classes.h | 21 +++ src/hyperv/hyperv_wmi_generator.input | 163 3 files changed, 391 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b

[PATCH 09/12] hyperv: implement networkGetXMLDesc

Co-authored-by: Dawid Zamirski Signed-off-by: Matt Coleman --- src/hyperv/hyperv_network_driver.c | 24 1 file changed, 24 insertions(+) diff --git a/src/hyperv/hyperv_network_driver.c b/src/hyperv/hyperv_network_driver.c index d6407ac591..93ef01c9aa 100644 --- a/src

[PATCH 07/12] hyperv: implement connectNumOfDefinedNetworks and connectListDefinedNetworks

Co-authored-by: Dawid Zamirski Signed-off-by: Matt Coleman --- src/hyperv/hyperv_network_driver.c | 20 1 file changed, 20 insertions(+) diff --git a/src/hyperv/hyperv_network_driver.c b/src/hyperv/hyperv_network_driver.c index 25755f2525..f85dea31fe 100644 --- a/src

[PATCH 08/12] hyperv: implement networkGetAutostart, networkIsActive, and networkIsPersistent

Co-authored-by: Dawid Zamirski Signed-off-by: Matt Coleman --- src/hyperv/hyperv_network_driver.c | 28 1 file changed, 28 insertions(+) diff --git a/src/hyperv/hyperv_network_driver.c b/src/hyperv/hyperv_network_driver.c index f85dea31fe..d6407ac591 100644

[PATCH 06/12] hyperv: implement networkLookupByName and networkLookupByUUID

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_network_driver.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/src/hyperv/hyperv_network_driver.c b/src/hyperv/hyperv_network_driver.c index 3931e548f5..25755f2525 100644 --- a/src/hyperv

[PATCH 04/12] hyperv: add support for creating network adapters

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 138 ++ src/hyperv/hyperv_wmi_classes.h | 2 + src/hyperv/hyperv_wmi_generator.input | 32 ++ 3 files changed, 172 insertions(+) diff --git a/src/hyperv

[PATCH 05/12] hyperv: implement connectListAllNetworks and connectNumOfNetworks

Co-authored-by: Dawid Zamirski Signed-off-by: Matt Coleman --- po/POTFILES.in | 1 + src/hyperv/hyperv_driver.c | 2 + src/hyperv/hyperv_network_driver.c | 127 + src/hyperv/hyperv_network_driver.h | 26 ++ src/hyperv/meson.build

[PATCH 02/12] hyperv: add support for creating serial devices

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 92 ++ 1 file changed, 92 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 9bbbcfc88c..9394794c8f 100644 --- a/src/hyperv

[PATCH 01/12] hyperv: XML parsing of serial ports

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 68 +++ src/hyperv/hyperv_wmi.c | 10 src/hyperv/hyperv_wmi.h | 4 ++ src/hyperv/hyperv_wmi_classes.h | 1 + src/hyperv

[PATCH 03/12] hyperv: XML parsing of Ethernet adapters

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 113 ++ src/hyperv/hyperv_wmi.c | 20 + src/hyperv/hyperv_wmi.h | 8 ++ src/hyperv/hyperv_wmi_classes.h | 12 +++ src/hyperv

[PATCH 00/12] Hyper-V serial ports, NICs, and screeshots

This patchset makes the following changes to the Hyper-V driver: * enable XML parsing and creation of serial ports and NICs * implement several networking APIs * implement screenshots Matt Coleman (12): hyperv: XML parsing of serial ports hyperv: add support for creating serial devices

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

> On Jan 22, 2021, at 12:12 PM, Matt Coleman wrote: > >> On Jan 22, 2021, at 12:07 PM, Matt Coleman wrote: >> >>> On Jan 22, 2021, at 11:30 AM, Laine Stump wrote: >>> >>> On 1/22/21 11:05 AM, Laine Stump wrote: >>>> 1)

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

> On Jan 22, 2021, at 12:07 PM, Matt Coleman wrote: > >> On Jan 22, 2021, at 11:30 AM, Laine Stump wrote: >> >> On 1/22/21 11:05 AM, Laine Stump wrote: >>> 1) There are several cleanup functions in external libraries that in the >>> past were o

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

> On Jan 22, 2021, at 11:30 AM, Laine Stump wrote: > > On 1/22/21 11:05 AM, Laine Stump wrote: >> 1) There are several cleanup functions in external libraries that in the >> past were only called after checking that the pointer was != NULL. g_autoptr >> cleanups need to handle being called

[PATCH 50/55] hyperv: use GLib auto-cleanup in hypervSerializeEprParam

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 56 - 1 file changed, 21 insertions(+), 35 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index ed0091ba06..c1325b2ccc 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src

[PATCH 45/55] hyperv: use GLib auto-cleanup in hypervMsvmVSMSAddResourceSettings and hypervMsvmVSMSModifyResourceSettings

Fixes a memory leak when hypervCreateInvokeParamsList() fails. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 43 - 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index

[PATCH 38/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainManagedSave

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e501a9..476c24533d 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 37/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainIsActive

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 6fa32d175d..e501a9 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 49/55] hyperv: use g_autoptr for WMI classes in hypervDomainAttachDeviceFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 38 +++--- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e8296ead21..2c0e9e0614 100644 --- a/src/hyperv/hyperv_driver.c

[PATCH 41/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectListAllDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index f134b7f137..2dfccb4802 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 28/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainGetState

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 9cf074b6a7..44be9fbd2f 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 53/55] hyperv: use GLib auto-cleanup in hypervCreateInvokeXmlDoc

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 96ae9a40c8..a28bb0e815 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv

[PATCH 27/55] hyperv: use g_autoptr for WMI classes in hypervDomainGetInfo

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 40e4c97d35..9cf074b6a7 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src

[PATCH 47/55] hyperv: use g_autoptr for Win32_OperatingSystem in hypervNodeGetFreeMemory

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 84ffb24f1a..bd3c5a7c34 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 39/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainHasManagedSaveImage

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 476c24533d..d4852d55af 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 36/55] hyperv: use g_autoptr for WMI classes in hypervDomainGetSchedulerParametersFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 15770eeba8..6fa32d175d 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src

[PATCH 46/55] hyperv: use g_autoptr for Win32_PerfRawData_HvStats_HyperVHypervisorVirtualProcessor in hypervDomainGetVcpus

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 4bf91cfa1a..84ffb24f1a 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 43/55] hyperv: use GLib auto-cleanup in hypervInvokeMethod

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 68 - 1 file changed, 27 insertions(+), 41 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 0a9d4bf4fd..459d207ee7 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src

[PATCH 42/55] hyperv: use GLib auto-cleanup in hypervDomainSendKey

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2dfccb4802..4bf91cfa1a 100644 --- a/src/hyperv/hyperv_driver.c +++ b

[PATCH 31/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectListDefinedDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 0642e42b35..f1e6efd343 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 55/55] hyperv: use g_auto for WsXmlDocH in hypervDomainAttachCDROM

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index b81cedf426..bdc084790a 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 54/55] hyperv: use g_auto for WsXmlDocH in hypervDomainAttachVirtualDisk

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2c0e9e0614..b81cedf426 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 51/55] hyperv: use GLib auto-cleanup in hypervEnumAndPull

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 42 ++--- 1 file changed, 14 insertions(+), 28 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index c1325b2ccc..b68b555a3b 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src

[PATCH 52/55] hyperv: use GLib auto-cleanup in hypervSerializeEmbeddedParam

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 44 + 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index b68b555a3b..96ae9a40c8 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src

[PATCH 33/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainCreateWithFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index a73b463260..535bd34733 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 34/55] hyperv: use g_autoptr for Msvm_VirtualSystemSettingData in hypervDomainGetAutostart

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 535bd34733..c63599c09e 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 32/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectNumOfDefinedDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index f1e6efd343..a73b463260 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 44/55] hyperv: use GLib auto-cleanup in hypervInvokeMsvmComputerSystemRequestStateChange

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 50 +++-- 1 file changed, 18 insertions(+), 32 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 459d207ee7..bd62174739 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src

[PATCH 21/55] hyperv: use g_autoptr for WMI classes in hypervDomainSetMemoryProperty

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2ec0415f62..f3fe88926e 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 30/55] hyperv: use g_autoptr for WMI classes in hypervDomainGetVcpusFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index f056761338..0642e42b35 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src

[PATCH 48/55] hyperv: use GLib auto-cleanup in hypervDomainGetXMLDesc

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 49 ++ 1 file changed, 18 insertions(+), 31 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index bd3c5a7c34..e8296ead21 100644 --- a/src/hyperv/hyperv_driver.c

[PATCH 25/55] hyperv: use g_autoptr for WMI classes in hypervDomainAttachStorage

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 07e8d376e0..06eee379a1 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 35/55] hyperv: use g_autoptr for Msvm_VirtualSystemSettingData in hypervDomainSetAutostart

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index c63599c09e..15770eeba8 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 40/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainManagedSaveRemove

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index d4852d55af..f134b7f137 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 04/55] hyperv: store hypervPrivate in hypervObject

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 131 + src/hyperv/hyperv_wmi.c| 19 +++--- src/hyperv/hyperv_wmi.h| 3 +- 3 files changed, 74 insertions(+), 79 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv

[PATCH 16/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainLookupByName

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index fe1ab1c52c..dd5c42c45b 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 24/55] hyperv: use g_autoptr for Msvm_ResourceAllocationSettingData in hypervDomainAttachPhysicalDisk

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 3c4ef5f33f..07e8d376e0 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src

[PATCH 29/55] hyperv: use g_autoptr for WMI classes in hypervDomainSetVcpusFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 44be9fbd2f..f056761338 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 13/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectListDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index efafe9ece2..45463d120d 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 06/55] hyperv: enable use of g_autoptr for the rest of the CIM/WMI classes

Signed-off-by: Matt Coleman --- scripts/hyperv_wmi_generator.py | 4 src/hyperv/hyperv_wmi.c | 12 ++-- src/hyperv/hyperv_wmi.h | 2 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/scripts/hyperv_wmi_generator.py b/scripts/hyperv_wmi_generator.py

[PATCH 17/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainResume

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index dd5c42c45b..1eb3dbd48e 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 10/55] hyperv: use g_autoptr for Msvm_ProcessorSettingData in hypervConnectGetMaxVcpus

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 8b59dd05f7..6375f6b011 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 20/55] hyperv: use g_autoptr for WMI classes in hypervDomainGetMaxMemory

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 7da4c216b1..2ec0415f62 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 05/55] hyperv: enable use of g_autoptr for hypervObject

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 3 +-- src/hyperv/hyperv_wmi.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 241993f2be..2a4377a12f 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv

[PATCH 03/55] hyperv: add inheritance to the WMI generator

This enables casting subtypes to their parent. Signed-off-by: Matt Coleman --- scripts/hyperv_wmi_generator.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/scripts/hyperv_wmi_generator.py b/scripts/hyperv_wmi_generator.py index d72e5d8ca1..e5e961d2db 100755

[PATCH 18/55] hyperv: use g_autoptr for WMI classes in hypervDomainShutdownFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 1eb3dbd48e..fcb764c0f7 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 26/55] hyperv: use g_autoptr for Msvm_DiskDrive in hypervDomainDefParsePhysicalDisk

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 06eee379a1..40e4c97d35 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 22/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervRequestStateChange

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index f3fe88926e..ef3ae54f7d 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 07/55] hyperv: enable automatic cleanup for OpenWSMAN types

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_private.h | 3 +-- src/hyperv/hyperv_wsman.h | 28 2 files changed, 29 insertions(+), 2 deletions(-) create mode 100644 src/hyperv/hyperv_wsman.h diff --git a/src/hyperv/hyperv_private.h b/src/hyperv

[PATCH 09/55] hyperv: use g_autoptr for Win32_ComputerSystem in hypervConnectGetHostname

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 830a3414c5..8b59dd05f7 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 19/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainDestroyFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index fcb764c0f7..7da4c216b1 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 23/55] hyperv: use g_autoptr for Win32_ComputerSystemProduct in hypervLookupHostSystemBiosUuid

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index ef3ae54f7d..3c4ef5f33f 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 12/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectNumOfDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e2773d0d2f..efafe9ece2 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 14/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainLookupByID

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 45463d120d..e5a62c728b 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 15/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainLookupByUUID

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e5a62c728b..fe1ab1c52c 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 08/55] hyperv: use g_autoptr for Win32_OperatingSystem in hypervConnectOpen

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 680d8b762b..830a3414c5 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 11/55] hyperv: use g_autoptr for WMI classes in hypervNodeGetInfo

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 6375f6b011..e2773d0d2f 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv

[PATCH 02/55] hyperv: store the Hyper-V version when connecting

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 62 + src/hyperv/hyperv_private.h | 1 + 2 files changed, 37 insertions(+), 26 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2399b5df7d..1ac379c14f 100644

[PATCH 00/55] Hyper-V: code cleanup & prep for future changes

backwards-incompatible changes introduced in Hyper-V 2016 Matt Coleman (55): hyperv: add a macro for retrieving setting data hyperv: store the Hyper-V version when connecting hyperv: add inheritance to the WMI generator hyperv: store hypervPrivate in hypervObject hyperv: enable use of

[PATCH 01/55] hyperv: add a macro for retrieving setting data

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 52 + 1 file changed, 16 insertions(+), 36 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 4bace10874..d89aeb1874 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src

[PATCH v2 10/10] hyperv: implement domainAttachDevice and domainAttachDeviceFlags

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 118 + 1 file changed, 118 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 76ef6e7e7c..2399b5df7d 100644 --- a/src/hyperv

[PATCH v2 08/10] hyperv: attach virtual optical disks when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 128 + 1 file changed, 128 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e19485839b..62c23731f9 100644 --- a/src/hyperv

[PATCH v2 09/10] hyperv: attach floppy disks when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 62c23731f9..76ef6e7e7c 100644 --- a/src/hyperv

[PATCH v2 07/10] hyperv: attach physical disks when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 111 + 1 file changed, 111 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 3a70f1e9d5..e19485839b 100644 --- a/src/hyperv

[PATCH v2 06/10] hyperv: attach virtual disks when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 249 +++- src/hyperv/hyperv_wmi_classes.h | 1 + 2 files changed, 247 insertions(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c

[PATCH v2 05/10] hyperv: create SCSI controllers when defining domains

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 65eb3c9ad6..ba39870b10 100644 --- a/src/hyperv

[PATCH v2 04/10] hyperv: add hypervMsvmVSMSAddResourceSettings

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 52 + src/hyperv/hyperv_wmi.h | 5 2 files changed, 57 insertions(+) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 466296fe2a..4bace10874 100644 --- a/src/hyperv

[PATCH v2 02/10] hyperv: implement domainUndefine and domainUndefineFlags

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2e18ef6691..e919259486 100644 --- a/src/hyperv

[PATCH v2 03/10] hyperv: implement domainDefineXML

Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e919259486..65eb3c9ad6 100644 --- a/src/hyperv

[PATCH v2 00/10] hyperv: implement defining/undefining domains

section. Here's a GitLab MR, if you'd prefer to review the changes there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/14 Matt Coleman (10): hyperv: ambiguous VM names will throw an error hyperv: implement domainUndefine and domainUndefineFlags hyperv: implement domainDefineXML

[PATCH v2 01/10] hyperv: ambiguous VM names will throw an error

Since Hyper-V allows multiple VMs to be created with the same name, some commands produce unpredictable results due to hypervDomainLookupByName's WMI query selecting the wrong domain. For example, this prevents `virsh dumpxml` from outputting XML for the wrong domain. Signed-off-by: Matt Coleman

Re: [PATCH 06/11] hyperv: attach virtual disks when defining domains

> On Nov 26, 2020, at 9:48 AM, Daniel P. Berrangé wrote: > > On Tue, Nov 24, 2020 at 02:48:35PM -0500, Matt Coleman wrote: >> +g_autofree char *addressString = g_strdup_printf("%u", >> disk->info.addr.drive.unit); > > Validate disk->info.type ==

  1   2   3   4   >