, esxDomainRevertToSnapshot)
(esxDomainSnapshotDelete): Simplify accordingly.
---
src/esx/esx_driver.c | 12
src/esx/esx_vi.c | 7 ---
2 files changed, 8 insertions(+), 11 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
| 99
++
1 files changed, 99 insertions(+), 0 deletions(-)
Tested, works, ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
);
goto cleanup;
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
);
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
. This is one of things where
vSphere API doesn't translate efficiently to libvirt API.
src/esx/esx_driver.c | 41 +
1 files changed, 41 insertions(+), 0 deletions(-)
Looks good, tested, works, ACK :)
--
Matthias Bolte
http://photron.blogspot.com
but agreed someone with the
setup should check those and give the final ACK :-)
Daniel
I'll probably have some time this weekend to have a look at it.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo
2011/9/27 Eric Blake ebl...@redhat.com:
On 09/27/2011 05:12 AM, Matthias Bolte wrote:
Before, URIs such as esx+ssh:// have been declined by the ESX driver
resulting in the remote driver trying to connect to an non-existing
libvirtd.
Now such URIs trigger and error in the ESX driver
2011/9/27 Eric Blake ebl...@redhat.com:
On 09/27/2011 05:14 AM, Matthias Bolte wrote:
Before, URIs such as hyperv+ssh:// have been declined by the Hyper-V
driver resulting in the remote driver trying to connect to an
non-existing libvirtd.
Now such URIs trigger an error in the Hyper-V
Before, URIs such as esx+ssh:// have been declined by the ESX driver
resulting in the remote driver trying to connect to an non-existing
libvirtd.
Now such URIs trigger and error in the ESX driver suggesting to try
again without the transport part in the scheme.
---
src/esx/esx_driver.c | 31
Before, URIs such as hyperv+ssh:// have been declined by the Hyper-V
driver resulting in the remote driver trying to connect to an
non-existing libvirtd.
Now such URIs trigger an error in the Hyper-V driver suggesting to
try again without the transport part in the scheme.
---
to replace the 'return NULL' with a 'goto cleanup'
here instead of adding a virConfFree, as this is more in line with the
surrounding code.
Either way ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir
2011/9/7 Eric Blake ebl...@redhat.com:
On 09/06/2011 09:01 PM, Matthias Bolte wrote:
Exit early if managed object is not found, instead of dereferencing
a NULL pointer and triggering a segfault.
---
src/esx/esx_vi.c | 8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
ACK
Allow the datacenter and compute resource parts of the path
to be prefixed with folders. Therefore, the way the path is
parsed has changed. Before, it was split in 2 or 3 items and
the items' meanings were determined by their positions. Now
the path can have 2 or more items and the the vCenter
2011/9/6 Eric Blake ebl...@redhat.com:
On 09/06/2011 07:44 AM, Matthias Bolte wrote:
Because it's a define use in MSCOM and its usage as
identifier results in a compile error.
Lame of the headers to invade the namespace like that, but easy enough to
work around.
---
tools/virsh.c | 24
Exit early if managed object is not found, instead of dereferencing
a NULL pointer and triggering a segfault.
---
src/esx/esx_vi.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c
index 5c8d79e..f4033eb 100644
---
documentation about in which situations what
error codes are applicable and what their intended meaning is. We
might also need to adjust the assigned error messages to improve error
reporting.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
2011/8/20 Eric Blake ebl...@redhat.com:
On 08/03/2011 09:00 AM, Matthias Bolte wrote:
Add a generator script to generate the structs and serialization
information for OpenWSMAN.
openwsman.h collects workarounds for problems in OpenWSMAN= 2.2.6.
There are also disabled sections that would
2011/8/20 Eric Blake ebl...@redhat.com:
On 08/03/2011 09:00 AM, Matthias Bolte wrote:
Domain listing, basic information retrieval and domain life cycle
management is implemented. But currently the domian XML output
s/domian/domain/
lacks the complete devices section.
The driver uses
2011/8/20 Eric Blake ebl...@redhat.com:
On 08/03/2011 09:00 AM, Matthias Bolte wrote:
---
v2:
- move microsoft.com link to drvhyperv.html.in
docs/drivers.html.in | 1 +
docs/drvhyperv.html.in | 112
docs/index.html.in | 3
2011/8/20 Eric Blake ebl...@redhat.com:
On 08/03/2011 09:00 AM, Matthias Bolte wrote:
Version 2 of the Hyper-V driver. See the individual patches for
the changes from version 1. Complete version 1 can be found here
https://www.redhat.com/archives/libvir-list/2011-July/msg00766.html
2011/8/26 Eric Blake ebl...@redhat.com:
On 08/26/2011 06:10 AM, Matthias Bolte wrote:
I pointed out a couple of nits, but nothing jumped out at me as a
showstopper. ACK, and I'm happy if you push without posting a v3.
Here's the interdiff I'm going to apply, before I push the whole
2011/8/23 Eric Blake ebl...@redhat.com:
On 08/23/2011 03:42 PM, Matthias Bolte wrote:
---
src/Makefile.am | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 8fe7120..5ba189c 100644
--- a/src/Makefile.am
+++ b/src
---
src/esx/esx_vi_generator.py | 24 +---
1 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
index 239ec73..8a128df 100755
--- a/src/esx/esx_vi_generator.py
+++ b/src/esx/esx_vi_generator.py
@@ -1817,17
2011/8/23 Eric Blake ebl...@redhat.com:
On 08/23/2011 03:18 PM, Matthias Bolte wrote:
---
src/esx/esx_vi_generator.py | 24 +---
1 files changed, 13 insertions(+), 11 deletions(-)
ACK.
Thanks, pushed.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list
---
src/Makefile.am |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 8fe7120..5ba189c 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -812,8 +812,9 @@ endif
BUILT_SOURCES += $(ESX_DRIVER_GENERATED)
. See
http://libvirt.org/git/?p=libvirt.git;a=blob;f=src/network/bridge_driver.c#l1806
You might suggest that it only should start/require dnsmasq when there
is a dhcp element or something DNS related that really makes dnsmasq
necessary.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir
2011/8/2 Daniel P. Berrange berra...@redhat.com:
On Mon, Aug 01, 2011 at 06:35:21PM +0200, Matthias Bolte wrote:
2011/8/1 Eric Blake ebl...@redhat.com:
On 07/28/2011 12:07 PM, Matthias Bolte wrote:
2011/7/27 Matthias Bolte matthias.bo...@googlemail.com:
doRemoteClose doesn't free
000..dcfc3f9
--- /dev/null
+++ b/src/hyperv/hyperv_wmi.c
@@ -0,0 +1,684 @@
+
+/*
+ * hyperv_wmi.h: general WMI over WSMAN related functions and structures for
+ * managing Microsoft Hyper-V hosts
+ *
+ * Copyright (C) 2011 Matthias Bolte matthias.bo...@googlemail.com
+ * Copyright
---
v2:
- move microsoft.com link to drvhyperv.html.in
docs/drivers.html.in |1 +
docs/drvhyperv.html.in | 112
docs/index.html.in |3 +
docs/sitemap.html.in |4 ++
src/README |3 +-
5 files changed, 122
/null
+++ b/src/hyperv/hyperv_util.c
@@ -0,0 +1,129 @@
+
+/*
+ * hyperv_util.c: utility functions for the Microsoft Hyper-V driver
+ *
+ * Copyright (C) 2011 Matthias Bolte matthias.bo...@googlemail.com
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under
Version 2 of the Hyper-V driver. See the individual patches for
the changes from version 1. Complete version 1 can be found here
https://www.redhat.com/archives/libvir-list/2011-July/msg00766.html
This series adds the basic driver and supports listing and retrieving
information about existing
host devices
+ *
+ * Copyright (C) 2011 Matthias Bolte matthias.bo...@googlemail.com
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1
---
v2:
- relax OpenWSMAN requirement to 2.2.3
- move libvirt.spec.in change from 2/5 here and fix OpenWSMAN package name
- qoute all PKG_CHECK_MODULES parameters
configure.ac| 38 ++
libvirt.spec.in |9 +
2 files changed, 47 insertions(+),
2011/8/3 Eric Blake ebl...@redhat.com:
On 08/03/2011 08:22 AM, Matthias Bolte wrote:
Detection based on gnutls_session doesn't work because GnuTLS 2.x.y
comes with a compat.h that defines gnutls_session to gnutls_session_t.
Instead detect this based on LIBGNUTLS_VERSION_MAJOR
2011/8/3 Eric Blake ebl...@redhat.com:
On 08/03/2011 10:28 AM, Matthias Bolte wrote:
2011/8/3 Eric Blakeebl...@redhat.com:
On 08/03/2011 08:22 AM, Matthias Bolte wrote:
Detection based on gnutls_session doesn't work because GnuTLS 2.x.y
comes with a compat.h that defines gnutls_session
(+), 1 deletions(-)
diff --git a/.gnulib b/.gnulib
index 41a7841..7f494c7 16
--- a/.gnulib
+++ b/.gnulib
@@ -1 +1 @@
-Subproject commit 41a7841a82351f9df3e13b6199a134004d694131
+Subproject commit 7f494c7d725db4a7f3abdef09d4070725487da67
--
1.7.4.4
ACK.
--
Matthias Bolte
http
2011/8/2 Daniel P. Berrange berra...@redhat.com:
On Thu, Jul 28, 2011 at 07:56:18AM -0600, Eric Blake wrote:
On 07/28/2011 07:52 AM, Matthias Bolte wrote:
At least all tests compile on FreeBSD again. But most of the SSH cases
in virnetmessagetest are failing and I don't understand why yet
Reported by Alex Jia.
---
src/conf/network_conf.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 6714c20..b11c482 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -169,6 +169,8 @@ void
fix from the libvirt side.
I've send a patch form the memory leak
https://www.redhat.com/archives/libvir-list/2011-August/msg3.html
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/8/1 Osier Yang jy...@redhat.com:
于 2011年08月01日 16:07, Matthias Bolte 写道:
Reported by Alex Jia.
---
src/conf/network_conf.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 6714c20..b11c482 100644
://www.redhat.com/archives/libvir-list/2011-July/msg02011.html
It's complex and I don't understand it completely, as there is ref
counting on multiple levels that is entangled with the event loop.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
)) {
+ if (!virDomainObjIsActive(vm)) {
qemuReportError(VIR_ERR_OPERATION_INVALID,
%s, _(domain is not running));
goto endjob;
ACK, makes condition and error message match again.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing
This commands don't have a --pool option, so don't tell
vshCommandOptVolBy that there could be one. This made
vshCommandOptString for pooloptname fail and an missing option
error was reported.
Make pooloptname optional for vshCommandOptVolBy.
---
tools/virsh.c |6 +++---
1 files changed, 3
2011/8/1 Daniel Veillard veill...@redhat.com:
On Mon, Aug 01, 2011 at 02:43:25PM +0200, Matthias Bolte wrote:
This commands don't have a --pool option, so don't tell
vshCommandOptVolBy that there could be one. This made
vshCommandOptString for pooloptname fail and an missing option
error
2011/8/1 Wen Congyang wencongy...@gmail.com:
At 08/01/2011 06:02 PM, Matthias Bolte write:
2011/8/1 Wen Congyangwe...@cn.fujitsu.com:
At 07/30/2011 03:02 PM, Daniel Veillard Write:
I actually tagged and pushed the rc2 tarball and rpms yesterday
but completely forgot to send the associated
2011/8/1 Eric Blake ebl...@redhat.com:
On 07/28/2011 12:07 PM, Matthias Bolte wrote:
2011/7/27 Matthias Bolte matthias.bo...@googlemail.com:
doRemoteClose doesn't free the virNetClientPtr and this creates a
260kb leak per remote connection. This happens because
virNetClientFree doesn't remove
,
please correct me if I'm wrong, thanks.
Correct, rerunning ./bootstrap should fix this.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/7/28 Eric Blake ebl...@redhat.com:
On 07/28/2011 09:52 AM, Matthias Bolte wrote:
Rely on PATH and use just true, because on FreeBSD it's /usr/bin/true.
What fun. The autoconf manual has this gem under true, apropos to the
current patch:
| when asked whether false is more portable
This tested failed on FreeBSD because it was using bash, that might
not be installed.
---
tests/int-overflow |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tests/int-overflow b/tests/int-overflow
index baf2eef..36e5536 100755
--- a/tests/int-overflow
+++
2011/7/28 Eric Blake ebl...@redhat.com:
From: Matthias Bolte matthias.bo...@googlemail.com
Gettext annoyingly modifies CPPFLAGS in-place, putting
-I/usr/local/include into the search patch if libintl headers
must be used from that location. But since we must support
automake 1.9.6 which
2011/7/29 Eric Blake ebl...@redhat.com:
On 07/29/2011 06:19 AM, Matthias Bolte wrote:
This tested failed on FreeBSD because it was using bash, that might
not be installed.
---
tests/int-overflow | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tests/int-overflow b
, TESTS_ENVIRONMENT): Use it to avoid referring to an
environment variable set previously within the same command line.
Reported by Matthias Bolte.
---
Spotted by inspection based on an IRC report; hopefully someone
on BSD can test if it actually makes a difference.
tests/Makefile.am | 10
it might not be included.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
/virnetsaslcontext.c (virNetSASLSessionUpdateBufSize):
Use a union to work around gcc warning.
---
src/rpc/virnetsaslcontext.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
---
bootstrap.conf |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index f006a47..3b105b1 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -36,6 +36,7 @@ configmake
count-one-bits
crypto/md5
dirname-lgpl
+environ
fclose
fcntl-h
ffs
2011/7/26 Eric Blake ebl...@redhat.com:
On 07/26/2011 02:45 PM, Matthias Bolte wrote:
+++ b/configure.ac
@@ -2011,8 +2011,16 @@ dnl Enable building libvirtd?
AM_CONDITIONAL([WITH_LIBVIRTD],[test x$with_libvirtd = xyes])
dnl Check for gettext - don't go any newer than what RHEL 5 supports
2011/7/28 Eric Blake ebl...@redhat.com:
On 07/28/2011 05:08 AM, Matthias Bolte wrote:
---
bootstrap.conf | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index f006a47..3b105b1 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
Rely on PATH and use just true, because on FreeBSD it's /usr/bin/true.
---
tests/commanddata/test16.log |2 +-
tests/commandtest.c |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/commanddata/test16.log b/tests/commanddata/test16.log
index
Prefer 'return EXIT_AM_SKIP' over 'exit(EXIT_AM_SKIP)'.
Prefer 'int main(void)' over 'int main(int argc, char **argv)'.
Fix mymain signature in commandtest and nodeinfotest.
---
tests/commandtest.c | 10 +-
tests/nodeinfotest.c | 10 +-
2011/7/27 Matthias Bolte matthias.bo...@googlemail.com:
doRemoteClose doesn't free the virNetClientPtr and this creates a
260kb leak per remote connection. This happens because
virNetClientFree doesn't remove the last ref, because virNetClientNew
creates the virNetClientPtr with a refcount
be fixed in the generator, but why no use xdr_free here
instead of open coding the free loop?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Add a new helper remoteFreeTypedParameters and teach the generator
to add it to the cleanup section.
https://bugzilla.redhat.com/show_bug.cgi?id=725322
---
src/remote/remote_driver.c | 22 +-
src/rpc/gendispatch.pl |5 +
2 files changed, 22 insertions(+), 5
2011/7/27 Matthias Bolte matthias.bo...@googlemail.com:
2011/7/27 Osier Yang jy...@redhat.com:
Hello, there
Per bug https://bugzilla.redhat.com/show_bug.cgi?id=725322, should
we change the remoteDomainSet* functions into skipgen, and fix the
leaks like below? (NB, new VIR_FREE statements
2011/7/27 Eric Blake ebl...@redhat.com:
On 07/27/2011 01:18 PM, Matthias Bolte wrote:
Add a new helper remoteFreeTypedParameters and teach the generator
to add it to the cleanup section.
https://bugzilla.redhat.com/show_bug.cgi?id=725322
---
src/remote/remote_driver.c | 22
2011/7/27 Eric Blake ebl...@redhat.com:
* tools/virsh.c (doMigrate): Add --change-protection flag.
* tools/virsh.pod (migrate): Document it.
---
As promised here:
https://www.redhat.com/archives/libvir-list/2011-July/msg01919.html
ACK.
--
Matthias Bolte
http://photron.blogspot.com
the refcounting
is supposed to work here I just report it and hope that Dan can easily
fix this.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/6/1 Eric Blake ebl...@redhat.com:
On 05/31/2011 02:51 PM, Matthias Bolte wrote:
AM_GNU_GETTEXT calls AM_ICONV_LINK. AM_ICONV_LINK saves and alters
CPPFLAGS, but doesn't restore it when it finds libiconv. This
results in /usr/local/include ending up in the gcc command line
before
2011/7/25 Daniel P. Berrange berra...@redhat.com:
On Fri, Jul 22, 2011 at 11:55:02PM +0200, Matthias Bolte wrote:
2011/7/22 Eric Blake ebl...@redhat.com:
* tests/virnettlscontexttest.c (testTLSLoadKey): Report errors.
---
Something in gnutls 2.8.5 (RHEL 6) was more leniant than gnutls
with
older gnutls. Also add missing newlines to key
---
tests/virnettlscontexttest.c | 47 -
1 files changed, 27 insertions(+), 20 deletions(-)
ACK, this makes virnettlscontexttest pass for me with gnutls 2.8.6.
--
Matthias Bolte
http
Also prepend $(AM_V_GEN).
---
src/Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 481caba..eef0669 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -90,7 +90,7 @@ EXTRA_DIST += $(srcdir)/util/virkeymaps.h
2011/7/21 Eric Blake ebl...@redhat.com:
On 07/21/2011 10:11 AM, Matthias Bolte wrote:
xen_session_logout already frees the whole session object.
Don't call xenSessionFree on a freed session object.
Reported by Sharmila Radhakrishnan.
---
src/xenapi/xenapi_driver.c | 2 +-
1 files
2011/7/22 Eric Blake ebl...@redhat.com:
On 07/22/2011 07:56 AM, Matthias Bolte wrote:
Also prepend $(AM_V_GEN).
---
src/Makefile.am | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 481caba..eef0669 100644
--- a/src
2011/7/22 Daniel Veillard veill...@redhat.com:
On Fri, Jul 22, 2011 at 08:06:00AM -0600, Eric Blake wrote:
On 07/22/2011 07:56 AM, Matthias Bolte wrote:
Also prepend $(AM_V_GEN).
---
src/Makefile.am | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src
a) there is a bug in the testcase that causes this
b) there is a bug in the tested code in libvirt that causes this
c) there is a bug in gnutls 2.8.6 that causes this
d) there is a bug in gnutls 2.8.5 that makes the broken test pass
e) etc
I'm not sure.
--
Matthias Bolte
http://photron.blogspot.com
:-)
ditto
+ unsigned long average;
+ unsigned long peak;
+ unsigned long burst;
+} virRate;
Also don't use long, as it's size is compiler and architecture
dependent. Make it either int if that's large enough or make it long
long to guarantee 64bit size if we need that here.
--
Matthias
Commit 8665f85523f0451c changed generated.stamp to $(GENERATE).stamp,
but missed one instance in the CLEANFILES list. This can break the
build in case the generated code is deleted but the .stamp file stays
around and therefore the code isn't regenerated.
---
python/Makefile.am |2 +-
1 files
The only 'void name(void)' style procedure in the protocol is 'close' that
is handled special, but also programming errors like a missing _args or
_ret suffix on the structs in the .x files can create such a situation by
accident. Making the generator aware of this avoids bogus errors from the
2011/7/21 Daniel P. Berrange berra...@redhat.com:
On Thu, Jul 21, 2011 at 01:47:14PM +0200, Matthias Bolte wrote:
Commit 8665f85523f0451c changed generated.stamp to $(GENERATE).stamp,
but missed one instance in the CLEANFILES list. This can break the
build in case the generated code is deleted
privP-session-error_description is a list and in order to get the
complete error message all parts of the list should be concatenated.
xenapiSessionErrorHandler does this when its third parameter is NULL.
The current code discards all but the first part of the error message
resulting in a
2011/7/21 Eric Blake ebl...@redhat.com:
On 07/21/2011 05:58 AM, Matthias Bolte wrote:
The only 'void name(void)' style procedure in the protocol is 'close' that
is handled special, but also programming errors like a missing _args or
_ret suffix on the structs in the .x files can create
xen_session_logout already frees the whole session object.
Don't call xenSessionFree on a freed session object.
Reported by Sharmila Radhakrishnan.
---
src/xenapi/xenapi_driver.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xenapi/xenapi_driver.c
(eventLoop.wakeupfd[0]);
+VIR_CLOSE(eventLoop.wakeupfd[1]);
return -1;
}
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/7/19 Daniel Veillard veill...@redhat.com:
On Tue, Jul 19, 2011 at 11:00:21AM +0200, Matthias Bolte wrote:
2011/7/19 a...@redhat.com:
* src/util/event_poll.c: fix file descriptors leak on virEventPollInit.
Detected in valgrind run:
==1254==
==1254== FILE DESCRIPTORS: 6 open
Currently there are no such procedures in the protocol, but programming
errors like a missing _args or _ret suffix on the structs in the .x files
can create such a situation by accident. Making the generator aware of
this avoids bogus errors from the generator such as:
Use of uninitialized
.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
);
+ return NULL;
}
static int networkGetAutostart(virNetworkPtr net,
NACK. Now networkGetBridgeName returns NULL always, that's wrong.
Why do you think that there is a leak?
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
2011/7/15 Alex Jia a...@redhat.com:
On 07/15/2011 03:03 PM, Alex Jia wrote:
On 07/15/2011 02:49 PM, Matthias Bolte wrote:
2011/7/15 a...@redhat.com:
* src/network/bridge_driver.c: Fix memory leak on cleanup section from
networkGetBridgeName function.
---
src/network/bridge_driver.c
2011/7/15 Michal Novotny minov...@redhat.com:
On 07/14/2011 05:42 PM, Matthias Bolte wrote:
2011/7/14 Michal Novotny minov...@redhat.com:
Hi guys,
some time ago I've been investigating the options to get the guest's IP
address information without having to connect to guest's VNC window
2011/7/15 Michal Novotny minov...@redhat.com:
On 07/15/2011 10:28 AM, Matthias Bolte wrote:
2011/7/15 Michal Novotny minov...@redhat.com:
On 07/14/2011 05:42 PM, Matthias Bolte wrote:
2011/7/14 Michal Novotny minov...@redhat.com:
Hi guys,
some time ago I've been investigating the options
This is not necessarily a typo. iff is short for 'if and only if'.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
. Returns -2 if there is no
/// data pending to be read the stream is marked as
non-blocking.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
state.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
the problem of
no mention of a transient domain.
That one actually covers transient domain partly. Look at the
create/shutdown transition between undefined and running states.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com
buildVolFrom function.
ACK, to a patch without this hunk.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
/esx_storage_driver.c | 4 +++-
7 files changed, 46 insertions(+), 13 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
| 2 +-
src/xen/xs_internal.c | 12 +---
9 files changed, 103 insertions(+), 26 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
+-
src/util/util.c | 14 +++---
8 files changed, 69 insertions(+), 46 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
insertions(+), 96 deletions(-)
Looks good, ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/7/13 Eric Blake ebl...@redhat.com:
On 07/13/2011 06:41 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake ebl...@redhat.com:
* src/uml/uml_driver.c (umlOpen, umlDomainGetXMLDesc)
(umlDomainBlockPeek): Reject unknown flags.
---
src/uml/uml_driver.c | 14 +++---
1 files changed, 11
301 - 400 of 2383 matches
Mail list logo
