Re: [libvirt] [PATCH v8 1/5] virstoragefile: Add helper to get storage source backingStore

On Wed, Dec 16, 2015 at 12:14 AM, John Ferlan <jfer...@redhat.com> wrote: > From: Matthias Gatto <matthias.ga...@outscale.com> > > Add a new helper - virStorageSourceGetBackingStore - to fetch the storage > source backingStore pointer in order to make it easier to ch

Re: [libvirt] [PATCH v7 01/13] virstoragefile: Add virStorageSourceGetBackingStore

On Mon, Dec 14, 2015 at 10:57 PM, John Ferlan <jfer...@redhat.com> wrote: > > > On 12/03/2015 09:35 AM, Matthias Gatto wrote: >> Create virStorageSourceGetBackingStore function in >> preparation for quorum: >> Actually, if we want to get a backing store inside a

Re: [libvirt] [PATCH v7 00/13] qemu: Add quorum support to libvirt

ping On Thu, Dec 3, 2015 at 3:35 PM, Matthias Gatto <matthias.ga...@outscale.com> wrote: > The purpose of these patches is to introduce quorum for libvirt > I've try to follow this proposal: > http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html > > This feature

[libvirt] [PATCH v7 13/13] qemu: qemuDiskPathToAlias quorum support

By adding quorum support to qemuDiskPathToAlias, we're adding support to qemuDomainGetBlkioParameters, which was returning an error when the domain was active. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion

[libvirt] [PATCH v7 02/13] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

Uniformize backing store usage by calling virStorageSourceGetBackingStore instead of setting backing store manually. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> Signed-off-by: John Ferlan <jfer...@redhat.com> --- src/conf/domain_conf.c| 7 -

[libvirt] [PATCH v7 04/13] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

Replace the parts of the code where a backing store is set manually with virStorageSourceSetBackingStore Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> Signed-off-by: John Ferlan <jfer...@redhat.com> --- src/conf/domain_conf.c| 3 ++- src/conf/st

[libvirt] [PATCH v7 11/13] qemu: Forbid blocks operations with quorum

For now we block all blocks operations with RAID disks. Quorum doesn't support BlockRebase neither, but qemuDomainBlockRebase call qemuDomainBlockPullCommon or qemuDomainBlockCopyCommon which are alerady blocked. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- sr

[libvirt] [PATCH v7 05/13] virstoragefile: change backingStore to backingStores.

gStore and virStorageSourceGetBackingStore. virStorageSourceSetBackingStore can now expand the size of src->backingStores. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/storage/storage_backend.c| 2 +- src/storage/storage_backend_fs.c | 2 +- src/util/virstoragefil

[libvirt] [PATCH v7 03/13] virstoragefile: Add virStorageSourceSetBackingStore

, I've added a function virStorageSourceSetBackingStore. For now virStorageSourceSetBackingStore don't handle the case where we have more than one backing store in virStorageSource. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> Signed-off-by: John Ferlan <jfer...@redhat.com&

[libvirt] [PATCH v7 12/13] qemu: qemuDomainGetBlockInfo quorum support

Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d0f7866..44ce90f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_dr

[libvirt] [PATCH v7 01/13] virstoragefile: Add virStorageSourceGetBackingStore

gStore field Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 10 ++ src/util/virstoragefile.h | 3 +++ 3 files changed, 14 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms i

[libvirt] [PATCH v7 10/13] domain: Add virDomainDefHasRAID

This function check if a domain has a RAID as a disk. This function is useful to block snapshot operations on domain which contain quorum. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/conf/domain_conf.c | 13 + src/conf/domain_conf.h | 1

[libvirt] [PATCH v7 00/13] qemu: Add quorum support to libvirt

. -Parse unconditionally backing store. -fold qemuBuildRAIDFileSourceStr into qemuBuildRAIDStr. -use 0/-1 return values when failing instead of bool. -virStorageSourceSetBackingStore now free backing store when they are already set. Matthias Gatto (13

[libvirt] [PATCH v7 08/13] domain_conf: Read and Write quorum config

, the index will be 1 for A and 2 for B, but if A have 2 childs C and D, so A will have the index 1, C and D: 2 and 3 and B will be 4. Here is a representation of our disk tree and they indexs: C[2] / A[1] /\D[3] HDA \ B[4] Signed-off-by: Matthias Gatto <matthias

[libvirt] [PATCH v7 07/13] virstoragefile: Add quorum in virstoragefile

Add VIR_STORAGE_TYPE_QUORUM in virStorageType. Add VIR_STORAGE_FILE_QUORUM in virStorageFileFormat. Add threshold value in _virStorageSource Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- docs/formatdomain.html.in | 23 --- docs/schemas/domaincomm

[libvirt] [PATCH v7 06/13] virstoragefile: Add virStorageSourceIsRAID

s beavious won't work with Quorum, and so we need to add exeptions for these functions, but I'm not convinced by the idea to add a lot of "disk->format == QUORUM" in all the code that deserve exeption for Quorum, so I've add a generic function for this. Signed-off-by: Matt

[libvirt] [PATCH v7 09/13] qemu: Add quorum support in qemuBuildDriveDevStr

Allow libvirt to build the quorum string use by qemu. Add 2astatic function: qemuBuildRAIDStr qemuBuildRAIDStr is made because a quorum can have another quorum as a child, so we may need to call qemuBuildRAIDStr recursively. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --

Re: [libvirt] [PATCH v6 02/13] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

On Mon, Nov 2, 2015 at 8:42 AM, Peter Krempa wrote: > >> @@ -99,37 +100,39 @@ virStorageBackendProbeTarget(virStorageSourcePtr target, >> if (!(target->backingStore = virStorageSourceNewFromBacking(meta))) >> goto cleanup; >> >> -

[libvirt] [PATCH v6 05/13] virstoragefile: change backingStore to backingStores.

gStore and virStorageSourceGetBackingStore. virStorageSourceSetBackingStore can now expand the size of src->backingStores. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/storage/storage_backend.c| 2 +- src/storage/storage_backend_fs.c | 2 +- src/util/virstoragefil

Re: [libvirt] [PATCH v6 11/11] quorum: Block snapshot operation with RAID

On Thu, Oct 29, 2015 at 2:43 PM, Matthias Gatto <matthias.ga...@outscale.com> wrote: > For now we block all snapshot operations with quorum, because it would require > a lot more code, espacially because Qemu doesn't really suport it. > > I guess, we can use node-name, and manu

[libvirt] [PATCH v6 01/13] virstoragefile: Add virStorageSourceGetBackingStore

gStore field Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 3 +++ 3 files changed, 12 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 4b7e

[libvirt] [PATCH v6 06/13] virstoragefile: Add virStorageSourceIsRAID

s beavious won't work with Quorum, and so we need to add exeptions for these functions, but I'm not convinced by the idea to add a lot of "disk->format == QUORUM" in all the code that deserve exeption for Quorum, so I've add a generic function for this. Signed-off-by: Matt

[libvirt] [PATCH v6 09/13] qemu: Add quorum support in qemuBuildDriveDevStr

ename" where libvirt don't use "file.filename=" but directly "file=". Therfore I use this function only for quorum. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/qemu/qemu_command.c | 93 + 1 file c

[libvirt] [PATCH v6 04/13] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

Replace the parts of the code where a backing store is set manually with virStorageSourceSetBackingStore Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> Signed-off-by: John Ferlan <jfer...@redhat.com> --- src/conf/domain_conf.c| 3 ++- src/conf/st

[libvirt] [PATCH v6 00/13] qemu: Add quorum support to libvirt

virDomainDefHasRAID -patch 11-13/13: Block all unsupported operations Matthias Gatto (13): virstoragefile: Add virStorageSourceGetBackingStore virstoragefile: Always use virStorageSourceGetBackingStore to get backing store virstoragefile: Add virStorageSourceSetBackingStore virstoragefile

[libvirt] [PATCH v6 10/13] domain: Add virDomainDefHasRAID

This function check if a domain has a RAID as a disk. This function is useful to block snapshot operation on domain which contain quorum. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/conf/domain_conf.c | 13 + src/conf/domain_conf.h | 1

[libvirt] [PATCH v6 03/13] virstoragefile: Add virStorageSourceSetBackingStore

, I've added a function virStorageSourceSetBackingStore. For now virStorageSourceSetBackingStore don't handle the case where we have more than one backing store in virStorageSource. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> Signed-off-by: John Ferlan <jfer...@redhat.com&

[libvirt] [PATCH v6 11/11] quorum: Block snapshot operation with RAID

. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 25be0d9..0e43966 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14674,6 +14

[libvirt] [PATCH v6 11/13] qemu: Block snapshot operation with RAID

-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 193c25d..1ec0cf2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -14674,6 +14

[libvirt] [PATCH v6 08/13] domain_conf: Read and Write quorum config

for quorum child manipulation. For now, this serie of patch forbid all actions which need to use indexes with quorum. Therefore even if the index manipulation is buggy, this should not be a problem because the buggy code should never be call. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.

[libvirt] [PATCH v6 12/13] qemu: qemuDomainGetBlockInfo quorum support

Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1ec0cf2..f70f1dd 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_dr

[libvirt] [PATCH v6 07/13] virstoragefile: Add quorum in virstoragefile

Add VIR_STORAGE_TYPE_QUORUM in virStorageType. Add VIR_STORAGE_FILE_QUORUM in virStorageFileFormat. Add threshold value in _virStorageSource Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- docs/formatdomain.html.in | 23 --- docs/schemas/domaincomm

[libvirt] [PATCH v6 13/13] qemu: qemuDiskPathToAlias quorum support

By adding quorum support to qemuDiskPathToAlias, we're adding support to qemuDomainGetBlkioParameters, which was returning an error when the domain was active. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion

[libvirt] [PATCH v6 02/13] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

Uniformize backing store usage by calling virStorageSourceGetBackingStore instead of setting backing store manually. Signed-off-by: Matthias Gatto <matthias.ga...@outscale.com> Signed-off-by: John Ferlan <jfer...@redhat.com> --- src/conf/domain_conf.c| 7 -

Re: [libvirt] [PATCH v5 8/9] qemu: Add quorum support in qemuBuildDriveDevStr

On Tue, May 12, 2015 at 5:38 PM, Peter Krempa pkre...@redhat.com wrote: On Thu, Apr 23, 2015 at 14:41:20 +0200, Matthias Gatto wrote: Allow to libvirt to build the quorum string used by quemu. Add 2 static functions: qemuBuildQuorumStr and qemuBuildAndAppendDriveStrToVirBuffer

Re: [libvirt] [PATCH v5 7/9] domain_conf: Read and Write quorum config

On Tue, May 12, 2015 at 5:04 PM, Peter Krempa pkre...@redhat.com wrote: On Thu, Apr 23, 2015 at 14:41:19 +0200, Matthias Gatto wrote: Add the capabiltty to libvirt to parse and format the quorum syntax as described here: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html

Re: [libvirt] [PATCH v5 4/9] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

On Mon, May 4, 2015 at 7:21 PM, John Ferlan jfer...@redhat.com wrote: On 04/23/2015 08:41 AM, Matthias Gatto wrote: Replace the parts of the code where a backing store is set manually with virStorageSourceSetBackingStore Signed-off-by: Matthias Gatto matthias.ga...@outscale.com Signed-off

Re: [libvirt] [PATCH v5 0/9] qemu: Add quorum support to libvirt

On Thu, Apr 23, 2015 at 2:41 PM, Matthias Gatto matthias.ga...@outscale.com wrote: The purpose of these patches is to introduce quorum for libvirt I've try to follow this proposal: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html This feature ask for 6 task: 1) Allow

[libvirt] [PATCH v5 6/9] virstoragefile: Add quorum in virstoragefile

Add VIR_STORAGE_TYPE_QUORUM in virStorageType. Add VIR_STORAGE_FILE_QUORUM in virStorageFileFormat. Add threshold value in _virStorageSource Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- docs/formatdomain.html.in | 23 --- docs/schemas/domaincommon.rng

[libvirt] [PATCH v5 8/9] qemu: Add quorum support in qemuBuildDriveDevStr

a complet quorum support in libvirt. Ideally I'd like to refactore virDomainDiskDefFormat to allow qemuBuildQuorumStr to call this function in a loop. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_command.c | 110 1

[libvirt] [PATCH v5 2/9] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

Uniformize backing store usage by calling virStorageSourceGetBackingStore instead of setting backing store manually. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c| 7 --- src/conf

[libvirt] [PATCH v5 7/9] domain_conf: Read and Write quorum config

Add the capabiltty to libvirt to parse and format the quorum syntax as described here: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c | 164 +++-- 1

[libvirt] [PATCH v5 3/9] virstoragefile: Add virStorageSourceSetBackingStore

, I've added a function virStorageSourceSetBackingStore. For now virStorageSourceSetBackingStore don't handle the case where we have more than one backing store in virStorageSource. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com Signed-off-by: John Ferlan jfer...@redhat.com --- src

[libvirt] [PATCH v5 0/9] qemu: Add quorum support to libvirt

: -Rebase on master -patch 1-4/9: use patchs from John Ferlan -patch 4/9: check return of virStorageSourceSetBackingStore -patch 5/9: report type of error on virStorageSourceSetBackingStore Matthias Gatto (9): virstoragefile: Add virStorageSourceGetBackingStore virstoragefile

[libvirt] [PATCH v5 1/9] virstoragefile: Add virStorageSourceGetBackingStore

Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 3 +++ 3 files changed, 12 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 8c50ea2..6893054

[libvirt] [PATCH v5 4/9] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

Replace the parts of the code where a backing store is set manually with virStorageSourceSetBackingStore Signed-off-by: Matthias Gatto matthias.ga...@outscale.com Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c| 3 ++- src/conf/storage_conf.c

[libvirt] [PATCH v5 9/9] virstoragefile: Add node-name

the nodename: http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03209.html Durring xml backingStore formating, look for a nodename attribute inside the virStorageSource struct, and add it to the disk element. Use the nodename to create the quorum in qemuBuildQuorumStr. Signed-off-by: Matthias

[libvirt] [PATCH v5 5/9] virstoragefile: change backingStore to backingStores.

(virStorageSourcePushBackingStore in the V2) and made the necessary modification to virStorageSourceSetBackingStore and virStorageSourceGetBackingStore. virStorageSourceSetBackingStore can now expand size of src-backingStores by calling virStorageSourceExpandBackingStore if necessary. Signed-off-by: Matthias Gatto

Re: [libvirt] [PATCH v4 0/9] qemu: Add quorum support to libvirt

On Thu, Apr 16, 2015 at 3:43 PM, John Ferlan jfer...@redhat.com wrote: On 03/17/2015 03:25 PM, Matthias Gatto wrote: The purpose of these patches is to introduce quorum for libvirt I've try to follow this proposal: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html Before

Re: [libvirt] [PATCH v4 0/9] qemu: Add quorum support to libvirt

On Tue, Mar 17, 2015 at 8:25 PM, Matthias Gatto matthias.ga...@outscale.com wrote: The purpose of these patches is to introduce quorum for libvirt I've try to follow this proposal: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html This feature ask for 6 task: 1) Allow

[libvirt] [PATCH v4 4/9] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

Replace the parts of the code where a backing store is set manually with virStorageSourceSetBackingStore Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c| 3 ++- src/conf/storage_conf.c | 16 +--- src/qemu

[libvirt] [PATCH v4 2/9] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

Uniformize backing store usage by calling virStorageSourceGetBackingStore instead of setting backing store manually. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c| 7 --- src/conf/storage_conf.c | 6 +++--- src/qemu

[libvirt] [PATCH v4 0/9] qemu: Add quorum support to libvirt

-Add Documentation V3: -Transforme the backingStore field in virStorageSource into an array of pointer instead of a pointer -Modify virStorageSourceSetBackingStore to allow it to expand the backingStore size. V4: -Rebase on master Matthias Gatto (9

[libvirt] [PATCH v4 6/9] virstoragefile: Add quorum in virstoragefile

Add VIR_STORAGE_TYPE_QUORUM in virStorageType. Add VIR_STORAGE_FILE_QUORUM in virStorageFileFormat. Add threshold value in _virStorageSource Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- docs/formatdomain.html.in | 20 +- docs/schemas/domaincommon.rng | 90

[libvirt] [PATCH v4 7/9] domain_conf: Read and Write quorum config

Add the capabiltty to libvirt to parse and format the quorum syntax as described here: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c | 164 +++-- 1

[libvirt] [PATCH v4 9/9] virstoragefile: Add node-name

the nodename: http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03209.html Durring xml backingStore formating, look for a nodename attribute inside the virStorageSource struct, and add it to the disk element. Use the nodename to create the quorum in qemuBuildQuorumStr. Signed-off-by: Matthias

[libvirt] [PATCH v4 3/9] virstoragefile: Add virStorageSourceSetBackingStore

, I've added a function virStorageSourceSetBackingStore. For now virStorageSourceSetBackingStore don't handle the case where we have more than one backing store in virStorageSource. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/libvirt_private.syms | 1 + src/util

[libvirt] [PATCH v4 8/9] qemu: Add quorum support in qemuBuildDriveDevStr

a complet quorum support in libvirt. Ideally I'd like to refactore virDomainDiskDefFormat to allow qemuBuildQuorumStr to call this function in a loop. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_command.c | 110 1

[libvirt] [PATCH v4 1/9] virstoragefile: Add virStorageSourceGetBackingStore

Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 3 +++ 3 files changed, 12 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1fb42ac..7b8038b

[libvirt] [PATCH v4 5/9] virstoragefile: change backingStore to backingStores.

(virStorageSourcePushBackingStore in the V2) and made the necessary modification to virStorageSourceSetBackingStore and virStorageSourceGetBackingStore. virStorageSourceSetBackingStore can now expand size of src-backingStores by calling virStorageSourceExpandBackingStore if necessary. Signed-off-by: Matthias Gatto

Re: [libvirt] [PATCH v3 0/9] qemu: Add quorum support to libvirt

On Thu, Feb 26, 2015 at 5:04 PM, Peter Krempa pkre...@redhat.com wrote: On Mon, Feb 23, 2015 at 14:18:31 +0100, Matthias Gatto wrote: On Tue, Feb 10, 2015 at 4:43 PM, Matthias Gatto matthias.ga...@outscale.com wrote: The purpose of these patches is to introduce quorum for libvirt I've try

Re: [libvirt] [PATCH v3 0/9] qemu: Add quorum support to libvirt

On Tue, Feb 10, 2015 at 4:43 PM, Matthias Gatto matthias.ga...@outscale.com wrote: The purpose of these patches is to introduce quorum for libvirt I've try to follow this proposal: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html This feature ask for 6 task: 1) Allow

[libvirt] [PATCH] qemu: check the validity of a pointer

In the current code if mem_mask is NULL there is a goto error, but we freeing it without knowing if mem_mask is NULL or not, therefor I've had a check. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_cgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[libvirt] [PATCH v3 5/9] virstoragefile: change backingStore to backingStores.

(virStorageSourcePushBackingStore in the V2) and made the necessary modification to virStorageSourceSetBackingStore and virStorageSourceGetBackingStore. virStorageSourceSetBackingStore can now expand size of src-backingStores by calling virStorageSourceExpandBackingStore if necessary. Signed-off-by: Matthias Gatto

[libvirt] [PATCH v3 8/9] qemu: Add quorum support in qemuBuildDriveDevStr

a complet quorum support in libvirt. Ideally I'd like to refactore virDomainDiskDefFormat to allow qemuBuildQuorumStr to call this function in a loop. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_command.c | 110 1

[libvirt] [PATCH v3 6/9] virstoragefile: Add quorum in virstoragefile

Add VIR_STORAGE_TYPE_QUORUM in virStorageType. Add VIR_STORAGE_FILE_QUORUM in virStorageFileFormat. Add threshold value in _virStorageSource Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- docs/formatdomain.html.in | 20 +- docs/schemas/domaincommon.rng | 90

[libvirt] [PATCH v3 0/9] qemu: Add quorum support to libvirt

-Add Documentation V3: -Transforme the backingStore field in virStorageSource into an array of pointer instead of a pointer -Modify virStorageSourceSetBackingStore to allow it to expand the backingStore size. Matthias Gatto (9): virstoragefile: Add

[libvirt] [PATCH v3 3/9] virstoragefile: Add virStorageSourceSetBackingStore

, I've added a function virStorageSourceSetBackingStore. For now virStorageSourceSetBackingStore don't handle the case where we have more than one backing store in virStorageSource. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/libvirt_private.syms | 1 + src/util

[libvirt] [PATCH v3 7/9] domain_conf: Read and Write quorum config

Add the capabiltty to libvirt to parse and format the quorum syntax as described here: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c | 164 +++-- 1

[libvirt] [PATCH v3 1/9] virstoragefile: Add virStorageSourceGetBackingStore

Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 3 +++ 3 files changed, 12 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 376c69b..30b7429

[libvirt] [PATCH v3 4/9] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

Replace the parts of the code where a backing store is set manually with virStorageSourceSetBackingStore Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c| 3 ++- src/conf/storage_conf.c | 7 +-- src/qemu/qemu_driver.c

[libvirt] [PATCH v3 2/9] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

Uniformize backing store usage by calling virStorageSourceGetBackingStore instead of setting backing store manually. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c| 7 --- src/conf/storage_conf.c | 18

[libvirt] [PATCH v3 9/9] virstoragefile: Add node-name

the nodename: http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03209.html Durring xml backingStore formating, look for a nodename attribute inside the virStorageSource struct, and add it to the disk element. Use the nodename to create the quorum in qemuBuildQuorumStr. Signed-off-by: Matthias

Re: [libvirt] [PATCH v2 5/9] virstoragefile: Treat backingStore as a pointer or an array

On Wed, Jan 28, 2015 at 11:10 AM, Michal Privoznik mpriv...@redhat.com wrote: On 21.01.2015 16:29, Matthias Gatto wrote: As explain in the former patchs, backingStore can be treat an array or a pointer. If we have only one backingStore we have to use it as a normal ptr but if there is more

[libvirt] [PATCH v2 7/9] domain_conf: Read and Write quorum config

Add the capabiltty to libvirt to parse and format the quorum syntax as described here: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c | 165 +++-- 1

[libvirt] [PATCH v2 0/9] qemu: Add quorum support to libvirt

-Add Documentation Matthias Gatto (9): virstoragefile: Add virStorageSourceGetBackingStore virstoragefile: Always use virStorageSourceGetBackingStore to get backing store virstoragefile: Add virStorageSourceSetBackingStore virstoragefile: Always use virStorageSourceSetBackingStore

[libvirt] [PATCH v2 3/9] virstoragefile: Add virStorageSourceSetBackingStore

, I've added a function virStorageSourceSetBackingStore. For now virStorageSourceSetBackingStore don't handle the case where we have more than one backing store in virStorageSource. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/libvirt_private.syms | 1 + src/util

[libvirt] [PATCH v2 2/9] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

Uniformize backing store usage by calling virStorageSourceGetBackingStore instead of setting backing store manually. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c| 7 --- src/conf/storage_conf.c | 18

[libvirt] [PATCH v2 8/9] qemu: Add quorum support in qemuBuildDriveDevStr

a complet quorum support in libvirt. Ideally I'd like to refactore virDomainDiskDefFormat to allow qemuBuildQuorumStr to call this function in a loop. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_command.c | 110 1

[libvirt] [PATCH v2 5/9] virstoragefile: Treat backingStore as a pointer or an array

changed virStorageSourceBackingStoreClear, virStorageSourceSetBackingStore and virStorageSourceGetBackingStore to handle the case where backingStore is an array. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/storage_conf.c | 7 ++- src/libvirt_private.syms

[libvirt] [PATCH v2 9/9] virstoragefile: Add node-name

the nodename: http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03209.html Durring xml backingStore formating, look for a nodename attribute inside the virStorageSource struct, and add it to the disk element. Use the nodename to create the quorum in qemuBuildQuorumStr. Signed-off-by: Matthias

[libvirt] [PATCH v2 1/9] virstoragefile: Add virStorageSourceGetBackingStore

Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 3 +++ 3 files changed, 12 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a2eec83..3f4d02c

[libvirt] [PATCH v2 6/9] virstoragefile: Add quorum in virstoragefile

Add VIR_STORAGE_TYPE_QUORUM in virStorageType. Add VIR_STORAGE_FILE_QUORUM in virStorageFileFormat. Add threshold value in _virStorageSource Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- docs/formatdomain.html.in | 20 ++-- docs/schemas/storagecommon.rng

[libvirt] [PATCH v2 4/9] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

Replace the parts of the code where a backing store is set manually with virStorageSourceSetBackingStore Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c | 2 +- src/conf/storage_conf.c | 4 ++-- src/qemu/qemu_driver.c | 4

Re: [libvirt] [PATCH 0/9] qemu: Add quorum support to libvirt

On Wed, Dec 17, 2014 at 10:53 AM, Matthias Gatto matthias.ga...@outscale.com wrote: On Mon, Dec 8, 2014 at 7:31 PM, Matthias Gatto matthias.ga...@outscale.com wrote: The purpose of these patches is to introduce quorum for libvirt I've try to follow this proposal: http://www.redhat.com

Re: [libvirt] [PATCH 0/9] qemu: Add quorum support to libvirt

On Mon, Dec 8, 2014 at 7:31 PM, Matthias Gatto matthias.ga...@outscale.com wrote: The purpose of these patches is to introduce quorum for libvirt I've try to follow this proposal: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html This feature ask for 6 task: 1) Allow

[libvirt] [PATCH 4/9] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

Replace the parts of the code where a backing store is set manually with virStorageSourceSetBackingStore Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c | 2 +- src/qemu/qemu_domain.c | 1 - src/qemu/qemu_driver.c | 4 ++-- src

[libvirt] [PATCH 3/9] virstoragefile: Add virStorageSourceSetBackingStore

, I've added a function virStorageSourceSetBackingStore. For now virStorageSourceSetBackingStore don't handle the case where we have more than one backing store in virStorageSource. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/libvirt_private.syms | 1 + src/util

[libvirt] [PATCH 1/9] virstoragefile: Add virStorageSourceGetBackingStore

Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 3 +++ 3 files changed, 12 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1853a9c..12dd399

[libvirt] [PATCH 5/9] virstoragefile: Treat backingStore as a pointer or an array

changed virStorageSourceBackingStoreClear, virStorageSourceSetBackingStore and virStorageSourceGetBackingStore to handle the case where backingStore is an array. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/storage_conf.c | 3 +- src/libvirt_private.syms

[libvirt] [PATCH 8/9] qemu: Add quorum support in qemuBuildDriveDevStr

a complet quorum support in libvirt. Ideally I'd like to refactore virDomainDiskDefFormat to allow qemuBuildQuorumStr to call this function in a loop. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_command.c | 110 1

[libvirt] [PATCH 0/9] qemu: Add quorum support to libvirt

a virDomainBlockDevAdd function in libvirt witch call blockdev-add. 2) use blockdev-add instead of device_add in qemuMonitorJSONAddDevice 3) write a hack which uses blockdev-add when only attaching quorum (but i'm pretty sure this solution is not the good one) Matthias Gatto (9

[libvirt] [PATCH 9/9] virstoragefile: Add node-name

the nodename: http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03209.html Durring xml backingStore formating, look for a nodename attribute inside the virStorageSource struct, and add it to the disk element. Use the nodename to create the quorum in qemuBuildQuorumStr. Signed-off-by: Matthias

[libvirt] [PATCH 7/9] domain_conf: Read and Write quorum config

Add the capabiltty to libvirt to parse and format the quorum syntax as described here: http://www.redhat.com/archives/libvir-list/2014-May/msg00533.html Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c | 165 +++-- 1

[libvirt] [PATCH 2/9] virstoragefile: Always use virStorageSourceGetBackingStore to get backing store

Uniformize backing store usage by calling virStorageSourceGetBackingStore instead of setting backing store manually. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c| 7 --- src/conf/storage_conf.c | 4 ++-- src/qemu

[libvirt] [PATCH 6/9] virstoragefile: Add quorum in virstoragefile

Add VIR_STORAGE_TYPE_QUORUM in virStorageType. Add VIR_STORAGE_FILE_QUORUM in virStorageFileFormat. Add threshold value in _virStorageSource Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/conf/domain_conf.c| 2 ++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_driver.c

Re: [libvirt] [PATCH v6 6/7] qemu: Add bps_max and friends to qemu command generation

On Tue, Nov 11, 2014 at 1:20 PM, John Ferlan jfer...@redhat.com wrote: On 10/29/2014 08:16 AM, Matthias Gatto wrote: Check the arability of the options with the current qemu binary, add them in the varable opt if yes, print a message if not. Signed-off-by: Matthias Gatto matthias.ga

[libvirt] [PATCH 1/2] qemu: Fix copy_paste_error in qemuBuildDriveStr.

Fix for this: http://www.redhat.com/archives/libvir-list/2014-November/msg00324.html Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

[libvirt] [PATCH 2/2] qemu: Fix DEATHCODE error in qemuDomainGetBlockIoTune.

reported here: http://www.redhat.com/archives/libvir-list/2014-November/msg00327.html I could have just remove bool supportMaxOptions variable, but if I had do this, we could not check anymore if the nparams variable is superior to QEMU_NB_BLOCK_IO_TUNE_PARAM_MAX. Signed-off-by: Matthias Gatto

[libvirt] [PATCH 0/2] qemu: Fix Coverity error on throttle.

Fix the errors reported by John Ferlan about therse patchs: http://www.redhat.com/archives/libvir-list/2014-November/msg00327.html http://www.redhat.com/archives/libvir-list/2014-November/msg00324.html Matthias Gatto (2): qemu: Fix copy_paste_error in qemuBuildDriveStr. qemu: Fix DEATHCODE

  1   2   >