Re: [PATCH for-6.1? v2 5/7] job: Add job_cancel_requested()

On 04.08.21 12:34, Kevin Wolf wrote: [ Peter, the question for you is at the end. ] Am 04.08.2021 um 10:07 hat Max Reitz geschrieben: On 03.08.21 16:25, Kevin Wolf wrote: Am 26.07.2021 um 16:46 hat Max Reitz geschrieben: Most callers of job_is_cancelled() actually want to know whether

Re: RFC: Qemu backup interface plans

On 19.05.21 08:11, Vladimir Sementsov-Ogievskiy wrote: 18.05.2021 19:39, Max Reitz wrote: [...] On 17.05.21 14:07, Vladimir Sementsov-Ogievskiy wrote: [...] Not also, that there is another benefit of such thing: we'll implement this callback in qcow2 driver, so that backup will read

Re: RFC: Qemu backup interface plans

Hi, Your proposal sounds good to me in general. Some small independent building blocks that seems to make sense to me. On 17.05.21 14:07, Vladimir Sementsov-Ogievskiy wrote: [...] What we lack in this scheme: 1. handling dirty bitmap in backup-top filter: backup-top does

Re: Qemu block filter insertion/removal API

On 17.05.21 14:44, Vladimir Sementsov-Ogievskiy wrote: Hi all! I'd like to be sure that we know where we are going to. In blockdev-era where qemu user is aware about block nodes, all nodes have good names and controlled by user we can efficiently use block filters. We already have some

Re: [PATCH v11 05/13] copy-on-read: limit COR operations to base in COR driver

On 14.10.20 20:57, Andrey Shinkevich wrote: > On 14.10.2020 15:01, Max Reitz wrote: >> On 12.10.20 19:43, Andrey Shinkevich wrote: >>> Limit COR operations by the base node in the backing chain when the >>> overlay base node name is given. It will be useful for a block

Re: [PATCH v11 09/13] copy-on-read: skip non-guest reads if no copy needed

On 14.10.20 18:39, Vladimir Sementsov-Ogievskiy wrote: > 14.10.2020 19:30, Max Reitz wrote: >> On 14.10.20 17:22, Vladimir Sementsov-Ogievskiy wrote: >>> 14.10.2020 15:51, Max Reitz wrote: >>>> On 12.10.20 19:43, Andrey Shinkevich wrote: >>>>> If the fl

Re: [PATCH v11 04/13] copy-on-read: pass overlay base node name to COR driver

On 14.10.20 18:08, Andrey Shinkevich wrote: > On 14.10.2020 14:09, Max Reitz wrote: >> On 12.10.20 19:43, Andrey Shinkevich wrote: >>> We are going to use the COR-filter for a block-stream job. >>> To limit COR operations by the base node in the backing chain during &g

Re: [PATCH v11 09/13] copy-on-read: skip non-guest reads if no copy needed

On 14.10.20 17:22, Vladimir Sementsov-Ogievskiy wrote: > 14.10.2020 15:51, Max Reitz wrote: >> On 12.10.20 19:43, Andrey Shinkevich wrote: >>> If the flag BDRV_REQ_PREFETCH was set, pass it further to the >>> COR-driver to skip unneeded reading. It can be taken i

Re: [PATCH v11 04/13] copy-on-read: pass overlay base node name to COR driver

On 14.10.20 16:56, Vladimir Sementsov-Ogievskiy wrote: > 14.10.2020 14:57, Max Reitz wrote: >> On 14.10.20 13:09, Max Reitz wrote: >>> On 12.10.20 19:43, Andrey Shinkevich wrote: >>>> We are going to use the COR-filter for a block-stream job. >>>>

Re: [PATCH v11 02/13] copy-on-read: add filter append/drop functions

On 14.10.20 16:28, Andrey Shinkevich wrote: > On 14.10.2020 13:44, Max Reitz wrote: >> On 12.10.20 19:43, Andrey Shinkevich wrote: >>> Provide API for the COR-filter insertion/removal. >>> Also, drop the filter child permissions for an inactive state when the >&

Re: [PATCH v11 13/13] block: apply COR-filter to block-stream jobs

On 12.10.20 19:43, Andrey Shinkevich wrote: > This patch completes the series with the COR-filter insertion for > block-stream operations. Adding the filter makes it possible for copied > regions to be discarded in backing files during the block-stream job, > what will reduce the disk overuse. >

Re: [PATCH v11 12/13] stream: remove unused backing-file name parameter

On 12.10.20 19:43, Andrey Shinkevich wrote: > The 'backing-file' argument is not used by the block-stream job. It > designates a backing file name to set in QCOW2 image header after the > block-stream job finished. A backing file name of the node above base > is used instead. > > Signed-off-by:

Re: [PATCH v11 11/13] stream: mark backing-file argument as deprecated

On 12.10.20 19:43, Andrey Shinkevich wrote: > Whereas the block-stream job starts using a backing file name of the > base node overlay after the block-stream job completes, mark the QMP > 'backing-file' argument as deprecated. > > Signed-off-by: Andrey Shinkevich > --- >

Re: [PATCH v11 10/13] stream: skip filters when writing backing file name to QCOW2 header

On 12.10.20 19:43, Andrey Shinkevich wrote: > Avoid writing a filter JSON-name to QCOW2 image when the backing file > is changed after the block stream job. > > Signed-off-by: Andrey Shinkevich > --- > block/stream.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff

Re: [PATCH v11 09/13] copy-on-read: skip non-guest reads if no copy needed

On 12.10.20 19:43, Andrey Shinkevich wrote: > If the flag BDRV_REQ_PREFETCH was set, pass it further to the > COR-driver to skip unneeded reading. It can be taken into account for > the COR-algorithms optimization. That check is being made during the > block stream job by the moment. > >

Re: [PATCH v11 08/13] copy-on-read: add support for BDRV_REQ_PREFETCH to COR-filter

On 12.10.20 19:43, Andrey Shinkevich wrote: > Add support for the BDRV_REQ_PREFETCH flag to the supported_write_flags s/write/read/ > of the COR-filter. > > Signed-off-by: Andrey Shinkevich > --- > block/copy-on-read.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v11 07/13] block: include supported_read_flags into BDS structure

+++ > 1 file changed, 4 insertions(+) Not sure what the problem with passing BDRV_REQ_PREFETCH to drivers that aren’t the COR filter are would be, but: Reviewed-by: Max Reitz (I mean, outside of the context of COR the flag is undefined, so it can be anything, but intuitively I’d assume i

Re: [PATCH v11 06/13] block: modify the comment for BDRV_REQ_PREFETCH flag

On 12.10.20 19:43, Andrey Shinkevich wrote: > Modify the comment for the flag BDRV_REQ_PREFETCH as we are going to > use it alone and pass it to the COR-filter driver for further > processing. > > Signed-off-by: Andrey Shinkevich > --- > include/block/block.h | 7 --- > 1 file changed, 4

Re: [PATCH v11 05/13] copy-on-read: limit COR operations to base in COR driver

On 12.10.20 19:43, Andrey Shinkevich wrote: > Limit COR operations by the base node in the backing chain when the > overlay base node name is given. It will be useful for a block stream > job when the COR-filter is applied. The overlay base node is passed as > the base itself may change due to

Re: [PATCH v11 05/13] copy-on-read: limit COR operations to base in COR driver

On 12.10.20 19:43, Andrey Shinkevich wrote: > Limit COR operations by the base node in the backing chain when the > overlay base node name is given. It will be useful for a block stream > job when the COR-filter is applied. The overlay base node is passed as > the base itself may change due to

Re: [PATCH v11 04/13] copy-on-read: pass overlay base node name to COR driver

On 14.10.20 13:09, Max Reitz wrote: > On 12.10.20 19:43, Andrey Shinkevich wrote: >> We are going to use the COR-filter for a block-stream job. >> To limit COR operations by the base node in the backing chain during >> stream job, pass the name of overlay base node to the c

Re: [PATCH v11 04/13] copy-on-read: pass overlay base node name to COR driver

On 12.10.20 19:43, Andrey Shinkevich wrote: > We are going to use the COR-filter for a block-stream job. > To limit COR operations by the base node in the backing chain during > stream job, pass the name of overlay base node to the copy-on-read > driver as base node itself may change due to

Re: [PATCH v11 02/13] copy-on-read: add filter append/drop functions

ockDriverState *bs, > + QDict *node_options, > + int flags, Error **errp) I had hoped you could make this a generic block layer function. :( (Because it really is rather generic) *shrug* Reviewed-by: Max R

Re: [PATCH v6 01/10] qemu-img: Flush stdout before before potential stderr messages

On 06.07.20 22:39, Eric Blake wrote: > During 'qemu-img create ... 2>&1', if --quiet is not in force, we can > end up with buffered I/O in stdout that was produced before failure, > but which appears in output after failure. This is confusing; the fix > is to flush stdout prior to attempting

Re: [PATCH 0/3] Rmove support of tftp storage protocol

On 22.05.20 04:07, Han Han wrote: > > > On Thu, May 21, 2020 at 5:21 PM Daniel P. Berrangé > wrote: > > On Thu, May 21, 2020 at 04:05:47PM +0800, Han Han wrote: > > On Thu, May 21, 2020 at 2:44 PM Peter Krempa > wrote: > >

Re: [PATCH v2 0/2] finish qemu-nbd --partition deprecation

On 31.01.20 18:11, Eric Blake wrote: > ping Do you want further review or is Ján’s sufficient for you? Also, I wonder whether it would make a good GSoC/Outreachy/... project to add partition reading support to the raw block driver, or whether that’s a bad idea. O:-) Max signature.asc

Re: [PATCH 0/4] qemu: fix block jobs when copy_on_read is enabled

atches. The churn for each version is hard. Finding willing reviewers is even harder. (I actually have basically no reviews for one of those prerequisite series (“block: Introduce real BdrvChildRole”) yet, so there’s little point in working on v7 of the main series.) Max > > Cc: Max Re

Re: [PATCH] qemu-nbd: Removed deprecated --partition option

On 23.01.20 13:30, Eric Blake wrote: > On 1/23/20 6:10 AM, Max Reitz wrote: >> On 22.01.20 22:43, Eric Blake wrote: >>> The option was deprecated in 4.0.0 (commit 0ae2d546); it's now been >>> long enough with no complaints to follow through with that process. >&g

Re: [PATCH] qemu-nbd: Removed deprecated --partition option

On 22.01.20 22:43, Eric Blake wrote: > The option was deprecated in 4.0.0 (commit 0ae2d546); it's now been > long enough with no complaints to follow through with that process. > > Signed-off-by: Eric Blake > --- > qemu-deprecated.texi | 49 ++-- > qemu-nbd.c | 133

Re: [libvirt] [Qemu-devel] Exposing feature deprecation to machine clients

On 07.11.19 20:13, Vladimir Sementsov-Ogievskiy wrote: > 07.11.2019 21:52, Philippe Mathieu-Daudé wrote: >> Hi Markus, >> >> On 8/15/19 7:40 PM, John Snow wrote: >>> On 8/15/19 10:16 AM, Markus Armbruster wrote: John Snow writes: >> [...] > I asked Markus this not too long ago; do we

Re: [libvirt] [PATCH 0/1] dirty-bitmaps: remove deprecated autoload parameter

On 25.09.19 01:01, John Snow wrote: > I'm going to be honest, here. There's actually no real reason to remove > this now, but we could, so I'm going to. > > Also, in terms of the API serving as documentation, it's nicer to not > pretend this is an option that does anything, so out it goes. > >