Re: [libvirt] [PATCHv3] virt-aa-helper: Fix permissions for vhost-user socket files

2015-07-02 Thread Michał Dubiel
Thanks Michal. Regards. On 2 July 2015 at 11:22, Michal Privoznik mpriv...@redhat.com wrote: On 01.07.2015 10:15, Michal Dubiel wrote: QEMU working in vhost-user mode communicates with the other end (i.e. some virtual router application) via unix domain sockets. This requires that

Re: [libvirt] [PATCHv2] virt-aa-helper: Fix permissions for vhost-user socket files

2015-07-01 Thread Michał Dubiel
Hi Michal, I've sent v3 of the patch with the curly braces removed from one line 'if' blok. Sorry for that. Regards, Michal On 30 June 2015 at 16:41, Michal Privoznik mpriv...@redhat.com wrote: On 22.06.2015 12:47, Michal Dubiel wrote: QEMU working in vhost-user mode communicates with the

Re: [libvirt] [PATCH] virt-aa-helper: Fix permissions for vhost-user socket files

2015-06-22 Thread Michał Dubiel
On 19 June 2015 at 21:30, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Michal Dubiel (m...@semihalf.com): QEMU working in vhost-user mode communicates with the other end (i.e. some virtual router application) via unix domain sockets. This requires that permissions for the socket

Re: [libvirt] [PATCH] virt-aa-helper: Fix permissions for vhost-user socket files

2015-06-22 Thread Michał Dubiel
Besides by changing from : } else { if ((x) == -1)) return -1; to } else if ((x) == -1) { return -1; Everything else inside the else if after the return -1 becomes dead Yes it becomes dead, but there is nothing left in the 'else if' block.

Re: [libvirt] Socket files in virt-aa-helper

2015-06-19 Thread Michał Dubiel
(in separate thread) that adds these changes. Regards, Michal On 18 June 2015 at 17:11, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Jamie Strandboge (ja...@canonical.com): On 06/16/2015 08:40 AM, Michał Dubiel wrote: Hi all, May I kindly ask someone for some advice

Re: [libvirt] Socket files in virt-aa-helper

2015-06-18 Thread Michał Dubiel
Thanks Jamie for the explanation. Regards, Michal On 16 June 2015 at 17:15, Jamie Strandboge ja...@canonical.com wrote: On 06/16/2015 08:40 AM, Michał Dubiel wrote: Hi all, May I kindly ask someone for some advice on this topic? Regards, Michal On 21 May 2015 at 20:23, Michał

Re: [libvirt] Socket files in virt-aa-helper

2015-06-16 Thread Michał Dubiel
Hi all, May I kindly ask someone for some advice on this topic? Regards, Michal On 21 May 2015 at 20:23, Michał Dubiel m...@semihalf.com wrote: Hi guys, I have got a question. I need to add apparmor support for vhost-user socket files used to communicate with the vhost-user server app

[libvirt] Socket files in virt-aa-helper

2015-05-21 Thread Michał Dubiel
Hi guys, I have got a question. I need to add apparmor support for vhost-user socket files used to communicate with the vhost-user server app. Those ones defined with something like: interface type='vhostuser' mac address='02:ed:f3:5d:de:f3'/ source type='unix'