Re: [libvirt] libvirt-tck test failure after commit b3d06987

2016-06-02 Thread Mike Latimer
Hi Vasiliy, On Thursday, June 02, 2016 02:29:51 PM Vasiliy Tolstov wrote: > 2016-06-02 8:13 GMT+03:00 Jim Fehlig : > > We've noticed libvirt-tck test 100-apply-verify-host.t failing recently on > > libvirt.git master and I finally got around to bisecting it to commit > >

Re: [libvirt] [PATCH tck 5/6] Delay before hotplugging

2015-10-08 Thread Mike Latimer
Hi Daniel, On Thursday, October 08, 2015 10:20:48 AM Daniel P. Berrange wrote: > On Thu, Oct 08, 2015 at 10:17:23AM +0100, Daniel P. Berrange wrote: > > On Mon, Oct 05, 2015 at 05:18:42PM -0600, Mike Latimer wrote: > > > diag "Creating a new transient domain"; >

[libvirt] [PATCH tck 3/3] Disk allocation size should be zero

2015-10-05 Thread Mike Latimer
(sparse raw) and ~200K (qcow2)). Signed-off-by: Mike Latimer <mlati...@suse.com> --- scripts/domain/121-block-info.t | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/scripts/domain/121-block-info.t b/scripts/domain/121-block-info.t index e7e3491..64eeef2

[libvirt] [PATCH tck 2/3] Reorder and add qcow tests

2015-10-05 Thread Mike Latimer
All image types (allocated raw, sparse raw and qcow2) should be tested. Add qcow2 to the test matrix, and reorder for clarify. Signed-off-by: Mike Latimer <mlati...@suse.com> --- scripts/domain/121-block-info.t | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff

[libvirt] [PATCH tck 1/3] Rename volume1 variables

2015-10-05 Thread Mike Latimer
To avoid confusion between 'dst' and 'dst2' type of variables, rename all variables relating to the fully allocated raw volume to include the number '1'. (e.g. dst -> dst1, path -> path1, vol -> vol1, etc...) Signed-off-by: Mike Latimer <mlati...@suse.com> --- scripts/domain/1

[libvirt] [PATCH tck 0/3] Account for blockstats changes in 121-block-info.t

2015-10-05 Thread Mike Latimer
Hi, Due to libvirt commit 0282ca45, 121-block-info.t fails as the allocation size returned by block-info is now zero. While addressing this, a few aspects of the test were also cleaned up. The changes are not extensive, but it made more sense to submit them in a series. Thanks, Mike Mike

[libvirt] [PATCH tck 2/6] nwfilter startup and shutdown delay

2015-10-05 Thread Mike Latimer
changes introduced in libvirt-tck commit 83ef279c. Signed-off-by: Mike Latimer <mlati...@suse.com> --- lib/Sys/Virt/TCK/NetworkHelpers.pm| 2 +- scripts/nwfilter/100-ping-still-working.t | 2 +- scripts/nwfilter/210-no-mac-spoofing.t| 2 +- scripts/nwfilter/220-no-ip-spoo

[libvirt] [PATCH tck 6/6] Handle dnsmasq child processes

2015-10-05 Thread Mike Latimer
of the same process owned by the dnsmasq user. This patch resolves the problem by adding `uniq` to the command generating the process list. Signed-off-by: Mike Latimer <mlati...@suse.com> --- scripts/networks/networkxml2hostout/tck-testnet-1.dat | 2 +- scripts/networks/networkxml2hostout/tck-tes

[libvirt] [PATCH tck 1/6] Retrieve ip address from arp instead of leases

2015-10-05 Thread Mike Latimer
Libvirt commit 0f87054b adds the --leasefile-ro option to dnsmasq. This change results in the default.leases no longer containing the ip address for the test domain. Instead of using the leases file, use arp to provide the ip address. Signed-off-by: Mike Latimer <mlati...@suse.com> --- l

[libvirt] [PATCH tck 3/6] NUMA flags are exclusive

2015-10-05 Thread Mike Latimer
is restarted and the NUMA settings are compared to the default flags (stored prior to any AFFECT_LIVE changes). Signed-off-by: Mike Latimer <mlati...@suse.com> --- scripts/domain/202-numa-set-parameters.t | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/s

[libvirt] [PATCH tck 5/6] Delay before hotplugging

2015-10-05 Thread Mike Latimer
When testing larger domains, a delay is necessary to ensure the test domain is fully initialized before hotplugging disks and/or nics. Signed-off-by: Mike Latimer <mlati...@suse.com> --- scripts/domain/200-disk-hotplug.t | 1 + scripts/domain/210-nic-hotplug.t | 1 + scripts/doma

[libvirt] [PATCH tck 4/6] Remove cow format tests

2015-10-05 Thread Mike Latimer
Qemu removed support for the cow format in 550830f9. This patch drops all cow related tests in libvirt-tck. Signed-off-by: Mike Latimer <mlati...@suse.com> --- scripts/storage/100-create-vol-dir.t | 19 +-- scripts/storage/200-clone-vol-dir.t | 4 ++-- 2 files chan

[libvirt] [PATCH tck 0/6] Update TCK for current libvirt/qemu environments

2015-10-05 Thread Mike Latimer
shortly, dealing with issues in 121-block-info.t. Mike Latimer (6): Retrieve ip address from arp instead of leases nwfilter startup and shutdown delay NUMA flags are exclusive Remove cow format tests Delay before hotplugging Handle dnsmasq child processes lib/Sys/Virt/TCK/NetworkHelpers.pm

[libvirt] [PATCH tck 3/5] hooks/05[12]: Fix typo in skip

2015-01-26 Thread Mike Latimer
Correct the order of parameters passed to skip to ensure the following tests are only executed under qemu and lxc environments: hooks/051-daemon-hook.t hooks/052-domain-hook.t --- scripts/hooks/051-daemon-hook.t | 2 +- scripts/hooks/052-domain-hook.t | 2 +- 2 files changed, 2

[libvirt] [PATCH tck 2/5] nwfilter/050-apply-verify-host.t: Fix typo, cleanup filter

2015-01-26 Thread Mike Latimer
If nwfilter/050-apply-verify-host.t fails to start a test VM, a typo causes the word 'Domain' to be executed as a command after undefining the VM: ./nwfilter2vmtest.sh: line 425: Domain: command not found Also, if either one of the test VM fails to be created, the test filter should be deleted

[libvirt] [PATCH tck 1/5] hooks/051-daemon-hook: Return 0 after connection reset

2015-01-26 Thread Mike Latimer
Despite running all subtests successfully, hooks/051-daemon-hook.t ends with a return code of 141. This is due to the connection to tck not being cleaned up properly after libvirtd is restarted in the middle of the test. Ignoring the SIGPIPE and specifically undefining $tck allows the test to

[libvirt] [PATCH tck 5/5] Prevent list_snapshots from causing test cleanup failure

2015-01-26 Thread Mike Latimer
When TCK cleans up a test domain, existing snapshots are deleted. However, not all drivers (e.g. libxl) support snapshots. When such a driver is involved, the following error is reported and the testkit fails to cleanup the domain: libvirt error code: 3, message: this function is not supported

[libvirt] [PATCH tck 4/5] Ensure uri_transport is defined before using it

2015-01-26 Thread Mike Latimer
Under some environments (such as Xen), there may not be a uri_transport defined. As this is not required, ensure the value is defined before attempting to use it --- lib/Sys/Virt/TCK/Capabilities.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH 2/3] Grant access to helpers

2015-01-22 Thread Mike Latimer
On Thursday, January 22, 2015 08:55:07 AM Cedric Bosdonnat wrote: Seems like the apparmor profile for libvirtd is pretty wide open, so I'm not sure if there will be much of a difference between those two settings. I'm also not sure how best to test the functionality of those helpers to

Re: [libvirt] [PATCH 2/3] Grant access to helpers

2015-01-21 Thread Mike Latimer
On Tuesday, January 20, 2015 09:08:04 AM Cedric Bosdonnat wrote: On Mon, 2015-01-19 at 18:25 -0700, Mike Latimer wrote: Apparmor must not prevent access to required helper programs. The following helpers should be allowed to run in unconfined execution mode: - libvirt_parthelper

[libvirt] [PATCH 3/3] Fix apparmor issues for tck

2015-01-19 Thread Mike Latimer
The network and nwfilter tests contained in the libvirt-TCK testkit can fail unless access to raw network packets is granted. Without this access, the following apparmor error can be seen while running the tests: apparmor=DENIED operation=create parent=1 profile=/usr/sbin/libvirtd pid=94731

[libvirt] [PATCH 2/3] Grant access to helpers

2015-01-19 Thread Mike Latimer
Apparmor must not prevent access to required helper programs. The following helpers should be allowed to run in unconfined execution mode: - libvirt_parthelper - libvirt_iohelper --- examples/apparmor/usr.sbin.libvirtd | 2 ++ 1 file changed, 2 insertions(+) diff --git

[libvirt] [PATCH 1/3] Fix apparmor issues for Xen

2015-01-19 Thread Mike Latimer
In order for apparmor to work properly in Xen environments, the following access rights need to be allowed: - Allow CAP_SYS_PACCT, which is required when resetting some multi-port Broadcom cards by writting to the PCI config space - Allow CAP_IPC_LOCK, which is required to lock/unlock

[libvirt] [PATCH 0/3] Update example apparmor profile

2015-01-19 Thread Mike Latimer
. Mike Latimer (3): Fix apparmor issues for Xen Grant access to helpers Fix apparmor issues for tck examples/apparmor/usr.sbin.libvirtd | 6 ++ 1 file changed, 6 insertions(+) -- 1.8.4.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir

Re: [libvirt] [PATCH perl-Sys-Virt] Don't die if snapshots are unsupported

2014-04-22 Thread Mike Latimer
On Tuesday, April 22, 2014 11:35:31 AM Daniel P. Berrange wrote: Unfortunately this is a change in API behaviour that affects more than just the TCK. You need todo the equivalent change to the TCK code instead really. Ok. I didn't really view this as a change to the API, but I suppose it is.

[libvirt] [PATCH perl-Sys-Virt] Don't die if snapshots are unsupported

2014-04-21 Thread Mike Latimer
Many libvirt-tck tests do not explicitly cleanup test domains before exiting. In this case Sys::Virt::TCK-cleanup is triggered, and the environment is reset automatically. During this reset, any existing snapshots are found for deletion through Sys::Virt::Domain-list_snapshots. If the underlying

[libvirt] [PATCH tck] 202-numa-set-parameters.t: use AFFECT_CONFIG when changing nodeset

2014-04-09 Thread Mike Latimer
The 202-numa-set-parameters.t test sets NUMA_NODESET using AFFECT_LIVE on a running domain, destroys and starts the domain, then verifies the NUMA_NODESET setting. As AFFECT_LIVE does not write the setting to the domain xml file, the new nodeset setting is lost when the domain is destroyed and the

[libvirt] [PATCH tck] 300-vsitype.t: Skip after $tck is defined

2014-04-01 Thread Mike Latimer
With $tck added to the skip conditional, the entire codeblock has to be after $tck is defined. Also, $tck-cleanup should be added to the skip conditions. --- scripts/nwfilter/300-vsitype.t | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

[libvirt] [PATCH tck] 110-static-relabel-yes.t: Only 5 tests in 110-static-relabel

2014-04-01 Thread Mike Latimer
Trivial, but there are only 5 tests in 110-static-relabel-yes.t. --- scripts/selinux/110-static-relabel-yes.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/selinux/110-static-relabel-yes.t b/scripts/selinux/110-static-relabel-yes.t index f558cc9..76781ca 100644 ---

[libvirt] [PATCH tck] 220-no-ip-spoofing.t: Don't use a static netmask

2014-04-01 Thread Mike Latimer
For environments not using a /24 netmask, this test can end up in a hung state. This patch reads the netmask from the nic and uses it later when ip addresses are changed and restored. --- scripts/nwfilter/220-no-ip-spoofing.t | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[libvirt] [PATCH tck] 210-no-mac-spoofing.t: Catch network is unreachable error

2014-04-01 Thread Mike Latimer
Some environments (openSUSE 13.1) can report the network is unreachable during this test. Trap that condition as well. --- scripts/nwfilter/210-no-mac-spoofing.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/nwfilter/210-no-mac-spoofing.t

Re: [libvirt] [PATCH tck] Find ebtables in /sbin or /usr/sbin

2014-03-31 Thread Mike Latimer
On Friday, March 28, 2014 11:09:02 AM Mike Latimer wrote: If ebtables binary is not found in /sbin, use /usr/sbin. --- scripts/nwfilter/100-ping-still-working.t | 3 ++- scripts/nwfilter/210-no-mac-spoofing.t| 3 ++- scripts/nwfilter/220-no-ip-spoofing.t | 3 ++- scripts/nwfilter

Re: [libvirt] [PATCH tck] 100-ping-still-working.t: Replace vnet0 with mac address

2014-03-31 Thread Mike Latimer
On Friday, March 28, 2014 11:28:19 AM Mike Latimer wrote: Using a statically defined vnet0 may fail if multiple VMs are running on the test machine. Switch to mac address, but replace '00' with '0' to match the output of ebtables. --- scripts/nwfilter/100-ping-still-working.t | 4 ++-- 1

Re: [libvirt] [PATCH tck 5/6] Convert nwfilter and domain balloon tests to virtbuilder images

2014-03-31 Thread Mike Latimer
On Friday, March 28, 2014 12:26:31 PM Daniel P. Berrange wrote: Change tests which need a full OS image over to use the new virtbuilder images instead of provisioning from a kickstart file. This should make them much more reliable to run. Signed-off-by: Daniel P. Berrange berra...@redhat.com

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 12:26:26 PM Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no end of pain. Switch the tests over to use Richard Jones' virt-builder

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 03:16:37 PM Guido Günther wrote: On Fri, Mar 28, 2014 at 12:26:26PM +, Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no end

[libvirt] [PATCH tck] Find ebtables in /sbin or /usr/sbin

2014-03-28 Thread Mike Latimer
If ebtables binary is not found in /sbin, use /usr/sbin. --- scripts/nwfilter/100-ping-still-working.t | 3 ++- scripts/nwfilter/210-no-mac-spoofing.t| 3 ++- scripts/nwfilter/220-no-ip-spoofing.t | 3 ++- scripts/nwfilter/230-no-mac-broadcast.t | 3 ++-

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 05:31:13 PM Richard W.M. Jones wrote: libguestfs exists on SUSE. Olaf Hering is packaging it. Not sure about SLES, but I was under the impression it was packaged for at least some version of SLES. Right. I thought he was working on some virt-builder images as well,

[libvirt] [PATCH tck] 100-ping-still-working.t: Replace vnet0 with mac address

2014-03-28 Thread Mike Latimer
Using a statically defined vnet0 may fail if multiple VMs are running on the test machine. Switch to mac address, but replace '00' with '0' to match the output of ebtables. --- scripts/nwfilter/100-ping-still-working.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 05:34:19 PM Richard W.M. Jones wrote: On Fri, Mar 28, 2014 at 11:06:56AM -0600, Mike Latimer wrote: ACK to all of this. For some reason, Fedora 20 didn't want to install for me (it failed when resizing the disk, and I don't have time to chase it today), but Fedora

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 02:32:28 PM Daniel P. Berrange wrote: I already made it configurable - just change the OS name in the config file to any that virt-builder supports. Even better. I'm very much liking what I'm seeing in the patches - specifically patch 4/6. I'll try to test it today

Re: [libvirt] [PATCH tck 0/6] Fix tests which need a full OS image

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 12:26:26 PM Daniel P. Berrange wrote: A bunch of tests currently attempt to kickstart a full Fedora OS image install. Everytime I try to update this kickstart to a new version of Fedora it causes no end of pain. Switch the tests over to use Richard Jones' virt-builder

Re: [libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-28 Thread Mike Latimer
On Friday, March 28, 2014 12:28:43 PM Daniel P. Berrange wrote: On Thu, Mar 27, 2014 at 04:12:16PM -0600, Mike Latimer wrote: Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather than passing the test as 'ok'. So we're talking about

Re: [libvirt] [PATCH] Do not truncate output of nwfilter2vmtest.sh

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 11:45:06 AM Daniel P. Berrange wrote: When printing test results, nwfilter2vmtest.sh, truncates the output at 66 or 70 characters. This is very unhelpful when debugging problems where you want to see the full output Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Do not truncate output of nwfilter2vmtest.sh

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 11:10:15 AM Eric Blake wrote: New or not, your reviews are helpful! We all had to start somewhere. And right now, the fact that you are attempting to run tck gives you better status as a reviewer, even if only to say I applied this, and it {still passed for

Re: [libvirt] [PATCH tck] Change 'Sys::Virt::TCK::generic_domain' to take named params

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 02:49:11 PM Daniel P. Berrange wrote: To make it easier to add more optional parameters to the Sys::Virt::TCK::generic_domain method, change it to take named parameters instead of positional parameters. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] [PATCH tck] Fix 202-numa-set-parameters.t test querying numa params

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 03:38:47 PM Daniel P. Berrange wrote: The 202-numa-set-parameters.t test would attempt to fetch NUMA parameters while the guest is shutoff using the VIR_DOMAIN_AFFECT_LIVE parameter. Change it to use the param AFFECT_CONFIG instead, and add a separate test for

Re: [libvirt] [PATCH tck] Adapt network tests to changed cli tool formats

2014-03-27 Thread Mike Latimer
On Thursday, March 27, 2014 02:49:25 PM Daniel P. Berrange wrote: The network tests invoke various ifconfig and route commands to test network setup, and also grep for dnsmasq/radvd args. Switch to use 'ip' since ifconfig and route commands are not installed by default on recent distros any

[libvirt] [PATCH tck] 300-vsitype.t: skip earlier if lldptool is not available

2014-03-27 Thread Mike Latimer
Move the test for /usr/sbin/lldptool up so libvirt-tck will report the skip and reason, rather than passing the test as 'ok'. --- scripts/nwfilter/300-vsitype.t | 48 ++ 1 file changed, 25 insertions(+), 23 deletions(-) diff --git

[libvirt] [PATCH tck] Remove /128 from ip6tables output

2014-03-27 Thread Mike Latimer
Due to iptables commit 945353a2 (in iptables v1.4.20 and higher), ip6tables no longer prints out /128. This patch removes /128 from output files, and replaces '/128' in command output with '' to remain compatible with older versions of ip6tables. ---

[libvirt] [TCK] nwfilter tests and libvirt commit 4f209434

2014-03-26 Thread Mike Latimer
Hi, As I've been looking through libvirt-tck tests, I found that commit 4f209434 (in libvirt) changes a condition that the nwfilter/050-apply-verify-host.t relies on. Specifically, the 050-apply-verify-host.t test creates a number of filters with invalid values (such as dscp='64', and

Re: [libvirt] [PATCH] libvirt-tck: 052-domain-hook.t - reload after hook cleanup

2014-03-25 Thread Mike Latimer
06, 2014 03:41:01 PM Mike Latimer wrote: Reload libvirtd after hook testing has completed. Otherwise, libvirtd is still expecting hook test scripts to exist. --- scripts/hooks/052-domain-hook.t | 4 1 file changed, 4 insertions(+) diff --git a/scripts/hooks/052-domain-hook.t b

[libvirt] [TCK][PATCH] Remove whitespace differences in network tmp files

2014-03-24 Thread Mike Latimer
The network/100-apply-verify-host.t test compares the results of various network commands (route, iptables, ebtables, etc...) against known, valid results. Depending on the versions of these tools, minor whitespace differences in command output can result in the failure of the test. This patch

Re: [libvirt] [PATCH v2] libvirt-tck: prefer kvm domains if multiple domain types exist

2014-03-24 Thread Mike Latimer
Ping. Has anyone (possibly Osier) had a chance to review this patch? On Friday, March 07, 2014 11:06:35 AM Mike Latimer wrote: When matching capabilities of a guest, if multiple domain types exist (for example, 'qemu' and 'kvm') the order in which they are returned can change. To avoid

[libvirt] [TCK][PATCH] Enable tests with a .pl extension

2014-03-24 Thread Mike Latimer
The main libvirt-tck script only executes tests using the default (.t) extension. This patch adds .t and .pl as valid extensions using the --ext parameter. This is required to enable storage tests added in commit 97c6a506. --- Build.PL| 2 +- bin/libvirt-tck | 5 + 2 files changed, 6

[libvirt] [TCK][PATCH] Rename .pl tests to .t

2014-03-24 Thread Mike Latimer
Commit 97c6a506 added several storage tests with a .pl extension. Rather than enable .pl tests, this patch simply renames these tests to .t. --- scripts/storage/{400-vol-download.pl = 400-vol-download.t} | 0 scripts/storage/{405-vol-download-all.pl = 405-vol-download-all.t}

Re: [libvirt] [TCK][PATCH] Enable tests with a .pl extension

2014-03-24 Thread Mike Latimer
On Monday, March 24, 2014 04:55:38 PM Daniel P. Berrange wrote: On Mon, Mar 24, 2014 at 10:42:35AM -0600, Mike Latimer wrote: The main libvirt-tck script only executes tests using the default (.t) extension. This patch adds .t and .pl as valid extensions using the --ext parameter

Re: [libvirt] [TCK][PATCH] Remove whitespace differences in network tmp files

2014-03-24 Thread Mike Latimer
On Monday, March 24, 2014 02:24:23 PM Eric Blake wrote: 'sed -i' is not portable (it is a GNU-ism) - but it's not the first time we've assumed GNU tools in this testsuite so I can overlook it. Ok. I'll keep that in mind in the future. If you'd rather the -i not be used, it's easy enough to

Re: [libvirt] [PATCH] libvirt-tck: Ignore SIGPIPE in 051-daemon-hook.t

2014-03-14 Thread Mike Latimer
Sorry for the slow response, I've been distracted with other projects. On Monday, March 10, 2014 09:25:37 PM Osier Yang wrote: Hm, $tck-cleanup() doesn't close the connection, it just destroy and undefine the existing domains, networks, and pools. snip sub reset { my $self = shift;

Re: [libvirt] [PATCH] libvirt-tck: Update hook syntax for libvirt 0.9.0+

2014-03-10 Thread Mike Latimer
On Friday, March 07, 2014 08:54:26 AM Eric Blake wrote: On 03/07/2014 02:02 AM, Osier Yang wrote: On 07/03/14 00:27, Mike Latimer wrote: Starting with libvirt 0.9.0+, hook scripts can be called from several new locations. These locations must also be reflected in the expected logs

Re: [libvirt] [PATCH] libvirt-tck: Update hook syntax for libvirt 0.9.0+

2014-03-07 Thread Mike Latimer
On Friday, March 07, 2014 05:02:00 PM Osier Yang wrote: ACK, but wondering why we didn't discover it, according to the log for the hook scripts have been changed. I'm not sure why this hasn't been seen before. The only thing that makes sense is that the hook tests haven't been tested since the

Re: [libvirt] [PATCH] libvirt-tck: Ignore SIGPIPE in 051-daemon-hook.t

2014-03-07 Thread Mike Latimer
On Friday, March 07, 2014 05:16:48 PM Osier Yang wrote: $hook-cleanup(); + +# Restarting libvirtd broke the tck connection, so ignore sigpipe and +# undefine $tck to avoid a return code of 141 +$SIG{PIPE} = 'IGNORE'; +undef $tck; We should get the libvirt

Re: [libvirt] [PATCH] libvirt-tck: prefer kvm if multiple domain types exist

2014-03-07 Thread Mike Latimer
On Friday, March 07, 2014 05:55:34 PM Osier Yang wrote: - return ($domains[0], +# Prefer kvm if multiple domain types are returned +my $domain; +if (int(@domains) gt 1) { +for (my $j = 0 ; $j int(@domains) ; $j++) { I would use grep instead

[libvirt] [PATCH v2] libvirt-tck: prefer kvm domains if multiple domain types exist

2014-03-07 Thread Mike Latimer
When matching capabilities of a guest, if multiple domain types exist (for example, 'qemu' and 'kvm') the order in which they are returned can change. To avoid unpredictable test results, this patch prefers kvm if that domain type exists. If not, the behavior matches what existed before, and the

[libvirt] [PATCH] libvirt-tck: Update hook syntax for libvirt 0.9.0+

2014-03-06 Thread Mike Latimer
Starting with libvirt 0.9.0+, hook scripts can be called from several new locations. These locations must also be reflected in the expected logs of the hook tests. The final test in 052-domain-hook.t intentionally produces a failed start, which should show the first stage in the startup hook

[libvirt] [PATCH] libvirt-tck: Ignore SIGPIPE in 051-daemon-hook.t

2014-03-06 Thread Mike Latimer
This test completes successfully, but results in a return code of 141 due to a broken pipe when restarting libvirtd. This patch just masks the SIGPIPE and undefines $tck to avoid the 141 return code. If there is a way to reestablish the tck connection after the restart, that would be a better

[libvirt] [PATCH] libvirt-tck: prefer kvm if multiple domain types exist

2014-03-06 Thread Mike Latimer
When matching capabilities of a guest, if multiple domain types exist (for example, 'qemu' and 'kvm') the order in which they are returned can change. To avoid unpredictable test results, this patch prefers kvm if that domain type exists. If not, the behavior matches what existed before, and the

[libvirt] [PATCH] libvirt-tck: 052-domain-hook.t - reload after hook cleanup

2014-03-06 Thread Mike Latimer
Reload libvirtd after hook testing has completed. Otherwise, libvirtd is still expecting hook test scripts to exist. --- scripts/hooks/052-domain-hook.t | 4 1 file changed, 4 insertions(+) diff --git a/scripts/hooks/052-domain-hook.t b/scripts/hooks/052-domain-hook.t index