Re: [libvirt PATCH 1/1] conf: move graphics validation checks out of *ParseXML function.

2020-07-30 Thread Nicolás Brignone
Hi! Is this going to be merged? Do I need to do something else? Thanks! On Fri, Jul 24, 2020 at 5:08 PM Jonathon Jongsma wrote: > On Wed, 2020-07-22 at 14:56 -0300, Nicolas Brignone wrote: > > Existing virDomainDefPostParseGraphics function seems to be the right > > place to put this

Re: [libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-09 Thread Nicolás Brignone
Ack, Thanks! On Thu, Jul 9, 2020 at 2:48 PM Daniel P. Berrangé wrote: > > On Thu, Jul 09, 2020 at 02:40:34PM -0300, Nicolás Brignone wrote: > > On Thu, Jul 9, 2020 at 5:15 AM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Jul 08, 2020 at 11:15:27PM -040

Re: [libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-09 Thread Nicolás Brignone
On Thu, Jul 9, 2020 at 5:15 AM Daniel P. Berrangé wrote: > > On Wed, Jul 08, 2020 at 11:15:27PM -0400, Laine Stump wrote: > > On 7/8/20 4:19 PM, Nicolas Brignone wrote: > > > All pointers to virXMLPropString() use g_autofree. > > > > > > I changed the summary line like this, to be more precise:

Re: [libvirt PATCH] All pointers to virXMLPropString() use g_autofree.

2020-07-09 Thread Nicolás Brignone
On Thu, Jul 9, 2020 at 12:15 AM Laine Stump wrote: > > On 7/8/20 4:19 PM, Nicolas Brignone wrote: > > All pointers to virXMLPropString() use g_autofree. > > > I changed the summary line like this, to be more precise: > > > conf: use g_autofree for all pointers to virXMLPropString() in