[libvirt] PING: [RFC] vhost-user + shared memory + NUMA

Hello! Sorry, but i did not get any answer to the last question. Would it be OK to require and implicitly add only shared mode ? Kind regards, Pavel Fedin Senior Engineer Samsung Electronics Research center Russia > -Original Message- > From: libvir-list-boun...@redh

Re: [libvirt] [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version

Hello! > I know Pavel Fedin was trying to revive kernel_irqchip=off once, > but I don't know if that effort was abandoned or not. It should work with the latest kernel, at least i posted patches and all of them were applied. If nothing got broken during later rewrites. The only missin

Re: [libvirt] [RFC] vhost-user + shared memory + NUMA

gs override it if needed. Well, the only little drawback would be necessity to add "shared" by itself. This would require additional patching to clients (e. g. openstack). Kind regards, Pavel Fedin Senior Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [RFC] vhost-user + shared memory + NUMA

n with shared memory? For example, it could be memory-backend-file on /dev/mem. If the community agrees that it's a good idea, improving the usability, i can propose patches. Kind regards, Pavel Fedin Senior Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-l

Re: [libvirt] [RFC] vhost-user + shared memory + NUMA

d compromise if we require , and only implicitly add "shared" if we have vhost-user devices? This way we would not change the way the guest memory is allocated. IMHO being able to manually specify "shared" both in and in would be ambiguous. Kind regards, Pavel Fedin Senior Engine

Re: [libvirt] [Qemu-devel] ARM KVM GICv3 Support

is used. Currently we can have v3 only with KVM, but when software emulation is implemented, it can be used in all cases, regardless of host KVM restrictions. > That should work for every QEMU version, right? Wrong. See (1) above. Kind regards, Pavel Fedin Senior Engineer Samsung Elect

Re: [libvirt] ARM KVM GICv3 Support

ations, once "virt" type is chosen, should be able to present one more control to choose between GIC versions. Just think of it as "machine sub-type". Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] How should libvirt apps enable virtio-pci for aarch64?

rated the Q35 machine and the bridge also breaks down. 'lspci -v' starts reporting "Unknown header type: 7f" for the bridge and for all devices behind it (and all devices fail). But it just means it should be fixed in qemu. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research

Re: [libvirt] How should libvirt apps enable virtio-pci for aarch64?

for MSI-X to work. I could also leave devices at bus#2, just in this case i don't get MSI-X, and this, for example, makes vhost-net unable to use irqfds (or it cannot initialize at all, again, i already don't remember), because this requires per-event irqs. Kind regards, Pavel Fedin Expert Engineer Samsu

Re: [libvirt] How should libvirt apps enable virtio-pci for aarch64?

ce is currently hardcoded to be PCIe for video cards and, IIRC, SCSI; and plain PCI for everything else. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] How should libvirt apps enable virtio-pci for aarch64?

low to have a simple "Address type" switch in e.g. virt-manager, so that i would be able to easily choose a way which the device uses to connect to the system. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

other, memory-mapped timer, which can be used with software emulation. And it works. Well, if you think that this is not ready for the wide public yet, we can leave out this part. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/3] Add support for gic-version machine option

perty unless value different from 2 is explicitly specified in the XML. I guess, virt-manager could also default to '2' (or 'Hypervisor's default', which would be the same). Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

se: Yes, ACK. > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > _("gic-version option is available " > "only for virt machine")); Then "...only for ARM vi

Re: [libvirt] [PATCH v2 0/3] Add support for gic-version machine option

use this is kind of different architecture. But Peter Maydell disagreed and insisted on option. So we have an option. > When would apps like virt-manager want to enable it? When choosing 'virt' machine type for ARM architecture. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Re

[libvirt] [PATCH v2 2/3] qemu: Add support for gic-version machine option

in order to keep backward compatibility with older qemu versions. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- src/qemu/qemu_command.c | 43 ++- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_command.c b/sr

[libvirt] [PATCH v2 3/3] qemu: Add test cases for gic-version option

These tests make sure that we can use this option only when the capability is set. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- .../qemuxml2argv-aarch64-gicv3.args| 6 + .../qemuxml2argv-aarch64-gicv3.xml | 26 ++

[libvirt] [PATCH v2 0/3] Add support for gic-version machine option

qemu now supports gic-version option for the virt machine. This patchset allows to use it in libvirt. v1 => v2: - Added capability flag Pavel Fedin (3): qemu: Introduce QEMU_CAPS_MACH_VIRT_GIC_VERSION capability qemu: Add support for gic-version machine option qemu: Add test cases for

[libvirt] [PATCH v2 1/3] qemu: Introduce QEMU_CAPS_MACH_VIRT_GIC_VERSION capability

Unfortunately qemu currently doesn't offer introspection for machine types, so we have to rely on version number, similar to QEMU_CAPS_MACHINE_USB_OPT. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + 2 files c

Re: [libvirt] [PATCH 0/2] Add support for gic-version machine option

o support for getting machine properties in QMP. Or, at least, it's not documented. The easy way would be based on version number (actually we already do this with QEMU_CAPS_MACHINE_USB_OPT). Will it be OK? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-lis

[libvirt] [PATCH 2/2] qemu: Add test case for gic-version option

Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- .../qemuxml2argv-aarch64-gicv3.args| 6 + .../qemuxml2argv-aarch64-gicv3.xml | 26 ++ tests/qemuxml2argvtest.c | 2 ++ 3 files changed, 34 insertions(+)

[libvirt] [PATCH 0/2] Add support for gic-version machine option

qemu now supports gic-version option for the virt machine. This patch allows to use it in libvirt. I decided not to add a new capability because qemu correctly complains by itself if it does not have this option. Pavel Fedin (2): qemu: Add support for gic-version machine option qemu: Add

[libvirt] [PATCH 1/2] qemu: Add support for gic-version machine option

in order to keep backward compatibility with older qemu versions. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- src/qemu/qemu_command.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b

[libvirt] [PATCH v2] Ignore virtio-mmio disks in qemuAssignDevicePCISlots()

that qemuAssignDevicePCISlots() was never called for ARM "virt" machine. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- v1 => v2 - Added check for QEMU_CAPS_DEVICE_VIRTIO_MMIO, this leaves the error message for machines which actually do not support virtio-mmio. In thi

Re: [libvirt] [PATCH] Ignore virtio-mmio disks in qemuAssignDevicePCISlots()

. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Ignore virtio-mmio disks in qemuAssignDevicePCISlots()

that's another problem). > And that is what we should keep for architectures without virtio-mmio > support, shouldn't we? Agree, thanks for testing. I don't have x86 installation here. I will make v2 which will check for QEMU_CAPS_DEVICE_VIRTIO_MMIO capability. Kind regards, Pavel Fedin Expert Engineer

Re: [libvirt] [PATCH v2] Ignore virtio-mmio disks in qemuAssignDevicePCISlots()

still waiting for the review. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] Ignore virtio-mmio disks in qemuAssignDevicePCISlots()

Hello! > There is no qemuCaps here, you have to pas it the whole way. Damn, sorry, it went away in a3ecd63e928ff39d73c1c14b0fb3be8addbc977b. I use older version for my distro, and the patch seemed to be so simple, so i decided not to do even compile test :) Respinning... Kind regards, Pa

[libvirt] [PATCH v3] Ignore virtio-mmio disks in qemuAssignDevicePCISlots()

that qemuAssignDevicePCISlots() was never called for ARM "virt" machine. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- v2 => v3 - Bring back qemuCaps to qemuAssignDevicePCISlots(), was lost in a3ecd63e928ff39d73c1c14b0fb3be8addbc977b - Swap conditions so as not to call vir

[libvirt] [PATCH v2 2/3] Use mockup cache

Use the new API in order to correctly add capability sets to the cache before parsing XML files Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- tests/domainsnapshotxml2xmltest.c | 15 --- tests/qemuagenttest.c | 18 +- tests/qemuargv2xml

[libvirt] [PATCH v2 0/3] Implement mockup capabilities cache in QEMU tests

d qemuTestDriverFree(). V1 => V2 - Fix also domainsnapshotxml2xmltest RFC => v1 - Major rework, almost everything changed. Pavel Fedin (3): Implement infrastracture for mocking up QEMU capabilities cache Use mockup cache Removed unneeded check src/qemu/qemu_capabilities.c

Re: [libvirt] [PATCH 2/3] Use mockup cache

would differ from test name, and the same set would be reused across tests which need equal capabilities. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 1/3] Implement infrastracture for mocking up QEMU capabilities cache

the test suite to actually populate the cache. Third, two utility functions are introduced for proper initialization and cleanup of the driver. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- src/qemu/qemu_capabilities.c | 16 +--- src/qemu/qemu_capspriv.h

Re: [libvirt] [PATCH 2/3] Use mockup cache

tests. Sorry, totally no time to do this rework now. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 3/3] Removed unneeded check

Since test suite now correctly creates capabilities cache, the hack is not needed any more. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- src/qemu/qemu_domain.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

[libvirt] [PATCH] Ignore virtio-mmio disks in qemuAssignDevicePCISlots()

Fixes the following error when attempting to add a disk with bus='virtio': virtio only support device address type 'PCI' Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- src/qemu/qemu_command.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_com

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

but just in case: http://www.redhat.com/archives/libvir-list/2015-September/msg00084.html Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

ecause i believe we want to exercise the actual library code, and not some test-only code. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 3/3] Removed unneeded check

Since test suite now correctly creates capabilities cache, the hack is not needed any more. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- src/qemu/qemu_domain.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

[libvirt] [PATCH 0/3] Implement mockup capabilities cache in QEMU tests

d qemuTestDriverFree(). I don't include changelist because this is a major rework of the RFC, almost everything has been changed. Pavel Fedin (3): Implement infrastracture for mocking up QEMU capabilities cache Use mockup cache Removed unneeded check src/qemu/qemu_capabilities.c | 16 ++

[libvirt] [PATCH 1/3] Implement infrastracture for mocking up QEMU capabilities cache

the test suite to actually populate the cache. Third, two utility functions are introduced for proper initialization and cleanup of the driver. Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- src/qemu/qemu_capabilities.c | 16 +--- src/qemu/qemu_capspriv.h

[libvirt] [PATCH 2/3] Use mockup cache

Use the new API in order to correctly add capability sets to the cache before parsing XML files Signed-off-by: Pavel Fedin <p.fe...@samsung.com> --- tests/qemuagenttest.c| 18 +- tests/qemuargv2xmltest.c | 19 +-- tests/qemuhotplugtest.c

Re: [libvirt] PING: [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

, unfortunately i was unable to get a US visa in time, so my attendance failed. :( Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] PING: [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

then, no response... Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Pavel Fedin Sent: Tuesday, August 18, 2015 12:40 PM To: libvir-list@redhat.com Cc

[libvirt] [RFC PATCH 2/3] Use mockup cache

Create capabilities cache using neq qemuTestMakeCapsCache() before parsing XML files Signed-off-by: Pavel Fedin p.fe...@samsung.com --- tests/qemuagenttest.c| 9 - tests/qemuargv2xmltest.c | 5 + tests/qemuhotplugtest.c | 23 +++ tests/qemuxml2argvtest.c

[libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

, such a design looks like an ugly hack by itself, so i stopped going in this direction. Comments and opinions are welcome. Pavel Fedin (3): Implement virQEMUCapsCache mockup Use mockup cache Removed unneeded check src/qemu/qemu_capabilities.c | 10 +- src/qemu/qemu_capspriv.h | 36

[libvirt] [RFC PATCH 3/3] Removed unneeded check

Since test suite now correctly creates capabilities cache, the hack is not needed any more. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_domain.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[libvirt] [RFC PATCH 1/3] Implement virQEMUCapsCache mockup

with architecture name, with some exceptions. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_capabilities.c | 10 +- src/qemu/qemu_capspriv.h | 36 +++ tests/testutilsqemu.c| 45 tests

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

compatibility with existing distros, which even don't enable PCI-Generic for both ARM architectures (and indeed ARM64 support for PCI-Generic is going to be enabled in upstream kernel v4.3 only). To tell the truth i'm too lazy now to look up relevant threads. Kind regards, Pavel Fedin Expert Engineer

Re: [libvirt] [PATCH] Revert qemu: Allow to plug virtio-net-pci into PCIe slot

will retest. Now i've got motivation to finally rebuild the RPM... Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Revert qemu: Allow to plug virtio-net-pci into PCIe slot

of those changes during the development of my series, sorry. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

-upstream (pcie-switch-upstream-port), and xio3130-downstream (pcie-switch-downstream-port). Didn't try that, but don't see why they would not work. PCI is just PCI after all, everything behing the controller is pretty much standard and arch-independent. Kind regards, Pavel Fedin Expert Engineer

Re: [libvirt] [PATCH v5 2/4] qemu: Add PCI-Express root to ARM virt machine

happens after any change. So from that POV, maybe we should just clean up the current merged patch so that it is properly exercised in the test suite by providing capabilities I will try to do it soon. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

Re: [libvirt] [PATCH v5 2/4] qemu: Add PCI-Express root to ARM virt machine

. virt machine (unversioned one) already has PCI. 2. qemu people don't want to have versioned virt. I already proposed this for GICv3 and they strictly refused. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v5 2/4] qemu: Add PCI-Express root to ARM virt machine

regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 2/4] qemu: Add PCI-Express root to ARM virt machine

shouldn't be that difficult. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 2/4] qemu: Add PCI-Express root to ARM virt machine

regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 2/4] qemu: Add PCI-Express root to ARM virt machine

not create the cache, instead it builds caps object directly and passes around the pointer to all functions which take it. It is actually not really difficult to fix this. The test suite should mock up qemuCapsCache too. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

Re: [libvirt] [PATCH v5 2/4] qemu: Add PCI-Express root to ARM virt machine

. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

Yeah, that's a good question. In a real world, PCIe is perfectly hot pluggable. Maybe the limitation comes from qemu? OTOH, why do we require devices to be hotpluggable ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

prevents them from using MSI-X. For example virtio-scsi still suffers from this problem. I ignore it for now because we currently don't have vhost-scsi support in qemu. Comments say that PCIe is not hotpluggable. But why? And why do we mandate hotplug? Kind regards, Pavel Fedin Expert Engineer Samsung

[libvirt] PING-2: [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

Hello! Can anybody tell me what is wrong with this? Ignored for a long time. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Pavel

[libvirt] PING: [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

PING Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Pavel Fedin Sent: Friday, July 17, 2015 2:28 PM To: libvir-list@redhat.com Cc

Re: [libvirt] Libvirt error in Openstack Tempest attaching disk on arm64 system

for the review, i have posted several versions, but got no single response during ~3 weeks. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

with existing installations. PCI bus has to be explicitly specified. - Check for the capability in correct place, in v2 it actually did not work Changes since v1: - Added capability based on qemu version number - Recognize also virt- prefix Pavel Fedin (4): qemu: Introduce QEMU_CAPS_OBJECT_GPEX

[libvirt] [PATCH v5 2/4] qemu: Add PCI-Express root to ARM virt machine

Here we assume that if qemu supports generic PCI host controller, it is a part of virt machine and can be used for adding PCI devices. In qemu this is actually a PCIe bus, so we also declare multibus capability so that 0'th bus is specified to qemu correctly as 'pcie.0' Signed-off-by: Pavel

[libvirt] [PATCH v5 1/4] qemu: Introduce QEMU_CAPS_OBJECT_GPEX

This capability specifies that qemu can implement generic PCI host controller. It is often used for virtual environments, including ARM. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 3 insertions

[libvirt] [PATCH v5 4/4] qemu: Allow to plug virtio-net-pci into PCIe slot

virtio-net-pci adapter is capable to use irqfd with vhost-net only in MSI-X mode, which appears to be available only on PCIe bus, at least on ARM Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_command.c | 8 1 file changed, 8 insertions(+) diff --git a/src/qemu

[libvirt] [PATCH v5 3/4] qemu: Build correct command line for PCI NICs on ARM

Legacy -net option works correctly only with embedded device models, which do not require any bus specification. Therefore, we should use -device for PCI hardware Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [libvirt] [PING: PATCH v4 0/3] Allow PCI virtio on ARM virt machine

Knock-knock!!! Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Pavel Fedin Sent: Thursday, July 09, 2015 12:11 PM To: libvir-list

[libvirt] [PATCH v4 0/3] Allow PCI virtio on ARM virt machine

capability based on qemu version number - Recognize also virt- prefix Pavel Fedin (3): Introduce QEMU_CAPS_OBJECT_GPEX Add PCI-Express root to ARM virt machine Build correct command line for PCI NICs on ARM src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu

[libvirt] [PATCH v4 3/3] Build correct command line for PCI NICs on ARM

Legacy -net option works correctly only with embedded device models, which do not require any bus specification. Therefore, we should use -device for PCI hardware Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[libvirt] [PATCH v4 2/3] Add PCI-Express root to ARM virt machine

Here we assume that if qemu supports generic PCI host controller, it is a part of virt machine and can be used for adding PCI devices. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_domain.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH v4 1/3] Introduce QEMU_CAPS_OBJECT_GPEX

This capability specifies that qemu can implement generic PCI host controller. It is often used for virtual environments, including ARM. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 3 insertions

[libvirt] [PATCH v2 1/2] Remove explicit enum from protocol structures

Explicit 'enum' keyword does not work with portablexdr-rpcgeb, causing its parser to fail. Fix method is borrowed from virnetprotocol.x Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/lxc/lxc_monitor_protocol.x | 2 +- src/lxc_monitor_protocol-structs | 2 +- 2 files changed, 2

[libvirt] [PATCH v2 0/2] Add support for portable-rpcgen from portablexdr library

, fix make syntax-check Pavel Fedin (2): Remove explicit enum from protocol structures Add support for portable-rpcgen from portablexdr library configure.ac | 2 +- src/lxc/lxc_monitor_protocol.x | 2 +- src/lxc_monitor_protocol-structs | 2 +- src/rpc/genprotocol.pl

[libvirt] [PATCH v2 2/2] Add support for portable-rpcgen from portablexdr library

This allows to build libvirt under MinGW Signed-off-by: Pavel Fedin p.fe...@samsung.com --- configure.ac | 2 +- src/rpc/genprotocol.pl | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index cd6c972..6533b88 100644 --- a/configure.ac

Re: [libvirt] [PATCH v3 2/3] Add PCI-Express root to ARM virt machine

. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

--- Here virNetMessageType and virNetMessageStatus are enums. Actually i borrowed fix method from here. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 1/3] Introduce QEMU_CAPS_ARM_VIRT_PCI

it to 'virt' machine. So, i could query for this flag and count it as capability. But - it only says that qemu knows this device in principle. It does not say that this device is really a part of virt machine. Will it be acceptable ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research

Re: [libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

to work with older OSes. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

This patch allows to build libvirt natively under MinGW/MSYS using portablexdr library. An updated version of portablexdr with fixed bugs is available as part of MSYS2 project. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- configure.ac | 2 +- src/lxc

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

: a) Change the default to PCI, for better performance; or: b) Leave the default as it is, but make explicit address type='pci' working? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

[libvirt] [PATCH v3 3/3] Build correct command line for PCI NICs on ARM

Legacy -net option works correctly only with embedded device models, which do not require any bus specification. Therefore, we should use -device for PCI hardware Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[libvirt] [PATCH v3 0/3] Allow PCI virtio on ARM virt machine

also virt- prefix Pavel Fedin (3): Introduce QEMU_CAPS_ARM_VIRT_PCI Add PCI-Express root to ARM virt machine Build correct command line for PCI NICs on ARM src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 3 ++- src/qemu

[libvirt] [PATCH v3 2/3] Add PCI-Express root to ARM virt machine

Add PCI Express root complex if the corresponding capability is present Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_domain.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index f9bf32c

[libvirt] [PATCH v3 1/3] Introduce QEMU_CAPS_ARM_VIRT_PCI

This capability specifies that virt machine on ARM has PCI controller. Enabled when qemu version is at least 2.3.0. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + 2 files changed, 6 insertions(+) diff --git a/src

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

implemented MSI on top of that (a small patch is needed). I believe distro maintainers could pick them up. PCI support gives great performance advantage, you can use vhost-net with irqfds. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing

Re: [libvirt] [PATCH] Added support for portable-rpcgen from portablexdr library

PING! Eric: I hope you are the right person ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Pavel Fedin Sent: Tuesday, June 23, 2015

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

kernel? Why? Shouldn't this be fixed then? virtio-PCI has much better performance than virtio-mmio, because you can use vhost-net with irqfds on it. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH] Revert Introduce QEMU_CAPS_ARM_VIRT_PCI

this is another story. :( Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -Original Message- From: Michal Privoznik [mailto:mpriv...@redhat.com] Sent: Tuesday, June 30, 2015 1:02 PM To: Peter Krempa; libvir-list@redhat.com Cc: Pavel Fedin; Cole Robinson

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

weeks have passed. I could write these tests if somebody explains me how our unit-testing works and where to put them. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

. To tell the truth i'm not familiar with libvirt's unit-test system. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Added support for portable-rpcgen from portablexdr library

This patch allows to build libvirt natively under MinGW/MSYS using portablexdr library. An updated version of portablexdr with fixed bugs is available as part of MSYS2 project. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- configure.ac | 2 +- src/lxc

[libvirt] PING: [PATCH v2 0/2] Allow PCI virtio on ARM virt machine

Knock-knock??? Sorry for possibly repeated PING, but i see that mailing list for some reason strips CC:'s if specified without real name, so retry with name this time. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -Original Message- From

[libvirt] PING: [PATCH v2 0/2] Allow PCI virtio on ARM virt machine

Hello ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Pavel Fedin Sent: Thursday, June 11, 2015 9:41 AM To: libvir-list@redhat.com

[libvirt] [PATCH v2 1/2] Introduce QEMU_CAPS_ARM_VIRT_PCI

This capability specifies that virt machine on ARM has PCI controller. Enabled when version is at least 2.3.0. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + 2 files changed, 6 insertions(+) diff --git a/src/qemu

[libvirt] [PATCH v2 0/2] Allow PCI virtio on ARM virt machine

allows to use both. If the user doesn't specify address type='virtio-mmio', PCI will be used by default. Changes since v1: - Added capability based on qemu version number - Recognize also virt- prefix Pavel Fedin (2): Introduce QEMU_CAPS_ARM_VIRT_PCI Allow PCI virtio on ARM virt machine src/qemu

[libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_command.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0a6d92f..2acdc6a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu

  1   2   >