if (i == 0) {
> +vshPrint(ctl, "%-15s %s\n", _("Messages:"), messages[i]);
> +} else {
> +vshPrint(ctl, "%-15s %s\n", "", messages[i]);
> +}
> +}
> +}
'messages' is leaked here.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
trdup_printf(
> +"%s: %s",
> + _("deprecated configuration"),
> +vm->deprecations[i]);
Ditto.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
install = "true"
> +displayName = "test"
Are you sure about these two? They have already displayName, albeit
with a different captalization, and indeed this patch has no changes
to their xml result files.
With the above two removed:
Reviewed-by: Pino Toscano
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
lly in case there
will ever be a V3.
> +if (hypervInvokeMethod(priv, params, NULL) < 0) {
> +virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> + _("Could not set autostart"));
Minor question: is there really no way to get the reason (in form of
string) of the failure?
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
mon helper might make sense or not.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
dable.
Of course, in case the message is changed to an untranslated text,
then please leave a comment there, so noone accidentally makes it
translatable.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
> MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_RESET);
> +
> + cleanup:
> +hypervFreeObject(priv, (hypervObject *)computerSystem);
> +
> +return result;
> +}
What about making a common helper function that calls
hypervMsvmComputerSystemFromDomain +
hypervInvokeMsvmComputerSystemRequestStateChange?
Note that virDomainReboot() can take various flags, however none is
used ATM.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Account for the possible SATA disks too, which means 120 potential
disks.
This means the size of the array triples, however that is unavoidable
with the current way of reading disks.
Signed-off-by: Pino Toscano
---
src/vmx/vmx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Try to parse SATA disks in VMware guests from their configs in VMX
files. There are a couple of helper/cleanup commits to ease a bit the
actual patches.
Pino Toscano (4):
vmx: hide private helpers
vmx: shortcut 'cdrom-image' as CD-ROM earlier
vmx: expand the disk array
vmx: start parsing
Move all the private helpers for parsing and formatting of domain
elements as private static functions in vmx.c, to avoid using them
directly.
Signed-off-by: Pino Toscano
---
src/libvirt_vmx.syms | 12 -
src/vmx/vmx.c| 62
src/vmx
Add it to the list of 'deviceType' values ignored for disks.
Signed-off-by: Pino Toscano
---
src/vmx/vmx.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
index 70f4d78e8a..0ec6222f50 100644
--- a/src/vmx/vmx.c
+++ b/src/vmx/vmx.c
=1677608
https://bugzilla.redhat.com/show_bug.cgi?id=1883588
Signed-off-by: Pino Toscano
---
src/vmx/vmx.c | 138 ++
.../vmx2xml-esx-in-the-wild-10.vmx| 101 +
.../vmx2xml-esx-in-the-wild-10.xml| 36
methodName = "ModifySystemSettings";
> +embeddedParamName = "SystemSettings";
> +embeddedParamClass = Msvm_VirtualSystemSettingData_WmiInfo;
> +enabledValue = g_strdup("4");
> +disabledValue = g_strdup("2");
> +}
It looks
t should work also with a greedy validator.
With the above changes:
Reviewed-by: Pino Toscano
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
ill make these
XMLs unusable as real XMLs, and some of them were actually real XMLs.
Even if these files are just tests, I don't think this is correct to
make them different than real XMLs.
If the schema does not support file='[datastore] path/to/file.vmx',
IMHO that's the schema itself what needs to be fixed, not example/test
XMLs...
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Change the interface of esxUtil_ResolveHostname() to return a newly
allocated string with the result address, instead of forcing the callers
to provide a buffer and its size. This way we can simply (auto)free the
string, and make the function stacks smaller.
Signed-off-by: Pino Toscano
---
src
Call freeaddrinfo() as soon as @result is not needed anymore, i.e. right
after getnameinfo(); this avoids calling freeaddrinfo() in two branches.
Signed-off-by: Pino Toscano
---
src/esx/esx_util.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/esx/esx_util.c b/src
o
esxUtil_ResolveHostname(), which forces it due to its interface.
I'll rewrite it to return a new string instead; consider it as a NACK
for this patch.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
D of -1,
> - * in that case a lookup based on the Name or UUId need to be done instead.
> + * in that case a lookup based on the Name or UUID need to be done instead.
> *
> * virDomainFree should be used to free the resources after the
> * domain object is no longer needed.
Re
On Saturday, 3 October 2020 01:02:47 CEST Matt Coleman wrote:
> On Oct 2, 2020, at 2:48 AM, Pino Toscano wrote:
> > IMHO these explanations should be documented in the Hyper-V driver
> > page: docs/drvhyperv.html.in. This way, users know about the different
>
On Friday, 2 October 2020 23:50:22 CEST Matt Coleman wrote:
> On Oct 2, 2020, at 2:25 AM, Pino Toscano wrote:
> > Note that now hypervGetVirtualSystemByID() issues VIR_ERR_INTERNAL_ERROR
> > in case / *computerSystemList is null, instead of
> > VIR_ERR_NO_DOMAIN. Shouldn
ring CSCreationClassName
> string CSDVersion
> string CSName
> -uint16 CurrentTimeZone
> +int16CurrentTimeZone
> boolean DataExecutionPrevention_Available
> boolean DataExecutionPrevention_32BitApplications
> boolean DataExecutionPrevention_Drivers
This seems unrelated to the patch? Or it is needed because this class
is used by the hypervGetWmiClass(Win32_OperatingSystem, ...) call, and
the field needed to be fixed?
I'd split it as separate commit before this one.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
6 @@
> #define MSVM_VIRTUALSYSTEMMANAGEMENTSERVICE_SELECTOR \
> "CreationClassName=Msvm_VirtualSystemManagementService"
>
> -int hypervVerifyResponse(WsManClient *client, WsXmlDocH response,
> - const char *detail);
> -
This change seems unrelated to the patch. Can you
) < 0) {
> -goto cleanup;
> -}
> -
> -if (processorSettingData == NULL) {
> +if (hypervGetProcSDByVSSDInstanceId(priv,
> + virtualSystemSettingData->data.common->InstanceID,
> + ) < 0) {
> virReportError(VIR_ERR_INTERNAL_ERROR,
> _("Could not lookup %s for domain %s"),
> "Msvm_ProcessorSettingData",
Ditto.
> @@ -809,21 +869,9 @@ hypervDomainGetXMLDesc(virDomainPtr domain, unsigned int
> flags)
> goto cleanup;
> }
>
> -/* Get Msvm_MemorySettingData */
> -virBufferEscapeSQL(,
> - "associators of "
> - "{Msvm_VirtualSystemSettingData.InstanceID=\"%s\"} "
> - "where AssocClass =
> Msvm_VirtualSystemSettingDataComponent "
> - "ResultClass = Msvm_MemorySettingData",
> - virtualSystemSettingData->data.common->InstanceID);
> -
> -if (hypervGetMsvmMemorySettingDataList(priv, ,
> - ) < 0) {
> -goto cleanup;
> -}
> -
> -
> -if (memorySettingData == NULL) {
> +if (hypervGetMemSDByVSSDInstanceId(priv,
> + virtualSystemSettingData->data.common->InstanceID,
> + ) < 0) {
> virReportError(VIR_ERR_INTERNAL_ERROR,
> _("Could not lookup %s for domain %s"),
> "Msvm_MemorySettingData",
Ditto.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
arate commit. This eases cherry-picking, removes
dependencies between patches that would not conflict otherwise, and
avoids churn in each patch.
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Followup of commit a79e7639daffac04b088378e6c79854fcac292f3 and
commit 7556ab139fd2e503ac26ee232ab273f1ec027c21.
Signed-off-by: Pino Toscano
---
meson.build | 10 --
1 file changed, 10 deletions(-)
diff --git a/meson.build b/meson.build
index 257e4452a1..a5ce8e17a8 100644
Signed-off-by: Pino Toscano
---
docs/gitdm/groups/unaffiliated | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/gitdm/groups/unaffiliated b/docs/gitdm/groups/unaffiliated
index 5f867fc5e4..1ca7eee81f 100644
--- a/docs/gitdm/groups/unaffiliated
+++ b/docs/gitdm/groups
Signed-off-by: Pino Toscano
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e992fbe471..7c723e6610 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -32,6 +32,13 @@ v6.8.0 (unreleased)
can now be passed using the ``passwd`` attribute
Implement the .domainInterfaceAddresses hypervisor API, although only
functional for the VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT source.
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 4 +
src/esx/esx_driver.c | 170 +++
2 files changed, 174
Add the definition of the GuestNicInfo object, with all the required
objects for it.
Signed-off-by: Pino Toscano
---
scripts/esx_vi_generator.py| 1 +
src/esx/esx_vi_generator.input | 54 ++
2 files changed, 55 insertions(+)
diff --git a/scripts
d a virReportError() here.
Good notice, it is actually an issue (we requested a property of a VM,
the SOAP call for it succeeded but there was no property in the
answer). I will amend and send v2.
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
Implement the .connectListAllNetworks networks API in the esx network
driver.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c | 69
1 file changed, 69 insertions(+)
diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c
index
On Monday, 14 September 2020 17:16:50 CEST Michal Privoznik wrote:
> On 9/14/20 11:10 AM, Pino Toscano wrote:
> > Implement the .connectListAllNetworks networks API in the esx network
> > driver.
> >
> > Signed-off-by: Pino Toscano
> > ---
> &
Implement the .domainInterfaceAddresses hypervisor API, although only
functional for the VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT source.
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 4 ++
src/esx/esx_driver.c | 166 +++
2 files changed, 170
Add the definition of the GuestNicInfo object, with all the required
objects for it.
Signed-off-by: Pino Toscano
---
scripts/esx_vi_generator.py| 1 +
src/esx/esx_vi_generator.input | 54 ++
2 files changed, 55 insertions(+)
diff --git a/scripts
Implement the .connectListAllNetworks networks API in the esx network
driver.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c | 64
1 file changed, 64 insertions(+)
diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c
index
Implement the .domainGetHostname hypervisor driver API to get the
hostname of a running guest (needs VMware Tools).
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 3 +++
src/esx/esx_driver.c | 54
2 files changed, 57 insertions(+)
diff
A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent
the number of the error, even in cases where there is one fitting more.
Hence, replace some of them with better virErrorNumber values.
Signed-off-by: Pino Toscano
---
Changes in v2:
- remove some
Signed-off-by: Pino Toscano
---
Changes in v2:
- ancestor -> base class
scripts/esx_vi_generator.py | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/scripts/esx_vi_generator.py b/scripts/esx_vi_generator.py
index 863c8af964..e0782e35f3 100755
---
A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent
the number of the error, even in cases where there is one fitting more.
Hence, replace some of them with better virErrorNumber values.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c| 4 ++--
src/esx
ed-off-by: Pino Toscano
---
scripts/esx_vi_generator.py | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/scripts/esx_vi_generator.py b/scripts/esx_vi_generator.py
index 863c8af964..be9b3949e8 100755
--- a/scripts/esx_vi_generator.py
+++ b/s
Consider a couple of misspelt emails in B-y tags.
Signed-off-by: Pino Toscano
---
docs/gitdm/aliases | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/gitdm/aliases b/docs/gitdm/aliases
index 83637bdff9..467e90f141 100644
--- a/docs/gitdm/aliases
+++ b/docs/gitdm/aliases
@@ -1,6 +1,8
PLD Linux is a Linux distribution, so @pld-linux.org fits in the
opensource group with similar projects.
Signed-off-by: Pino Toscano
---
docs/gitdm/groups/opensource | 1 +
docs/gitdm/groups/unaffiliated | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/gitdm/groups
above the value will not change so
> >no need to re-load.
> >
> > 2) at module insertion time
> >
> >In this case it's actually wrong to cache it, because the module can
> >be unloaded and reloaded while libvirt will not check and update the
> >cached value. In those scenarios it should also be determined only
> >after you open the control fd frist.
> >
> As promised yesterday, I've dived into the code and found out that the
> major number can be specified as a parameter to the dm module (just
> tested and it works). So the next thing I tried was to see how could we
> check whether the module was reloaded. I've tried opening
> /dev/mapper/control hoping that I will get EOF on module unload (which I
> could then use to run a callback that would invalidate the cached
> value). But having the file open prevents unloading the module.
>
> Loading/unloading a module results in an udev event, BUT we listen for
> udev events only in nodedev driver and moving the code out to a driver
> agnostic location and making it driver agnostic is too much code for a
> little gain.
>
> Then I looked whether it's possible to get the major number via an
> ioctl(). But haven't found anything.
What about stat()ing /dev/mapper/control? That should give you the
major/minor of that special character device.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
of a numbered one
Signed-off-by: Pino Toscano
---
docs/auth.html.in | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/docs/auth.html.in b/docs/auth.html.in
index 6f8805b6f5..9964313776 100644
--- a/docs/auth.html.in
+++ b/docs/auth.html.in
@@ -122,17 +122,19
672cf08782
> Cc: Cole Robinson
> Cc: Eric Blake
> Cc: Pino Toscano
> ---
Reviewed-by: Pino Toscano
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
ACCESS-FILE PERMITTED-ACCESS-FILE")
> > -sys.exit(1)
> > +abs_builddir = os.environ.get('abs_builddir', '')
> > +abs_srcdir = os.environ.get('abs_srcdir', '')
> >
> > -access_file = sys.argv[1]
> > -permitted_file = sys.argv[2]
> > +filename = ''.join(random.choice(string.ascii_letters) for _ in range(16))
>
> Umm, python doesn't have a 'mkostemp' equivalent? This seems a bit
> fishy.
Sure, it is the tempfile module:
https://docs.python.org/3/library/tempfile.html
filename = tempfile.mkstemp(dir=abs_builddir, prefix='file-access-',
suffix='.txt')
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
s 'vcpus' must not overlap"),
> - elementName);
> + _("'%s' attributes '%s' must not overlap"),
> + elementName, attributeName);
While I generally agree with this kind of changes, please note that
this is difficult in
o create dbus state dir %s"),
> + cfg->dbusStateDir);
Minor notes on the message:
- spell "D-Bus" correctly
- no need to abbreviate "directory"
- quote the path placeholder
so I suggest something like:
"Failed to create the D-Bus state directory '%s'"
(
Remove the paragraph in the storage pool page that mentions
virConnectGetCapabilities, as virConnectGetCapabilities does not return
any information about pools.
Signed-off-by: Pino Toscano
---
docs/formatstoragecaps.html.in | 6 --
1 file changed, 6 deletions(-)
diff --git a/docs
enerally used in spoken/informal
language, and while libvirt is not that formal it should not be that
colloquial either IMHO; also, they make the text slightly harder to
understand by non-native speakers, and they are lost when translating.
A POV on the matter is:
https://www.businesswritingblog.com/business_writing/2006/04/dont_use_contra.html
e) which message to use to indicate that QEMU does not support
something?
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
of those 4 forms:
Or maybe s/those 3/the following/, so there is no need to keep the
updated count of the allowed forms (I think it doesn't matter how many
they are).
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
On Wednesday, 13 May 2020 10:58:51 CEST Ján Tomko wrote:
> +if (fs->readonly) {
> +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> + _("virtiofs does not yet supported read-only
> mode"));
s/supported/suppor
interwonen in the
makefiles
- update the documentation
- update libvirt-ci
- remove the autoconf+makefile build system
Pino Toscano (1):
Add dune build system
.gitignore | 3 +++
dune | 18 +
dune-project | 1 +
dune.inc | 22
Introduce the dune build system to build ocaml-libvirt, providing
everything that the current autoconf-based build system has.
Add also an opam configuration files, as it is mandatory with dune.
Signed-off-by: Pino Toscano
---
.gitignore | 3 +++
dune | 18
-1;
> }
>
> -virMutexLock(>lock);
> -
Careful #2 here about locking earlier: while usually this is not an
issue, it could be in case the code that was executed without the lock
held can be called by other code branches with the lock held.
Again, this must be thoroughly checked in the whole patch series.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
gt;
> check-manifest:
> - git ls-files > .check-manifest; \
> + git ls-files | grep -v .github/lockdown.yml > .check-manifest; \
Thanks, this seems OK.
Maybe one small improvement if you have the time/will: skip the entire
.github/ toplevel directory, so in case we add more
}
>
> This new test fails on FreeBSD
>
> $ VIR_TEST_DEBUG=1 VIR_TEST_RANGE=28 ./commandtest
> TEST: commandtest
> 28) Command Exec test28 test ...
> Unexpected error object
> libvirt: error : some error message: Input/output e
not include unistd.h anymore, we need to include it.
Signed-off-by: Pino Toscano
---
tests/virnetdaemontest.c | 4 +++-
tests/virnetserverclienttest.c | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c
index 825487f0a1
onder if therefore it would be safer to set the string to a
> known-good non-NULL value such as ‘strdup ("emptyBackingString")’?
Thought about that, however "emptyBackingString" seems like a magic
identifier, and it would be trading one hack with another, somehow.
--
Move earlier the checks for skipping a hard disk when parsing a CD-DROM,
and for skipping a CD-ROM when parsing a hard disk. This should have no
behaviour changes, and avoids to add repeated checks in following
commits.
Signed-off-by: Pino Toscano
---
src/vmx/vmx.c | 48
disk and floppies, so make sure that a NULL fileName
is handled in cdrom- and floppy-related paths.
https://bugzilla.redhat.com/show_bug.cgi?id=1808610
Signed-off-by: Pino Toscano
---
src/vmx/vmx.c | 25 ++-
.../vmx2xmldata/vmx2xml-cdrom-ide-empty-2
v1 is:
https://www.redhat.com/archives/libvir-list/2020-March/msg00616.html
Changes from v1:
- added a patch to shortcut few checks
- use NULLSTR
- handle floppies (poor guys)
Pino Toscano (2):
vmx: shortcut earlier few 'ignore' cases in virVMXParseDisk()
vmx: make 'fileName' optional for CD
disk and floppies, so make sure that a NULL fileName
is handled in cdrom-related paths.
https://bugzilla.redhat.com/show_bug.cgi?id=1808610
Signed-off-by: Pino Toscano
---
src/vmx/vmx.c | 22 ++
.../vmx2xmldata/vmx2xml-cdrom-ide-empty-2.vmx | 4
gt;
> [...]
> +int
> +virFileDataSync(int fd)
> +{
> +#if defined(__APPLE__) || defined(WIN32)
> +return g_fsync(fd);
> +#else
> +return fdatasync(fd);
> +#endif
Why not just simply add a configure check for the fdatasync function?
This way there is no need to hardcode OS
; 10.5 all support this critical
> extension.
This is not correct: POSIX.1-2008 standardizes null as possible value
for the second argument; see:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/realpath.html
--
Pino Toscano
signature.asc
Description: This is a digitally signed message
A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent
the number of the error, even in cases where there is one fitting more.
Hence, replace some of them with better virErrorNumber values.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c| 4 ++--
src/esx
Implement the .connectListAllNetworks networks API in the esx network
driver.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c | 64
1 file changed, 64 insertions(+)
diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c
index
Implement the .domainGetHostname hypervisor driver API to get the
hostname of a running guest (needs VMware Tools).
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 3 +++
src/esx/esx_driver.c | 54
2 files changed, 57 insertions(+)
diff
ed-off-by: Pino Toscano
---
scripts/esx_vi_generator.py | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/scripts/esx_vi_generator.py b/scripts/esx_vi_generator.py
index 048f5dde9e..9e3151943b 100755
--- a/scripts/esx_vi_generator.py
+++ b/s
Implement the .domainInterfaceAddresses hypervisor API, although only
functional for the VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT source.
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 4 ++
src/esx/esx_driver.c | 166 +++
2 files changed, 170
Move the creation of a virStorageVolPtr object from the esxVI_ScsiLun
object of a SCSI lun out of esxStorageVolLookupByName and
esxStorageVolLookupByPath in an own helper. This way it can be used
also in other functions.
Signed-off-by: Pino Toscano
Reviewed-by: Cole Robinson
---
src/esx
Implement the .storagePoolListAllVolumes storage API in the esx storage
driver, and in all its subdrivers.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_iscsi.c | 68 +++
src/esx/esx_storage_backend_vmfs.c | 83 +
src/esx
- implemented domainGetHostname
- implemented domainInterfaceAddresses
Pino Toscano (11):
esx: implement connectListAllStoragePools
esx: implement connectListAllNetworks
esx: split datastorePathToStorageVol helper
esx: split scsilunToStorageVol helper
esx: implement
Signed-off-by: Pino Toscano
---
docs/news.xml | 14 ++
1 file changed, 14 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 055353b9a5..6c29011d53 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -86,6 +86,20 @@
lzop should be used
Add the definition of the GuestNicInfo object, with all the required
objects for it.
Signed-off-by: Pino Toscano
---
scripts/esx_vi_generator.py| 1 +
src/esx/esx_vi_generator.input | 54 ++
2 files changed, 55 insertions(+)
diff --git a/scripts
Implement the .connectListAllStoragePools storage API in the esx storage
driver, and in all its subdrivers.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_iscsi.c | 70 +
src/esx/esx_storage_backend_vmfs.c | 96 +
src/esx
Move the creation of a virStorageVolPtr object by lookup out of
esxStorageVolLookupByPath in an own helper. This way it can be used
also in other functions.
Signed-off-by: Pino Toscano
Reviewed-by: Cole Robinson
---
src/esx/esx_storage_backend_vmfs.c | 29 +++--
1 file
On Thursday, 12 December 2019 16:26:26 CET Andrea Bolognani wrote:
> On Thu, 2019-12-12 at 16:05 +0100, Pino Toscano wrote:
> > On Thursday, 12 December 2019 15:31:04 CET Andrea Bolognani wrote:
> > > + augeas-lenses:
> > > +default: augeas
> > > +de
+ augeas-lenses:
> +default: augeas
> +deb: augeas-lenses
> +OpenSUSE: augeas-lenses
Why is this needed? The lenses must be already a dependency of the
augeas shared library, or at least of the tools.
--
Pino Toscano
signature.asc
Description: This is a digitally
Getting the hostname of guest usually requires a in-guest agent, or
generally can be determined only on active domains.
Signed-off-by: Pino Toscano
---
tools/virsh-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index
Implement the .connectListAllStoragePools storage API in the esx storage
driver, and in all its subdrivers.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_iscsi.c | 72 +
src/esx/esx_storage_backend_vmfs.c | 98 +
src/esx
Signed-off-by: Pino Toscano
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index c362bf3a15..1718a686ce 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -55,6 +55,17 @@
+
+
+ esx
Move the creation of a virNetworkPtr object from the
esxVI_HostVirtualSwitch object of a virtual switch out of
esxNetworkLookupByName in an own helper. This way it can be used also
in other functions.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c | 34
Implement the .connectListAllNetworks networks API in the esx network
driver.
Signed-off-by: Pino Toscano
---
src/esx/esx_network_driver.c | 66
1 file changed, 66 insertions(+)
diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c
index
This way they are correctly represented:
... instead of 'auto'.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_vmfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/esx/esx_storage_backend_vmfs.c
b/src/esx/esx_storage_backend_vmfs.c
index 05b273aed7..1270c21e00
Pino Toscano (12):
esx: split datastoreToStoragePoolPtr helper
esx: split datastorePoolType helper
esx: split targetToStoragePool helper
esx: implement connectListAllStoragePools
esx: split virtualswitchToNetwork helper
esx: implement connectListAllNetworks
storage: add vmfs
Move the detection of the type of a vmfs pool out of
esxLookupVMFSStoragePoolType in an own helper. This way it can be used
also in other functions.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_vmfs.c | 49 --
1 file changed, 33 insertions(+), 16
Move the creation of a virStorageVolPtr object by lookup out of
esxStorageVolLookupByPath in an own helper. This way it can be used
also in other functions.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_vmfs.c | 28 ++--
1 file changed, 18 insertions(+), 10
It will be used to represent the type of a filesystem pool in ESXi.
Signed-off-by: Pino Toscano
---
docs/schemas/storagepool.rng | 1 +
docs/schemas/storagevol.rng | 1 +
docs/storage.html.in | 3 +++
src/conf
Move the creation of a virStoragePtr object from the esxVI_ObjectContent
object of a datastore out of esxStoragePoolLookupByName in an own
helper. This way it can be used also in other functions.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_vmfs.c | 45
Move the creation of a virStorageVolPtr object from the esxVI_ScsiLun
object of a SCSI lun out of esxStorageVolLookupByName and
esxStorageVolLookupByPath in an own helper. This way it can be used
also in other functions.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_iscsi.c | 60
Implement the .storagePoolListAllVolumes storage API in the esx storage
driver, and in all its subdrivers.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_iscsi.c | 70
src/esx/esx_storage_backend_vmfs.c | 85 +
src/esx
Move the creation of a virStoragePtr object from the
esxVI_HostInternetScsiHbaStaticTarget object of a target out of
esxStoragePoolLookupByName in an own helper. This way it can be used
also in other functions.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_iscsi.c | 32
On Wednesday, 13 November 2019 13:46:06 CET Pino Toscano wrote:
> Make the virConnectListAllStoragePools API work for esx storage pools by
> implementing the internal connectListAllStoragePools storage API.
>
> Pino Toscano (5):
> esx: split datastoreToStoragePoolPtr helper
It was lifted with c92b6023e8eb670e01571e299a85e9da9bd4844c.
Signed-off-by: Pino Toscano
---
docs/drvesx.html.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in
index 901d65958a..ac7bc645d1 100644
--- a/docs/drvesx.html.in
+++ b
Move the detection of the type of a vmfs pool out of
esxLookupVMFSStoragePoolType in an own helper. This way it can be used
also in other functions.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_vmfs.c | 49 --
1 file changed, 33 insertions(+), 16
Implement the .connectListAllStoragePools storage API in the esx storage
driver, and in all its subdrivers.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_iscsi.c | 72 +
src/esx/esx_storage_backend_vmfs.c | 98 +
src/esx
Make the virConnectListAllStoragePools API work for esx storage pools by
implementing the internal connectListAllStoragePools storage API.
Pino Toscano (5):
esx: split datastoreToStoragePoolPtr helper
esx: split datastorePoolType helper
esx: split targetToStoragePool helper
esx: implement
Move the creation of a virStoragePtr object from the esxVI_ObjectContent
object of a datastore out of esxStoragePoolLookupByName in an own
helper. This way it can be used also in other functions.
Signed-off-by: Pino Toscano
---
src/esx/esx_storage_backend_vmfs.c | 45
1 - 100 of 282 matches
Mail list logo
