Re: [libvirt] Problem about Libvirt and Virtualbox....

2009-12-22 Thread Pritesh Kothari
Hi Prashant, try 0.7.4 or latest head, works fine with it. Regards, Pritesh On Wed, Dec 23, 2009 at 12:30 PM, Prashant Wakchaure prashant.wakcha...@gmail.com wrote: Hello, Currently I am working on libvirt API and I am trying to connect virtualbox with libvirt. I using ubuntu 9.10 and

Re: [libvirt] [BUG] connection to vbox 3.1 fails

2009-12-07 Thread Pritesh Kothari
On Sat, Dec 5, 2009 at 1:09 AM, Matthias Bolte matthias.bo...@googlemail.com wrote: 2009/12/4 Florian Vichot florian.vic...@diateam.net: Hello all, As confirmed on IRC by Matthias, when trying to open a connection of any sort (vbox:///session or vbox:///system) to the vbox driver with a

Re: [libvirt] [PATCH] vbox: Use virIndexToDiskName() in vboxGenerateMediumName()

2009-12-07 Thread Pritesh Kothari
On Fri, Dec 4, 2009 at 8:24 PM, Daniel Veillard veill...@redhat.com wrote: On Fri, Dec 04, 2009 at 03:31:06PM +0100, Matthias Bolte wrote: --- src/vbox/vbox_tmpl.c | 48 +--- 1 files changed, 9 insertions(+), 39 deletions(-) diff --git

Re: [libvirt] Creating Guest OS in Virtual Box

2009-10-05 Thread Pritesh Kothari
Hi Santosh, apply this patch http://www.mail-archive.com/libvir-list@redhat.com/msg16797.html and hopefully it should work Regards, Pritesh On Monday 05 October 2009 14:51:33 santosh gandham wrote: Hi, I am trying to create Guest OS (VM) in virtualBox throught libvirt. I installed libvirt

Re: [libvirt] Creating Guest OS in Virtual Box

2009-10-05 Thread Pritesh Kothari
os typehvm/type boot dev='hd'/ /os memory542720/memory vcpu1/vcpu devices disk type='file' device='disk' source file='/home/santhosh/Desktop/ubuntu9.vdi'/ target dev='hdd'/

Re: [libvirt] [PATCH] in vbox driver, interface type bridge should really be type ethernet

2009-10-02 Thread Pritesh Kothari
Hi Florian, On Wednesday 30 September 2009 20:08:36 Florian Vichot wrote: If I understand correctly, the bridge type for an interface means libvirt is in charge of creating a tun device and adding it to the specified bridge in the source bridge=.. attribute.This is not what the (badly named

[libvirt] [PATCH] minor fix's

2009-09-30 Thread Pritesh Kothari
Hi All, Just minor fix's. Regards, Pritesh diff --git a/daemon/dispatch.c b/daemon/dispatch.c index e9fe260..011d523 100644 --- a/daemon/dispatch.c +++ b/daemon/dispatch.c @@ -594,7 +594,7 @@ remoteSendStreamData(struct qemud_client *client, struct qemud_client_message *msg; XDR xdr;

Re: [libvirt] [PATCH 1/6] Move file format enum to libvirt_util

2009-09-29 Thread Pritesh Kothari
+enum virStorageFileFormat { +VIR_STORAGE_FILE_RAW = 0, +VIR_STORAGE_FILE_DIR, +VIR_STORAGE_FILE_BOCHS, +VIR_STORAGE_FILE_CLOOP, +VIR_STORAGE_FILE_COW, +VIR_STORAGE_FILE_DMG, +VIR_STORAGE_FILE_ISO, +VIR_STORAGE_FILE_QCOW, +VIR_STORAGE_FILE_QCOW2, +

Re: [libvirt] [PATCH] in Vbox driver, OpenHardDisk is called with NULL instead of

2009-09-29 Thread Pritesh Kothari
On Tuesday 29 September 2009 12:27:49 Florian Vichot wrote: This patch replaces the use of NULL with empty strings () in a call to OpenHardDisk, which otherwise fails with E_INVALIDARG. The patch fix's it but the more appropriate fix would be as below. Regards, Pritesh diff --git

[libvirt] [PATCH] bug in vboxDomainDestroy in vbox driver

2009-09-29 Thread Pritesh Kothari
Hi All, There is bug in vboxDomainDestroy() where in the while powerdown the method doesn't wait till its completion. Fix in the attached patch. Regards, Pritesh diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 07515fe..65e3449 100644 --- a/src/vbox/vbox_tmpl.c +++

Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

2009-09-23 Thread Pritesh Kothari
Hi Dominik, The patch is attached below. It does not work for me. After applying the patch, configure still fails with checking for DEVMAPPER... no configure: error: You must install device-mapper-devel = 0.0 to compile libvirt Since it is still showing the old message, I guess the patch

Re: [libvirt] 0.7.1 compile fails on opensuse 11.1

2009-09-22 Thread Pritesh Kothari
it seems openSuSE 11.1 does not come with a pkgconfig for the device-mapper-devel package. I created a bug [1] for opensuse but was also told to mention it here so configure.in could be patched once the bug was fixed. Hi All, Just fixed this for ubuntu (should work now for suse as well) with

[libvirt] [PATCH]: API Change patch for VBox 3.0.6

2009-09-14 Thread Pritesh Kothari
Hi All, VirtualBox 3.0.6 was released few days ago and there were some minor API changes in it. I have created a patch for the same and posting it here. Regards, Pritesh commit 72088db113ce5837cce91616ebbf64dcd1a2b0ee Author: Pritesh Kothari pritesh.koth...@sun.com Date: Mon Sep 14 09:05:38

[libvirt] [PATCH]: Bug when you try to start machines made will older VBox versions

2009-09-14 Thread Pritesh Kothari
Hi All, Thanks to Florian, who pointed out the bug, due to which you can't start domains defined with older builds or with empty FRONTEND/Type tag in their xml files. Fixed it in the following patch. Regards, Pritesh commit 612e914a8b5902f779223f70552a16d86ede6e6f Author: Pritesh Kothari

Re: [libvirt] [PATCH]: Fixed minor bugs in display and added OOM checks.

2009-09-08 Thread Pritesh Kothari
Lastly added OOM checks in few places which were missed earlier. Okay applied thanks ! I would concur with Chris, I think the current practice in most of libvirt code when there is a complex routine is to handle OOM with a goto to an error label. Thanks Chris and Daniel for the review, i

[libvirt] [PATCH]: Fixed minor bugs in display and added OOM checks.

2009-09-07 Thread Pritesh Kothari
Hi All, There was a minor bug in selecting the graphics type. if the graphics type was desktop it was assumed that display is set for it, and thus crashed on strdup, so now checking if display is present before setting it. The second bug was while setting the 3d acceleration parameter,

[libvirt] [PATCH] Added Storage Volume support to VIrtualBox

2009-09-03 Thread Pritesh Kothari
Hi All, I have added support for Storage Volumes in VirtualBox, the patch for the same is attached here. (needs the little bit cleanup patch previously posted) Regards, Pritesh commit 4fc1ae881a8c45985c777605a012933c783f7d7c Author: Pritesh Kothari pritesh.koth...@sun.com Date: Thu Sep 3 17

[libvirt] [PATCH] little bit cleanup

2009-08-31 Thread Pritesh Kothari
Hi All, Just cleaned up some code to make the it more readable. The patch is attached here with. Directly applies to the HEAD as of today. Regards, Pritesh commit 02516f8e4ab143e2dee618b4ea5fa05f266de0de Author: Pritesh Kothari pritesh.koth...@sun.com Date: Mon Aug 31 14:45:33 2009 +0200

Re: [libvirt] Communicating with libvirt from windows

2009-08-24 Thread Pritesh Kothari
On Monday 24 August 2009 12:17:23 anuj rampal wrote: Hi, I have KVM running on one of my machine and I can controle the geues OS using the virt-manager and Virsh tools. Now what I want to do is talk to libvirt from my windows machine. I tried to compile libvirt for windows but couldnt get

[libvirt] [PATCH] virsh vol-key segfault fix

2009-08-24 Thread Pritesh Kothari
Hi, There is a bug in virsh command vol-key, it segfaults cause the fourth option to vshCommandOptVolBy() is null instead of pool on virsh.c:5209. The patch to fix this is attached. Regards, Pritesh diff --git a/src/virsh.c b/src/virsh.c index 2d0cf81..15e0cef 100644 --- a/src/virsh.c +++

Re: [libvirt] [PATCH] Support for 3d Acceleration in video tag

2009-08-19 Thread Pritesh Kothari
true, will add a element called acceleration/ cause there are some features for 2d acceleration as well, so that will take care of 3d and 2d acceleration both. will post a patch soon with the above changes in it. Reposting the patch with changes mentioned above. Regards, Pritesh commit

Re: [libvirt] [PATCH] Support for defining/dumping video device in VirtualBox

2009-08-19 Thread Pritesh Kothari
On Thursday 13 August 2009 20:50:25 Daniel P. Berrange wrote: On Mon, Aug 10, 2009 at 01:55:03PM +0200, Pritesh Kothari wrote: Hi All, I have added support for defining/dumping video device in VirtualBox. The patch for the same is attached here. Also this patch depends on the earlier

Re: [libvirt] [PATCH] Support for 3d Acceleration in video tag

2009-08-18 Thread Pritesh Kothari
I recall you said there might be other options /settings related to 3d acceleration in virtualbox in the future. If so I think it might be worth making that element all of its own video model type='vbox' 3daccel / /model /video true, will add a element called

[libvirt] [PATCH 1/2]: VirtualBox: Updated vboxNetworkCreateXML() and vboxNetworkDefineXML()

2009-08-13 Thread Pritesh Kothari
027210861c8434ca8c0e58b90094a9ccdeb7c275 Author: Pritesh Kothari pritesh.koth...@sun.com Date: Thu Aug 13 14:59:07 2009 +0200 libvirt: Merged vboxNetworkCreateXML() and vboxNetworkDefineXML() and added code to handle multiple hostonly interfaces. diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 32bfb4d

Re: [libvirt] vbox save/restore

2009-08-10 Thread Pritesh Kothari
On Monday 10 August 2009 02:48:10 Lucian Adrian Grijincu wrote: Hello, I see that the vbox driver in virDomainSave doesn't use the destination file path and calls vbox's IConsole::SaveState. As I see it IConsole::SaveState is more like a pause command: you can save the state you're in and

[libvirt] [PATCH] Support for 3d Acceleration in video tag

2009-08-10 Thread Pritesh Kothari
Hi All, I have added support for 3d Acceleration in the video tag, the patch for the same is attached here. Regards, Pritesh commit c2bfc05a3dd0176396ba55c3c7fc3c004323c9d9 Author: Pritesh Kothari pritesh.koth...@sun.com Date: Mon Aug 10 13:38:45 2009 +0200 libvirt: support for 3d

[libvirt] [PATCH] Support for defining/dumping video device in VirtualBox

2009-08-10 Thread Pritesh Kothari
Hi All, I have added support for defining/dumping video device in VirtualBox. The patch for the same is attached here. Also this patch depends on the earlier patch Support for 3d Acceleration in video tag. Regards, Pritesh commit 777bf7dbbc1a6531965cd11be41987d8b74bf0f2 Author: Pritesh Kothari

[libvirt] [PATCH] Support for getting/setting number of cpus in VirtualBox

2009-08-07 Thread Pritesh Kothari
Hi All, I have just added support for getting/setting number of cpus in VirtualBox. The patch for the same is include below. Regards, Pritesh commit 3dcaf67d0bb4aa58c4e2224779bebcf2263068b8 Author: Pritesh Kothari pritesh.koth...@sun.com Date: Fri Aug 7 15:49:16 2009 +0200 libvirt

Re: [libvirt] Bugfix for failing to reconnect to vbox:///session

2009-07-20 Thread Pritesh Kothari
I don't think this is quite correct. We call VBoxCGlueInit() in the vboxRegister() function, which is run when libvirt first initializes the whole library. The real bug is the vboxClose() method which calls vboxUninitialize() which is then calling VBoxCGlueTerm(). So if you have many

[libvirt] Bugfix for failing to reconnect to vbox:///session

2009-07-17 Thread Pritesh Kothari
Hi All, While reconnecting to vbox:///session, since the VBoxCGlueInit() is not intialized, the g_pfnGetFunctions is NULL and thus reconnection fails with SEGV. Fixed this in the patch below. Regards, Pritesh commit 9df6333b50a8b512b30ec5bbbfd01a2eec6cbf8b Author: Pritesh Kothari pritesh.koth

Re: [libvirt] PATCH 1/2: Support video element in domain config

2009-07-13 Thread Pritesh Kothari
- Centralized the logic for default video model default RAM - Added a type=vbox for their custom graphics card Patch looks fine to me, but it seems to miss 3dSupport as discussed with Pritesh. But it will be easy to add this, and that will allow Tom Hughes to rebase his patch

[libvirt] Moving Drivers to their respective directories under src/

2009-07-13 Thread Pritesh Kothari
Hi All, Now since we have moved the repo from CVS = git can we consider moving each driver to its respective directory under src/. The src/ directory is too crowded with more then 150+ base files and more when you compile things. Also is there any way to output the compiled files to a separate

Re: [libvirt] PATCH: Convert VBox driver to preferred style

2009-06-02 Thread Pritesh Kothari
On Tuesday 02 June 2009 12:09:24 Daniel P. Berrange wrote: The driver function table in the VBox driver is currently using named struct member initializers. We previously removed all these from other drivers, so we have a clearer indication of missing APIs in each driver. This patch updates

Re: [libvirt] PATCH: Wire up NUMA APIs in VirtualBox driver

2009-06-02 Thread Pritesh Kothari
On Tuesday 02 June 2009 12:10:05 Daniel P. Berrange wrote: This patch simply wires up the shared NUMA API implementations in the virtualbox driver Daniel diff -r 8b34df5f9ddf src/vbox/vbox_tmpl.c --- a/src/vbox/vbox_tmpl.cThu May 28 11:55:49 2009 +0100 +++ b/src/vbox/vbox_tmpl.cThu

Re: [libvirt] PATCH: Centralize some duplicated NUMA code

2009-06-02 Thread Pritesh Kothari
On Tuesday 02 June 2009 12:05:54 Daniel P. Berrange wrote: .version = vboxGetVersion, .getHostname = vboxGetHostname, .getMaxVcpus = vboxGetMaxVcpus, -.nodeGetInfo = vboxNodeGetInfo, +

[libvirt] [PATCH 1/1] fixed the event-test.c example to check for return values

2009-05-20 Thread Pritesh Kothari
Hi All, The event-test.c example doesn't check for the return values while registering for the callbacks, this patch just checks for them along with a correcting a small typo. (Unpaused = Paused) Regards, Pritesh commit e646e55c4167572a8b345f99d9beaac4fa5ca538 Author: pk221555

Re: [libvirt] PATCH: Work in progress suport for video device config

2009-05-19 Thread Pritesh Kothari
On Tuesday 19 May 2009 11:35:40 Daniel P. Berrange wrote: We discussed adding a new XML element for representing video devices a few weeks back. This is my work in progress patch for the XML parsing routines supporting video model type='vga|cirrus|vmvga|xen' vram='64' heads='1'/

Re: [libvirt] QEMU/KVM auto-detection bug

2009-05-12 Thread Pritesh Kothari
On Tuesday 12 May 2009 11:36:50 Chris Lalancette wrote: All, Even with Guido/Pritesh's recent changes to the vbox open routine, the auto-detection in libvirt is currently broken. What happens is that in src/libvirt.c:do_open(), at the start of the loop to auto-detect drivers, ret-uri is

Re: [libvirt] QEMU/KVM auto-detection bug

2009-05-12 Thread Pritesh Kothari
On Tuesday 12 May 2009 11:55:17 Chris Lalancette wrote: Pritesh Kothari wrote: On Tuesday 12 May 2009 11:36:50 Chris Lalancette wrote: All, Even with Guido/Pritesh's recent changes to the vbox open routine, the auto-detection in libvirt is currently broken. What happens

Re: [libvirt] [PATCH 1/3] Support for vrdp/sdl/gui while defining a machine

2009-05-12 Thread Pritesh Kothari
This wasn't exactly what I anticipated. It intended that it should report the error *and* return as an error to the caller, rather than carrying on. hmm.. I thought it more like handling NULL returns from strdup. That said, I notice that none of the existing code we have committed for

Re: [libvirt] PATCH: ALlow for quiet build

2009-05-12 Thread Pritesh Kothari
On Monday 11 May 2009 17:47:00 Daniel P. Berrange wrote: This is a simpler version of http://www.redhat.com/archives/libvir-list/2009-April/msg00523.html just overriding the LIBTOOL variable in configure.in, instead of in each Makefile.am As before you still need 'make -s' to get full

Re: [libvirt] [PATCH 3/3] networking API for hostonly networks in VirtualBox driver in libvirt

2009-05-11 Thread Pritesh Kothari
+ +strcpy (networkNameUtf8, HostInterfaceNetworking-); +strcat (networkNameUtf8, def-name); That said, how about just using virAsprintf(nmetworkNameUtf8.. instead of alloc+strcpy Done. +DEBUG(Network Name: %s, def-name); +DEBUG(Network UUID: +

Re: [libvirt] [PATCH 3/3] networking API for hostonly networks in VirtualBox driver in libvirt

2009-05-11 Thread Pritesh Kothari
You really don't need to keep any data about the networking driver in libvirt(d) itself ? as danpb explained it :) +/* Currently support only one dhcp server per network + * with contigious address space from start to end +

Re: [libvirt] [PATCH 1/3] Support for vrdp/sdl/gui while defining a machine

2009-05-11 Thread Pritesh Kothari
[PATCH 1/3]: contains support for vrdp/sdl/gui while defining a machine. +guiDisplay = strdup(def-graphics[i]-data.desktop.display); +} + +if ((def-graphics[i]-type == VIR_DOMAIN_GRAPHICS_TYPE_SDL) (sdlPresent == 0)) { +

Re: [libvirt] [PATCH 2/3] Support for vrdp/sdl/gui while dumping xml

2009-05-11 Thread Pritesh Kothari
-def-graphics-data.rdp.autoport = 1; +valueDisplayUtf8 = getenv(DISPLAY); +valueDisplayFree = 0; } Using getenv() here is not right, since that's running in the

Re: [libvirt] [PATCH 3/3] Support for vrdp/sdl/gui while starting the machine

2009-05-11 Thread Pritesh Kothari
Same issue about use of 'getenv' strdup OOM handling here. Fixed these two and reposting the patch. Regards, Pritesh diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 85a336a..274afd8 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -2343,20 +2343,12 @@ static

Re: [libvirt] [PATCH 3/3] networking API for hostonly networks in VirtualBox driver in libvirt

2009-05-11 Thread Pritesh Kothari
There's a strdup() call here that's not checked for failure, and quite a few more in other functions in the patch. Hopefully covered all the strdup's and fixed it Reposting the patch. This reminds me that we really need to make a wrapper for strdup, as we did for malloc() to validate

Re: [libvirt] PATCH: Another attempt to fix vbox driver open

2009-05-11 Thread Pritesh Kothari
- If the user gives a URI with a vbox:/// prefix, we should always handle it, unless a 'server' is set when we leave it to the remote driver - If an invalid path is given we must give back a real error code - If after deciding the URI is for us, any initialization fails we must

Re: [libvirt] [PATCH] vbox: don't fail on missing vbox

2009-05-07 Thread Pritesh Kothari
On Thursday 07 May 2009 10:50:54 Guido Günther wrote: Hi, virsh fails with: 10:47:37.104: debug : do_open:922 : no name, allowing driver auto-select 10:47:37.104: debug : do_open:930 : trying driver 0 (Test) ... 10:47:37.104: debug : do_open:936 : driver 0 Test returned DECLINED

Re: [libvirt] [PATCH] vbox: don't crash if init fails early

2009-05-07 Thread Pritesh Kothari
On Thursday 07 May 2009 10:52:15 Guido Günther wrote: Hi, not having set up pfuncs already results in a core dump. O.k. to apply? ACK, Regards, Pritesh -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Re: Has anyone ever gotten the client or full to compile on OS X?

2009-05-07 Thread Pritesh Kothari
On Thursday 07 May 2009 11:20:10 Daniel Veillard wrote: On Wed, May 06, 2009 at 03:20:23PM -0500, Schley Andrew Kutz wrote: Anyone? :( I really don't want to have to bring up a whole new box just do do dev work that I should be able to do from my Mac. I guess I can write against the Java

[libvirt] [PATCH 1/3] Support for vrdp/sdl/gui while defining a machine

2009-05-07 Thread Pritesh Kothari
Hi All, I have added support for vrdp/sdl/gui modes for VirtualBox driver in libvirt. Tha patch's are as below: [PATCH 1/3]: contains support for vrdp/sdl/gui while defining a machine. [PATCH 2/3]: contains support for vrdp/sdl/gui while dumping xml [PATCH 3/3]: contains support for

[libvirt] [PATCH 2/3] Support for vrdp/sdl/gui while dumping xml

2009-05-07 Thread Pritesh Kothari
Hi All, I have added support for vrdp/sdl/gui modes for VirtualBox driver in libvirt. Tha patch's are as below: [PATCH 1/3]: contains support for vrdp/sdl/gui while defining a machine. [PATCH 2/3]: contains support for vrdp/sdl/gui while dumping xml [PATCH 3/3]: contains support for

Re: [libvirt] [PATCH 0/1] Added Networking API to change/create/etc. hostonly/internal network in VirtualBox

2009-05-06 Thread Pritesh Kothari
change/create/etc. hostonly/internal network in VirtualBox network namevboxnet0/name uuid786f6276-656e-4074-8000-0a002700/uuid forward mode='hostonly'/ This line isn't neccessary - AFAICT there is no forwarding off traffic from hostonly networks to the LAN. Just set

[libvirt] [PATCH 3/3] networking API for hostonly networks in VirtualBox driver in libvirt

2009-05-06 Thread Pritesh Kothari
Hi All, As discussed on the list resending the networking patch's. the patch's are as below: [PATCH 1/3]: contains support for Internal network in libvirt [PATCH 2/3]: contains support for Host only and Internal networks in VirtualBox driver [PATCH 3/3]: contains networking API for hostonly

[libvirt] [PATCH 2/3] support for Host only and Internal networks in VirtualBox driver

2009-05-06 Thread Pritesh Kothari
Hi All, As discussed on the list resending the networking patch's. the patch's are as below: [PATCH 1/3]: contains support for Internal network in libvirt [PATCH 2/3]: contains support for Host only and Internal networks in VirtualBox driver [PATCH 3/3]: contains networking API for hostonly

[libvirt] [PATCH 1/3] support for Internal network in libvirt

2009-05-06 Thread Pritesh Kothari
Hi All, As discussed on the list resending the networking patch's. the patch's are as below: [PATCH 1/3]: contains support for Internal network in libvirt [PATCH 2/3]: contains support for Host only and Internal networks in VirtualBox driver [PATCH 3/3]: contains networking API for hostonly

Re: [libvirt] [PATCH 2/2] support for multiple graphics devices

2009-05-06 Thread Pritesh Kothari
On Wednesday 06 May 2009 18:08:39 you wrote: On Thu, Apr 30, 2009 at 11:28:31AM +0200, Pritesh Kothari wrote: Hi All, I have added support for multiple graphics devices, the patches are as below. I have checked them against current cvs head and works fine PATCH 1/2: contains changes

[libvirt] [PATCH 1/2] support for multiple graphics devices

2009-04-30 Thread Pritesh Kothari
Hi All, I have added support for multiple graphics devices, the patches are as below. I have checked them against current cvs head and works fine PATCH 1/2: contains changes in libvirt for multiple graphics devices PATCH 2/2: contains corresponding changes in qemu driver. Regards, Pritesh diff

[libvirt] [PATCH 2/2] support for multiple graphics devices

2009-04-30 Thread Pritesh Kothari
Hi All, I have added support for multiple graphics devices, the patches are as below. I have checked them against current cvs head and works fine PATCH 1/2: contains changes in libvirt for multiple graphics devices PATCH 2/2: contains corresponding changes in qemu driver. Regards, Pritesh diff

Re: [libvirt] [PATCH 1/1] Changes in version detection and moving a global variable in the global struct

2009-04-30 Thread Pritesh Kothari
On Thursday 30 April 2009 14:26:06 Daniel P. Berrange wrote: On Wed, Apr 29, 2009 at 01:14:05PM +0200, Pritesh Kothari wrote: Hi All, PATCH 1/1: contains changes in version detection and moving a global variable in the global struct, so that no more global vairables exists

[libvirt] [PATCH 1/1] Support for rdp/desktop types in graphics tag

2009-04-30 Thread Pritesh Kothari
Hi All, As per the discussion earlier on the list I have modified the rdp type and added a new desktop type and posting the patch for same. Regards, Pritesh diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 2f784e1..5e4aa5b 100644 --- a/docs/schemas/domain.rng +++

[libvirt] [PATCH 1/1] Changes in version detection and moving a global variable in the global struct

2009-04-29 Thread Pritesh Kothari
Hi All, PATCH 1/1: contains changes in version detection and moving a global variable in the global struct, so that no more global vairables exists. Regards, Pritesh commit 4a76967975b311151454af60d03c1e84ad0f6a11 Author: Pritesh Kothari pritesh.koth...@sun.com Date: Wed Apr 29 11:16:59 2009

[libvirt] [PATCH 1/1] Making path detection more robust in VirtualBox

2009-04-29 Thread Pritesh Kothari
Hi All, PATCH 1/1: contains changes in the glue code for making path detection more robust in VirtualBox Regards, Pritesh commit 0f31b4cce710ab6efea352174049e305b29a7a2f Author: Pritesh Kothari pritesh.koth...@sun.com Date: Wed Apr 29 10:52:37 2009 +0200 made the path detection more

[libvirt] [PATCH 2/2] Support for 'hostonly' and 'internal' network in VirtualBox

2009-04-29 Thread Pritesh Kothari
: contains changes in the vbox driver itself. Regards, Pritesh commit 43eb6ab5ce2ab1918c804614ca2b345858f2294c Author: Pritesh Kothari pritesh.koth...@sun.com Date: Wed Apr 29 11:22:38 2009 +0200 hostonly and internal networking added with changes as specified on the list diff --git a/src/vbox

[libvirt] [PATCH 1/2] Support for 'hostonly' and 'internal' network in VirtualBox

2009-04-29 Thread Pritesh Kothari
: contains changes in the vbox driver itself. Regards, Pritesh commit 11024ae0d14c1d0a2fdf1d141ce598e14435b2d3 Author: Pritesh Kothari pritesh.koth...@sun.com Date: Wed Apr 29 10:49:02 2009 +0200 added 'mode' attribute to source tag under interface diff --git a/src/domain_conf.c b/src/domain_conf.c

[libvirt] [PATCH 1/1] Added Networking API to change/create/etc. hostonly/internal network in VirtualBox

2009-04-29 Thread Pritesh Kothari
Hi All: [PATCH 0/1]: Contains sample xml file showing features supported so far. [PATCH 1/1]: Contains the patch for adding Networking API to change/create/etc. hostonly/internal network in VirtualBox Regards, Pritesh diff --git a/src/network_conf.c b/src/network_conf.c index b4da3fb..b4e0b39

[libvirt] [PATCH 0/1] Added Networking API to change/create/etc. hostonly/internal network in VirtualBox

2009-04-29 Thread Pritesh Kothari
Hi All: [PATCH 0/1]: Contains sample xml file showing features supported so far. [PATCH 1/1]: Contains the patch for adding Networking API to change/create/etc. hostonly/internal network in VirtualBox Regards, Pritesh network namevboxnet0/name uuid786f6276-656e-4074-8000-0a002700/uuid

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-24 Thread Pritesh Kothari
true. no need for that. Actually I believe there is. I think what was originally meant was whether the domain would be able to do real accelerated 3D using the host hardware, from the guest. VBox provides an option to make 3D calls on the virtualized video card call the real 3D api of the

Re: [libvirt] libvirt Driver support Matrix.

2009-04-24 Thread Pritesh Kothari
On Friday 24 April 2009 10:59:11 Abhishek K Jha wrote: Hi, I needed to know if libvirt supports migration via the QEMU/KVM driver. ( virDomainMigrate) Could someone point me to the latest driver support matrix for libvirt. It seems the one at http://libvirt.org/hvsupport.html was last

Re: [libvirt] libvirt Driver support Matrix.

2009-04-24 Thread Pritesh Kothari
Hi Abhishek, If I look at the latest hvsupport.html, it still shows virDomainMigrate as unsupported by QEMU/KVM. I did some more search and if I look at the log ( http://git.et.redhat.com/?p=libvirt.git;a=log;h=2bfdcfda7c55c3ed59c16e82fcba86ed6e42e0b4 ) , I see an entry for Fix URI check

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
Hi Daniel, graphics type='desktop'/ graphics type='rdp' port='1234' autoport='no' listen='172.21.4.3'/ this seems ok, but the only question I have is, currently libvirt supports only one virDomainGraphicsDef, so is it ok for me add support for more then one virDomainGraphicsDef? or else

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
Hi Daniel, yes this is a limitation of the impelentation, not of the model, it makes more sense to allow multiple graphis entries. Ok, will do this. feedback about attributes (auth='external' authtimeout='1234') would also be appreciated. Thanks. auth='external' sounds unclear,

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
Hi Daniel, We don't currently have any explicit representation of a video card device. The graphics tag is really representing the host I/O layer, covering video, mouse, keyboard (and potentially audio too). I didn't get you here? i mean there is a seperate virDomainSoundDefPtr,

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
On Thursday 23 April 2009 14:47:17 Daniel P. Berrange wrote: On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: Hi Daniel, We don't currently have any explicit representation of a video card device. The graphics tag is really representing the host I/O layer, covering

Re: [libvirt] [PATCH 1/2] (Updated fixed) OpenNebula driver, libvirt-0.6.2

2009-04-22 Thread Pritesh Kothari
Hi Abel - Included driver's files in a different directory src/opennebula Great, wouldn't crowd the src/ directory anymore, thanks. domain) { break; case VIR_FROM_VBOX: dom = VBOX ; +case VIR_FROM_ONE: +dom = ONE ; break; }

[libvirt] [PATCH] Documentation for VirtualBox support

2009-04-21 Thread Pritesh Kothari
Author: Pritesh Kothari pritesh.koth...@sun.com Date: Tue Apr 21 13:22:20 2009 +0200 libvirt: VirtualBox Documentation diff --git a/docs/drivers.html.in b/docs/drivers.html.in index 344a89a..e281258 100644 --- a/docs/drivers.html.in +++ b/docs/drivers.html.in @@ -22,6 +22,7

Re: [libvirt] VirtualBox libvirt support sample XML file

2009-04-16 Thread Pritesh Kothari
Hi Daniel, !--INTERNAL NETWORK -- interface type='network' source network='int_net'/ model type='am79c970a'/ /interface !-- HOST ONLY NETWORK -- interface type='ethernet'

[libvirt] [PATCH 1/4] VirtualBox support

2009-04-16 Thread Pritesh Kothari
Hi All, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. It takes cares of all the stuff mentioned on the list earlier. Still if I have missed anything, please do tell me. The patches are organized as below: Patch 0/4: contains

[libvirt] [PATCH 3/4] VirtualBox support

2009-04-16 Thread Pritesh Kothari
Hi All, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. It takes cares of all the stuff mentioned on the list earlier. Still if I have missed anything, please do tell me. The patches are organized as below: Patch 0/4: contains

[libvirt] [PATCH 0/4] VirtualBox support

2009-04-16 Thread Pritesh Kothari
Hi All, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. It takes cares of all the stuff mentioned on the list earlier. Still if I have missed anything, please do tell me. The patches are organized as below: Patch 0/4: contains

[libvirt] [PATCH 4/4] VirtualBox support

2009-04-16 Thread Pritesh Kothari
Hi All, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. It takes cares of all the stuff mentioned on the list earlier. Still if I have missed anything, please do tell me. The patches are organized as below: Patch 0/4: contains

Re: [libvirt] [PATCH 2/4] VirtualBox support

2009-04-16 Thread Pritesh Kothari
Hi Daniel, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. It takes cares of all the stuff mentioned on the list earlier. Still if I have missed anything, please do tell me. I actually just tried out your previous patch from

Re: [libvirt] [PATCH 2/2] VirtualBox support (Resending by fixing a autodetection Bug)

2009-04-14 Thread Pritesh Kothari
Hi Daniel, +char g_szVBoxErrMsg[256]; I don't much like the static fixed size error message buffer Fixed this. +if (conn-uri == NULL) { +conn-uri = xmlParseURI(uid ? vbox:///session : vbox:///system); +if (conn-uri == NULL) { +vboxError(conn,

[libvirt] VirtualBox libvirt support sample XML file

2009-04-09 Thread Pritesh Kothari
Hi All, Just posting a sample XML file for creating a machine with all features supported by the patch, so that it is easy for everyone to know which features are supported till now, I am in process of adding the Documentation for same and thus posting this file till then. Regards Pritesh

[libvirt] [PATCH 1/2] VirtualBox support

2009-04-08 Thread Pritesh Kothari
and the 2.2 release. [PATCH 1/2] contains diff of files already in libvirt. [PATCH 2/2] contains new files needed for VirtualBox support. Regards, Pritesh commit 52462104988fc1bcbe62833fb8ea7e759e903e27 Author: Pritesh Kothari pritesh.koth...@sun.com Date: Wed Apr 8 12:13:16 2009 +0200 patch0

Re: [libvirt] Planning and schedule

2009-04-06 Thread Pritesh Kothari
Hi Daniel, Plannned so far for 0.6.3 are: - API for physical host interface - the VirtualBox driver if in shape and in time I am trying hard to bring up the Virtualbox driver in shape, so hopefully I will post another patch this week. Regards, Pritesh -- Libvir-list mailing list

Re: [libvirt] [PATCH 1/2] VirtualBox support to libvirt

2009-03-19 Thread Pritesh Kothari
Hi Daniel, +VBOX_DRIVER_SOURCES = \ +vbox/VBoxXPCOMCGlue.c vbox/VBoxXPCOMCGlue.h \ +vbox/vbox_driver.c vbox/vbox_driver.h \ +vbox/vbox_V2_2.c Hum, I wonder about the need of a subdirectory here, others drivers are directly

[libvirt] [PATCH 1/2] VirtualBox support to libvirt

2009-03-18 Thread Pritesh Kothari
Hi All, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. The patch works very well with the VirtualBox OSE version and the 2.2 Beta release. [PATCH 1/2] contains diff of files already in libvirt. [PATCH 2/2] contains new files needed

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-03-10 Thread Pritesh Kothari
Hi All, Small patch for updating the schema file and testcase for the same: diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 2e2e408..107215c 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -874,6 +874,7 @@ valuesb16/value

Re: [libvirt] PATCH: 25/25: Support ac97 sound card

2009-03-10 Thread Pritesh Kothari
Hi All, If you change this file, you'll also need to change the corresponding file tests/qemuxml2argvdata/qemuxml2argv-sound.args, which is the command line ARGV associated with that XML. Should merely need to add ',ac97' into the appropriate place. Resubmitting the patch with above change

Re: [libvirt] VirtualBox support to libvirt

2009-03-10 Thread Pritesh Kothari
Hi Daniel, Minor point for next time - it'd make it a little quicker to review if could just attach the plain vbox.patch file directly to the mail. If it hits the maximum attachment size allowed by mailman, one of us can easily approve the mail, or just split it into sections. Sorry, would

Re: [libvirt] some questions about libvirt features and limitations

2009-03-06 Thread Pritesh Kothari
Hi Daniel, We'd very much like to see VirtualBox suported as a driver in libvirt because its a pretty popular open source virt technology and there have been quite a few feature requests from users for it to be included. I have an very rough snapshot working just for

[libvirt] VirtualBox support to libvirt

2009-03-06 Thread Pritesh Kothari
Hi All, I have attached a patch which when applied on the HEAD would allow virtualbox support in libvirt. The steps to apply patch are: tar -zxvf vbox-patch.tar.gz git-apply vbox-patch The patch works very well with the VirtualBox OSE svn HEAD and is supposed to support VirtualBox 2.2 onwards

Re: [libvirt] some questions about libvirt features and limitations

2009-03-04 Thread Pritesh Kothari
Hi Florian, Someone mentioned a VirtualBox driver. I'm highly interested in this. How is it going ? I'd be more than happy to beta test if required. Will it work with both PUEL and OSE versions ? When will it be ready for inclusion in libvirt ? How will you handle RDP access, as from what I

Re: [libvirt] Adding VirtualBox support to libvirt

2009-02-26 Thread Pritesh Kothari
, etc as well ) I am using dlopen() and friends to open the VirtualBox library at runtime, is it ok? cause I didn't see any driver doing something like this. Regards, -pritesh On Wednesday 03 December 2008 14:26:30 Daniel Veillard wrote: On Wed, Dec 03, 2008 at 02:20:44PM +0100, Pritesh Kothari

Re: [libvirt] Adding VirtualBox support to libvirt

2009-02-26 Thread Pritesh Kothari
Hi Daniel, As of 0.6.0, the libvirtd daemon is fully multi-threaded. This means that many API calls can be using your driver concurrently. So every driver API call you have (ie those registered in the 'virDriver' struct must use one or more mutexs to ensure safe access to internal state.

Re: [libvirt] Adding VirtualBox support to libvirt

2009-02-26 Thread Pritesh Kothari
Hi John, Generally, if you can, use the generic parts. If you need to specify something specific to VBox you have three options: 1. work out a hypervisor-agnostic abstraction for what you're trying to define (preferred), then use that 1. define a vbox-specific ref as you above 2. if it's

[libvirt] Adding VirtualBox support to libvirt

2008-12-03 Thread Pritesh Kothari
Hi, I am in the process of adding support for virtualbox in libvirt. Basically Virtualbox exports its API through XPCOM. Now to simplify things I was thinking of using C++ and already existing xpcom component in virtualbox but since libvirt exports C API i am not sure if i should use C++ or