tall such
> machine just for trying out this patch, but I can clearly see it won't
> break anything that works right now, so...
Works fine on FreeBSD, as expected, so ACKed and pushed.
Roman Bogorodskiy
signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@red
onfig --libs --cflags libvirt
-I/usr/local/include -L/usr/local/lib -lvirt
$
If that does not work, could you please describe how did you do the
libvirt installation on your system?
Thanks,
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
src/bhyve/bhyve_driver.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index d44cf2c..efba0ae 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -465,6 +465,27 @@
Commit 89c509a0 added getters for cgroup block device I/O throttling,
however stub versions of these functions have not matching function
prototypes that result in compilation fail on platforms not supporting
cgroup.
Fix build by correcting prototypes of the stubbed functions.
Pushing under
on FreeBSD. Do I
get it right that it's something that I need to report to gnulib?
Roman Bogorodskiy
pgpyR0KvZpMT7.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Daniel P. Berrange wrote:
On Sun, Jul 19, 2015 at 11:20:35AM +0300, Roman Bogorodskiy wrote:
Bhyve as of r279225 (FreeBSD -CURRENT) or r284894 (FreeBSD 10-STABLE)
supports using UTC time offset via the '-u' argument to bhyve(8). By
default it's still using localtime.
Make the bhyve
Commit ac3ed20 breaks build on FreeBSD with:
CC util/libvirt_util_la-virnetdev.lo
util/virnetdev.c:2967:1: error: unused function 'virNetDevRDMAFeature'
[-Werror,-Wunused-function]
virNetDevRDMAFeature(const char *ifname,
^
So hide virNetDevRDMAFeature function under the #ifdef
Daniel P. Berrange wrote:
On Sun, Jul 19, 2015 at 11:20:36AM +0300, Roman Bogorodskiy wrote:
---
docs/drvbhyve.html.in | 28
1 file changed, 28 insertions(+)
ACK
Pushed, thanks!
Regards,
Daniel
--
|: http://berrange.com -o-http
Martin Kletzander wrote:
On Fri, Jul 17, 2015 at 08:23:07PM +0300, Roman Bogorodskiy wrote:
Currently, build fails on FreeBSD with:
CC libvirt_driver_la-nodeinfo.lo
nodeinfo.c:1941:56: error: use of undeclared identifier 'SYSFS_SYSTEM_PATH'
const char *prefix = sysfs_prefix
Bhyve as of r279225 (FreeBSD -CURRENT) or r284894 (FreeBSD 10-STABLE)
supports using UTC time offset via the '-u' argument to bhyve(8). By
default it's still using localtime.
Make the bhyve driver use UTC clock if it's requested by specifying
clock offset='utc' in domain XML and if the bhyve(8)
---
docs/drvbhyve.html.in | 28
1 file changed, 28 insertions(+)
diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in
index 5479511..485b051 100644
--- a/docs/drvbhyve.html.in
+++ b/docs/drvbhyve.html.in
@@ -250,5 +250,33 @@ attempt to boot from the first
Currently, build fails on FreeBSD with:
CC libvirt_driver_la-nodeinfo.lo
nodeinfo.c:1941:56: error: use of undeclared identifier 'SYSFS_SYSTEM_PATH'
const char *prefix = sysfs_prefix ? sysfs_prefix : SYSFS_SYSTEM_PATH;
^
1 error
Commit 825df8c3 refactored virProcess{Set,Get}Affinity routines,
however broke BSD implementation because of the incorrect variable
name. Fix build by using a proper variable name.
Pushing as trivial and build break fix.
---
src/util/virprocess.c | 2 +-
1 file changed, 1 insertion(+), 1
Roman Bogorodskiy wrote:
Martin Kletzander wrote:
On Thu, May 28, 2015 at 11:11:06AM +0400, Roman Bogorodskiy wrote:
Jim Fehlig wrote:
On 05/27/2015 09:06 AM, Martin Kletzander wrote:
On Sun, May 24, 2015 at 06:45:02PM +0300, Roman Bogorodskiy wrote:
The libxl tries
Martin Kletzander wrote:
On Thu, May 28, 2015 at 11:11:06AM +0400, Roman Bogorodskiy wrote:
Jim Fehlig wrote:
On 05/27/2015 09:06 AM, Martin Kletzander wrote:
On Sun, May 24, 2015 at 06:45:02PM +0300, Roman Bogorodskiy wrote:
The libxl tries to check if it's running in dom0
Jim Fehlig wrote:
On 05/27/2015 09:06 AM, Martin Kletzander wrote:
On Sun, May 24, 2015 at 06:45:02PM +0300, Roman Bogorodskiy wrote:
The libxl tries to check if it's running in dom0 by parsing
/proc/xen/capabilities and if that fails it doesn't load.
There's no procfs interface
Cole Robinson wrote:
On 05/26/2015 12:30 AM, Roman Bogorodskiy wrote:
Commit 7c2d65d dropped setting default mode.
Update zfs tests accordingly.
---
tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml | 3 ---
tests/storagepoolxml2xmlout/pool-zfs.xml | 3 ---
2 files
Commit 7c2d65d dropped setting default mode.
Update zfs tests accordingly.
---
tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml | 3 ---
tests/storagepoolxml2xmlout/pool-zfs.xml | 3 ---
2 files changed, 6 deletions(-)
diff --git a/tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml
Martin Kletzander wrote:
On Sat, May 23, 2015 at 09:15:08PM +0300, Roman Bogorodskiy wrote:
The libxl tries to check if it's running in dom0 by parsing
/proc/xen/capabilities and if that fails it doesn't load.
There's no procfs interface in Xen on FreeBSD, so this check always
fails
The libxl tries to check if it's running in dom0 by parsing
/proc/xen/capabilities and if that fails it doesn't load.
There's no procfs interface in Xen on FreeBSD, so this check always
fails.
In addition to checking procfs, check if /dev/xen/xenstored, that's enough to
check if we're running in
Eric Blake wrote:
On 05/23/2015 02:45 PM, Martin Kletzander wrote:
On Sat, May 23, 2015 at 08:05:23PM +0300, Roman Bogorodskiy wrote:
Build with gcc 4.8 fails with:
Arguably a bug in gcc; but since we can work around it without too much
pain, we should.
bhyve/bhyve_monitor.c
Martin Kletzander wrote:
On Sat, May 23, 2015 at 10:49:09PM +0300, Roman Bogorodskiy wrote:
Commit c4d27bd dropped output of owner/group -1.
Update zfs tests accordingly.
---
tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml | 2 --
tests/storagepoolxml2xmlout/pool-zfs.xml
Commit c4d27bd dropped output of owner/group -1.
Update zfs tests accordingly.
---
tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml | 2 --
tests/storagepoolxml2xmlout/pool-zfs.xml | 2 --
2 files changed, 4 deletions(-)
diff --git
Build with gcc 4.8 fails with:
bhyve/bhyve_monitor.c: In function 'bhyveMonitorIO':
bhyve/bhyve_monitor.c:51:18: error: missing initializer for field 'tv_sec' of
'const struct timespec' [-Werror=missing-field-initializers]
const struct timespec zerowait = {};
Explicitly initialize zerowait
similar to that one.
By the way, clang doesn't do much inlining with -O0, I guess that could
be similar in gcc, so it should be a quick check to see if that's a
compiler problem.
Roman Bogorodskiy
pgpUasjwoS_Ku.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
The libxl tries to check if it's running in dom0 by parsing
/proc/xen/capabilities and if that fails it doesn't load.
There's no procfs interface in Xen on FreeBSD, so this check always
fails.
Instead of using procfs, check if /dev/xen/xenstored, that's enough to
check if we're running in dom0
Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Eric Blake wrote:
On 05/08/2015 12:23 AM, Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Currently the stack frame size limit is set to 4096 and it started to
cause an error
Ján Tomko wrote:
On Sat, May 09, 2015 at 07:51:55PM +0300, Roman Bogorodskiy wrote:
Due to clang problems[1] I've switched to gcc from FreeBSD ports.
That involves some minor fixes provided in this series.
Roman Bogorodskiy (2):
bhyve: fix bhyvexml2argvtest build with gcc
gcc5 reports an error like this:
bhyvexml2argvtest.c: In function 'testCompareXMLToArgvFiles':
bhyvexml2argvtest.c:24:18: error: variable 'vm' set but not used
[-Werror=unused-but-set-variable]
virDomainObj vm;
^
cc1: all warnings being treated as errors
Fix by dropping
Due to clang problems[1] I've switched to gcc from FreeBSD ports.
That involves some minor fixes provided in this series.
Roman Bogorodskiy (2):
bhyve: fix bhyvexml2argvtest build with gcc
maint: extend PIE support check
m4/virt-compile-pie.m4| 4 ++--
tests/bhyvexml2argvtest.c | 2
GCC installed from FreeBSD ports doesn't support building PIE executables
and fails with:
/usr/local/bin/ld: /usr/lib/crt1.o: relocation R_X86_64_32 against
`_DYNAMIC' can not be used when making a shared object; recompile with
-fPIC
/usr/lib/crt1.o: error adding symbols: Bad value
collect2:
Roman Bogorodskiy wrote:
Eric Blake wrote:
On 05/08/2015 12:23 AM, Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Currently the stack frame size limit is set to 4096 and it started to
cause an error like this:
virshtest.c:253:1
Roman Bogorodskiy wrote:
Due to clang problems[1] I've switched to gcc from FreeBSD ports.
That involves some minor fixes provided in this series.
Oops, it misses:
1: https://www.redhat.com/archives/libvir-list/2015-May/msg00011.html
Roman Bogorodskiy (2):
bhyve: fix bhyvexml2argvtest
Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Currently the stack frame size limit is set to 4096 and it started to
cause an error like this:
virshtest.c:253:1: error: stack frame size of 5512 bytes in function
'mymain' [-Werror,-Wframe-larger-than=]
mymain(void)
^
1
Eric Blake wrote:
On 05/08/2015 12:23 AM, Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Roman Bogorodskiy wrote:
Currently the stack frame size limit is set to 4096 and it started to
cause an error like this:
virshtest.c:253:1: error: stack frame size of 5512 bytes
Currently the stack frame size limit is set to 4096 and it started to
cause an error like this:
virshtest.c:253:1: error: stack frame size of 5512 bytes in function
'mymain' [-Werror,-Wframe-larger-than=]
mymain(void)
^
1 error generated.
Increase it to 6144.
---
m4/virt-compile-warnings.m4 | 2
Roman Bogorodskiy wrote:
Currently the stack frame size limit is set to 4096 and it started to
cause an error like this:
virshtest.c:253:1: error: stack frame size of 5512 bytes in function
'mymain' [-Werror,-Wframe-larger-than=]
mymain(void)
^
1 error generated.
Increase it to 6144
Peter Krempa wrote:
On Tue, Apr 28, 2015 at 08:30:30 +0400, Roman Bogorodskiy wrote:
Build with clang fails with:
CC conf/libvirt_conf_la-domain_conf.lo
conf/domain_conf.c:13377:9: error: variable 'cpumask' is used
uninitialized whenever 'if' condition is true
Build with clang fails with:
CC conf/libvirt_conf_la-domain_conf.lo
conf/domain_conf.c:13377:9: error: variable 'cpumask' is used
uninitialized whenever 'if' condition is true
[-Werror,-Wsometimes-uninitialized]
if (!(tmp = virXMLPropString(node, cpuset))) {
Roman Bogorodskiy
pgpRoRDRSPR1W.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Commit ca32929 caused build errors in bhyvexml2argvtest.c because of
some undefined variables.
Pushing under the build breaker rule.
---
tests/bhyvexml2argvtest.c | 4
1 file changed, 4 deletions(-)
diff --git a/tests/bhyvexml2argvtest.c b/tests/bhyvexml2argvtest.c
index 1cce2aa..1c7bc31
Commit 835cf84 dropped expectedVirtTypes argument for
virDomainDefParse*() functions, however bhyve tests still try to pass
that to virDomainDefParseFile(), therefore build fails.
Fix build by fixing virDomainDefParseFile() usage.
---
tests/bhyvexml2argvtest.c | 1 -
tests/bhyvexml2xmltest.c |
Peter Krempa wrote:
On Thu, Apr 23, 2015 at 10:55:12 +0400, Roman Bogorodskiy wrote:
Commit 835cf84 dropped expectedVirtTypes argument for
virDomainDefParse*() functions, however bhyve tests still try to pass
that to virDomainDefParseFile(), therefore build fails.
Fix build
Martin Kletzander wrote:
On Tue, Apr 21, 2015 at 08:19:45PM +0300, Roman Bogorodskiy wrote:
When running on FreeBSD, there's a bug in virCommandProcessIO
polling that is triggered by the commandtest.
A test that triggers EPIPE in commandtest (named test20) hungs
forever on FreeBSD
Peter Krempa wrote:
On Wed, Apr 22, 2015 at 12:19:51 +0400, Roman Bogorodskiy wrote:
Build fails on non-Linux systems with this error:
CC util/libvirt_util_la-virnetdev.lo
util/virnetdev.c:364:1: error: unused function 'virNetDevReplaceMacAddress'
[-Werror,-Wunused-function
Build fails on non-Linux systems with this error:
CC util/libvirt_util_la-virnetdev.lo
util/virnetdev.c:364:1: error: unused function 'virNetDevReplaceMacAddress'
[-Werror,-Wunused-function]
virNetDevReplaceMacAddress(const char *linkdev,
^
util/virnetdev.c:406:1: error: unused function
When running on FreeBSD, there's a bug in virCommandProcessIO
polling that is triggered by the commandtest.
A test that triggers EPIPE in commandtest (named test20) hungs
forever on FreeBSD.
Apparently, this happens because FreeBSD sets POLLHUP flag on revents
when stdin in closed. And as the
When building without lxc support enabled, build fails with:
CLD vircapstest
vircapstest.o: In function `test_virCapsDomainDataLookupLXC':
vircapstest.c:(.text+0x9ef): undefined reference to `testLXCCapsInit'
Fix that by hiding LXC tests under appropriate #ifdef.
---
tests/vircapstest.c | 4
John Ferlan wrote:
On 10/29/2014 02:20 PM, Roman Bogorodskiy wrote:
Currently, build fails on FreeBSD because its struct ifreq does not
have ifr_hwaddr member. In order to fix that, check if this member
is present, otherwise fall back to the stub version of the
virNetDev{Add,Del}Multi
John Ferlan wrote:
On 10/29/2014 02:20 PM, Roman Bogorodskiy wrote:
The virGetSCSIHostNumber function return type is int, however
its stubbed version returns NULL. That results in a build fail
on systems that uses the stubbed version. Fix by using a proper
return type.
---
src
without
issues
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
'
virMacAddrGetRaw(macaddr, (unsigned char *)ifr.ifr_hwaddr.sa_data);
~~~ ^
4 errors generated.
I have fixes for that, will send the patches shortly.
Roman Bogorodskiy
pgpomXO1zB7mD.pgp
Description: PGP signature
--
libvir-list mailing list
libvir
The virGetSCSIHostNumber function return type is int, however
its stubbed version returns NULL. That results in a build fail
on systems that uses the stubbed version. Fix by using a proper
return type.
---
src/util/virutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Currently, build fails on FreeBSD because its struct ifreq does not
have ifr_hwaddr member. In order to fix that, check if this member
is present, otherwise fall back to the stub version of the
virNetDev{Add,Del}Multi functions.
---
configure.ac | 3 ++-
src/util/virnetdev.c | 6 --
2
Laine Stump wrote:
On 10/29/2014 02:08 PM, Roman Bogorodskiy wrote:
Conrad Meyer wrote:
Hi all,
The recent commit with SHA1 cc0e8c244d080f56392278e836cc378ba848e7aa,
util: Functions to update host network device's multicast filter,
breaks the build on FreeBSD, so please address
users will have to rebuild libvirt if
they want to update bhyve-grub.
+virCommandAddArg(cmd, chr-source.data.file.path);
+}
+
/* VM name */
virCommandAddArg(cmd, def-name);
--
1.9.3
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https
://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Roman Bogorodskiy
pgpcUeO0cSTEf.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
@@ struct _bhyveConn {
virCapsPtr caps;
virDomainXMLOptionPtr xmlopt;
char *pidfile;
+char *grub_devicesmap_file;
virSysinfoDefPtr hostsysinfo;
virObjectEventStatePtr domainEventState;
--
1.9.3
Roman Bogorodskiy
pgpU7R_ed9xuj.pgp
Description: PGP
Conrad Meyer wrote:
On Sun, Oct 26, 2014 at 7:00 AM, Roman Bogorodskiy
bogorods...@gmail.com wrote:
Conrad Meyer wrote:
I've tested the HDD boot and it seems to work.
I've tried to boot from CD and had a problem with that. It generates a
command like that:
/usr/local/sbin
Conrad Rad wrote:
On Fri, Oct 24, 2014 at 12:58 AM, Roman Bogorodskiy
bogorods...@gmail.com wrote:
Conrad Meyer wrote:
Hi Conrad.
Thanks for the patch. As for the /tmp, probably storing it somewhere in
BHYVE_STATE_DIR would be more clean.
Sure.
However, I'm concerned about
, send any mail to
freebsd-virtualization-unsubscr...@freebsd.org
Thanks,
Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Eric Blake wrote:
On 10/21/2014 08:22 AM, Roman Bogorodskiy wrote:
Build with clang fails with:
CC util/libvirt_util_la-virsocketaddr.lo
util/virsocketaddr.c:904:17: error: cast from 'struct sockaddr *' to
'struct sockaddr_in *' increases required alignment from 1 to 4
Build with clang fails with:
CC util/libvirt_util_la-virsocketaddr.lo
util/virsocketaddr.c:904:17: error: cast from 'struct sockaddr *' to
'struct sockaddr_in *' increases required alignment from 1 to 4
[-Werror,-Wcast-align]
inet4 = (struct sockaddr_in*) res-ai_addr;
Eric Blake wrote:
On 10/18/2014 10:41 AM, Roman Bogorodskiy wrote:
Build with clang fails with:
CC util/libvirt_util_la-virsocketaddr.lo
util/virsocketaddr.c:904:17: error: cast from 'struct sockaddr *' to
'struct sockaddr_in *' increases required alignment from 1 to 4
Build with clang fails with:
CC util/libvirt_util_la-virsocketaddr.lo
util/virsocketaddr.c:904:17: error: cast from 'struct sockaddr *' to
'struct sockaddr_in *' increases required alignment from 1 to 4
[-Werror,-Wcast-align]
inet4 = (struct sockaddr_in*) res-ai_addr;
copied the author of that commit to get an opinion...
Hi,
Yes, I guess 'goto cleanup' is missing here indeed. VIR_WARN() will also
work, but probably it'd be better user experience to report an unsupported
configuration and fail early instead of showing a warning that could be
missed.
Roman
Currently, build with clang fails with:
CC qemu/libvirt_driver_qemu_impl_la-qemu_command.lo
qemu/qemu_command.c:6580:58: error: implicit conversion from enumeration type
'virMemAccess' to different enumeration type 'virTristateSwitch'
[-Werror,-Wenum-conversion]
virTristateSwitch
Commit b20d39a introduced a new argument for the
virNetDevTapCreateInBridgePort function, however, its mock
in bhyve tests wasn't updated, so the build failed.
Fix build by adding this new argument to the mock version.
---
tests/bhyvexml2argvmock.c | 1 +
1 file changed, 1 insertion(+)
diff
Commit f05b6a91 added virQEMUDriverConfigPtr argument to the
virQEMUCapsFillDomainCaps function and it uses forward declaration
of virQEMUDriverConfig and virQEMUDriverConfigPtr that casues clang
build to fail:
gmake[3]: Entering directory `/usr/home/novel/code/libvirt/src'
CC
Michal Privoznik wrote:
On 18.09.2014 08:47, Roman Bogorodskiy wrote:
Commit b20d39a introduced a new argument for the
virNetDevTapCreateInBridgePort function, however, its mock
in bhyve tests wasn't updated, so the build failed.
Fix build by adding this new argument to the mock
Ján Tomko wrote:
On 09/14/2014 05:46 AM, Roman Bogorodskiy wrote:
- Provide an implementation for buildPool and deletePool operations
for the ZFS storage backend.
- Add VIR_STORAGE_POOL_SOURCE_DEVICE flag to ZFS pool poolOptions
as now we can specify devices to build pool from
Ján Tomko wrote:
On 09/14/2014 07:24 AM, Roman Bogorodskiy wrote:
- docs/formatstorage.html.in: document 'zfs' pool type, add it
to a list of pool types that could use source physical devices
- docs/storage.html.in: update a ZFS pool example XML with
source physical devices
- Provide an implementation for buildPool and deletePool operations
for the ZFS storage backend.
- Add VIR_STORAGE_POOL_SOURCE_DEVICE flag to ZFS pool poolOptions
as now we can specify devices to build pool from
- storagepool.rng: add an optional 'sourceinfodev' to 'sourcezfs' and
add
Roman Bogorodskiy wrote:
Ján Tomko wrote:
On 09/07/2014 04:15 PM, Roman Bogorodskiy wrote:
Provide an implementation for buildPool and deletePool operations for
the ZFS storage backend.
---
docs/schemas/storagepool.rng | 1 +
src/storage/storage_backend_zfs.c | 57
- docs/formatstorage.html.in: document 'zfs' pool type, add it
to a list of pool types that could use source physical devices
- docs/storage.html.in: update a ZFS pool example XML with
source physical devices, mention that starting from 1.2.9 a
pool could be created from this devices by
Ján Tomko wrote:
On 09/07/2014 04:15 PM, Roman Bogorodskiy wrote:
Provide an implementation for buildPool and deletePool operations for
the ZFS storage backend.
---
docs/schemas/storagepool.rng | 1 +
src/storage/storage_backend_zfs.c | 57
Provide an implementation for buildPool and deletePool operations for
the ZFS storage backend.
---
docs/schemas/storagepool.rng | 1 +
src/storage/storage_backend_zfs.c | 57 +++
2 files changed, 58 insertions(+)
diff --git a/docs/schemas/storagepool.rng
John Ferlan wrote:
On 08/27/2014 05:02 AM, Roman Bogorodskiy wrote:
Currently, after calling commands to create a new volumes,
virStorageBackendZFSCreateVol calls virStorageBackendZFSFindVols that
calls virStorageBackendZFSParseVol.
virStorageBackendZFSParseVol checks
but just a Wiki page.
So on one hand it's logical as when viewing a FAQ user is on Wiki, but
on the other hand it looks a little confusing indeed.
Roman Bogorodskiy
pgpx5F6RhLvlH.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo
Currently, after calling commands to create a new volumes,
virStorageBackendZFSCreateVol calls virStorageBackendZFSFindVols that
calls virStorageBackendZFSParseVol.
virStorageBackendZFSParseVol checks if a volume already exists by
trying to get it using virStorageVolDefFindByName.
For a just
Michal Privoznik wrote:
On 15.08.2014 10:44, Roman Bogorodskiy wrote:
Roman Bogorodskiy (3):
fdstream: report error if virSetNonBlock fails
fdstream: introduce virFDStreamOpenBlockDevice
storage: zfs: implement download and upload
src/fdstream.c| 30
(+), 1 deletion(-)
Sorry about that and thanks for the fix!
Roman Bogorodskiy
pgpMqC1TApAlA.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Roman Bogorodskiy wrote:
Roman Bogorodskiy (3):
fdstream: report error if virSetNonBlock fails
fdstream: introduce virFDStreamOpenBlockDevice
storage: zfs: implement download and upload
src/fdstream.c| 30 +++---
src/fdstream.h
@@ main(int argc, char **argv)
if (argc == 5)
hostname = argv[4];
+/* In case hostname is still unkown, use the last known one */
s/unkown/unknown/
+if (!hostname)
+hostname = virGetEnvAllowSUID(DNSMASQ_OLD_HOSTNAME);
+
Roman Bogorodskiy
pgpt2IQsV86lF.pgp
Michal Privoznik wrote:
On 15.08.2014 17:58, Roman Bogorodskiy wrote:
Changes from v1:
- Add volume support for the bhyveload command as
well to allow booting from a volume
Changes from v2:
- Move disk source pool translation to storage/storage_driver.c
instead
Changes from v1:
- Add volume support for the bhyveload command as
well to allow booting from a volume
Roman Bogorodskiy (2):
conf: make disk source pool translation generic
bhyve: add volumes support
src/bhyve/bhyve_command.c | 16 ++-
src/bhyve/bhyve_command.h | 7 +-
src/bhyve
Currently, qemu driver uses qemuTranslateDiskSourcePool()
to translate disk volume information. This function is
general enough and could be used for other drivers as well,
so move it to conf/domain_conf.c along with its helpers.
- qemuTranslateDiskSourcePool: move to conf/domain_conf.c
and
Update bhyveBuildDiskArgStr to support volumes:
- Make virBhyveProcessBuildBhyveCmd and
virBhyveProcessBuildLoadCmd take virConnectPtr as the
first argument instead of bhyveConnPtr as virConnectPtr is
needed for virDomainTranslateDiskSourcePool,
- Add virDomainTranslateDiskSourcePool
Add an implementation of uploadVol and downloadVol using
virStorageBackendVolUploadLocal and virStorageBackendVolDownloadLocal
respectively.
---
src/storage/storage_backend_zfs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/storage/storage_backend_zfs.c
Roman Bogorodskiy (3):
fdstream: report error if virSetNonBlock fails
fdstream: introduce virFDStreamOpenBlockDevice
storage: zfs: implement download and upload
src/fdstream.c| 30 +++---
src/fdstream.h| 5 +
src
virStorageBackendVolDownloadLocal and virStorageBackendVolUploadLocal
use virFDStreamOpenFile function to work with the volume fd.
virFDStreamOpenFile calls virFDStreamOpenFileInternal that implements
handling of the non-blocking I/O. If a file is not a character device and
not a fifo, it uses
virFDStreamOpenInternal terminates if virSetNonBlock fails. As
virSetNonBlock uses gnulib's set_nonblocking_flag that sets errno,
call virReportSystemError() to let user know the reason of fail.
---
src/fdstream.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Daniel P. Berrange wrote:
On Fri, Aug 15, 2014 at 12:44:21PM +0400, Roman Bogorodskiy wrote:
virStorageBackendVolDownloadLocal and virStorageBackendVolUploadLocal
use virFDStreamOpenFile function to work with the volume fd.
virFDStreamOpenFile calls virFDStreamOpenFileInternal
Daniel P. Berrange wrote:
On Fri, Aug 15, 2014 at 12:55:58PM +0400, Roman Bogorodskiy wrote:
Daniel P. Berrange wrote:
On Fri, Aug 15, 2014 at 12:44:21PM +0400, Roman Bogorodskiy wrote:
virStorageBackendVolDownloadLocal and virStorageBackendVolUploadLocal
use
Update bhyveBuildDiskArgStr to support volumes:
- Make virBhyveProcessBuildBhyveCmd and
virBhyveProcessBuildLoadCmd take virConnectPtr as the
first argument instead of bhyveConnPtr as virConnectPtr is
needed for virStorageTranslateDiskSourcePool,
- Add virStorageTranslateDiskSourcePool
driver that
is not needed for many drivers
Roman Bogorodskiy (2):
conf: make disk source pool translation generic
bhyve: add volumes support
src/bhyve/bhyve_command.c| 17 ++-
src/bhyve/bhyve_command.h| 7 +-
src/bhyve/bhyve_driver.c | 4 +-
src/bhyve/bhyve_process.c
Currently, qemu driver uses qemuTranslateDiskSourcePool()
to translate disk volume information. This function is
general enough and could be used for other drivers as well,
so move it to conf/domain_conf.c along with its helpers.
- qemuTranslateDiskSourcePool: move to storage/storage_driver.c
Update bhyveBuildDiskArgStr to support volumes:
- Make virBhyveProcessBuildBhyveCmd take virConnectPtr as the
first argument instead of bhyveConnPtr as virConnectPtr is
needed for virDomainTranslateDiskSourcePool,
- Add virDomainTranslateDiskSourcePool call to
Currently, qemu driver uses qemuTranslateDiskSourcePool()
to translate disk volume information. This function is
general enough and could be used for other drivers as well,
so move it to conf/domain_conf.c along with its helpers.
- qemuTranslateDiskSourcePool: move to conf/domain_conf.c
and
Ján Tomko wrote:
On 07/26/2014 06:13 PM, Roman Bogorodskiy wrote:
Implement ZFS storage backend driver. Currently supported
only on FreeBSD because of ZFS limitations on Linux.
---
configure.ac | 43 +
docs/schemas/storagepool.rng | 20 +++
docs
501 - 600 of 997 matches
Mail list logo
