[libvirt PATCH 3/3] vircgroupv1: fix null string specifier argument in virCgroupV1ValidatePlacement

2022-05-26 Thread Scott Davis
at %s"), | ^~ Signed-off-by: Scott Davis --- src/util/vircgroupv1.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c index 96f36c3b4d..cbee08e931 100644 --- a/src/util/vircgroupv1.c +++ b/src/util/vircgroupv1.c

[libvirt PATCH 0/3] Fix null string specifiers detected by GCC

2022-05-26 Thread Scott Davis
Each of the following tripped the -Wformat-overflow warning in GCC 11. The fixes all seemed pretty obvious based on the context. Apologies for any formatting or other mistakes, this is my first time submitting libvirt patches and using git publish. Scott Davis (3): qemu: fix null string

[libvirt PATCH 1/3] qemu: fix null string specifier argument in qemuDomainBlockJobAbort

2022-05-26 Thread Scott Davis
: %s"), | ^~ Signed-off-by: Scott Davis --- src/qemu/qemu_driver.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6631edb9d6..d3ba74c14a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@

[libvirt PATCH 2/3] remote: fix null string specifier argument in remoteProbeSessionDriverFromBinary

2022-05-26 Thread Scott Davis
'%s' via daemon %s", drivers[i], daemonpath); | ^~ Signed-off-by: Scott Davis --- src/remote/remote_sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_sockets.c b/src/remote/remote_socket

[PATCH] tests/meson: fix mock library link on MacOS

2020-08-28 Thread Scott Shambarger
MacOS can not pre-load modules, so mock libraries must be built as shared libraries (without asneeded striping, and undefined symbols allowed). Signed-off-by: Scott Shambarger --- tests/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/meson.build b

Re: [PATCH v2] util: use host module suffix when loading drivers

2020-08-26 Thread Scott Shambarger
On 2020-08-26 01:34, Pavel Hrdina wrote: And pushed. Great, I'll update my pull request on Homebrew. Now to see if I can fix all those tests that have been failing on MacOS... S.

[PATCH v2] util: use host module suffix when loading drivers

2020-08-25 Thread Scott Shambarger
Driver module loaders current hardcode ".so" as the file extension. On MacOS, meson uses ".dylib" as a module file extension. This patch adds VIR_FILE_MODULE_EXT to virfile.h defined as the hosts module extension, and updates driver module loaders to make use of it.

Re: [PATCH] src/meson: add module name_suffix as 'so'

2020-08-24 Thread Scott Shambarger
:) Thanks, Scott

Re: [PATCH] src/meson: add module name_suffix as 'so'

2020-08-22 Thread Scott Shambarger
patch that uses the whatever meson does, but I don't think it currently has a specific config for the suffix used for loadable modules (which, on MacOS should really be ".bundle", but is currently ".dylib" - just to be even more confused :). Thoughts? Scott

[PATCH] src/meson: add module name_suffix as 'so'

2020-08-22 Thread Scott Shambarger
support libvirtd). Signed-off-by: Scott Shambarger --- src/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/meson.build b/src/meson.build index 73ac99f01e..73986401c9 100644 --- a/src/meson.build +++ b/src/meson.build @@ -567,6 +567,7 @@ foreach module : virt_modules module['na

libvirt 6.6.0 tarball breaks on Homebrew/MacOS

2020-08-18 Thread Scott Shambarger
ion tarball. Perhaps the tarball could be re-released with autoconf from the official upstream libtool? (2.4.6) Thanks, Scott PS. MacPorts is unaffected as it runs autogen.sh... but that shouldn't be necessary with a distribution tarball :)

[libvirt] [PATCH] virsh emulatorpin, vcpupin: omit offline CPUs from affinity map

2019-07-11 Thread Scott Cheloha
(rhbz#1434276) Signed-off-by: Scott Cheloha --- I'm unsure whether it's better to automatically fall back to the full map if virHostCPUGetOnlineBitmap() fails, or to fail loudly as I do in this patch. Preferences? src/conf/domain_conf.c | 8 src/qemu/qemu_driver.c | 4 2 files

Re: [libvirt] [PATCH 0/7] Keep non-persistent changes alive in snapshot

2018-01-11 Thread Scott Garfinkle
On Mon, 2017-10-30 at 14:21 +0530, Kothapally Madhu Pavan wrote: > Restoring to a snapshot should not overwrite the persistent XML > configuration > of a snapshot as a side effect. This patchset fixes the same. > Currently, > virDomainSnapshotDef only saves active domain definition of the > guest.

Re: [libvirt] [PATCH v2] treat host models as case-insensitive strings

2018-01-11 Thread Scott Garfinkle
On Thu, 2018-01-11 at 11:19 -0500, John Ferlan wrote: > > On 12/26/2017 02:55 PM, Scott Garfinkle wrote: > > Qemu now allows case-insensitive specification of CPU models. This > > fixes the resulting problems on (at least) POWER arch machines. > > Would have been great

[libvirt] [PATCH v2] treat host models as case-insensitive strings

2017-12-26 Thread Scott Garfinkle
(e.g. "Power8" instead of "POWER8"). Signed-off-by: Scott Garfinkle <scott...@linux.vnet.ibm.com> --- src/conf/domain_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c ind

Re: [libvirt] [PATCH] treat host models as case-insensitive strings

2017-12-19 Thread Scott Garfinkle
On Tue, 2017-12-19 at 20:05 +0100, Jiri Denemark wrote: > On Tue, Dec 19, 2017 at 12:39:26 -0600, Scott Garfinkle wrote: > > Qemu now allows case-insensitive specification of CPU models. This fixes the > > resulting problems on POWER arch machines. I believe a similar change

[libvirt] [PATCH] treat host models as case-insensitive strings

2017-12-19 Thread Scott Garfinkle
Qemu now allows case-insensitive specification of CPU models. This fixes the resulting problems on POWER arch machines. I believe a similar change is needed in src/cpu/cpu_x86.c but I don't have a way to test this. Signed-off-by: Scott Garfinkle <scott...@linux.vnet.ibm.com> --- sr

[libvirt] [PATCH v4 4/4] docs: document migrate-getmaxdowntime support

2017-08-17 Thread Scott Garfinkle
--- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 26bd9bd..640e5f5 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,16 @@ + + + qemu: Add migrate-getmaxdowntime command + +

[libvirt] [PATCH v4 2/4] qemu: Implement virDomainMigrateGetMaxDowntime

2017-08-17 Thread Scott Garfinkle
Add code to support querying maximum allowable downtime during live migration. --- src/qemu/qemu_driver.c | 58 src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 4 +++ src/remote/remote_driver.c | 1 +

[libvirt] [PATCH v4 3/4] virsh: Add support for virDomainMigrateGetMaxDowntime

2017-08-17 Thread Scott Garfinkle
Implement a migrate-getmaxdowntime command to complement migrate-setmaxdowntime. --- tools/virsh-domain.c | 42 ++ tools/virsh.pod | 6 ++ 2 files changed, 48 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

[libvirt] [PATCH v4 0/4] Implement migrate-getmaxdowntime command

2017-08-17 Thread Scott Garfinkle
/archives/libvir-list/2017-July/msg01010.html [v3} https://www.redhat.com/archives/libvir-list/2017-July/msg01301.html Scott Garfinkle (4) Add virDomainMigrateGetMaxDowntime public API qemu: Implement virDomainMigrateGetMaxDowntime virsh: Add support for virDomainMigrateGetMaxDowntime

[libvirt] [PATCH v4 1/4] Add virDomainMigrateGetMaxDowntime public API

2017-08-17 Thread Scott Garfinkle
Add virDomainMigrateGetMaxDowntime to support querying maximum allowable downtime during live migration. --- include/libvirt/libvirt-domain.h | 4 src/driver-hypervisor.h | 6 ++ src/libvirt-domain.c | 41

[libvirt] Request for review: [PATCH v3 0/3] implement migrate-getmaxdowntime command

2017-08-08 Thread Scott Garfinkle
I think this may have gotten lost in the 3.6 release. Does someone have the time to review this, please? The patches still apply cleanly (albeit with fuzz) at the current level. -Scott Garfinkle -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir

[libvirt] [PATCH v3 2/3] qemu: Implement virDomainMigrateGetMaxDowntime

2017-07-28 Thread Scott Garfinkle
From: Scott Garfinkle <s...@us.ibm.com> --- src/qemu/qemu_driver.c | 51 src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 4 src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 16 +

[libvirt] [PATCH v3 3/3] virsh: Add support for virDomainMigrateGetMaxDowntime

2017-07-28 Thread Scott Garfinkle
From: Scott Garfinkle <s...@us.ibm.com> --- tools/virsh-domain.c | 46 ++ tools/virsh.pod | 18 ++ 2 files changed, 64 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0684979..10fdd0f

[libvirt] [PATCH v3 0/3] implement migrate-getmaxdowntime command

2017-07-28 Thread Scott Garfinkle
} https://www.redhat.com/archives/libvir-list/2017-July/msg00908.html [v2} https://www.redhat.com/archives/libvir-list/2017-July/msg01010.html Scott Garfinkle (3) Add virDomainMigrateGetMaxDowntime public API qemu: Implement virDomainMigrateGetMaxDowntime virsh: Add support

[libvirt] [PATCH v3 1/3] Add virDomainMigrateGetMaxDowntime public API

2017-07-28 Thread Scott Garfinkle
From: Scott Garfinkle <s...@us.ibm.com> --- include/libvirt/libvirt-domain.h | 4 src/driver-hypervisor.h | 6 ++ src/libvirt-domain.c | 45 src/libvirt_public.syms | 4 4 files changed, 59 inse

[libvirt] [PATCH v2] Generate unique socket file

2017-07-25 Thread Scott Garfinkle
uniqueness in the names we generate internally. Before the changes we'd get /var/lib/libvirt/qemu/channel/target/unknown.sock for each instance of Now, we get vioser-00-00-01.sock, vioser-00-00-02.sock, etc. Changes from v1: new socket name Signed-off-by: Scott Ga

Re: [libvirt] [PATCH] Use unsigned timeout in cmdMigrateSetMaxDowntime

2017-07-19 Thread Scott Garfinkle
John Ferlan <jfer...@redhat.com> wrote on 07/10/2017 06:41:34 AM: > From: John Ferlan <jfer...@redhat.com> > To: Scott Garfinkle <s...@us.ibm.com>, libvir-list@redhat.com > Date: 07/10/2017 06:41 AM > Subject: Re: [libvirt] [PATCH] Use unsigned timeout

[libvirt] [PATCH] Use unsigned timeout in cmdMigrateSetMaxDowntime

2017-06-27 Thread Scott Garfinkle
all have the correct (unsigned) type. Signed-off-by: Scott Garfinkle <s...@us.ibm.com> --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 5311a57..0d21fe7 100644 --- a/tools/virsh-domain.c +++ b

[libvirt] Process to upstream new driver for proprietary hypervisor?

2016-05-19 Thread Scott Bissett
Hello, I am currently implementing a libvirt driver for my company's proprietary custom hypervisor. I have used the VMware driver as a design template, since it is interfacing a closed-source hypervisor as well. Ultimately, as we approach a minimally-usable implementation, we would like to

[libvirt] Sign up for wiki?

2015-11-29 Thread Scott Bronson
Hi, I'd like to update http://wiki.libvirt.org/page/Networking#Forwarding_Incoming_Connections The python script is now a broken link, and there's a better one at https://github.com/saschpe/libvirt-hook-qemu Username of 'bronson' is easiest for me to remember. Thanks! - Scott -- libvir

[libvirt] C# PInvoke Library done, Nuget Package released

2015-05-17 Thread scott lee
Libvirt C# Nuget package released at https://www.nuget.org/packages/Libvirt_Pinvoke/ This will add all necessary dll's and includes a full 1 to 1 mapping of the libvirt API 1.2.13 (http://libvirt.org/html/). All Structures, enums, delegates, and functions are included with the same naming and

[libvirt] Windows Development

2015-05-14 Thread scott lee
the calls/structs and generate the PInvoke calls for everything at once and place it into a .cs file so developers can start dewveloping in libvirt fast and easy. Scott Lee -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Windows Development

2015-05-14 Thread scott lee
I just finished the C# PInvoke portion for the libvirt library. https://github.com/smasherprog/Libvirt_Windows_Dll If you download the repo, and execute the powershell script, all dlls/headers are pulled, and a single C# PInvoke file is generated from the libvirt header files which contains all

Re: [libvirt] Attempting to pivot disk with incomplete mirror results in hang

2015-01-14 Thread Scott Sullivan
On 01/13/2015 11:48 PM, Eric Blake wrote: On 01/13/2015 12:43 PM, Scott Sullivan wrote: I have what appears to be a bug when pivoting a disk during a block copy that is not yet 100% finished, resulting in the pivot command hanging. I have verified this problem on libvirt 1.2.10. I couldn't

Re: [libvirt] Attempting to pivot disk with incomplete mirror results in hang

2015-01-13 Thread Scott Sullivan
On 01/13/2015 02:43 PM, Scott Sullivan wrote: I have what appears to be a bug when pivoting a disk during a block copy that is not yet 100% finished, resulting in the pivot command hanging. I have verified this problem on libvirt 1.2.10. Here's what Im seeing (transient guest): 1.) Start

[libvirt] Attempting to pivot disk with incomplete mirror results in hang

2015-01-13 Thread Scott Sullivan
I have what appears to be a bug when pivoting a disk during a block copy that is not yet 100% finished, resulting in the pivot command hanging. I have verified this problem on libvirt 1.2.10. Here's what Im seeing (transient guest): 1.) Start the block copy: [root@host ~]# virsh blockcopy

Re: [libvirt] Attempting to pivot disk with incomplete mirror results in hang

2015-01-13 Thread Scott Sullivan
On 01/13/2015 03:05 PM, Eric Blake wrote: On 01/13/2015 12:43 PM, Scott Sullivan wrote: I have what appears to be a bug when pivoting a disk during a block copy that is not yet 100% finished, resulting in the pivot command hanging. I have verified this problem on libvirt 1.2.10. Known issue

Re: [libvirt] libnuma build failure [was: securityselinuxlabeltest test fails on v1.2.5]

2014-07-01 Thread Scott Sullivan
On 06/30/2014 05:26 PM, Eric Blake wrote: On 06/30/2014 01:46 PM, Scott Sullivan wrote: I've tested the v1.2.6-rc2 git tag, im getting this build error: CC util/libvirt_util_la-virnuma.lo util/virnuma.c: In function 'virNumaNodeIsAvailable': util/virnuma.c:428: error: 'numa_nodes_ptr

Re: [libvirt] securityselinuxlabeltest test fails on v1.2.5

2014-06-30 Thread Scott Sullivan
On 06/26/2014 05:36 PM, Eric Blake wrote: On 06/26/2014 09:38 AM, Scott Sullivan wrote: On 06/26/2014 10:09 AM, Ján Tomko wrote: On 06/26/2014 03:56 PM, Scott Sullivan wrote: 1) Labelling disks ... internal error: File /home/rpmbuild/packages

Re: [libvirt] securityselinuxlabeltest test fails on v1.2.5

2014-06-26 Thread Scott Sullivan
On 06/25/2014 01:18 PM, Eric Blake wrote: On 06/25/2014 11:08 AM, Scott Sullivan wrote: I am trying to build v1.2.5-maint, however I have one test failing causing the build to fail: TEST: securityselinuxlabeltest !!!. 4 FAIL Can you rerun

Re: [libvirt] securityselinuxlabeltest test fails on v1.2.5

2014-06-26 Thread Scott Sullivan
On 06/26/2014 10:09 AM, Ján Tomko wrote: On 06/26/2014 03:56 PM, Scott Sullivan wrote: 1) Labelling disks ... internal error: File /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.raw context 'EOPNOTSUPP' did not match

[libvirt] securityselinuxlabeltest test fails on v1.2.5

2014-06-25 Thread Scott Sullivan
I am trying to build v1.2.5-maint, however I have one test failing causing the build to fail: TEST: securityselinuxlabeltest !!!. 4 FAIL PASS: virsh-undefine === 1 of 112 tests failed Please report to

Re: [libvirt] [Xen-devel] libvirt, libxl and channels

2014-06-06 Thread Dave Scott
[cc:d Ian Jackson— sorry I should have cc:d you originally!] On 4 Jun 2014, at 10:38, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Jun 04, 2014 at 09:11:59AM +, Dave Scott wrote: Hi, Two of the applications I’d like to use with libvirt (cloudstack and oVirt) make use

[libvirt] libvirt, libxl and channels

2014-06-04 Thread Dave Scott
Hi, Two of the applications I’d like to use with libvirt (cloudstack and oVirt) make use of “channels” in the domain XML, like this: channel type='unix' source mode='bind' path='/var/lib/libvirt/qemu/s-4-VM.agent'/ target type='virtio' name='s-4-VM.vport'/ address type='virtio-serial'/ /channel

Re: [libvirt] [PATCH] is_selinux_enabled returns -1 on error, account for this.

2014-03-20 Thread Scott Sullivan
On 03/20/2014 11:27 AM, Michal Privoznik wrote: On 18.03.2014 18:02, Scott Sullivan wrote: Per the documentation, is_selinux_enabled() returns -1 on error. Account for this. Previously when -1 was being returned the condition would still be true. I was noticing this because on my system

Re: [libvirt] [PATCH] is_selinux_enabled returns -1 on error, account for this.

2014-03-19 Thread Scott Sullivan
On 03/18/2014 01:02 PM, Scott Sullivan wrote: Per the documentation, is_selinux_enabled() returns -1 on error. Account for this. Previously when -1 was being returned the condition would still be true. I was noticing this because on my system that has selinux disabled I was getting

[libvirt] [PATCH] is_selinux_enabled returns -1 on error, account for this.

2014-03-18 Thread Scott Sullivan
. From 23e0780db43ebd3ea90710750639df901c261674 Mon Sep 17 00:00:00 2001 From: Scott Sullivan ssulli...@liquidweb.com Date: Tue, 18 Mar 2014 12:55:50 -0400 Subject: [PATCH] is_selinux_enabled returns -1 on error, account for this. --- src/security/security_selinux.c |2 +- src/util/viridentity.c

Re: [libvirt] 1.2.0 segfault on Centos 6

2014-02-20 Thread Scott Sullivan
On 02/04/2014 05:23 PM, Jiri Denemark wrote: On Tue, Feb 04, 2014 at 17:02:41 +0100, Franky Van Liedekerke wrote: Hi, using libvirt 1.2.0 on a up-to-date Centos6.5 machine leads to occasional segmentation faults (see below). Sometimes it runs for 5 minutes, sometimes for an hour, but after

[libvirt] virsh [attach-detach]-device question

2013-08-06 Thread Scott Sullivan
I have noticed a behavior I am hoping someone can help me understand. Consider the following scenario: 1.) Start a test dummy qemu-kvm instance with no OS via virsh named no_os. 2.) Attach a device to it; [root@host ~]# virsh attach-device no_os /root/hotplug_device_b.xml Device attached

Re: [libvirt] virsh [attach-detach]-device question

2013-08-06 Thread Scott Sullivan
On 08/06/2013 08:54 AM, Scott Sullivan wrote: I have noticed a behavior I am hoping someone can help me understand. Consider the following scenario: 1.) Start a test dummy qemu-kvm instance with no OS via virsh named no_os. 2.) Attach a device to it; [root@host ~]# virsh attach-device no_os

Re: [libvirt] [ocaml] event registration APis v3

2013-05-08 Thread David Scott
Hi, On 8 May 2013, at 12:32, Richard W.M. Jones rjo...@redhat.com wrote: On Wed, Apr 24, 2013 at 11:39:02AM +0100, David Scott wrote: Hi, Here are my latest patches which add OCaml bindings for the libvirt event API. I'm pretty happy with them now: my test programs have been running

Re: [libvirt] [PATCH 2/2] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread David Scott
Jim, Daniel, thanks for all the feedback! On 29/04/13 20:02, Jim Fehlig wrote: [ snip ] As mentioned in my other response [1], your original patch (with a check to verify the requested emulator exists) should be sufficient. OK, I'll send an emulator-only patch shortly. Cheers, Dave --

[libvirt] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread David Scott
of the old qemu during development, you will have to ensure the wrapper script also has the name qemu-dm, by placing it in a separate directory. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- src/libxl/libxl_conf.c | 44 1 files changed, 44

Re: [libvirt] [PATCH] libxl: allow an emulator to be selected in the domain config XML

2013-04-30 Thread David Scott
Hi, [added xen-devel: FYI this is about how to properly set the libxl device_model_version when the user has provided a manual device_model override (aka a path to a qemu) in the libvirt domain XML.] On 30/04/13 16:10, Jim Fehlig wrote: David Scott wrote: The emulator path supplied can

Re: [libvirt] [Xen-devel] libvirt, libxl and QDISKs

2013-04-29 Thread David Scott
Hi Jim, Thanks for the explanation about the capabilities. On 27/04/13 00:44, Jim Fehlig wrote: Do you have time for an upstream libvirt patch to expose the possible emulators in the capabilities, along with this patch allowing the user to specify one? I'll have a go and send you (cc'ing the

[libvirt] libxl: expose and control xen device model versions

2013-04-29 Thread David Scott
Hi, These patches expose multiple xen device model options in the capabilities XML and allow the user to select a specific device model via the domain XML's emulator tag. It is important to control the device model per VM, since the default is changing from xen-4.2 qemu traditional to xen-4.3

[libvirt] [PATCH 1/2] libxl: expose multiple emulators per guest in the capabilities XML

2013-04-29 Thread David Scott
for the emulators at runtime and expose them as separate domains within the same guest architecture. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- src/libxl/libxl_conf.c | 87 --- 1 files changed, 66 insertions(+), 21 deletions(-) diff --git a/src

[libvirt] [PATCH 2/2] libxl: allow an emulator to be selected in the domain config XML

2013-04-29 Thread David Scott
We cross-check the given path against the capabilties, and translate it into a libxl_device_model_version. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- src/libxl/libxl_conf.c | 41 + 1 files changed, 41 insertions(+), 0 deletions(-) diff

[libvirt] [ocaml PATCH 4/4] Add a simple example to show how to receive event callbacks

2013-04-24 Thread David Scott
Signed-off-by: David Scott dave.sc...@eu.citrix.com --- .gitignore| 1 + Makefile.in | 1 + examples/Makefile.in | 13 - examples/domain_events.ml | 145 ++ 4 files changed, 159 insertions(+), 1 deletion

[libvirt] [ocaml] event registration APis v3

2013-04-24 Thread David Scott
Hi, Here are my latest patches which add OCaml bindings for the libvirt event API. I'm pretty happy with them now: my test programs have been running for long periods of time without incident. Changes from the previous submission (sent 2013-04-17) * added a patch which removes the backwards

[libvirt] [ocaml PATCH 2/4] Add binding for virConnectSetKeepAlive

2013-04-24 Thread David Scott
This one is a 'one-off' but it ought to be possible to use the generator to create the function (it has signature 'conn, int, int : int') This function first appeared in libvirt version 0.9.8. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- libvirt/libvirt.ml | 2 ++ libvirt

[libvirt] [ocaml PATCH 3/4] Add event callback implementation based on virConnectDomainEventRegisterAny

2013-04-24 Thread David Scott
. The OCaml function can then find the right callback in the Hashtbl and call it. The client can deregister the callback with: E.deregister_any conn id; Signed-off-by: David Scott dave.sc...@eu.citrix.com --- libvirt/generator.pl| 2 + libvirt/libvirt.ml | 765

Re: [libvirt] [PATCH 2/3][ocaml] Add event callback implementation based on virConnectDomainEventRegisterAny

2013-04-18 Thread David Scott
i.e. all of these: On Wed, Apr 17, 2013 at 11:16 AM, David Scott scott...@gmail.com wrote: [snip] + case VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON: +cb = VIR_DOMAIN_EVENT_CALLBACK(s_s_i_s_callback); +break; + case VIR_DOMAIN_EVENT_ID_CONTROL_ERROR: +cb = VIR_DOMAIN_EVENT_CALLBACK

[libvirt] (no subject)

2013-04-17 Thread David Scott
Hi, I've made an improved set of ocaml bindings for the libvirt event mechanism which I'm now reasonably happy with. Improvements since my first submission: 1. it's possible to deregister callbacks with 'deregister_any' 2. the callback to ocaml now re-acquires the heap lock *before* creating

[libvirt] [PATCH 1/3] Add binding for virConnectSetKeepAlive

2013-04-17 Thread David Scott
This one is a 'one-off' but it ought to be possible to use the generator to create the function (it has signature 'conn, int, int : int') This function first appeared in libvirt version 0.9.8. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- config.h.in | 3

[libvirt] [PATCH 3/3] Add a simple example to show how to receive event callbacks

2013-04-17 Thread David Scott
Signed-off-by: David Scott dave.sc...@eu.citrix.com --- .gitignore| 1 + Makefile.in | 1 + examples/.depend | 14 +++-- examples/Makefile.in | 13 - examples/domain_events.ml | 145 ++ 5 files

[libvirt] [PATCH 2/3] Add event callback implementation based on virConnectDomainEventRegisterAny

2013-04-17 Thread David Scott
{Register,Deregister}Any virEventRegisterDefaultImpl virEventRunDefaultImpl were present in libvirt 0.9.1 so we always assume the symbols are present. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- config.h.in | 6 + configure.ac| 2 + libvirt

[libvirt] [PATCH] Fix typo in ocaml_libvirt_storage_vol_get_info

2013-04-17 Thread David Scott
The info.capacity was being overwritten with the info.allocation. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- libvirt/libvirt_c_oneoffs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt/libvirt_c_oneoffs.c b/libvirt/libvirt_c_oneoffs.c index 80e1c03

[libvirt] [PATCH 1/3] Add binding for virConnectSetKeepAlive

2013-03-27 Thread David Scott
This one is a 'one-off' but it ought to be possible to use the generator to create the function (it has signature 'conn, int, int : int') Signed-off-by: David Scott dave.sc...@eu.citrix.com --- config.h.in |3 +++ configure.ac|1 + libvirt/.depend

[libvirt] ocaml: prototype bindings for event callbacks

2013-03-27 Thread David Scott
Hi, I've made an prototype set of ocaml bindings for the libvirt event mechanism -- here is what I've got so far. It's possible to register for all the types supported by virConnectDomainEventRegisterAny I've not tested each type of event yet, but the basics are all working. For every

[libvirt] [PATCH 3/3] Add a simple example to show how to receive event callbacks

2013-03-27 Thread David Scott
Signed-off-by: David Scott dave.sc...@eu.citrix.com --- .gitignore|1 + Makefile.in |1 + examples/.depend | 14 ++--- examples/Makefile.in | 13 - examples/domain_events.ml | 124 + 5 files

[libvirt] [PATCH 2/3] Add event callback implementation based on virConnectDomainEventRegisterAny

2013-03-27 Thread David Scott
function can then find the right callback in the Hashtbl and call it. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- config.h.in |9 + configure.ac|3 + libvirt/libvirt.ml | 714 +++ libvirt/libvirt.mli

[libvirt] [PATCH 3/3] Functions returning unit correspond to C fns which use -1 for failure

2013-03-06 Thread David Scott
This affects the following functions: virStoragePoolBuild virStoragePoolDelete virStorageVolDelete Previously a call to virStorageVolDelete would succeed returning 0, which was interpreted as false, causing us to raise an exception with VIR_ERR_NONE. Signed-off-by: David Scott dave.sc

[libvirt] [PATCH 1/3] Correct typos in the storage interface's phantom types

2013-03-06 Thread David Scott
: Pool.set_autostart Volume.create_xml Volume.delete Signed-off-by: David Scott dave.sc...@eu.citrix.com --- libvirt/libvirt.ml |6 +++--- libvirt/libvirt.mli |6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libvirt/libvirt.ml b/libvirt/libvirt.ml index 07542a9..443b22b

[libvirt] [PATCH 2/3] Volume.delete takes a flags parameter

2013-03-06 Thread David Scott
This corrects a mismatch between the generated C stubs and the .ml interface. Signed-off-by: David Scott dave.sc...@eu.citrix.com --- libvirt/libvirt.ml |2 +- libvirt/libvirt.mli |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt/libvirt.ml b/libvirt

[libvirt] Minor fixes to ocaml bindings for storage pools/volumes

2013-03-06 Thread David Scott
) is here: https://github.com/djs55/xcp-libvirt-storage/blob/master/server.ml Cheers, Dave Scott http://dave.recoil.org/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Minor fixes to ocaml bindings for storage pools/volumes

2013-03-06 Thread David Scott
On Wed, Mar 6, 2013 at 5:01 PM, Richard W.M. Jones rjo...@redhat.comwrote: On Wed, Mar 06, 2013 at 04:18:02PM +, David Scott wrote: These patches fix a couple of minor issues I encountered while trying to manipulate storage pools and volumes from an OCaml program. If you're

[libvirt] Thoughts on adding a domain type of jvm

2013-02-08 Thread Scott Stark
I'm working with a java vm vendor that is developing a multi-tenancy jvm and is trying to leverage the libvirt framework for the domain configuration. Right now the java language binding leverages the libvirt c library for parsing the domain.xml file. What are the thoughts on adding a 'jvm'

Re: [libvirt] Thoughts on adding a domain type of jvm

2013-02-08 Thread Scott Stark
- Original Message - From: Eric Blake ebl...@redhat.com To: Scott Stark sst...@redhat.com Cc: libvir-list@redhat.com Sent: Friday, February 8, 2013 12:21:17 PM Subject: Re: [libvirt] Thoughts on adding a domain type of jvm On 02/08/2013 12:20 PM, Scott Stark wrote: [any way you can

Re: [libvirt] virsh nodeinfo CPU detection questions

2013-01-30 Thread Scott Sullivan
On 01/29/2013 02:55 PM, Doug Goldstein wrote: On Tue, Jan 29, 2013 at 9:52 AM, Scott Sullivanssulli...@liquidweb.com wrote: I have a machine with four AMD Opteron(TM) 6272 processors: http://www.amd.com/us/products/server/processors/6000-series-platform/6200/Pages/6200-series

[libvirt] virsh nodeinfo CPU detection questions

2013-01-29 Thread Scott Sullivan
I have a machine with four AMD Opteron(TM) 6272 processors: http://www.amd.com/us/products/server/processors/6000-series-platform/6200/Pages/6200-series-processors.aspx#5 I use 'virsh nodeinfo' to determine the amount of physical CPUs, and CPU cores. What values should I be looking at in the

Re: [libvirt] libvirtd segfault

2013-01-03 Thread Scott Sullivan
On 01/02/2013 09:45 AM, Scott Sullivan wrote: On 12/29/2012 04:09 AM, Michal Privoznik wrote: On 28.12.2012 20:23, Scott Sullivan wrote: snip/ I have just now received another SIGSEGV, with your patch applied. Here's the info from the GDB session: Detaching after fork from child process

Re: [libvirt] libvirtd segfault

2013-01-02 Thread Scott Sullivan
On 12/29/2012 04:09 AM, Michal Privoznik wrote: On 28.12.2012 20:23, Scott Sullivan wrote: snip/ I have just now received another SIGSEGV, with your patch applied. Here's the info from the GDB session: Detaching after fork from child process 11266. 2012-12-28 18:56:53.261+: 29943

Re: [libvirt] libvirtd segfault

2012-12-28 Thread Scott Sullivan
0x003009ae570d in clone () from /lib64/libc.so.6 (gdb) On 12/27/2012 01:15 PM, Scott Sullivan wrote: ### Libvirt version: ### libvirt tagged v1.0.0 from git , with f0e72b2f5c675f927d04545dc5095f9e5998f171 applied ### Problem: ### Libvirtd segfaults ### Steps to reproduce

Re: [libvirt] libvirtd segfault

2012-12-28 Thread Scott Sullivan
On 12/28/2012 10:50 AM, Michal Privoznik wrote: On 28.12.2012 14:24, Scott Sullivan wrote: In case its useful, here's the 'bt' output from this session as well: (gdb) bt #0 qemuDomainObjBeginJobInternal (driver=0x7fffe401d740, driver_locked=true, obj=0x7fff80001b00, job=QEMU_JOB_DESTROY

Re: [libvirt] libvirtd segfault

2012-12-28 Thread Scott Sullivan
On 12/28/2012 01:31 PM, Scott Sullivan wrote: On 12/28/2012 10:50 AM, Michal Privoznik wrote: On 28.12.2012 14:24, Scott Sullivan wrote: In case its useful, here's the 'bt' output from this session as well: (gdb) bt #0 qemuDomainObjBeginJobInternal (driver=0x7fffe401d740, driver_locked=true

[libvirt] libvirtd segfault

2012-12-27 Thread Scott Sullivan
### Libvirt version: ### libvirt tagged v1.0.0 from git , with f0e72b2f5c675f927d04545dc5095f9e5998f171 applied ### Problem: ### Libvirtd segfaults ### Steps to reproduce: ### This is difficult to reproduce; but appears to happen only when doing 'virsh destroys', and when they are ran in

[libvirt] libvirt RBD attach regression?

2012-11-21 Thread Scott Sullivan
be of any further assistance with this, let me know. Thanks, Scott Sullivan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] libvirt RBD attach regression?

2012-11-21 Thread Scott Sullivan
Hello, We were able to come up with this patch, which does fix the problem in our use case: http://pastebin.com/izx40mRd Interested to hear any feedback on the patch. On 11/21/2012 12:13 PM, Eric Blake wrote: On 11/21/2012 09:45 AM, Scott Sullivan wrote: Hello, I have been testing

[libvirt] libvirt Application Development Guide - revival

2012-06-06 Thread Scott Radvan
-Libvirt_Application_Development_Guide (under the Red Hat Enterprise Linux 6 product). Thanks for your help, [1] http://libvirt.org/devguide.html -- Scott Radvan Content Author II Platform (Virtualization) Red Hat APAC -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] sr-iov ethernet VF is not assigned correctly to guest

2012-03-26 Thread Scott
Hi, I'm hoping someone could possibly show me what I may be doing wrong here, and why I'm not seeing the expected results Thanks in advance! Server Information:HP Product Name: ProLiant DL165 G7 Ethernet Card Information: Intel 82599EB 10-Gigabit SFI/SFP+ uname: Linux 3.0.0-16-server x86_64

Re: [libvirt] sr-iov ethernet VF is not assigned correctly to guest

2012-03-26 Thread Scott
On Mar 26, 2012, at 11:20 AM, Daniel P. Berrange wrote: On Mon, Mar 26, 2012 at 11:12:56AM -0400, Scott wrote: Hi, I'm hoping someone could possibly show me what I may be doing wrong here, and why I'm not seeing the expected results Thanks in advance! Server Information:HP Product

[libvirt] [PATCH] lxc: do not require 'ifconfig' or 'ipconfig' in container

2011-08-23 Thread Scott Moser
Currently, the lxc implementation invokes 'ip' and 'ifconfig' commands inside a container using 'virRun'. That has the side effect of requiring those commands to be present and to function in a manner consistent with the usage. Some small roots (such as ttylinux) may not have 'ip' or 'ifconfig'.

[libvirt] [PATCH] fix virParseVersionString with linux 3.0

2011-07-01 Thread Scott Moser
linux 3.0 has no micro version number, and that is causing problems for virParseVersionString. The patch below should allow for: major major.minor major.minor.micro If major or minor are not present they just default to zero. We found this in Ubuntu (https://bugs.launchpad.net/bugs/802977)

Re: [libvirt] Problem with libvirt on Fedora 14 with virt-preview repo

2011-05-03 Thread Scott Dowdle
undesired effects that will have on your system's operation. I'm not using TLS and uncommenting out the listen_tls=0 parameter fixed it for me. It does appear the default has changed to 1. TYL, -- Scott Dowdle 704 Church Street Belgrade, MT 59714 (406)388-0827 [home] (406)994-3931 [work] -- libvir

Re: [libvirt] [libvirt-users] Anyone interested in forming a libvirt docs team?

2010-12-22 Thread Scott Baker
On 12/21/2010 03:15 AM, Anthony Davis wrote: Hi Justin, I can offer some free time:) I'd be willing to contribute to a wiki if we had the docs in a wiki. -- Scott Baker - Canby Telcom System Administrator - RHCE - 503.266.8253 -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH] [PATCH v13-pre1] add 802.1Qbh and 802.1Qbg handling

2010-05-29 Thread Scott Feldman
From: Scott Feldman scofe...@cisco.com Stefan, I was doing more testing and have some fixes for the bh paths. This patch is on top of your V12 patch... - some minor cleanups - if association fails due to timeout, disassociate the port profile, otherwise association state-machine

Re: [libvirt] [PATCH v9] add 802.1Qbh and 802.1Qbg handling

2010-05-26 Thread Scott Feldman
.bh with v9 now...no regressions so far... -scott -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

  1   2   >