Re: [libvirt] [PATCH 0/7] Keep non-persistent changes alive in snapshot

2018-01-11 Thread Scott Garfinkle
On Mon, 2017-10-30 at 14:21 +0530, Kothapally Madhu Pavan wrote: > Restoring to a snapshot should not overwrite the persistent XML > configuration > of a snapshot as a side effect. This patchset fixes the same. > Currently, > virDomainSnapshotDef only saves active domain definition of the > guest.

Re: [libvirt] [PATCH v2] treat host models as case-insensitive strings

2018-01-11 Thread Scott Garfinkle
On Thu, 2018-01-11 at 11:19 -0500, John Ferlan wrote: > > On 12/26/2017 02:55 PM, Scott Garfinkle wrote: > > Qemu now allows case-insensitive specification of CPU models. This > > fixes the resulting problems on (at least) POWER arch machines. > > Would have been great

[libvirt] [PATCH v2] treat host models as case-insensitive strings

2017-12-26 Thread Scott Garfinkle
(e.g. "Power8" instead of "POWER8"). Signed-off-by: Scott Garfinkle <scott...@linux.vnet.ibm.com> --- src/conf/domain_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c ind

Re: [libvirt] [PATCH] treat host models as case-insensitive strings

2017-12-19 Thread Scott Garfinkle
On Tue, 2017-12-19 at 20:05 +0100, Jiri Denemark wrote: > On Tue, Dec 19, 2017 at 12:39:26 -0600, Scott Garfinkle wrote: > > Qemu now allows case-insensitive specification of CPU models. This fixes the > > resulting problems on POWER arch machines. I believe a similar change

[libvirt] [PATCH] treat host models as case-insensitive strings

2017-12-19 Thread Scott Garfinkle
Qemu now allows case-insensitive specification of CPU models. This fixes the resulting problems on POWER arch machines. I believe a similar change is needed in src/cpu/cpu_x86.c but I don't have a way to test this. Signed-off-by: Scott Garfinkle <scott...@linux.vnet.ibm.com> --- sr

[libvirt] [PATCH v4 4/4] docs: document migrate-getmaxdowntime support

2017-08-17 Thread Scott Garfinkle
--- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 26bd9bd..640e5f5 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,16 @@ + + + qemu: Add migrate-getmaxdowntime command + +

[libvirt] [PATCH v4 2/4] qemu: Implement virDomainMigrateGetMaxDowntime

2017-08-17 Thread Scott Garfinkle
Add code to support querying maximum allowable downtime during live migration. --- src/qemu/qemu_driver.c | 58 src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 4 +++ src/remote/remote_driver.c | 1 +

[libvirt] [PATCH v4 3/4] virsh: Add support for virDomainMigrateGetMaxDowntime

2017-08-17 Thread Scott Garfinkle
Implement a migrate-getmaxdowntime command to complement migrate-setmaxdowntime. --- tools/virsh-domain.c | 42 ++ tools/virsh.pod | 6 ++ 2 files changed, 48 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

[libvirt] [PATCH v4 0/4] Implement migrate-getmaxdowntime command

2017-08-17 Thread Scott Garfinkle
/archives/libvir-list/2017-July/msg01010.html [v3} https://www.redhat.com/archives/libvir-list/2017-July/msg01301.html Scott Garfinkle (4) Add virDomainMigrateGetMaxDowntime public API qemu: Implement virDomainMigrateGetMaxDowntime virsh: Add support for virDomainMigrateGetMaxDowntime

[libvirt] [PATCH v4 1/4] Add virDomainMigrateGetMaxDowntime public API

2017-08-17 Thread Scott Garfinkle
Add virDomainMigrateGetMaxDowntime to support querying maximum allowable downtime during live migration. --- include/libvirt/libvirt-domain.h | 4 src/driver-hypervisor.h | 6 ++ src/libvirt-domain.c | 41

[libvirt] Request for review: [PATCH v3 0/3] implement migrate-getmaxdowntime command

2017-08-08 Thread Scott Garfinkle
I think this may have gotten lost in the 3.6 release. Does someone have the time to review this, please? The patches still apply cleanly (albeit with fuzz) at the current level. -Scott Garfinkle -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir

[libvirt] [PATCH v3 2/3] qemu: Implement virDomainMigrateGetMaxDowntime

2017-07-28 Thread Scott Garfinkle
From: Scott Garfinkle <s...@us.ibm.com> --- src/qemu/qemu_driver.c | 51 src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 4 src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 16 +

[libvirt] [PATCH v3 3/3] virsh: Add support for virDomainMigrateGetMaxDowntime

2017-07-28 Thread Scott Garfinkle
From: Scott Garfinkle <s...@us.ibm.com> --- tools/virsh-domain.c | 46 ++ tools/virsh.pod | 18 ++ 2 files changed, 64 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0684979..10fdd0f

[libvirt] [PATCH v3 0/3] implement migrate-getmaxdowntime command

2017-07-28 Thread Scott Garfinkle
} https://www.redhat.com/archives/libvir-list/2017-July/msg00908.html [v2} https://www.redhat.com/archives/libvir-list/2017-July/msg01010.html Scott Garfinkle (3) Add virDomainMigrateGetMaxDowntime public API qemu: Implement virDomainMigrateGetMaxDowntime virsh: Add support

[libvirt] [PATCH v3 1/3] Add virDomainMigrateGetMaxDowntime public API

2017-07-28 Thread Scott Garfinkle
From: Scott Garfinkle <s...@us.ibm.com> --- include/libvirt/libvirt-domain.h | 4 src/driver-hypervisor.h | 6 ++ src/libvirt-domain.c | 45 src/libvirt_public.syms | 4 4 files changed, 59 inse

[libvirt] [PATCH v2] Generate unique socket file

2017-07-25 Thread Scott Garfinkle
uniqueness in the names we generate internally. Before the changes we'd get /var/lib/libvirt/qemu/channel/target/unknown.sock for each instance of Now, we get vioser-00-00-01.sock, vioser-00-00-02.sock, etc. Changes from v1: new socket name Signed-off-by: Scott Ga

Re: [libvirt] [PATCH] Use unsigned timeout in cmdMigrateSetMaxDowntime

2017-07-19 Thread Scott Garfinkle
John Ferlan <jfer...@redhat.com> wrote on 07/10/2017 06:41:34 AM: > From: John Ferlan <jfer...@redhat.com> > To: Scott Garfinkle <s...@us.ibm.com>, libvir-list@redhat.com > Date: 07/10/2017 06:41 AM > Subject: Re: [libvirt] [PATCH] Use unsigned timeout

[libvirt] [PATCH] Use unsigned timeout in cmdMigrateSetMaxDowntime

2017-06-27 Thread Scott Garfinkle
all have the correct (unsigned) type. Signed-off-by: Scott Garfinkle <s...@us.ibm.com> --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 5311a57..0d21fe7 100644 --- a/tools/virsh-domain.c +++ b