Re: [libvirt] [PATCH] util: generate correct macvtap name

2016-03-29 Thread Shanzhi Yu
On 03/29/2016 12:23 AM, Laine Stump wrote: On 03/28/2016 10:42 AM, Laine Stump wrote: On 03/28/2016 06:43 AM, Shanzhi Yu wrote: in commit 370608b, bitmap of in-used macvtap devices was introduced. if there is already macvtap device created not by libvirt

[libvirt] [PATCH] util: generate correct macvtap name

2016-03-28 Thread Shanzhi Yu
=1321546 Signed-off-by: Shanzhi Yu <s...@redhat.com> --- src/util/virnetdevmacvlan.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index 2409113..973363e 100644 --- a/src/util/virnetdevmacvlan.c +++

[libvirt] [PATCH] rbd: use unsigned long long instead of uint64_t

2016-03-28 Thread Shanzhi Yu
bytes allocated for RBD image %s", Signed-off-by: Shanzhi Yu <s...@redhat.com> --- src/storage/storage_backend_rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index c9b47e2..dec0905 100644 -

[libvirt] [PATCH] qemu: improve the error when try to undefine transient network

2016-03-06 Thread Shanzhi Yu
Signed-off-by: Shanzhi Yu <s...@redhat.com> --- src/network/bridge_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 7ab9e29..b62fdff 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_dr

[libvirt] [PATCH] qemu: forbid renaming domain which has managedsave file

2016-03-03 Thread Shanzhi Yu
after rename a domain which has managedsave file, the new name domain can't boot up from the state it saved, and the managedsave file will exist with the original name. Signed-off-by: Shanzhi Yu <s...@redhat.com> --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff

[libvirt] [PATCH] qemu: enalbe hotplugging of macvtap device with multiqueue

2016-02-25 Thread Shanzhi Yu
in commit 81a110, multiqueue for macvtap is enabled but forget to support hotplugging enabled Signed-off-by: Shanzhi Yu <s...@redhat.com> --- src/qemu/qemu_hotplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c

[libvirt] [PATCH v2] security_selinux: Fix crash in virSecuritySELinuxRestoreFileLabel

2016-01-21 Thread Shanzhi Yu
virSecuritySELinuxRestoreFileLabel should never be called with NULL path add check before call this function in case of causeing libvirtd crash https://bugzilla.redhat.com/show_bug.cgi?id=1300532 Signed-off-by: Shanzhi Yu <s...@redhat.com> --- src/security/security_selinux.

[libvirt] [PATCH] security_selinux: Fix crash in virSecuritySELinuxRestoreFileLabel

2016-01-21 Thread Shanzhi Yu
when failed to boot a guest, virSecuritySELinuxRestoreFileLabel will be called eventually to reset security label, which will lead a crash if pass null to virFileResolveLink(path, ). https://bugzilla.redhat.com/show_bug.cgi?id=1300532 Signed-off-by: Shanzhi Yu <s...@redhat.com> --- src/se

[libvirt] [libvirt-test-API] [PATCH] Add test cases for API defineXMLFlags

2015-09-28 Thread Shanzhi Yu
Signed-off-by: Shanzhi Yu <s...@redhat.com> --- cases/linux_domain.conf | 22 + repos/domain/definewithflags.py | 104 2 files changed, 126 insertions(+) create mode 100644 repos/domain/definewithflags.py diff --git a

[libvirt] [libvirt-test-API] [PATCH] fix some typo

2015-09-28 Thread Shanzhi Yu
Signed-off-by: Shanzhi Yu <s...@redhat.com> --- repos/domain/fsinfo.py | 2 +- repos/domain/install_linux_check.py | 2 +- repos/domain/install_linux_net.py | 2 +- repos/interface/define.py | 2 +- repos/interface/undefine.py | 4 ++-- 5 files chan

[libvirt] [libvirt-test-API] [PATCH] Add two cases for API interfaceAddresses and make small changes to global.cfg

2015-09-28 Thread Shanzhi Yu
Signed-off-by: Shanzhi Yu <s...@redhat.com> --- cases/linux_domain.conf| 12 +++ global.cfg | 8 +++-- repos/domain/get_guest_network_info.py | 66 ++ 3 files changed, 84 insertions(+), 2 deletions(-) creat

[libvirt] [libvirt-test-API] [PATCH] fix two error in script pin_iothread.py and connection_getAllDomainStats.py

2015-09-28 Thread Shanzhi Yu
Signed-off-by: Shanzhi Yu <s...@redhat.com> --- repos/domain/pin_iothread.py | 2 +- repos/virconn/connection_getAllDomainStats.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/repos/domain/pin_iothread.py b/repos/domain/pin_iothread.py index 2

[libvirt] [libvirt-test-API] [PATCH] change some cases order in conf file linux_domain.conf

2015-09-28 Thread Shanzhi Yu
Some cases need guest agent running in domain, change some cases order to avoid the failure. Signed-off-by: Shanzhi Yu <s...@redhat.com> --- cases/linux_domain.conf | 100 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a

Re: [libvirt] [PATCH] qemu: blockcopy: Forbid using persistent bitmap granularity with raw vols

2015-06-24 Thread Shanzhi Yu
On 06/24/2015 03:11 PM, Peter Krempa wrote: qemu returns error but only in the event after the block job actually starts. Reject it upfront for a better error message. Instead of: $ virsh blockcopy vm hdc /tmp/raw.img --granularity 4096 --verbose --wait error: Block Copy unexpectedly

Re: [libvirt] [PATCH] qemu: blockcopy: Forbid using persistent bitmap granularity with raw vols

2015-06-24 Thread Shanzhi Yu
On 06/24/2015 05:33 PM, Peter Krempa wrote: On Wed, Jun 24, 2015 at 16:48:16 +0800, Shanzhi Yu wrote: On 06/24/2015 03:11 PM, Peter Krempa wrote: qemu returns error but only in the event after the block job actually starts. Reject it upfront for a better error message. Instead

[libvirt] [PATCH] qemu: add value range check of option granularity

2015-06-16 Thread Shanzhi Yu
command 'drive-mirror': Parameter 'granularity' expects a value in range [512B, 64MB] Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_driver.c | 4 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d1f195c..0eca8ed 100644

[libvirt] [PATCH] tools: fix the output of blockjob

2015-05-10 Thread Shanzhi Yu
There will be no output when use blockjob with --raw option if guest has no block job. A explicit message should be given just like with --info Signed-off-by: Shanzhi Yu s...@redhat.com --- tools/virsh-domain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh

Re: [libvirt] [PATCH] qemu: Fix the crash in qemuDomainBlockCopyCommon

2015-04-27 Thread Shanzhi Yu
On 04/27/2015 05:57 PM, Peter Krempa wrote: On Mon, Apr 27, 2015 at 15:38:57 +0800, Shanzhi Yu wrote: The crash caused when checking the backing file path of a disk while the disk has no backing file, add a check before using disk-src-backingStore-path Resolves: https

[libvirt] [PATCH] qemu: Fix the crash in qemuDomainBlockCopyCommon

2015-04-27 Thread Shanzhi Yu
The crash caused when checking the backing file path of a disk while the disk has no backing file, add a check before using disk-src-backingStore-path Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1215569 --- src/qemu/qemu_driver.c | 9 + 1 file changed, 9 insertions(+) diff

Re: [libvirt] [PATCH] qemu: blockCopy: Allow shallow block copy into a raw image

2015-04-27 Thread Shanzhi Yu
On 04/27/2015 08:01 PM, Peter Krempa wrote: The documentation states that for shallow block copy the image has to have the same guest visible content as backing file of the current image. This condition can be achieved also with a raw file (or a qcow without a backing file) so remove the

Re: [libvirt] [PATCH] qemu: blockCopy: Allow shallow block copy into a raw image

2015-04-27 Thread Shanzhi Yu
On 04/27/2015 11:38 PM, Peter Krempa wrote: On Mon, Apr 27, 2015 at 22:11:40 +0800, Shanzhi Yu wrote: On 04/27/2015 08:01 PM, Peter Krempa wrote: The documentation states that for shallow block copy the image has to have the same guest visible content as backing file of the current image

[libvirt] [PATCH] qemu: save domain status after set memory parameters

2015-04-14 Thread Shanzhi Yu
After set memory parameters for running domain, save the change to live xml is needed otherwise it will disappear after restart libvirtd. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1211548 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3

[libvirt] [PATCH] tools: improve the error info when fail to parse parameter --soft-limit of memtune

2015-04-14 Thread Shanzhi Yu
-limit Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1211550 Signed-off-by: Shanzhi Yu s...@redhat.com --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 3e2c420..ebdf398 100644 --- a/tools/virsh

Re: [libvirt] [PATCH] qemu: save domain status after set memory parameters

2015-04-14 Thread Shanzhi Yu
On 04/14/2015 07:54 PM, Ján Tomko wrote: On Tue, Apr 14, 2015 at 06:24:41PM +0800, Shanzhi Yu wrote: After set memory parameters for running domain, save the change to live xml is needed otherwise it will disappear after restart libvirtd. Resolves: https://bugzilla.redhat.com/show_bug.cgi

[libvirt] [RFC] How to build libvirt package with git commit info from libvirt.git

2015-03-31 Thread Shanzhi Yu
Hello there, Currently I am searching a way to build a libvirt package from latest libvirt.git with package name including git commit info. Like # cd libvirt git describe v1.2.14-rc1-16-g0c4474d then I want to build a libvirt package with name like

[libvirt] [PATCH] qemu: end the job when try to blockcopy to non-file destination

2015-03-27 Thread Shanzhi Yu
Blockcopy to non-file destination is not supported according the code while a 'goto endjob' is missed after check the destination which lead qemu try to do drive-mirror. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1206406 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu

Re: [libvirt] [PATCH] conf: refact virDomainHasDiskMirror and rename it to virDomainHasBlockjob

2015-03-26 Thread Shanzhi Yu
- Original Message - | From: Peter Krempa pkre...@redhat.com | To: Shanzhi Yu s...@redhat.com | Cc: libvir-list@redhat.com | Sent: Wednesday, March 25, 2015 11:24:21 PM | Subject: Re: [libvirt] [PATCH] conf: refact virDomainHasDiskMirror and rename | it to virDomainHasBlockjob | On Tue

[libvirt] [PATCH] conf: refact virDomainHasDiskMirror and rename it to virDomainHasBlockjob

2015-03-24 Thread Shanzhi Yu
: stream, and migration will succeed which will lead the blockpull job failed. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1203628 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/conf/domain_conf.c| 6 +++--- src/conf/domain_conf.h| 2 +- src/libvirt_private.syms | 2 +- src

Re: [libvirt] Domain XML isn't dumping full backing chain

2015-03-18 Thread Shanzhi Yu
- Original Message - | From: Deepak Shetty dpkshe...@gmail.com | To: libvir-list@redhat.com | Sent: Wednesday, March 18, 2015 7:19:05 PM | Subject: [libvirt] Domain XML isn't dumping full backing chain | Hi, | I am using libvirt version 1.2.9.2 on F21 and i am unable to get the complete

Re: [libvirt] [PATCH v2] qemu: read backing chain names from qemu

2015-03-12 Thread Shanzhi Yu
I do meet libvirtd crash sometime when test this patch(I also met it when test v1 yesterday, but can not reproduce it 100%.) Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffe9d39700 (LWP 25413)] virJSONValueObjectGetString (object=0x0, key=key@entry=0x7fffe4f72429

Re: [libvirt] [PATCH v2] qemu: snapshot: remove the redundant 'if' check

2015-03-04 Thread Shanzhi Yu
On 03/04/2015 09:12 PM, Peter Krempa wrote: On Sat, Feb 28, 2015 at 17:51:36 +0800, Shanzhi Yu wrote: When the domain's source disk type is network, if source protocol is rbd or sheepdog, the 'if().. break' will end the current case, which lead to miss check the driver type is raw or qcow2

[libvirt] [PATCH v2] qemu: snapshot: remove the redundant 'if' check

2015-02-28 Thread Shanzhi Yu
storage. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1179533 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_driver.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e282464..544ed82 100644 --- a/src/qemu

Re: [libvirt] [PATCH] qemu: snapshot: post error when create internal system checkpoint snapshot with rbd backend

2015-02-27 Thread Shanzhi Yu
On 02/19/2015 10:35 PM, Michal Privoznik wrote: On 11.02.2015 16:57, Shanzhi Yu wrote: When create internel system checkpoint snapshot with source file based on rbd backend, libvirt miss to check if the format of source file support internal snapshot. Resolves: https://bugzilla.redhat.com

[libvirt] [PATCH] util: make use of VIR_LOCK_SPACE_ACQUIRE_AUTOCREATE in virLockSpaceAcquireResource

2015-02-12 Thread Shanzhi Yu
When create external disk snapshot with virtlock enabled, libvirtd will hang if flag VIR_LOCK_SPACE_ACQUIRE_AUTOCREATE is missed in virLockSpaceAcquireResource. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1191901 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/util/virlockspace.c | 6

Re: [libvirt] [PATCH] util: make use of VIR_LOCK_SPACE_ACQUIRE_AUTOCREATE in virLockSpaceAcquireResource

2015-02-12 Thread Shanzhi Yu
On 02/12/2015 07:17 PM, Daniel P. Berrange wrote: On Thu, Feb 12, 2015 at 07:12:57PM +0800, Shanzhi Yu wrote: When create external disk snapshot with virtlock enabled, libvirtd will hang if flag VIR_LOCK_SPACE_ACQUIRE_AUTOCREATE is missed in virLockSpaceAcquireResource. Resolves: https

[libvirt] [PATCH] qemu: snapshot: post error when create internal system checkpoint snapshot with rbd backend

2015-02-11 Thread Shanzhi Yu
When create internel system checkpoint snapshot with source file based on rbd backend, libvirt miss to check if the format of source file support internal snapshot. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1179533 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] storage: rbd: Improve the error when start a pool based on non-exist rados object

2015-02-10 Thread Shanzhi Yu
On 02/06/2015 08:55 PM, Ján Tomko wrote: On Fri, Feb 06, 2015 at 07:45:37PM +0800, Shanzhi Yu wrote: When start/create a pool based on non-exist rados object, the error will be like $virsh pool-start p-c error: Failed to start pool p-c error: failed to create the RBD IoCTX. Does the pool

Re: [libvirt] [PATCH] qemu: fix crash in migrate when migrateuri do not have a scheme

2015-02-10 Thread Shanzhi Yu
On 02/11/2015 03:41 PM, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1191355 When we migrate a vm with migrateuri option with a uri do not have scheme like this: # virsh migrate test4 --live qemu+ssh://lhuang/system --migrateuri 127.0.0.1 target libvirtd will crashed

[libvirt] [PATCH] storage: rbd: Improve the error when start a pool based on non-exist rados object

2015-02-06 Thread Shanzhi Yu
: internal error: failed to create the RBD IoCTX. the rados pool 'libvirt-pool-clone' is not available Signed-off-by: Shanzhi Yu s...@redhat.com --- src/storage/storage_backend_rbd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src

Re: [libvirt] [PATCH] qemu: snapshot: inactive external snapshot can't work after libvirtd restart

2015-01-15 Thread Shanzhi Yu
On 01/14/2015 12:14 AM, John Ferlan wrote: On 12/06/2014 11:32 AM, Shanzhi Yu wrote: When create inactive external snapshot, after update disk definitions, virDomainSaveConfig is needed, if not after restart libvirtd the new snapshot file definitions in xml will be lost. Reproduce steps: 1

[libvirt] [PATCH] qemu: snapshot: inactive external snapshot can't work after libvirtd restart

2014-12-06 Thread Shanzhi Yu
/lib/libvirt/images/rhel7.img This was first reported by Eric Blake http://www.redhat.com/archives/libvir-list/2014-December/msg00369.html Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu

Re: [libvirt] snapshot-create-as doesn't always work across libvirtd restarts

2014-12-06 Thread Shanzhi Yu
On 12/06/2014 03:33 PM, Eric Blake wrote: I just found out the hard way that we have a bug in snapshot-create-as, when I corrupted a guest. I was testing with an offline domain: # virsh dumpxml win64 |grep -C1 driver disk type='block' device='disk' driver name='qemu' type='raw'/

[libvirt] [PATCH] qemu: snapshot: Report better error when create internal snapshot with passthrough devices

2014-12-03 Thread Shanzhi Yu
When create internal system checkpoint snapshot, it will not works if guest has passthrough devices attached. It will report error: error: operation failed: Error -22 while writing VM With this patch, it will report erro: error: Requested operation is not valid: domain has assigned non-USB host

[libvirt] [PATCH] virsh: vol-upload disallow negative offset

2014-12-02 Thread Shanzhi Yu
In commit 570d0f, it should diable negative offset both in cmdVolDownload and cmdVolUpload according the description, while it really didn't in cmdVolUpload Disable it in this patch Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1087104 Signed-off-by: Shanzhi Yu s...@redhat.com --- tools

[libvirt] [PATCH] qemu: add port check for iscsi host when disk type is network

2014-11-13 Thread Shanzhi Yu
/show_bug.cgi?id=1163553 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_command.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f674ba9..f806225 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3016,6

Re: [libvirt] [PATCH] qemu: add port check for iscsi host when disk type is network

2014-11-13 Thread Shanzhi Yu
On 11/13/2014 05:42 PM, Peter Krempa wrote: On 11/13/14 10:28, Shanzhi Yu wrote: For network type disk, host port is not checked when source protocol is iscsi, so the error is not sure when with invalid port. If pass -1 to port the error will be error: Failed to start domain rh6-i error

Re: [libvirt] [PATCH] qemu: add port check for iscsi host when disk type is network

2014-11-13 Thread Shanzhi Yu
On 11/13/2014 06:21 PM, Peter Krempa wrote: On 11/13/14 11:17, Shanzhi Yu wrote: On 11/13/2014 05:42 PM, Peter Krempa wrote: On 11/13/14 10:28, Shanzhi Yu wrote: For network type disk, host port is not checked when source protocol is iscsi, so the error is not sure when with invalid port

[libvirt] [PATCH v2] qemu: add port check for host when disk type is network

2014-11-13 Thread Shanzhi Yu
to 65536 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1163553 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_command.c | 12 1 file changed, 12 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f674ba9..66082e1 100644 --- a/src/qemu

[libvirt] [PATCH] uitl: use if and only if instead of iff in some comments

2014-10-28 Thread Shanzhi Yu
-by: Shanzhi Yu s...@redhat.com --- src/util/virhash.c | 2 +- src/util/virstring.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virhash.c b/src/util/virhash.c index e3c1880..e3bf1d3 100644 --- a/src/util/virhash.c +++ b/src/util/virhash.c @@ -65,7 +65,7 @@ struct

Re: [libvirt] [PATCH] uitl: use if and only if instead of iff in some comments

2014-10-28 Thread Shanzhi Yu
On 10/28/2014 10:17 PM, Eric Blake wrote: On 10/28/2014 08:00 AM, Shanzhi Yu wrote: From wiki In writing, phrases commonly used, with debatable propriety. In logic formulae, logical symbols are used instead of these phrases In some comments, we use if and only if, so instead the logical

Re: [libvirt] [PATCH] util: fix libvirtd crash caused by virStorageNetHostTransportTypeFromString

2014-10-27 Thread Shanzhi Yu
On 10/25/2014 03:12 AM, Eric Blake wrote: On 10/24/2014 01:01 PM, Shanzhi Yu wrote: When split uri-scheme into two strings with +, the second one will be s/split/splitting/ rdma://server/.., pass it to virStorageNetHostTransportTypeFromString will lead libvirtd crash. So a second

[libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Shanzhi Yu
not be NULL 2014-10-24 09:24:36.443+: 28876: error : virDriverLoadModule:99 : Failed module registration vboxNetworkRegister Signed-off-by: Shanzhi Yu s...@redhat.com --- src/vbox/vbox_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vbox/vbox_driver.c b/src

Re: [libvirt] [PATCH] vbox: network: make sure driver not be NULL in virRegisterNetworkDriver

2014-10-24 Thread Shanzhi Yu
On 10/24/2014 10:52 PM, Daniel P. Berrange wrote: On Fri, Oct 24, 2014 at 08:47:47AM -0600, Eric Blake wrote: On 10/24/2014 03:31 AM, Shanzhi Yu wrote: libvirtd will report below error if does not make sure driver not be NULL in virRegisterNetworkDriver $ libvirtd 2014-10-24 09:24:36.443

[libvirt] [PATCH] util: fix libvirtd crash caused by virStorageNetHostTransportTypeFromString

2014-10-24 Thread Shanzhi Yu
When split uri-scheme into two strings with +, the second one will be rdma://server/.., pass it to virStorageNetHostTransportTypeFromString will lead libvirtd crash. So a second virStringSplit call is needed. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1156288 Signed-off-by: Shanzhi Yu

Re: [libvirt] [PATCH] qemu: add capability probing for block-stream

2014-10-24 Thread Shanzhi Yu
Ping? On 09/16/2014 01:06 PM, Shanzhi Yu wrote: Since block-stream is not supported on qemu-kvm, so libvirt should post more accurate error info when do blockpull with qemu-kvm but not Command 'block-stream' is not found Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140981 Signed-off

[libvirt] [PATCH] virsh: Improve the job type reported of virsh cmd blockcommit

2014-10-23 Thread Shanzhi Yu
When begin a blockcommit job(active) with virsh, it will report Block Commit started(it really donesn't matter much), but for more preciese it should report Active Block Commit started Signed-off-by: Shanzhi Yu s...@redhat.com --- tools/virsh-domain.c | 12 +--- 1 file changed, 9

Re: [libvirt] [PATCH 2/3] qemu: save domain status after set network interface's bandwidth parameters

2014-10-06 Thread Shanzhi Yu
- Original Message - | From: Martin Kletzander mklet...@redhat.com | To: Shanzhi Yu s...@redhat.com | Cc: libvir-list@redhat.com | Sent: Monday, October 6, 2014 5:43:13 PM | Subject: Re: [libvirt] [PATCH 2/3] qemu: save domain status after set network interface's bandwidth parameters

[libvirt] [PATCHv2 3/3] qemu: save domain status after set domain's numa parameters

2014-10-06 Thread Shanzhi Yu
After set domain's numa parameters for running domain, save the change, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511; meanwihle add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetNumaParameters Signed-off-by: Shanzhi Yu s

[libvirt] [PATCHv2 0/3] Save domain satus after change some parameters

2014-10-06 Thread Shanzhi Yu
Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=1146511 Also add BeginJob/EndJob in qemuDomainSetBlkioParameters, qemuDomainSetInterfaceParameters,qemuDomainSetNumaParameters Shanzhi Yu (3): qemu: save domain status after set the blkio parameters qemu: call qemuDomainObjBeginJob

[libvirt] [PATCHv2 1/3] qemu: save domain status after set the blkio parameters

2014-10-06 Thread Shanzhi Yu
After set the blkio parameters for running domain, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511, meanwhile add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetBlkioParameters Signed-off-by: Shanzhi Yu s...@redhat.com

[libvirt] [PATCHv2 2/3] qemu: call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetInterfaceParameters

2014-10-06 Thread Shanzhi Yu
add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetInterfaceParameters Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_driver.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu

[libvirt] [PATCH] snapshot: conf: Forbid using same file as external snapshot for disks and external snapshot for memory

2014-10-02 Thread Shanzhi Yu
When create external system checkpoint snapshot, snapshot file for disks should not be same with snapshot file for memory Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1148932 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/conf/snapshot_conf.c | 10 ++ 1 file changed, 10

[libvirt] [PATCH] qemu: Improve domainSetTime error info report

2014-09-30 Thread Shanzhi Yu
check domain's status before call virQEMUCapsGet to report a accurate error when domain is shut off Resolve: https://bugzilla.redhat.com/show_bug.cgi?id=1147847 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_driver.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions

Re: [libvirt] [PATCH] qemu: save domain status after set the blkio parameters

2014-09-29 Thread Shanzhi Yu
- Original Message - | From: Martin Kletzander mklet...@redhat.com | To: Shanzhi Yu s...@redhat.com | Cc: libvir-list@redhat.com | Sent: Monday, September 29, 2014 3:07:11 PM | Subject: Re: [libvirt] [PATCH] qemu: save domain status after set the blkio parameters | | On Mon, Sep 29

[libvirt] [PATCH 1/3] qemu: save domain status after set the blkio parameters

2014-09-29 Thread Shanzhi Yu
After set the blkio parameters for running domain, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511, meanwhile add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetBlkioParameters Signed-off-by: Shanzhi Yu s...@redhat.com

[libvirt] [PATCH 0/3] Save domain satus after change some parameters

2014-09-29 Thread Shanzhi Yu
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1146511 Shanzhi Yu (3): qemu: save domain status after set the blkio parameters qemu: save domain status after set network interface's bandwidth parameters qemu: save domain status after set domain's numa parameters src/qemu

[libvirt] [PATCH 2/3] qemu: save domain status after set network interface's bandwidth parameters

2014-09-29 Thread Shanzhi Yu
After set network interface's bandwidth for running domain, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511, meanwhile add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetInterfaceParameters Signed-off-by: Shanzhi Yu s

[libvirt] [PATCH 3/3] qemu: save domain status after set domain's numa parameters

2014-09-29 Thread Shanzhi Yu
After set domain's numa parameters for running domain, save the change, save the change into live xml is needed to survive restarting the libvirtd, same story with bug 1146511; meanwihle add call qemuDomainObjBeginJob/qemuDomainObjEndJob in qemuDomainSetNumaParameters Signed-off-by: Shanzhi Yu s

[libvirt] [PATCH] qemu: save domain status after set the blkio parameters

2014-09-28 Thread Shanzhi Yu
After set the blkio parameters for running domain, save the change into live xml is needed to survive restarting the libvirtd Same story with bug 1146511 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu

[libvirt] [PATCH] configure: improve misleading libnl3-devel missing error message

2014-09-25 Thread Shanzhi Yu
When build libvirt from source with netcf-devel installed, it will report error libnl-devel =3.0 is required for macvtap support, actually it requires libnl3-devel Signed-off-by: Shanzhi Yu s...@redhat.com --- configure.ac | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH] qemu: add capability probing for block-stream

2014-09-15 Thread Shanzhi Yu
Since block-stream is not supported on qemu-kvm, so libvirt should post more accurate error info when do blockpull with qemu-kvm but not Command 'block-stream' is not found Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140981 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu

[libvirt] [PATCH] Valid pool format type for logical volume pool should be auto and lvm2

2014-06-18 Thread Shanzhi Yu
The logical volume pool supports formats auto and lvm2 Signed-off-by: Shanzhi Yu s...@redhat.com --- src/conf/storage_conf.c | 2 +- src/conf/storage_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 8b6fd79

[libvirt] [PATCH] Report an clear error when try to build lvm2 type pool

2014-06-10 Thread Shanzhi Yu
STORAGE_POOL_DISK_LVM2 can't be created by parted mklabel, so report an error when build such type pool Signed-off-by: Shanzhi Yu s...@redhat.com --- src/storage/storage_backend_disk.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/storage

[libvirt] [PATCH] Prevent guest be paused when do external system checkpoint snapshot

2014-05-14 Thread Shanzhi Yu
https://bugzilla.redhat.com/show_bug.cgi?id=1097503 Guest will be paused when do external system checkpoint snapshot with invalid compression format. Signed-off-by: Shanzhi Yu s...@redhat.com --- src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src

[libvirt] [PATCH] Improve the error info when fail to start guest due to lack of cgroup controller

2014-05-13 Thread Shanzhi Yu
When cgroup controller cpu, cpuset and cpuacct are all unmounted, fail to start guest. The error info is not accurate. It will report At least one cgroup controller is required even though there is cgroup controller memory or blkio. Signed-off-by: Shanzhi Yu s...@redhat.com --- src/util

[libvirt] [PATCH] virsh: Add one blank line after output of dompmsuspend/dompmwakeup

2014-04-11 Thread Shanzhi Yu
There should be include one blank line after result of dompmsuspend and dompmwakeup --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 73414f8..3aca1e7 100644 --- a/tools/virsh-domain.c +++

[libvirt] [PATCH] virsh: man: delete the unexpected character in snapshot-list

2014-04-02 Thread Shanzhi Yu
--- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index ba2da20..98d891a 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3162,7 +3162,7 @@ with I--current. =item Bsnapshot-list Idomain [I--metadata] [I--no-metadata]