[libvirt] [PATCH v1] storage: prefer using newDef to save configfile

2018-07-12 Thread Shichangkuo
When re-defining an active storage pool, the configfile has not changed. This issue was introduced by bfcd8fc, storage: Use virStoragePoolObjGetDef accessor for driver. So we prefer using newDef to save configfile. Signed-off-by: shichangkuo --- src/storage/storage_driver.c |6 -- 1

Re: [libvirt] [PATCH] storage: prefer using newDef to save configfile

2018-07-10 Thread Shichangkuo
> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Tuesday, July 10, 2018 9:27 PM > To: shichangkuo (Cloud); 'libvir-list@redhat.com'; 'jfer...@redhat.com' > Subject: Re: [libvirt] [PATCH] storage: prefer using newDef to save configfile &g

[libvirt] [PATCH] storage: prefer using newDef to save configfile

2018-07-10 Thread Shichangkuo
When re-defining an active storage pool, the configfile has not changed. This issue was introduced by bfcd8fc9, storage: Use virStoragePoolObjGetDef accessor for driver. So we prefer using newDef to save configfile. Signed-off-by: Changkuo Shi --- src/storage/storage_driver.c |6 -- 1

[libvirt] [libivrt] storage: Two iSCSI node records may cause refreshing iscsi pool failed

2016-12-01 Thread Shichangkuo
Hi, John When starting an iscsi storage pool, libvirt will execute “iscsiadm --mode node --portal 192.168.0.42 --targetname iqn.2003-10.com. --op new”, which is called by virISCSINodeNew. This will add an iSCSI node record. The record file is