[libvirt] [RFC 0/4] add automatic cleanup functionality in some files

This series of patches aim at augmenting our discussion about the design for implementing the cleanup attribute. A set of macros have been added at the end of viralloc.h A few files have been modified to use the newly created macros. Sukrit Bhatnagar (4): add macros for implementing automatic

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On 29 May 2018 at 10:36, Michal Privoznik wrote: > On 05/28/2018 09:34 AM, Sukrit Bhatnagar wrote: >> >> This is what new macros will look like: >> >> # define _VIR_TYPE_PTR(type) type##Ptr >> >> # define _VIR_ATTR_AUTOFREE_PTR(type) __attribu

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On 28 May 2018 at 13:54, Pavel Hrdina <phrd...@redhat.com> wrote: > On Mon, May 28, 2018 at 01:04:28PM +0530, Sukrit Bhatnagar wrote: >> On 25 May 2018 at 16:20, Pavel Hrdina <phrd...@redhat.com> wrote: >> > On Fri, May 25, 2018 at 12:06:50PM +0200, Andrea Bolognani w

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On 25 May 2018 at 16:20, Pavel Hrdina wrote: > On Fri, May 25, 2018 at 12:06:50PM +0200, Andrea Bolognani wrote: >> On Fri, 2018-05-25 at 10:04 +0200, Pavel Hrdina wrote: >> > On Fri, May 25, 2018 at 09:13:51AM +0200, Andrea Bolognani wrote: >> > > However, I realize it might

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

On 23 May 2018 at 21:35, Pavel Hrdina <phrd...@redhat.com> wrote: > On Sun, Mar 25, 2018 at 01:55:07AM +0530, Sukrit Bhatnagar wrote: >> Hi, >> >> I am interested in implementing the GCC cleanup attribute for automatic >> resource freeing as part of GSoC'18. I ha

[libvirt] [GSoC] Introduction

Hi, I am Sukrit Bhatnagar, selected in GSoC '18 for the project "Automatic freeing of resources". I will be modifying the libvirt core C library to add functionality for GCC cleanup attribute. Over the next couple of months, I will be discussing the general code design in this l

Re: [libvirt] [PATCH v4 0/5] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

On 18 April 2018 at 00:41, Cole Robinson <crobi...@redhat.com> wrote: > On 04/17/2018 01:33 PM, John Ferlan wrote: > > > > > > On 04/16/2018 06:56 PM, Sukrit Bhatnagar wrote: > >> Changes in v4: > >> Changes made in v2 anbd v3 to qemu_command.c are

[libvirt] [PATCH v4 4/5] qemu: Escape commas for qemuBuildGraphicsVNCCommandLine

Add comma escaping for cfg->vncTLSx509certdir. Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> --- src/qemu/qemu_command.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e903491..8f0dd

[libvirt] [PATCH v4 0/5] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

BuildChrChardevStr - cfg->vncTLSx509certdir in qemuBuildGraphicsVNCCommandLine - cfg->spiceTLSx509certdir in qemuBuildGraphicsSPICECommandLine - loader->path, loader->nvram usage in qemuBuildDomainLoaderCommandLine Link to v2: https://www.redhat.com/archives/libvir-list/2018-March/msg0

[libvirt] [PATCH v4 1/5] qemu: Escape commas for qemuBuildRomStr

Add comma escaping for info->romfile. Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> --- src/qemu/qemu_command.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index f864350..e7b8aa3 100644 --- a

[libvirt] [PATCH v4 5/5] qemu: Escape commas for qemuBuildDomainLoaderCommandLine

Add comma escaping for loader->path and loader->nvram. Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> --- src/qemu/qemu_command.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 8f0d

[libvirt] [PATCH v4 3/5] qemu: Escape commas for qemuBuildFSStr and qemuBuildFSDevStr

Add comma escaping for fs->src->path and fs->dst. Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> --- src/qemu/qemu_command.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b75e441..e903491 1

[libvirt] [PATCH v4 2/5] qemu: Escape commas for qemuBuildDriveDevStr

Add comma escaping for disk->vendor and disk->product when being built for the command line (and not from hotplug). Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> --- src/qemu/qemu_command.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --gi

Re: [libvirt] [PATCH v3] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

the series of patches start from v1? I can start afresh with the patches and this might save some confusion later. Thanks. On Wed, Apr 11, 2018 at 3:52 AM, John Ferlan <jfer...@redhat.com> wrote: > > > On 04/02/2018 04:17 PM, Sukrit Bhatnagar wrote: > > This patch adds virQEMUB

[libvirt] [PATCH v3] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

This patch adds virQEMUBuildBufferEscapeComma to properly escape commas in user provided data fields for qemu command line processing. Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> --- Thank you for the helpful feedback and apologies for the delay. Changes

[libvirt] [GSoC] Design ideas for implementing cleanup attribute

to lxc driver will be in src/lxc/lxc_cleanup.c. Your suggestions are welcome. Thanks, Sukrit Bhatnagar -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [GSoC] Pointers for project idea

Hi, Can anyone provide me with some pointers for the project "Conversion to and from OCI formatted containers"? I have referred to the relevant source files listed on the ideas page and would like to read more about it. Thanks, Sukrit -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

This patch adds virQEMUBuildBufferEscapeComma wherever applicable in src/qemu/qemu_command.c Based on: https://wiki.libvirt.org/page/BiteSizedTasks#qemu:_Use_comma_escaping_for_more_command_line_values Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> --- This patch is submitted t

[libvirt] [GSoC] Contribution towards GSoC'18 [BiteSizedTasks].

passed by an unmodified clone were passed after I made these changes. Once `make syntax-check` gave a false error related to matching of braces in if-else. Your feedback is welcome :) Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> --- src/qemu/qemu_co

[libvirt] [GSoC] git send-email help

Hi, I am trying to mail a patch I made to this list, but git send-email is not working. I have followed the steps in Contributing Guidelines page. What can I do? Thanks, Sukrit -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [GSoC]: Help in setup

:10 PM, Erik Skultety <eskul...@redhat.com> wrote: > On Tue, Mar 13, 2018 at 02:09:30AM +0530, Sukrit Bhatnagar wrote: > > Hi, > > > > I am Sukrit, currently pursuing Masters in Computer Science and > Engineering > > from Indian Institute of Technology Bo

[libvirt] [GSoC]: Help in setup

to run `autogen.sh` successfully from the git repo clone as there is some error related to gnulib git repo's URL. Can someone help me out please? Thanks, Sukrit Bhatnagar -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

<    1   2   3   4