configure: fix incorrect AC_ENABLE_ARG([test-suite], ...)
Configure incorrectly required --with-test-suite instead of --enable-test-suite
and it was
therefore impossible to disable/enable the test-suite option manually as it
would always
adopt the 'check' value.
Signed-off-by: TJ libv
make: obey WITH_TESTS; do not run test suite when --enable-test-suite=no
Even when --enable-test-suite=no a build would run the test suite. Fix the
Makefile so that
tests are conditional on WITH_TESTS.
Signed-off-by: TJ libv...@iam.tj
---
Makefile.am | 6 +-
1 file changed, 5 insertions
On 28/02/13 19:45, Laine Stump wrote:
[...sni[...]
I think Eric mentioned elsewhere that your patches are *extremely*
small. At least both the data structure, parser, and formatter changes
should go into a single patch. For that matter, this functionality is
small enough that you could put
On 28/02/13 19:51, Laine Stump wrote:
On 02/27/2013 09:57 PM, TJ wrote:
From: TJ li...@iam.tj
Rather than iterate through virNetworkIPDef arrays multiple times
use the new virNetworkDef ipv4_dhcp and ipv6_dhcp active stanza
pointers.
Signed-off-by: TJ li...@iam.tj
---
src/network
On 28/02/13 19:56, Laine Stump wrote:
On 02/27/2013 09:57 PM, TJ wrote:
From: TJ li...@iam.tj
A DHCP relay daemon will be started that will forward all DHCP/BOOTP
requests on the bridge network via the first declared forward
interface.
Okay, I think we've got our first candidate
On 28/02/13 19:51, Laine Stump wrote:
On 02/27/2013 09:57 PM, TJ wrote:
From: TJ li...@iam.tj
Rather than iterate through virNetworkIPDef arrays multiple times
use the new virNetworkDef ipv4_dhcp and ipv6_dhcp active stanza
pointers.
Signed-off-by: TJ li...@iam.tj
---
src/network
://github.com/iam-TJ/libvirt.git dhcp_relay_network
for you to fetch changes up to dfc0609403106712b205e60b53b29dc850cad68d:
docs: Describe the dhcp 'enable' and 'relay' attributes (2013-02-27
20:35:06 +)
TJ (10):
conf: DHCP
From: TJ libv...@iam.tj
Maintain backwards XML compatibility by assuming existing default values
and only adding the additional XML properties if settings are not
default.
Signed-off-by: TJ li...@iam.tj
---
src/conf/network_conf.c | 28
1 file changed, 24 insertions
From: TJ li...@iam.tj
Having previously introduced DHCP enabled and relay state within the
virNetworkIpDef structure - which can be one of many on each network -
these pointers allow us to track and easily access the DHCP state for
IPv4 and IPv6 when setting up the network without having
From: TJ li...@iam.tj
To avoid iterating all virNetworkIpDef entries when determining
DHCP state keep track of the first enabled DHCP stanza in the
network definition itself, for both IPv4 and IPv6.
A by-product of this change is it allows the XML to contain more
than one IP-DHCP stanza
From: TJ li...@iam.tj
Rather than iterate through virNetworkIPDef arrays multiple times
use the new virNetworkDef ipv4_dhcp and ipv6_dhcp active stanza
pointers.
Signed-off-by: TJ li...@iam.tj
---
src/network/bridge_driver.c | 63 +++--
1 file changed, 15
From: TJ li...@iam.tj
Maintain backwards XML compatibility by assuming existing default values
and only adding the additional XML properties if settings are not
default.
Signed-off-by: TJ li...@iam.tj
---
src/conf/network_conf.c | 28
1 file changed, 24 insertions
From: TJ li...@iam.tj
A DHCP relay daemon will be started that will forward all DHCP/BOOTP
requests on the bridge network via the first declared forward
interface. The relay is broadcast rather than routed so no IP address
is needed on the bridge.
The XML relay element's relay property
From: TJ li...@iam.tj
Signed-off-by: TJ li...@iam.tj
---
src/conf/network_conf.c | 1 +
src/network/bridge_driver.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index c5eab01..43c277c 100644
--- a/src/conf/network_conf.c
+++ b/src
From: TJ li...@iam.tj
When dnsmasq's DNS services are required but the network is configured
to use a DHCP relay agent (other than dnsmasq's proxy services) the
configuration generated for dnsmasq should not enable DHCP services.
Signed-off-by: TJ li...@iam.tj
---
src/network/bridge_driver.c
From: TJ li...@iam.tj
Signed-off-by: TJ li...@iam.tj
---
docs/formatnetwork.html.in | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in
index 41a83fa..c4c4def 100644
--- a/docs/formatnetwork.html.in
On 28/02/13 03:15, Eric Blake wrote:
On 02/27/2013 07:18 PM, TJ wrote:
Signed-off-by: TJ li...@iam.tj
Can you use a full legal name, instead of a two-letter pseudonym?
TJ is my full name.
Your commit message is missing some substance, such as a summary of what
is being added.
The first
On 28/02/13 03:23, Eric Blake wrote:
On 02/27/2013 07:57 PM, TJ wrote:
From: TJ li...@iam.tj
Maintain backwards XML compatibility by assuming existing default values
and only adding the additional XML properties if settings are not
default.
Signed-off-by: TJ li...@iam.tj
---
src/conf
On 28/02/13 03:38, Eric Blake wrote:
This indentation mess with TAB is making this hard to review.
It seems vim is the culprit. Default setting seems to be that it's inserting a
tab when I hit Enter on a previous line when there's a multiple of 8 spaces of
indent on the new line. I had a
On 28/02/13 03:49, Eric Blake wrote:
On 02/27/2013 08:26 PM, TJ wrote:
On 28/02/13 03:15, Eric Blake wrote:
On 02/27/2013 07:18 PM, TJ wrote:
Signed-off-by: TJ li...@iam.tj
Can you use a full legal name, instead of a two-letter pseudonym?
TJ is my full name.
Whatever. It might
On 28/02/13 04:16, Eric Blake wrote:
diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in
index 41a83fa..c4c4def 100644
--- a/docs/formatnetwork.html.in
+++ b/docs/formatnetwork.html.in
Yay - your series added documentation!
I commented to a student that the documentation
On 28/02/13 04:09, Eric Blake wrote:
On 02/27/2013 07:57 PM, TJ wrote:
From: TJ li...@iam.tj
A DHCP relay daemon will be started that will forward all DHCP/BOOTP
requests on the bridge network via the first declared forward
interface. The relay is broadcast rather than routed so no IP
I'm currently adding support for running a DHCP relay daemon instead of using
dnsmasq for DHCP.
Everything is looking good but I've stumbled on one issue.
I've added a new variable to 'configure.a' (DHCPRELAY) but found that
'autogen.sh' doesn't call
'autoheader' to remake 'config.h.in' so it
On 27/02/13 01:01, TJ wrote:
I've added a new variable to 'configure.a' (DHCPRELAY) but found that
'autogen.sh' doesn't call
'autoheader' to remake 'config.h.in' so it contains the definition of
DHCPRELAY for the compiler.
False alarm - I made a typo in the most critical spot
24 matches
Mail list logo
