EPERM when hot plugging passthrough device to guest after having rebooted libvirt

2023-02-27 Thread Thanos Makatos
On an older, patched libvirt version (8.0.0), I've run into an issue when attempting to hot plug a PCI device via virsh attach-device --live. To repro: 1. start a guest and hot plug a device (works fine), 2. hot unplug the device 3. restart libvirt 4. attempt to hot plug the same device, it fails

RE: using libvirt 4.5 with upstream qemu

2021-03-02 Thread Thanos Makatos
> -Original Message- > From: Daniel Henrique Barboza > Sent: 01 March 2021 18:07 > To: Peter Krempa ; Thanos Makatos > > Cc: libvir-list@redhat.com > Subject: Re: using libvirt 4.5 with upstream qemu > > > > On 3/1/21 12:47 PM, Peter Krempa wrote:

RE: using libvirt 4.5 with upstream qemu

2021-03-01 Thread Thanos Makatos
> -Original Message- > From: Daniel P. Berrangé > Sent: 01 March 2021 15:39 > To: Thanos Makatos > Cc: libvir-list@redhat.com > Subject: Re: using libvirt 4.5 with upstream qemu > > On Mon, Mar 01, 2021 at 03:30:58PM +, Thanos Makatos wrote: > >

using libvirt 4.5 with upstream qemu

2021-03-01 Thread Thanos Makatos
I'm trying to use QEMU master with libvirt 4.5 and QEMU seems to be hanging when I try to start a guest. My environment is a modified CentOS 7.9 installation using libvirt 4.5.0. When I use a modified version of QEMU 2.12 (reasonably close to the stock CentOS version) everything works fine. When

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> -Original Message- > From: Peter Krempa > Sent: 23 November 2020 17:47 > To: Thanos Makatos > Cc: Suraj Kasi ; libvirt-l...@redhat.com; John Levon > > Subject: Re: Libvirt NVME support > > On Mon, Nov 23, 2020 at 17:40:58 +, Thanos Makatos wrote:

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> -Original Message- > From: Peter Krempa > Sent: 23 November 2020 16:56 > To: Thanos Makatos > Cc: Suraj Kasi ; libvirt-l...@redhat.com; John Levon > > Subject: Re: Libvirt NVME support > > On Mon, Nov 23, 2020 at 16:48:55 +, Thanos Makatos wrote:

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> -Original Message- > From: Peter Krempa > Sent: 23 November 2020 15:20 > To: Daniel P. Berrangé > Cc: Michal Prívozník ; Thanos Makatos > ; Suraj Kasi ; > libvirt-l...@redhat.com; John Levon > Subject: Re: Libvirt NVME support > > On Mon, Nov 23,

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> On Mon, Nov 23, 2020 at 13:07:51 +0000, Thanos Makatos wrote: > > > > > On Mon, Nov 23, 2020 at 09:47:23 +0000, Thanos Makatos wrote: > > > > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > > > > As a

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> On Mon, Nov 23, 2020 at 09:47:23 +0000, Thanos Makatos wrote: > > > On Thu, Nov 19, 2020 at 10:17:56 +0000, Thanos Makatos wrote: > > > > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > &g

RE: Libvirt NVME support

2020-11-23 Thread Thanos Makatos
> On Thu, Nov 19, 2020 at 10:17:56 +0000, Thanos Makatos wrote: > > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > > > > > And then add the storage into it as: > > > > > > > &

RE: Libvirt NVME support

2020-11-19 Thread Thanos Makatos
> As a starting point a trivial way to model this in the XML will be: > > > > And then add the storage into it as: > > > > 'target dev' is how the device appears in the guest, right? It should be something like 'nvme0n1'. I'm not sure though this is something that we

RE: Libvirt NVME support

2020-11-18 Thread Thanos Makatos
> As a separate question, is there any performance benefit of emulating a > NVMe controller compared to e.g. virtio-scsi? We haven't measured that yet; I would expect it to be slight faster and/or more CPU efficient but wouldn't be surprised if it isn't. The main benefit of using NVMe is that we

RE: Libvirt NVME support

2020-11-09 Thread Thanos Makatos
> -Original Message- > From: Peter Krempa > Sent: 09 November 2020 16:44 > To: Suraj Kasi > Cc: libvirt-l...@redhat.com; Thanos Makatos > ; John Levon > Subject: Re: Libvirt NVME support > > On Mon, Nov 09, 2020 at 16:38:11 +, Suraj Kasi wrote: > &g