Re: [libvirt] [PATCH] virNetworkDefUpdateDNSHost: Require both IP and a hostname to match

2018-11-07 Thread W. Trevor King
On Wed, Nov 07, 2018 at 11:17:51AM -0500, Laine Stump wrote: > On 11/6/18 12:10 PM, W. Trevor King wrote: > > But HOST records can have the same hostname for multiple records > > (similar to TXT records with the same value). The value that > > needs to be distinct for H

Re: [libvirt] [PATCH] virNetworkDefUpdateDNSHost: Only require IP to match

2018-11-06 Thread W. Trevor King
I've filed [1] to track this in Bugzilla. Cheers, Trevor [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1647211 -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy -- libvir-list mailing list

[libvirt] [PATCH] virNetworkDefUpdateDNSHost: Only require IP to match

2018-11-06 Thread W. Trevor King
On Tue, Nov 06, 2018 at 09:10:39AM -0800, W. Trevor King wrote: > This commit update the matching logic to only consider the IP > address. Oops, I should have updated the subject to: virNetworkDefUpdateDNSHost: Only require IP to match Cheers, Trevor -- This email may be signed or enc

Re: [libvirt] [PATCH go] version: Add ParseVersion and a Version struct

2018-11-06 Thread W. Trevor King
Anything I can do to help this along? I've adjusted the subject to have "PATCH go" instead of just "PATCH"; sorry about that. Cheers, Trevor -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

[libvirt] [PATCH] virNetworkDefUpdateDNSHost: Require both IP and a hostname to match

2018-11-06 Thread W. Trevor King
Since fc19a0059 (network: backend functions for updating network dns host/srv/txt, 2012-11-12), the matching logic for various network components has been: 1) for HOST records, it's considered a match if the IP address or any of the hostnames of an existing record matches. 2) for SRV records,

[libvirt] [PATCH] version: Add ParseVersion and a Version struct

2018-10-15 Thread W. Trevor King
Make it easier to convert version integers to the more human-readable major.minor.release format. --- connect.go | 8 version.go | 52 ++ version_test.go | 64 + 3 files