[libvirt] [PATCH] daemon: Fix indentation in libvirtd.c

2014-07-29 Thread Wang Rui
Signed-off-by: Wang Rui --- daemon/libvirtd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 4c926b3..946081a 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -803,11 +803,11 @@ static void daemonReloadHandler

Re: [libvirt] [PATCH V2 2/6] qemu: Introduce vgamem attribute for video model

2014-07-25 Thread Wang Rui
On 2014/7/24 17:48, Pavel Hrdina wrote: >> index e59ea4c..18d5c17 100644 >> --- a/src/libvirt_private.syms >> +++ b/src/libvirt_private.syms >> @@ -434,6 +434,7 @@ virDomainVcpuPinDel; >> virDomainVcpuPinFindByVcpu; >> virDomainVcpuPinIsDuplicate; >> virDomainVideoDefaultRAM; >> +virDomainVideo

Re: [libvirt] [PATCH V2 2/6] qemu: Introduce vgamem attribute for video model

2014-07-25 Thread Wang Rui
On 2014/7/24 17:40, Michal Privoznik wrote: >> --- >> src/conf/domain_conf.c | 48 ++- >> src/conf/domain_conf.h | 3 +- >> src/libvirt_private.syms | 1 + >> src/qemu/qemu_command.c | 75 >> >> 4 files chan

Re: [libvirt] [PATCH V2 1/6] qemu: Remove vram attribute in some cases

2014-07-25 Thread Wang Rui
On 2014/7/24 17:37, Pavel Hrdina wrote: >> --- >> src/conf/domain_conf.c | 17 - >> 1 file changed, 12 insertions(+), 5 deletions(-) >> [...] >> @@ -9474,9 +9471,19 @@ virDomainVideoDefParseXML(xmlNodePtr node, >> } >> >> if (vram) { >> +/* For type of kvm, vra

Re: [libvirt] [PATCH] util: virTimeFieldsThenRaw never return negative

2014-07-24 Thread Wang Rui
On 2014/7/24 13:18, Martin Kletzander wrote: > On Thu, Jul 24, 2014 at 10:17:45AM +0800, Wang Rui wrote: >> From: James >> >> virTimeFieldsThenRaw will never return negative result, so I delete related >> judgement. >> > > Looking at the code I think

Re: [libvirt] [PATCH V2 0/6] Some improvements for video model.

2014-07-23 Thread Wang Rui
On 2014/7/14 19:20, Wang Rui wrote: > From: Zeng Junliang > > https://www.redhat.com/archives/libvir-list/2014-June/msg00569.html > ping ... > diff to v1: > - Rmoving the confusing vram attribute for cirrus and stdvga. > - leave out cirrus for the new vgamem attribute.

[libvirt] [PATCH] util: virTimeFieldsThenRaw never return negative

2014-07-23 Thread Wang Rui
From: James virTimeFieldsThenRaw will never return negative result, so I delete related judgement. Signed-off-by: James --- src/util/virtime.c | 7 ++- src/util/virtime.h | 4 ++-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/util/virtime.c b/src/util/virtime.c index

Re: [libvirt] [RFC] require for suggestions on support for ivshmem device

2014-07-20 Thread Wang Rui
On 2014/7/17 17:37, Martin Kletzander wrote: > On Tue, May 20, 2014 at 11:17:32AM +0200, Martin Kletzander wrote: >> On Wed, May 14, 2014 at 08:23:21AM +, Wangrui (K) wrote: >>> Hi, >>> >>> Libvirt does not support ivshmem(Inter-VM Shared Memory) device recently, >>> thus, I would like to know

[libvirt] [PATCH V2 2/6] qemu: Introduce vgamem attribute for video model

2014-07-14 Thread Wang Rui
From: Zeng Junliang This patch introduces vgamem attribute for video model, and sets its default value as qemu used. Parse it in two ways accroding to qemu startup parameters supported: -device or -vga. Signed-off-by: Zeng Junliang Signed-off-by: Wang Rui --- src/conf/domain_conf.c | 48

[libvirt] [PATCH V2 6/6] docs: add description for vgamem attribute and secondary-vga

2014-07-14 Thread Wang Rui
From: Zeng Junliang Enhance schema. Add description for vgamem attribute and secondary-vga. Signed-off-by: Zeng Junliang Signed-off-by: Wang Rui --- docs/formatdomain.html.in | 39 ++- docs/schemas/domaincommon.rng | 5 + 2 files changed, 31

[libvirt] [PATCH V2 4/6] tests: modify test case related to vgamem attribute

2014-07-14 Thread Wang Rui
From: Zeng Junliang While removing the useless vram attribute for cirrus and stdvga device, we should update the corresponding test cases. Adding test cases for the new vgamem attribute is also needed. Signed-off-by: Zeng Junliang Signed-off-by: Wang Rui --- .../qemuhotplug-console-compat-2

[libvirt] [PATCH V2 3/6] qemu: Add support for secondary-vga

2014-07-14 Thread Wang Rui
From: Zeng Junliang Secondary-vga is supported by QEMU in currently master. Add it supported in libvirt as qemu commandline shows: '-device secondary-vga'. Signed-off-by: Zeng Junliang Signed-off-by: Wang Rui --- src/conf/domain_conf.c | 16 -- src/conf/dom

[libvirt] [PATCH V2 1/6] qemu: Remove vram attribute in some cases

2014-07-14 Thread Wang Rui
From: Zeng Junliang The vram attribute is invalid for cirrus and stdvga device, and default vram value would make us confused. It would be better to remove it. Signed-off-by: Zeng Junliang Signed-off-by: Wang Rui --- src/conf/domain_conf.c | 17 - 1 file changed, 12

[libvirt] [PATCH V2 0/6] Some improvements for video model.

2014-07-14 Thread Wang Rui
From: Zeng Junliang https://www.redhat.com/archives/libvir-list/2014-June/msg00569.html diff to v1: - Rmoving the confusing vram attribute for cirrus and stdvga. - leave out cirrus for the new vgamem attribute. - add secondary-vga supports and some other docs and tests. Zeng Junliang (6): qem

[libvirt] [PATCH V2 5/6] tests: Add test cases for secondary-vga

2014-07-14 Thread Wang Rui
From: Zeng Junliang While adding support for secondary-vga, we should add test cases for it and test its basic functions. Signed-off-by: Zeng Junliang Signed-off-by: Wang Rui --- qemuxml2argv-graphics-vnc-secondary-vga.xml| 39 ++ .../qemuxml2argv-graphics-vnc

Re: [libvirt] [PATCH] properly set video ram size for qemu VGA video device

2014-07-08 Thread Wang Rui
On 2014/7/7 20:39, Ján Tomko wrote: > On 07/07/2014 01:44 PM, Pavel Hrdina wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1076098 >> >> We support vram option for video devices in domain xml, but so far >> only for QXL it had some effect. VGA video device in QEMU can also >> accept the size

[libvirt] [RFC]KVM VMs stay in pause state too long in finish phase during migration

2014-07-03 Thread Wang Rui
Hi, I started a VM on KVM environment(libvirt1.2.6 qemu1.5.1). I found that the startup thread keeps vm lock too long. And this would cause other VMs paused(both on src and dest) too long during migration. Steps to Reproduce: 1. Define and start three VMs(VMA, VMB, VMC) on source host with 16 N

Re: [libvirt] [PATCH] LXC: update comments of lxcDomainCreateXMLWithFiles() and lxcDomainCreateXML()

2014-07-02 Thread Wang Rui
On 2014/6/25 16:16, Wang Rui wrote: > From: Yue wenyuan > > The comments for lxcDomainCreateXMLWithFiles are out of date. So update them. > And add comments for lxcDomainCreateXML > > Signed-off-by: Wang Rui > Signed-off-by: Yue wenyuan > --- >

[libvirt] [PATCH] LXC: update comments of lxcDomainCreateXMLWithFiles() and lxcDomainCreateXML()

2014-06-25 Thread Wang Rui
From: Yue wenyuan The comments for lxcDomainCreateXMLWithFiles are out of date. So update them. And add comments for lxcDomainCreateXML Signed-off-by: Wang Rui Signed-off-by: Yue wenyuan --- src/lxc/lxc_driver.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff

<    1   2