Re: [libvirt] [libvirt-glib v8 5/5] tests: Add test for GVirConfigDomainHostdevPci API

, Zeeshan Ali (Khattak) <zeesha...@gnome.org> wrote: > --- > tests/test-gconfig.c| 43 > + > tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ > 2 files changed, 54 insertions(+) > create mode 100644 tests/x

[libvirt] [libvirt-glib v8 5/5] tests: Add test for GVirConfigDomainHostdevPci API

--- tests/test-gconfig.c| 43 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ 2 files changed, 54 insertions(+) create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml diff --git a/tests/test-gconfig.c

[libvirt] [libvirt-glib v8 3/5] gconfig: Add GVirConfigDomainHostdevPci

received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#include + +#includ

[libvirt] [libvirt-glib v8 4/5] gconfig: Add GVirConfigDomainAddressPci getters

From: Christophe Fergeau They will be useful to do more checks in the GVirDomainDeviceHostdev unit test. --- .../libvirt-gconfig-domain-address-pci.c | 45 ++ .../libvirt-gconfig-domain-address-pci.h | 5 +++

[libvirt] [libvirt-glib v8 2/5] gconfig: Add GVirConfigDomainHostdev

* You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#inclu

[libvirt] [libvirt-glib v8 1/5] gconfig: Add gvir_config_object_has_child

From: Christophe Fergeau --- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h

Re: [libvirt] [libvirt-glib v7 3/5] gconfig: Add GVirConfigDomainHostdevPci

On Mon, Jul 25, 2016 at 10:08 AM, Christophe Fergeau <cferg...@redhat.com> wrote: > On Fri, Jul 22, 2016 at 01:43:35PM +0100, Zeeshan Ali (Khattak) wrote: >> +gboolean >> gvir_config_domain_hostdev_pci_get_rom_bar(GVirConfigDomainHostdevPci >> *hostdev) >> +

[libvirt] [libvirt-glib v7 4/5] gconfig: Add GVirConfigDomainAddressPci getters

From: Christophe Fergeau They will be useful to do more checks in the GVirDomainDeviceHostdev unit test. --- .../libvirt-gconfig-domain-address-pci.c | 45 ++ .../libvirt-gconfig-domain-address-pci.h | 5 +++

[libvirt] [libvirt-glib v7 3/5] gconfig: Add GVirConfigDomainHostdevPci

received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#include + +#includ

[libvirt] [libvirt-glib v7 2/5] gconfig: Add GVirConfigDomainHostdev

* You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#inclu

[libvirt] [libvirt-glib v7 1/5] gconfig: Add gvir_config_object_has_child

From: Christophe Fergeau --- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h

[libvirt] [libvirt-glib v7 5/5] tests: Add test for GVirConfigDomainHostdevPci API

--- tests/test-gconfig.c| 43 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ 2 files changed, 54 insertions(+) create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml diff --git a/tests/test-gconfig.c

Re: [libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

Hi, On Fri, Jul 22, 2016 at 10:27 AM, Christophe Fergeau <cferg...@redhat.com> wrote: > On Thu, Jul 21, 2016 at 06:11:36PM +0100, Zeeshan Ali (Khattak) wrote: >> Hi, >> >> On Mon, Jul 18, 2016 at 3:54 PM, Christophe Fergeau <cferg...@redhat.com> >> w

[libvirt] [gconfig v6 4/5] gconfig: Add GVirConfigDomainAddressPci getters

From: Christophe Fergeau They will be useful to do more checks in the GVirDomainDeviceHostdev unit test. --- .../libvirt-gconfig-domain-address-pci.c | 45 ++ .../libvirt-gconfig-domain-address-pci.h | 5 +++

[libvirt] [gconfig v6 5/5] Add test for GVirConfigDomainHostdevPci API

--- tests/test-gconfig.c| 43 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ 2 files changed, 54 insertions(+) create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml diff --git a/tests/test-gconfig.c

[libvirt] [gconfig v6 2/5] Add GVirConfigDomainHostdev

* You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#inclu

[libvirt] [gconfig v6 1/5] gconfig: Add gvir_config_object_has_child

From: Christophe Fergeau --- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h

[libvirt] [gconfig v6 3/5] Add GVirConfigDomainHostdevPci

received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#include + +#includ

Re: [libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

manually specify for adding patch series version. > Acked-by: Christophe Fergeau <cferg...@redhat.com> > > Christophe > > On Wed, Jul 06, 2016 at 10:45:52PM +0100, Zeeshan Ali (Khattak) wrote: >> Add API to read and write domain/devices/hostdev nodes. This patch

Re: [libvirt] [PATCH] config: Add listen setter

config_domain_video_set_accel3d; >> } LIBVIRT_GCONFIG_0.2.2; >> >> +LIBVIRT_GCONFIG_0.2.5 { >> + gvir_config_domain_graphics_spice_set_listen; >> +} LIBVIRT_GCONFIG_0.2.4; >> + >> # define new API here using predicted next version number >> -- >> 2.5.5 >> > > > > -- > Visarion-Mingopol Alexandru-Viorel > Telefon : 0729614060 > Best Bucuresti > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list -- Regards, Zeeshan Ali (Khattak) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-glib] gconfig: Add gvir_config_domain_video_get_model()

Add a getter for model of domain video device. --- libvirt-gconfig/libvirt-gconfig-domain-video.c | 12 libvirt-gconfig/libvirt-gconfig-domain-video.h | 1 + libvirt-gconfig/libvirt-gconfig.sym| 1 + 3 files changed, 14 insertions(+) diff --git

Re: [libvirt] [gconfig] gconfig: VIRTIO -> VIRTIO_GPU

Hi, On Wed, Jul 13, 2016 at 4:27 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Wed, Jul 13, 2016 at 04:16:01PM +0100, Zeeshan Ali (Khattak) wrote: >> Rename GVIR_CONFIG_DOMAIN_VIDEO_MODEL_VIRTIO to >> GVIR_CONFIG_DOMAIN_VIDEO_MODEL_VIRTIO_GPU to get the namin

[libvirt] [gconfig] gconfig: VIRTIO -> VIRTIO_GPU

Rename GVIR_CONFIG_DOMAIN_VIDEO_MODEL_VIRTIO to GVIR_CONFIG_DOMAIN_VIDEO_MODEL_VIRTIO_GPU to get the naming the same as used by libosinfo. Consistency is good anyway in general but this would also mean that Boxes can start using virgl without any changes. --- examples/config-demo.py

[libvirt] [PATCHv5 4/5] gconfig: Add GVirConfigDomainAddressPci getters

From: Christophe Fergeau They will be useful to do more checks in the GVirDomainDeviceHostdev unit test. --- .../libvirt-gconfig-domain-address-pci.c | 45 ++ .../libvirt-gconfig-domain-address-pci.h | 5 +++

[libvirt] [PATCHv5 3/5] Add GVirConfigDomainHostdevPci

received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#include + +#includ

[libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

* You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#inclu

[libvirt] gconfig: Add hostdev support v5

It's back! :) Really intend to actually get it finished and merged this time around. Basically I mostly fixed all the minor issues in patch 3/5 (Add GVirConfigDomainHostdevPci) pointed out in last review, including treatment of on/off attributes (which is why the patch "libvirt-gconfig: Accept

[libvirt] [PATCHv5 1/5] gconfig: Add gvir_config_object_has_child

From: Christophe Fergeau --- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h

[libvirt] [PATCHv5 5/5] Add test for GVirConfigDomainHostdevPci API

--- tests/test-gconfig.c| 43 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ 2 files changed, 54 insertions(+) create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml diff --git a/tests/test-gconfig.c

Re: [libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

On Thu, May 12, 2016 at 1:28 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > Looks I never answered this one. > > On Tue, Apr 26, 2016 at 05:04:30PM +0100, Zeeshan Ali (Khattak) wrote: >> >> +const gchar >> >> *gvir_config_domain_hostdev_pci_

Re: [libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

On Thu, Apr 21, 2016 at 3:12 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > On Fri, Apr 15, 2016 at 02:38:22PM +0100, Zeeshan Ali (Khattak) wrote: >> Add API to read and write PCI hostdev nodes. >> --- >> libvirt-gconfig/Makefile.am|

Re: [libvirt] [PATCH v4 1/6] gconfig: Add gvir_config_object_has_child

On Thu, Apr 21, 2016 at 2:55 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > On Fri, Apr 15, 2016 at 02:38:19PM +0100, Zeeshan Ali (Khattak) wrote: >> From: Christophe Fergeau <cferg...@redhat.com> > > This patch is mine, hopefully someone else will review it ;)

Re: [libvirt] [PATCH v4 6/6] Add test for GVirConfigDomainHostdevPci API

On Thu, Apr 21, 2016 at 3:14 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > And one more. Yours? AFAIK it's mine. > On Fri, Apr 15, 2016 at 02:38:24PM +0100, Zeeshan Ali (Khattak) wrote: >> --- >> tests/test-gconfig.c

Re: [libvirt] [PATCH v4 5/6] gconfig: Add GVirConfigDomainAddressPci getters

On Thu, Apr 21, 2016 at 3:14 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > Another patch that I wrote... ACK. > Christophe > > On Fri, Apr 15, 2016 at 02:38:23PM +0100, Zeeshan Ali (Khattak) wrote: >> From: Christophe Fergeau <cferg...@redhat.com> >&g

[libvirt] [PATCH v4 6/6] Add test for GVirConfigDomainHostdevPci API

--- tests/test-gconfig.c| 43 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ 2 files changed, 54 insertions(+) create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml diff --git a/tests/test-gconfig.c

[libvirt] [PATCH v4 2/6] Add GVirConfigDomainHostdev

* You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#inclu

[libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#include + +#includ

[libvirt] [PATCH v4 3/6] libvirt-gconfig: Accept on/off as boolean attributes

gvir_config_object_get_attribute_boolean() currently only accepts yes/no as boolean attribute values. Let's also accept on/off as valid values too. This will come handy in a following patch that adds 'hostdev' handling API. --- libvirt-gconfig/libvirt-gconfig-object.c | 4 ++-- 1 file changed, 2

[libvirt] gconfig: Add hostdev support v4

Finally I got the time to clean-up and fix the patches. It's been a while last i looked into them already and I got a bit confused at some point so I appologize if I didn't address some of the review comments. -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH v4 1/6] gconfig: Add gvir_config_object_has_child

From: Christophe Fergeau --- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h

[libvirt] [PATCH v4 5/6] gconfig: Add GVirConfigDomainAddressPci getters

From: Christophe Fergeau They will be useful to do more checks in the GVirDomainDeviceHostdev unit test. --- .../libvirt-gconfig-domain-address-pci.c | 45 ++ .../libvirt-gconfig-domain-address-pci.h | 5 +++

Re: [libvirt] [libvirt-glib v2 8/9] Add test for GVirConfigDomainHostdevPci API

On Fri, Mar 11, 2016 at 3:15 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > On Fri, Mar 11, 2016 at 03:03:03PM +, Zeeshan Ali (Khattak) wrote: >> On Fri, Mar 11, 2016 at 9:21 AM, Christophe Fergeau <cferg...@redhat.com> >> wrote: >> > On Thu, Mar 1

Re: [libvirt] [libvirt-glib v2 8/9] Add test for GVirConfigDomainHostdevPci API

On Fri, Mar 11, 2016 at 9:21 AM, Christophe Fergeau <cferg...@redhat.com> wrote: > On Thu, Mar 10, 2016 at 05:08:33PM +, Zeeshan Ali (Khattak) wrote: >> Hi, >> >> I'm a bit confused, this patch doesn't seem to add anything to mine. >> Did you forget to comm

Re: [libvirt] [libvirt-glib v2 8/9] Add test for GVirConfigDomainHostdevPci API

Hi, I'm a bit confused, this patch doesn't seem to add anything to mine. Did you forget to commit? On Fri, Jan 29, 2016 at 6:21 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > From: "Zeeshan Ali (Khattak)" <zeesha...@gnome.org> > &

Re: [libvirt] [libvirt-glib 1/3] Add GVirConfigDomainHostdev

u should have received a copy of the GNU Lesser General Public >> + * License along with this library. If not, see >> + * <http://www.gnu.org/licenses/>. >> + * >> + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> >> + * Christophe Fergeau &l

Re: [libvirt] [libvirt-glib 2/3] Add GVirConfigDomainHostdevPci

ar = FALSE; >> + >> +return (const char *) rom_node->children->content; > > The filename is in the file attribute, it's not in the node content > (addressed in a patch I'm going to send by switching to using > GVirConfigObject helpers). > > Regarding the API, I d

[libvirt] [libvirt-glib 2/3] Add GVirConfigDomainHostdevPci

received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#include + +#includ

[libvirt] [libvirt-glib 3/3] Add test for GVirConfigDomainHostdevPci API

--- tests/test-gconfig.c| 30 + tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 + 2 files changed, 41 insertions(+) create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml diff --git a/tests/test-gconfig.c

[libvirt] [libvirt-glib 1/3] Add GVirConfigDomainHostdev

* You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> + * Christophe Fergeau <cferg...@redhat.com> + */ + +#inclu

[libvirt] [libvirt-glib] gobject, gconfig: Drop redundant debug logging

Justification from IRC chat: danpb: i'm not sure it's good to have a g_debug() for every libvirt-gobject/gconfig object creation/destruction danpb: the debug output becomes so big that at least I never think about enabling it at runtime and sometimes end up missing

Re: [libvirt] [libvirt-glib v5] gobject: Port to GTask API

On Thu, Nov 26, 2015 at 10:20 AM, Christophe Fergeau <cferg...@redhat.com> wrote: > Hey, > > Still a couple of comments :( Fixed and pushed. Thanks for reviews. -- Regards, Zeeshan Ali (Khattak) Befriend GNOME: http://www.gnome.org/frie

[libvirt] [libvirt-glib v5] gobject: Port to GTask API

Drop usage of deprecated GSimpleAsyncResult API. --- v5: * Plug some GError leaks. * Drop StoragePoolBuildData in favour of GUINT_TO_POINTER/GPOINTER_TO_UINT. * Don't unref GTask before using it later in idle callback. libvirt-gobject/libvirt-gobject-domain.c| 290

[libvirt] [libvirt-glib v4] gobject: Port to GTask API

Drop usage of deprecated GSimpleAsyncResult API. --- libvirt-gobject/libvirt-gobject-domain.c| 290 +--- libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++ libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++---

Re: [libvirt] [libvirt-glib v4] gobject: Port to GTask API

On Tue, Nov 24, 2015 at 4:23 PM, Zeeshan Ali (Khattak) <zeesha...@gnome.org> wrote: > Drop usage of deprecated GSimpleAsyncResult API. > --- This version ensures that async result is returned from the main thread in gvir_stream_close_async(). > libvirt-gobject/libvirt-g

[libvirt] [libvirt-glib v3] gobject: Port to GTask API

Drop usage of deprecated GSimpleAsyncResult API. --- libvirt-gobject/libvirt-gobject-domain.c| 290 +--- libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++ libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++---

Re: [libvirt] [libvirt-glib v3] gobject: Port to GTask API

On Mon, Nov 23, 2015 at 10:45 PM, Zeeshan Ali (Khattak) <zeesha...@gnome.org> wrote: > Drop usage of deprecated GSimpleAsyncResult API. > --- Sorry, forgot to pass --annotate option to git-send-email. v3 just drops some of the private context structures in favour of GPOI

Re: [libvirt] [libvirt-glib v2 3/3] gobject: Port to GTask API

On Mon, Nov 23, 2015 at 4:08 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > On Fri, Nov 20, 2015 at 09:06:30PM +, Zeeshan Ali (Khattak) wrote: >> Drop usage of deprecated GSimpleAsyncResult API. >> --- > > A Changes since v1 section would be nice

[libvirt] [v3] gobject: Add wrapper virDomainSetTime()

--- libvirt-gobject/libvirt-gobject-domain.c | 134 +++ libvirt-gobject/libvirt-gobject-domain.h | 15 +++- libvirt-gobject/libvirt-gobject.sym | 9 +++ 3 files changed, 157 insertions(+), 1 deletion(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c

Re: [libvirt] [libvirt-glib 3/3] gobject: Port to GTask API

diately > without doing anything? I doubt so. AFAICT, it was scheduling the result to be returned in the idle using 'g_simple_async_result_complete_in_idle'. > The helper does not seem to be doing anything more, in which case I'd > suggest not creating an intermediate helper thread, and

[libvirt] [libvirt-glib v2 2/3] gconfig: Drop redundant glib compatibility code

We already require and use glib >= 2.36 so there is no reason to keep around code to ensure compatibility with glib older than that. --- libvirt-gconfig/libvirt-gconfig-compat.h | 20 1 file changed, 20 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-compat.h

[libvirt] [libvirt-glib v2 1/3] gobject: Drop redundant glib compatibility code

We already require and use glib >= 2.36 so there is no reason to keep around code to ensure compatibility with glib older than that. --- libvirt-gobject/libvirt-gobject-compat.c | 87 libvirt-gobject/libvirt-gobject-compat.h | 73 --- 2

[libvirt] [libvirt-glib 2/3] gconfig: Drop redundant glib compatibility code

We already require and use glib >= 2.36 so there is no reason to keep around code to ensure compatibility with glib older than that. --- libvirt-gconfig/libvirt-gconfig-compat.h | 20 1 file changed, 20 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-compat.h

[libvirt] [libvirt-glib v2 3/3] gobject: Port to GTask API

Drop usage of deprecated GSimpleAsyncResult API. --- libvirt-gobject/libvirt-gobject-domain.c| 273 +++ libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++ libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++

Re: [libvirt] [PATCH v2] gobject: Add wrapper virDomainSetTime()

wrong then? I think it's more important to optimize it out rather than ensuring programmer doesn't pass wrong value by mistake, here. -- Regards, Zeeshan Ali (Khattak) Befriend GNOME: http://www.gnome.org/friends/ -- libvir-list mailing lis

[libvirt] [libvirt-glib 2/3] gconfig: Drop redundant glib compatibility code

We already require and use glib >= 2.36 so there is no reason to keep around code to ensure compatibility with glib oler than that. --- libvirt-gconfig/libvirt-gconfig-compat.h | 20 1 file changed, 20 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-compat.h

[libvirt] Drop deprecated API use + redundant compat. code

Couldn't come up with a better summary here, sorry but these patches simply * Drop usage of deprecated GSimpleAsyncResult API. * Drop redundant compatibility API. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-glib 1/3] gobject: Drop redundant glib compatibility code

We already require and use glib >= 2.36 so there is no reason to keep around code to ensure compatibility with glib oler than that. --- libvirt-gobject/libvirt-gobject-compat.c | 87 libvirt-gobject/libvirt-gobject-compat.h | 73 --- 2

[libvirt] [libvirt-glib 3/3] gobject: Port to GTask API

Drop usage of deprecated GSimpleAsyncResult API. --- libvirt-gobject/libvirt-gobject-domain.c| 270 ++- libvirt-gobject/libvirt-gobject-input-stream.c | 76 +++ libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++

[libvirt] [PATCH v2] gobject: Add wrapper virDomainSetTime()

--- This version: * Replaces the seconds and nseconds arguments by a GDateTime. * Drops the use of flags argument, since caller can specify the only flag currently possible (VIR_DOMAIN_TIME_SYNC) by simply passing a NULL as the GDateTime argument. * Add some needed articles to doc comment.

Re: [libvirt] [libvirt-glib] gobject: Add wrapper virDomainSetTime()

Hi Christophe, On Wed, Oct 28, 2015 at 10:15 AM, Christophe Fergeau <cferg...@redhat.com> wrote: > Hey, > > On Tue, Oct 27, 2015 at 06:17:58PM +0000, Zeeshan Ali (Khattak) wrote: >> --- >> libvirt-gobject/libvirt-gobject-domain.c | 126 >> ++

[libvirt] [libvirt-glib] gobject: Add wrapper virDomainSetTime()

--- libvirt-gobject/libvirt-gobject-domain.c | 126 +++ libvirt-gobject/libvirt-gobject-domain.h | 25 ++ libvirt-gobject/libvirt-gobject.sym | 9 +++ 3 files changed, 160 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-domain.c

[libvirt] [libvirt-glib] gobject: Correct docs for gvir_storage_pool_get_info()

The returned GVirStoragePoolInfo pointer is not a GObject so it must not be unrefed using g_object_unref(). Since gvir_storage_pool_info_free() is private function, callers must either use g_slice_free() or g_boxed_free(). --- Perhaps we should just make gvir_storage_pool_info_free() public

Re: [libvirt] [libvirt-glib] gobject: Correct docs for gvir_storage_pool_get_info()

On Wed, Sep 23, 2015 at 2:18 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Wed, Sep 23, 2015 at 01:44:28PM +0100, Zeeshan Ali (Khattak) wrote: >> The returned GVirStoragePoolInfo pointer is not a GObject so it must not >> be unrefed using g_

Re: [libvirt] [libvirt-glib] gobject: Correct docs for gvir_storage_pool_get_info()

On Wed, Sep 23, 2015 at 3:00 PM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Wed, Sep 23, 2015 at 02:54:51PM +0100, Zeeshan Ali (Khattak) wrote: >> On Wed, Sep 23, 2015 at 2:18 PM, Daniel P. Berrange <berra...@redhat.com> >> wrote: >> > On Wed, Sep 2

Re: [libvirt] [libvirt-glib 0/4] gconfig: Leak fixes and small cleanup

, and refactors two setters in GVirConfigDomainVideo to make them use the helpers provided by GVirConfigObject. Ping? These missed the libvirt-glib release, it would be nice to get them in... :) Sorry I had missed them somehow. ACK series. -- Regards, Zeeshan Ali (Khattak

Re: [libvirt] [PATCH glib] README: formally document intended platform support targets

://www.redhat.com/mailman/listinfo/libvir-list -- Regards, Zeeshan Ali (Khattak) Befriend GNOME: http://www.gnome.org/friends/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

On Tue, Jul 21, 2015 at 4:09 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jul 21, 2015 at 03:56:54PM +0100, Zeeshan Ali (Khattak) wrote: On Tue, Jul 21, 2015 at 3:20 PM, Daniel P. Berrange berra...@redhat.com wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

*/ +(void)mac; +gvir_set_error_literal(err, GVIR_NETWORK_ERROR, + 0, + Unable to get network DHCP leases); +return NULL; +#endif /* HAVE_VIR_NETWORK_GET_DHCP_LEASES */ } -- 2.4.3 -- Regards, Zeeshan Ali (Khattak

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Mon, Jul 20, 2015 at 6:32 PM, Christophe Fergeau cferg...@redhat.com wrote: On Mon, Jul 20, 2015 at 05:24:30PM +0100, Zeeshan Ali (Khattak) wrote: And all that data is completely irrelevant for the reason I mentioned again and again. Now that we have the data, and that it goes your way

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Thu, Jul 16, 2015 at 10:11 AM, Christophe Fergeau cferg...@redhat.com wrote: On Mon, Jul 13, 2015 at 02:45:21PM +0100, Zeeshan Ali (Khattak) wrote: On Fri, Jul 10, 2015 at 5:04 PM, Christophe Fergeau cferg...@redhat.com wrote: Patches of yours broke the build, you have a strong opinion

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Fri, Jul 10, 2015 at 5:04 PM, Christophe Fergeau cferg...@redhat.com wrote: On Fri, Jul 10, 2015 at 04:43:15PM +0100, Zeeshan Ali (Khattak) wrote: I really don't see the point of evaluating possible but unlinkely[1] impact on any distro. As I said, we give distros enough time

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Thu, Jul 9, 2015 at 3:01 PM, Christophe Fergeau cferg...@redhat.com wrote: On Thu, Jul 09, 2015 at 02:41:45PM +0100, Zeeshan Ali (Khattak) wrote: The answer was that magnitude of ugliness is irrelevant. Surely you know that this is not anything objective. To me a single #ifdef is ugly

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Thu, Jul 9, 2015 at 8:05 AM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Jul 08, 2015 at 07:00:36PM +0100, Zeeshan Ali (Khattak) wrote: On Wed, Jul 8, 2015 at 3:42 PM, Christophe Fergeau cferg...@redhat.com wrote: but you haven't brought anything forward to support that ugly

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Thu, Jul 9, 2015 at 12:56 PM, Christophe Fergeau cferg...@redhat.com wrote: On Thu, Jul 09, 2015 at 12:42:23PM +0100, Zeeshan Ali (Khattak) wrote: Honestly, this is a very weird attitude, rather than trying to come with hard facts, you prefer having some kind of poll and make an arbitary

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Wed, Jul 8, 2015 at 11:11 AM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Jul 07, 2015 at 05:27:39PM +0100, Zeeshan Ali (Khattak) wrote: Hi all, Christophe pointed out that this and the previous patch binds API that was added an year ago: commit

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Wed, Jul 8, 2015 at 2:27 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Jul 08, 2015 at 01:13:09PM +0100, Zeeshan Ali (Khattak) wrote: On Wed, Jul 8, 2015 at 11:11 AM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Jul 07, 2015 at 05:27:39PM +0100, Zeeshan Ali (Khattak

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Wed, Jul 8, 2015 at 3:42 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Jul 08, 2015 at 03:37:43PM +0100, Zeeshan Ali (Khattak) wrote: Also keeping in mind that it makes very little sense to upgrade libvirt-glib and not libvirt since libvirt doesn't break any ABI/API

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

#ifdef around these new API but if others (I guess mainly Dan?) agree with Christophe, I can do that. On Tue, Jul 7, 2015 at 4:26 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: On Tue, Jul 7, 2015 at 3:17 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: --- libvirt-gobject/libvirt

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Tue, Jul 7, 2015 at 3:17 PM, Zeeshan Ali (Khattak) zeesha...@gnome.org wrote: --- libvirt-gobject/libvirt-gobject-network.c | 55 +++ libvirt-gobject/libvirt-gobject-network.h | 4 +++ libvirt-gobject/libvirt-gobject.sym | 2 ++ 3 files changed, 61

[libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

--- libvirt-gobject/libvirt-gobject-network.c | 55 +++ libvirt-gobject/libvirt-gobject-network.h | 4 +++ libvirt-gobject/libvirt-gobject.sym | 2 ++ 3 files changed, 61 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-network.c

[libvirt] [libvirt-glib PATCHv5 2/7] gobject: Plug 2 virConnect leaks

A virConnect reference is leaked in error cases. This patch moves the unref after the label we jump to on errors, to avoid this leak. --- libvirt-gobject/libvirt-gobject-connection.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[libvirt] [libvirt-glib PATCHv5 5/7] gobject: Add API to query connection networks

Add API to query networks from a connection. --- libvirt-gobject/libvirt-gobject-connection.c | 262 +++ libvirt-gobject/libvirt-gobject-connection.h | 13 +- libvirt-gobject/libvirt-gobject.sym | 6 + 3 files changed, 279 insertions(+), 2 deletions(-) diff

[libvirt] [libvirt-glib PATCHv5 4/7] gobject: Add API to query connection interfaces

Add API to query network interfaces from a connection. --- libvirt-gobject/libvirt-gobject-connection.c | 270 +++ libvirt-gobject/libvirt-gobject-connection.h | 13 +- libvirt-gobject/libvirt-gobject.sym | 7 + 3 files changed, 288 insertions(+), 2

[libvirt] [libvirt-glib PATCHv5 1/7] gobject: Simplify gvir_connection_list*() implementations

Make use of virConnectListAll* functions to avoid making 4 calls and hence avoid race conditions and complicated code. --- libvirt-gobject/libvirt-gobject-connection.c | 203 --- 1 file changed, 28 insertions(+), 175 deletions(-) diff --git

[libvirt] [libvirt-glib PATCHv5 3/7] gobject: Port GVirConnection to GTask

GSimpleAsyncResult has been deprecated in favour of GTask and with latest glib headers, we get tons of warnings about use of deprecated API. This patch ports the GVirConnection class to GTask. --- libvirt-gobject/libvirt-gobject-connection.c | 280 +-- 1 file changed, 136

[libvirt] [libvirt-glib PATCHv5 6/7] gobject: Add wrapper for virNetworkDHCPLease

+ * http://www.gnu.org/licenses/. + * + * Authors: Zeeshan Ali (Khattak) zeesha...@gnome.org + * Daniel P. Berrange berra...@redhat.com + */ + +#ifndef __LIBVIRT_GOBJECT_NETWORK_DHCP_LEASE_PRIVATE_H__ +#define __LIBVIRT_GOBJECT_NETWORK_DHCP_LEASE_PRIVATE_H__ + +G_BEGIN_DECLS

Re: [libvirt] [libvirt-glib PATCHv4 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Mon, Jul 6, 2015 at 6:05 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Jul 01, 2015 at 09:40:51PM +0100, Zeeshan Ali (Khattak) wrote: --- libvirt-gobject/libvirt-gobject-network.c | 54 +++ libvirt-gobject/libvirt-gobject-network.h | 4

[libvirt] [libvirt-glib] gobject: Remove redundant virtual functions

These virtual functions were most likely a result of copypaste error. --- libvirt-gobject/libvirt-gobject-network.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-network.h b/libvirt-gobject/libvirt-gobject-network.h index 5617ed6..8c31af4

Re: [libvirt] [libvirt-glib] gobject: Remove redundant virtual functions

On Fri, Jul 3, 2015 at 3:35 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Jul 03, 2015 at 03:17:42PM +0100, Zeeshan Ali (Khattak) wrote: These virtual functions were most likely a result of copypaste error. --- libvirt-gobject/libvirt-gobject-network.h | 5 + 1 file changed

[libvirt] [libvirt-glib PATCHv3 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

--- libvirt-gobject/libvirt-gobject-network.c | 54 +++ libvirt-gobject/libvirt-gobject-network.h | 4 +++ libvirt-gobject/libvirt-gobject.sym | 2 ++ 3 files changed, 60 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-network.c

  1   2   3   4   5   6   >