Re: [libvirt] [BUG] mlock support breakage

On Mon, Mar 13, 2017 at 12:35:42PM -0400, Luiz Capitulino wrote: > On Mon, 13 Mar 2017 16:08:58 + > "Daniel P. Berrange" <berra...@redhat.com> wrote: > > > > 2. Drop change c2e60ad0e51 and automtically increase memory > > > locking limit to

Re: [libvirt] [BUG] mlock support breakage

On Mon, Mar 13, 2017 at 11:58:24AM -0400, Luiz Capitulino wrote: > > Libvirt commit c2e60ad0e51 added a new check to the XML validation > logic where XMLs containing must also > contain . This causes two breakages where > working guests won't start anymore: > > 1. Systems where mlock limit was

[libvirt] [PATCH] Switch to GSSAPI (kerberos) instead of the insecure DIGEST-MD5

. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- daemon/libvirtd.sasl | 44 +- docs/auth.html.in| 89 +--- libvirt.spec.in | 6 ++-- 3 files changed, 102 insertions(+), 37 deletions(-) diff --git a/

Re: [libvirt] [PATCH] qemuDomainBuildNamespace: Handle file mount points

On Mon, Mar 13, 2017 at 01:37:48PM +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1431112 > > Yeah, that's right. A mount point doesn't have to be a directory. > It can be a file too. However, the code that tries to preserve > mount points under /dev for new

Re: [libvirt] [PATCH v3] Document preferred naming conventions

On Fri, Mar 10, 2017 at 03:31:29PM +0100, Michal Privoznik wrote: > On 03/06/2017 12:09 PM, Daniel P. Berrange wrote: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-off-by: Daniel P. Be

Re: [libvirt] [PATCH v3] Document preferred naming conventions

On Mon, Mar 06, 2017 at 11:09:26AM +, Daniel P. Berrange wrote: > This documents the preferred conventions for naming files, > structs, enums, typedefs and functions. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > > Changed in v3: > - Cl

Re: [libvirt] [PATCH v2 0/2] Use the shared keycodemap database

On Fri, Mar 03, 2017 at 04:54:33PM +, Daniel P. Berrange wrote: > Changed in v2: > > - Fixed make syntax-check errors > - Auto-generate man pages listing value key codes for use with > the virDomainSendKey API / virsh send-key command > > Daniel P. Berrange (2):

Re: [libvirt] [PATCH 4/6] bhyve: enumerate UEFI firmwares

On Sun, Feb 12, 2017 at 07:12:32PM +0400, Roman Bogorodskiy wrote: > From: Fabian Freyer > > Signed-off-by: Roman Bogorodskiy > --- > src/bhyve/bhyve_capabilities.c | 28 > 1 file changed, 28 insertions(+) >

Re: [libvirt] Revisiting qemu monitor timeout on VM start

On Thu, Mar 09, 2017 at 09:00:47AM +0100, Michal Privoznik wrote: > On 03/08/2017 10:19 PM, Jim Fehlig wrote: > > Hi All, > > > > Encountering a qemu monitor timeout when starting a VM has been discussed > > here > > before, e.g. > > > >

Re: [libvirt] Making containers creation easy

On Thu, Mar 09, 2017 at 09:35:18AM +0100, Michal Privoznik wrote: > On 03/09/2017 09:28 AM, Cedric Bosdonnat wrote: > > Hi Michal, > > > > On Thu, 2017-03-09 at 08:54 +0100, Michal Privoznik wrote: > >> On 03/08/2017 06:16 PM, Cedric Bosdonnat wrote: > >>> Hi all, > >>> > >>> I've worked on

Re: [libvirt] [PATCH v2 00/10] perf: Add software perf events

On Mon, Mar 06, 2017 at 02:55:18PM -0500, John Ferlan wrote: > > > On 02/23/2017 09:55 AM, Nitesh Konkar wrote: > > This patch series adds software perf events. > > The perl and go patches shall follow shortly. > > > > Nitesh Konkar (10): > > perf: add cpu_clock software perf event support >

Re: [libvirt] [RFC PATCH 1/2] qemu: Advertise ACPI support for aarch64 guests

On Wed, Mar 08, 2017 at 06:05:02PM +0100, Andrea Bolognani wrote: > On Wed, 2017-03-08 at 16:00 +, Daniel P. Berrange wrote: > > > So far, libvirt has assumed that only x86 supports ACPI, > > > but that's inaccurate since aarch64 supports it too. > >  > > IIU

Re: [libvirt] [RFC PATCH 1/2] qemu: Advertise ACPI support for aarch64 guests

On Wed, Mar 08, 2017 at 04:56:30PM +0100, Andrea Bolognani wrote: > So far, libvirt has assumed that only x86 supports ACPI, > but that's inaccurate since aarch64 supports it too. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1429509 > --- > Advertising ACPI support in capabilities

Re: [libvirt] [RFC PATCH 1/2] qemu: Advertise ACPI support for aarch64 guests

On Wed, Mar 08, 2017 at 04:56:30PM +0100, Andrea Bolognani wrote: > So far, libvirt has assumed that only x86 supports ACPI, > but that's inaccurate since aarch64 supports it too. IIUC, it only supports ACPI if using the AAVMF firmware, right ? I know that is the preferred firmware for aarch64,

Re: [libvirt] [PATCH v1 0/3] libxl: nestedhvm support

On Wed, Mar 08, 2017 at 03:09:11PM +, Joao Martins wrote: > On 03/08/2017 02:13 PM, Daniel P. Berrange wrote: > > On Wed, Mar 08, 2017 at 03:07:12PM +0100, Wim Ten Have wrote: > >> From: Wim ten Have <wim.ten.h...@oracle.com> > >> > >> This

Re: [libvirt] [PATCH v1 0/3] libxl: nestedhvm support

On Wed, Mar 08, 2017 at 03:07:12PM +0100, Wim Ten Have wrote: > From: Wim ten Have > > This patch enhances host-passthrough capability to advertise the > required vendor CPU virtualization feature which will be used to > enable 'nestedhvm' in the libxl driver. > > For

Re: [libvirt] [PATCH 2/2] qemu: Validate the domain after marking the current domain as transient

On Wed, Mar 08, 2017 at 10:32:32AM +0100, Marc Hartmayer wrote: > On Mon, Feb 27, 2017 at 11:20 AM +0100, "Daniel P. Berrange" > <berra...@redhat.com> wrote: > > On Mon, Feb 27, 2017 at 10:59:39AM +0100, Marc Hartmayer wrote: > >> On Thu, Feb 23, 2017 a

Re: [libvirt] [PATCH 3/3] qemu_domain: use correct default USB controller on ppc64

On Tue, Mar 07, 2017 at 04:15:03PM +0100, Pavel Hrdina wrote: > On Tue, Mar 07, 2017 at 02:40:55PM +, Daniel P. Berrange wrote: > > On Tue, Mar 07, 2017 at 03:32:37PM +0100, Pavel Hrdina wrote: > > > On Tue, Mar 07, 2017 at 02:55:43PM +0100, Andrea Bolognani wrote: > >

Re: [libvirt] [PATCH 3/3] qemu_domain: use correct default USB controller on ppc64

On Tue, Mar 07, 2017 at 03:32:37PM +0100, Pavel Hrdina wrote: > On Tue, Mar 07, 2017 at 02:55:43PM +0100, Andrea Bolognani wrote: > > On Tue, 2017-03-07 at 09:19 +0100, Pavel Hrdina wrote: > > > > However, after migration is complete, the > > > > element has model='nec-xhci' instead of

Re: [libvirt] [PATCH go v3] Add support for perf events

On Mon, Mar 06, 2017 at 03:08:07PM -0500, John Ferlan wrote: > > > On 02/24/2017 07:12 AM, Nitesh Konkar wrote: > > Signed-off-by: Nitesh Konkar > > --- > > connect.go | 54 ++ > > domain.go | 54

Re: [libvirt] [PATCH v3] Document preferred naming conventions

On Mon, Mar 06, 2017 at 01:11:20PM -0500, Laine Stump wrote: > On 03/06/2017 06:09 AM, Daniel P. Berrange wrote: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-off-by: Daniel P. Be

Re: [libvirt] [PATCH] make all struct typedefs comply with proposed coding conventions

On Mon, Mar 06, 2017 at 12:53:23PM -0500, Laine Stump wrote: > Proposed formal coding conventions encourage defining typedefs for > vir[Blah] and vir[Blah]Ptr separately from the associated struct named > _vir[Blah]: > > typedef struct _virBlah virBlah; > typedef virBlah *virBlahPtr; >

[libvirt] [PATCH] Add virsystemdpriv.h to UTIL_SOURCES

Ensure virsystemdpriv.h gets included in dist tarballs. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Pushed to fix RPM builds src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index c85927f..62c8743

Re: [libvirt] 'make check' fails (qemuhotplugTest) with libvirt fakeroot build, starting with 3.1.0 release

On Mon, Mar 06, 2017 at 12:05:58PM +0100, Predrag Ivanovic wrote: > On Mon, 06 Mar 2017 07:06:22 +0100 > Michal Privoznik wrote: > > >This is the problem. fakeroot tells the test that it is running under > >root user therefore it tries to access some dirs there (which is denied > >because of

[libvirt] [PATCH v3] Document preferred naming conventions

This documents the preferred conventions for naming files, structs, enums, typedefs and functions. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Changed in v3: - Clarify function naming wrt verb & subject - Simplify macro naming, since in practice libvirt code doesn't

Re: [libvirt] [PATCH] Document preferred naming conventions

On Mon, Mar 06, 2017 at 10:21:28AM +0100, Bjoern Walk wrote: > Daniel P. Berrange <berra...@redhat.com> [2017-03-03, 10:50AM +0100]: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-

Re: [libvirt] [PATCH v2] Document preferred naming conventions

On Fri, Mar 03, 2017 at 07:57:24PM +0100, Jiri Denemark wrote: > On Fri, Mar 03, 2017 at 17:47:23 +, Daniel P. Berrange wrote: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-off-by

[libvirt] [PATCH v2] Document preferred naming conventions

This documents the preferred conventions for naming files, structs, enums, typedefs and functions. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Changed in v2: - Fix typo - Add macro docs - Clarify that $VERB is always last in function/macro names HACKING

[libvirt] [PATCH v2 1/2] util: switch over to use keycodemapdb GIT submodule

. Berrange <berra...@redhat.com> --- .gitignore| 3 +- .gitmodules | 3 + src/Makefile.am | 45 ++-- src/keycodemapdb | 1 + src/util/keymaps.csv | 464 -- src/util/virk

[libvirt] [PATCH v2 2/2] Add ability to generate man page describing key code names & values

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt.spec.in | 1 + mingw-libvirt.spec.in | 2 ++ src/Makefile.am | 42 +++--- tools/virsh.pod | 20 4 files changed, 62 insertions(+), 3 deletions(-)

[libvirt] [PATCH v2 0/2] Use the shared keycodemap database

Changed in v2: - Fixed make syntax-check errors - Auto-generate man pages listing value key codes for use with the virDomainSendKey API / virsh send-key command Daniel P. Berrange (2): util: switch over to use keycodemapdb GIT submodule Add ability to generate man page describing key

Re: [libvirt] [PATCH] Document preferred naming conventions

On Fri, Mar 03, 2017 at 03:19:46PM +0100, Michal Privoznik wrote: > On 03/03/2017 10:48 AM, Daniel P. Berrange wrote: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-off-by: Daniel P. Be

Re: [libvirt] [PATCH] Document preferred naming conventions

On Fri, Mar 03, 2017 at 03:10:11PM +0100, Martin Kletzander wrote: > On Fri, Mar 03, 2017 at 09:48:23AM +, Daniel P. Berrange wrote: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-off-by

Re: [libvirt] [PATCH RFC 1/4] qemu_agent: move agent into util

> this code. > > Yeap, I too was surprised on how the changes were non disruptive wrt to qemu > driver :) > > > > > [...] > >> diff --git a/src/util/virqemuagent.h b/src/util/virqemuagent.h > >> new file mode 100644 > >> i

[libvirt] [PATCH] Document preferred naming conventions

This documents the preferred conventions for naming files, structs, enums, typedefs and functions. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- HACKING | 71 docs/hacking.html.i

Re: [libvirt] [PATCH RFC 2/4] qemu_agent: ignore requests echoed back by guest

On Thu, Mar 02, 2017 at 11:10:10AM -0700, Jim Fehlig wrote: > On 02/08/2017 09:44 AM, Joao Martins wrote: > > Signed-off-by: Joao Martins > > Since it wasn't needed before, I think it is helpful for the commit message > to describe why the change is needed now. I'm

Re: [libvirt] [PATCH] Add aarch64 to virArch

On Fri, Feb 24, 2017 at 05:11:52PM +0300, Matwey V. Kornilov wrote: > Signed-off-by: Matwey V. Kornilov > --- > src/lxc/lxc_container.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c > index

Re: [libvirt] [PATCH 2/3] conf: Clean up nodedev code

On Thu, Mar 02, 2017 at 08:04:32AM -0500, John Ferlan wrote: > > > On 03/01/2017 07:27 PM, John Ferlan wrote: > > Alter the static functions from virNodeDev* to just nodeDev* as a visual > > cue to determine which are local or not when reading code. > > Rather than trying to respond

[libvirt] [PATCH] util: switch over to use keycodemapdb GIT submodule

. Berrange <berra...@redhat.com> --- .gitignore| 3 +- .gitmodules | 3 + src/Makefile.am | 41 ++-- src/keycodemapdb | 1 + src/util/keymaps.csv | 464 -- src/util/virk

Re: [libvirt] [PATCH 2/3] conf: Clean up nodedev code

On Thu, Mar 02, 2017 at 10:35:57AM +0100, Michal Privoznik wrote: > On 03/02/2017 10:30 AM, Daniel P. Berrange wrote: > > On Thu, Mar 02, 2017 at 10:04:24AM +0100, Michal Privoznik wrote: > >> On 03/02/2017 09:58 AM, Peter Krempa wrote: > >>> On Wed, Mar 01, 2017

Re: [libvirt] [PATCH 2/3] conf: Clean up nodedev code

On Thu, Mar 02, 2017 at 10:04:24AM +0100, Michal Privoznik wrote: > On 03/02/2017 09:58 AM, Peter Krempa wrote: > > On Wed, Mar 01, 2017 at 19:27:15 -0500, John Ferlan wrote: > >> Alter the static functions from virNodeDev* to just nodeDev* as a visual > >> cue to determine which are local or not

Re: [libvirt] [PATCH v2 00/14] Add TLS support for migration

On Wed, Mar 01, 2017 at 12:47:18PM -0500, John Ferlan wrote: > > > On 03/01/2017 10:33 AM, Jiri Denemark wrote: > > On Wed, Mar 01, 2017 at 10:14:10 -0500, John Ferlan wrote: > >> On 03/01/2017 06:57 AM, Jiri Denemark wrote: > >> That jiggled a memory strand... It really wasn't clear from

Re: [libvirt] [PATCH v2 00/14] Add TLS support for migration

On Wed, Mar 01, 2017 at 01:39:18PM +0100, Jiri Denemark wrote: > On Wed, Mar 01, 2017 at 12:18:23 +, Daniel P. Berrange wrote: > > Hmm, I see this is a limitation of the migrate-set-parameters method. You > > can set new parameters for tls_creds / tls_hostname, but you can't f

Re: [libvirt] [PATCH v2 00/14] Add TLS support for migration

On Tue, Feb 28, 2017 at 11:07:21AM -0500, John Ferlan wrote: > > As I mentioned in my v1 review, we should always set the parameters if > > QEMU supports them to make sure they don't contain any leftovers from a > > previous migration. > > I see from a quick scan of the qemu code though that it

Re: [libvirt] [RFC PATCH 00/12] Support multiple PHBs on pSeries guests

On Tue, Feb 28, 2017 at 05:12:32PM +0100, Andrea Bolognani wrote: > Note: if you want to try this out, you'll need to make sure > your QEMU binary includes this commit[1]; moreover, > that commit is missing a way for libvirt to detect > whether the new naming scheme is in place,

Re: [libvirt] [PATCH RFC 2/9] conf: Introduce virPoolObj and virPoolTableObj and PoolObj API's

On Wed, Mar 01, 2017 at 05:00:05AM -0500, Andrea Bolognani wrote: > On Tue, Feb 28, 2017 at 5:39:52 PM, Daniel P. Berrange wrote: > > FWIW, the virObject framework as it exists today was just the bare > > minimum we needed in order to get a basic inheritance system up and > >

Re: [libvirt] [PATCH RFC 2/9] conf: Introduce virPoolObj and virPoolTableObj and PoolObj API's

On Wed, Mar 01, 2017 at 10:56:16AM +0100, Martin Kletzander wrote: > On Wed, Mar 01, 2017 at 09:42:37AM +, Daniel P. Berrange wrote: > > On Wed, Mar 01, 2017 at 10:27:32AM +0100, Martin Kletzander wrote: > > > On Wed, Mar 01, 2017 at 09:06:13AM +, Daniel P. Berrange wro

Re: [libvirt] [PATCH RFC 2/9] conf: Introduce virPoolObj and virPoolTableObj and PoolObj API's

On Wed, Mar 01, 2017 at 10:27:32AM +0100, Martin Kletzander wrote: > On Wed, Mar 01, 2017 at 09:06:13AM +, Daniel P. Berrange wrote: > > On Wed, Mar 01, 2017 at 09:55:03AM +0100, Martin Kletzander wrote: > > > On Tue, Feb 28, 2017 at 04:39:52PM +, Daniel P. Berrange w

Re: [libvirt] [PATCH RFC 2/9] conf: Introduce virPoolObj and virPoolTableObj and PoolObj API's

On Wed, Mar 01, 2017 at 09:55:03AM +0100, Martin Kletzander wrote: > On Tue, Feb 28, 2017 at 04:39:52PM +, Daniel P. Berrange wrote: > > FWIW, the virObject framework as it exists today was just the bare > > minimum we needed in order to get a basic inheritance system up

Re: [libvirt] [PATCH] qemuDomainAttachNetDevice: Support attach of type="user"

On Tue, Feb 28, 2017 at 05:52:15PM +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1420668 > > This has worked in previous releases. > My commit c266b60440 broke it. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_hotplug.c | 3 +++ >

Re: [libvirt] [PATCH RFC 2/9] conf: Introduce virPoolObj and virPoolTableObj and PoolObj API's

On Tue, Feb 28, 2017 at 04:52:31PM +0100, Pavel Hrdina wrote: > On Tue, Feb 28, 2017 at 04:15:42PM +0100, Michal Privoznik wrote: > > On 02/11/2017 05:29 PM, John Ferlan wrote: > > > +struct _virPoolDef { > > > +char *uuid; > > > +char *name; > > > +}; > > > + > > > +struct _virPoolObj { >

Re: [libvirt] [PATCH RFC 1/9] conf: Modify gendispatch.pl to make ACL argument opaque

On Sat, Feb 11, 2017 at 11:29:37AM -0500, John Ferlan wrote: > The various drivers each have vir*EnsureACL and vir*CheckACL API's > which are generated on the fly by gendispatch to include the driver > typed "def" name as the last argument based on the API being checked > and the driver name (e.g.

Re: [libvirt] [PATCH v2 00/14] Add TLS support for migration

On Tue, Feb 28, 2017 at 02:48:19PM +0100, Jiri Denemark wrote: > On Thu, Feb 23, 2017 at 13:42:02 -0500, John Ferlan wrote: > > AFAIU - removal of the objects would remove the migration tls-creds, > > tls-hostname settings. > > This would be a very strange behavior. > > > I left the

Re: [libvirt] [PATCH go v2] domain.go: wrong calculation of bitmask in PinVcpuFlags()

On Mon, Feb 27, 2017 at 07:23:12PM -0500, Leonid Podolny wrote: > --- > domain.go | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/domain.go b/domain.go > index 2bd9852..7276ef8 100644 > --- a/domain.go > +++ b/domain.go > @@ -1768,7 +1768,7 @@ func (d *Domain)

Re: [libvirt] [PATCH 2/2] qemu: Validate the domain after marking the current domain as transient

On Mon, Feb 27, 2017 at 10:59:39AM +0100, Marc Hartmayer wrote: > On Thu, Feb 23, 2017 at 05:36 PM +0100, "Daniel P. Berrange" > <berra...@redhat.com> wrote: > > On Thu, Feb 23, 2017 at 05:22:44PM +0100, Marc Hartmayer wrote: > >> On Thu, Feb 23, 201

[libvirt] RFC: Making storage vol upload/download more useful

The virStorageVolUpload/Download APIs currently require that you upload the physical disk image content, rather than the virtual disk image content. ie the entire qcow2 file, not just its payload. While this is certainly useful in some scenarios, it is rather unhelpful, if not dangerous, in

Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 04:39:01PM +0530, Nitesh Konkar wrote: > On Fri, Feb 24, 2017 at 4:06 PM, Daniel P. Berrange <berra...@redhat.com> > wrote: > > > On Fri, Feb 24, 2017 at 11:02:33AM +0100, Peter Krempa wrote: > > > On Fri, Feb 24, 2017 at 15:22:51 +0530, Nites

Re: [libvirt] [PATCH go v2] Add support for perf events

On Fri, Feb 24, 2017 at 11:02:33AM +0100, Peter Krempa wrote: > On Fri, Feb 24, 2017 at 15:22:51 +0530, Nitesh Konkar wrote: > > Signed-off-by: Nitesh Konkar > > --- > > connect.go | 54 ++ > > domain.go

Re: [libvirt] [PATCH 3/5] util: virbuffer: introduce virBufferEscapeN

On Thu, Feb 23, 2017 at 05:51:21PM +0100, Pavel Hrdina wrote: > On Thu, Feb 23, 2017 at 04:32:32PM +, Daniel P. Berrange wrote: > > On Thu, Feb 23, 2017 at 04:26:58PM +0100, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > > > --

Re: [libvirt] [PATCH 4/4] Add ATTRIBUTE_FALLTHROUGH for switch cases without break

On Thu, Feb 23, 2017 at 09:07:59PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > > > On Wed, Feb 22, 2017 at 05:52:05PM +, Daniel P. Berrange wrote: > > > In GCC 7 there is a new warning triggered when a switch > > > case has a conditi

Re: [libvirt] [PATCH 2/2] qemu: Validate the domain after marking the current domain as transient

On Thu, Feb 23, 2017 at 05:22:44PM +0100, Marc Hartmayer wrote: > On Thu, Feb 23, 2017 at 03:33 PM +0100, Michal Privoznik > wrote: > > On 02/23/2017 10:44 AM, Marc Hartmayer wrote: > >> Validate the domain that actually will be started. It's semantically > >> more clear and

Re: [libvirt] [PATCH 3/5] util: virbuffer: introduce virBufferEscapeN

On Thu, Feb 23, 2017 at 04:26:58PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/libvirt_private.syms | 1 + > src/util/virbuffer.c | 104 > +++ > src/util/virbuffer.h | 2 + > tests/virbuftest.c

Re: [libvirt] [PATCH 2/5] util: use VIR_STRCAT instead of strcat

On Thu, Feb 23, 2017 at 05:15:37PM +0100, Martin Kletzander wrote: > On Thu, Feb 23, 2017 at 04:26:57PM +0100, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > cfg.mk| 14 -- > > src/storage/storage_backend_logical.c |

Re: [libvirt] [PATCH 05/14] qemu: Implement NVDIMM

On Thu, Feb 23, 2017 at 02:25:13PM +0100, Michal Privoznik wrote: > On 02/23/2017 02:16 PM, Daniel P. Berrange wrote: > > On Thu, Feb 23, 2017 at 02:07:27PM +0100, Michal Privoznik wrote: > >> On 02/23/2017 11:48 AM, Daniel P. Berrange wrote: > >>> On Thu, Feb 23, 20

Re: [libvirt] [PATCH 05/14] qemu: Implement NVDIMM

On Thu, Feb 23, 2017 at 02:07:27PM +0100, Michal Privoznik wrote: > On 02/23/2017 11:48 AM, Daniel P. Berrange wrote: > > On Thu, Feb 23, 2017 at 11:16:17AM +0100, Michal Privoznik wrote: > >> On 02/23/2017 11:02 AM, Daniel P. Berrange wrote: > >>> On Thu, Feb 23, 20

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On Thu, Feb 23, 2017 at 01:15:50PM +0100, Martin Kletzander wrote: > On Thu, Feb 23, 2017 at 10:46:14AM +, Daniel P. Berrange wrote: > > On Thu, Feb 23, 2017 at 11:38:40AM +0100, Martin Kletzander wrote: > > > On Thu, Feb 23, 2017 at 09:48:48AM +, Daniel P. Berrange wro

Re: [libvirt] [PATCH 05/14] qemu: Implement NVDIMM

On Thu, Feb 23, 2017 at 11:16:17AM +0100, Michal Privoznik wrote: > On 02/23/2017 11:02 AM, Daniel P. Berrange wrote: > > On Thu, Feb 23, 2017 at 10:02:48AM +0100, Michal Privoznik wrote: > >> So, majority of the code is just ready as-is. Well, with one > >> slight ch

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On Thu, Feb 23, 2017 at 11:38:40AM +0100, Martin Kletzander wrote: > On Thu, Feb 23, 2017 at 09:48:48AM +, Daniel P. Berrange wrote: > > On Wed, Feb 22, 2017 at 09:19:15PM +0100, Martin Kletzander wrote: > > > On Wed, Feb 22, 2017 at 02:44:01PM -0500, Laine Stump wrote: >

Re: [libvirt] [PATCH 05/14] qemu: Implement NVDIMM

On Thu, Feb 23, 2017 at 10:02:48AM +0100, Michal Privoznik wrote: > So, majority of the code is just ready as-is. Well, with one > slight change: differentiate between dimm and nvdimm in places > like device alias generation, generating the command line and so > on. > > Speaking of the command

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On Wed, Feb 22, 2017 at 09:19:15PM +0100, Martin Kletzander wrote: > On Wed, Feb 22, 2017 at 02:44:01PM -0500, Laine Stump wrote: > > On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: > > > One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags > > > was

Re: [libvirt] [PATCH 4/4] Add ATTRIBUTE_FALLTHROUGH for switch cases without break

On Wed, Feb 22, 2017 at 02:49:12PM -0600, Eric Blake wrote: > On 02/22/2017 11:52 AM, Daniel P. Berrange wrote: > > In GCC 7 there is a new warning triggered when a switch > > case has a conditional statement (eg if ... else...) and > > some of the code paths fallthrou

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On Wed, Feb 22, 2017 at 02:52:08PM -0600, Eric Blake wrote: > On 02/22/2017 11:52 AM, Daniel P. Berrange wrote: > > One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags > > was missing a break that could result it in falling through to > > an incorrect codepath

Re: [libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

On Wed, Feb 22, 2017 at 03:00:41PM -0600, Eric Blake wrote: > On 02/22/2017 01:44 PM, Laine Stump wrote: > > On 02/22/2017 12:52 PM, Daniel P. Berrange wrote: > >> One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags > >> was missing a break that could r

Re: [libvirt] [PATCH 1/4] Use explicit boolean comparison in OOM check

On Thu, Feb 23, 2017 at 09:41:12AM +0100, Michal Privoznik wrote: > On 02/22/2017 06:52 PM, Daniel P. Berrange wrote: > > GCC 7 gets upset by > > > >if (!tmp && (size * count)) > > > > warning > > > > util/viralloc.c: In functi

Re: [libvirt] [PATCH 4/4] Add ATTRIBUTE_FALLTHROUGH for switch cases without break

On Wed, Feb 22, 2017 at 05:52:05PM +, Daniel P. Berrange wrote: > In GCC 7 there is a new warning triggered when a switch > case has a conditional statement (eg if ... else...) and > some of the code paths fallthrough to the next switch > statement. e.g. > > conf/domain_c

[libvirt] [PATCH 2/4] libxl: fix empty string check for channel path

The libxl code was checking that a 'char *' was != '\0', instead of checking the first element in the string Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/libxl/libxl_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_domain.c

[libvirt] [PATCH 3/4] qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags

One of the conditions in qemuDomainDeviceCalculatePCIConnectFlags was missing a break that could result it in falling through to an incorrect codepath. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/qemu/qemu_domain_address.c | 1 + 1 file changed, 1 insertion(+) diff

[libvirt] [PATCH 1/4] Use explicit boolean comparison in OOM check

~^~~~ Keep it happy by adding != 0 to the right hand expression so it realizes we really are wanting to treat the result of the arithmetic expression as a boolean Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/util/viralloc.c | 2 +- 1 file changed, 1 insertion(+), 1

[libvirt] [PATCH 0/4] Fix build with GCC 7

. Daniel P. Berrange (4): Use explicit boolean comparison in OOM check libxl: fix empty string check for channel path qemu: add missing break in qemuDomainDeviceCalculatePCIConnectFlags Add ATTRIBUTE_FALLTHROUGH for switch cases without break src/conf/domain_conf.c | 7 +++ src

[libvirt] [PATCH 4/4] Add ATTRIBUTE_FALLTHROUGH for switch cases without break

ther than a bug. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/conf/domain_conf.c | 7 +++ src/conf/network_conf.c | 3 ++- src/internal.h | 8 src/lxc/lxc_container.c | 2 +- src/network/bridge_driver.c | 6 ++ tools/virsh-edit.c

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On Wed, Feb 22, 2017 at 03:13:05PM +0100, Paolo Bonzini wrote: > > > On 22/02/2017 15:11, Daniel P. Berrange wrote: > > On Wed, Feb 22, 2017 at 03:10:00PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 22/02/2017 14:46, Daniel P. Berrange wrote: >

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On Wed, Feb 22, 2017 at 03:10:00PM +0100, Paolo Bonzini wrote: > > > On 22/02/2017 14:46, Daniel P. Berrange wrote: > > On Wed, Feb 22, 2017 at 02:38:32PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 22/02/2017 11:05, Daniel P. Berrange wrote: >

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On Wed, Feb 22, 2017 at 02:38:32PM +0100, Paolo Bonzini wrote: > > > On 22/02/2017 11:05, Daniel P. Berrange wrote: > > I'd also suggest just assigning the whole vHBA > > What do you mean by "assigning the whole vHBA"? There is no concept of > a vHBA as e.g.

Re: [libvirt] [PATCH 1/5] lib: Add API for specific vCPU hot(un)plug

On Wed, Feb 22, 2017 at 01:34:54PM +0100, Peter Krempa wrote: > On Wed, Feb 22, 2017 at 12:16:51 +, Daniel Berrange wrote: > > On Fri, Feb 10, 2017 at 06:10:18PM +0100, Peter Krempa wrote: > > > Similarly to domainSetGuestVcpus this commit adds API which allows to

Re: [libvirt] [PATCH 1/5] lib: Add API for specific vCPU hot(un)plug

On Fri, Feb 10, 2017 at 06:10:18PM +0100, Peter Krempa wrote: > Similarly to domainSetGuestVcpus this commit adds API which allows to > modify state of individual vcpus rather than just setting the count. > > This allows to enable CPUs in specific guest NUMA nodes to achieve any > necessary

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On Tue, Feb 21, 2017 at 10:45:05PM -0500, John Ferlan wrote: > > > On 02/21/2017 12:03 PM, Daniel P. Berrange wrote: > > On Tue, Feb 21, 2017 at 11:33:25AM -0500, John Ferlan wrote: > >> Repost: > >> http://www.redhat.com/archives/libvir-list/2017-February/

Re: [libvirt] [PATCH] conf: Allow omitting of numa node memory size

On Wed, Feb 22, 2017 at 10:04:08AM +0100, Peter Krempa wrote: > On Tue, Feb 21, 2017 at 15:36:23 +, Daniel Berrange wrote: > > On Tue, Feb 21, 2017 at 04:22:05PM +0100, Peter Krempa wrote: > > > Memory-less numa nodes could be specified by setting the memory size to >

Re: [libvirt] [PATCH REPOST v2 0/3] Add callback mech for qemu and nodedev

On Tue, Feb 21, 2017 at 11:33:25AM -0500, John Ferlan wrote: > Repost: http://www.redhat.com/archives/libvir-list/2017-February/msg00501.html > > to update to top of branch as of commit id '5ad03b9db2' BTW, could you include the full cover letter in each new version rather than making people

Re: [libvirt] [PATCH] conf: Allow omitting of numa node memory size

On Tue, Feb 21, 2017 at 04:22:05PM +0100, Peter Krempa wrote: > Memory-less numa nodes could be specified by setting the memory size to > 0. Allow ommiting of the parameter completely to specify the same. > > Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1217144 Does this

Re: [libvirt] [PATCH 01/12] conf: introduce domain XML element for iothread

On Tue, Feb 21, 2017 at 02:14:44PM +0100, Pavel Hrdina wrote: > On Tue, Feb 21, 2017 at 12:55:51PM +, Daniel P. Berrange wrote: > > On Tue, Feb 21, 2017 at 01:48:15PM +0100, Pavel Hrdina wrote: > > > On Tue, Feb 21, 2017 at 12:26:02PM +, Daniel P. Berrange wrote: >

Re: [libvirt] [PATCH 01/12] conf: introduce domain XML element for iothread

On Tue, Feb 21, 2017 at 01:48:15PM +0100, Pavel Hrdina wrote: > On Tue, Feb 21, 2017 at 12:26:02PM +, Daniel P. Berrange wrote: > > On Tue, Feb 21, 2017 at 01:14:57PM +0100, Pavel Hrdina wrote: > > > QEMU 2.9.0 will introduce polling feature for AioContext that instead

Re: [libvirt] [PATCH 01/12] conf: introduce domain XML element for iothread

On Tue, Feb 21, 2017 at 01:14:57PM +0100, Pavel Hrdina wrote: > QEMU 2.9.0 will introduce polling feature for AioContext that instead > of blocking syscalls polls for events without blocking. This means > that polling can be in most cases faster but it also increases CPU > utilization. > > To

[libvirt] [PATCH] Format printf format specifier used with niothreadids

c:23915:46: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t {aka unsigned int}' [-Werror=format=] virBufferAsprintf(buf, "%lu\n", ^ Signed-off-by: Daniel P. Berrange <berra...@

Re: [libvirt] [PATCH 02/13] conf: Introduce migrate_tls_x509_cert_dir

On Mon, Feb 20, 2017 at 03:30:26PM +, Daniel P. Berrange wrote: > On Mon, Feb 20, 2017 at 10:26:16AM -0500, John Ferlan wrote: > > > > > > On 02/20/2017 10:13 AM, Jiri Denemark wrote: > > > On Fri, Feb 17, 2017 at 14:39:19 -0500, John Ferlan wrote: > > >

Re: [libvirt] [PATCH 02/13] conf: Introduce migrate_tls_x509_cert_dir

On Mon, Feb 20, 2017 at 10:26:16AM -0500, John Ferlan wrote: > > > On 02/20/2017 10:13 AM, Jiri Denemark wrote: > > On Fri, Feb 17, 2017 at 14:39:19 -0500, John Ferlan wrote: > >> Add a new TLS X.509 certificate type - "migrate". This will handle the > >> creation of a TLS certificate capability

Re: [libvirt] [PATCH] qemu: Enforce qemuSecurity wrappers

On Mon, Feb 20, 2017 at 12:50:23PM +0100, Peter Krempa wrote: > On Tue, Feb 14, 2017 at 15:30:44 +0100, Michal Privoznik wrote: > > Now that we have some qemuSecurity wrappers over > > virSecurityManager APIs, lets make sure everybody sticks with > > them. We have them for a reason and calling

Re: [libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

On Fri, Feb 17, 2017 at 10:20:34AM -0600, Eric Blake wrote: > On 02/17/2017 08:26 AM, Daniel P. Berrange wrote: > > > It isn't that simple - this isn't a mere matter of checking data. The use > > of the getters during the setter method is a fundamental requirement. At > >

Re: [libvirt] [PATCH] nodedev: Introduce new drm cap

On Fri, Feb 17, 2017 at 04:19:38PM +0100, Michal Privoznik wrote: > After 7f1bdec5fa0a0cd25 our nodedev driver is capable of > determining DRM devices (DRM stands for Direct Render Manager not > Digital rights management). There is still one bit missing > though: virConnectListAllNodeDevices() is

Re: [libvirt] [PATCH] libvirt-override: fix flags mutually exclusize

On Fri, Feb 17, 2017 at 03:22:12PM +0100, Erik Skultety wrote: > On Fri, Feb 17, 2017 at 07:19:25PM +0800, Jie Wang wrote: > > Just a nit that we tend to prefix the patch with [libvirt-python] instead of > just [libvirt] so it's absolutely clear which repository you're sending the > patch against

Re: [libvirt] ARMv7 guest PCI support broken in 3.0.0 onwards

On Thu, Feb 16, 2017 at 04:58:52PM +0100, Andrea Bolognani wrote: > On Wed, 2017-02-15 at 09:24 +, Daniel P. Berrange wrote: > [...] > > $ virsh start f22-arm32 > > error: Failed to start domain f22-arm32 > > error: internal error: qemu unexpectedly closed the monito

<    5   6   7   8   9   10   11   12   13   14   >