From: Julio Faracco
The function nodedevRegister() (or all register functions) requires an
integer as a return. That function is not returning a value when UDEV is
not set. This commit just adds a generic return for that specific case.
Signed-off-by: Julio Faracco
---
From: Julio Faracco
Using lease information from dnsmasq, libvirt can retrieve hostname
information. LXC documentation says that hostname can be 'lxc.uts.name',
but if an user runs 'hostnamectl' and change hostname during container
execution, it will reflect the command output. This option could
From: Julio Faracco
There is a lots of possibilities to retrieve hostname information from
domain. Libvirt could use lease information from dnsmasq to get current
hostname too. QEMU supports QEMU-agent but it can use lease source. See
'domifaddr' as an example.
This commit still adds lease
From: Julio Faracco
The first patch add a new parameter into virDomainGetHostname to specify
which source an user would like to fetch hostname. QEMU supports agent
and lease from dnsmasq. Drivers that are not supporting any of these,
are included into default section of switch-case structure.
From: Julio Faracco
In function virSecurityDeviceLabelDefNew(), when libvirt fails to
allocate seclabel structure it returns a failure. This case is setting
seclabel as a NULL pointer and accessing its attribute below. This
commit fixes this wrong logic.
Signed-off-by: Julio Faracco
---
From: Julio Faracco
LXC was not working when you attached a new disk that points to block
device. See: https://bugzilla.redhat.com/show_bug.cgi?id=1697115.
Command line from virsh was showing problems with alias first (this
feature is not supported) and after, problems to query block device. It
From: Julio Faracco
Some people from IBM does not use 'ibm.com' domain emails.
They use personal or other domains.
Signed-off-by: Julio Faracco
---
docs/gitdm/companies/ibm | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/gitdm/companies/ibm b/docs/gitdm/companies/ibm
index
From: Julio Faracco
There is an issue with when of 'x' or 'y' settings are 0.
Function virDomainVideoResolutionDefParseXML() will validate this XML,
but both 'x' and 'y' will be removed. One example, if someone defines
this settings:
After applying this settings, funcion
From: Julio Faracco
Commit 72862797 introduced resolution settings for QEMU video drivers.
It includes a new structure inside video definition. So, the code needs
to clear pointer allocation for that structure into clear function
virDomainVideoDefClear(). This commit adds this missing
From: Julio Faracco
This commit let QEMU command line define 'xres' and 'yres' properties
if XML contains both properties from video model: based on resolution
fields 'x' and 'y'. There is a conditional structure inside
qemuDomainDeviceDefValidateVideo() that validates if video model
supports
From: Julio Faracco
This serie adds resolution ('x' and 'y') properties into XML definition
for QEMU video devices to specify a default resolution. This specific
case is not considering those attributes as a QEMU capabilities due to
complexity of code versus test complexity versus a real gain.
From: Julio Faracco
This commit adds resolution element with parameters 'x' and 'y' into video
XML domain group definition. Both, properties were added into an element
called 'resolution' and it was added inside 'model' element. They are set
as optional. This element does not follow QEMU
From: Julio Faracco
Now, QEMU command line can define 'xres' and 'yres' if XML contains both
properties from video model. This is generetaed if resolution was set.
Code let QEMU handle if video model supports this feature.
Signed-off-by: Julio Faracco
---
src/qemu/qemu_command.c | 5 +
1
From: Julio Faracco
This serie adds resolution ('x' and 'y') properties into XML definition
for QEMU video devices to specify a default resolution. This specific
case is not considering those attributes as a QEMU capabilities due to
complexity of code versus test complexity versus a real gain.
From: Julio Faracco
New tests to verify resolution properties of a simple qxl video. Other
video models supports 'xres' and 'yres' feature for QEMU. But a qxl test
should be enough to cover this domain feature.
Signed-off-by: Julio Faracco
---
.../video-qxl-resolution.args |
From: Julio Faracco
XML need to support both properties together. This commit adds XML
support for video model if they are set. Domain configuration is able
to parse this properties as 'x' and 'y'. Code is not using same label as
QEMU: 'xres' and 'yres'.
Signed-off-by: Julio Faracco
---
From: Julio Faracco
This commit adds resolution element with parameters 'x' and 'y' into video
XML domain group definition. Both, properties were added into an element
called 'resolution' and it was added inside 'model' element. They are set
as optional. This element does not follow QEMU
From: Julio Faracco
Function qemuMigrationEatCookie() calls
qemuMigrationCookieXMLParseStr(), when qemuCaps is not set, function
assumes priv as a NULL pointer. At the end, function tries to set
job info operation to the same current job. But, if priv is NULL due to
missing qemuCaps, code
From: Julio Faracco
This is an issue for LXC loop devices when you are trying to get loop
devices info using `ioctl`. Modern apps uses `/sys/dev/block` to grab
information about devices, but if you use the method mention you won't
be able to retrive the associated file with that loop device. See
From: Julio Faracco
This is an issue for LXC loop devices when you are trying to get loop
devices info using `ioctl`. Modern apps uses `/sys/dev/block` to grab
information about devices, but if you use the method mention you won't
be able to retrive the associated file with that loop device. See
From: Julio Faracco
New test case was added to cover 'xres' and 'yres' properties for Bochs
model due to latest QEMU version.
Signed-off-by: Julio Faracco
---
...ochs-display-resolution.x86_64-latest.args | 35 +++
.../video-bochs-display-resolution.xml| 33
From: Julio Faracco
New test case was added to cover 'xres' and 'yres' properties for QXL
model due to latest QEMU version.
Signed-off-by: Julio Faracco
---
.../video-qxl-resolution.x86_64-latest.args | 35 +++
.../qemuxml2argvdata/video-qxl-resolution.xml | 33
From: Julio Faracco
This commit adds resolution element with parameters 'x' and 'y' into video
XML domain group definition. Both, properties were added into an element
called 'resolution' and it was added inside 'model' element. They are
set as optional. This element does not follow QEMU
From: Julio Faracco
Display devices can use now properties 'xres' and 'yres' by QEMU
command line. Only models specified by their QEMU capabilities. This
commit includes VGA, QXL, Virtio and Bochs.
Signed-off-by: Julio Faracco
---
src/qemu/qemu_command.c | 20
1 file
From: Julio Faracco
New test case was added to cover 'xres' and 'yres' properties for VGA
model due to latest QEMU version.
Signed-off-by: Julio Faracco
---
tests/qemuxml2argvtest.c | 1 +
tests/qemuxml2xmltest.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/tests/qemuxml2argvtest.c
From: Julio Faracco
New element 'resolution' with parameters 'x' and 'y' were added to
support this settings for VGA, QXL, Virtio and Bochs XMLs. A new
structure was created as Acceleration element has. It is easy to parse
this property. Example:
Signed-off-by: Julio Faracco
From: Julio Faracco
New QEMU capabilities for display resolution were added: xres and yres.
Some models supports like VGA, QXL, Virtio and Bochs support set
resolution for driver. The capabilities mentioned above were added into
those models.
Signed-off-by: Julio Faracco
---
From: Julio Faracco
The display model 'bochs-display' should be added into capability test
case of command 'device-list-properties' because we are supporting this
display now. It is listed by 'virQEMUCapsDeviceProps'.
See src/qemu/qemu_capabilities.c:1378.
Signed-off-by: Julio Faracco
---
From: Julio Faracco
New test case was added to cover 'xres' and 'yres' properties for Virtio
model due to latest QEMU version.
Signed-off-by: Julio Faracco
---
...o-virtio-gpu-resolution.x86_64-latest.args | 35 +++
.../video-virtio-gpu-resolution.xml | 33
From: Julio Faracco
Both resolution capabilities were added for QEMU versions: 2.10, 2.11,
2.12, 3.0.0, 3.10 and 4.0.0.
Signed-off-by: Julio Faracco
---
tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 2 ++
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 2 ++
From: Julio Faracco
This serie adds 'xres' and 'yres' QEMU display properties into a new
element called 'resolution'. This element is covered by model element:
Only types VGA, QXL, Virtio and Bochs support passing resolution to
driver. That's why some test cases were added
From: Julio Faracco
This serie adds 'xres' and 'yres' properties into XML definition for QXL
video device to specify a default resolution. This serie covers a simple
test case too.
Julio Faracco (4):
docs: Adding 'xres' and 'yres' into qxl XML definition
conf: Adding XML support for 'xres'
From: Julio Faracco
XML need to support both properties together. This commit adds XML
support for QXL model if they are set. Domain configuration is able to
parse this properties.
Signed-off-by: Julio Faracco
---
src/conf/domain_conf.c | 26 ++
src/conf/domain_conf.h
From: Julio Faracco
New tests to verify resolution properties of a simple qxl video.
Signed-off-by: Julio Faracco
---
.../video-qxl-resolution.args | 32 +++
.../qemuxml2argvdata/video-qxl-resolution.xml | 40 +++
tests/qemuxml2argvtest.c
From: Julio Faracco
Now, QEMU command line can define 'xres' and 'yres' if XML contains both
properties from qxl model.
Signed-off-by: Julio Faracco
---
src/qemu/qemu_command.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
From: Julio Faracco
This commit adds 'xres' and 'yres' into qxl XML Domain group definition.
Both, properties were added into properties group inside qxl model and
they are set as optional.
Signed-off-by: Julio Faracco
---
docs/schemas/domaincommon.rng | 10 ++
1 file changed, 10
36 matches
Mail list logo
