Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

2008-04-29 Thread Soren Hansen
On Tue, Apr 08, 2008 at 02:57:15PM +0100, Daniel P. Berrange wrote: This patch seems incomplete - there's no code to include the model tag when dumping the XML. FWIW, The patch I applied in Ubuntu to do this, looks like this. It obviously still lack the test case updates and such, though.

[Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

2008-04-08 Thread Richard W.M. Jones
This patch allows selection of the NIC model for QEMU/KVM domains. The selection is done by adding a model/ element to the XML, as in this example: interface type='user' mac address='00:16:3e:33:b8:d3'/ model type='ne2k_pci'/ /interface The model type string is only checked

Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

2008-04-08 Thread Daniel Veillard
On Tue, Apr 08, 2008 at 02:17:56PM +0100, Richard W.M. Jones wrote: This patch allows selection of the NIC model for QEMU/KVM domains. The selection is done by adding a model/ element to the XML, as in this example: interface type='user' mac address='00:16:3e:33:b8:d3'/

Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

2008-04-08 Thread Daniel P. Berrange
On Tue, Apr 08, 2008 at 02:17:56PM +0100, Richard W.M. Jones wrote: This patch allows selection of the NIC model for QEMU/KVM domains. The selection is done by adding a model/ element to the XML, as in this example: interface type='user' mac address='00:16:3e:33:b8:d3'/

Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

2008-04-08 Thread Henri Cook
What about when the model name doesn't include an underscore? like e1000 H Richard W.M. Jones wrote: This patch allows selection of the NIC model for QEMU/KVM domains. The selection is done by adding a model/ element to the XML, as in this example: interface type='user' mac

Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

2008-04-08 Thread Henri Cook
I'm sorry , didn't read the patch properly first! Richard W.M. Jones wrote: This patch allows selection of the NIC model for QEMU/KVM domains. The selection is done by adding a model/ element to the XML, as in this example: interface type='user' mac

Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

2008-04-08 Thread Richard W.M. Jones
On Tue, Apr 08, 2008 at 02:57:15PM +0100, Daniel P. Berrange wrote: This patch seems incomplete - there's no code to include the model tag when dumping the XML. Yeah, agreed - forgot about that :-( We should also implement the same for Xen driver really, since that has the choice of

Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

2008-04-08 Thread Pau Garcia i Quiles
Quoting Richard W.M. Jones [EMAIL PROTECTED]: This patch allows selection of the NIC model for QEMU/KVM domains. The selection is done by adding a model/ element to the XML, as in this example: interface type='user' mac address='00:16:3e:33:b8:d3'/ model type='ne2k_pci'/

Re: [Libvir] [PATCH] Allow selection of the NIC model in QEMU/KVM

2008-04-08 Thread Daniel P. Berrange
On Tue, Apr 08, 2008 at 03:16:08PM +0100, Richard W.M. Jones wrote: On Tue, Apr 08, 2008 at 02:57:15PM +0100, Daniel P. Berrange wrote: This patch seems incomplete - there's no code to include the model tag when dumping the XML. Yeah, agreed - forgot about that :-( Oh, you may also find