Re: [Libvir] [PATCH] qemu_conf.h: Avoid dubious signed one-bit bitfield

2007-11-16 Thread Daniel Veillard
On Thu, Nov 15, 2007 at 03:32:21AM -0500, Jim Paris wrote: Signed one-bit bitfields are odd (values are 0 and -1?). The code doesn't test for == 1, so it's not currently broken, but it's fragile. (Noticed by Sparse). Okay both changes makes sense, thanks for raising those and sending

[Libvir] [PATCH] qemu_conf.h: Avoid dubious signed one-bit bitfield

2007-11-15 Thread Jim Paris
Signed one-bit bitfields are odd (values are 0 and -1?). The code doesn't test for == 1, so it's not currently broken, but it's fragile. (Noticed by Sparse). --- src/qemu_conf.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu_conf.h b/src/qemu_conf.h index