Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-30 Thread Daniel Veillard
On Wed, Apr 30, 2008 at 12:29:18AM -0400, Jim Paris wrote: Daniel P. Berrange wrote: This patch finishes off the work from Rich / Soren to support network interface model in both Xen and QEMU drivers, and adds test cases for the new syntax I still think our consensus from when I posted

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-30 Thread Daniel P. Berrange
On Wed, Apr 30, 2008 at 03:22:26AM -0400, Daniel Veillard wrote: On Wed, Apr 30, 2008 at 12:29:18AM -0400, Jim Paris wrote: Daniel P. Berrange wrote: This patch finishes off the work from Rich / Soren to support network interface model in both Xen and QEMU drivers, and adds test cases for

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-30 Thread Daniel P. Berrange
On Wed, Apr 30, 2008 at 12:29:18AM -0400, Jim Paris wrote: Daniel P. Berrange wrote: This patch finishes off the work from Rich / Soren to support network interface model in both Xen and QEMU drivers, and adds test cases for the new syntax I still think our consensus from when I posted

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-30 Thread Daniel Veillard
On Wed, Apr 30, 2008 at 12:43:06PM +0100, Daniel P. Berrange wrote: And Ubuntu have already shipped a product with a patch using this syntax applied, so we can't reasonably change it. I refuse to be bound by such arguments. We just can't accept this, if someone ships a mofified version

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-30 Thread Soren Hansen
On Wed, Apr 30, 2008 at 12:43:06PM +0100, Daniel P. Berrange wrote: And Ubuntu have already shipped a product with a patch using this syntax applied, so we can't reasonably change it. Ironically, I'm with Daniel Veillard on this one. Sure, it'd be nice if it was factored into the decision to

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-30 Thread Daniel P. Berrange
On Wed, Apr 30, 2008 at 07:27:41PM +0200, Soren Hansen wrote: On Wed, Apr 30, 2008 at 12:43:06PM +0100, Daniel P. Berrange wrote: And Ubuntu have already shipped a product with a patch using this syntax applied, so we can't reasonably change it. Ironically, I'm with Daniel Veillard on this

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-30 Thread Soren Hansen
On Wed, Apr 30, 2008 at 11:36:33PM +0100, Daniel P. Berrange wrote: WRT to the network interface type attribute, I advised Soren at the virt summit in Austin, that since Rich Jones had already posted the patch and we'd all basically agreed on syntax it was reasonably to include the patch in

[Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-29 Thread Daniel P. Berrange
This patch finishes off the work from Rich / Soren to support network interface model in both Xen and QEMU drivers, and adds test cases for the new syntax src/qemu_conf.c | 57 ++-- src/qemu_conf.h |2

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-29 Thread Daniel P. Berrange
On Tue, Apr 29, 2008 at 06:20:01PM +0100, Daniel P. Berrange wrote: This patch finishes off the work from Rich / Soren to support network interface model in both Xen and QEMU drivers, and adds test cases for the new syntax Here is a re-diff following Jim's xmlFree cleanups. Dan. Index:

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-29 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Apr 29, 2008 at 06:20:01PM +0100, Daniel P. Berrange wrote: This patch finishes off the work from Rich / Soren to support network interface model in both Xen and QEMU drivers, and adds test cases for the new syntax Here is a re-diff

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-29 Thread Jim Paris
Daniel P. Berrange wrote: This patch finishes off the work from Rich / Soren to support network interface model in both Xen and QEMU drivers, and adds test cases for the new syntax I still think our consensus from when I posted this patch last year (nic model=...) makes more sense ... but