[libvirt] Re: [Libvir] make syntax-check fails with bzr checkouts

2008-05-06 Thread Soren Hansen
On Wed, Apr 30, 2008 at 12:19:51PM +0200, Jim Meyering wrote: Unfortunately, the above no longer applies, due to upstream (gnulib) changes to deal with non-srcdir (aka VPATH) builds. I updated libvirt from gnulib just yesterday, and will again, later today. Here's the new patch that seems to

Re: [libvirt] Re: [Libvir] make syntax-check fails with bzr checkouts

2008-05-06 Thread Jim Meyering
Soren Hansen [EMAIL PROTECTED] wrote: On Wed, Apr 30, 2008 at 12:19:51PM +0200, Jim Meyering wrote: Unfortunately, the above no longer applies, due to upstream (gnulib) changes to deal with non-srcdir (aka VPATH) builds. I updated libvirt from gnulib just yesterday, and will again, later

Re: [Libvir] make syntax-check fails with bzr checkouts

2008-04-30 Thread Soren Hansen
The bzr problem was obviously that vc-list-files didn't support bzr. Failing with CVS was caused by a bashism in vc-list-files. In Ubuntu, /bin/sh points to dash instead of bash, but vc-list-files had #!/bin/sh. This patch fixes both issues: === modified file 'build-aux/vc-list-files' ---

Re: [Libvir] make syntax-check fails with bzr checkouts

2008-04-30 Thread Jim Meyering
Soren Hansen [EMAIL PROTECTED] wrote: The bzr problem was obviously that vc-list-files didn't support bzr. Failing with CVS was caused by a bashism in vc-list-files. In Ubuntu, /bin/sh points to dash instead of bash, but vc-list-files had #!/bin/sh. This patch fixes both issues: Hi Soren,

Re: [Libvir] make syntax-check fails with bzr checkouts

2008-04-30 Thread Soren Hansen
On Wed, Apr 30, 2008 at 12:19:51PM +0200, Jim Meyering wrote: Unfortunately, the above no longer applies, due to upstream (gnulib) changes to deal with non-srcdir (aka VPATH) builds. I updated libvirt from gnulib just yesterday, and will again, later today. Can you adapt your patch to make

Re: [Libvir] make syntax-check fails with bzr checkouts

2008-04-30 Thread Jim Meyering
Soren Hansen [EMAIL PROTECTED] wrote: On Wed, Apr 30, 2008 at 12:19:51PM +0200, Jim Meyering wrote: Unfortunately, the above no longer applies, due to upstream (gnulib) changes to deal with non-srcdir (aka VPATH) builds. I updated libvirt from gnulib just yesterday, and will again, later

Re: [Libvir] make syntax-check fails with bzr checkouts

2008-04-30 Thread Jim Meyering
Soren Hansen [EMAIL PROTECTED] wrote: ... Here's the patch I've pushed to gnulib: http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=173a9f0c48a16c3507f8 That patch will make the cvs case fail, too. It will prepend a ./ to all path names which will screw with the

[Libvir] make syntax-check fails with bzr checkouts

2008-04-29 Thread Soren Hansen
I seem to be completely unable to get make syntax-checks to function properly with my bzr checkout of libvirt[1]. I've attached the output as as-is.txt. I tried adding hacking bzr support into vc-list-files (see vc-list-files-bzr.patch), but that didn't quite seem to do the trick, as you can see

Re: [Libvir] make syntax-check fails with bzr checkouts

2008-04-29 Thread Daniel Veillard
On Tue, Apr 29, 2008 at 05:11:59PM +0200, Soren Hansen wrote: I tried CVS, too, and that also fails (see cvs-syntax-check.log). weird Is it only meant to work with git? Really no, I only use CVS checkouts... Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/

Re: [Libvir] make syntax-check fails with bzr checkouts

2008-04-29 Thread Daniel P. Berrange
On Tue, Apr 29, 2008 at 05:11:59PM +0200, Soren Hansen wrote: I seem to be completely unable to get make syntax-checks to function properly with my bzr checkout of libvirt[1]. I've attached the output as as-is.txt. I tried adding hacking bzr support into vc-list-files (see