Re: [PATCH] Revert "spec: Simplify setting features off by default"

2020-10-28 Thread Andrea Bolognani
On Wed, 2020-10-28 at 16:55 -0400, Neal Gompa wrote: > On Tue, Oct 27, 2020 at 9:30 AM Andrea Bolognani wrote: > > On Tue, 2020-10-27 at 14:05 +0100, Andrea Bolognani wrote: [...] > > > Note that in this case I've removed > > > > > > # fuse is used to provide virtualized /proc for LXC > > >

Re: [PATCH] Revert "spec: Simplify setting features off by default"

2020-10-28 Thread Neal Gompa
On Tue, Oct 27, 2020 at 9:30 AM Andrea Bolognani wrote: > > On Tue, 2020-10-27 at 14:05 +0100, Andrea Bolognani wrote: > > I'm not convinced reverting this was the right call. > > > > The way RPM conditional macros work is that, if you have > > > > %{!?macro:value} > > > > that will expand to

Re: [PATCH] Revert "spec: Simplify setting features off by default"

2020-10-27 Thread Andrea Bolognani
On Tue, 2020-10-27 at 14:05 +0100, Andrea Bolognani wrote: > I'm not convinced reverting this was the right call. > > The way RPM conditional macros work is that, if you have > > %{!?macro:value} > > that will expand to 'value' if 'macro' is *not* defined, and to > nothing otherwise. So if

Re: [PATCH] Revert "spec: Simplify setting features off by default"

2020-10-27 Thread Andrea Bolognani
On Tue, 2020-10-27 at 11:07 +0100, Michal Privoznik wrote: > On 10/26/20 10:53 PM, Neal Gompa wrote: > > As it turns out, the rather complicated structure that is > > currently used for enabling or disabling features in the libvirt > > build does not cleanly map well to RPM's bcond feature. > > >

Re: [PATCH] Revert "spec: Simplify setting features off by default"

2020-10-27 Thread Michal Privoznik
On 10/26/20 10:53 PM, Neal Gompa wrote: As it turns out, the rather complicated structure that is currently used for enabling or disabling features in the libvirt build does not cleanly map well to RPM's bcond feature. Consequently, we need these back in order to support trivially activating

[PATCH] Revert "spec: Simplify setting features off by default"

2020-10-26 Thread Neal Gompa
As it turns out, the rather complicated structure that is currently used for enabling or disabling features in the libvirt build does not cleanly map well to RPM's bcond feature. Consequently, we need these back in order to support trivially activating these features through extra macros as build