Re: [PATCH] meson: tools: depend on keycode generated sources

2021-03-05 Thread Roman Bogorodskiy
Andrea Bolognani wrote: > On Fri, 2021-03-05 at 13:43 +0100, Ján Tomko wrote: > > On a Friday in 2021, Andrea Bolognani wrote: > > > On Thu, 2021-03-04 at 17:47 +0100, Ján Tomko wrote: > > > > On a Wednesday in 2021, Roman Bogorodskiy wrote: > > > > > +keycode_dep = declare_dependency(sources:

Re: [PATCH] meson: tools: depend on keycode generated sources

2021-03-05 Thread Andrea Bolognani
On Fri, 2021-03-05 at 13:43 +0100, Ján Tomko wrote: > On a Friday in 2021, Andrea Bolognani wrote: > > On Thu, 2021-03-04 at 17:47 +0100, Ján Tomko wrote: > > > On a Wednesday in 2021, Roman Bogorodskiy wrote: > > > > +keycode_dep = declare_dependency(sources: keycode_gen_sources) > > > > > >

Re: [PATCH] meson: tools: depend on keycode generated sources

2021-03-05 Thread Ján Tomko
On a Friday in 2021, Andrea Bolognani wrote: On Thu, 2021-03-04 at 17:47 +0100, Ján Tomko wrote: On a Wednesday in 2021, Roman Bogorodskiy wrote: > +keycode_dep = declare_dependency(sources: keycode_gen_sources) Please format this as: keycode_dep = declare_dependency( sources:

Re: [PATCH] meson: tools: depend on keycode generated sources

2021-03-05 Thread Andrea Bolognani
On Thu, 2021-03-04 at 17:47 +0100, Ján Tomko wrote: > On a Wednesday in 2021, Roman Bogorodskiy wrote: > > +keycode_dep = declare_dependency(sources: keycode_gen_sources) > > Please format this as: > > keycode_dep = declare_dependency( >sources: keycode_gen_sources > ) > > to match the

Re: [PATCH] meson: tools: depend on keycode generated sources

2021-03-04 Thread Ján Tomko
On a Wednesday in 2021, Roman Bogorodskiy wrote: Tools depend on keycode generated sources, so declare that as an explicit dependency, otherwise it might fail with: ../tools/virsh-completer-domain.c:35:10: fatal error: 'virkeynametable_linux.h' file not found ^

[PATCH] meson: tools: depend on keycode generated sources

2021-03-02 Thread Roman Bogorodskiy
Tools depend on keycode generated sources, so declare that as an explicit dependency, otherwise it might fail with: ../tools/virsh-completer-domain.c:35:10: fatal error: 'virkeynametable_linux.h' file not found ^ Signed-off-by: Roman Bogorodskiy --- I noticed