Re: [PATCH] qemuDomainAttachRedirdevDevice: Remove need_release variable

On 2/3/21 7:18 AM, Yi Li wrote: Get rid of the 'need_release' variable. Signed-off-by: Yi Li --- src/qemu/qemu_hotplug.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Michal Privoznik and pushed. Michal

Re: [PATCH] qemuDomainAttachRedirdevDevice: Remove need_release variable

On 2/3/21 3:18 AM, Yi Li wrote: Get rid of the 'need_release' variable. Signed-off-by: Yi Li --- Good catch. The bool was being used simply as a way to tell the cleanup code 'do not release the address if we fail before this point'. Might as well just "return -1" in these cases and

[PATCH] qemuDomainAttachRedirdevDevice: Remove need_release variable

Get rid of the 'need_release' variable. Signed-off-by: Yi Li --- src/qemu/qemu_hotplug.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 882e5d2384..e07dba3c5e 100644 --- a/src/qemu/qemu_hotplug.c +++