Re: [PATCH] qemuDomainDeviceNetDefPostParse: Switch order of conditions

2020-06-25 Thread Daniel P . Berrangé
On Thu, Jun 25, 2020 at 03:54:18PM +0200, Michal Privoznik wrote: > On 6/25/20 10:38 AM, Daniel P. Berrangé wrote: > > On Thu, Jun 25, 2020 at 09:48:56AM +0200, Michal Privoznik wrote: > > > A few commits back (in v6.4.0-131-gbdb8f2e418) the post parse > > > function for domain interface was

Re: [PATCH] qemuDomainDeviceNetDefPostParse: Switch order of conditions

2020-06-25 Thread Michal Privoznik
On 6/25/20 10:38 AM, Daniel P. Berrangé wrote: On Thu, Jun 25, 2020 at 09:48:56AM +0200, Michal Privoznik wrote: A few commits back (in v6.4.0-131-gbdb8f2e418) the post parse function for domain interface was changed so that it doesn't fill in model for hostdev types of interfaces (including

Re: [PATCH] qemuDomainDeviceNetDefPostParse: Switch order of conditions

2020-06-25 Thread Laine Stump
On 6/25/20 3:48 AM, Michal Privoznik wrote: A few commits back (in v6.4.0-131-gbdb8f2e418) the post parse function for domain interface was changed so that it doesn't fill in model for hostdev types of interfaces (including network type interfaces which would end up hostdevs). While the idea is

Re: [PATCH] qemuDomainDeviceNetDefPostParse: Switch order of conditions

2020-06-25 Thread Daniel P . Berrangé
On Thu, Jun 25, 2020 at 09:48:56AM +0200, Michal Privoznik wrote: > A few commits back (in v6.4.0-131-gbdb8f2e418) the post parse > function for domain interface was changed so that it doesn't fill > in model for hostdev types of interfaces (including network type > interfaces which would end up

[PATCH] qemuDomainDeviceNetDefPostParse: Switch order of conditions

2020-06-25 Thread Michal Privoznik
A few commits back (in v6.4.0-131-gbdb8f2e418) the post parse function for domain interface was changed so that it doesn't fill in model for hostdev types of interfaces (including network type interfaces which would end up hostdevs). While the idea is sound, the execution can be a bit better: