Re: [PATCH] the leading space in volmode check will never match the leading tab output from zfs get

2020-10-09 Thread Michal Privoznik
On 10/2/20 4:42 PM, Daniel Henrique Barboza wrote: The code is ok but the commit message can be improved. Usually we want a commit title with a single-line summary of what you're changing, a blank line, and a description describes in more the change, and your signed-off tag. This guideline can

Re: [PATCH] the leading space in volmode check will never match the leading tab output from zfs get

2020-10-02 Thread Daniel Henrique Barboza
The code is ok but the commit message can be improved. Usually we want a commit title with a single-line summary of what you're changing, a blank line, and a description describes in more the change, and your signed-off tag. This guideline can be found here:

[PATCH] the leading space in volmode check will never match the leading tab output from zfs get

2020-09-24 Thread richardburakowski
Signed-off-by: Richard Burakowski --- src/storage/storage_backend_zfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index dc692f47ed..439f5b2fd5 100644 --- a/src/storage/storage_backend_zfs.c +++